Ver código fonte

Merge pull request #332 from FGA-GCES/fix/default-target-secret-name

fix: use external secret name if target secret is not specified
paul-the-alien[bot] 4 anos atrás
pai
commit
013e2ea191

+ 7 - 1
pkg/controllers/externalsecret/externalsecret_controller.go

@@ -167,9 +167,15 @@ func (r *Reconciler) Reconcile(ctx context.Context, req ctrl.Request) (ctrl.Resu
 		return ctrl.Result{RequeueAfter: refreshInt}, nil
 	}
 
+	// Target Secret Name should default to the ExternalSecret name if not explicitly specified
+	secretName := externalSecret.Spec.Target.Name
+	if secretName == "" {
+		secretName = externalSecret.ObjectMeta.Name
+	}
+
 	secret := &v1.Secret{
 		ObjectMeta: metav1.ObjectMeta{
-			Name:      externalSecret.Spec.Target.Name,
+			Name:      secretName,
 			Namespace: externalSecret.Namespace,
 		},
 		Data: make(map[string][]byte),