Browse Source

Updated validation for akeyless to catch invalid URLs and emtpy accessID name and keys

Signed-off-by: Idowu Emehinola <hydeenoble39@gmail.com>
Idowu Emehinola 4 years ago
parent
commit
022f5aaf6f
2 changed files with 3 additions and 8 deletions
  1. 0 8
      pkg/provider/akeyless/akeyless.go
  2. 3 0
      pkg/provider/akeyless/utils.go

+ 0 - 8
pkg/provider/akeyless/akeyless.go

@@ -40,13 +40,6 @@ var _ esv1beta1.Provider = &Provider{}
 // Provider satisfies the provider interface.
 type Provider struct{}
 
-// List of error messages.
-const (
-	errInvalidAkeylessURL          = "invalid akeyless GW API URL"
-	errInvalidAkeylessAccessIDName = "missing akeyless accessID name"
-	errInvalidAkeylessAccessIDKey  = "missing akeyless accessID key"
-)
-
 // akeylessBase satisfies the provider.SecretsClient interface.
 type akeylessBase struct {
 	kube      client.Client
@@ -85,7 +78,6 @@ func (p *Provider) ValidateStore(store esv1beta1.GenericStore) error {
 	akeylessGWApiURL := *akeylessSpec.AkeylessGWApiURL
 
 	if akeylessGWApiURL != "" {
-
 		url, err := url.Parse(akeylessGWApiURL)
 		if err != nil {
 			return fmt.Errorf(errInvalidAkeylessURL)

+ 3 - 0
pkg/provider/akeyless/utils.go

@@ -31,6 +31,9 @@ const (
 	errInvalidProvider              = "invalid provider spec. Missing Akeyless field in store %s"
 	errJSONSecretUnmarshal          = "unable to unmarshal secret: %w"
 	errUninitalizedAkeylessProvider = "provider akeyless is not initialized"
+	errInvalidAkeylessURL          = "invalid akeyless GW API URL"
+	errInvalidAkeylessAccessIDName = "missing akeyless accessID name"
+	errInvalidAkeylessAccessIDKey  = "missing akeyless accessID key"
 )
 
 // GetAKeylessProvider does the necessary nil checks and returns the akeyless provider or an error.