Просмотр исходного кода

feat: reduce default store requeue interval

Moritz Johner 1 месяц назад
Родитель
Сommit
092febf5e4
2 измененных файлов с 31 добавлено и 1 удалено
  1. 1 1
      cmd/controller/root.go
  2. 30 0
      cmd/controller/root_test.go

+ 1 - 1
cmd/controller/root.go

@@ -417,7 +417,7 @@ func init() {
 		true,
 		"Enable a direct API read when the partial Secret cache and managed Secret cache disagree. Disable to rely on cache retry only.",
 	)
-	rootCmd.Flags().DurationVar(&storeRequeueInterval, "store-requeue-interval", time.Minute*5, "Default Time duration between reconciling (Cluster)SecretStores")
+	rootCmd.Flags().DurationVar(&storeRequeueInterval, "store-requeue-interval", 30*time.Second, "Default Time duration between reconciling (Cluster)SecretStores")
 	rootCmd.Flags().BoolVar(&enableFloodGate, "enable-flood-gate", true, "Enable flood gate. External secret will be reconciled only if the ClusterStore or Store have an healthy or unknown state.")
 	rootCmd.Flags().BoolVar(&enableGeneratorState, "enable-generator-state", true, "Whether the Controller should manage GeneratorState")
 	rootCmd.Flags().BoolVar(&enableExtendedMetricLabels, "enable-extended-metric-labels", false, "Enable recommended kubernetes annotations as labels in metrics.")

+ 30 - 0
cmd/controller/root_test.go

@@ -0,0 +1,30 @@
+/*
+Copyright © The ESO Authors
+
+Licensed under the Apache License, Version 2.0 (the "License");
+you may not use this file except in compliance with the License.
+You may obtain a copy of the License at
+
+    https://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing, software
+distributed under the License is distributed on an "AS IS" BASIS,
+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+See the License for the specific language governing permissions and
+limitations under the License.
+*/
+
+package controller
+
+import "testing"
+
+func TestStoreRequeueIntervalDefault(t *testing.T) {
+	flag := rootCmd.Flags().Lookup("store-requeue-interval")
+	if flag == nil {
+		t.Fatal("store-requeue-interval flag not found")
+	}
+
+	if flag.DefValue != "30s" {
+		t.Fatalf("expected store-requeue-interval default 30s, got %q", flag.DefValue)
+	}
+}