test(e2e): scope aws v2 find secret names

e2e/suites/provider/cases/aws/secretsmanager/provider_support_test.go

@@ -19,6 +19,8 @@ package aws
 import (
 	"context"
 	"errors"
+	"os"
+	"strings"
 	"testing"
 
 	"github.com/aws/aws-sdk-go-v2/aws"
@@ -208,3 +210,22 @@ func TestIsAssumeRoleAccessDeniedRecognizesSTSAccessDeniedErrors(t *testing.T) {
 		t.Fatal("expected sts access denied error to be recognized")
 	}
 }
+
+func TestProviderV2FindSuiteUsesScopedRemoteSecretNames(t *testing.T) {
+	t.Parallel()
+
+	content, err := os.ReadFile("provider_v2.go")
+	if err != nil {
+		t.Fatalf("read provider_v2.go: %v", err)
+	}
+
+	for _, required := range []string{
+		`f.MakeRemoteRefKey("aws-v2-find-one")`,
+		`f.MakeRemoteRefKey("aws-v2-find-two")`,
+		`f.MakeRemoteRefKey("aws-v2-ignore")`,
+	} {
+		if !strings.Contains(string(content), required) {
+			t.Fatalf("expected AWS v2 find suite to include %q", required)
+		}
+	}
+}

e2e/suites/provider/cases/aws/secretsmanager/provider_v2.go

@@ -69,17 +69,20 @@ var _ = Describe("[aws] v2 namespaced provider", Label("aws", "secretsmanager",
 			})
 		}, useV2StaticAuth(prov)),
 		framework.Compose(withStaticAuth, f, func(f *framework.Framework) (string, func(*framework.TestCase)) {
+			findOne := f.MakeRemoteRefKey("aws-v2-find-one")
+			findTwo := f.MakeRemoteRefKey("aws-v2-find-two")
+			ignored := f.MakeRemoteRefKey("aws-v2-ignore")
 			return common.NamespacedProviderFind(f, common.NamespacedProviderFindConfig{
 				Description:        "[aws] should sync ExternalSecret dataFrom.find through a namespaced Provider",
 				ExternalSecretName: "aws-v2-find-es",
 				TargetSecretName:   "aws-v2-find-target",
-				MatchRegExp:        "^aws-v2-find-(one|two)$",
+				MatchRegExp:        fmt.Sprintf("^(%s|%s)$", findOne, findTwo),
 				MatchingSecrets: map[string]string{
-					"aws-v2-find-one": "aws-v2-one",
-					"aws-v2-find-two": "aws-v2-two",
+					findOne: "aws-v2-one",
+					findTwo: "aws-v2-two",
 				},
 				IgnoredSecrets: map[string]string{
-					"aws-v2-ignore": "aws-v2-ignore",
+					ignored: "aws-v2-ignore",
 				},
 			})
 		}, useV2StaticAuth(prov)),