Browse Source

flip order of `err` and nil `secret` variable check in `listSecrets()` function of vault provider (#1504)

Signed-off-by: Marcel Hoyer <mhoyer@pixelplastic.de>
Marcel Hoyer 3 years ago
parent
commit
17ece4df8f
1 changed files with 3 additions and 3 deletions
  1. 3 3
      pkg/provider/vault/vault.go

+ 3 - 3
pkg/provider/vault/vault.go

@@ -429,12 +429,12 @@ func (v *client) listSecrets(ctx context.Context, path string) ([]string, error)
 		return nil, err
 	}
 	secret, err := v.logical.ListWithContext(ctx, url)
-	if secret == nil {
-		return nil, fmt.Errorf("provided path %v does not contain any secrets", url)
-	}
 	if err != nil {
 		return nil, fmt.Errorf(errReadSecret, err)
 	}
+	if secret == nil {
+		return nil, fmt.Errorf("provided path %v does not contain any secrets", url)
+	}
 	t, ok := secret.Data["keys"]
 	if !ok {
 		return nil, nil