Просмотр исходного кода

Fix null pointer dereference in text with Recorder fake

Signed-off-by: Dominic Meddick <dominic.meddick@engineerbetter.com>
Co-authored-by: Amr Fawzy <amr.fawzy@container-solutions.com>
James Cleveland 4 лет назад
Родитель
Сommit
1e51dfec4d

+ 12 - 0
pkg/controllers/pushsecret/internal/fakes/recorder.go

@@ -0,0 +1,12 @@
+package fakes
+
+import "k8s.io/apimachinery/pkg/runtime"
+
+type FakeRecorder struct {
+}
+
+func (r FakeRecorder) Event(object runtime.Object, eventtype string, reason string, message string) {}
+func (r FakeRecorder) Eventf(object runtime.Object, eventtype, reason, messageFmt string, args ...interface{}) {
+}
+func (r FakeRecorder) AnnotatedEventf(object runtime.Object, annotations map[string]string, eventtype, reason, messageFmt string, args ...interface{}) {
+}

+ 3 - 1
pkg/controllers/pushsecret/pushsecret_controller_test.go

@@ -39,10 +39,12 @@ var _ = Describe("pushsecret", func() {
 	var (
 		reconciler *Reconciler
 		client     *fakes.Client
+		recorder   *fakes.FakeRecorder
 	)
 	BeforeEach(func() {
 		client = new(fakes.Client)
-		reconciler = &Reconciler{client, logr.Discard(), nil, nil, 0, ""}
+		recorder = &fakes.FakeRecorder{}
+		reconciler = &Reconciler{client, logr.Discard(), nil, recorder, 0, ""}
 	})
 	Describe("#Reconcile", func() {
 		var (