Browse Source

fix: error strings

Lucas Severo Alves 4 years ago
parent
commit
21df9b5729

+ 0 - 2
deploy/crds/external-secrets.io_clustersecretstores.yaml

@@ -279,8 +279,6 @@ spec:
                                       cluster-scoped defaults to the namespace of
                                       the referent.
                                     type: string
-                                required:
-                                - name
                                 type: object
                             type: object
                         required:

+ 0 - 2
deploy/crds/external-secrets.io_secretstores.yaml

@@ -279,8 +279,6 @@ spec:
                                       cluster-scoped defaults to the namespace of
                                       the referent.
                                     type: string
-                                required:
-                                - name
                                 type: object
                             type: object
                         required:

+ 3 - 4
pkg/provider/gitlab/gitlab.go

@@ -35,11 +35,10 @@ import (
 // Requires GITLAB_TOKEN and GITLAB_PROJECT_ID to be set in environment variables
 
 const (
-	// TODO: Make these more descriptive.
-	errGitlabCredSecretName                   = "error with credentials"
-	errInvalidClusterStoreMissingSAKNamespace = "error"
+	errGitlabCredSecretName                   = "credentials are empty"
+	errInvalidClusterStoreMissingSAKNamespace = "invalid clusterStore missing SAK namespace"
 	errFetchSAKSecret                         = "couldn't find secret on cluster: %w"
-	errMissingSAK                             = "error"
+	errMissingSAK                             = "missing credentials while setting auth"
 	errUninitalizedGitlabProvider             = "provider gitlab is not initialized"
 	errJSONSecretUnmarshal                    = "unable to unmarshal secret: %w"
 )