Browse Source

Stop ignoring ExternalSecret reconciliation error (#2583)

Signed-off-by: shuheiktgw <s-kitagawa@mercari.com>
Shuhei Kitagawa 2 years ago
parent
commit
3164df0c08
1 changed files with 2 additions and 1 deletions
  1. 2 1
      pkg/controllers/externalsecret/externalsecret_controller.go

+ 2 - 1
pkg/controllers/externalsecret/externalsecret_controller.go

@@ -127,7 +127,7 @@ func (r *Reconciler) Reconcile(ctx context.Context, req ctrl.Request) (ctrl.Resu
 		log.Error(err, errGetES)
 		log.Error(err, errGetES)
 		syncCallsError.With(resourceLabels).Inc()
 		syncCallsError.With(resourceLabels).Inc()
 
 
-		return ctrl.Result{}, nil
+		return ctrl.Result{}, err
 	}
 	}
 
 
 	// if extended metrics is enabled, refine the time series vector
 	// if extended metrics is enabled, refine the time series vector
@@ -164,6 +164,7 @@ func (r *Reconciler) Reconcile(ctx context.Context, req ctrl.Request) (ctrl.Resu
 	}, &existingSecret)
 	}, &existingSecret)
 	if err != nil && !apierrors.IsNotFound(err) {
 	if err != nil && !apierrors.IsNotFound(err) {
 		log.Error(err, errGetExistingSecret)
 		log.Error(err, errGetExistingSecret)
+		return ctrl.Result{}, err
 	}
 	}
 
 
 	// refresh should be skipped if
 	// refresh should be skipped if