Browse Source

Fix: add coversion hook to steps to disable webhook (#4453)

* Fix: add coversion hook to steps to disable webhook

Signed-off-by: Matías Arranz García <74046491+matt-matt-tmatt@users.noreply.github.com>

* Fix typo

Signed-off-by: Matías Arranz García <74046491+matt-matt-tmatt@users.noreply.github.com>

---------

Signed-off-by: Matías Arranz García <74046491+matt-matt-tmatt@users.noreply.github.com>
Co-authored-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>
Matías Arranz García 1 year ago
parent
commit
41e4fd48d2
1 changed files with 2 additions and 3 deletions
  1. 2 3
      docs/api/components.md

+ 2 - 3
docs/api/components.md

@@ -12,14 +12,13 @@ Exernal Secrets comes with three components: `Core Controller`, `Webhook` and `C
 This is due to the need to implement conversion webhooks in order to convert custom resources between api versions and
 This is due to the need to implement conversion webhooks in order to convert custom resources between api versions and
 to provide a ValidatingWebhook for the `ExternalSecret` and `SecretStore` resources.
 to provide a ValidatingWebhook for the `ExternalSecret` and `SecretStore` resources.
 
 
-These features are optional but highly recommended. You can disable them with helm chart values `certController.create=false` and `webhook.create=false`.
+These features are optional but highly recommended. You can disable them with helm chart values `certController.create=false`, `webhook.create=false` and `crds.conversion.enabled=false`.
 
 
 <br/>
 <br/>
 ![Component Overview](../pictures/diagrams-component-overview.png)
 ![Component Overview](../pictures/diagrams-component-overview.png)
 
 
-
 ### TLS Bootstrap
 ### TLS Bootstrap
 
 
 Cert-controller is responsible for (1) generating TLS credentials which will be used by the webhook component and (2) injecting the certificate as `caBundle` into `Kind=CustomResourceDefinition` for conversion webhooks and `Kind=ValidatingWebhookConfiguration` for validating admission webhook. The TLS credentials are stored in a `Kind=Secret` which is consumed by the webhook.
 Cert-controller is responsible for (1) generating TLS credentials which will be used by the webhook component and (2) injecting the certificate as `caBundle` into `Kind=CustomResourceDefinition` for conversion webhooks and `Kind=ValidatingWebhookConfiguration` for validating admission webhook. The TLS credentials are stored in a `Kind=Secret` which is consumed by the webhook.
 
 
-![](../pictures/eso-threat-model-TLS%20Bootstrap.drawio.png){: style="width:70%;"}
+![](../pictures/eso-threat-model-TLS%20Bootstrap.drawio.png){: style="width:70%;"}