Browse Source

WiP: no target name unit test

Mateus Oliveira Patrício 4 years ago
parent
commit
42a658c2b1
1 changed files with 11 additions and 0 deletions
  1. 11 0
      pkg/controllers/externalsecret/externalsecret_controller_test.go

+ 11 - 0
pkg/controllers/externalsecret/externalsecret_controller_test.go

@@ -223,6 +223,16 @@ var _ = Describe("ExternalSecret controller", func() {
 		}
 		}
 	}
 	}
 
 
+	// if target Secret name is not specified it should use the ExternalSecret name.
+	syncWithoutTargetName := func(tc *testCase) {
+		tc.externalSecret.Spec.Target.Name = ""
+		tc.checkSecret = func(es *esv1alpha1.ExternalSecret, secret *v1.Secret) {
+
+			// check secret name
+			Expect(string(secret.ObjectMeta.Name)).To(Equal(ExternalSecretName))
+		}
+	}
+
 	// labels and annotations from the Kind=ExternalSecret
 	// labels and annotations from the Kind=ExternalSecret
 	// should be copied over to the Kind=Secret
 	// should be copied over to the Kind=Secret
 	syncLabelsAnnotations := func(tc *testCase) {
 	syncLabelsAnnotations := func(tc *testCase) {
@@ -911,6 +921,7 @@ var _ = Describe("ExternalSecret controller", func() {
 		Entry("should recreate deleted secret", checkDeletion),
 		Entry("should recreate deleted secret", checkDeletion),
 		Entry("should create proper hash annotation for the external secret", checkSecretDataHashAnnotation),
 		Entry("should create proper hash annotation for the external secret", checkSecretDataHashAnnotation),
 		Entry("should refresh when the hash annotation doesn't correspond to secret data", checkSecretDataHashAnnotationChange),
 		Entry("should refresh when the hash annotation doesn't correspond to secret data", checkSecretDataHashAnnotationChange),
+		Entry("should use external secret name if target secret name isn't defined", syncWithoutTargetName),
 		Entry("should set the condition eventually", syncLabelsAnnotations),
 		Entry("should set the condition eventually", syncLabelsAnnotations),
 		Entry("should set prometheus counters", checkPrometheusCounters),
 		Entry("should set prometheus counters", checkPrometheusCounters),
 		Entry("should merge with existing secret using creationPolicy=Merge", mergeWithSecret),
 		Entry("should merge with existing secret using creationPolicy=Merge", mergeWithSecret),