Эх сурвалжийг харах

WIP: Fixed bug not returning error

Signed-off-by: James Cleveland <james.cleveland@engineerbetter.com>
Co-authored-by: Amr Fawzy <amr.fawzy@container-solutions.com>
Dominic Meddick 4 жил өмнө
parent
commit
4761591cda

+ 1 - 0
pkg/controllers/pushsecret/pushsecret_controller.go

@@ -84,6 +84,7 @@ func (r *Reconciler) Reconcile(ctx context.Context, req ctrl.Request) (ctrl.Resu
 		cond := NewPushSecretCondition(esapi.PushSecretReady, v1.ConditionFalse, esapi.ReasonErrored, err.Error())
 		cond := NewPushSecretCondition(esapi.PushSecretReady, v1.ConditionFalse, esapi.ReasonErrored, err.Error())
 		ss = SetPushSecretCondition(ss, *cond)
 		ss = SetPushSecretCondition(ss, *cond)
 		r.recorder.Event(&ss, v1.EventTypeWarning, esapi.ReasonErrored, err.Error())
 		r.recorder.Event(&ss, v1.EventTypeWarning, esapi.ReasonErrored, err.Error())
+		return ctrl.Result{}, err
 	}
 	}
 	err = r.SetSecretToProviders(ctx, secretStores, ss, secret)
 	err = r.SetSecretToProviders(ctx, secretStores, ss, secret)
 	if err != nil {
 	if err != nil {