fix: update the e2e test with the new store status value (#5089)

* fix: update the e2e test with the new store status value

Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>

* add argo server side apply option

Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>

* fix tab character instead of spaces :facepalm:

Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>

* add replace true for CRD updates

Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>

* increase arcocd version and remove replace

Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>

---------

Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>
Co-authored-by: Idan Adar <iadar@il.ibm.com>

e2e/framework/addon/eso_argocd_application.go

@@ -68,6 +68,7 @@ spec:
       selfHeal: true
     syncOptions:
     - CreateNamespace=true
+    - ServerSideApply=true
   source:
     chart: %s
     repoURL: %s

e2e/suites/argocd/install.go

@@ -34,7 +34,7 @@ func installArgo(cfg *addon.Config) {
 		Namespace:    "argocd",
 		ReleaseName:  "argocd",
 		Chart:        "argo-cd/argo-cd",
-		ChartVersion: "3.35.4",
+		ChartVersion: "8.2.5",
 		Repo: addon.ChartRepo{
 			Name: "argo-cd",
 			URL:  "https://argoproj.github.io/argo-helm",

e2e/suites/provider/cases/vault/vault.go

@@ -292,7 +292,7 @@ func testInvalidMtlsStore(tc *framework.TestCase) {
 		}
 		Expect(string(ss.Status.Conditions[0].Type)).Should(Equal("Ready"))
 		Expect(string(ss.Status.Conditions[0].Status)).Should(Equal("False"))
-		Expect(ss.Status.Conditions[0].Reason).Should(Equal("ValidationFailed"))
+		Expect(ss.Status.Conditions[0].Reason).Should(Equal("InvalidProviderConfig"))
 		Expect(ss.Status.Conditions[0].Message).Should(ContainSubstring("unable to validate store"))
 		return true, nil
 	})