Removing Key checks from utils.go and passing them to IBM provider

Signed-off-by: Gustavo Carvalho <gustavo.carvalho@container-solutions.com>

pkg/provider/ibm/provider.go

@@ -332,6 +332,12 @@ func (ibm *providerIBM) ValidateStore(store esv1beta1.GenericStore) error {
 	if err != nil {
 		return err
 	}
+	if secretRef.Name == "" {
+		return fmt.Errorf("secretAPIKey.name cannot be empty")
+	}
+	if secretRef.Key == "" {
+		return fmt.Errorf("secretAPIKey.key cannot be empty")
+	}
 	return nil
 }
 

pkg/provider/ibm/provider_test.go

@@ -136,7 +136,7 @@ func TestValidateStore(t *testing.T) {
 	err = p.ValidateStore(store)
 	if err == nil {
 		t.Errorf(errExpectedErr)
-	} else if err.Error() != "secret name is required" {
+	} else if err.Error() != "secretAPIKey.name cannot be empty" {
 		t.Errorf("KeySelector test failed: expected secret name is required, got %v", err)
 	}
 	store.Spec.Provider.IBM.Auth.SecretRef.SecretAPIKey.Name = "foo"

pkg/utils/utils.go

@@ -110,12 +110,6 @@ func ErrorContains(out error, want string) bool {
 // We MUST NOT check the name or key property here. It MAY be defaulted by the provider.
 func ValidateSecretSelector(store esv1beta1.GenericStore, ref esmeta.SecretKeySelector) error {
 	clusterScope := store.GetObjectKind().GroupVersionKind().Kind == esv1beta1.ClusterSecretStoreKind
-	if ref.Name == "" {
-		return fmt.Errorf("secret name is required")
-	}
-	if ref.Key == "" {
-		return fmt.Errorf("secret key is required")
-	}
 	if clusterScope && ref.Namespace == nil {
 		return fmt.Errorf("cluster scope requires namespace")
 	}