Browse Source

lint + pass final test

William Young 4 years ago
parent
commit
77265b76f6

+ 1 - 2
pkg/provider/aws/secretsmanager/secretsmanager.go

@@ -116,7 +116,7 @@ func (sm *SecretsManager) SetSecret(ctx context.Context, value []byte, remoteRef
 	managedBy := "managed-by"
 	managedBy := "managed-by"
 	externalSecrets := "external-secrets"
 	externalSecrets := "external-secrets"
 	externalSecretsTag := []*awssm.Tag{
 	externalSecretsTag := []*awssm.Tag{
-		&awssm.Tag{
+		{
 			Key:   &managedBy,
 			Key:   &managedBy,
 			Value: &externalSecrets,
 			Value: &externalSecrets,
 		},
 		},
@@ -150,7 +150,6 @@ func (sm *SecretsManager) SetSecret(ctx context.Context, value []byte, remoteRef
 				return fmt.Errorf("secret not managed by external-secrets")
 				return fmt.Errorf("secret not managed by external-secrets")
 			}
 			}
 		}
 		}
-
 	}
 	}
 TAGGED:
 TAGGED:
 	if awsSecret != nil && reflect.DeepEqual(awsSecret.SecretBinary, secretRequest.SecretBinary) {
 	if awsSecret != nil && reflect.DeepEqual(awsSecret.SecretBinary, secretRequest.SecretBinary) {

+ 3 - 3
pkg/provider/aws/secretsmanager/secretsmanager_test.go

@@ -344,14 +344,14 @@ func TestSetSecret(t *testing.T) {
 	}
 	}
 
 
 	externalSecretsTag := []*awssm.Tag{
 	externalSecretsTag := []*awssm.Tag{
-		&awssm.Tag{
+		{
 			Key:   &managedBy,
 			Key:   &managedBy,
 			Value: &externalSecrets,
 			Value: &externalSecrets,
 		},
 		},
 	}
 	}
 
 
 	externalSecretsTagFaulty := []*awssm.Tag{
 	externalSecretsTagFaulty := []*awssm.Tag{
-		&awssm.Tag{
+		{
 			Key:   &notManagedBy,
 			Key:   &notManagedBy,
 			Value: &externalSecrets,
 			Value: &externalSecrets,
 		},
 		},
@@ -510,7 +510,7 @@ func TestSetSecret(t *testing.T) {
 				},
 				},
 			},
 			},
 			want: want{
 			want: want{
-				err: noPermission,
+				err: fmt.Errorf("secret not managed by external-secrets"),
 			},
 			},
 		},
 		},
 	}
 	}