|
|
@@ -92,7 +92,7 @@ func nilProviderTestCase() *akeylessTestCase {
|
|
|
}
|
|
|
func failGetTestCase() *akeylessTestCase {
|
|
|
return makeValidAkeylessTestCase("fail GetSecret").SetExpectVal(false).SetExpectErr("fail get").
|
|
|
- SetMockClient(fakeakeyless.New().SetGetSecretFn(func(secretName string, version int32) (string, error) { return "", errors.New("fail get") }))
|
|
|
+ SetMockClient(fakeakeyless.New().SetGetSecretFn(func(_ string, _ int32) (string, error) { return "", errors.New("fail get") }))
|
|
|
}
|
|
|
|
|
|
func makeValidRef() *esv1.ExternalSecretDataRemoteRef {
|
|
|
@@ -308,16 +308,16 @@ func TestSecretExists(t *testing.T) {
|
|
|
testCases := []*akeylessTestCase{
|
|
|
nilProviderTestCase().SetExpectVal(false),
|
|
|
makeValidAkeylessTestCase("no secret").SetExpectVal(false).
|
|
|
- SetMockClient(fakeakeyless.New().SetGetSecretFn(func(secretName string, version int32) (string, error) { return "", ErrItemNotExists })),
|
|
|
+ SetMockClient(fakeakeyless.New().SetGetSecretFn(func(_ string, _ int32) (string, error) { return "", ErrItemNotExists })),
|
|
|
failGetTestCase(),
|
|
|
makeValidAkeylessTestCase("success without property").SetExpectVal(true).SetExpectInput(&testingfake.PushSecretData{Property: ""}).
|
|
|
- SetMockClient(fakeakeyless.New().SetGetSecretFn(func(secretName string, version int32) (string, error) { return "my secret", nil })),
|
|
|
+ SetMockClient(fakeakeyless.New().SetGetSecretFn(func(_ string, _ int32) (string, error) { return "my secret", nil })),
|
|
|
makeValidAkeylessTestCase("fail unmarshal").SetExpectVal(false).SetExpectErr("invalid character 'd' looking for beginning of value").SetExpectInput(&testingfake.PushSecretData{Property: "prop"}).
|
|
|
- SetMockClient(fakeakeyless.New().SetGetSecretFn(func(secretName string, version int32) (string, error) { return "daenerys", nil })),
|
|
|
+ SetMockClient(fakeakeyless.New().SetGetSecretFn(func(_ string, _ int32) (string, error) { return "daenerys", nil })),
|
|
|
makeValidAkeylessTestCase("no property").SetExpectVal(false).SetExpectInput(&testingfake.PushSecretData{Property: "prop"}).
|
|
|
- SetMockClient(fakeakeyless.New().SetGetSecretFn(func(secretName string, version int32) (string, error) { return `{"propa": "a"}`, nil })),
|
|
|
+ SetMockClient(fakeakeyless.New().SetGetSecretFn(func(_ string, _ int32) (string, error) { return `{"propa": "a"}`, nil })),
|
|
|
makeValidAkeylessTestCase("success with property").SetExpectVal(true).SetExpectInput(&testingfake.PushSecretData{Property: "prop"}).
|
|
|
- SetMockClient(fakeakeyless.New().SetGetSecretFn(func(secretName string, version int32) (string, error) { return `{"prop": "a"}`, nil })),
|
|
|
+ SetMockClient(fakeakeyless.New().SetGetSecretFn(func(_ string, _ int32) (string, error) { return `{"prop": "a"}`, nil })),
|
|
|
}
|
|
|
|
|
|
sm := Akeyless{}
|
|
|
@@ -340,29 +340,29 @@ func TestPushSecret(t *testing.T) {
|
|
|
nilProviderTestCase(),
|
|
|
failGetTestCase(),
|
|
|
makeValidAkeylessTestCase("fail unmarshal").SetExpectErr("invalid character 'm' looking for beginning of value").
|
|
|
- SetMockClient(fakeakeyless.New().SetGetSecretFn(func(secretName string, version int32) (string, error) { return "morgoth", nil })),
|
|
|
+ SetMockClient(fakeakeyless.New().SetGetSecretFn(func(_ string, _ int32) (string, error) { return "morgoth", nil })),
|
|
|
makeValidAkeylessTestCase("create new secret").SetExpectInput(&corev1.Secret{Data: map[string][]byte{"test": []byte("test")}}).
|
|
|
- SetMockClient(fakeakeyless.New().SetGetSecretFn(func(secretName string, version int32) (string, error) { return "", ErrItemNotExists }).
|
|
|
- SetCreateSecretFn(func(ctx context.Context, remoteKey string, data string) error {
|
|
|
+ SetMockClient(fakeakeyless.New().SetGetSecretFn(func(_ string, _ int32) (string, error) { return "", ErrItemNotExists }).
|
|
|
+ SetCreateSecretFn(func(_ context.Context, _ string, data string) error {
|
|
|
if data != `{"test":"test"}` {
|
|
|
return errors.New("secret is not good")
|
|
|
}
|
|
|
return nil
|
|
|
})),
|
|
|
makeValidAkeylessTestCase("update secret").SetExpectInput(&corev1.Secret{Data: map[string][]byte{"test2": []byte("test2")}}).
|
|
|
- SetMockClient(fakeakeyless.New().SetGetSecretFn(func(secretName string, version int32) (string, error) { return `{"test2":"untest"}`, nil }).
|
|
|
- SetUpdateSecretFn(func(ctx context.Context, remoteKey string, data string) error {
|
|
|
+ SetMockClient(fakeakeyless.New().SetGetSecretFn(func(_ string, _ int32) (string, error) { return `{"test2":"untest"}`, nil }).
|
|
|
+ SetUpdateSecretFn(func(_ context.Context, _ string, data string) error {
|
|
|
if data != `{"test2":"test2"}` {
|
|
|
return errors.New("secret is not good")
|
|
|
}
|
|
|
return nil
|
|
|
})),
|
|
|
makeValidAkeylessTestCase("shouldnt update").SetExpectInput(&corev1.Secret{Data: map[string][]byte{"test": []byte("test")}}).
|
|
|
- SetMockClient(fakeakeyless.New().SetGetSecretFn(func(secretName string, version int32) (string, error) { return `{"test":"test"}`, nil })),
|
|
|
+ SetMockClient(fakeakeyless.New().SetGetSecretFn(func(_ string, _ int32) (string, error) { return `{"test":"test"}`, nil })),
|
|
|
makeValidAkeylessTestCase("merge secret maps").SetExpectInput(&corev1.Secret{Data: map[string][]byte{"test": []byte("test")}}).
|
|
|
SetExpectInput2(&testingfake.PushSecretData{Property: "test", SecretKey: "test"}).
|
|
|
- SetMockClient(fakeakeyless.New().SetGetSecretFn(func(secretName string, version int32) (string, error) { return `{"test2":"test2"}`, nil }).
|
|
|
- SetUpdateSecretFn(func(ctx context.Context, remoteKey string, data string) error {
|
|
|
+ SetMockClient(fakeakeyless.New().SetGetSecretFn(func(_ string, _ int32) (string, error) { return `{"test2":"test2"}`, nil }).
|
|
|
+ SetUpdateSecretFn(func(_ context.Context, _ string, data string) error {
|
|
|
expected := `{"test":"test","test2":"test2"}`
|
|
|
if data != expected {
|
|
|
return fmt.Errorf("secret %s expected %s", data, expected)
|
|
|
@@ -392,31 +392,31 @@ func TestDeleteSecret(t *testing.T) {
|
|
|
testCases := []*akeylessTestCase{
|
|
|
nilProviderTestCase(),
|
|
|
makeValidAkeylessTestCase("fail describe").SetExpectErr("err desc").
|
|
|
- SetMockClient(fakeakeyless.New().SetDescribeItemFn(func(ctx context.Context, itemName string) (*akeyless.Item, error) { return nil, errors.New("err desc") })),
|
|
|
+ SetMockClient(fakeakeyless.New().SetDescribeItemFn(func(_ context.Context, _ string) (*akeyless.Item, error) { return nil, errors.New("err desc") })),
|
|
|
makeValidAkeylessTestCase("no such item").
|
|
|
- SetMockClient(fakeakeyless.New().SetDescribeItemFn(func(ctx context.Context, itemName string) (*akeyless.Item, error) { return nil, nil })),
|
|
|
+ SetMockClient(fakeakeyless.New().SetDescribeItemFn(func(_ context.Context, _ string) (*akeyless.Item, error) { return nil, nil })),
|
|
|
makeValidAkeylessTestCase("tags nil").
|
|
|
- SetMockClient(fakeakeyless.New().SetDescribeItemFn(func(ctx context.Context, itemName string) (*akeyless.Item, error) { return &akeyless.Item{}, nil })),
|
|
|
+ SetMockClient(fakeakeyless.New().SetDescribeItemFn(func(_ context.Context, _ string) (*akeyless.Item, error) { return &akeyless.Item{}, nil })),
|
|
|
makeValidAkeylessTestCase("no external secret managed tags").
|
|
|
- SetMockClient(fakeakeyless.New().SetDescribeItemFn(func(ctx context.Context, itemName string) (*akeyless.Item, error) {
|
|
|
+ SetMockClient(fakeakeyless.New().SetDescribeItemFn(func(_ context.Context, _ string) (*akeyless.Item, error) {
|
|
|
return &akeyless.Item{ItemTags: &[]string{"some-random-tag"}}, nil
|
|
|
})),
|
|
|
makeValidAkeylessTestCase("delete whole secret").SetExpectInput(&testingfake.PushSecretData{RemoteKey: "42"}).
|
|
|
- SetMockClient(fakeakeyless.New().SetDescribeItemFn(func(ctx context.Context, itemName string) (*akeyless.Item, error) {
|
|
|
+ SetMockClient(fakeakeyless.New().SetDescribeItemFn(func(_ context.Context, _ string) (*akeyless.Item, error) {
|
|
|
return &akeyless.Item{ItemTags: &[]string{extSecretManagedTag}}, nil
|
|
|
- }).SetDeleteSecretFn(func(ctx context.Context, remoteKey string) error {
|
|
|
+ }).SetDeleteSecretFn(func(_ context.Context, remoteKey string) error {
|
|
|
if remoteKey != "42" {
|
|
|
return fmt.Errorf("remote key %s expected %s", remoteKey, "42")
|
|
|
}
|
|
|
return nil
|
|
|
})),
|
|
|
makeValidAkeylessTestCase("delete property of secret").SetExpectInput(&testingfake.PushSecretData{Property: "Foo"}).
|
|
|
- SetMockClient(fakeakeyless.New().SetDescribeItemFn(func(ctx context.Context, itemName string) (*akeyless.Item, error) {
|
|
|
+ SetMockClient(fakeakeyless.New().SetDescribeItemFn(func(_ context.Context, _ string) (*akeyless.Item, error) {
|
|
|
return &akeyless.Item{ItemTags: &[]string{extSecretManagedTag}}, nil
|
|
|
- }).SetGetSecretFn(func(secretName string, version int32) (string, error) {
|
|
|
+ }).SetGetSecretFn(func(_ string, _ int32) (string, error) {
|
|
|
return `{"Dio": "Brando", "Foo": "Fighters"}`, nil
|
|
|
}).
|
|
|
- SetUpdateSecretFn(func(ctx context.Context, remoteKey string, data string) error {
|
|
|
+ SetUpdateSecretFn(func(_ context.Context, _ string, data string) error {
|
|
|
expected := `{"Dio":"Brando"}`
|
|
|
if data != expected {
|
|
|
return fmt.Errorf("secret %s expected %s", data, expected)
|
|
|
@@ -424,12 +424,12 @@ func TestDeleteSecret(t *testing.T) {
|
|
|
return nil
|
|
|
})),
|
|
|
makeValidAkeylessTestCase("delete secret if one property left").SetExpectInput(&testingfake.PushSecretData{RemoteKey: "Rings", Property: "Annatar"}).
|
|
|
- SetMockClient(fakeakeyless.New().SetDescribeItemFn(func(ctx context.Context, itemName string) (*akeyless.Item, error) {
|
|
|
+ SetMockClient(fakeakeyless.New().SetDescribeItemFn(func(_ context.Context, _ string) (*akeyless.Item, error) {
|
|
|
return &akeyless.Item{ItemTags: &[]string{extSecretManagedTag}}, nil
|
|
|
- }).SetGetSecretFn(func(secretName string, version int32) (string, error) {
|
|
|
+ }).SetGetSecretFn(func(_ string, _ int32) (string, error) {
|
|
|
return `{"Annatar": "The Lord of Gifts"}`, nil
|
|
|
}).
|
|
|
- SetDeleteSecretFn(func(ctx context.Context, remoteKey string) error {
|
|
|
+ SetDeleteSecretFn(func(_ context.Context, remoteKey string) error {
|
|
|
if remoteKey != "Rings" {
|
|
|
return fmt.Errorf("remote key %s expected %s", remoteKey, "Annatar")
|
|
|
}
|