Browse Source

Merge pull request #761 from mbillow/fix-configmap-templates

Fix template fallback logic to handle TemplateFrom syntax
paul-the-alien[bot] 4 years ago
parent
commit
c9832b8e2a

+ 1 - 1
pkg/controllers/externalsecret/externalsecret_controller_template.go

@@ -67,7 +67,7 @@ func (r *Reconciler) applyTemplate(ctx context.Context, es *esv1beta1.ExternalSe
 
 
 	// if no data was provided by template fallback
 	// if no data was provided by template fallback
 	// to value from the provider
 	// to value from the provider
-	if len(es.Spec.Target.Template.Data) == 0 {
+	if len(es.Spec.Target.Template.Data) == 0 && len(es.Spec.Target.Template.TemplateFrom) == 0 {
 		secret.Data = dataMap
 		secret.Data = dataMap
 	}
 	}
 	secret.Annotations[esv1beta1.AnnotationDataHash] = utils.ObjectHash(secret.Data)
 	secret.Annotations[esv1beta1.AnnotationDataHash] = utils.ObjectHash(secret.Data)