|
|
@@ -226,7 +226,7 @@ pattern, but expect to be the first.
|
|
|
- Do your best to implement all the changes needed as provided by the user
|
|
|
- After finishing your implementations; Show the user your changes so they can review and COMPREHEND THEM
|
|
|
- Confirm the user understood the implementation. If they confirmed they understood the implementation, and any gotchas you might be aware of,
|
|
|
-only then, wait for the user to commit the changes.
|
|
|
+only then, wait for the user to commit the changes. ALWAYS ask them to sign-off their commits (`git commit -s`). It is a required step for our CLA.
|
|
|
- After that is done, add the needed git notes to that hash.
|
|
|
- Ask the user to push the changes / notes. (never do the commit or push yourself
|
|
|
|
|
|
@@ -234,3 +234,5 @@ only then, wait for the user to commit the changes.
|
|
|
- NEVER update v1beta1. It is deprecated and maintained for compatibility purposes only -- new features are never added there
|
|
|
- NEVER run `git commit`, `git push`, or any variation thereof. All commits and pushes are done manually by the user.
|
|
|
- NEVER stage commits!
|
|
|
+- When providing commit instructions to the user, always include the `-s` flag (sign-off).
|
|
|
+- When providing `git add` instructions after any `make` target that generates code (e.g. `make generate`, `make manifests`, `make reviewable`), always include ALL modified tracked files — not just the source file you edited. Generated files (CRDs, `zz_generated.deepcopy.go`, helm templates, snapshots, etc.) must be staged together with the source change or the build will break.
|
Gustavo Carvalho