Add Helm chart value that disables webhook secret creation (#2721)

Signed-off-by: Leonardo M. Miranda <leonardomichalskim@gmail.com>

deploy/charts/external-secrets/README.md

@@ -151,6 +151,7 @@ The command removes all the Kubernetes components associated with the chart and
 | webhook.affinity | object | `{}` |  |
 | webhook.certCheckInterval | string | `"5m"` | Specifices the time to check if the cert is valid |
 | webhook.certSecretNameOverride | string | `""` | If its value is different from the default one, it overrides the name of the secret resource where the webhook certificates are stored. |
+| webhook.createWebhookSecret | bool | `true` | Whether to create the webhook secret resource (doesn't interfere with `webhook.certManager.cert.create`). |
 | webhook.certDir | string | `"/tmp/certs"` |  |
 | webhook.certManager.addInjectorAnnotations | bool | `true` | Automatically add the cert-manager.io/inject-ca-from annotation to the webhooks and CRDs. As long as you have the cert-manager CA Injector enabled, this will automatically setup your webhook's CA to the one used by cert-manager. See https://cert-manager.io/docs/concepts/ca-injector |
 | webhook.certManager.cert.annotations | object | `{}` | Add extra annotations to the Certificate resource. |

deploy/charts/external-secrets/templates/webhook-secret.yaml

@@ -1,4 +1,4 @@
-{{- if and .Values.webhook.create (not .Values.webhook.certManager.enabled) }}
+{{- if and .Values.webhook.create (not .Values.webhook.certManager.enabled) .Values.webhook.createWebhookSecret }}
 apiVersion: v1
 kind: Secret
 metadata:

deploy/charts/external-secrets/tests/webhook_test.yaml

@@ -113,6 +113,16 @@ tests:
     templates:
       - webhook-secret.yaml
       - webhook-certificate.yaml
+  - it: also should not create the secret nor the certificate
+    set:
+      webhook.certManager.enabled: false
+      webhook.createWebhookSecret: false
+    asserts:
+      - hasDocuments:
+          count: 0
+    templates:
+      - webhook-secret.yaml
+      - webhook-certificate.yaml
   - it: should
     set:
       webhook.certManager.enabled: true

deploy/charts/external-secrets/values.yaml

@@ -223,6 +223,10 @@ webhook:
   # stored.
   certSecretNameOverride: ""
 
+  # -- Whether to create the webhook secret resource (doesn't interfere with
+  # webhook.certManager.cert.create).
+  createWebhookSecret: true
+
   certDir: /tmp/certs
   # -- Specifies whether validating webhooks should be created with failurePolicy: Fail or Ignore
   failurePolicy: Fail