Browse Source

Fix missing region error with defaultJWTProvider (#4940)

* fix missing region error with irsa

Signed-off-by: SYSHIL <ilhan.syed@gmail.com>

* Delete test-static-creds.yaml

Signed-off-by: Syed Shahidh Ilhan F <62804977+Ilhan-Personal@users.noreply.github.com>

* nit

Signed-off-by: SYSHIL <ilhan.syed@gmail.com>

* fix auth

Signed-off-by: SYSHIL <ilhan.syed@gmail.com>

* Delete test-ecr-fix.yaml

Signed-off-by: Syed Shahidh Ilhan F <62804977+Ilhan-Personal@users.noreply.github.com>

* revert irrelevant changes

Signed-off-by: SYSHIL <ilhan.syed@gmail.com>

---------

Signed-off-by: SYSHIL <ilhan.syed@gmail.com>
Signed-off-by: Syed Shahidh Ilhan F <62804977+Ilhan-Personal@users.noreply.github.com>
Syed Shahidh Ilhan F 9 months ago
parent
commit
d88aade676
1 changed files with 4 additions and 4 deletions
  1. 4 4
      pkg/provider/aws/auth/auth.go

+ 4 - 4
pkg/provider/aws/auth/auth.go

@@ -30,12 +30,12 @@ import (
 	"k8s.io/client-go/kubernetes"
 	ctrl "sigs.k8s.io/controller-runtime"
 	"sigs.k8s.io/controller-runtime/pkg/client"
-	ctrlcfg "sigs.k8s.io/controller-runtime/pkg/client/config"
 
 	esv1 "github.com/external-secrets/external-secrets/apis/externalsecrets/v1"
 	"github.com/external-secrets/external-secrets/pkg/feature"
 	"github.com/external-secrets/external-secrets/pkg/provider/aws/util"
 	"github.com/external-secrets/external-secrets/pkg/utils/resolvers"
+	ctrlcfg "sigs.k8s.io/controller-runtime/pkg/client/config"
 )
 
 // Config contains configuration to create a new AWS provider.
@@ -195,7 +195,6 @@ func NewGeneratorSession(ctx context.Context, auth esv1.AWSAuth, role, region st
 			return nil, err
 		}
 	}
-
 	config := aws.NewConfig()
 	if credsProvider != nil {
 		config.Credentials = credsProvider
@@ -297,8 +296,9 @@ func DefaultJWTProvider(name, namespace, roleArn string, aud []string, region st
 		return nil, err
 	}
 
-	awscfg, err := config.LoadDefaultConfig(context.TODO(), config.WithAppID("external-secrets"), // Disable shared config files:
-		config.WithSharedConfigFiles([]string{}),
+	awscfg, err := config.LoadDefaultConfig(context.TODO(), config.WithAppID("external-secrets"),
+		config.WithRegion(region),
+		config.WithSharedConfigFiles([]string{}), // Disable shared config files:
 		config.WithSharedCredentialsFiles([]string{}))
 
 	if err != nil {