:broom: remove hostname from keeper configuration (#2071)

* remove hostname from keeper configuration

Signed-off-by: Pedro Parra Ortega <parraortega.pedro@gmail.com>

apis/externalsecrets/v1beta1/secretstore_keepersecurity_types.go

@@ -19,6 +19,5 @@ import smmeta "github.com/external-secrets/external-secrets/apis/meta/v1"
 // KeeperSecurityProvider Configures a store to sync secrets using Keeper Security.
 type KeeperSecurityProvider struct {
 	Auth     smmeta.SecretKeySelector `json:"authRef"`
-	Hostname string                   `json:"hostname"`
 	FolderID string                   `json:"folderID"`
 }

config/crds/bases/external-secrets.io_clustersecretstores.yaml

@@ -2388,12 +2388,9 @@ spec:
                         type: object
                       folderID:
                         type: string
-                      hostname:
-                        type: string
                     required:
                     - authRef
                     - folderID
-                    - hostname
                     type: object
                   kubernetes:
                     description: Kubernetes configures this store to sync secrets

config/crds/bases/external-secrets.io_secretstores.yaml

@@ -2388,12 +2388,9 @@ spec:
                         type: object
                       folderID:
                         type: string
-                      hostname:
-                        type: string
                     required:
                     - authRef
                     - folderID
-                    - hostname
                     type: object
                   kubernetes:
                     description: Kubernetes configures this store to sync secrets

deploy/crds/bundle.yaml

@@ -2191,12 +2191,9 @@ spec:
                           type: object
                         folderID:
                           type: string
-                        hostname:
-                          type: string
                       required:
                         - authRef
                         - folderID
-                        - hostname
                       type: object
                     kubernetes:
                       description: Kubernetes configures this store to sync secrets using a Kubernetes cluster provider
@@ -5509,12 +5506,9 @@ spec:
                           type: object
                         folderID:
                           type: string
-                        hostname:
-                          type: string
                       required:
                         - authRef
                         - folderID
-                        - hostname
                       type: object
                     kubernetes:
                       description: Kubernetes configures this store to sync secrets using a Kubernetes cluster provider

docs/api/spec.md

@@ -3456,16 +3456,6 @@ External Secrets meta/v1.SecretKeySelector
 </tr>
 <tr>
 <td>
-<code>hostname</code></br>
-<em>
-string
-</em>
-</td>
-<td>
-</td>
-</tr>
-<tr>
-<td>
 <code>folderID</code></br>
 <em>
 string

docs/snippets/keepersecurity-secret-store.yaml

@@ -6,7 +6,6 @@ metadata:
 spec:
   provider:
     keepersecurity:
-      hostname: keepersecurity.eu
       authRef: # Refer to a kubernetes secret which holds the base64 encoded json string for the configuration
         name: keeper-configuration
         key:  auth

pkg/provider/keepersecurity/provider.go

@@ -16,7 +16,6 @@ package keepersecurity
 import (
 	"context"
 	"fmt"
-	"net/url"
 
 	ksm "github.com/keeper-security/secrets-manager-go/core"
 	"github.com/keeper-security/secrets-manager-go/core/logger"
@@ -36,7 +35,6 @@ const (
 	errKeeperSecurityNilSpecProviderKeeperSecurity  = "nil spec.provider.keepersecurity"
 	errKeeperSecurityStoreMissingAuth               = "missing: spec.provider.keepersecurity.auth"
 	errKeeperSecurityStoreMissingFolderID           = "missing: spec.provider.keepersecurity.folderID"
-	errKeeperSecurityStoreInvalidConnectHost        = "unable to parse URL: spec.provider.keepersecurity.connectHost: %w"
 	errInvalidClusterStoreMissingK8sSecretNamespace = "invalid ClusterSecretStore: missing KeeperSecurity k8s Auth Secret Namespace"
 	errFetchK8sSecret                               = "could not fetch k8s Secret: %w"
 	errMissingK8sSecretKey                          = "missing Secret key: %s"
@@ -104,11 +102,6 @@ func (p *Provider) ValidateStore(store esv1beta1.GenericStore) error {
 	// check mandatory fields
 	config := spc.Provider.KeeperSecurity
 
-	// check valid URL
-	if _, err := url.Parse(config.Hostname); err != nil {
-		return fmt.Errorf(errKeeperSecurityStoreInvalidConnectHost, err)
-	}
-
 	if err := utils.ValidateSecretSelector(store, config.Auth); err != nil {
 		return fmt.Errorf(errKeeperSecurityStoreMissingAuth)
 	}