Browse Source

fix: wi for clusterstore

Lucas Severo Alves 4 years ago
parent
commit
fb51f8bc57
1 changed files with 3 additions and 2 deletions
  1. 3 2
      pkg/provider/gcp/secretmanager/secretsmanager.go

+ 3 - 2
pkg/provider/gcp/secretmanager/secretsmanager.go

@@ -80,10 +80,11 @@ func (c *gClient) setAuth(ctx context.Context) error {
 
 	// only ClusterStore is allowed to set namespace (and then it's required)
 	if c.storeKind == esv1alpha1.ClusterSecretStoreKind {
-		if c.store.Auth.SecretRef.SecretAccessKey.Namespace == nil {
+		if credentialsSecretName != "" && c.store.Auth.SecretRef.SecretAccessKey.Namespace == nil {
 			return fmt.Errorf(errInvalidClusterStoreMissingSAKNamespace)
+		} else if credentialsSecretName != "" {
+			objectKey.Namespace = *c.store.Auth.SecretRef.SecretAccessKey.Namespace
 		}
-		objectKey.Namespace = *c.store.Auth.SecretRef.SecretAccessKey.Namespace
 	}
 	if credentialsSecretName == "" {
 		c.credentials = nil