Browse Source

minor changes: extension of PR #2950 (#2967)

Shanti G 2 years ago
parent
commit
fb762b57b3
2 changed files with 3 additions and 4 deletions
  1. 2 3
      pkg/provider/ibm/provider.go
  2. 1 1
      pkg/provider/ibm/provider_test.go

+ 2 - 3
pkg/provider/ibm/provider.go

@@ -309,10 +309,9 @@ func getServiceCredentialsSecret(ibm *providerIBM, secretName *string, secretGro
 		return nil, err
 	}
 	if val, ok := secMap[credentialsConst]; ok {
-		var mval []byte
-		mval, err = json.Marshal(val)
+		mval, err := json.Marshal(val)
 		if err != nil {
-			return nil, err
+			return nil, fmt.Errorf("failed to marshal secret map for service credentials secret: %w", err)
 		}
 		return mval, nil
 	}

+ 1 - 1
pkg/provider/ibm/provider_test.go

@@ -756,7 +756,7 @@ func TestGetSecretMap(t *testing.T) {
 		}
 	}
 
-	//good case: service_credentials
+	// good case: service_credentials
 	setSecretSrvCreds := func(smtc *secretManagerTestCase) {
 		secret := &sm.ServiceCredentialsSecret{
 			Name:        utilpointer.To("testyname"),