| 12345678910111213141516171819202122232425262728293031323334353637383940414243444546474849505152535455565758596061626364656667686970717273747576777879808182838485868788899091929394959697989910010110210310410510610710810911011111211311411511611711811912012112212312412512612712812913013113213313413513613713813914014114214314414514614714814915015115215315415515615715815916016116216316416516616716816917017117217317417517617717817918018118218318418518618718818919019119219319419519619719819920020120220320420520620720820921021121221321421521621721821922022122222322422522622722822923023123223323423523623723823924024124224324424524624724824925025125225325425525625725825926026126226326426526626726826927027127227327427527627727827928028128228328428528628728828929029129229329429529629729829930030130230330430530630730830931031131231331431531631731831932032132232332432532632732832933033133233333433533633733833934034134234334434534634734834935035135235335435535635735835936036136236336436536636736836937037137237337437537637737837938038138238338438538638738838939039139239339439539639739839940040140240340440540640740840941041141241341441541641741841942042142242342442542642742842943043143243343443543643743843944044144244344444544644744844945045145245345445545645745845946046146246346446546646746846947047147247347447547647747847948048148248348448548648748848949049149249349449549649749849950050150250350450550650750850951051151251351451551651751851952052152252352452552652752852953053153253353453553653753853954054154254354454554654754854955055155255355455555655755855956056156256356456556656756856957057157257357457557657757857958058158258358458558658758858959059159259359459559659759859960060160260360460560660760860961061161261361461561661761861962062162262362462562662762862963063163263363463563663763863964064164264364464564664764864965065165265365465565665765865966066166266366466566666766866967067167267367467567667767867968068168268368468568668768868969069169269369469569669769869970070170270370470570670770870971071171271371471571671771871972072172272372472572672772872973073173273373473573673773873974074174274374474574674774874975075175275375475575675775875976076176276376476576676776876977077177277377477577677777877978078178278378478578678778878979079179279379479579679779879980080180280380480580680780880981081181281381481581681781881982082182282382482582682782882983083183283383483583683783883984084184284384484584684784884985085185285385485585685785885986086186286386486586686786886987087187287387487587687787887988088188288388488588688788888989089189289389489589689789889990090190290390490590690790890991091191291391491591691791891992092192292392492592692792892993093193293393493593693793893994094194294394494594694794894995095195295395495595695795895996096196296396496596696796896997097197297397497597697797897998098198298398498598698798898999099199299399499599699799899910001001100210031004100510061007100810091010101110121013101410151016101710181019102010211022102310241025102610271028102910301031103210331034103510361037103810391040104110421043104410451046104710481049105010511052105310541055105610571058105910601061106210631064106510661067106810691070107110721073107410751076107710781079108010811082108310841085108610871088108910901091109210931094109510961097109810991100110111021103110411051106110711081109111011111112111311141115111611171118111911201121112211231124112511261127112811291130113111321133113411351136113711381139114011411142114311441145114611471148114911501151115211531154115511561157115811591160116111621163116411651166116711681169117011711172117311741175117611771178117911801181118211831184118511861187118811891190119111921193119411951196119711981199120012011202120312041205120612071208120912101211121212131214121512161217121812191220122112221223122412251226122712281229123012311232123312341235123612371238123912401241124212431244124512461247124812491250125112521253125412551256125712581259126012611262126312641265126612671268126912701271127212731274127512761277127812791280128112821283128412851286128712881289129012911292129312941295129612971298129913001301130213031304130513061307130813091310131113121313131413151316131713181319132013211322132313241325132613271328132913301331133213331334133513361337133813391340134113421343134413451346134713481349135013511352135313541355135613571358135913601361136213631364136513661367136813691370137113721373137413751376137713781379138013811382138313841385138613871388138913901391139213931394139513961397139813991400140114021403140414051406140714081409141014111412141314141415 |
- /*
- Licensed under the Apache License, Version 2.0 (the "License");
- you may not use this file except in compliance with the License.
- You may obtain a copy of the License at
- http://www.apache.org/licenses/LICENSE-2.0
- Unless required by applicable law or agreed to in writing, software
- distributed under the License is distributed on an "AS IS" BASIS,
- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- See the License for the specific language governing permissions and
- limitations under the License.
- */
- package utils
- import (
- "encoding/json"
- "errors"
- "reflect"
- "testing"
- "time"
- "github.com/aws/aws-sdk-go-v2/aws"
- "github.com/oracle/oci-go-sdk/v65/vault"
- "github.com/stretchr/testify/assert"
- v1 "k8s.io/api/core/v1"
- apiextensionsv1 "k8s.io/apiextensions-apiserver/pkg/apis/apiextensions/v1"
- metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
- esv1 "github.com/external-secrets/external-secrets/apis/externalsecrets/v1"
- esv1alpha1 "github.com/external-secrets/external-secrets/apis/externalsecrets/v1alpha1"
- esmetav1 "github.com/external-secrets/external-secrets/apis/meta/v1"
- )
- const (
- base64DecodedValue string = "foo%_?bar"
- base64EncodedValue string = "Zm9vJV8/YmFy"
- base64URLEncodedValue string = "Zm9vJV8_YmFy"
- keyWithEmojis string = "😀foo😁bar😂baz😈bing"
- keyWithInvalidChars string = "some-array[0].entity"
- keyWithEncodedInvalidChars string = "some-array_U005b_0_U005d_.entity"
- )
- func TestObjectHash(t *testing.T) {
- tests := []struct {
- name string
- input any
- want string
- }{
- {
- name: "A nil should be still working",
- input: nil,
- want: "c461202a18e99215f121936fb2452e03843828e448a00a53f285a6fc",
- },
- {
- name: "We accept a simple scalar value, i.e. string",
- input: "hello there",
- want: "f78681ec611ebaeea0689bff6c7812a83ff98a7faba986d9af76c999",
- },
- {
- name: "A complex object like a secret is not an issue",
- input: v1.Secret{Data: map[string][]byte{
- "xx": []byte("yyy"),
- }},
- want: "9c717e13e4281db3cdad3f56c6e7faab1d7029c4b4fbbf12fbec9b1e",
- },
- {
- name: "map also works",
- input: map[string][]byte{
- "foo": []byte("value1"),
- "bar": []byte("value2"),
- },
- want: "1bed8bcbcb4547ffe19a19cd47d9078e84aa6598266d86b99f992d64",
- },
- }
- for _, tt := range tests {
- t.Run(tt.name, func(t *testing.T) {
- if got := ObjectHash(tt.input); got != tt.want {
- t.Errorf("ObjectHash() = %v, want %v", got, tt.want)
- }
- })
- }
- }
- func TestIsNil(t *testing.T) {
- tbl := []struct {
- name string
- val any
- exp bool
- }{
- {
- name: "simple nil val",
- val: nil,
- exp: true,
- },
- {
- name: "nil slice",
- val: (*[]struct{})(nil),
- exp: true,
- },
- {
- name: "struct pointer",
- val: &testing.T{},
- exp: false,
- },
- {
- name: "struct",
- val: testing.T{},
- exp: false,
- },
- {
- name: "slice of struct",
- val: []struct{}{{}},
- exp: false,
- },
- {
- name: "slice of ptr",
- val: []*testing.T{nil},
- exp: false,
- },
- {
- name: "slice",
- val: []struct{}(nil),
- exp: false,
- },
- {
- name: "int default value",
- val: 0,
- exp: false,
- },
- {
- name: "empty str",
- val: "",
- exp: false,
- },
- {
- name: "oracle vault",
- val: vault.VaultsClient{},
- exp: false,
- },
- {
- name: "func",
- val: func() {
- // noop for testing and to make linter happy
- },
- exp: false,
- },
- {
- name: "channel",
- val: make(chan struct{}),
- exp: false,
- },
- {
- name: "map",
- val: map[string]string{},
- exp: false,
- },
- }
- for _, row := range tbl {
- t.Run(row.name, func(t *testing.T) {
- res := IsNil(row.val)
- if res != row.exp {
- t.Errorf("IsNil(%#v)=%t, expected %t", row.val, res, row.exp)
- }
- })
- }
- }
- func TestConvertKeys(t *testing.T) {
- type args struct {
- strategy esv1.ExternalSecretConversionStrategy
- in map[string][]byte
- }
- tests := []struct {
- name string
- args args
- want map[string][]byte
- wantErr bool
- }{
- {
- name: "convert with special chars",
- args: args{
- strategy: esv1.ExternalSecretConversionDefault,
- in: map[string][]byte{
- "foo$bar%baz*bing": []byte(`noop`),
- },
- },
- want: map[string][]byte{
- "foo_bar_baz_bing": []byte(`noop`),
- },
- },
- {
- name: "error on collision",
- args: args{
- strategy: esv1.ExternalSecretConversionDefault,
- in: map[string][]byte{
- "foo$bar%baz*bing": []byte(`noop`),
- "foo_bar_baz$bing": []byte(`noop`),
- },
- },
- wantErr: true,
- },
- {
- name: "convert path",
- args: args{
- strategy: esv1.ExternalSecretConversionDefault,
- in: map[string][]byte{
- "/foo/bar/baz/bing": []byte(`noop`),
- "foo/bar/baz/bing/": []byte(`noop`),
- },
- },
- want: map[string][]byte{
- "_foo_bar_baz_bing": []byte(`noop`),
- "foo_bar_baz_bing_": []byte(`noop`),
- },
- },
- {
- name: "convert unicode",
- args: args{
- strategy: esv1.ExternalSecretConversionUnicode,
- in: map[string][]byte{
- keyWithEmojis: []byte(`noop`),
- },
- },
- want: map[string][]byte{
- "_U1f600_foo_U1f601_bar_U1f602_baz_U1f608_bing": []byte(`noop`),
- },
- },
- }
- for _, tt := range tests {
- t.Run(tt.name, func(t *testing.T) {
- got, err := ConvertKeys(tt.args.strategy, tt.args.in)
- if (err != nil) != tt.wantErr {
- t.Errorf("ConvertKeys() error = %v, wantErr %v", err, tt.wantErr)
- return
- }
- if !reflect.DeepEqual(got, tt.want) {
- t.Errorf("ConvertKeys() = %v, want %v", got, tt.want)
- }
- })
- }
- }
- func TestReverseKeys(t *testing.T) {
- type args struct {
- encodingStrategy esv1.ExternalSecretConversionStrategy
- decodingStrategy esv1alpha1.PushSecretConversionStrategy
- in map[string][]byte
- }
- tests := []struct {
- name string
- args args
- want map[string][]byte
- wantErr bool
- }{
- {
- name: "encoding and decoding strategy are selecting Unicode conversion and reverse unicode, so the in and want should match, this test covers Unicode characters beyond the Basic Multilingual Plane (BMP)",
- args: args{
- encodingStrategy: esv1.ExternalSecretConversionUnicode,
- decodingStrategy: esv1alpha1.PushSecretConversionReverseUnicode,
- in: map[string][]byte{
- keyWithEmojis: []byte(`noop`),
- },
- },
- want: map[string][]byte{
- keyWithEmojis: []byte(`noop`),
- },
- },
- {
- name: "encoding and decoding strategy are selecting Unicode conversion and reverse unicode, so the in and want should match, this test covers Unicode characters in the Basic Multilingual Plane (BMP)",
- args: args{
- encodingStrategy: esv1.ExternalSecretConversionUnicode,
- decodingStrategy: esv1alpha1.PushSecretConversionReverseUnicode,
- in: map[string][]byte{
- keyWithInvalidChars: []byte(`noop`),
- },
- },
- want: map[string][]byte{
- keyWithInvalidChars: []byte(`noop`),
- },
- },
- {
- name: "the encoding strategy is selecting Unicode conversion, but the decoding strategy is none, so we want an encoded representation of the content",
- args: args{
- encodingStrategy: esv1.ExternalSecretConversionUnicode,
- decodingStrategy: esv1alpha1.PushSecretConversionNone,
- in: map[string][]byte{
- keyWithInvalidChars: []byte(`noop`),
- },
- },
- want: map[string][]byte{
- keyWithEncodedInvalidChars: []byte(`noop`),
- },
- },
- }
- for _, tt := range tests {
- t.Run(tt.name, func(t *testing.T) {
- got, err := ConvertKeys(tt.args.encodingStrategy, tt.args.in)
- if (err != nil) != tt.wantErr {
- t.Errorf("ConvertKeys() error = %v, wantErr %v", err, tt.wantErr)
- return
- }
- got, err = ReverseKeys(tt.args.decodingStrategy, got)
- if (err != nil) != tt.wantErr {
- t.Errorf("ReverseKeys() error = %v, wantErr %v", err, tt.wantErr)
- return
- }
- if !reflect.DeepEqual(got, tt.want) {
- t.Errorf("ReverseKeys() = %v, want %v", got, tt.want)
- }
- })
- }
- }
- func TestDecode(t *testing.T) {
- type args struct {
- strategy esv1.ExternalSecretDecodingStrategy
- in map[string][]byte
- }
- tests := []struct {
- name string
- args args
- want map[string][]byte
- wantErr bool
- }{
- {
- name: "base64 decoded",
- args: args{
- strategy: esv1.ExternalSecretDecodeBase64,
- in: map[string][]byte{
- "foo": []byte("YmFy"),
- },
- },
- want: map[string][]byte{
- "foo": []byte("bar"),
- },
- },
- {
- name: "invalid base64",
- args: args{
- strategy: esv1.ExternalSecretDecodeBase64,
- in: map[string][]byte{
- "foo": []byte("foo"),
- },
- },
- wantErr: true,
- },
- {
- name: "base64url decoded",
- args: args{
- strategy: esv1.ExternalSecretDecodeBase64URL,
- in: map[string][]byte{
- "foo": []byte(base64URLEncodedValue),
- },
- },
- want: map[string][]byte{
- "foo": []byte(base64DecodedValue),
- },
- },
- {
- name: "invalid base64url",
- args: args{
- strategy: esv1.ExternalSecretDecodeBase64URL,
- in: map[string][]byte{
- "foo": []byte("foo"),
- },
- },
- wantErr: true,
- },
- {
- name: "none",
- args: args{
- strategy: esv1.ExternalSecretDecodeNone,
- in: map[string][]byte{
- "foo": []byte(base64URLEncodedValue),
- },
- },
- want: map[string][]byte{
- "foo": []byte(base64URLEncodedValue),
- },
- },
- {
- name: "auto",
- args: args{
- strategy: esv1.ExternalSecretDecodeAuto,
- in: map[string][]byte{
- "b64": []byte(base64EncodedValue),
- "invalidb64": []byte("foo"),
- "b64url": []byte(base64URLEncodedValue),
- },
- },
- want: map[string][]byte{
- "b64": []byte(base64DecodedValue),
- "invalidb64": []byte("foo"),
- "b64url": []byte(base64DecodedValue),
- },
- },
- }
- for _, tt := range tests {
- t.Run(tt.name, func(t *testing.T) {
- got, err := DecodeMap(tt.args.strategy, tt.args.in)
- if (err != nil) != tt.wantErr {
- t.Errorf("DecodeMap() error = %v, wantErr %v", err, tt.wantErr)
- return
- }
- if !reflect.DeepEqual(got, tt.want) {
- t.Errorf("DecodeMap() = %v, want %v", got, tt.want)
- }
- })
- }
- }
- func TestValidate(t *testing.T) {
- err := NetworkValidate("http://google.com", 10*time.Second)
- if err != nil {
- t.Errorf("Connection problem: %v", err)
- }
- }
- func TestRewrite(t *testing.T) {
- type args struct {
- operations []esv1.ExternalSecretRewrite
- in map[string][]byte
- }
- tests := []struct {
- name string
- args args
- want map[string][]byte
- wantErr bool
- }{
- {
- name: "using double merge",
- args: args{
- operations: []esv1.ExternalSecretRewrite{
- {
- Merge: &esv1.ExternalSecretRewriteMerge{
- Strategy: esv1.ExternalSecretRewriteMergeStrategyJSON,
- ConflictPolicy: esv1.ExternalSecretRewriteMergeConflictPolicyIgnore,
- Into: "merged",
- Priority: []string{"a"},
- },
- },
- {
- Merge: &esv1.ExternalSecretRewriteMerge{
- Strategy: esv1.ExternalSecretRewriteMergeStrategyExtract,
- ConflictPolicy: esv1.ExternalSecretRewriteMergeConflictPolicyIgnore,
- Priority: []string{"b"},
- },
- },
- },
- in: map[string][]byte{
- "a": []byte(`{"host": "dba", "pass": "yola", "port": 123}`),
- "b": []byte(`{"host": "dbb", "pass": "yolb"}`),
- },
- },
- want: map[string][]byte{
- "host": []byte("dbb"),
- "pass": []byte("yolb"),
- "port": []byte("123"),
- },
- },
- {
- name: "using regexp and merge",
- args: args{
- operations: []esv1.ExternalSecretRewrite{
- {
- Regexp: &esv1.ExternalSecretRewriteRegexp{
- Source: "db/(.*)",
- Target: "$1",
- },
- },
- {
- Merge: &esv1.ExternalSecretRewriteMerge{
- Strategy: esv1.ExternalSecretRewriteMergeStrategyJSON,
- ConflictPolicy: esv1.ExternalSecretRewriteMergeConflictPolicyIgnore,
- Into: "merged",
- Priority: []string{"a"},
- },
- },
- },
- in: map[string][]byte{
- "db/a": []byte(`{"host": "dba.example.com"}`),
- "db/b": []byte(`{"host": "dbb.example.com", "pass": "yolo"}`),
- },
- },
- want: map[string][]byte{
- "a": []byte(`{"host": "dba.example.com"}`),
- "b": []byte(`{"host": "dbb.example.com", "pass": "yolo"}`),
- "merged": []byte(`{"host":"dba.example.com","pass":"yolo"}`),
- },
- },
- {
- name: "replace of a single key",
- args: args{
- operations: []esv1.ExternalSecretRewrite{
- {
- Regexp: &esv1.ExternalSecretRewriteRegexp{
- Source: "-",
- Target: "_",
- },
- },
- },
- in: map[string][]byte{
- "foo-bar": []byte("bar"),
- },
- },
- want: map[string][]byte{
- "foo_bar": []byte("bar"),
- },
- },
- {
- name: "no operation",
- args: args{
- operations: []esv1.ExternalSecretRewrite{
- {
- Regexp: &esv1.ExternalSecretRewriteRegexp{
- Source: "hello",
- Target: "world",
- },
- },
- },
- in: map[string][]byte{
- "foo": []byte("bar"),
- },
- },
- want: map[string][]byte{
- "foo": []byte("bar"),
- },
- },
- {
- name: "removing prefix from keys",
- args: args{
- operations: []esv1.ExternalSecretRewrite{
- {
- Regexp: &esv1.ExternalSecretRewriteRegexp{
- Source: "^my/initial/path/",
- Target: "",
- },
- },
- },
- in: map[string][]byte{
- "my/initial/path/foo": []byte("bar"),
- },
- },
- want: map[string][]byte{
- "foo": []byte("bar"),
- },
- },
- {
- name: "using un-named capture groups",
- args: args{
- operations: []esv1.ExternalSecretRewrite{
- {
- Regexp: &esv1.ExternalSecretRewriteRegexp{
- Source: "f(.*)o",
- Target: "a_new_path_$1",
- },
- },
- },
- in: map[string][]byte{
- "foo": []byte("bar"),
- "foodaloo": []byte("barr"),
- },
- },
- want: map[string][]byte{
- "a_new_path_o": []byte("bar"),
- "a_new_path_oodalo": []byte("barr"),
- },
- },
- {
- name: "using named and numbered capture groups",
- args: args{
- operations: []esv1.ExternalSecretRewrite{
- {
- Regexp: &esv1.ExternalSecretRewriteRegexp{
- Source: "f(?P<content>.*)o",
- Target: "a_new_path_${content}_${1}",
- },
- },
- },
- in: map[string][]byte{
- "foo": []byte("bar"),
- "floo": []byte("barr"),
- },
- },
- want: map[string][]byte{
- "a_new_path_o_o": []byte("bar"),
- "a_new_path_lo_lo": []byte("barr"),
- },
- },
- {
- name: "using sequenced rewrite operations",
- args: args{
- operations: []esv1.ExternalSecretRewrite{
- {
- Regexp: &esv1.ExternalSecretRewriteRegexp{
- Source: "my/(.*?)/bar/(.*)",
- Target: "$1-$2",
- },
- },
- {
- Regexp: &esv1.ExternalSecretRewriteRegexp{
- Source: "-",
- Target: "_",
- },
- },
- {
- Regexp: &esv1.ExternalSecretRewriteRegexp{
- Source: "ass",
- Target: "***",
- },
- },
- },
- in: map[string][]byte{
- "my/app/bar/key": []byte("bar"),
- "my/app/bar/password": []byte("barr"),
- },
- },
- want: map[string][]byte{
- "app_key": []byte("bar"),
- "app_p***word": []byte("barr"),
- },
- },
- {
- name: "using transform rewrite operation to create env var format keys",
- args: args{
- operations: []esv1.ExternalSecretRewrite{
- {
- Regexp: &esv1.ExternalSecretRewriteRegexp{
- Source: "my/(.*?)/bar/(.*)",
- Target: "$1-$2",
- },
- },
- {
- Transform: &esv1.ExternalSecretRewriteTransform{
- Template: `{{ .value | upper | replace "-" "_" }}`,
- },
- },
- },
- in: map[string][]byte{
- "my/app/bar/key": []byte("bar"),
- },
- },
- want: map[string][]byte{
- "APP_KEY": []byte("bar"),
- },
- },
- }
- for _, tt := range tests {
- t.Run(tt.name, func(t *testing.T) {
- got, err := RewriteMap(tt.args.operations, tt.args.in)
- if (err != nil) != tt.wantErr {
- t.Errorf("RewriteMap() error = %v, wantErr %v", err, tt.wantErr)
- return
- }
- if !reflect.DeepEqual(got, tt.want) {
- t.Errorf("RewriteMap() = %v, want %v", got, tt.want)
- }
- })
- }
- }
- func TestRewriteMerge(t *testing.T) {
- type args struct {
- operation esv1.ExternalSecretRewriteMerge
- in map[string][]byte
- }
- tests := []struct {
- name string
- args args
- want map[string][]byte
- wantErr bool
- }{
- {
- name: "using empty merge",
- args: args{
- operation: esv1.ExternalSecretRewriteMerge{},
- in: map[string][]byte{
- "mongo-credentials": []byte(`{"username": "foz", "password": "baz"}`),
- "redis-credentials": []byte(`{"host": "redis.example.com", "port": "6379"}`),
- },
- },
- want: map[string][]byte{
- "username": []byte("foz"),
- "password": []byte("baz"),
- "host": []byte("redis.example.com"),
- "port": []byte("6379"),
- },
- wantErr: false,
- },
- {
- name: "using priority",
- args: args{
- operation: esv1.ExternalSecretRewriteMerge{
- ConflictPolicy: esv1.ExternalSecretRewriteMergeConflictPolicyIgnore,
- Priority: []string{"mongo-credentials", "redis-credentials"},
- },
- in: map[string][]byte{
- "redis-credentials": []byte(`{"host": "redis.example.com", "port": "6379"}`),
- "mongo-credentials": []byte(`{"username": "foz", "password": "baz"}`),
- "other-credentials": []byte(`{"key": "value", "host": "other.example.com"}`),
- },
- },
- want: map[string][]byte{
- "username": []byte("foz"),
- "password": []byte("baz"),
- "host": []byte("redis.example.com"),
- "port": []byte("6379"),
- "key": []byte("value"),
- },
- wantErr: false,
- },
- {
- name: "using priority with keys not in input",
- args: args{
- operation: esv1.ExternalSecretRewriteMerge{
- ConflictPolicy: esv1.ExternalSecretRewriteMergeConflictPolicyIgnore,
- Priority: []string{"non-existent-key", "another-missing-key", "mongo-credentials"},
- },
- in: map[string][]byte{
- "mongo-credentials": []byte(`{"username": "foz", "password": "baz"}`),
- "redis-credentials": []byte(`{"host": "redis.example.com", "port": "6379"}`),
- },
- },
- want: nil,
- wantErr: true,
- },
- {
- name: "using conflict policy error",
- args: args{
- operation: esv1.ExternalSecretRewriteMerge{
- ConflictPolicy: esv1.ExternalSecretRewriteMergeConflictPolicyError,
- },
- in: map[string][]byte{
- "mongo-credentials": []byte(`{"username": "foz", "password": "baz"}`),
- "redis-credentials": []byte(`{"username": "redis", "port": "6379"}`),
- },
- },
- want: nil,
- wantErr: true,
- },
- {
- name: "using JSON strategy",
- args: args{
- operation: esv1.ExternalSecretRewriteMerge{
- Strategy: esv1.ExternalSecretRewriteMergeStrategyJSON,
- Into: "credentials",
- },
- in: map[string][]byte{
- "mongo-credentials": []byte(`{"username": "foz", "password": "baz"}`),
- "redis-credentials": []byte(`{"host": "redis.example.com", "port": "6379"}`),
- },
- },
- want: map[string][]byte{
- "mongo-credentials": []byte(`{"username": "foz", "password": "baz"}`),
- "redis-credentials": []byte(`{"host": "redis.example.com", "port": "6379"}`),
- "credentials": func() []byte {
- expected := map[string]interface{}{
- "username": "foz",
- "password": "baz",
- "host": "redis.example.com",
- "port": "6379",
- }
- b, _ := json.Marshal(expected)
- return b
- }(),
- },
- wantErr: false,
- },
- {
- name: "using JSON strategy without into",
- args: args{
- operation: esv1.ExternalSecretRewriteMerge{
- Strategy: esv1.ExternalSecretRewriteMergeStrategyJSON,
- },
- in: map[string][]byte{
- "mongo-credentials": []byte(`{"username": "foz", "password": "baz"}`),
- "redis-credentials": []byte(`{"host": "redis.example.com", "port": "6379"}`),
- },
- },
- want: nil,
- wantErr: true,
- },
- {
- name: "with invalid JSON",
- args: args{
- operation: esv1.ExternalSecretRewriteMerge{},
- in: map[string][]byte{
- "invalid-json": []byte(`{"username": "foz", "password": "baz"`),
- },
- },
- want: nil,
- wantErr: true,
- },
- }
- for _, tt := range tests {
- t.Run(tt.name, func(t *testing.T) {
- got, err := RewriteMerge(tt.args.operation, tt.args.in)
- if (err != nil) != tt.wantErr {
- t.Errorf("RewriteMerge() error = %v, wantErr %v", err, tt.wantErr)
- return
- }
- if !reflect.DeepEqual(got, tt.want) {
- t.Errorf("RewriteMerge() = %v, want %v", got, tt.want)
- }
- })
- }
- }
- func TestReverse(t *testing.T) {
- type args struct {
- strategy esv1alpha1.PushSecretConversionStrategy
- in string
- }
- tests := []struct {
- name string
- args args
- want string
- }{
- {
- name: "do not change the key when using the None strategy",
- args: args{
- strategy: esv1alpha1.PushSecretConversionNone,
- in: keyWithEncodedInvalidChars,
- },
- want: keyWithEncodedInvalidChars,
- },
- {
- name: "reverse an unicode encoded key",
- args: args{
- strategy: esv1alpha1.PushSecretConversionReverseUnicode,
- in: keyWithEncodedInvalidChars,
- },
- want: keyWithInvalidChars,
- },
- {
- name: "do not attempt to decode an invalid unicode representation",
- args: args{
- strategy: esv1alpha1.PushSecretConversionReverseUnicode,
- in: "_U0xxx_x_U005b_",
- },
- want: "_U0xxx_x[",
- },
- }
- for _, tt := range tests {
- t.Run(tt.name, func(t *testing.T) {
- if got := reverse(tt.args.strategy, tt.args.in); got != tt.want {
- t.Errorf("reverse() = %v, want %v", got, tt.want)
- }
- })
- }
- }
- func TestFetchValueFromMetadata(t *testing.T) {
- type args struct {
- key string
- data *apiextensionsv1.JSON
- def any
- }
- type testCase struct {
- name string
- args args
- wantT any
- wantErr bool
- }
- tests := []testCase{
- {
- name: "plain dig for an existing key",
- args: args{
- key: "key",
- data: &apiextensionsv1.JSON{
- Raw: []byte(
- `{"key": "value"}`,
- ),
- },
- def: "def",
- },
- wantT: "value",
- wantErr: false,
- },
- {
- name: "return default if key not found",
- args: args{
- key: "key2",
- data: &apiextensionsv1.JSON{
- Raw: []byte(
- `{"key": "value"}`,
- ),
- },
- def: "def",
- },
- wantT: "def",
- wantErr: false,
- },
- {
- name: "use a different type",
- args: args{
- key: "key",
- data: &apiextensionsv1.JSON{
- Raw: []byte(
- `{"key": 123}`,
- ),
- },
- def: 1234,
- },
- wantT: float64(123), // unmarshal is always float64
- wantErr: false,
- },
- {
- name: "digging deeper",
- args: args{
- key: "key2",
- data: &apiextensionsv1.JSON{
- Raw: []byte(
- `{"key": {"key2": "value"}}`,
- ),
- },
- def: "",
- },
- wantT: "value",
- wantErr: false,
- },
- {
- name: "digging for a slice",
- args: args{
- key: "topics",
- data: &apiextensionsv1.JSON{
- Raw: []byte(
- `{"topics": ["topic1", "topic2"]}`,
- ),
- },
- def: []string{},
- },
- wantT: []any{"topic1", "topic2"}, // we don't have deep type matching so it's not an []string{} but []any.
- wantErr: false,
- },
- }
- for _, tt := range tests {
- t.Run(tt.name, func(t *testing.T) {
- gotT, err := FetchValueFromMetadata(tt.args.key, tt.args.data, tt.args.def)
- if (err != nil) != tt.wantErr {
- t.Errorf("FetchValueFromMetadata() error = %v, wantErr %v", err, tt.wantErr)
- return
- }
- assert.Equal(t, tt.wantT, gotT)
- })
- }
- }
- func TestGetByteValue(t *testing.T) {
- type args struct {
- data any
- }
- type testCase struct {
- name string
- args args
- want []byte
- wantErr bool
- }
- tests := []testCase{
- {
- name: "string",
- args: args{
- data: "value",
- },
- want: []byte("value"),
- wantErr: false,
- },
- {
- name: "map of any",
- args: args{
- data: map[string]any{
- "key": "value",
- },
- },
- want: []byte(`{"key":"value"}`),
- wantErr: false,
- },
- {
- name: "slice of string",
- args: args{
- data: []string{"value1", "value2"},
- },
- want: []byte("value1\nvalue2"),
- wantErr: false,
- },
- {
- name: "json.RawMessage",
- args: args{
- data: json.RawMessage(`{"key":"value"}`),
- },
- want: []byte(`{"key":"value"}`),
- wantErr: false,
- },
- {
- name: "float64",
- args: args{
- data: 123.45,
- },
- want: []byte("123.45"),
- wantErr: false,
- },
- {
- name: "json.Number",
- args: args{
- data: json.Number("123.45"),
- },
- want: []byte("123.45"),
- wantErr: false,
- },
- {
- name: "slice of any",
- args: args{
- data: []any{"value1", "value2"},
- },
- want: []byte(`["value1","value2"]`),
- wantErr: false,
- },
- {
- name: "boolean",
- args: args{
- data: true,
- },
- want: []byte("true"),
- wantErr: false,
- },
- {
- name: "nil",
- args: args{
- data: nil,
- },
- want: []byte(nil),
- wantErr: false,
- },
- }
- for _, tt := range tests {
- t.Run(tt.name, func(t *testing.T) {
- got, err := GetByteValue(tt.args.data)
- if (err != nil) != tt.wantErr {
- t.Errorf("GetByteValue() error = %v, wantErr %v", err, tt.wantErr)
- return
- }
- if !reflect.DeepEqual(got, tt.want) {
- t.Errorf("GetByteValue() = %v, want %v", got, tt.want)
- }
- })
- }
- }
- func TestCompareStringAndByteSlices(t *testing.T) {
- type args struct {
- stringValue *string
- byteValueSlice []byte
- }
- type testCase struct {
- name string
- args args
- want bool
- wantErr bool
- }
- tests := []testCase{
- {
- name: "same contents",
- args: args{
- stringValue: aws.String("value"),
- byteValueSlice: []byte("value"),
- },
- want: true,
- wantErr: true,
- }, {
- name: "different contents",
- args: args{
- stringValue: aws.String("value89"),
- byteValueSlice: []byte("value"),
- },
- want: true,
- wantErr: false,
- }, {
- name: "same contents with random",
- args: args{
- stringValue: aws.String("value89!3#@212"),
- byteValueSlice: []byte("value89!3#@212"),
- },
- want: true,
- wantErr: true,
- }, {
- name: "check Nil",
- args: args{
- stringValue: nil,
- byteValueSlice: []byte("value89!3#@212"),
- },
- want: false,
- wantErr: false,
- },
- }
- for _, tt := range tests {
- t.Run(tt.name, func(t *testing.T) {
- got := CompareStringAndByteSlices(tt.args.stringValue, tt.args.byteValueSlice)
- if got != tt.wantErr {
- t.Errorf("CompareStringAndByteSlices() got = %v, want = %v", got, tt.wantErr)
- return
- }
- })
- }
- }
- func TestValidateSecretSelector(t *testing.T) {
- tests := []struct {
- desc string
- store esv1.GenericStore
- ref esmetav1.SecretKeySelector
- expected error
- }{
- {
- desc: "cluster secret store with namespace reference",
- store: &esv1.ClusterSecretStore{
- TypeMeta: metav1.TypeMeta{
- Kind: esv1.ClusterSecretStoreKind,
- },
- },
- ref: esmetav1.SecretKeySelector{
- Namespace: Ptr("test"),
- },
- expected: nil,
- },
- {
- desc: "secret store without namespace reference",
- store: &esv1.SecretStore{
- TypeMeta: metav1.TypeMeta{
- Kind: esv1.SecretStoreKind,
- },
- },
- ref: esmetav1.SecretKeySelector{},
- expected: nil,
- },
- {
- desc: "secret store with the same namespace reference",
- store: &esv1.SecretStore{
- TypeMeta: metav1.TypeMeta{
- Kind: esv1.SecretStoreKind,
- },
- ObjectMeta: metav1.ObjectMeta{
- Namespace: "test",
- },
- },
- ref: esmetav1.SecretKeySelector{
- Namespace: Ptr("test"),
- },
- expected: nil,
- },
- {
- desc: "cluster secret store without namespace reference",
- store: &esv1.ClusterSecretStore{
- TypeMeta: metav1.TypeMeta{
- Kind: esv1.ClusterSecretStoreKind,
- },
- },
- ref: esmetav1.SecretKeySelector{},
- expected: errRequireNamespace,
- },
- {
- desc: "secret store with the different namespace reference",
- store: &esv1.SecretStore{
- TypeMeta: metav1.TypeMeta{
- Kind: esv1.SecretStoreKind,
- },
- ObjectMeta: metav1.ObjectMeta{
- Namespace: "test",
- },
- },
- ref: esmetav1.SecretKeySelector{
- Namespace: Ptr("different"),
- },
- expected: errNamespaceNotAllowed,
- },
- }
- for _, tt := range tests {
- t.Run(tt.desc, func(t *testing.T) {
- got := ValidateSecretSelector(tt.store, tt.ref)
- if !errors.Is(got, tt.expected) {
- t.Errorf("ValidateSecretSelector() got = %v, want = %v", got, tt.expected)
- return
- }
- })
- }
- }
- func TestValidateReferentSecretSelector(t *testing.T) {
- tests := []struct {
- desc string
- store esv1.GenericStore
- ref esmetav1.SecretKeySelector
- expected error
- }{
- {
- desc: "cluster secret store with namespace reference",
- store: &esv1.ClusterSecretStore{
- TypeMeta: metav1.TypeMeta{
- Kind: esv1.ClusterSecretStoreKind,
- },
- },
- ref: esmetav1.SecretKeySelector{
- Namespace: Ptr("test"),
- },
- expected: nil,
- },
- {
- desc: "secret store without namespace reference",
- store: &esv1.SecretStore{
- TypeMeta: metav1.TypeMeta{
- Kind: esv1.SecretStoreKind,
- },
- },
- ref: esmetav1.SecretKeySelector{},
- expected: nil,
- },
- {
- desc: "secret store with the same namespace reference",
- store: &esv1.SecretStore{
- TypeMeta: metav1.TypeMeta{
- Kind: esv1.SecretStoreKind,
- },
- ObjectMeta: metav1.ObjectMeta{
- Namespace: "test",
- },
- },
- ref: esmetav1.SecretKeySelector{
- Namespace: Ptr("test"),
- },
- expected: nil,
- },
- {
- desc: "secret store with the different namespace reference",
- store: &esv1.SecretStore{
- TypeMeta: metav1.TypeMeta{
- Kind: esv1.SecretStoreKind,
- },
- ObjectMeta: metav1.ObjectMeta{
- Namespace: "test",
- },
- },
- ref: esmetav1.SecretKeySelector{
- Namespace: Ptr("different"),
- },
- expected: errNamespaceNotAllowed,
- },
- }
- for _, tt := range tests {
- t.Run(tt.desc, func(t *testing.T) {
- got := ValidateReferentSecretSelector(tt.store, tt.ref)
- if !errors.Is(got, tt.expected) {
- t.Errorf("ValidateReferentSecretSelector() got = %v, want = %v", got, tt.expected)
- return
- }
- })
- }
- }
- func TestValidateServiceAccountSelector(t *testing.T) {
- tests := []struct {
- desc string
- store esv1.GenericStore
- ref esmetav1.ServiceAccountSelector
- expected error
- }{
- {
- desc: "cluster secret store with namespace reference",
- store: &esv1.ClusterSecretStore{
- TypeMeta: metav1.TypeMeta{
- Kind: esv1.ClusterSecretStoreKind,
- },
- },
- ref: esmetav1.ServiceAccountSelector{
- Namespace: Ptr("test"),
- },
- expected: nil,
- },
- {
- desc: "secret store without namespace reference",
- store: &esv1.SecretStore{
- TypeMeta: metav1.TypeMeta{
- Kind: esv1.SecretStoreKind,
- },
- },
- ref: esmetav1.ServiceAccountSelector{},
- expected: nil,
- },
- {
- desc: "secret store with the same namespace reference",
- store: &esv1.SecretStore{
- TypeMeta: metav1.TypeMeta{
- Kind: esv1.SecretStoreKind,
- },
- ObjectMeta: metav1.ObjectMeta{
- Namespace: "test",
- },
- },
- ref: esmetav1.ServiceAccountSelector{
- Namespace: Ptr("test"),
- },
- expected: nil,
- },
- {
- desc: "cluster secret store without namespace reference",
- store: &esv1.ClusterSecretStore{
- TypeMeta: metav1.TypeMeta{
- Kind: esv1.ClusterSecretStoreKind,
- },
- },
- ref: esmetav1.ServiceAccountSelector{},
- expected: errRequireNamespace,
- },
- {
- desc: "secret store with the different namespace reference",
- store: &esv1.SecretStore{
- TypeMeta: metav1.TypeMeta{
- Kind: esv1.SecretStoreKind,
- },
- ObjectMeta: metav1.ObjectMeta{
- Namespace: "test",
- },
- },
- ref: esmetav1.ServiceAccountSelector{
- Namespace: Ptr("different"),
- },
- expected: errNamespaceNotAllowed,
- },
- }
- for _, tt := range tests {
- t.Run(tt.desc, func(t *testing.T) {
- got := ValidateServiceAccountSelector(tt.store, tt.ref)
- if !errors.Is(got, tt.expected) {
- t.Errorf("ValidateServiceAccountSelector() got = %v, want = %v", got, tt.expected)
- return
- }
- })
- }
- }
- func TestValidateReferentServiceAccountSelector(t *testing.T) {
- tests := []struct {
- desc string
- store esv1.GenericStore
- ref esmetav1.ServiceAccountSelector
- expected error
- }{
- {
- desc: "cluster secret store with namespace reference",
- store: &esv1.ClusterSecretStore{
- TypeMeta: metav1.TypeMeta{
- Kind: esv1.ClusterSecretStoreKind,
- },
- },
- ref: esmetav1.ServiceAccountSelector{
- Namespace: Ptr("test"),
- },
- expected: nil,
- },
- {
- desc: "secret store without namespace reference",
- store: &esv1.SecretStore{
- TypeMeta: metav1.TypeMeta{
- Kind: esv1.SecretStoreKind,
- },
- },
- ref: esmetav1.ServiceAccountSelector{},
- expected: nil,
- },
- {
- desc: "secret store with the same namespace reference",
- store: &esv1.SecretStore{
- TypeMeta: metav1.TypeMeta{
- Kind: esv1.SecretStoreKind,
- },
- ObjectMeta: metav1.ObjectMeta{
- Namespace: "test",
- },
- },
- ref: esmetav1.ServiceAccountSelector{
- Namespace: Ptr("test"),
- },
- expected: nil,
- },
- {
- desc: "secret store with the different namespace reference",
- store: &esv1.SecretStore{
- TypeMeta: metav1.TypeMeta{
- Kind: esv1.SecretStoreKind,
- },
- ObjectMeta: metav1.ObjectMeta{
- Namespace: "test",
- },
- },
- ref: esmetav1.ServiceAccountSelector{
- Namespace: Ptr("different"),
- },
- expected: errNamespaceNotAllowed,
- },
- }
- for _, tt := range tests {
- t.Run(tt.desc, func(t *testing.T) {
- got := ValidateReferentServiceAccountSelector(tt.store, tt.ref)
- if !errors.Is(got, tt.expected) {
- t.Errorf("ValidateReferentServiceAccountSelector() got = %v, want = %v", got, tt.expected)
- return
- }
- })
- }
- }
|