pushsecret_controller.go 14 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398
  1. /*
  2. Licensed under the Apache License, Version 2.0 (the "License");
  3. you may not use this file except in compliance with the License.
  4. You may obtain a copy of the License at
  5. http://www.apache.org/licenses/LICENSE-2.0
  6. Unless required by applicable law or agreed to in writing, software
  7. distributed under the License is distributed on an "AS IS" BASIS,
  8. WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
  9. See the License for the specific language governing permissions and
  10. limitations under the License.
  11. */
  12. package pushsecret
  13. import (
  14. "context"
  15. "fmt"
  16. "strings"
  17. "time"
  18. "github.com/go-logr/logr"
  19. v1 "k8s.io/api/core/v1"
  20. apierrors "k8s.io/apimachinery/pkg/api/errors"
  21. metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
  22. "k8s.io/apimachinery/pkg/runtime"
  23. "k8s.io/apimachinery/pkg/types"
  24. "k8s.io/client-go/tools/record"
  25. ctrl "sigs.k8s.io/controller-runtime"
  26. "sigs.k8s.io/controller-runtime/pkg/client"
  27. "sigs.k8s.io/controller-runtime/pkg/controller/controllerutil"
  28. esapi "github.com/external-secrets/external-secrets/apis/externalsecrets/v1alpha1"
  29. v1beta1 "github.com/external-secrets/external-secrets/apis/externalsecrets/v1beta1"
  30. "github.com/external-secrets/external-secrets/pkg/controllers/secretstore"
  31. )
  32. const (
  33. errFailedGetSecret = "could not get source secret"
  34. errPatchStatus = "error merging"
  35. errGetSecretStore = "could not get SecretStore %q, %w"
  36. errGetClusterSecretStore = "could not get ClusterSecretStore %q, %w"
  37. errGetProviderFailed = "could not start provider"
  38. errGetSecretsClientFailed = "could not start secrets client"
  39. errCloseStoreClient = "error when calling provider close method"
  40. errSetSecretFailed = "could not write remote ref %v to target secretstore %v: %v"
  41. errFailedSetSecret = "set secret failed: %v"
  42. pushSecretFinalizer = "pushsecret.externalsecrets.io/finalizer"
  43. )
  44. type Reconciler struct {
  45. client.Client
  46. Log logr.Logger
  47. Scheme *runtime.Scheme
  48. recorder record.EventRecorder
  49. RequeueInterval time.Duration
  50. ControllerClass string
  51. }
  52. func (r *Reconciler) Reconcile(ctx context.Context, req ctrl.Request) (ctrl.Result, error) {
  53. log := r.Log.WithValues("pushsecret", req.NamespacedName)
  54. var ps esapi.PushSecret
  55. err := r.Get(ctx, req.NamespacedName, &ps)
  56. mgr := secretstore.NewManager(r.Client, r.ControllerClass, false)
  57. defer mgr.Close(ctx)
  58. if apierrors.IsNotFound(err) {
  59. return ctrl.Result{}, nil
  60. } else if err != nil {
  61. msg := "unable to get PushSecret"
  62. r.recorder.Event(&ps, v1.EventTypeWarning, esapi.ReasonErrored, msg)
  63. log.Error(err, msg)
  64. return ctrl.Result{}, fmt.Errorf("get resource: %w", err)
  65. }
  66. refreshInt := r.RequeueInterval
  67. if ps.Spec.RefreshInterval != nil {
  68. refreshInt = ps.Spec.RefreshInterval.Duration
  69. }
  70. p := client.MergeFrom(ps.DeepCopy())
  71. defer func() {
  72. err := r.Client.Status().Patch(ctx, &ps, p)
  73. if err != nil {
  74. log.Error(err, errPatchStatus)
  75. }
  76. }()
  77. switch ps.Spec.DeletionPolicy {
  78. case esapi.PushSecretDeletionPolicyDelete:
  79. // finalizer logic. Only added if we should delete the secrets
  80. if ps.ObjectMeta.DeletionTimestamp.IsZero() {
  81. if !controllerutil.ContainsFinalizer(&ps, pushSecretFinalizer) {
  82. controllerutil.AddFinalizer(&ps, pushSecretFinalizer)
  83. err := r.Client.Update(ctx, &ps, &client.UpdateOptions{})
  84. if err != nil {
  85. return ctrl.Result{}, fmt.Errorf("could not update finalizers: %w", err)
  86. }
  87. return ctrl.Result{}, nil
  88. }
  89. } else {
  90. if controllerutil.ContainsFinalizer(&ps, pushSecretFinalizer) {
  91. // trigger a cleanup with no Synced Map
  92. badState, err := r.DeleteSecretFromProviders(ctx, &ps, esapi.SyncedPushSecretsMap{}, mgr)
  93. if err != nil {
  94. msg := fmt.Sprintf("Failed to Delete Secrets from Provider: %v", err)
  95. cond := NewPushSecretCondition(esapi.PushSecretReady, v1.ConditionFalse, esapi.ReasonErrored, msg)
  96. ps = SetPushSecretCondition(ps, *cond)
  97. r.SetSyncedSecrets(&ps, badState)
  98. r.recorder.Event(&ps, v1.EventTypeWarning, esapi.ReasonErrored, msg)
  99. return ctrl.Result{}, err
  100. }
  101. controllerutil.RemoveFinalizer(&ps, pushSecretFinalizer)
  102. err = r.Client.Update(ctx, &ps, &client.UpdateOptions{})
  103. if err != nil {
  104. return ctrl.Result{}, fmt.Errorf("could not update finalizers: %w", err)
  105. }
  106. return ctrl.Result{}, nil
  107. }
  108. }
  109. case esapi.PushSecretDeletionPolicyNone:
  110. default:
  111. }
  112. secret, err := r.GetSecret(ctx, ps)
  113. if err != nil {
  114. cond := NewPushSecretCondition(esapi.PushSecretReady, v1.ConditionFalse, esapi.ReasonErrored, errFailedGetSecret)
  115. ps = SetPushSecretCondition(ps, *cond)
  116. r.recorder.Event(&ps, v1.EventTypeWarning, esapi.ReasonErrored, errFailedGetSecret)
  117. return ctrl.Result{}, err
  118. }
  119. secretStores, err := r.GetSecretStores(ctx, ps)
  120. if err != nil {
  121. cond := NewPushSecretCondition(esapi.PushSecretReady, v1.ConditionFalse, esapi.ReasonErrored, err.Error())
  122. ps = SetPushSecretCondition(ps, *cond)
  123. r.recorder.Event(&ps, v1.EventTypeWarning, esapi.ReasonErrored, err.Error())
  124. return ctrl.Result{}, err
  125. }
  126. syncedSecrets, err := r.PushSecretToProviders(ctx, secretStores, ps, secret, mgr)
  127. if err != nil {
  128. msg := fmt.Sprintf(errFailedSetSecret, err)
  129. cond := NewPushSecretCondition(esapi.PushSecretReady, v1.ConditionFalse, esapi.ReasonErrored, msg)
  130. ps = SetPushSecretCondition(ps, *cond)
  131. totalSecrets := mergeSecretState(syncedSecrets, ps.Status.SyncedPushSecrets)
  132. r.SetSyncedSecrets(&ps, totalSecrets)
  133. r.recorder.Event(&ps, v1.EventTypeWarning, esapi.ReasonErrored, msg)
  134. return ctrl.Result{}, err
  135. }
  136. switch ps.Spec.DeletionPolicy {
  137. case esapi.PushSecretDeletionPolicyDelete:
  138. badSyncState, err := r.DeleteSecretFromProviders(ctx, &ps, syncedSecrets, mgr)
  139. if err != nil {
  140. msg := fmt.Sprintf("Failed to Delete Secrets from Provider: %v", err)
  141. cond := NewPushSecretCondition(esapi.PushSecretReady, v1.ConditionFalse, esapi.ReasonErrored, msg)
  142. ps = SetPushSecretCondition(ps, *cond)
  143. r.SetSyncedSecrets(&ps, badSyncState)
  144. r.recorder.Event(&ps, v1.EventTypeWarning, esapi.ReasonErrored, msg)
  145. return ctrl.Result{}, err
  146. }
  147. case esapi.PushSecretDeletionPolicyNone:
  148. default:
  149. }
  150. msg := "PushSecret synced successfully"
  151. cond := NewPushSecretCondition(esapi.PushSecretReady, v1.ConditionTrue, esapi.ReasonSynced, msg)
  152. ps = SetPushSecretCondition(ps, *cond)
  153. r.SetSyncedSecrets(&ps, syncedSecrets)
  154. r.recorder.Event(&ps, v1.EventTypeNormal, esapi.ReasonSynced, msg)
  155. return ctrl.Result{RequeueAfter: refreshInt}, nil
  156. }
  157. func (r *Reconciler) SetSyncedSecrets(ps *esapi.PushSecret, status esapi.SyncedPushSecretsMap) {
  158. ps.Status.SyncedPushSecrets = status
  159. }
  160. func mergeSecretState(newMap, old esapi.SyncedPushSecretsMap) esapi.SyncedPushSecretsMap {
  161. out := newMap.DeepCopy()
  162. for k, v := range old {
  163. _, ok := out[k]
  164. if !ok {
  165. out[k] = make(map[string]esapi.PushSecretData)
  166. }
  167. for kk, vv := range v {
  168. out[k][kk] = vv
  169. }
  170. }
  171. return out
  172. }
  173. func (r *Reconciler) DeleteSecretFromProviders(ctx context.Context, ps *esapi.PushSecret, newMap esapi.SyncedPushSecretsMap, mgr *secretstore.Manager) (esapi.SyncedPushSecretsMap, error) {
  174. out := mergeSecretState(newMap, ps.Status.SyncedPushSecrets)
  175. for storeName, oldData := range ps.Status.SyncedPushSecrets {
  176. storeRef := v1beta1.SecretStoreRef{
  177. Name: strings.Split(storeName, "/")[1],
  178. Kind: strings.Split(storeName, "/")[0],
  179. }
  180. client, err := mgr.Get(ctx, storeRef, ps.Namespace, nil)
  181. if err != nil {
  182. return out, fmt.Errorf("could not get secrets client for store %v: %w", storeName, err)
  183. }
  184. newData, ok := newMap[storeName]
  185. if !ok {
  186. err = r.DeleteAllSecretsFromStore(ctx, client, oldData)
  187. if err != nil {
  188. return out, err
  189. }
  190. delete(out, storeName)
  191. continue
  192. }
  193. for oldEntry, oldRef := range oldData {
  194. _, ok := newData[oldEntry]
  195. if !ok {
  196. err = r.DeleteSecretFromStore(ctx, client, oldRef)
  197. if err != nil {
  198. return out, err
  199. }
  200. delete(out[storeName], oldRef.Match.RemoteRef.RemoteKey)
  201. }
  202. }
  203. }
  204. return out, nil
  205. }
  206. func (r *Reconciler) DeleteAllSecretsFromStore(ctx context.Context, client v1beta1.SecretsClient, data map[string]esapi.PushSecretData) error {
  207. for _, v := range data {
  208. err := r.DeleteSecretFromStore(ctx, client, v)
  209. if err != nil {
  210. return err
  211. }
  212. }
  213. return nil
  214. }
  215. func (r *Reconciler) DeleteSecretFromStore(ctx context.Context, client v1beta1.SecretsClient, data esapi.PushSecretData) error {
  216. return client.DeleteSecret(ctx, data.Match.RemoteRef)
  217. }
  218. func (r *Reconciler) PushSecretToProviders(ctx context.Context, stores map[esapi.PushSecretStoreRef]v1beta1.GenericStore, ps esapi.PushSecret, secret *v1.Secret, mgr *secretstore.Manager) (esapi.SyncedPushSecretsMap, error) {
  219. out := esapi.SyncedPushSecretsMap{}
  220. for ref, store := range stores {
  221. storeKey := fmt.Sprintf("%v/%v", ref.Kind, store.GetName())
  222. out[storeKey] = make(map[string]esapi.PushSecretData)
  223. storeRef := v1beta1.SecretStoreRef{
  224. Name: store.GetName(),
  225. Kind: ref.Kind,
  226. }
  227. client, err := mgr.Get(ctx, storeRef, ps.GetNamespace(), nil)
  228. if err != nil {
  229. return out, fmt.Errorf("could not get secrets client for store %v: %w", store.GetName(), err)
  230. }
  231. for _, ref := range ps.Spec.Data {
  232. secretValue, ok := secret.Data[ref.Match.SecretKey]
  233. if !ok {
  234. return out, fmt.Errorf("secret key %v does not exist", ref.Match.SecretKey)
  235. }
  236. err := client.PushSecret(ctx, secretValue, ref.Match.RemoteRef)
  237. if err != nil {
  238. return out, fmt.Errorf(errSetSecretFailed, ref.Match.SecretKey, store.GetName(), err)
  239. }
  240. out[storeKey][ref.Match.RemoteRef.RemoteKey] = ref
  241. }
  242. }
  243. return out, nil
  244. }
  245. func (r *Reconciler) GetSecret(ctx context.Context, ps esapi.PushSecret) (*v1.Secret, error) {
  246. secretName := types.NamespacedName{Name: ps.Spec.Selector.Secret.Name, Namespace: ps.Namespace}
  247. secret := &v1.Secret{}
  248. err := r.Client.Get(ctx, secretName, secret)
  249. if err != nil {
  250. return nil, err
  251. }
  252. return secret, nil
  253. }
  254. func (r *Reconciler) GetSecretStores(ctx context.Context, ps esapi.PushSecret) (map[esapi.PushSecretStoreRef]v1beta1.GenericStore, error) {
  255. stores := make(map[esapi.PushSecretStoreRef]v1beta1.GenericStore)
  256. for _, refStore := range ps.Spec.SecretStoreRefs {
  257. if refStore.LabelSelector != nil {
  258. labelSelector, err := metav1.LabelSelectorAsSelector(refStore.LabelSelector)
  259. if err != nil {
  260. return nil, fmt.Errorf("could not convert labels: %w", err)
  261. }
  262. if refStore.Kind == v1beta1.ClusterSecretStoreKind {
  263. clusterSecretStoreList := v1beta1.ClusterSecretStoreList{}
  264. err = r.List(ctx, &clusterSecretStoreList, &client.ListOptions{LabelSelector: labelSelector})
  265. if err != nil {
  266. return nil, fmt.Errorf("could not list cluster Secret Stores: %w", err)
  267. }
  268. for k, v := range clusterSecretStoreList.Items {
  269. key := esapi.PushSecretStoreRef{
  270. Name: v.Name,
  271. Kind: v1beta1.ClusterSecretStoreKind,
  272. }
  273. stores[key] = &clusterSecretStoreList.Items[k]
  274. }
  275. } else {
  276. secretStoreList := v1beta1.SecretStoreList{}
  277. err = r.List(ctx, &secretStoreList, &client.ListOptions{LabelSelector: labelSelector})
  278. if err != nil {
  279. return nil, fmt.Errorf("could not list Secret Stores: %w", err)
  280. }
  281. for k, v := range secretStoreList.Items {
  282. key := esapi.PushSecretStoreRef{
  283. Name: v.Name,
  284. Kind: v1beta1.SecretStoreKind,
  285. }
  286. stores[key] = &secretStoreList.Items[k]
  287. }
  288. }
  289. } else {
  290. store, err := r.getSecretStoreFromName(ctx, refStore, ps.Namespace)
  291. if err != nil {
  292. return nil, err
  293. }
  294. stores[refStore] = store
  295. }
  296. }
  297. return stores, nil
  298. }
  299. func (r *Reconciler) getSecretStoreFromName(ctx context.Context, refStore esapi.PushSecretStoreRef, ns string) (v1beta1.GenericStore, error) {
  300. if refStore.Name == "" {
  301. return nil, fmt.Errorf("refStore Name must be provided")
  302. }
  303. ref := types.NamespacedName{
  304. Name: refStore.Name,
  305. }
  306. if refStore.Kind == v1beta1.ClusterSecretStoreKind {
  307. var store v1beta1.ClusterSecretStore
  308. err := r.Get(ctx, ref, &store)
  309. if err != nil {
  310. return nil, fmt.Errorf(errGetClusterSecretStore, ref.Name, err)
  311. }
  312. return &store, nil
  313. }
  314. ref.Namespace = ns
  315. var store v1beta1.SecretStore
  316. err := r.Get(ctx, ref, &store)
  317. if err != nil {
  318. return nil, fmt.Errorf(errGetSecretStore, ref.Name, err)
  319. }
  320. return &store, nil
  321. }
  322. func (r *Reconciler) SetupWithManager(mgr ctrl.Manager) error {
  323. r.recorder = mgr.GetEventRecorderFor("pushsecret")
  324. return ctrl.NewControllerManagedBy(mgr).
  325. For(&esapi.PushSecret{}).
  326. Complete(r)
  327. }
  328. func NewPushSecretCondition(condType esapi.PushSecretConditionType, status v1.ConditionStatus, reason, message string) *esapi.PushSecretStatusCondition {
  329. return &esapi.PushSecretStatusCondition{
  330. Type: condType,
  331. Status: status,
  332. LastTransitionTime: metav1.Now(),
  333. Reason: reason,
  334. Message: message,
  335. }
  336. }
  337. func SetPushSecretCondition(gs esapi.PushSecret, condition esapi.PushSecretStatusCondition) esapi.PushSecret {
  338. status := gs.Status
  339. currentCond := GetPushSecretCondition(status, condition.Type)
  340. if currentCond != nil && currentCond.Status == condition.Status &&
  341. currentCond.Reason == condition.Reason && currentCond.Message == condition.Message {
  342. return gs
  343. }
  344. // Do not update lastTransitionTime if the status of the condition doesn't change.
  345. if currentCond != nil && currentCond.Status == condition.Status {
  346. condition.LastTransitionTime = currentCond.LastTransitionTime
  347. }
  348. status.Conditions = append(filterOutCondition(status.Conditions, condition.Type), condition)
  349. gs.Status = status
  350. return gs
  351. }
  352. // filterOutCondition returns an empty set of conditions with the provided type.
  353. func filterOutCondition(conditions []esapi.PushSecretStatusCondition, condType esapi.PushSecretConditionType) []esapi.PushSecretStatusCondition {
  354. newConditions := make([]esapi.PushSecretStatusCondition, 0, len(conditions))
  355. for _, c := range conditions {
  356. if c.Type == condType {
  357. continue
  358. }
  359. newConditions = append(newConditions, c)
  360. }
  361. return newConditions
  362. }
  363. // GetSecretStoreCondition returns the condition with the provided type.
  364. func GetPushSecretCondition(status esapi.PushSecretStatus, condType esapi.PushSecretConditionType) *esapi.PushSecretStatusCondition {
  365. for i := range status.Conditions {
  366. c := status.Conditions[i]
  367. if c.Type == condType {
  368. return &c
  369. }
  370. }
  371. return nil
  372. }