externalsecret_controller.go 23 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528529530531532533534535536537538539540541542543544545546547548549550551552553554555556557558559560561562563564565566567568569570571572573574575576577578579580581582583584585586587588589590591592593594595596597598599600601602603604605606607608609610611612613614615616617618619620621622623624625626627628629630631632633634635636637638
  1. /*
  2. Licensed under the Apache License, Version 2.0 (the "License");
  3. you may not use this file except in compliance with the License.
  4. You may obtain a copy of the License at
  5. http://www.apache.org/licenses/LICENSE-2.0
  6. Unless required by applicable law or agreed to in writing, software
  7. distributed under the License is distributed on an "AS IS" BASIS,
  8. WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
  9. See the License for the specific language governing permissions and
  10. limitations under the License.
  11. */
  12. package externalsecret
  13. import (
  14. "context"
  15. "encoding/json"
  16. "fmt"
  17. "strings"
  18. "time"
  19. "github.com/go-logr/logr"
  20. v1 "k8s.io/api/core/v1"
  21. "k8s.io/apimachinery/pkg/api/equality"
  22. apierrors "k8s.io/apimachinery/pkg/api/errors"
  23. metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
  24. "k8s.io/apimachinery/pkg/runtime"
  25. "k8s.io/apimachinery/pkg/types"
  26. "k8s.io/client-go/rest"
  27. "k8s.io/client-go/tools/record"
  28. ctrl "sigs.k8s.io/controller-runtime"
  29. "sigs.k8s.io/controller-runtime/pkg/builder"
  30. "sigs.k8s.io/controller-runtime/pkg/client"
  31. "sigs.k8s.io/controller-runtime/pkg/controller"
  32. "sigs.k8s.io/controller-runtime/pkg/controller/controllerutil"
  33. esv1beta1 "github.com/external-secrets/external-secrets/apis/externalsecrets/v1beta1"
  34. // Metrics.
  35. "github.com/external-secrets/external-secrets/pkg/controllers/externalsecret/esmetrics"
  36. ctrlmetrics "github.com/external-secrets/external-secrets/pkg/controllers/metrics"
  37. // Loading registered generators.
  38. _ "github.com/external-secrets/external-secrets/pkg/generator/register"
  39. // Loading registered providers.
  40. _ "github.com/external-secrets/external-secrets/pkg/provider/register"
  41. "github.com/external-secrets/external-secrets/pkg/utils"
  42. )
  43. const (
  44. fieldOwnerTemplate = "externalsecrets.external-secrets.io/%v"
  45. errGetES = "could not get ExternalSecret"
  46. errConvert = "could not apply conversion strategy to keys: %v"
  47. errDecode = "could not apply decoding strategy to %v[%d]: %v"
  48. errGenerate = "could not generate [%d]: %w"
  49. errRewrite = "could not rewrite spec.dataFrom[%d]: %v"
  50. errInvalidKeys = "secret keys from spec.dataFrom.%v[%d] can only have alphanumeric,'-', '_' or '.' characters. Convert them using rewrite (https://external-secrets.io/latest/guides-datafrom-rewrite)"
  51. errUpdateSecret = "could not update Secret"
  52. errPatchStatus = "unable to patch status"
  53. errStoreRef = "could not get store reference"
  54. errStoreUsability = "could not use store reference"
  55. errStoreProvider = "could not get store provider"
  56. errStoreClient = "could not get provider client"
  57. errGetExistingSecret = "could not get existing secret: %w"
  58. errCloseStoreClient = "could not close provider client"
  59. errSetCtrlReference = "could not set ExternalSecret controller reference: %w"
  60. errFetchTplFrom = "error fetching templateFrom data: %w"
  61. errGetSecretData = "could not get secret data from provider"
  62. errDeleteSecret = "could not delete secret"
  63. errApplyTemplate = "could not apply template: %w"
  64. errExecTpl = "could not execute template: %w"
  65. errInvalidCreatePolicy = "invalid creationPolicy=%s. Can not delete secret i do not own"
  66. errPolicyMergeNotFound = "the desired secret %s was not found. With creationPolicy=Merge the secret won't be created"
  67. errPolicyMergeGetSecret = "unable to get secret %s: %w"
  68. errPolicyMergeMutate = "unable to mutate secret %s: %w"
  69. errPolicyMergePatch = "unable to patch secret %s: %w"
  70. errTplCMMissingKey = "error in configmap %s: missing key %s"
  71. errTplSecMissingKey = "error in secret %s: missing key %s"
  72. )
  73. // Reconciler reconciles a ExternalSecret object.
  74. type Reconciler struct {
  75. client.Client
  76. Log logr.Logger
  77. Scheme *runtime.Scheme
  78. RestConfig *rest.Config
  79. ControllerClass string
  80. RequeueInterval time.Duration
  81. ClusterSecretStoreEnabled bool
  82. EnableFloodGate bool
  83. recorder record.EventRecorder
  84. }
  85. // Reconcile implements the main reconciliation loop
  86. // for watched objects (ExternalSecret, ClusterSecretStore and SecretStore),
  87. // and updates/creates a Kubernetes secret based on them.
  88. func (r *Reconciler) Reconcile(ctx context.Context, req ctrl.Request) (ctrl.Result, error) {
  89. log := r.Log.WithValues("ExternalSecret", req.NamespacedName)
  90. resourceLabels := ctrlmetrics.RefineNonConditionMetricLabels(map[string]string{"name": req.Name, "namespace": req.Namespace})
  91. start := time.Now()
  92. syncCallsError := esmetrics.GetCounterVec(esmetrics.SyncCallsErrorKey)
  93. // use closures to dynamically update resourceLabels
  94. defer func() {
  95. esmetrics.GetGaugeVec(esmetrics.ExternalSecretReconcileDurationKey).With(resourceLabels).Set(float64(time.Since(start)))
  96. esmetrics.GetCounterVec(esmetrics.SyncCallsKey).With(resourceLabels).Inc()
  97. }()
  98. var externalSecret esv1beta1.ExternalSecret
  99. err := r.Get(ctx, req.NamespacedName, &externalSecret)
  100. if err != nil {
  101. if apierrors.IsNotFound(err) {
  102. conditionSynced := NewExternalSecretCondition(esv1beta1.ExternalSecretDeleted, v1.ConditionFalse, esv1beta1.ConditionReasonSecretDeleted, "Secret was deleted")
  103. SetExternalSecretCondition(&esv1beta1.ExternalSecret{
  104. ObjectMeta: metav1.ObjectMeta{
  105. Name: req.Name,
  106. Namespace: req.Namespace,
  107. },
  108. }, *conditionSynced)
  109. return ctrl.Result{}, nil
  110. }
  111. log.Error(err, errGetES)
  112. syncCallsError.With(resourceLabels).Inc()
  113. return ctrl.Result{}, err
  114. }
  115. timeSinceLastRefresh := 0 * time.Second
  116. if !externalSecret.Status.RefreshTime.IsZero() {
  117. timeSinceLastRefresh = time.Since(externalSecret.Status.RefreshTime.Time)
  118. }
  119. // skip reconciliation if deletion timestamp is set on external secret
  120. if externalSecret.DeletionTimestamp != nil {
  121. log.Info("skipping as it is in deletion")
  122. return ctrl.Result{}, nil
  123. }
  124. // if extended metrics is enabled, refine the time series vector
  125. resourceLabels = ctrlmetrics.RefineLabels(resourceLabels, externalSecret.Labels)
  126. if shouldSkipClusterSecretStore(r, externalSecret) {
  127. log.Info("skipping cluster secret store as it is disabled")
  128. return ctrl.Result{}, nil
  129. }
  130. // skip when pointing to an unmanaged store
  131. skip, err := shouldSkipUnmanagedStore(ctx, req.Namespace, r, externalSecret)
  132. if skip {
  133. log.Info("skipping unmanaged store as it points to a unmanaged controllerClass")
  134. return ctrl.Result{}, nil
  135. }
  136. refreshInt := r.RequeueInterval
  137. if externalSecret.Spec.RefreshInterval != nil {
  138. refreshInt = externalSecret.Spec.RefreshInterval.Duration
  139. }
  140. // Target Secret Name should default to the ExternalSecret name if not explicitly specified
  141. secretName := externalSecret.Spec.Target.Name
  142. if secretName == "" {
  143. secretName = externalSecret.ObjectMeta.Name
  144. }
  145. // fetch external secret, we need to ensure that it exists, and it's hashmap corresponds
  146. var existingSecret v1.Secret
  147. err = r.Get(ctx, types.NamespacedName{
  148. Name: secretName,
  149. Namespace: externalSecret.Namespace,
  150. }, &existingSecret)
  151. if err != nil && !apierrors.IsNotFound(err) {
  152. log.Error(err, errGetExistingSecret)
  153. return ctrl.Result{}, err
  154. }
  155. // refresh should be skipped if
  156. // 1. resource generation hasn't changed
  157. // 2. refresh interval is 0
  158. // 3. if we're still within refresh-interval
  159. if !shouldRefresh(externalSecret) && isSecretValid(existingSecret) {
  160. refreshInt = (externalSecret.Spec.RefreshInterval.Duration - timeSinceLastRefresh) + 5*time.Second
  161. log.V(1).Info("skipping refresh", "rv", getResourceVersion(externalSecret), "nr", refreshInt.Seconds())
  162. return ctrl.Result{RequeueAfter: refreshInt}, nil
  163. }
  164. if !shouldReconcile(externalSecret) {
  165. log.V(1).Info("stopping reconciling", "rv", getResourceVersion(externalSecret))
  166. return ctrl.Result{
  167. RequeueAfter: 0,
  168. Requeue: false,
  169. }, nil
  170. }
  171. // patch status when done processing
  172. p := client.MergeFrom(externalSecret.DeepCopy())
  173. defer func() {
  174. err = r.Status().Patch(ctx, &externalSecret, p)
  175. if err != nil {
  176. log.Error(err, errPatchStatus)
  177. }
  178. }()
  179. secret := &v1.Secret{
  180. ObjectMeta: metav1.ObjectMeta{
  181. Name: secretName,
  182. Namespace: externalSecret.Namespace,
  183. },
  184. Immutable: &externalSecret.Spec.Target.Immutable,
  185. Data: make(map[string][]byte),
  186. }
  187. dataMap, err := r.getProviderSecretData(ctx, &externalSecret)
  188. if err != nil {
  189. log.Error(err, errGetSecretData)
  190. r.recorder.Event(&externalSecret, v1.EventTypeWarning, esv1beta1.ReasonUpdateFailed, err.Error())
  191. conditionSynced := NewExternalSecretCondition(esv1beta1.ExternalSecretReady, v1.ConditionFalse, esv1beta1.ConditionReasonSecretSyncedError, errGetSecretData)
  192. SetExternalSecretCondition(&externalSecret, *conditionSynced)
  193. syncCallsError.With(resourceLabels).Inc()
  194. return ctrl.Result{}, err
  195. }
  196. // if no data was found we can delete the secret if needed.
  197. if len(dataMap) == 0 {
  198. switch externalSecret.Spec.Target.DeletionPolicy {
  199. // delete secret and return early.
  200. case esv1beta1.DeletionPolicyDelete:
  201. // safeguard that we only can delete secrets we own
  202. // this is also implemented in the es validation webhook
  203. if externalSecret.Spec.Target.CreationPolicy != esv1beta1.CreatePolicyOwner {
  204. err := fmt.Errorf(errInvalidCreatePolicy, externalSecret.Spec.Target.CreationPolicy)
  205. log.Error(err, errDeleteSecret)
  206. r.recorder.Event(&externalSecret, v1.EventTypeWarning, esv1beta1.ReasonUpdateFailed, err.Error())
  207. conditionSynced := NewExternalSecretCondition(esv1beta1.ExternalSecretReady, v1.ConditionFalse, esv1beta1.ConditionReasonSecretSyncedError, errDeleteSecret)
  208. SetExternalSecretCondition(&externalSecret, *conditionSynced)
  209. syncCallsError.With(resourceLabels).Inc()
  210. return ctrl.Result{}, err
  211. }
  212. err = r.Delete(ctx, secret)
  213. if err != nil && !apierrors.IsNotFound(err) {
  214. log.Error(err, errDeleteSecret)
  215. r.recorder.Event(&externalSecret, v1.EventTypeWarning, esv1beta1.ReasonUpdateFailed, err.Error())
  216. conditionSynced := NewExternalSecretCondition(esv1beta1.ExternalSecretReady, v1.ConditionFalse, esv1beta1.ConditionReasonSecretSyncedError, errDeleteSecret)
  217. SetExternalSecretCondition(&externalSecret, *conditionSynced)
  218. syncCallsError.With(resourceLabels).Inc()
  219. }
  220. conditionSynced := NewExternalSecretCondition(esv1beta1.ExternalSecretReady, v1.ConditionTrue, esv1beta1.ConditionReasonSecretDeleted, "secret deleted due to DeletionPolicy")
  221. SetExternalSecretCondition(&externalSecret, *conditionSynced)
  222. return ctrl.Result{RequeueAfter: refreshInt}, err
  223. case esv1beta1.DeletionPolicyMerge:
  224. // noop, handled below
  225. // In case provider secrets don't exist the kubernetes secret will be kept as-is.
  226. case esv1beta1.DeletionPolicyRetain:
  227. return ctrl.Result{RequeueAfter: refreshInt}, nil
  228. }
  229. }
  230. mutationFunc := func() error {
  231. if externalSecret.Spec.Target.CreationPolicy == esv1beta1.CreatePolicyOwner {
  232. err = controllerutil.SetControllerReference(&externalSecret, &secret.ObjectMeta, r.Scheme)
  233. if err != nil {
  234. return fmt.Errorf(errSetCtrlReference, err)
  235. }
  236. }
  237. if secret.Data == nil {
  238. secret.Data = make(map[string][]byte)
  239. }
  240. // diff existing keys
  241. keys, err := getManagedKeys(&existingSecret, externalSecret.Name)
  242. if err != nil {
  243. return err
  244. }
  245. // Sanitize data map for any updates on the ES
  246. for _, key := range keys {
  247. if dataMap[key] == nil {
  248. secret.Data[key] = nil
  249. // Sanitizing any templated / updated keys
  250. delete(secret.Data, key)
  251. }
  252. }
  253. err = r.applyTemplate(ctx, &externalSecret, secret, dataMap)
  254. if err != nil {
  255. return fmt.Errorf(errApplyTemplate, err)
  256. }
  257. if externalSecret.Spec.Target.CreationPolicy == esv1beta1.CreatePolicyOwner {
  258. lblValue := utils.ObjectHash(fmt.Sprintf("%v/%v", externalSecret.Namespace, externalSecret.Name))
  259. secret.Labels[esv1beta1.LabelOwner] = lblValue
  260. }
  261. secret.Annotations[esv1beta1.AnnotationDataHash] = r.computeDataHashAnnotation(&existingSecret, secret)
  262. return nil
  263. }
  264. switch externalSecret.Spec.Target.CreationPolicy { //nolint:exhaustive
  265. case esv1beta1.CreatePolicyMerge:
  266. err = patchSecret(ctx, r.Client, r.Scheme, secret, mutationFunc, externalSecret.Name)
  267. if err == nil {
  268. externalSecret.Status.Binding = v1.LocalObjectReference{Name: secret.Name}
  269. }
  270. case esv1beta1.CreatePolicyNone:
  271. log.V(1).Info("secret creation skipped due to creationPolicy=None")
  272. err = nil
  273. default:
  274. var created bool
  275. created, err = createOrUpdate(ctx, r.Client, secret, mutationFunc, externalSecret.Name)
  276. if err == nil {
  277. externalSecret.Status.Binding = v1.LocalObjectReference{Name: secret.Name}
  278. }
  279. // cleanup orphaned secrets
  280. if created {
  281. delErr := deleteOrphanedSecrets(ctx, r.Client, &externalSecret)
  282. if delErr != nil {
  283. msg := fmt.Sprintf("failed to clean up orphaned secrets: %v", delErr)
  284. log.Error(delErr, msg)
  285. r.recorder.Event(&externalSecret, v1.EventTypeWarning, esv1beta1.ReasonUpdateFailed, delErr.Error())
  286. conditionSynced := NewExternalSecretCondition(esv1beta1.ExternalSecretReady, v1.ConditionFalse, esv1beta1.ConditionReasonSecretSyncedError, msg)
  287. SetExternalSecretCondition(&externalSecret, *conditionSynced)
  288. syncCallsError.With(resourceLabels).Inc()
  289. return ctrl.Result{}, delErr
  290. }
  291. }
  292. }
  293. if err != nil {
  294. log.Error(err, errUpdateSecret)
  295. r.recorder.Event(&externalSecret, v1.EventTypeWarning, esv1beta1.ReasonUpdateFailed, err.Error())
  296. conditionSynced := NewExternalSecretCondition(esv1beta1.ExternalSecretReady, v1.ConditionFalse, esv1beta1.ConditionReasonSecretSyncedError, errUpdateSecret)
  297. SetExternalSecretCondition(&externalSecret, *conditionSynced)
  298. syncCallsError.With(resourceLabels).Inc()
  299. return ctrl.Result{}, err
  300. }
  301. r.recorder.Event(&externalSecret, v1.EventTypeNormal, esv1beta1.ReasonUpdated, "Updated Secret")
  302. conditionSynced := NewExternalSecretCondition(esv1beta1.ExternalSecretReady, v1.ConditionTrue, esv1beta1.ConditionReasonSecretSynced, "Secret was synced")
  303. currCond := GetExternalSecretCondition(externalSecret.Status, esv1beta1.ExternalSecretReady)
  304. SetExternalSecretCondition(&externalSecret, *conditionSynced)
  305. externalSecret.Status.RefreshTime = metav1.NewTime(start)
  306. externalSecret.Status.SyncedResourceVersion = getResourceVersion(externalSecret)
  307. if currCond == nil || currCond.Status != conditionSynced.Status {
  308. log.Info("reconciled secret") // Log once if on success in any verbosity
  309. } else {
  310. log.V(1).Info("reconciled secret") // Log all reconciliation cycles if higher verbosity applied
  311. }
  312. return ctrl.Result{
  313. RequeueAfter: refreshInt,
  314. }, nil
  315. }
  316. func deleteOrphanedSecrets(ctx context.Context, cl client.Client, externalSecret *esv1beta1.ExternalSecret) error {
  317. secretList := v1.SecretList{}
  318. lblValue := utils.ObjectHash(fmt.Sprintf("%v/%v", externalSecret.Namespace, externalSecret.Name))
  319. ls := &metav1.LabelSelector{
  320. MatchLabels: map[string]string{
  321. esv1beta1.LabelOwner: lblValue,
  322. },
  323. }
  324. labelSelector, err := metav1.LabelSelectorAsSelector(ls)
  325. if err != nil {
  326. return err
  327. }
  328. err = cl.List(ctx, &secretList, &client.ListOptions{LabelSelector: labelSelector})
  329. if err != nil {
  330. return err
  331. }
  332. for key, secret := range secretList.Items {
  333. if externalSecret.Spec.Target.Name != "" && secret.Name != externalSecret.Spec.Target.Name {
  334. err = cl.Delete(ctx, &secretList.Items[key])
  335. if err != nil {
  336. return err
  337. }
  338. }
  339. }
  340. return nil
  341. }
  342. func createOrUpdate(ctx context.Context, c client.Client, obj client.Object, f func() error, fieldOwner string) (bool, error) {
  343. fqdn := fmt.Sprintf(fieldOwnerTemplate, fieldOwner)
  344. key := client.ObjectKeyFromObject(obj)
  345. if err := c.Get(ctx, key, obj); err != nil {
  346. if !apierrors.IsNotFound(err) {
  347. return false, err
  348. }
  349. if err := f(); err != nil {
  350. return false, err
  351. }
  352. // Setting Field Owner even for CreationPolicy==Create
  353. if err := c.Create(ctx, obj, client.FieldOwner(fqdn)); err != nil {
  354. return false, err
  355. }
  356. return true, nil
  357. }
  358. existing := obj.DeepCopyObject()
  359. if err := f(); err != nil {
  360. return false, err
  361. }
  362. if equality.Semantic.DeepEqual(existing, obj) {
  363. return false, nil
  364. }
  365. if err := c.Update(ctx, obj, client.FieldOwner(fqdn)); err != nil {
  366. return false, err
  367. }
  368. return false, nil
  369. }
  370. func patchSecret(ctx context.Context, c client.Client, scheme *runtime.Scheme, secret *v1.Secret, mutationFunc func() error, fieldOwner string) error {
  371. fqdn := fmt.Sprintf(fieldOwnerTemplate, fieldOwner)
  372. err := c.Get(ctx, client.ObjectKeyFromObject(secret), secret.DeepCopy())
  373. if apierrors.IsNotFound(err) {
  374. return fmt.Errorf(errPolicyMergeNotFound, secret.Name)
  375. }
  376. if err != nil {
  377. return fmt.Errorf(errPolicyMergeGetSecret, secret.Name, err)
  378. }
  379. existing := secret.DeepCopyObject()
  380. err = mutationFunc()
  381. if err != nil {
  382. return fmt.Errorf(errPolicyMergeMutate, secret.Name, err)
  383. }
  384. // GVK is missing in the Secret, see:
  385. // https://github.com/kubernetes-sigs/controller-runtime/issues/526
  386. // https://github.com/kubernetes-sigs/controller-runtime/issues/1517
  387. // https://github.com/kubernetes/kubernetes/issues/80609
  388. // we need to manually set it before doing a Patch() as it depends on the GVK
  389. gvks, unversioned, err := scheme.ObjectKinds(secret)
  390. if err != nil {
  391. return err
  392. }
  393. if !unversioned && len(gvks) == 1 {
  394. secret.SetGroupVersionKind(gvks[0])
  395. }
  396. if equality.Semantic.DeepEqual(existing, secret) {
  397. return nil
  398. }
  399. // Cleaning up Managed fields manually as to keep patch coherence
  400. secret.ObjectMeta.ManagedFields = nil
  401. // we're not able to resolve conflicts so we force ownership
  402. // see: https://kubernetes.io/docs/reference/using-api/server-side-apply/#using-server-side-apply-in-a-controller
  403. err = c.Patch(ctx, secret, client.Apply, client.FieldOwner(fqdn), client.ForceOwnership)
  404. if err != nil {
  405. return fmt.Errorf(errPolicyMergePatch, secret.Name, err)
  406. }
  407. return nil
  408. }
  409. func getManagedKeys(secret *v1.Secret, fieldOwner string) ([]string, error) {
  410. fqdn := fmt.Sprintf(fieldOwnerTemplate, fieldOwner)
  411. var keys []string
  412. for _, v := range secret.ObjectMeta.ManagedFields {
  413. if v.Manager != fqdn {
  414. continue
  415. }
  416. fields := make(map[string]interface{})
  417. err := json.Unmarshal(v.FieldsV1.Raw, &fields)
  418. if err != nil {
  419. return nil, fmt.Errorf("error unmarshaling managed fields: %w", err)
  420. }
  421. dataFields := fields["f:data"]
  422. if dataFields == nil {
  423. continue
  424. }
  425. df, ok := dataFields.(map[string]interface{})
  426. if !ok {
  427. continue
  428. }
  429. for k := range df {
  430. if k == "." {
  431. continue
  432. }
  433. keys = append(keys, strings.TrimPrefix(k, "f:"))
  434. }
  435. }
  436. return keys, nil
  437. }
  438. func getResourceVersion(es esv1beta1.ExternalSecret) string {
  439. return fmt.Sprintf("%d-%s", es.ObjectMeta.GetGeneration(), hashMeta(es.ObjectMeta))
  440. }
  441. func hashMeta(m metav1.ObjectMeta) string {
  442. type meta struct {
  443. annotations map[string]string
  444. labels map[string]string
  445. }
  446. return utils.ObjectHash(meta{
  447. annotations: m.Annotations,
  448. labels: m.Labels,
  449. })
  450. }
  451. func shouldSkipClusterSecretStore(r *Reconciler, es esv1beta1.ExternalSecret) bool {
  452. return !r.ClusterSecretStoreEnabled && es.Spec.SecretStoreRef.Kind == esv1beta1.ClusterSecretStoreKind
  453. }
  454. // shouldSkipUnmanagedStore iterates over all secretStore references in the externalSecret spec,
  455. // fetches the store and evaluates the controllerClass property.
  456. // Returns true if any storeRef points to store with a non-matching controllerClass.
  457. func shouldSkipUnmanagedStore(ctx context.Context, namespace string, r *Reconciler, es esv1beta1.ExternalSecret) (bool, error) {
  458. var storeList []esv1beta1.SecretStoreRef
  459. if es.Spec.SecretStoreRef.Name != "" {
  460. storeList = append(storeList, es.Spec.SecretStoreRef)
  461. }
  462. for _, ref := range es.Spec.Data {
  463. if ref.SourceRef != nil && ref.SourceRef.SecretStoreRef != nil {
  464. storeList = append(storeList, *ref.SourceRef.SecretStoreRef)
  465. }
  466. }
  467. for _, ref := range es.Spec.DataFrom {
  468. if ref.SourceRef != nil && ref.SourceRef.SecretStoreRef != nil {
  469. storeList = append(storeList, *ref.SourceRef.SecretStoreRef)
  470. }
  471. // verify that generator's controllerClass matches
  472. if ref.SourceRef != nil && ref.SourceRef.GeneratorRef != nil {
  473. genDef, err := r.getGeneratorDefinition(ctx, namespace, ref.SourceRef)
  474. if err != nil {
  475. return false, err
  476. }
  477. skipGenerator, err := shouldSkipGenerator(r, genDef)
  478. if err != nil {
  479. return false, err
  480. }
  481. if skipGenerator {
  482. return true, nil
  483. }
  484. }
  485. }
  486. for _, ref := range storeList {
  487. var store esv1beta1.GenericStore
  488. switch ref.Kind {
  489. case esv1beta1.SecretStoreKind, "":
  490. store = &esv1beta1.SecretStore{}
  491. case esv1beta1.ClusterSecretStoreKind:
  492. store = &esv1beta1.ClusterSecretStore{}
  493. namespace = ""
  494. }
  495. err := r.Client.Get(ctx, types.NamespacedName{
  496. Name: ref.Name,
  497. Namespace: namespace,
  498. }, store)
  499. if err != nil {
  500. return false, err
  501. }
  502. class := store.GetSpec().Controller
  503. if class != "" && class != r.ControllerClass {
  504. return true, nil
  505. }
  506. }
  507. return false, nil
  508. }
  509. func shouldRefresh(es esv1beta1.ExternalSecret) bool {
  510. // refresh if resource version changed
  511. if es.Status.SyncedResourceVersion != getResourceVersion(es) {
  512. return true
  513. }
  514. // skip refresh if refresh interval is 0
  515. if es.Spec.RefreshInterval.Duration == 0 && es.Status.SyncedResourceVersion != "" {
  516. return false
  517. }
  518. if es.Status.RefreshTime.IsZero() {
  519. return true
  520. }
  521. return es.Status.RefreshTime.Add(es.Spec.RefreshInterval.Duration).Before(time.Now())
  522. }
  523. func shouldReconcile(es esv1beta1.ExternalSecret) bool {
  524. if es.Spec.Target.Immutable && hasSyncedCondition(es) {
  525. return false
  526. }
  527. return true
  528. }
  529. func hasSyncedCondition(es esv1beta1.ExternalSecret) bool {
  530. for _, condition := range es.Status.Conditions {
  531. if condition.Reason == "SecretSynced" {
  532. return true
  533. }
  534. }
  535. return false
  536. }
  537. // isSecretValid checks if the secret exists, and it's data is consistent with the calculated hash.
  538. func isSecretValid(existingSecret v1.Secret) bool {
  539. // if target secret doesn't exist, or annotations as not set, we need to refresh
  540. if existingSecret.UID == "" || existingSecret.Annotations == nil {
  541. return false
  542. }
  543. // if the calculated hash is different from the calculation, then it's invalid
  544. if existingSecret.Annotations[esv1beta1.AnnotationDataHash] != utils.ObjectHash(existingSecret.Data) {
  545. return false
  546. }
  547. return true
  548. }
  549. // computeDataHashAnnotation generate a hash of the secret data combining the old key with the new keys to add or override.
  550. func (r *Reconciler) computeDataHashAnnotation(existing, secret *v1.Secret) string {
  551. data := make(map[string][]byte)
  552. for k, v := range existing.Data {
  553. data[k] = v
  554. }
  555. for k, v := range secret.Data {
  556. data[k] = v
  557. }
  558. return utils.ObjectHash(data)
  559. }
  560. // SetupWithManager returns a new controller builder that will be started by the provided Manager.
  561. func (r *Reconciler) SetupWithManager(mgr ctrl.Manager, opts controller.Options) error {
  562. r.recorder = mgr.GetEventRecorderFor("external-secrets")
  563. return ctrl.NewControllerManagedBy(mgr).
  564. WithOptions(opts).
  565. For(&esv1beta1.ExternalSecret{}).
  566. Owns(&v1.Secret{}, builder.OnlyMetadata).
  567. Complete(r)
  568. }