secretsmanager.go 16 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528529530531532533534535536537538539540541542543544545546547548549550551552553554555556557558559560
  1. /*
  2. Licensed under the Apache License, Version 2.0 (the "License");
  3. you may not use this file except in compliance with the License.
  4. You may obtain a copy of the License at
  5. http://www.apache.org/licenses/LICENSE-2.0
  6. Unless required by applicable law or agreed to in writing, software
  7. distributed under the License is distributed on an "AS IS" BASIS,
  8. WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
  9. See the License for the specific language governing permissions and
  10. limitations under the License.
  11. */
  12. package secretsmanager
  13. import (
  14. "bytes"
  15. "context"
  16. "encoding/json"
  17. "errors"
  18. "fmt"
  19. "math/big"
  20. "strings"
  21. "github.com/aws/aws-sdk-go/aws"
  22. "github.com/aws/aws-sdk-go/aws/awserr"
  23. "github.com/aws/aws-sdk-go/aws/request"
  24. "github.com/aws/aws-sdk-go/aws/session"
  25. awssm "github.com/aws/aws-sdk-go/service/secretsmanager"
  26. "github.com/google/uuid"
  27. "github.com/tidwall/gjson"
  28. "github.com/tidwall/sjson"
  29. corev1 "k8s.io/api/core/v1"
  30. utilpointer "k8s.io/utils/ptr"
  31. ctrl "sigs.k8s.io/controller-runtime"
  32. esv1beta1 "github.com/external-secrets/external-secrets/apis/externalsecrets/v1beta1"
  33. "github.com/external-secrets/external-secrets/pkg/constants"
  34. "github.com/external-secrets/external-secrets/pkg/find"
  35. "github.com/external-secrets/external-secrets/pkg/metrics"
  36. "github.com/external-secrets/external-secrets/pkg/provider/aws/util"
  37. )
  38. // https://github.com/external-secrets/external-secrets/issues/644
  39. var _ esv1beta1.SecretsClient = &SecretsManager{}
  40. // SecretsManager is a provider for AWS SecretsManager.
  41. type SecretsManager struct {
  42. sess *session.Session
  43. client SMInterface
  44. referentAuth bool
  45. cache map[string]*awssm.GetSecretValueOutput
  46. config *esv1beta1.SecretsManager
  47. }
  48. // SMInterface is a subset of the smiface api.
  49. // see: https://docs.aws.amazon.com/sdk-for-go/api/service/secretsmanager/secretsmanageriface/
  50. type SMInterface interface {
  51. ListSecrets(*awssm.ListSecretsInput) (*awssm.ListSecretsOutput, error)
  52. GetSecretValue(*awssm.GetSecretValueInput) (*awssm.GetSecretValueOutput, error)
  53. CreateSecretWithContext(aws.Context, *awssm.CreateSecretInput, ...request.Option) (*awssm.CreateSecretOutput, error)
  54. GetSecretValueWithContext(aws.Context, *awssm.GetSecretValueInput, ...request.Option) (*awssm.GetSecretValueOutput, error)
  55. PutSecretValueWithContext(aws.Context, *awssm.PutSecretValueInput, ...request.Option) (*awssm.PutSecretValueOutput, error)
  56. DescribeSecretWithContext(aws.Context, *awssm.DescribeSecretInput, ...request.Option) (*awssm.DescribeSecretOutput, error)
  57. DeleteSecretWithContext(ctx aws.Context, input *awssm.DeleteSecretInput, opts ...request.Option) (*awssm.DeleteSecretOutput, error)
  58. }
  59. const (
  60. errUnexpectedFindOperator = "unexpected find operator"
  61. managedBy = "managed-by"
  62. externalSecrets = "external-secrets"
  63. initialVersion = "00000000-0000-0000-0000-000000000001"
  64. )
  65. var log = ctrl.Log.WithName("provider").WithName("aws").WithName("secretsmanager")
  66. // New creates a new SecretsManager client.
  67. func New(sess *session.Session, cfg *aws.Config, secretsManagerCfg *esv1beta1.SecretsManager, referentAuth bool) (*SecretsManager, error) {
  68. return &SecretsManager{
  69. sess: sess,
  70. client: awssm.New(sess, cfg),
  71. referentAuth: referentAuth,
  72. cache: make(map[string]*awssm.GetSecretValueOutput),
  73. config: secretsManagerCfg,
  74. }, nil
  75. }
  76. func (sm *SecretsManager) fetch(ctx context.Context, ref esv1beta1.ExternalSecretDataRemoteRef) (*awssm.GetSecretValueOutput, error) {
  77. ver := "AWSCURRENT"
  78. valueFrom := "SECRET"
  79. if ref.Version != "" {
  80. ver = ref.Version
  81. }
  82. if ref.MetadataPolicy == esv1beta1.ExternalSecretMetadataPolicyFetch {
  83. valueFrom = "TAG"
  84. }
  85. log.Info("fetching secret value", "key", ref.Key, "version", ver, "value", valueFrom)
  86. cacheKey := fmt.Sprintf("%s#%s#%s", ref.Key, ver, valueFrom)
  87. if secretOut, found := sm.cache[cacheKey]; found {
  88. log.Info("found secret in cache", "key", ref.Key, "version", ver)
  89. return secretOut, nil
  90. }
  91. var secretOut *awssm.GetSecretValueOutput
  92. var err error
  93. if ref.MetadataPolicy == esv1beta1.ExternalSecretMetadataPolicyFetch {
  94. describeSecretInput := &awssm.DescribeSecretInput{
  95. SecretId: &ref.Key,
  96. }
  97. descOutput, err := sm.client.DescribeSecretWithContext(ctx, describeSecretInput)
  98. if err != nil {
  99. return nil, err
  100. }
  101. log.Info("found metadata secret", "key", ref.Key, "output", descOutput)
  102. jsonTags, err := util.SecretTagsToJSONString(descOutput.Tags)
  103. if err != nil {
  104. return nil, err
  105. }
  106. secretOut = &awssm.GetSecretValueOutput{
  107. ARN: descOutput.ARN,
  108. CreatedDate: descOutput.CreatedDate,
  109. Name: descOutput.Name,
  110. SecretString: &jsonTags,
  111. VersionId: &ver,
  112. }
  113. } else {
  114. var getSecretValueInput *awssm.GetSecretValueInput
  115. if strings.HasPrefix(ver, "uuid/") {
  116. versionID := strings.TrimPrefix(ver, "uuid/")
  117. getSecretValueInput = &awssm.GetSecretValueInput{
  118. SecretId: &ref.Key,
  119. VersionId: &versionID,
  120. }
  121. } else {
  122. getSecretValueInput = &awssm.GetSecretValueInput{
  123. SecretId: &ref.Key,
  124. VersionStage: &ver,
  125. }
  126. }
  127. secretOut, err = sm.client.GetSecretValue(getSecretValueInput)
  128. metrics.ObserveAPICall(constants.ProviderAWSSM, constants.CallAWSSMGetSecretValue, err)
  129. var nf *awssm.ResourceNotFoundException
  130. if errors.As(err, &nf) {
  131. return nil, esv1beta1.NoSecretErr
  132. }
  133. if err != nil {
  134. return nil, err
  135. }
  136. }
  137. sm.cache[cacheKey] = secretOut
  138. return secretOut, nil
  139. }
  140. func (sm *SecretsManager) DeleteSecret(ctx context.Context, remoteRef esv1beta1.PushSecretRemoteRef) error {
  141. secretName := remoteRef.GetRemoteKey()
  142. secretValue := awssm.GetSecretValueInput{
  143. SecretId: &secretName,
  144. }
  145. secretInput := awssm.DescribeSecretInput{
  146. SecretId: &secretName,
  147. }
  148. awsSecret, err := sm.client.GetSecretValueWithContext(ctx, &secretValue)
  149. metrics.ObserveAPICall(constants.ProviderAWSSM, constants.CallAWSSMGetSecretValue, err)
  150. var aerr awserr.Error
  151. if err != nil {
  152. if ok := errors.As(err, &aerr); !ok {
  153. return err
  154. }
  155. if aerr.Code() == awssm.ErrCodeResourceNotFoundException {
  156. return nil
  157. }
  158. return err
  159. }
  160. data, err := sm.client.DescribeSecretWithContext(ctx, &secretInput)
  161. metrics.ObserveAPICall(constants.ProviderAWSSM, constants.CallAWSSMDescribeSecret, err)
  162. if err != nil {
  163. return err
  164. }
  165. if !isManagedByESO(data) {
  166. return nil
  167. }
  168. deleteInput := &awssm.DeleteSecretInput{
  169. SecretId: awsSecret.ARN,
  170. }
  171. if sm.config != nil && sm.config.ForceDeleteWithoutRecovery {
  172. deleteInput.ForceDeleteWithoutRecovery = &sm.config.ForceDeleteWithoutRecovery
  173. }
  174. if sm.config != nil && sm.config.RecoveryWindowInDays > 0 {
  175. deleteInput.RecoveryWindowInDays = &sm.config.RecoveryWindowInDays
  176. }
  177. err = util.ValidateDeleteSecretInput(*deleteInput)
  178. if err != nil {
  179. return err
  180. }
  181. _, err = sm.client.DeleteSecretWithContext(ctx, deleteInput)
  182. metrics.ObserveAPICall(constants.ProviderAWSSM, constants.CallAWSSMDeleteSecret, err)
  183. return err
  184. }
  185. func (sm *SecretsManager) PushSecret(ctx context.Context, secret *corev1.Secret, psd esv1beta1.PushSecretData) error {
  186. if psd.GetSecretKey() == "" {
  187. return fmt.Errorf("pushing the whole secret is not yet implemented")
  188. }
  189. secretName := psd.GetRemoteKey()
  190. value := secret.Data[psd.GetSecretKey()]
  191. managedBy := managedBy
  192. externalSecrets := externalSecrets
  193. externalSecretsTag := []*awssm.Tag{
  194. {
  195. Key: &managedBy,
  196. Value: &externalSecrets,
  197. },
  198. }
  199. secretValue := awssm.GetSecretValueInput{
  200. SecretId: &secretName,
  201. }
  202. secretInput := awssm.DescribeSecretInput{
  203. SecretId: &secretName,
  204. }
  205. awsSecret, err := sm.client.GetSecretValueWithContext(ctx, &secretValue)
  206. metrics.ObserveAPICall(constants.ProviderAWSSM, constants.CallAWSSMGetSecretValue, err)
  207. if psd.GetProperty() != "" {
  208. currentSecret := sm.retrievePayload(awsSecret)
  209. if currentSecret != "" && !gjson.Valid(currentSecret) {
  210. return errors.New("PushSecret for aws secrets manager with a pushSecretData property requires a json secret")
  211. }
  212. value, _ = sjson.SetBytes([]byte(currentSecret), psd.GetProperty(), value)
  213. }
  214. var aerr awserr.Error
  215. if err != nil {
  216. if ok := errors.As(err, &aerr); !ok {
  217. return err
  218. }
  219. if aerr.Code() == awssm.ErrCodeResourceNotFoundException {
  220. secretVersion := initialVersion
  221. secretRequest := awssm.CreateSecretInput{
  222. Name: &secretName,
  223. SecretBinary: value,
  224. Tags: externalSecretsTag,
  225. ClientRequestToken: &secretVersion,
  226. }
  227. _, err = sm.client.CreateSecretWithContext(ctx, &secretRequest)
  228. metrics.ObserveAPICall(constants.ProviderAWSSM, constants.CallAWSSMCreateSecret, err)
  229. return err
  230. }
  231. return err
  232. }
  233. data, err := sm.client.DescribeSecretWithContext(ctx, &secretInput)
  234. metrics.ObserveAPICall(constants.ProviderAWSSM, constants.CallAWSSMDescribeSecret, err)
  235. if err != nil {
  236. return err
  237. }
  238. if !isManagedByESO(data) {
  239. return fmt.Errorf("secret not managed by external-secrets")
  240. }
  241. if awsSecret != nil && bytes.Equal(awsSecret.SecretBinary, value) {
  242. return nil
  243. }
  244. newVersionNumber, err := bumpVersionNumber(awsSecret.VersionId)
  245. if err != nil {
  246. return err
  247. }
  248. input := &awssm.PutSecretValueInput{
  249. SecretId: awsSecret.ARN,
  250. SecretBinary: value,
  251. ClientRequestToken: newVersionNumber,
  252. }
  253. _, err = sm.client.PutSecretValueWithContext(ctx, input)
  254. metrics.ObserveAPICall(constants.ProviderAWSSM, constants.CallAWSSMPutSecretValue, err)
  255. return err
  256. }
  257. func padOrTrim(b []byte) []byte {
  258. l := len(b)
  259. size := 16
  260. if l == size {
  261. return b
  262. }
  263. if l > size {
  264. return b[l-size:]
  265. }
  266. tmp := make([]byte, size)
  267. copy(tmp[size-l:], b)
  268. return tmp
  269. }
  270. func bumpVersionNumber(id *string) (*string, error) {
  271. if id == nil {
  272. output := initialVersion
  273. return &output, nil
  274. }
  275. n := new(big.Int)
  276. oldVersion, ok := n.SetString(strings.ReplaceAll(*id, "-", ""), 16)
  277. if !ok {
  278. return nil, fmt.Errorf("expected secret version in AWS SSM to be a UUID but got '%s'", *id)
  279. }
  280. newVersionRaw := oldVersion.Add(oldVersion, big.NewInt(1)).Bytes()
  281. newVersion, err := uuid.FromBytes(padOrTrim(newVersionRaw))
  282. if err != nil {
  283. return nil, err
  284. }
  285. s := newVersion.String()
  286. return &s, nil
  287. }
  288. func isManagedByESO(data *awssm.DescribeSecretOutput) bool {
  289. managedBy := managedBy
  290. externalSecrets := externalSecrets
  291. for _, tag := range data.Tags {
  292. if *tag.Key == managedBy && *tag.Value == externalSecrets {
  293. return true
  294. }
  295. }
  296. return false
  297. }
  298. // GetAllSecrets syncs multiple secrets from aws provider into a single Kubernetes Secret.
  299. func (sm *SecretsManager) GetAllSecrets(ctx context.Context, ref esv1beta1.ExternalSecretFind) (map[string][]byte, error) {
  300. if ref.Name != nil {
  301. return sm.findByName(ctx, ref)
  302. }
  303. if len(ref.Tags) > 0 {
  304. return sm.findByTags(ctx, ref)
  305. }
  306. return nil, errors.New(errUnexpectedFindOperator)
  307. }
  308. func (sm *SecretsManager) findByName(ctx context.Context, ref esv1beta1.ExternalSecretFind) (map[string][]byte, error) {
  309. matcher, err := find.New(*ref.Name)
  310. if err != nil {
  311. return nil, err
  312. }
  313. filters := make([]*awssm.Filter, 0)
  314. if ref.Path != nil {
  315. filters = append(filters, &awssm.Filter{
  316. Key: utilpointer.To(awssm.FilterNameStringTypeName),
  317. Values: []*string{
  318. ref.Path,
  319. },
  320. })
  321. }
  322. data := make(map[string][]byte)
  323. var nextToken *string
  324. for {
  325. it, err := sm.client.ListSecrets(&awssm.ListSecretsInput{
  326. Filters: filters,
  327. NextToken: nextToken,
  328. })
  329. metrics.ObserveAPICall(constants.ProviderAWSSM, constants.CallAWSSMListSecrets, err)
  330. if err != nil {
  331. return nil, err
  332. }
  333. log.V(1).Info("aws sm findByName found", "secrets", len(it.SecretList))
  334. for _, secret := range it.SecretList {
  335. if !matcher.MatchName(*secret.Name) {
  336. continue
  337. }
  338. log.V(1).Info("aws sm findByName matches", "name", *secret.Name)
  339. err = sm.fetchAndSet(ctx, data, *secret.Name)
  340. if err != nil {
  341. return nil, err
  342. }
  343. }
  344. nextToken = it.NextToken
  345. if nextToken == nil {
  346. break
  347. }
  348. }
  349. return data, nil
  350. }
  351. func (sm *SecretsManager) findByTags(ctx context.Context, ref esv1beta1.ExternalSecretFind) (map[string][]byte, error) {
  352. filters := make([]*awssm.Filter, 0)
  353. for k, v := range ref.Tags {
  354. filters = append(filters, &awssm.Filter{
  355. Key: utilpointer.To(awssm.FilterNameStringTypeTagKey),
  356. Values: []*string{
  357. utilpointer.To(k),
  358. },
  359. }, &awssm.Filter{
  360. Key: utilpointer.To(awssm.FilterNameStringTypeTagValue),
  361. Values: []*string{
  362. utilpointer.To(v),
  363. },
  364. })
  365. }
  366. if ref.Path != nil {
  367. filters = append(filters, &awssm.Filter{
  368. Key: utilpointer.To(awssm.FilterNameStringTypeName),
  369. Values: []*string{
  370. ref.Path,
  371. },
  372. })
  373. }
  374. data := make(map[string][]byte)
  375. var nextToken *string
  376. for {
  377. log.V(1).Info("aws sm findByTag", "nextToken", nextToken)
  378. it, err := sm.client.ListSecrets(&awssm.ListSecretsInput{
  379. Filters: filters,
  380. NextToken: nextToken,
  381. })
  382. metrics.ObserveAPICall(constants.ProviderAWSSM, constants.CallAWSSMListSecrets, err)
  383. if err != nil {
  384. return nil, err
  385. }
  386. log.V(1).Info("aws sm findByTag found", "secrets", len(it.SecretList))
  387. for _, secret := range it.SecretList {
  388. err = sm.fetchAndSet(ctx, data, *secret.Name)
  389. if err != nil {
  390. return nil, err
  391. }
  392. }
  393. nextToken = it.NextToken
  394. if nextToken == nil {
  395. break
  396. }
  397. }
  398. return data, nil
  399. }
  400. func (sm *SecretsManager) fetchAndSet(ctx context.Context, data map[string][]byte, name string) error {
  401. sec, err := sm.fetch(ctx, esv1beta1.ExternalSecretDataRemoteRef{
  402. Key: name,
  403. })
  404. if err != nil {
  405. return err
  406. }
  407. if sec.SecretString != nil {
  408. data[name] = []byte(*sec.SecretString)
  409. }
  410. if sec.SecretBinary != nil {
  411. data[name] = sec.SecretBinary
  412. }
  413. return nil
  414. }
  415. // GetSecret returns a single secret from the provider.
  416. func (sm *SecretsManager) GetSecret(ctx context.Context, ref esv1beta1.ExternalSecretDataRemoteRef) ([]byte, error) {
  417. secretOut, err := sm.fetch(ctx, ref)
  418. if errors.Is(err, esv1beta1.NoSecretErr) {
  419. return nil, err
  420. }
  421. if err != nil {
  422. return nil, util.SanitizeErr(err)
  423. }
  424. if ref.Property == "" {
  425. if secretOut.SecretString != nil {
  426. return []byte(*secretOut.SecretString), nil
  427. }
  428. if secretOut.SecretBinary != nil {
  429. return secretOut.SecretBinary, nil
  430. }
  431. return nil, fmt.Errorf("invalid secret received. no secret string nor binary for key: %s", ref.Key)
  432. }
  433. val := sm.mapSecretToGjson(secretOut, ref.Property)
  434. if !val.Exists() {
  435. return nil, fmt.Errorf("key %s does not exist in secret %s", ref.Property, ref.Key)
  436. }
  437. return []byte(val.String()), nil
  438. }
  439. func (sm *SecretsManager) mapSecretToGjson(secretOut *awssm.GetSecretValueOutput, property string) gjson.Result {
  440. payload := sm.retrievePayload(secretOut)
  441. refProperty := sm.escapeDotsIfRequired(property, payload)
  442. val := gjson.Get(payload, refProperty)
  443. return val
  444. }
  445. func (sm *SecretsManager) retrievePayload(secretOut *awssm.GetSecretValueOutput) string {
  446. var payload string
  447. if secretOut.SecretString != nil {
  448. payload = *secretOut.SecretString
  449. }
  450. if secretOut.SecretBinary != nil {
  451. payload = string(secretOut.SecretBinary)
  452. }
  453. return payload
  454. }
  455. func (sm *SecretsManager) escapeDotsIfRequired(currentRefProperty, payload string) string {
  456. // We need to search if a given key with a . exists before using gjson operations.
  457. idx := strings.Index(currentRefProperty, ".")
  458. refProperty := currentRefProperty
  459. if idx > -1 {
  460. refProperty = strings.ReplaceAll(currentRefProperty, ".", "\\.")
  461. val := gjson.Get(payload, refProperty)
  462. if !val.Exists() {
  463. refProperty = currentRefProperty
  464. }
  465. }
  466. return refProperty
  467. }
  468. // GetSecretMap returns multiple k/v pairs from the provider.
  469. func (sm *SecretsManager) GetSecretMap(ctx context.Context, ref esv1beta1.ExternalSecretDataRemoteRef) (map[string][]byte, error) {
  470. log.Info("fetching secret map", "key", ref.Key)
  471. data, err := sm.GetSecret(ctx, ref)
  472. if err != nil {
  473. return nil, err
  474. }
  475. kv := make(map[string]json.RawMessage)
  476. err = json.Unmarshal(data, &kv)
  477. if err != nil {
  478. return nil, fmt.Errorf("unable to unmarshal secret %s: %w", ref.Key, err)
  479. }
  480. secretData := make(map[string][]byte)
  481. for k, v := range kv {
  482. var strVal string
  483. err = json.Unmarshal(v, &strVal)
  484. if err == nil {
  485. secretData[k] = []byte(strVal)
  486. } else {
  487. secretData[k] = v
  488. }
  489. }
  490. return secretData, nil
  491. }
  492. func (sm *SecretsManager) Close(_ context.Context) error {
  493. return nil
  494. }
  495. func (sm *SecretsManager) Validate() (esv1beta1.ValidationResult, error) {
  496. // skip validation stack because it depends on the namespace
  497. // of the ExternalSecret
  498. if sm.referentAuth {
  499. return esv1beta1.ValidationResultUnknown, nil
  500. }
  501. _, err := sm.sess.Config.Credentials.Get()
  502. if err != nil {
  503. return esv1beta1.ValidationResultError, util.SanitizeErr(err)
  504. }
  505. return esv1beta1.ValidationResultReady, nil
  506. }
  507. func (sm *SecretsManager) Capabilities() esv1beta1.SecretStoreCapabilities {
  508. return esv1beta1.SecretStoreReadWrite
  509. }