client.go 17 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528529530531532533534535536537538539540541
  1. /*
  2. Licensed under the Apache License, Version 2.0 (the "License");
  3. you may not use this file except in compliance with the License.
  4. You may obtain a copy of the License at
  5. http://www.apache.org/licenses/LICENSE-2.0
  6. Unless required by applicable law or agreed to in writing, software
  7. distributed under the License is distributed on an "AS IS" BASIS,
  8. WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
  9. See the License for the specific language governing permissions and
  10. limitations under the License.
  11. */
  12. package secretmanager
  13. import (
  14. "bytes"
  15. "context"
  16. "encoding/json"
  17. "errors"
  18. "fmt"
  19. "strconv"
  20. "strings"
  21. secretmanager "cloud.google.com/go/secretmanager/apiv1"
  22. "cloud.google.com/go/secretmanager/apiv1/secretmanagerpb"
  23. "github.com/googleapis/gax-go/v2"
  24. "github.com/googleapis/gax-go/v2/apierror"
  25. "github.com/tidwall/gjson"
  26. "github.com/tidwall/sjson"
  27. "google.golang.org/api/iterator"
  28. "google.golang.org/genproto/protobuf/field_mask"
  29. "google.golang.org/grpc/codes"
  30. "google.golang.org/grpc/status"
  31. ctrl "sigs.k8s.io/controller-runtime"
  32. kclient "sigs.k8s.io/controller-runtime/pkg/client"
  33. esv1beta1 "github.com/external-secrets/external-secrets/apis/externalsecrets/v1beta1"
  34. "github.com/external-secrets/external-secrets/pkg/constants"
  35. "github.com/external-secrets/external-secrets/pkg/find"
  36. "github.com/external-secrets/external-secrets/pkg/metrics"
  37. "github.com/external-secrets/external-secrets/pkg/utils"
  38. )
  39. const (
  40. CloudPlatformRole = "https://www.googleapis.com/auth/cloud-platform"
  41. defaultVersion = "latest"
  42. errGCPSMStore = "received invalid GCPSM SecretStore resource"
  43. errUnableGetCredentials = "unable to get credentials: %w"
  44. errClientClose = "unable to close SecretManager client: %w"
  45. errMissingStoreSpec = "invalid: missing store spec"
  46. errFetchSAKSecret = "could not fetch SecretAccessKey secret: %w"
  47. errMissingSAK = "missing SecretAccessKey"
  48. errUnableProcessJSONCredentials = "failed to process the provided JSON credentials: %w"
  49. errUnableCreateGCPSMClient = "failed to create GCP secretmanager client: %w"
  50. errUninitalizedGCPProvider = "provider GCP is not initialized"
  51. errClientGetSecretAccess = "unable to access Secret from SecretManager Client: %w"
  52. errJSONSecretUnmarshal = "unable to unmarshal secret: %w"
  53. errInvalidStore = "invalid store"
  54. errInvalidStoreSpec = "invalid store spec"
  55. errInvalidStoreProv = "invalid store provider"
  56. errInvalidGCPProv = "invalid gcp secrets manager provider"
  57. errInvalidAuthSecretRef = "invalid auth secret ref: %w"
  58. errInvalidWISARef = "invalid workload identity service account reference: %w"
  59. errUnexpectedFindOperator = "unexpected find operator"
  60. managedByKey = "managed-by"
  61. managedByValue = "external-secrets"
  62. )
  63. type Client struct {
  64. smClient GoogleSecretManagerClient
  65. kube kclient.Client
  66. store *esv1beta1.GCPSMProvider
  67. storeKind string
  68. // namespace of the external secret
  69. namespace string
  70. workloadIdentity *workloadIdentity
  71. }
  72. type GoogleSecretManagerClient interface {
  73. DeleteSecret(ctx context.Context, req *secretmanagerpb.DeleteSecretRequest, opts ...gax.CallOption) error
  74. AccessSecretVersion(ctx context.Context, req *secretmanagerpb.AccessSecretVersionRequest, opts ...gax.CallOption) (*secretmanagerpb.AccessSecretVersionResponse, error)
  75. ListSecrets(ctx context.Context, req *secretmanagerpb.ListSecretsRequest, opts ...gax.CallOption) *secretmanager.SecretIterator
  76. AddSecretVersion(ctx context.Context, req *secretmanagerpb.AddSecretVersionRequest, opts ...gax.CallOption) (*secretmanagerpb.SecretVersion, error)
  77. CreateSecret(ctx context.Context, req *secretmanagerpb.CreateSecretRequest, opts ...gax.CallOption) (*secretmanagerpb.Secret, error)
  78. Close() error
  79. GetSecret(ctx context.Context, req *secretmanagerpb.GetSecretRequest, opts ...gax.CallOption) (*secretmanagerpb.Secret, error)
  80. UpdateSecret(context.Context, *secretmanagerpb.UpdateSecretRequest, ...gax.CallOption) (*secretmanagerpb.Secret, error)
  81. }
  82. var log = ctrl.Log.WithName("provider").WithName("gcp").WithName("secretsmanager")
  83. func (c *Client) DeleteSecret(ctx context.Context, remoteRef esv1beta1.PushRemoteRef) error {
  84. gcpSecret, err := c.smClient.GetSecret(ctx, &secretmanagerpb.GetSecretRequest{
  85. Name: fmt.Sprintf("projects/%s/secrets/%s", c.store.ProjectID, remoteRef.GetRemoteKey()),
  86. })
  87. metrics.ObserveAPICall(constants.ProviderGCPSM, constants.CallGCPSMGetSecret, err)
  88. if err != nil {
  89. if status.Code(err) == codes.NotFound {
  90. return nil
  91. }
  92. return err
  93. }
  94. if manager, ok := gcpSecret.Labels[managedByKey]; !ok || manager != managedByValue {
  95. return nil
  96. }
  97. deleteSecretVersionReq := &secretmanagerpb.DeleteSecretRequest{
  98. Name: fmt.Sprintf("projects/%s/secrets/%s", c.store.ProjectID, remoteRef.GetRemoteKey()),
  99. }
  100. err = c.smClient.DeleteSecret(ctx, deleteSecretVersionReq)
  101. metrics.ObserveAPICall(constants.ProviderGCPSM, constants.CallGCPSMDeleteSecret, err)
  102. return err
  103. }
  104. func parseError(err error) error {
  105. var gerr *apierror.APIError
  106. if errors.As(err, &gerr) && gerr.GRPCStatus().Code() == codes.NotFound {
  107. return esv1beta1.NoSecretError{}
  108. }
  109. return err
  110. }
  111. // PushSecret pushes a kubernetes secret key into gcp provider Secret.
  112. func (c *Client) PushSecret(ctx context.Context, payload []byte, remoteRef esv1beta1.PushRemoteRef) error {
  113. gcpSecret, err := c.smClient.GetSecret(ctx, &secretmanagerpb.GetSecretRequest{
  114. Name: fmt.Sprintf("projects/%s/secrets/%s", c.store.ProjectID, remoteRef.GetRemoteKey()),
  115. })
  116. metrics.ObserveAPICall(constants.ProviderGCPSM, constants.CallGCPSMGetSecret, err)
  117. if err != nil {
  118. if status.Code(err) != codes.NotFound {
  119. return err
  120. }
  121. gcpSecret, err = c.smClient.CreateSecret(ctx, &secretmanagerpb.CreateSecretRequest{
  122. Parent: fmt.Sprintf("projects/%s", c.store.ProjectID),
  123. SecretId: remoteRef.GetRemoteKey(),
  124. Secret: &secretmanagerpb.Secret{
  125. Labels: map[string]string{
  126. managedByKey: managedByValue,
  127. },
  128. Replication: &secretmanagerpb.Replication{
  129. Replication: &secretmanagerpb.Replication_Automatic_{
  130. Automatic: &secretmanagerpb.Replication_Automatic{},
  131. },
  132. },
  133. },
  134. })
  135. metrics.ObserveAPICall(constants.ProviderGCPSM, constants.CallGCPSMCreateSecret, err)
  136. if err != nil {
  137. return err
  138. }
  139. }
  140. manager, ok := gcpSecret.Labels[managedByKey]
  141. if !ok || manager != managedByValue {
  142. if remoteRef.GetProperty() == "" {
  143. return fmt.Errorf("secret %v is not managed by external secrets", remoteRef.GetRemoteKey())
  144. }
  145. labels := map[string]string{}
  146. for k, v := range gcpSecret.Labels {
  147. labels[k] = v
  148. }
  149. labels[managedByKey] = managedByValue
  150. _, err = c.smClient.UpdateSecret(ctx, &secretmanagerpb.UpdateSecretRequest{
  151. Secret: &secretmanagerpb.Secret{
  152. Name: gcpSecret.Name,
  153. Labels: labels,
  154. },
  155. UpdateMask: &field_mask.FieldMask{
  156. Paths: []string{"labels"},
  157. },
  158. })
  159. metrics.ObserveAPICall(constants.ProviderGCPSM, constants.CallGCPSMUpdateSecret, err)
  160. if err != nil {
  161. return err
  162. }
  163. }
  164. gcpVersion, err := c.smClient.AccessSecretVersion(ctx, &secretmanagerpb.AccessSecretVersionRequest{
  165. Name: fmt.Sprintf("projects/%s/secrets/%s/versions/latest", c.store.ProjectID, remoteRef.GetRemoteKey()),
  166. })
  167. metrics.ObserveAPICall(constants.ProviderGCPSM, constants.CallGCPSMAccessSecretVersion, err)
  168. if err != nil && status.Code(err) != codes.NotFound {
  169. return err
  170. }
  171. if gcpVersion != nil && gcpVersion.Payload != nil {
  172. if remoteRef.GetProperty() == "" && bytes.Equal(payload, gcpVersion.Payload.Data) {
  173. return nil
  174. }
  175. if remoteRef.GetProperty() != "" {
  176. val := getDataByProperty(gcpVersion, remoteRef.GetProperty())
  177. if val.Exists() && val.String() == string(payload) {
  178. return nil
  179. }
  180. }
  181. }
  182. data := payload
  183. if remoteRef.GetProperty() != "" {
  184. var base []byte
  185. if gcpVersion != nil && gcpVersion.Payload != nil {
  186. base = gcpVersion.Payload.Data
  187. }
  188. data, err = sjson.SetBytes(base, remoteRef.GetProperty(), payload)
  189. if err != nil {
  190. return err
  191. }
  192. }
  193. addSecretVersionReq := &secretmanagerpb.AddSecretVersionRequest{
  194. Parent: fmt.Sprintf("projects/%s/secrets/%s", c.store.ProjectID, remoteRef.GetRemoteKey()),
  195. Payload: &secretmanagerpb.SecretPayload{
  196. Data: data,
  197. },
  198. }
  199. _, err = c.smClient.AddSecretVersion(ctx, addSecretVersionReq)
  200. metrics.ObserveAPICall(constants.ProviderGCPSM, constants.CallGCPSMAddSecretVersion, err)
  201. return err
  202. }
  203. // GetAllSecrets syncs multiple secrets from gcp provider into a single Kubernetes Secret.
  204. func (c *Client) GetAllSecrets(ctx context.Context, ref esv1beta1.ExternalSecretFind) (map[string][]byte, error) {
  205. if ref.Name != nil {
  206. return c.findByName(ctx, ref)
  207. }
  208. if len(ref.Tags) > 0 {
  209. return c.findByTags(ctx, ref)
  210. }
  211. return nil, errors.New(errUnexpectedFindOperator)
  212. }
  213. func (c *Client) findByName(ctx context.Context, ref esv1beta1.ExternalSecretFind) (map[string][]byte, error) {
  214. // regex matcher
  215. matcher, err := find.New(*ref.Name)
  216. if err != nil {
  217. return nil, err
  218. }
  219. req := &secretmanagerpb.ListSecretsRequest{
  220. Parent: fmt.Sprintf("projects/%s", c.store.ProjectID),
  221. }
  222. if ref.Path != nil {
  223. req.Filter = fmt.Sprintf("name:%s", *ref.Path)
  224. }
  225. // Call the API.
  226. it := c.smClient.ListSecrets(ctx, req)
  227. secretMap := make(map[string][]byte)
  228. var resp *secretmanagerpb.Secret
  229. defer metrics.ObserveAPICall(constants.ProviderGCPSM, constants.CallGCPSMListSecrets, err)
  230. for {
  231. resp, err = it.Next()
  232. if errors.Is(err, iterator.Done) {
  233. break
  234. }
  235. if err != nil {
  236. return nil, fmt.Errorf("failed to list secrets: %w", err)
  237. }
  238. log.V(1).Info("gcp sm findByName found", "secrets", strconv.Itoa(it.PageInfo().Remaining()))
  239. key := c.trimName(resp.Name)
  240. // If we don't match we skip.
  241. // Also, if we have path, and it is not at the beguining we skip.
  242. // We have to check if path is at the beguining of the key because
  243. // there is no way to create a `name:%s*` (starts with) filter
  244. // At https://cloud.google.com/secret-manager/docs/filtering you can use `*`
  245. // but not like that it seems.
  246. if !matcher.MatchName(key) || (ref.Path != nil && !strings.HasPrefix(key, *ref.Path)) {
  247. continue
  248. }
  249. log.V(1).Info("gcp sm findByName matches", "name", resp.Name)
  250. secretMap[key], err = c.getData(ctx, key)
  251. if err != nil {
  252. return nil, err
  253. }
  254. }
  255. return utils.ConvertKeys(ref.ConversionStrategy, secretMap)
  256. }
  257. func (c *Client) getData(ctx context.Context, key string) ([]byte, error) {
  258. dataRef := esv1beta1.ExternalSecretDataRemoteRef{
  259. Key: key,
  260. }
  261. data, err := c.GetSecret(ctx, dataRef)
  262. if err != nil {
  263. return []byte(""), err
  264. }
  265. return data, nil
  266. }
  267. func (c *Client) findByTags(ctx context.Context, ref esv1beta1.ExternalSecretFind) (map[string][]byte, error) {
  268. var tagFilter string
  269. for k, v := range ref.Tags {
  270. tagFilter = fmt.Sprintf("%slabels.%s=%s ", tagFilter, k, v)
  271. }
  272. tagFilter = strings.TrimSuffix(tagFilter, " ")
  273. if ref.Path != nil {
  274. tagFilter = fmt.Sprintf("%s name:%s", tagFilter, *ref.Path)
  275. }
  276. req := &secretmanagerpb.ListSecretsRequest{
  277. Parent: fmt.Sprintf("projects/%s", c.store.ProjectID),
  278. }
  279. log.V(1).Info("gcp sm findByTags", "tagFilter", tagFilter)
  280. req.Filter = tagFilter
  281. // Call the API.
  282. it := c.smClient.ListSecrets(ctx, req)
  283. var resp *secretmanagerpb.Secret
  284. var err error
  285. defer metrics.ObserveAPICall(constants.ProviderGCPSM, constants.CallGCPSMListSecrets, err)
  286. secretMap := make(map[string][]byte)
  287. for {
  288. resp, err = it.Next()
  289. if errors.Is(err, iterator.Done) {
  290. break
  291. }
  292. if err != nil {
  293. return nil, fmt.Errorf("failed to list secrets: %w", err)
  294. }
  295. key := c.trimName(resp.Name)
  296. if ref.Path != nil && !strings.HasPrefix(key, *ref.Path) {
  297. continue
  298. }
  299. log.V(1).Info("gcp sm findByTags matches tags", "name", resp.Name)
  300. secretMap[key], err = c.getData(ctx, key)
  301. if err != nil {
  302. return nil, err
  303. }
  304. }
  305. return utils.ConvertKeys(ref.ConversionStrategy, secretMap)
  306. }
  307. func (c *Client) trimName(name string) string {
  308. projectIDNumuber := c.extractProjectIDNumber(name)
  309. key := strings.TrimPrefix(name, fmt.Sprintf("projects/%s/secrets/", projectIDNumuber))
  310. return key
  311. }
  312. // extractProjectIDNumber grabs the project id from the full name returned by gcp api
  313. // gcp api seems to always return the number and not the project name
  314. // (and users would always use the name, while requests accept both).
  315. func (c *Client) extractProjectIDNumber(secretFullName string) string {
  316. s := strings.Split(secretFullName, "/")
  317. ProjectIDNumuber := s[1]
  318. return ProjectIDNumuber
  319. }
  320. // GetSecret returns a single secret from the provider.
  321. func (c *Client) GetSecret(ctx context.Context, ref esv1beta1.ExternalSecretDataRemoteRef) ([]byte, error) {
  322. if utils.IsNil(c.smClient) || c.store.ProjectID == "" {
  323. return nil, fmt.Errorf(errUninitalizedGCPProvider)
  324. }
  325. if ref.MetadataPolicy == esv1beta1.ExternalSecretMetadataPolicyFetch {
  326. return c.getSecretMetadata(ctx, ref)
  327. }
  328. version := ref.Version
  329. if version == "" {
  330. version = defaultVersion
  331. }
  332. req := &secretmanagerpb.AccessSecretVersionRequest{
  333. Name: fmt.Sprintf("projects/%s/secrets/%s/versions/%s", c.store.ProjectID, ref.Key, version),
  334. }
  335. result, err := c.smClient.AccessSecretVersion(ctx, req)
  336. metrics.ObserveAPICall(constants.ProviderGCPSM, constants.CallGCPSMAccessSecretVersion, err)
  337. err = parseError(err)
  338. if err != nil {
  339. return nil, fmt.Errorf(errClientGetSecretAccess, err)
  340. }
  341. if ref.Property == "" {
  342. if result.Payload.Data != nil {
  343. return result.Payload.Data, nil
  344. }
  345. return nil, fmt.Errorf("invalid secret received. no secret string for key: %s", ref.Key)
  346. }
  347. val := getDataByProperty(result, ref.Property)
  348. if !val.Exists() {
  349. return nil, fmt.Errorf("key %s does not exist in secret %s", ref.Property, ref.Key)
  350. }
  351. return []byte(val.String()), nil
  352. }
  353. func (c *Client) getSecretMetadata(ctx context.Context, ref esv1beta1.ExternalSecretDataRemoteRef) ([]byte, error) {
  354. secret, err := c.smClient.GetSecret(ctx, &secretmanagerpb.GetSecretRequest{
  355. Name: fmt.Sprintf("projects/%s/secrets/%s", c.store.ProjectID, ref.Key),
  356. })
  357. err = parseError(err)
  358. if err != nil {
  359. return nil, fmt.Errorf(errClientGetSecretAccess, err)
  360. }
  361. const (
  362. annotations = "annotations"
  363. labels = "labels"
  364. )
  365. extractMetadataKey := func(s string, p string) string {
  366. prefix := p + "."
  367. if !strings.HasPrefix(s, prefix) {
  368. return ""
  369. }
  370. return strings.TrimPrefix(s, prefix)
  371. }
  372. if annotation := extractMetadataKey(ref.Property, annotations); annotation != "" {
  373. v, ok := secret.GetAnnotations()[annotation]
  374. if !ok {
  375. return nil, fmt.Errorf("annotation with key %s does not exist in secret %s", annotation, ref.Key)
  376. }
  377. return []byte(v), nil
  378. }
  379. if label := extractMetadataKey(ref.Property, labels); label != "" {
  380. v, ok := secret.GetLabels()[label]
  381. if !ok {
  382. return nil, fmt.Errorf("label with key %s does not exist in secret %s", label, ref.Key)
  383. }
  384. return []byte(v), nil
  385. }
  386. if ref.Property == annotations {
  387. j, err := json.Marshal(secret.GetAnnotations())
  388. if err != nil {
  389. return nil, fmt.Errorf("faild marshaling annotations into json: %w", err)
  390. }
  391. return j, nil
  392. }
  393. if ref.Property == labels {
  394. j, err := json.Marshal(secret.GetLabels())
  395. if err != nil {
  396. return nil, fmt.Errorf("faild marshaling labels into json: %w", err)
  397. }
  398. return j, nil
  399. }
  400. if ref.Property != "" {
  401. return nil, fmt.Errorf("invalid property %s: metadata property should start with either %s or %s", ref.Property, annotations, labels)
  402. }
  403. j, err := json.Marshal(map[string]map[string]string{
  404. "annotations": secret.GetAnnotations(),
  405. "labels": secret.GetLabels(),
  406. })
  407. if err != nil {
  408. return nil, fmt.Errorf("faild marshaling metadata map into json: %w", err)
  409. }
  410. return j, nil
  411. }
  412. // GetSecretMap returns multiple k/v pairs from the provider.
  413. func (c *Client) GetSecretMap(ctx context.Context, ref esv1beta1.ExternalSecretDataRemoteRef) (map[string][]byte, error) {
  414. if c.smClient == nil || c.store.ProjectID == "" {
  415. return nil, fmt.Errorf(errUninitalizedGCPProvider)
  416. }
  417. data, err := c.GetSecret(ctx, ref)
  418. if err != nil {
  419. return nil, err
  420. }
  421. kv := make(map[string]json.RawMessage)
  422. err = json.Unmarshal(data, &kv)
  423. if err != nil {
  424. return nil, fmt.Errorf(errJSONSecretUnmarshal, err)
  425. }
  426. secretData := make(map[string][]byte)
  427. for k, v := range kv {
  428. var strVal string
  429. err = json.Unmarshal(v, &strVal)
  430. if err == nil {
  431. secretData[k] = []byte(strVal)
  432. } else {
  433. secretData[k] = v
  434. }
  435. }
  436. return secretData, nil
  437. }
  438. func (c *Client) Close(_ context.Context) error {
  439. var err error
  440. if c.smClient != nil {
  441. err = c.smClient.Close()
  442. }
  443. if c.workloadIdentity != nil {
  444. err = c.workloadIdentity.Close()
  445. }
  446. useMu.Unlock()
  447. if err != nil {
  448. return fmt.Errorf(errClientClose, err)
  449. }
  450. return nil
  451. }
  452. func (c *Client) Validate() (esv1beta1.ValidationResult, error) {
  453. if c.storeKind == esv1beta1.ClusterSecretStoreKind && isReferentSpec(c.store) {
  454. return esv1beta1.ValidationResultUnknown, nil
  455. }
  456. return esv1beta1.ValidationResultReady, nil
  457. }
  458. func getDataByProperty(resp *secretmanagerpb.AccessSecretVersionResponse, property string) gjson.Result {
  459. var payload string
  460. if resp.Payload.Data != nil {
  461. payload = string(resp.Payload.Data)
  462. }
  463. idx := strings.Index(property, ".")
  464. refProperty := property
  465. if idx > 0 {
  466. refProperty = strings.ReplaceAll(refProperty, ".", "\\.")
  467. val := gjson.Get(payload, refProperty)
  468. if val.Exists() {
  469. return val
  470. }
  471. }
  472. return gjson.Get(payload, property)
  473. }