keyvault.go 49 KB

1234567891011121314151617181920212223242526272829303132333435363738394041424344454647484950515253545556575859606162636465666768697071727374757677787980818283848586878889909192939495969798991001011021031041051061071081091101111121131141151161171181191201211221231241251261271281291301311321331341351361371381391401411421431441451461471481491501511521531541551561571581591601611621631641651661671681691701711721731741751761771781791801811821831841851861871881891901911921931941951961971981992002012022032042052062072082092102112122132142152162172182192202212222232242252262272282292302312322332342352362372382392402412422432442452462472482492502512522532542552562572582592602612622632642652662672682692702712722732742752762772782792802812822832842852862872882892902912922932942952962972982993003013023033043053063073083093103113123133143153163173183193203213223233243253263273283293303313323333343353363373383393403413423433443453463473483493503513523533543553563573583593603613623633643653663673683693703713723733743753763773783793803813823833843853863873883893903913923933943953963973983994004014024034044054064074084094104114124134144154164174184194204214224234244254264274284294304314324334344354364374384394404414424434444454464474484494504514524534544554564574584594604614624634644654664674684694704714724734744754764774784794804814824834844854864874884894904914924934944954964974984995005015025035045055065075085095105115125135145155165175185195205215225235245255265275285295305315325335345355365375385395405415425435445455465475485495505515525535545555565575585595605615625635645655665675685695705715725735745755765775785795805815825835845855865875885895905915925935945955965975985996006016026036046056066076086096106116126136146156166176186196206216226236246256266276286296306316326336346356366376386396406416426436446456466476486496506516526536546556566576586596606616626636646656666676686696706716726736746756766776786796806816826836846856866876886896906916926936946956966976986997007017027037047057067077087097107117127137147157167177187197207217227237247257267277287297307317327337347357367377387397407417427437447457467477487497507517527537547557567577587597607617627637647657667677687697707717727737747757767777787797807817827837847857867877887897907917927937947957967977987998008018028038048058068078088098108118128138148158168178188198208218228238248258268278288298308318328338348358368378388398408418428438448458468478488498508518528538548558568578588598608618628638648658668678688698708718728738748758768778788798808818828838848858868878888898908918928938948958968978988999009019029039049059069079089099109119129139149159169179189199209219229239249259269279289299309319329339349359369379389399409419429439449459469479489499509519529539549559569579589599609619629639649659669679689699709719729739749759769779789799809819829839849859869879889899909919929939949959969979989991000100110021003100410051006100710081009101010111012101310141015101610171018101910201021102210231024102510261027102810291030103110321033103410351036103710381039104010411042104310441045104610471048104910501051105210531054105510561057105810591060106110621063106410651066106710681069107010711072107310741075107610771078107910801081108210831084108510861087108810891090109110921093109410951096109710981099110011011102110311041105110611071108110911101111111211131114111511161117111811191120112111221123112411251126112711281129113011311132113311341135113611371138113911401141114211431144114511461147114811491150115111521153115411551156115711581159116011611162116311641165116611671168116911701171117211731174117511761177117811791180118111821183118411851186118711881189119011911192119311941195119611971198119912001201120212031204120512061207120812091210121112121213121412151216121712181219122012211222122312241225122612271228122912301231123212331234123512361237123812391240124112421243124412451246124712481249125012511252125312541255125612571258125912601261126212631264126512661267126812691270127112721273127412751276127712781279128012811282128312841285128612871288128912901291129212931294129512961297129812991300130113021303130413051306130713081309131013111312131313141315131613171318131913201321132213231324132513261327132813291330133113321333133413351336133713381339134013411342134313441345134613471348134913501351135213531354135513561357135813591360136113621363136413651366136713681369137013711372137313741375137613771378137913801381138213831384138513861387138813891390139113921393139413951396139713981399140014011402140314041405140614071408140914101411141214131414141514161417141814191420142114221423142414251426142714281429143014311432143314341435143614371438143914401441144214431444144514461447144814491450145114521453145414551456145714581459146014611462
  1. /*
  2. Copyright © 2025 ESO Maintainer Team
  3. Licensed under the Apache License, Version 2.0 (the "License");
  4. you may not use this file except in compliance with the License.
  5. You may obtain a copy of the License at
  6. https://www.apache.org/licenses/LICENSE-2.0
  7. Unless required by applicable law or agreed to in writing, software
  8. distributed under the License is distributed on an "AS IS" BASIS,
  9. WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
  10. See the License for the specific language governing permissions and
  11. limitations under the License.
  12. */
  13. // Package keyvault implements a provider for Azure Key Vault secrets, allowing
  14. // External Secrets to read from and write to Azure Key Vault.
  15. package keyvault
  16. import (
  17. "context"
  18. "crypto/x509"
  19. b64 "encoding/base64"
  20. "encoding/json"
  21. "encoding/pem"
  22. "errors"
  23. "fmt"
  24. "os"
  25. "path"
  26. "path/filepath"
  27. "regexp"
  28. "strings"
  29. "time"
  30. "github.com/Azure/azure-sdk-for-go/sdk/azcore"
  31. "github.com/Azure/azure-sdk-for-go/sdk/security/keyvault/azcertificates"
  32. "github.com/Azure/azure-sdk-for-go/sdk/security/keyvault/azkeys"
  33. "github.com/Azure/azure-sdk-for-go/sdk/security/keyvault/azsecrets"
  34. "github.com/Azure/azure-sdk-for-go/services/keyvault/v7.0/keyvault"
  35. "github.com/Azure/go-autorest/autorest"
  36. "github.com/Azure/go-autorest/autorest/adal"
  37. "github.com/Azure/go-autorest/autorest/azure"
  38. kvauth "github.com/Azure/go-autorest/autorest/azure/auth"
  39. "github.com/Azure/go-autorest/autorest/date"
  40. "github.com/AzureAD/microsoft-authentication-library-for-go/apps/confidential"
  41. "github.com/lestrrat-go/jwx/v2/jwk"
  42. "github.com/tidwall/gjson"
  43. "golang.org/x/crypto/sha3"
  44. authv1 "k8s.io/api/authentication/v1"
  45. corev1 "k8s.io/api/core/v1"
  46. metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
  47. "k8s.io/apimachinery/pkg/types"
  48. "k8s.io/client-go/kubernetes"
  49. kcorev1 "k8s.io/client-go/kubernetes/typed/core/v1"
  50. pointer "k8s.io/utils/ptr"
  51. "sigs.k8s.io/controller-runtime/pkg/client"
  52. ctrlcfg "sigs.k8s.io/controller-runtime/pkg/client/config"
  53. "sigs.k8s.io/controller-runtime/pkg/webhook/admission"
  54. gopkcs12 "software.sslmate.com/src/go-pkcs12"
  55. esv1 "github.com/external-secrets/external-secrets/apis/externalsecrets/v1"
  56. "github.com/external-secrets/external-secrets/runtime/constants"
  57. "github.com/external-secrets/external-secrets/runtime/esutils"
  58. "github.com/external-secrets/external-secrets/runtime/esutils/metadata"
  59. "github.com/external-secrets/external-secrets/runtime/esutils/resolvers"
  60. "github.com/external-secrets/external-secrets/runtime/metrics"
  61. )
  62. const (
  63. defaultObjType = "secret"
  64. objectTypeCert = "cert"
  65. objectTypeKey = "key"
  66. // AzureDefaultAudience is the default audience used for Azure AD token exchange.
  67. AzureDefaultAudience = "api://AzureADTokenExchange"
  68. // AnnotationClientID is the annotation key for Azure Workload Identity client ID.
  69. AnnotationClientID = "azure.workload.identity/client-id"
  70. // AnnotationTenantID is the annotation key for Azure Workload Identity tenant ID.
  71. AnnotationTenantID = "azure.workload.identity/tenant-id"
  72. managerLabel = "external-secrets"
  73. managedBy = "managed-by"
  74. errUnexpectedStoreSpec = "unexpected store spec"
  75. errMissingAuthType = "cannot initialize Azure Client: no valid authType was specified"
  76. errPropNotExist = "property %s does not exist in key %s"
  77. errTagNotExist = "tag %s does not exist"
  78. errUnknownObjectType = "unknown Azure Keyvault object Type for %s"
  79. errUnmarshalJSONData = "error unmarshalling json data: %w"
  80. errDataFromCert = "cannot get use dataFrom to get certificate secret"
  81. errDataFromKey = "cannot get use dataFrom to get key secret"
  82. errMissingTenant = "missing tenantID in store config"
  83. errMissingClient = "missing clientID: either serviceAccountRef or service account annotation '%s' is missing"
  84. errMissingSecretRef = "missing secretRef in provider config"
  85. errMissingClientIDSecret = "missing accessKeyID/secretAccessKey in store config"
  86. errInvalidClientCredentials = "both clientSecret and clientCredentials set"
  87. errMultipleClientID = "multiple clientID found. Check secretRef and serviceAccountRef"
  88. errMultipleTenantID = "multiple tenantID found. Check secretRef, 'spec.provider.azurekv.tenantId', and serviceAccountRef"
  89. errInvalidStore = "invalid store"
  90. errInvalidStoreSpec = "invalid store spec"
  91. errInvalidStoreProv = "invalid store provider"
  92. errInvalidAzureProv = "invalid azure keyvault provider"
  93. errInvalidSecRefClientID = "invalid AuthSecretRef.ClientID: %w"
  94. errInvalidSecRefClientSecret = "invalid AuthSecretRef.ClientSecret: %w"
  95. errInvalidSARef = "invalid ServiceAccountRef: %w"
  96. errMissingWorkloadEnvVars = "missing environment variables. AZURE_CLIENT_ID, AZURE_TENANT_ID and AZURE_FEDERATED_TOKEN_FILE must be set"
  97. errReadTokenFile = "unable to read token file %s: %w"
  98. )
  99. // https://github.com/external-secrets/external-secrets/issues/644
  100. var _ esv1.SecretsClient = &Azure{}
  101. var _ esv1.Provider = &Azure{}
  102. // SecretClient is an interface to keyvault.BaseClient.
  103. type SecretClient interface {
  104. GetKey(ctx context.Context, vaultBaseURL string, keyName string, keyVersion string) (result keyvault.KeyBundle, err error)
  105. GetSecret(ctx context.Context, vaultBaseURL string, secretName string, secretVersion string) (result keyvault.SecretBundle, err error)
  106. GetSecretsComplete(ctx context.Context, vaultBaseURL string, maxresults *int32) (result keyvault.SecretListResultIterator, err error)
  107. GetCertificate(ctx context.Context, vaultBaseURL string, certificateName string, certificateVersion string) (result keyvault.CertificateBundle, err error)
  108. SetSecret(ctx context.Context, vaultBaseURL string, secretName string, parameters keyvault.SecretSetParameters) (result keyvault.SecretBundle, err error)
  109. ImportKey(ctx context.Context, vaultBaseURL string, keyName string, parameters keyvault.KeyImportParameters) (result keyvault.KeyBundle, err error)
  110. ImportCertificate(ctx context.Context, vaultBaseURL string, certificateName string, parameters keyvault.CertificateImportParameters) (result keyvault.CertificateBundle, err error)
  111. DeleteCertificate(ctx context.Context, vaultBaseURL string, certificateName string) (result keyvault.DeletedCertificateBundle, err error)
  112. DeleteKey(ctx context.Context, vaultBaseURL string, keyName string) (result keyvault.DeletedKeyBundle, err error)
  113. DeleteSecret(ctx context.Context, vaultBaseURL string, secretName string) (result keyvault.DeletedSecretBundle, err error)
  114. }
  115. // Azure implements the External Secrets provider for Azure Key Vault.
  116. type Azure struct {
  117. crClient client.Client
  118. kubeClient kcorev1.CoreV1Interface
  119. store esv1.GenericStore
  120. provider *esv1.AzureKVProvider
  121. namespace string
  122. // Legacy go-autorest client
  123. baseClient SecretClient
  124. // New Azure SDK clients (used when UseAzureSDK is true)
  125. secretsClient *azsecrets.Client
  126. keysClient *azkeys.Client
  127. certsClient *azcertificates.Client
  128. }
  129. // PushSecretMetadataSpec defines metadata for pushing secrets to Azure Key Vault,
  130. // including expiration date and tags.
  131. type PushSecretMetadataSpec struct {
  132. ExpirationDate string `json:"expirationDate,omitempty"`
  133. Tags map[string]string `json:"tags,omitempty"`
  134. }
  135. // Capabilities return the provider supported capabilities (ReadOnly, WriteOnly, ReadWrite).
  136. func (a *Azure) Capabilities() esv1.SecretStoreCapabilities {
  137. return esv1.SecretStoreReadWrite
  138. }
  139. // NewClient constructs a new secrets client based on the provided store.
  140. func (a *Azure) NewClient(ctx context.Context, store esv1.GenericStore, kube client.Client, namespace string) (esv1.SecretsClient, error) {
  141. return newClient(ctx, store, kube, namespace)
  142. }
  143. func newClient(ctx context.Context, store esv1.GenericStore, kube client.Client, namespace string) (esv1.SecretsClient, error) {
  144. provider, err := getProvider(store)
  145. if err != nil {
  146. return nil, err
  147. }
  148. cfg, err := ctrlcfg.GetConfig()
  149. if err != nil {
  150. return nil, err
  151. }
  152. kubeClient, err := kubernetes.NewForConfig(cfg)
  153. if err != nil {
  154. return nil, err
  155. }
  156. az := &Azure{
  157. crClient: kube,
  158. kubeClient: kubeClient.CoreV1(),
  159. store: store,
  160. namespace: namespace,
  161. provider: provider,
  162. }
  163. // allow SecretStore controller validation to pass
  164. // when using referent namespace.
  165. if store.GetKind() == esv1.ClusterSecretStoreKind &&
  166. namespace == "" &&
  167. isReferentSpec(provider) {
  168. return az, nil
  169. }
  170. // Check if the new Azure SDK should be used
  171. if provider.UseAzureSDK != nil && *provider.UseAzureSDK {
  172. err = initializeNewAzureSDK(ctx, az)
  173. } else {
  174. err = initializeLegacyClient(ctx, az)
  175. }
  176. return az, err
  177. }
  178. // initializeLegacyClient sets up the Azure Key Vault client using the legacy go-autorest SDK.
  179. func initializeLegacyClient(ctx context.Context, az *Azure) error {
  180. var authorizer autorest.Authorizer
  181. var err error
  182. switch *az.provider.AuthType {
  183. case esv1.AzureManagedIdentity:
  184. authorizer, err = az.authorizerForManagedIdentity()
  185. case esv1.AzureServicePrincipal:
  186. authorizer, err = az.authorizerForServicePrincipal(ctx)
  187. case esv1.AzureWorkloadIdentity:
  188. authorizer, err = az.authorizerForWorkloadIdentity(ctx, NewTokenProvider)
  189. default:
  190. return errors.New(errMissingAuthType)
  191. }
  192. if err != nil {
  193. return err
  194. }
  195. cl := keyvault.New()
  196. cl.Authorizer = authorizer
  197. az.baseClient = &cl
  198. return nil
  199. }
  200. // initializeNewAzureSDK sets up the Azure Key Vault client using the new azcore-based SDK.
  201. func initializeNewAzureSDK(ctx context.Context, az *Azure) error {
  202. // Get cloud configuration
  203. cloudConfig, err := getCloudConfiguration(az.provider)
  204. if err != nil {
  205. return fmt.Errorf("failed to get cloud configuration: %w", err)
  206. }
  207. // Build credential based on auth type
  208. var credential azcore.TokenCredential
  209. switch *az.provider.AuthType {
  210. case esv1.AzureManagedIdentity:
  211. credential, err = buildManagedIdentityCredential(az, cloudConfig)
  212. case esv1.AzureServicePrincipal:
  213. credential, err = buildServicePrincipalCredential(ctx, az, cloudConfig)
  214. case esv1.AzureWorkloadIdentity:
  215. credential, err = buildWorkloadIdentityCredential(ctx, az, cloudConfig)
  216. default:
  217. return errors.New(errMissingAuthType)
  218. }
  219. if err != nil {
  220. return err
  221. }
  222. // Create Azure SDK clients and store them directly
  223. az.secretsClient, err = azsecrets.NewClient(*az.provider.VaultURL, credential, &azsecrets.ClientOptions{
  224. ClientOptions: azcore.ClientOptions{Cloud: cloudConfig},
  225. })
  226. if err != nil {
  227. return fmt.Errorf("failed to create secrets client: %w", err)
  228. }
  229. az.keysClient, err = azkeys.NewClient(*az.provider.VaultURL, credential, &azkeys.ClientOptions{
  230. ClientOptions: azcore.ClientOptions{Cloud: cloudConfig},
  231. })
  232. if err != nil {
  233. return fmt.Errorf("failed to create keys client: %w", err)
  234. }
  235. az.certsClient, err = azcertificates.NewClient(*az.provider.VaultURL, credential, &azcertificates.ClientOptions{
  236. ClientOptions: azcore.ClientOptions{Cloud: cloudConfig},
  237. })
  238. if err != nil {
  239. return fmt.Errorf("failed to create certificates client: %w", err)
  240. }
  241. return nil
  242. }
  243. // useNewSDK returns true if the new Azure SDK should be used.
  244. func (a *Azure) useNewSDK() bool {
  245. return a.provider.UseAzureSDK != nil && *a.provider.UseAzureSDK
  246. }
  247. func getProvider(store esv1.GenericStore) (*esv1.AzureKVProvider, error) {
  248. spc := store.GetSpec()
  249. if spc == nil || spc.Provider.AzureKV == nil {
  250. return nil, errors.New(errUnexpectedStoreSpec)
  251. }
  252. return spc.Provider.AzureKV, nil
  253. }
  254. // ValidateStore validates the Azure Key Vault provider configuration.
  255. func (a *Azure) ValidateStore(store esv1.GenericStore) (admission.Warnings, error) {
  256. if store == nil {
  257. return nil, errors.New(errInvalidStore)
  258. }
  259. spc := store.GetSpec()
  260. if spc == nil {
  261. return nil, errors.New(errInvalidStoreSpec)
  262. }
  263. if spc.Provider == nil {
  264. return nil, errors.New(errInvalidStoreProv)
  265. }
  266. p := spc.Provider.AzureKV
  267. if p == nil {
  268. return nil, errors.New(errInvalidAzureProv)
  269. }
  270. if p.AuthSecretRef != nil {
  271. if p.AuthSecretRef.ClientID != nil {
  272. if err := esutils.ValidateReferentSecretSelector(store, *p.AuthSecretRef.ClientID); err != nil {
  273. return nil, fmt.Errorf(errInvalidSecRefClientID, err)
  274. }
  275. }
  276. if p.AuthSecretRef.ClientSecret != nil {
  277. if err := esutils.ValidateReferentSecretSelector(store, *p.AuthSecretRef.ClientSecret); err != nil {
  278. return nil, fmt.Errorf(errInvalidSecRefClientSecret, err)
  279. }
  280. }
  281. }
  282. if p.ServiceAccountRef != nil {
  283. if err := esutils.ValidateReferentServiceAccountSelector(store, *p.ServiceAccountRef); err != nil {
  284. return nil, fmt.Errorf(errInvalidSARef, err)
  285. }
  286. }
  287. // Validate Azure Stack Cloud configuration
  288. if p.EnvironmentType == esv1.AzureEnvironmentAzureStackCloud {
  289. // Azure Stack requires custom cloud config
  290. if p.CustomCloudConfig == nil {
  291. return nil, errors.New("CustomCloudConfig is required when EnvironmentType is AzureStackCloud")
  292. }
  293. // Azure Stack requires new SDK
  294. if p.UseAzureSDK == nil || !*p.UseAzureSDK {
  295. return nil, errors.New("AzureStackCloud environment requires UseAzureSDK to be set to true - the legacy SDK does not support custom clouds")
  296. }
  297. // Validate required fields
  298. if p.CustomCloudConfig.ActiveDirectoryEndpoint == "" {
  299. return nil, errors.New("activeDirectoryEndpoint is required in CustomCloudConfig")
  300. }
  301. } else if p.CustomCloudConfig != nil {
  302. // CustomCloudConfig should only be used with AzureStackCloud
  303. return nil, errors.New("CustomCloudConfig should only be specified when EnvironmentType is AzureStackCloud")
  304. }
  305. return nil, nil
  306. }
  307. func canDelete(tags map[string]*string, err error) (bool, error) {
  308. aerr := &autorest.DetailedError{}
  309. conv := errors.As(err, aerr)
  310. if err != nil && !conv {
  311. return false, fmt.Errorf("could not parse error: %w", err)
  312. }
  313. if conv && aerr.StatusCode != 404 { // Secret is already deleted, nothing to do.
  314. return false, fmt.Errorf("unexpected api error: %w", err)
  315. }
  316. if aerr.StatusCode == 404 {
  317. return false, nil
  318. }
  319. manager, ok := tags[managedBy]
  320. if !ok || manager == nil || *manager != managerLabel {
  321. return false, errors.New("not managed by external-secrets")
  322. }
  323. return true, nil
  324. }
  325. func (a *Azure) deleteKeyVaultKey(ctx context.Context, keyName string) error {
  326. value, err := a.baseClient.GetKey(ctx, *a.provider.VaultURL, keyName, "")
  327. metrics.ObserveAPICall(constants.ProviderAzureKV, constants.CallAzureKVGetKey, err)
  328. ok, err := canDelete(value.Tags, err)
  329. if err != nil {
  330. return fmt.Errorf("error getting key %v: %w", keyName, err)
  331. }
  332. if ok {
  333. _, err = a.baseClient.DeleteKey(ctx, *a.provider.VaultURL, keyName)
  334. metrics.ObserveAPICall(constants.ProviderAzureKV, constants.CallAzureKVDeleteKey, err)
  335. if err != nil {
  336. return fmt.Errorf("error deleting key %v: %w", keyName, err)
  337. }
  338. }
  339. return nil
  340. }
  341. func (a *Azure) deleteKeyVaultSecret(ctx context.Context, secretName string) error {
  342. value, err := a.baseClient.GetSecret(ctx, *a.provider.VaultURL, secretName, "")
  343. metrics.ObserveAPICall(constants.ProviderAzureKV, constants.CallAzureKVGetSecret, err)
  344. ok, err := canDelete(value.Tags, err)
  345. if err != nil {
  346. return fmt.Errorf("error getting secret %v: %w", secretName, err)
  347. }
  348. if ok {
  349. _, err = a.baseClient.DeleteSecret(ctx, *a.provider.VaultURL, secretName)
  350. metrics.ObserveAPICall(constants.ProviderAzureKV, constants.CallAzureKVDeleteSecret, err)
  351. if err != nil {
  352. return fmt.Errorf("error deleting secret %v: %w", secretName, err)
  353. }
  354. }
  355. return nil
  356. }
  357. func (a *Azure) deleteKeyVaultCertificate(ctx context.Context, certName string) error {
  358. value, err := a.baseClient.GetCertificate(ctx, *a.provider.VaultURL, certName, "")
  359. metrics.ObserveAPICall(constants.ProviderAzureKV, constants.CallAzureKVGetCertificate, err)
  360. ok, err := canDelete(value.Tags, err)
  361. if err != nil {
  362. return fmt.Errorf("error getting certificate %v: %w", certName, err)
  363. }
  364. if ok {
  365. _, err = a.baseClient.DeleteCertificate(ctx, *a.provider.VaultURL, certName)
  366. metrics.ObserveAPICall(constants.ProviderAzureKV, constants.CallAzureKVDeleteCertificate, err)
  367. if err != nil {
  368. return fmt.Errorf("error deleting certificate %v: %w", certName, err)
  369. }
  370. }
  371. return nil
  372. }
  373. // DeleteSecret deletes a secret from Azure Key Vault.
  374. func (a *Azure) DeleteSecret(ctx context.Context, remoteRef esv1.PushSecretRemoteRef) error {
  375. objectType, secretName := getObjType(esv1.ExternalSecretDataRemoteRef{Key: remoteRef.GetRemoteKey()})
  376. switch objectType {
  377. case defaultObjType:
  378. if a.useNewSDK() {
  379. return a.deleteKeyVaultSecretWithNewSDK(ctx, secretName)
  380. }
  381. return a.deleteKeyVaultSecret(ctx, secretName)
  382. case objectTypeCert:
  383. if a.useNewSDK() {
  384. return a.deleteKeyVaultCertificateWithNewSDK(ctx, secretName)
  385. }
  386. return a.deleteKeyVaultCertificate(ctx, secretName)
  387. case objectTypeKey:
  388. if a.useNewSDK() {
  389. return a.deleteKeyVaultKeyWithNewSDK(ctx, secretName)
  390. }
  391. return a.deleteKeyVaultKey(ctx, secretName)
  392. default:
  393. return fmt.Errorf("secret type '%v' is not supported", objectType)
  394. }
  395. }
  396. // SecretExists checks if a secret exists in Azure Key Vault.
  397. func (a *Azure) SecretExists(ctx context.Context, remoteRef esv1.PushSecretRemoteRef) (bool, error) {
  398. if a.useNewSDK() {
  399. return a.secretExistsWithNewSDK(ctx, remoteRef)
  400. }
  401. objectType, secretName := getObjType(esv1.ExternalSecretDataRemoteRef{Key: remoteRef.GetRemoteKey()})
  402. var err error
  403. switch objectType {
  404. case defaultObjType:
  405. _, err = a.baseClient.GetSecret(ctx, *a.provider.VaultURL, secretName, "")
  406. case objectTypeCert:
  407. _, err = a.baseClient.GetCertificate(ctx, *a.provider.VaultURL, secretName, "")
  408. case objectTypeKey:
  409. _, err = a.baseClient.GetKey(ctx, *a.provider.VaultURL, secretName, "")
  410. default:
  411. errMsg := fmt.Sprintf("secret type '%v' is not supported", objectType)
  412. return false, errors.New(errMsg)
  413. }
  414. err = parseError(err)
  415. if err != nil {
  416. var noSecretErr esv1.NoSecretError
  417. if errors.As(err, &noSecretErr) {
  418. return false, nil
  419. }
  420. return false, err
  421. }
  422. return true, nil
  423. }
  424. func getCertificateFromValue(value []byte) (*x509.Certificate, error) {
  425. // 1st: try decode pkcs12
  426. _, localCert, err := gopkcs12.Decode(value, "")
  427. if err == nil {
  428. return localCert, nil
  429. }
  430. // 2nd: try decode pkcs12 with chain
  431. _, localCert, _, err = gopkcs12.DecodeChain(value, "")
  432. if err == nil {
  433. return localCert, nil
  434. }
  435. // 3rd: try DER
  436. localCert, err = x509.ParseCertificate(value)
  437. if err == nil {
  438. return localCert, nil
  439. }
  440. // 4th: parse PEM blocks
  441. for {
  442. block, rest := pem.Decode(value)
  443. value = rest
  444. if block == nil {
  445. break
  446. }
  447. cert, err := x509.ParseCertificate(block.Bytes)
  448. if err == nil {
  449. return cert, nil
  450. }
  451. }
  452. return nil, errors.New("could not parse certificate value as PKCS#12, DER or PEM")
  453. }
  454. func getKeyFromValue(value []byte) (any, error) {
  455. val := value
  456. pemBlock, _ := pem.Decode(value)
  457. // if a private key regular expression doesn't match, we should consider this key to be symmetric
  458. if pemBlock == nil {
  459. return val, nil
  460. }
  461. val = pemBlock.Bytes
  462. switch pemBlock.Type {
  463. case "PRIVATE KEY":
  464. return x509.ParsePKCS8PrivateKey(val)
  465. case "RSA PRIVATE KEY":
  466. return x509.ParsePKCS1PrivateKey(val)
  467. case "EC PRIVATE KEY":
  468. return x509.ParseECPrivateKey(val)
  469. default:
  470. return nil, fmt.Errorf("key type %v is not supported", pemBlock.Type)
  471. }
  472. }
  473. func canCreate(tags map[string]*string, err error) (bool, error) {
  474. aerr := &autorest.DetailedError{}
  475. conv := errors.As(err, aerr)
  476. if err != nil && !conv {
  477. return false, fmt.Errorf("could not parse error: %w", err)
  478. }
  479. if conv && aerr.StatusCode != 404 {
  480. return false, fmt.Errorf("unexpected api error: %w", err)
  481. }
  482. if err == nil {
  483. manager, ok := tags[managedBy]
  484. if !ok || manager == nil || *manager != managerLabel {
  485. return false, errors.New("not managed by external-secrets")
  486. }
  487. }
  488. return true, nil
  489. }
  490. func (a *Azure) setKeyVaultSecret(ctx context.Context, secretName string, value []byte, expires *date.UnixTime, tags map[string]string) error {
  491. secret, err := a.baseClient.GetSecret(ctx, *a.provider.VaultURL, secretName, "")
  492. metrics.ObserveAPICall(constants.ProviderAzureKV, constants.CallAzureKVGetSecret, err)
  493. ok, err := canCreate(secret.Tags, err)
  494. if err != nil {
  495. return fmt.Errorf("cannot get secret %v: %w", secretName, err)
  496. }
  497. if !ok {
  498. return nil
  499. }
  500. val := string(value)
  501. if secret.Value != nil && val == *secret.Value {
  502. if secret.Attributes != nil {
  503. if (secret.Attributes.Expires == nil && expires == nil) ||
  504. (secret.Attributes.Expires != nil && expires != nil && *secret.Attributes.Expires == *expires) {
  505. return nil
  506. }
  507. }
  508. }
  509. secretParams := keyvault.SecretSetParameters{
  510. Value: &val,
  511. Tags: map[string]*string{
  512. managedBy: pointer.To(managerLabel),
  513. },
  514. SecretAttributes: &keyvault.SecretAttributes{
  515. Enabled: pointer.To(true),
  516. },
  517. }
  518. for k, v := range tags {
  519. secretParams.Tags[k] = &v
  520. }
  521. if expires != nil {
  522. secretParams.SecretAttributes.Expires = expires
  523. }
  524. _, err = a.baseClient.SetSecret(ctx, *a.provider.VaultURL, secretName, secretParams)
  525. metrics.ObserveAPICall(constants.ProviderAzureKV, constants.CallAzureKVGetSecret, err)
  526. if err != nil {
  527. return fmt.Errorf("could not set secret %v: %w", secretName, err)
  528. }
  529. return nil
  530. }
  531. func (a *Azure) setKeyVaultCertificate(ctx context.Context, secretName string, value []byte, tags map[string]string) error {
  532. val := b64.StdEncoding.EncodeToString(value)
  533. localCert, err := getCertificateFromValue(value)
  534. if err != nil {
  535. return fmt.Errorf("value from secret is not a valid certificate: %w", err)
  536. }
  537. cert, err := a.baseClient.GetCertificate(ctx, *a.provider.VaultURL, secretName, "")
  538. metrics.ObserveAPICall(constants.ProviderAzureKV, constants.CallAzureKVGetCertificate, err)
  539. ok, err := canCreate(cert.Tags, err)
  540. if err != nil {
  541. return fmt.Errorf("cannot get certificate %v: %w", secretName, err)
  542. }
  543. if !ok {
  544. return nil
  545. }
  546. b512 := sha3.Sum512(localCert.Raw)
  547. if cert.Cer != nil && b512 == sha3.Sum512(*cert.Cer) {
  548. return nil
  549. }
  550. params := keyvault.CertificateImportParameters{
  551. Base64EncodedCertificate: &val,
  552. Tags: map[string]*string{
  553. managedBy: pointer.To(managerLabel),
  554. },
  555. }
  556. for k, v := range tags {
  557. params.Tags[k] = &v
  558. }
  559. _, err = a.baseClient.ImportCertificate(ctx, *a.provider.VaultURL, secretName, params)
  560. metrics.ObserveAPICall(constants.ProviderAzureKV, constants.CallAzureKVImportCertificate, err)
  561. if err != nil {
  562. return fmt.Errorf("could not import certificate %v: %w", secretName, err)
  563. }
  564. return nil
  565. }
  566. func equalKeys(newKey, oldKey keyvault.JSONWebKey) bool {
  567. // checks for everything except KeyID and KeyOps
  568. rsaCheck := newKey.E != nil && oldKey.E != nil && *newKey.E == *oldKey.E &&
  569. newKey.N != nil && oldKey.N != nil && *newKey.N == *oldKey.N
  570. symmetricCheck := newKey.Crv == oldKey.Crv &&
  571. newKey.T != nil && oldKey.T != nil && *newKey.T == *oldKey.T &&
  572. newKey.X != nil && oldKey.X != nil && *newKey.X == *oldKey.X &&
  573. newKey.Y != nil && oldKey.Y != nil && *newKey.Y == *oldKey.Y
  574. return newKey.Kty == oldKey.Kty && (rsaCheck || symmetricCheck)
  575. }
  576. func (a *Azure) setKeyVaultKey(ctx context.Context, secretName string, value []byte, tags map[string]string) error {
  577. key, err := getKeyFromValue(value)
  578. if err != nil {
  579. return fmt.Errorf("could not load private key %v: %w", secretName, err)
  580. }
  581. jwKey, err := jwk.FromRaw(key)
  582. if err != nil {
  583. return fmt.Errorf("failed to generate a JWK from secret %v content: %w", secretName, err)
  584. }
  585. buf, err := json.Marshal(jwKey)
  586. if err != nil {
  587. return fmt.Errorf("error parsing key: %w", err)
  588. }
  589. azkey := keyvault.JSONWebKey{}
  590. err = json.Unmarshal(buf, &azkey)
  591. if err != nil {
  592. return fmt.Errorf("error unmarshalling key: %w", err)
  593. }
  594. keyFromVault, err := a.baseClient.GetKey(ctx, *a.provider.VaultURL, secretName, "")
  595. metrics.ObserveAPICall(constants.ProviderAzureKV, constants.CallAzureKVGetKey, err)
  596. ok, err := canCreate(keyFromVault.Tags, err)
  597. if err != nil {
  598. return fmt.Errorf("cannot get key %v: %w", secretName, err)
  599. }
  600. if !ok {
  601. return nil
  602. }
  603. if keyFromVault.Key != nil && equalKeys(azkey, *keyFromVault.Key) {
  604. return nil
  605. }
  606. params := keyvault.KeyImportParameters{
  607. Key: &azkey,
  608. KeyAttributes: &keyvault.KeyAttributes{},
  609. Tags: map[string]*string{
  610. managedBy: pointer.To(managerLabel),
  611. },
  612. }
  613. for k, v := range tags {
  614. params.Tags[k] = &v
  615. }
  616. _, err = a.baseClient.ImportKey(ctx, *a.provider.VaultURL, secretName, params)
  617. metrics.ObserveAPICall(constants.ProviderAzureKV, constants.CallAzureKVImportKey, err)
  618. if err != nil {
  619. return fmt.Errorf("could not import key %v: %w", secretName, err)
  620. }
  621. return nil
  622. }
  623. func getSecretKey(secret *corev1.Secret, data esv1.PushSecretData) ([]byte, error) {
  624. if data.GetSecretKey() != "" {
  625. return secret.Data[data.GetSecretKey()], nil
  626. }
  627. // Must convert secret values to string, otherwise data will be sent as base64 to Vault
  628. secretStringVal := make(map[string]string)
  629. for k, v := range secret.Data {
  630. secretStringVal[k] = string(v)
  631. }
  632. value, err := esutils.JSONMarshal(secretStringVal)
  633. if err != nil {
  634. return nil, fmt.Errorf("failed to serialize secret content as JSON: %w", err)
  635. }
  636. return value, nil
  637. }
  638. // PushSecret stores secrets into a Key vault instance.
  639. func (a *Azure) PushSecret(ctx context.Context, secret *corev1.Secret, data esv1.PushSecretData) error {
  640. var (
  641. value []byte
  642. err error
  643. expires *date.UnixTime
  644. tags map[string]string
  645. )
  646. if value, err = getSecretKey(secret, data); err != nil {
  647. return err
  648. }
  649. metadata, err := metadata.ParseMetadataParameters[PushSecretMetadataSpec](data.GetMetadata())
  650. if err != nil {
  651. return fmt.Errorf("failed to parse push secret metadata: %w", err)
  652. }
  653. if metadata != nil && metadata.Spec.ExpirationDate != "" {
  654. t, err := time.Parse(time.RFC3339, metadata.Spec.ExpirationDate)
  655. if err != nil {
  656. return fmt.Errorf("error parsing expiration date in metadata: %w. Expected format: YYYY-MM-DDTHH:MM:SSZ (RFC3339). Example: 2024-12-31T20:00:00Z", err)
  657. }
  658. unixTime := date.UnixTime(t)
  659. expires = &unixTime
  660. }
  661. if metadata != nil && metadata.Spec.Tags != nil {
  662. if _, exists := metadata.Spec.Tags[managedBy]; exists {
  663. return fmt.Errorf("error parsing tags in metadata: Cannot specify a '%s' tag", managedBy)
  664. }
  665. tags = metadata.Spec.Tags
  666. }
  667. objectType, secretName := getObjType(esv1.ExternalSecretDataRemoteRef{Key: data.GetRemoteKey()})
  668. switch objectType {
  669. case defaultObjType:
  670. if a.useNewSDK() {
  671. return a.setKeyVaultSecretWithNewSDK(ctx, secretName, value, nil, tags)
  672. }
  673. return a.setKeyVaultSecret(ctx, secretName, value, expires, tags)
  674. case objectTypeCert:
  675. if a.useNewSDK() {
  676. return a.setKeyVaultCertificateWithNewSDK(ctx, secretName, value, tags)
  677. }
  678. return a.setKeyVaultCertificate(ctx, secretName, value, tags)
  679. case objectTypeKey:
  680. if a.useNewSDK() {
  681. return a.setKeyVaultKeyWithNewSDK(ctx, secretName, value, tags)
  682. }
  683. return a.setKeyVaultKey(ctx, secretName, value, tags)
  684. default:
  685. return fmt.Errorf("secret type %v not supported", objectType)
  686. }
  687. }
  688. // GetAllSecrets implements store.Client.GetAllSecrets Interface.
  689. // Retrieves a map[string][]byte with the secret names as key and the secret itself as the calue.
  690. func (a *Azure) GetAllSecrets(ctx context.Context, ref esv1.ExternalSecretFind) (map[string][]byte, error) {
  691. if a.useNewSDK() {
  692. return a.getAllSecretsWithNewSDK(ctx, ref)
  693. }
  694. return a.getAllSecretsWithLegacySDK(ctx, ref)
  695. }
  696. func (a *Azure) getAllSecretsWithLegacySDK(ctx context.Context, ref esv1.ExternalSecretFind) (map[string][]byte, error) {
  697. basicClient := a.baseClient
  698. secretsMap := make(map[string][]byte)
  699. checkTags := len(ref.Tags) > 0
  700. checkName := ref.Name != nil && ref.Name.RegExp != ""
  701. secretListIter, err := basicClient.GetSecretsComplete(ctx, *a.provider.VaultURL, nil)
  702. metrics.ObserveAPICall(constants.ProviderAzureKV, constants.CallAzureKVGetSecrets, err)
  703. err = parseError(err)
  704. if err != nil {
  705. return nil, err
  706. }
  707. for secretListIter.NotDone() {
  708. secret := secretListIter.Value()
  709. ok, secretName := isValidSecret(checkTags, checkName, ref, secret)
  710. if !ok {
  711. err = secretListIter.Next()
  712. if err != nil {
  713. return nil, err
  714. }
  715. continue
  716. }
  717. secretResp, err := basicClient.GetSecret(ctx, *a.provider.VaultURL, secretName, "")
  718. metrics.ObserveAPICall(constants.ProviderAzureKV, constants.CallAzureKVGetSecret, err)
  719. err = parseError(err)
  720. if err != nil {
  721. return nil, err
  722. }
  723. secretValue := *secretResp.Value
  724. secretsMap[secretName] = []byte(secretValue)
  725. err = secretListIter.Next()
  726. if err != nil {
  727. return nil, err
  728. }
  729. }
  730. return secretsMap, nil
  731. }
  732. // Retrieves a tag value if specified and all tags in JSON format if not.
  733. func getSecretTag(tags map[string]*string, property string) ([]byte, error) {
  734. if property == "" {
  735. secretTagsData := make(map[string]string)
  736. for k, v := range tags {
  737. secretTagsData[k] = *v
  738. }
  739. return json.Marshal(secretTagsData)
  740. }
  741. if val, exist := tags[property]; exist {
  742. return []byte(*val), nil
  743. }
  744. idx := strings.Index(property, ".")
  745. if idx < 0 {
  746. return nil, fmt.Errorf(errTagNotExist, property)
  747. }
  748. if idx > 0 {
  749. tagName := property[0:idx]
  750. if val, exist := tags[tagName]; exist {
  751. key := strings.Replace(property, tagName+".", "", 1)
  752. return getProperty(*val, key, property)
  753. }
  754. }
  755. return nil, fmt.Errorf(errTagNotExist, property)
  756. }
  757. // Retrieves a property value if specified and the secret value if not.
  758. func getProperty(secret, property, key string) ([]byte, error) {
  759. if property == "" {
  760. return []byte(secret), nil
  761. }
  762. res := gjson.Get(secret, property)
  763. if !res.Exists() {
  764. idx := strings.Index(property, ".")
  765. if idx < 0 {
  766. return nil, fmt.Errorf(errPropNotExist, property, key)
  767. }
  768. escaped := strings.ReplaceAll(property, ".", "\\.")
  769. jValue := gjson.Get(secret, escaped)
  770. if jValue.Exists() {
  771. return []byte(jValue.String()), nil
  772. }
  773. return nil, fmt.Errorf(errPropNotExist, property, key)
  774. }
  775. return []byte(res.String()), nil
  776. }
  777. func parseError(err error) error {
  778. aerr := autorest.DetailedError{}
  779. if errors.As(err, &aerr) && aerr.StatusCode == 404 {
  780. return esv1.NoSecretError{}
  781. }
  782. return err
  783. }
  784. // GetSecret implements store.Client.GetSecret Interface.
  785. // Retrieves a secret/Key/Certificate/Tag with the secret name defined in ref.Name
  786. // The Object Type is defined as a prefix in the ref.Name , if no prefix is defined , we assume a secret is required.
  787. func (a *Azure) GetSecret(ctx context.Context, ref esv1.ExternalSecretDataRemoteRef) ([]byte, error) {
  788. if a.useNewSDK() {
  789. return a.getSecretWithNewSDK(ctx, ref)
  790. }
  791. return a.getSecretWithLegacySDK(ctx, ref)
  792. }
  793. // returns a SecretBundle with the tags values.
  794. func (a *Azure) getSecretTags(ctx context.Context, ref esv1.ExternalSecretDataRemoteRef) (map[string]*string, error) {
  795. if a.useNewSDK() {
  796. return a.getSecretTagsWithNewSDK(ctx, ref)
  797. }
  798. return a.getSecretTagsWithLegacySDK(ctx, ref)
  799. }
  800. func (a *Azure) getSecretTagsWithLegacySDK(ctx context.Context, ref esv1.ExternalSecretDataRemoteRef) (map[string]*string, error) {
  801. _, secretName := getObjType(ref)
  802. secretResp, err := a.baseClient.GetSecret(ctx, *a.provider.VaultURL, secretName, ref.Version)
  803. metrics.ObserveAPICall(constants.ProviderAzureKV, constants.CallAzureKVGetSecret, err)
  804. err = parseError(err)
  805. if err != nil {
  806. return nil, err
  807. }
  808. secretTagsData := make(map[string]*string)
  809. for tagname, tagval := range secretResp.Tags {
  810. name := secretName + "_" + tagname
  811. kv := make(map[string]string)
  812. err = json.Unmarshal([]byte(*tagval), &kv)
  813. // if the tagvalue is not in JSON format then we added to secretTagsData we added as it is
  814. if err != nil {
  815. secretTagsData[name] = tagval
  816. } else {
  817. for k, v := range kv {
  818. value := v
  819. secretTagsData[name+"_"+k] = &value
  820. }
  821. }
  822. }
  823. return secretTagsData, nil
  824. }
  825. // GetSecretMap returns a map of secret values from Azure KeyVault by fetching the secret with
  826. // the given name and parsing it as a JSON object. If MetadataPolicy is set to Fetch, it will
  827. // return the secret tags instead.
  828. func (a *Azure) GetSecretMap(ctx context.Context, ref esv1.ExternalSecretDataRemoteRef) (map[string][]byte, error) {
  829. objectType, secretName := getObjType(ref)
  830. switch objectType {
  831. case defaultObjType:
  832. data, err := a.GetSecret(ctx, ref)
  833. if err != nil {
  834. return nil, err
  835. }
  836. if ref.MetadataPolicy == esv1.ExternalSecretMetadataPolicyFetch {
  837. tags, _ := a.getSecretTags(ctx, ref)
  838. return getSecretMapProperties(tags, ref.Key, ref.Property), nil
  839. }
  840. return getSecretMapMap(data)
  841. case objectTypeCert:
  842. return nil, errors.New(errDataFromCert)
  843. case objectTypeKey:
  844. return nil, errors.New(errDataFromKey)
  845. }
  846. return nil, fmt.Errorf(errUnknownObjectType, secretName)
  847. }
  848. func getSecretMapMap(data []byte) (map[string][]byte, error) {
  849. kv := make(map[string]json.RawMessage)
  850. err := json.Unmarshal(data, &kv)
  851. if err != nil {
  852. return nil, fmt.Errorf(errUnmarshalJSONData, err)
  853. }
  854. secretData := make(map[string][]byte)
  855. for k, v := range kv {
  856. var strVal string
  857. err = json.Unmarshal(v, &strVal)
  858. if err == nil {
  859. secretData[k] = []byte(strVal)
  860. } else {
  861. secretData[k] = v
  862. }
  863. }
  864. return secretData, nil
  865. }
  866. func getSecretMapProperties(tags map[string]*string, key, property string) map[string][]byte {
  867. tagByteArray := make(map[string][]byte)
  868. if property != "" {
  869. keyPropertyName := key + "_" + property
  870. singleTag, _ := getSecretTag(tags, keyPropertyName)
  871. tagByteArray[keyPropertyName] = singleTag
  872. return tagByteArray
  873. }
  874. for k, v := range tags {
  875. tagByteArray[k] = []byte(*v)
  876. }
  877. return tagByteArray
  878. }
  879. func (a *Azure) authorizerForWorkloadIdentity(ctx context.Context, tokenProvider tokenProviderFunc) (autorest.Authorizer, error) {
  880. aadEndpoint := AadEndpointForType(a.provider.EnvironmentType)
  881. kvResource := kvResourceForProviderConfig(a.provider.EnvironmentType)
  882. // If no serviceAccountRef was provided
  883. // we expect certain env vars to be present.
  884. // They are set by the azure workload identity webhook
  885. // by adding the label `azure.workload.identity/use: "true"` to the external-secrets pod
  886. if a.provider.ServiceAccountRef == nil {
  887. clientID := os.Getenv("AZURE_CLIENT_ID")
  888. tenantID := os.Getenv("AZURE_TENANT_ID")
  889. tokenFilePath := os.Getenv("AZURE_FEDERATED_TOKEN_FILE")
  890. if clientID == "" || tenantID == "" || tokenFilePath == "" {
  891. return nil, errors.New(errMissingWorkloadEnvVars)
  892. }
  893. token, err := os.ReadFile(filepath.Clean(tokenFilePath))
  894. if err != nil {
  895. return nil, fmt.Errorf(errReadTokenFile, tokenFilePath, err)
  896. }
  897. tp, err := tokenProvider(ctx, string(token), clientID, tenantID, aadEndpoint, kvResource)
  898. if err != nil {
  899. return nil, err
  900. }
  901. return autorest.NewBearerAuthorizer(tp), nil
  902. }
  903. ns := a.namespace
  904. if a.store.GetKind() == esv1.ClusterSecretStoreKind && a.provider.ServiceAccountRef.Namespace != nil {
  905. ns = *a.provider.ServiceAccountRef.Namespace
  906. }
  907. var sa corev1.ServiceAccount
  908. err := a.crClient.Get(ctx, types.NamespacedName{
  909. Name: a.provider.ServiceAccountRef.Name,
  910. Namespace: ns,
  911. }, &sa)
  912. if err != nil {
  913. return nil, err
  914. }
  915. // Extract clientID
  916. var clientID string
  917. // First check if AuthSecretRef is set and clientID can be fetched from there
  918. if a.provider.AuthSecretRef != nil {
  919. if a.provider.AuthSecretRef.ClientID == nil {
  920. return nil, errors.New(errMissingClientIDSecret)
  921. }
  922. clientID, err = resolvers.SecretKeyRef(
  923. ctx,
  924. a.crClient,
  925. a.store.GetKind(),
  926. a.namespace, a.provider.AuthSecretRef.ClientID)
  927. if err != nil {
  928. return nil, err
  929. }
  930. }
  931. // If AuthSecretRef is not set, use default (Service Account) implementation
  932. // Try to get clientID from Annotations
  933. if len(sa.ObjectMeta.Annotations) > 0 {
  934. if val, found := sa.ObjectMeta.Annotations[AnnotationClientID]; found {
  935. // If clientID is defined in both Annotations and AuthSecretRef, return an error
  936. if clientID != "" {
  937. return nil, errors.New(errMultipleClientID)
  938. }
  939. clientID = val
  940. }
  941. }
  942. // Return an error if clientID is still empty
  943. if clientID == "" {
  944. return nil, fmt.Errorf(errMissingClient, AnnotationClientID)
  945. }
  946. // Extract tenantID
  947. var tenantID string
  948. // First check if AuthSecretRef is set and tenantID can be fetched from there
  949. if a.provider.AuthSecretRef != nil {
  950. // We may want to set tenantID explicitly in the `spec.provider.azurekv` section of the SecretStore object
  951. // So that is okay if it is not there
  952. if a.provider.AuthSecretRef.TenantID != nil {
  953. tenantID, err = resolvers.SecretKeyRef(
  954. ctx,
  955. a.crClient,
  956. a.store.GetKind(),
  957. a.namespace, a.provider.AuthSecretRef.TenantID)
  958. if err != nil {
  959. return nil, err
  960. }
  961. }
  962. }
  963. // Check if spec.provider.azurekv.tenantID is set
  964. if tenantID == "" && a.provider.TenantID != nil {
  965. tenantID = *a.provider.TenantID
  966. }
  967. // Try to get tenantID from Annotations first. Default implementation.
  968. if len(sa.ObjectMeta.Annotations) > 0 {
  969. if val, found := sa.ObjectMeta.Annotations[AnnotationTenantID]; found {
  970. // If tenantID is defined in both Annotations and AuthSecretRef, return an error
  971. if tenantID != "" {
  972. return nil, errors.New(errMultipleTenantID)
  973. }
  974. tenantID = val
  975. }
  976. }
  977. // Fallback: use the AZURE_TENANT_ID env var which is set by the azure workload identity webhook
  978. // https://azure.github.io/azure-workload-identity/docs/topics/service-account-labels-and-annotations.html#service-account
  979. if tenantID == "" {
  980. tenantID = os.Getenv("AZURE_TENANT_ID")
  981. }
  982. // Return an error if tenantID is still empty
  983. if tenantID == "" {
  984. return nil, errors.New(errMissingTenant)
  985. }
  986. audiences := []string{AzureDefaultAudience}
  987. if len(a.provider.ServiceAccountRef.Audiences) > 0 {
  988. audiences = append(audiences, a.provider.ServiceAccountRef.Audiences...)
  989. }
  990. token, err := FetchSAToken(ctx, ns, a.provider.ServiceAccountRef.Name, audiences, a.kubeClient)
  991. if err != nil {
  992. return nil, err
  993. }
  994. tp, err := tokenProvider(ctx, token, clientID, tenantID, aadEndpoint, kvResource)
  995. if err != nil {
  996. return nil, err
  997. }
  998. return autorest.NewBearerAuthorizer(tp), nil
  999. }
  1000. // FetchSAToken retrieves a service account token from Kubernetes with the specified audiences.
  1001. // It takes the service account namespace, name, audience list, and Kubernetes client interface.
  1002. // Returns the token string or an error if the token creation fails.
  1003. func FetchSAToken(ctx context.Context, ns, name string, audiences []string, kubeClient kcorev1.CoreV1Interface) (string, error) {
  1004. token, err := kubeClient.ServiceAccounts(ns).CreateToken(ctx, name, &authv1.TokenRequest{
  1005. Spec: authv1.TokenRequestSpec{
  1006. Audiences: audiences,
  1007. },
  1008. }, metav1.CreateOptions{})
  1009. if err != nil {
  1010. return "", err
  1011. }
  1012. return token.Status.Token, nil
  1013. }
  1014. // tokenProvider satisfies the adal.OAuthTokenProvider interface.
  1015. type tokenProvider struct {
  1016. accessToken string
  1017. }
  1018. type tokenProviderFunc func(ctx context.Context, token, clientID, tenantID, aadEndpoint, kvResource string) (adal.OAuthTokenProvider, error)
  1019. // NewTokenProvider creates a new Azure OAuth token provider for authentication.
  1020. func NewTokenProvider(ctx context.Context, token, clientID, tenantID, aadEndpoint, kvResource string) (adal.OAuthTokenProvider, error) {
  1021. cred := confidential.NewCredFromAssertionCallback(func(_ context.Context, _ confidential.AssertionRequestOptions) (string, error) {
  1022. return token, nil
  1023. })
  1024. cClient, err := confidential.New(fmt.Sprintf("%s%s", aadEndpoint, tenantID), clientID, cred)
  1025. if err != nil {
  1026. return nil, err
  1027. }
  1028. scope := kvResource
  1029. // .default needs to be added to the scope
  1030. if !strings.Contains(kvResource, ".default") {
  1031. scope = fmt.Sprintf("%s/.default", kvResource)
  1032. }
  1033. authRes, err := cClient.AcquireTokenByCredential(ctx, []string{
  1034. scope,
  1035. })
  1036. if err != nil {
  1037. return nil, err
  1038. }
  1039. return &tokenProvider{
  1040. accessToken: authRes.AccessToken,
  1041. }, nil
  1042. }
  1043. func (t *tokenProvider) OAuthToken() string {
  1044. return t.accessToken
  1045. }
  1046. func (a *Azure) authorizerForManagedIdentity() (autorest.Authorizer, error) {
  1047. msiConfig := kvauth.NewMSIConfig()
  1048. msiConfig.Resource = kvResourceForProviderConfig(a.provider.EnvironmentType)
  1049. if a.provider.IdentityID != nil {
  1050. msiConfig.ClientID = *a.provider.IdentityID
  1051. }
  1052. return msiConfig.Authorizer()
  1053. }
  1054. func (a *Azure) authorizerForServicePrincipal(ctx context.Context) (autorest.Authorizer, error) {
  1055. if a.provider.TenantID == nil {
  1056. return nil, errors.New(errMissingTenant)
  1057. }
  1058. if a.provider.AuthSecretRef == nil {
  1059. return nil, errors.New(errMissingSecretRef)
  1060. }
  1061. if a.provider.AuthSecretRef.ClientID == nil || (a.provider.AuthSecretRef.ClientSecret == nil && a.provider.AuthSecretRef.ClientCertificate == nil) {
  1062. return nil, errors.New(errMissingClientIDSecret)
  1063. }
  1064. if a.provider.AuthSecretRef.ClientSecret != nil && a.provider.AuthSecretRef.ClientCertificate != nil {
  1065. return nil, errors.New(errInvalidClientCredentials)
  1066. }
  1067. return a.getAuthorizerFromCredentials(ctx)
  1068. }
  1069. func (a *Azure) getAuthorizerFromCredentials(ctx context.Context) (autorest.Authorizer, error) {
  1070. clientID, err := resolvers.SecretKeyRef(
  1071. ctx,
  1072. a.crClient,
  1073. a.store.GetKind(),
  1074. a.namespace, a.provider.AuthSecretRef.ClientID,
  1075. )
  1076. if err != nil {
  1077. return nil, err
  1078. }
  1079. if a.provider.AuthSecretRef.ClientSecret != nil {
  1080. clientSecret, err := resolvers.SecretKeyRef(
  1081. ctx,
  1082. a.crClient,
  1083. a.store.GetKind(),
  1084. a.namespace, a.provider.AuthSecretRef.ClientSecret,
  1085. )
  1086. if err != nil {
  1087. return nil, err
  1088. }
  1089. return getAuthorizerForClientSecret(
  1090. clientID,
  1091. clientSecret,
  1092. *a.provider.TenantID,
  1093. a.provider.EnvironmentType,
  1094. )
  1095. }
  1096. clientCertificate, err := resolvers.SecretKeyRef(
  1097. ctx,
  1098. a.crClient,
  1099. a.store.GetKind(),
  1100. a.namespace, a.provider.AuthSecretRef.ClientCertificate,
  1101. )
  1102. if err != nil {
  1103. return nil, err
  1104. }
  1105. return getAuthorizerForClientCertificate(
  1106. clientID,
  1107. []byte(clientCertificate),
  1108. *a.provider.TenantID,
  1109. a.provider.EnvironmentType,
  1110. )
  1111. }
  1112. func getAuthorizerForClientSecret(clientID, clientSecret, tenantID string, environmentType esv1.AzureEnvironmentType) (autorest.Authorizer, error) {
  1113. clientCredentialsConfig := kvauth.NewClientCredentialsConfig(clientID, clientSecret, tenantID)
  1114. clientCredentialsConfig.Resource = kvResourceForProviderConfig(environmentType)
  1115. clientCredentialsConfig.AADEndpoint = AadEndpointForType(environmentType)
  1116. return clientCredentialsConfig.Authorizer()
  1117. }
  1118. func getAuthorizerForClientCertificate(clientID string, certificateBytes []byte, tenantID string, environmentType esv1.AzureEnvironmentType) (autorest.Authorizer, error) {
  1119. clientCertificateConfig := NewClientInMemoryCertificateConfig(clientID, certificateBytes, tenantID)
  1120. clientCertificateConfig.Resource = kvResourceForProviderConfig(environmentType)
  1121. clientCertificateConfig.AADEndpoint = AadEndpointForType(environmentType)
  1122. return clientCertificateConfig.Authorizer()
  1123. }
  1124. // Close closes the Azure Key Vault provider.
  1125. func (a *Azure) Close(_ context.Context) error {
  1126. return nil
  1127. }
  1128. // Validate validates the Azure Key Vault provider configuration.
  1129. func (a *Azure) Validate() (esv1.ValidationResult, error) {
  1130. if a.store.GetKind() == esv1.ClusterSecretStoreKind && isReferentSpec(a.provider) {
  1131. return esv1.ValidationResultUnknown, nil
  1132. }
  1133. return esv1.ValidationResultReady, nil
  1134. }
  1135. func isReferentSpec(prov *esv1.AzureKVProvider) bool {
  1136. if prov.AuthSecretRef != nil &&
  1137. ((prov.AuthSecretRef.ClientID != nil &&
  1138. prov.AuthSecretRef.ClientID.Namespace == nil) ||
  1139. (prov.AuthSecretRef.ClientSecret != nil &&
  1140. prov.AuthSecretRef.ClientSecret.Namespace == nil)) {
  1141. return true
  1142. }
  1143. if prov.ServiceAccountRef != nil &&
  1144. prov.ServiceAccountRef.Namespace == nil {
  1145. return true
  1146. }
  1147. return false
  1148. }
  1149. // AadEndpointForType returns the Azure Active Directory endpoint for the specified Azure environment type.
  1150. func AadEndpointForType(t esv1.AzureEnvironmentType) string {
  1151. switch t {
  1152. case esv1.AzureEnvironmentPublicCloud:
  1153. return azure.PublicCloud.ActiveDirectoryEndpoint
  1154. case esv1.AzureEnvironmentChinaCloud:
  1155. return azure.ChinaCloud.ActiveDirectoryEndpoint
  1156. case esv1.AzureEnvironmentUSGovernmentCloud:
  1157. return azure.USGovernmentCloud.ActiveDirectoryEndpoint
  1158. case esv1.AzureEnvironmentGermanCloud:
  1159. return azure.GermanCloud.ActiveDirectoryEndpoint
  1160. case esv1.AzureEnvironmentAzureStackCloud:
  1161. // Azure Stack Cloud requires custom configuration and new SDK
  1162. // Return empty string to indicate it's not supported in old SDK
  1163. return ""
  1164. default:
  1165. return azure.PublicCloud.ActiveDirectoryEndpoint
  1166. }
  1167. }
  1168. // ServiceManagementEndpointForType returns the service management endpoint for the specified Azure environment type.
  1169. func ServiceManagementEndpointForType(t esv1.AzureEnvironmentType) string {
  1170. switch t {
  1171. case esv1.AzureEnvironmentPublicCloud:
  1172. return azure.PublicCloud.ServiceManagementEndpoint
  1173. case esv1.AzureEnvironmentChinaCloud:
  1174. return azure.ChinaCloud.ServiceManagementEndpoint
  1175. case esv1.AzureEnvironmentUSGovernmentCloud:
  1176. return azure.USGovernmentCloud.ServiceManagementEndpoint
  1177. case esv1.AzureEnvironmentGermanCloud:
  1178. return azure.GermanCloud.ServiceManagementEndpoint
  1179. case esv1.AzureEnvironmentAzureStackCloud:
  1180. // Azure Stack Cloud requires custom configuration and new SDK
  1181. // Return empty string to indicate it's not supported in old SDK
  1182. return ""
  1183. default:
  1184. return azure.PublicCloud.ServiceManagementEndpoint
  1185. }
  1186. }
  1187. func kvResourceForProviderConfig(t esv1.AzureEnvironmentType) string {
  1188. var res string
  1189. switch t {
  1190. case esv1.AzureEnvironmentPublicCloud:
  1191. res = azure.PublicCloud.KeyVaultEndpoint
  1192. case esv1.AzureEnvironmentChinaCloud:
  1193. res = azure.ChinaCloud.KeyVaultEndpoint
  1194. case esv1.AzureEnvironmentUSGovernmentCloud:
  1195. res = azure.USGovernmentCloud.KeyVaultEndpoint
  1196. case esv1.AzureEnvironmentGermanCloud:
  1197. res = azure.GermanCloud.KeyVaultEndpoint
  1198. case esv1.AzureEnvironmentAzureStackCloud:
  1199. // Azure Stack Cloud requires custom configuration and new SDK
  1200. // Return empty string to indicate it's not supported in old SDK
  1201. res = ""
  1202. default:
  1203. res = azure.PublicCloud.KeyVaultEndpoint
  1204. }
  1205. return strings.TrimSuffix(res, "/")
  1206. }
  1207. func getObjType(ref esv1.ExternalSecretDataRemoteRef) (string, string) {
  1208. objectType := defaultObjType
  1209. secretName := ref.Key
  1210. nameSplitted := strings.Split(secretName, "/")
  1211. if len(nameSplitted) > 1 {
  1212. objectType = nameSplitted[0]
  1213. secretName = nameSplitted[1]
  1214. // TODO: later tokens can be used to read the secret tags
  1215. }
  1216. return objectType, secretName
  1217. }
  1218. func isValidSecret(checkTags, checkName bool, ref esv1.ExternalSecretFind, secret keyvault.SecretItem) (bool, string) {
  1219. if secret.ID == nil || !*secret.Attributes.Enabled {
  1220. return false, ""
  1221. }
  1222. if checkTags && !okByTags(ref, secret) {
  1223. return false, ""
  1224. }
  1225. secretName := path.Base(*secret.ID)
  1226. if checkName && !okByName(ref, secretName) {
  1227. return false, ""
  1228. }
  1229. return true, secretName
  1230. }
  1231. func okByName(ref esv1.ExternalSecretFind, secretName string) bool {
  1232. matches, _ := regexp.MatchString(ref.Name.RegExp, secretName)
  1233. return matches
  1234. }
  1235. func okByTags(ref esv1.ExternalSecretFind, secret keyvault.SecretItem) bool {
  1236. tagsFound := true
  1237. for k, v := range ref.Tags {
  1238. if val, ok := secret.Tags[k]; !ok || *val != v {
  1239. tagsFound = false
  1240. break
  1241. }
  1242. }
  1243. return tagsFound
  1244. }
  1245. // GetSecret implementation using legacy go-autorest SDK.
  1246. func (a *Azure) getSecretWithLegacySDK(ctx context.Context, ref esv1.ExternalSecretDataRemoteRef) ([]byte, error) {
  1247. objectType, secretName := getObjType(ref)
  1248. switch objectType {
  1249. case defaultObjType:
  1250. // returns a SecretBundle with the secret value
  1251. // https://pkg.go.dev/github.com/Azure/azure-sdk-for-go/services/keyvault/v7.0/keyvault#SecretBundle
  1252. secretResp, err := a.baseClient.GetSecret(ctx, *a.provider.VaultURL, secretName, ref.Version)
  1253. metrics.ObserveAPICall(constants.ProviderAzureKV, constants.CallAzureKVGetSecret, err)
  1254. err = parseError(err)
  1255. if err != nil {
  1256. return nil, err
  1257. }
  1258. if ref.MetadataPolicy == esv1.ExternalSecretMetadataPolicyFetch {
  1259. return getSecretTag(secretResp.Tags, ref.Property)
  1260. }
  1261. return getProperty(*secretResp.Value, ref.Property, ref.Key)
  1262. case objectTypeCert:
  1263. // returns a CertBundle. We return CER contents of x509 certificate
  1264. // see: https://pkg.go.dev/github.com/Azure/azure-sdk-for-go/services/keyvault/v7.0/keyvault#CertificateBundle
  1265. certResp, err := a.baseClient.GetCertificate(ctx, *a.provider.VaultURL, secretName, ref.Version)
  1266. metrics.ObserveAPICall(constants.ProviderAzureKV, constants.CallAzureKVGetCertificate, err)
  1267. err = parseError(err)
  1268. if err != nil {
  1269. return nil, err
  1270. }
  1271. if ref.MetadataPolicy == esv1.ExternalSecretMetadataPolicyFetch {
  1272. return getSecretTag(certResp.Tags, ref.Property)
  1273. }
  1274. return *certResp.Cer, nil
  1275. case objectTypeKey:
  1276. // returns a KeyBundle
  1277. // https://pkg.go.dev/github.com/Azure/azure-sdk-for-go/services/keyvault/v7.0/keyvault#KeyBundle
  1278. keyResp, err := a.baseClient.GetKey(ctx, *a.provider.VaultURL, secretName, ref.Version)
  1279. metrics.ObserveAPICall(constants.ProviderAzureKV, constants.CallAzureKVGetKey, err)
  1280. err = parseError(err)
  1281. if err != nil {
  1282. return nil, err
  1283. }
  1284. if ref.MetadataPolicy == esv1.ExternalSecretMetadataPolicyFetch {
  1285. return getSecretTag(keyResp.Tags, ref.Property)
  1286. }
  1287. keyBytes, err := json.Marshal(keyResp.Key)
  1288. if err != nil {
  1289. return nil, fmt.Errorf("failed to marshal key: %w", err)
  1290. }
  1291. return getProperty(string(keyBytes), ref.Property, ref.Key)
  1292. }
  1293. return nil, fmt.Errorf(errUnknownObjectType, secretName)
  1294. }
  1295. // NewProvider creates a new Provider instance.
  1296. func NewProvider() esv1.Provider {
  1297. return &Azure{}
  1298. }
  1299. // ProviderSpec returns the provider specification for registration.
  1300. func ProviderSpec() *esv1.SecretStoreProvider {
  1301. return &esv1.SecretStoreProvider{
  1302. AzureKV: &esv1.AzureKVProvider{},
  1303. }
  1304. }
  1305. // MaintenanceStatus returns the maintenance status of the provider.
  1306. func MaintenanceStatus() esv1.MaintenanceStatus {
  1307. return esv1.MaintenanceStatusMaintained
  1308. }