keyvault.go 17 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528
  1. /*
  2. Licensed under the Apache License, Version 2.0 (the "License");
  3. you may not use this file except in compliance with the License.
  4. You may obtain a copy of the License at
  5. http://www.apache.org/licenses/LICENSE-2.0
  6. Unless required by applicable law or agreed to in writing, software
  7. distributed under the License is distributed on an "AS IS" BASIS,
  8. WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
  9. See the License for the specific language governing permissions and
  10. limitations under the License.
  11. */
  12. package keyvault
  13. import (
  14. "context"
  15. "encoding/json"
  16. "errors"
  17. "fmt"
  18. "os"
  19. "path"
  20. "regexp"
  21. "strings"
  22. "github.com/Azure/azure-sdk-for-go/profiles/latest/keyvault/keyvault"
  23. "github.com/Azure/go-autorest/autorest"
  24. "github.com/Azure/go-autorest/autorest/adal"
  25. kvauth "github.com/Azure/go-autorest/autorest/azure/auth"
  26. "github.com/AzureAD/microsoft-authentication-library-for-go/apps/confidential"
  27. "github.com/tidwall/gjson"
  28. authv1 "k8s.io/api/authentication/v1"
  29. corev1 "k8s.io/api/core/v1"
  30. metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
  31. "k8s.io/apimachinery/pkg/types"
  32. "k8s.io/client-go/kubernetes"
  33. kcorev1 "k8s.io/client-go/kubernetes/typed/core/v1"
  34. "sigs.k8s.io/controller-runtime/pkg/client"
  35. ctrlcfg "sigs.k8s.io/controller-runtime/pkg/client/config"
  36. esv1beta1 "github.com/external-secrets/external-secrets/apis/externalsecrets/v1beta1"
  37. smmeta "github.com/external-secrets/external-secrets/apis/meta/v1"
  38. "github.com/external-secrets/external-secrets/pkg/utils"
  39. )
  40. const (
  41. defaultObjType = "secret"
  42. objectTypeCert = "cert"
  43. objectTypeKey = "key"
  44. vaultResource = "https://vault.azure.net"
  45. azureDefaultAudience = "api://AzureADTokenExchange"
  46. annotationClientID = "azure.workload.identity/client-id"
  47. annotationTenantID = "azure.workload.identity/tenant-id"
  48. errUnexpectedStoreSpec = "unexpected store spec"
  49. errMissingAuthType = "cannot initialize Azure Client: no valid authType was specified"
  50. errPropNotExist = "property %s does not exist in key %s"
  51. errUnknownObjectType = "unknown Azure Keyvault object Type for %s"
  52. errUnmarshalJSONData = "error unmarshalling json data: %w"
  53. errDataFromCert = "cannot get use dataFrom to get certificate secret"
  54. errDataFromKey = "cannot get use dataFrom to get key secret"
  55. errMissingTenant = "missing tenantID in store config"
  56. errMissingSecretRef = "missing secretRef in provider config"
  57. errMissingClientIDSecret = "missing accessKeyID/secretAccessKey in store config"
  58. errFindSecret = "could not find secret %s/%s: %w"
  59. errFindDataKey = "no data for %q in secret '%s/%s'"
  60. errInvalidStore = "invalid store"
  61. errInvalidStoreSpec = "invalid store spec"
  62. errInvalidStoreProv = "invalid store provider"
  63. errInvalidAzureProv = "invalid azure keyvault provider"
  64. errInvalidSecRefClientID = "invalid AuthSecretRef.ClientID: %w"
  65. errInvalidSecRefClientSecret = "invalid AuthSecretRef.ClientSecret: %w"
  66. errInvalidSARef = "invalid ServiceAccountRef: %w"
  67. errMissingWorkloadEnvVars = "missing environment variables. AZURE_CLIENT_ID, AZURE_TENANT_ID and AZURE_FEDERATED_TOKEN_FILE must be set"
  68. errReadTokenFile = "unable to read token file %s: %w"
  69. errMissingSAAnnotation = "missing service account annotation: %s"
  70. )
  71. // interface to keyvault.BaseClient.
  72. type SecretClient interface {
  73. GetKey(ctx context.Context, vaultBaseURL string, keyName string, keyVersion string) (result keyvault.KeyBundle, err error)
  74. GetSecret(ctx context.Context, vaultBaseURL string, secretName string, secretVersion string) (result keyvault.SecretBundle, err error)
  75. GetSecretsComplete(ctx context.Context, vaultBaseURL string, maxresults *int32) (result keyvault.SecretListResultIterator, err error)
  76. GetCertificate(ctx context.Context, vaultBaseURL string, certificateName string, certificateVersion string) (result keyvault.CertificateBundle, err error)
  77. }
  78. type Azure struct {
  79. crClient client.Client
  80. kubeClient kcorev1.CoreV1Interface
  81. store esv1beta1.GenericStore
  82. provider *esv1beta1.AzureKVProvider
  83. baseClient SecretClient
  84. namespace string
  85. }
  86. func init() {
  87. esv1beta1.Register(&Azure{}, &esv1beta1.SecretStoreProvider{
  88. AzureKV: &esv1beta1.AzureKVProvider{},
  89. })
  90. }
  91. // NewClient constructs a new secrets client based on the provided store.
  92. func (a *Azure) NewClient(ctx context.Context, store esv1beta1.GenericStore, kube client.Client, namespace string) (esv1beta1.SecretsClient, error) {
  93. return newClient(ctx, store, kube, namespace)
  94. }
  95. func newClient(ctx context.Context, store esv1beta1.GenericStore, kube client.Client, namespace string) (esv1beta1.SecretsClient, error) {
  96. provider, err := getProvider(store)
  97. if err != nil {
  98. return nil, err
  99. }
  100. cfg, err := ctrlcfg.GetConfig()
  101. if err != nil {
  102. return nil, err
  103. }
  104. kubeClient, err := kubernetes.NewForConfig(cfg)
  105. if err != nil {
  106. return nil, err
  107. }
  108. az := &Azure{
  109. crClient: kube,
  110. kubeClient: kubeClient.CoreV1(),
  111. store: store,
  112. namespace: namespace,
  113. provider: provider,
  114. }
  115. var authorizer autorest.Authorizer
  116. switch *provider.AuthType {
  117. case esv1beta1.AzureManagedIdentity:
  118. authorizer, err = az.authorizerForManagedIdentity()
  119. case esv1beta1.AzureServicePrincipal:
  120. authorizer, err = az.authorizerForServicePrincipal(ctx)
  121. case esv1beta1.AzureWorkloadIdentity:
  122. authorizer, err = az.authorizerForWorkloadIdentity(ctx, newTokenProvider)
  123. default:
  124. err = fmt.Errorf(errMissingAuthType)
  125. }
  126. cl := keyvault.New()
  127. cl.Authorizer = authorizer
  128. az.baseClient = &cl
  129. return az, err
  130. }
  131. func getProvider(store esv1beta1.GenericStore) (*esv1beta1.AzureKVProvider, error) {
  132. spc := store.GetSpec()
  133. if spc == nil || spc.Provider.AzureKV == nil {
  134. return nil, errors.New(errUnexpectedStoreSpec)
  135. }
  136. return spc.Provider.AzureKV, nil
  137. }
  138. func (a *Azure) ValidateStore(store esv1beta1.GenericStore) error {
  139. if store == nil {
  140. return fmt.Errorf(errInvalidStore)
  141. }
  142. spc := store.GetSpec()
  143. if spc == nil {
  144. return fmt.Errorf(errInvalidStoreSpec)
  145. }
  146. if spc.Provider == nil {
  147. return fmt.Errorf(errInvalidStoreProv)
  148. }
  149. p := spc.Provider.AzureKV
  150. if p == nil {
  151. return fmt.Errorf(errInvalidAzureProv)
  152. }
  153. if p.AuthSecretRef != nil {
  154. if p.AuthSecretRef.ClientID != nil {
  155. if err := utils.ValidateSecretSelector(store, *p.AuthSecretRef.ClientID); err != nil {
  156. return fmt.Errorf(errInvalidSecRefClientID, err)
  157. }
  158. }
  159. if p.AuthSecretRef.ClientSecret != nil {
  160. if err := utils.ValidateSecretSelector(store, *p.AuthSecretRef.ClientSecret); err != nil {
  161. return fmt.Errorf(errInvalidSecRefClientSecret, err)
  162. }
  163. }
  164. }
  165. if p.ServiceAccountRef != nil {
  166. if err := utils.ValidateServiceAccountSelector(store, *p.ServiceAccountRef); err != nil {
  167. return fmt.Errorf(errInvalidSARef, err)
  168. }
  169. }
  170. return nil
  171. }
  172. // Implements store.Client.GetAllSecrets Interface.
  173. // Retrieves a map[string][]byte with the secret names as key and the secret itself as the calue.
  174. func (a *Azure) GetAllSecrets(ctx context.Context, ref esv1beta1.ExternalSecretFind) (map[string][]byte, error) {
  175. basicClient := a.baseClient
  176. secretsMap := make(map[string][]byte)
  177. checkTags := len(ref.Tags) > 0
  178. checkName := ref.Name != nil && len(ref.Name.RegExp) > 0
  179. secretListIter, err := basicClient.GetSecretsComplete(context.Background(), *a.provider.VaultURL, nil)
  180. if err != nil {
  181. return nil, err
  182. }
  183. for secretListIter.NotDone() {
  184. secretList := secretListIter.Response().Value
  185. for _, secret := range *secretList {
  186. ok, secretName := isValidSecret(checkTags, checkName, ref, secret)
  187. if !ok {
  188. continue
  189. }
  190. secretResp, err := basicClient.GetSecret(context.Background(), *a.provider.VaultURL, secretName, "")
  191. if err != nil {
  192. return nil, err
  193. }
  194. secretValue := *secretResp.Value
  195. secretsMap[secretName] = []byte(secretValue)
  196. }
  197. err = secretListIter.Next()
  198. if err != nil {
  199. return nil, err
  200. }
  201. }
  202. return secretsMap, nil
  203. }
  204. // Implements store.Client.GetSecret Interface.
  205. // Retrieves a secret/Key/Certificate with the secret name defined in ref.Name
  206. // The Object Type is defined as a prefix in the ref.Name , if no prefix is defined , we assume a secret is required.
  207. func (a *Azure) GetSecret(ctx context.Context, ref esv1beta1.ExternalSecretDataRemoteRef) ([]byte, error) {
  208. version := ""
  209. objectType, secretName := getObjType(ref)
  210. if ref.Version != "" {
  211. version = ref.Version
  212. }
  213. switch objectType {
  214. case defaultObjType:
  215. // returns a SecretBundle with the secret value
  216. // https://pkg.go.dev/github.com/Azure/azure-sdk-for-go/services/keyvault/v7.0/keyvault#SecretBundle
  217. secretResp, err := a.baseClient.GetSecret(context.Background(), *a.provider.VaultURL, secretName, version)
  218. if err != nil {
  219. return nil, err
  220. }
  221. if ref.Property == "" {
  222. return []byte(*secretResp.Value), nil
  223. }
  224. res := gjson.Get(*secretResp.Value, ref.Property)
  225. if !res.Exists() {
  226. return nil, fmt.Errorf(errPropNotExist, ref.Property, ref.Key)
  227. }
  228. return []byte(res.String()), err
  229. case objectTypeCert:
  230. // returns a CertBundle. We return CER contents of x509 certificate
  231. // see: https://pkg.go.dev/github.com/Azure/azure-sdk-for-go/services/keyvault/v7.0/keyvault#CertificateBundle
  232. secretResp, err := a.baseClient.GetCertificate(context.Background(), *a.provider.VaultURL, secretName, version)
  233. if err != nil {
  234. return nil, err
  235. }
  236. return *secretResp.Cer, nil
  237. case objectTypeKey:
  238. // returns a KeyBundle that contains a jwk
  239. // azure kv returns only public keys
  240. // see: https://pkg.go.dev/github.com/Azure/azure-sdk-for-go/services/keyvault/v7.0/keyvault#KeyBundle
  241. keyResp, err := a.baseClient.GetKey(context.Background(), *a.provider.VaultURL, secretName, version)
  242. if err != nil {
  243. return nil, err
  244. }
  245. return json.Marshal(keyResp.Key)
  246. }
  247. return nil, fmt.Errorf(errUnknownObjectType, secretName)
  248. }
  249. // Implements store.Client.GetSecretMap Interface.
  250. // New version of GetSecretMap.
  251. func (a *Azure) GetSecretMap(ctx context.Context, ref esv1beta1.ExternalSecretDataRemoteRef) (map[string][]byte, error) {
  252. objectType, secretName := getObjType(ref)
  253. switch objectType {
  254. case defaultObjType:
  255. data, err := a.GetSecret(ctx, ref)
  256. if err != nil {
  257. return nil, err
  258. }
  259. kv := make(map[string]string)
  260. err = json.Unmarshal(data, &kv)
  261. if err != nil {
  262. return nil, fmt.Errorf(errUnmarshalJSONData, err)
  263. }
  264. secretData := make(map[string][]byte)
  265. for k, v := range kv {
  266. secretData[k] = []byte(v)
  267. }
  268. return secretData, nil
  269. case objectTypeCert:
  270. return nil, fmt.Errorf(errDataFromCert)
  271. case objectTypeKey:
  272. return nil, fmt.Errorf(errDataFromKey)
  273. }
  274. return nil, fmt.Errorf(errUnknownObjectType, secretName)
  275. }
  276. func (a *Azure) authorizerForWorkloadIdentity(ctx context.Context, tokenProvider tokenProviderFunc) (autorest.Authorizer, error) {
  277. // if no serviceAccountRef was provided
  278. // we expect certain env vars to be present.
  279. // They are set by the azure workload identity webhook.
  280. if a.provider.ServiceAccountRef == nil {
  281. clientID := os.Getenv("AZURE_CLIENT_ID")
  282. tenantID := os.Getenv("AZURE_TENANT_ID")
  283. tokenFilePath := os.Getenv("AZURE_FEDERATED_TOKEN_FILE")
  284. if clientID == "" || tenantID == "" || tokenFilePath == "" {
  285. return nil, errors.New(errMissingWorkloadEnvVars)
  286. }
  287. token, err := os.ReadFile(tokenFilePath)
  288. if err != nil {
  289. return nil, fmt.Errorf(errReadTokenFile, tokenFilePath, err)
  290. }
  291. tp, err := tokenProvider(ctx, string(token), clientID, tenantID)
  292. if err != nil {
  293. return nil, err
  294. }
  295. return autorest.NewBearerAuthorizer(tp), nil
  296. }
  297. ns := a.namespace
  298. if a.store.GetObjectKind().GroupVersionKind().Kind == esv1beta1.ClusterSecretStoreKind {
  299. ns = *a.provider.ServiceAccountRef.Namespace
  300. }
  301. var sa corev1.ServiceAccount
  302. err := a.crClient.Get(ctx, types.NamespacedName{
  303. Name: a.provider.ServiceAccountRef.Name,
  304. Namespace: ns,
  305. }, &sa)
  306. if err != nil {
  307. return nil, err
  308. }
  309. clientID, ok := sa.ObjectMeta.Annotations[annotationClientID]
  310. if !ok {
  311. return nil, fmt.Errorf(errMissingSAAnnotation, annotationClientID)
  312. }
  313. tenantID, ok := sa.ObjectMeta.Annotations[annotationTenantID]
  314. if !ok {
  315. return nil, fmt.Errorf(errMissingSAAnnotation, annotationTenantID)
  316. }
  317. token, err := fetchSAToken(ctx, ns, a.provider.ServiceAccountRef.Name, a.kubeClient)
  318. if err != nil {
  319. return nil, err
  320. }
  321. tp, err := tokenProvider(ctx, token, clientID, tenantID)
  322. if err != nil {
  323. return nil, err
  324. }
  325. return autorest.NewBearerAuthorizer(tp), nil
  326. }
  327. func fetchSAToken(ctx context.Context, ns, name string, kubeClient kcorev1.CoreV1Interface) (string, error) {
  328. token, err := kubeClient.ServiceAccounts(ns).CreateToken(ctx, name, &authv1.TokenRequest{
  329. Spec: authv1.TokenRequestSpec{
  330. Audiences: []string{azureDefaultAudience},
  331. },
  332. }, metav1.CreateOptions{})
  333. if err != nil {
  334. return "", err
  335. }
  336. return token.Status.Token, nil
  337. }
  338. // tokenProvider satisfies the adal.OAuthTokenProvider interface.
  339. type tokenProvider struct {
  340. accessToken string
  341. }
  342. type tokenProviderFunc func(ctx context.Context, token, clientID, tenantID string) (adal.OAuthTokenProvider, error)
  343. func newTokenProvider(ctx context.Context, token, clientID, tenantID string) (adal.OAuthTokenProvider, error) {
  344. // exchange token with Azure AccessToken
  345. cred, err := confidential.NewCredFromAssertion(token)
  346. if err != nil {
  347. return nil, err
  348. }
  349. // AZURE_AUTHORITY_HOST
  350. cClient, err := confidential.New(clientID, cred, confidential.WithAuthority(
  351. fmt.Sprintf("https://login.microsoftonline.com/%s/oauth2/token", tenantID),
  352. ))
  353. if err != nil {
  354. return nil, err
  355. }
  356. authRes, err := cClient.AcquireTokenByCredential(ctx, []string{
  357. "https://vault.azure.net/.default",
  358. })
  359. if err != nil {
  360. return nil, err
  361. }
  362. return &tokenProvider{
  363. accessToken: authRes.AccessToken,
  364. }, nil
  365. }
  366. func (t *tokenProvider) OAuthToken() string {
  367. return t.accessToken
  368. }
  369. func (a *Azure) authorizerForManagedIdentity() (autorest.Authorizer, error) {
  370. msiConfig := kvauth.NewMSIConfig()
  371. msiConfig.Resource = vaultResource
  372. if a.provider.IdentityID != nil {
  373. msiConfig.ClientID = *a.provider.IdentityID
  374. }
  375. return msiConfig.Authorizer()
  376. }
  377. func (a *Azure) authorizerForServicePrincipal(ctx context.Context) (autorest.Authorizer, error) {
  378. if a.provider.TenantID == nil {
  379. return nil, fmt.Errorf(errMissingTenant)
  380. }
  381. if a.provider.AuthSecretRef == nil {
  382. return nil, fmt.Errorf(errMissingSecretRef)
  383. }
  384. if a.provider.AuthSecretRef.ClientID == nil || a.provider.AuthSecretRef.ClientSecret == nil {
  385. return nil, fmt.Errorf(errMissingClientIDSecret)
  386. }
  387. clusterScoped := false
  388. if a.store.GetObjectKind().GroupVersionKind().Kind == esv1beta1.ClusterSecretStoreKind {
  389. clusterScoped = true
  390. }
  391. cid, err := a.secretKeyRef(ctx, a.store.GetNamespace(), *a.provider.AuthSecretRef.ClientID, clusterScoped)
  392. if err != nil {
  393. return nil, err
  394. }
  395. csec, err := a.secretKeyRef(ctx, a.store.GetNamespace(), *a.provider.AuthSecretRef.ClientSecret, clusterScoped)
  396. if err != nil {
  397. return nil, err
  398. }
  399. clientCredentialsConfig := kvauth.NewClientCredentialsConfig(cid, csec, *a.provider.TenantID)
  400. clientCredentialsConfig.Resource = vaultResource
  401. return clientCredentialsConfig.Authorizer()
  402. }
  403. // secretKeyRef fetch a secret key.
  404. func (a *Azure) secretKeyRef(ctx context.Context, namespace string, secretRef smmeta.SecretKeySelector, clusterScoped bool) (string, error) {
  405. var secret corev1.Secret
  406. ref := types.NamespacedName{
  407. Namespace: namespace,
  408. Name: secretRef.Name,
  409. }
  410. if clusterScoped && secretRef.Namespace != nil {
  411. ref.Namespace = *secretRef.Namespace
  412. }
  413. err := a.crClient.Get(ctx, ref, &secret)
  414. if err != nil {
  415. return "", fmt.Errorf(errFindSecret, ref.Namespace, ref.Name, err)
  416. }
  417. keyBytes, ok := secret.Data[secretRef.Key]
  418. if !ok {
  419. return "", fmt.Errorf(errFindDataKey, secretRef.Key, secretRef.Name, namespace)
  420. }
  421. value := strings.TrimSpace(string(keyBytes))
  422. return value, nil
  423. }
  424. func (a *Azure) Close(ctx context.Context) error {
  425. return nil
  426. }
  427. func (a *Azure) Validate() error {
  428. return nil
  429. }
  430. func getObjType(ref esv1beta1.ExternalSecretDataRemoteRef) (string, string) {
  431. objectType := defaultObjType
  432. secretName := ref.Key
  433. nameSplitted := strings.Split(secretName, "/")
  434. if len(nameSplitted) > 1 {
  435. objectType = nameSplitted[0]
  436. secretName = nameSplitted[1]
  437. // TODO: later tokens can be used to read the secret tags
  438. }
  439. return objectType, secretName
  440. }
  441. func isValidSecret(checkTags, checkName bool, ref esv1beta1.ExternalSecretFind, secret keyvault.SecretItem) (bool, string) {
  442. if secret.ID == nil || !*secret.Attributes.Enabled {
  443. return false, ""
  444. }
  445. if checkTags && !okByTags(ref, secret) {
  446. return false, ""
  447. }
  448. secretName := path.Base(*secret.ID)
  449. if checkName && !okByName(ref, secretName) {
  450. return false, ""
  451. }
  452. return true, secretName
  453. }
  454. func okByName(ref esv1beta1.ExternalSecretFind, secretName string) bool {
  455. matches, _ := regexp.MatchString(ref.Name.RegExp, secretName)
  456. return matches
  457. }
  458. func okByTags(ref esv1beta1.ExternalSecretFind, secret keyvault.SecretItem) bool {
  459. tagsFound := true
  460. for k, v := range ref.Tags {
  461. if val, ok := secret.Tags[k]; !ok || *val != v {
  462. tagsFound = false
  463. break
  464. }
  465. }
  466. return tagsFound
  467. }