secretsmanager.go 10 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326
  1. /*
  2. Licensed under the Apache License, Version 2.0 (the "License");
  3. you may not use this file except in compliance with the License.
  4. You may obtain a copy of the License at
  5. http://www.apache.org/licenses/LICENSE-2.0
  6. Unless required by applicable law or agreed to in writing, software
  7. distributed under the License is distributed on an "AS IS" BASIS,
  8. WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
  9. See the License for the specific language governing permissions and
  10. limitations under the License.
  11. */
  12. package secretmanager
  13. import (
  14. "context"
  15. "encoding/json"
  16. "fmt"
  17. "sync"
  18. secretmanager "cloud.google.com/go/secretmanager/apiv1"
  19. "github.com/googleapis/gax-go/v2"
  20. "github.com/tidwall/gjson"
  21. "golang.org/x/oauth2"
  22. "golang.org/x/oauth2/google"
  23. "google.golang.org/api/option"
  24. secretmanagerpb "google.golang.org/genproto/googleapis/cloud/secretmanager/v1"
  25. v1 "k8s.io/api/core/v1"
  26. "k8s.io/apimachinery/pkg/types"
  27. kclient "sigs.k8s.io/controller-runtime/pkg/client"
  28. esv1beta1 "github.com/external-secrets/external-secrets/apis/externalsecrets/v1beta1"
  29. "github.com/external-secrets/external-secrets/pkg/utils"
  30. )
  31. const (
  32. CloudPlatformRole = "https://www.googleapis.com/auth/cloud-platform"
  33. defaultVersion = "latest"
  34. errGCPSMStore = "received invalid GCPSM SecretStore resource"
  35. errUnableGetCredentials = "unable to get credentials: %w"
  36. errClientClose = "unable to close SecretManager client: %w"
  37. errMissingStoreSpec = "invalid: missing store spec"
  38. errInvalidClusterStoreMissingSAKNamespace = "invalid ClusterSecretStore: missing GCP SecretAccessKey Namespace"
  39. errInvalidClusterStoreMissingSANamespace = "invalid ClusterSecretStore: missing GCP Service Account Namespace"
  40. errFetchSAKSecret = "could not fetch SecretAccessKey secret: %w"
  41. errMissingSAK = "missing SecretAccessKey"
  42. errUnableProcessJSONCredentials = "failed to process the provided JSON credentials: %w"
  43. errUnableCreateGCPSMClient = "failed to create GCP secretmanager client: %w"
  44. errUninitalizedGCPProvider = "provider GCP is not initialized"
  45. errClientGetSecretAccess = "unable to access Secret from SecretManager Client: %w"
  46. errJSONSecretUnmarshal = "unable to unmarshal secret: %w"
  47. errInvalidStore = "invalid store"
  48. errInvalidStoreSpec = "invalid store spec"
  49. errInvalidStoreProv = "invalid store provider"
  50. errInvalidGCPProv = "invalid gcp secrets manager provider"
  51. errInvalidAuthSecretRef = "invalid auth secret ref: %w"
  52. errInvalidWISARef = "invalid workload identity service account reference: %w"
  53. )
  54. type GoogleSecretManagerClient interface {
  55. AccessSecretVersion(ctx context.Context, req *secretmanagerpb.AccessSecretVersionRequest, opts ...gax.CallOption) (*secretmanagerpb.AccessSecretVersionResponse, error)
  56. Close() error
  57. }
  58. /*
  59. Currently, GCPSM client has a limitation around how concurrent connections work
  60. This limitation causes memory leaks due to random disconnects from living clients
  61. and also payload switches when sending a call (such as using a credential from one
  62. thread to ask secrets from another thread).
  63. A Mutex was implemented to make sure only one connection can be in place at a time.
  64. */
  65. var useMu = sync.Mutex{}
  66. // ProviderGCP is a provider for GCP Secret Manager.
  67. type ProviderGCP struct {
  68. projectID string
  69. SecretManagerClient GoogleSecretManagerClient
  70. gClient *gClient
  71. }
  72. type gClient struct {
  73. kube kclient.Client
  74. store *esv1beta1.GCPSMProvider
  75. namespace string
  76. storeKind string
  77. workloadIdentity *workloadIdentity
  78. }
  79. func (c *gClient) getTokenSource(ctx context.Context, store esv1beta1.GenericStore, kube kclient.Client, namespace string) (oauth2.TokenSource, error) {
  80. ts, err := serviceAccountTokenSource(ctx, store, kube, namespace)
  81. if ts != nil || err != nil {
  82. return ts, err
  83. }
  84. ts, err = c.workloadIdentity.TokenSource(ctx, store, kube, namespace)
  85. if ts != nil || err != nil {
  86. return ts, err
  87. }
  88. return google.DefaultTokenSource(ctx, CloudPlatformRole)
  89. }
  90. func (c *gClient) Close() error {
  91. return c.workloadIdentity.Close()
  92. }
  93. func serviceAccountTokenSource(ctx context.Context, store esv1beta1.GenericStore, kube kclient.Client, namespace string) (oauth2.TokenSource, error) {
  94. spec := store.GetSpec()
  95. if spec == nil || spec.Provider.GCPSM == nil {
  96. return nil, fmt.Errorf(errMissingStoreSpec)
  97. }
  98. sr := spec.Provider.GCPSM.Auth.SecretRef
  99. if sr == nil {
  100. return nil, nil
  101. }
  102. storeKind := store.GetObjectKind().GroupVersionKind().Kind
  103. credentialsSecret := &v1.Secret{}
  104. credentialsSecretName := sr.SecretAccessKey.Name
  105. objectKey := types.NamespacedName{
  106. Name: credentialsSecretName,
  107. Namespace: namespace,
  108. }
  109. // only ClusterStore is allowed to set namespace (and then it's required)
  110. if storeKind == esv1beta1.ClusterSecretStoreKind {
  111. if credentialsSecretName != "" && sr.SecretAccessKey.Namespace == nil {
  112. return nil, fmt.Errorf(errInvalidClusterStoreMissingSAKNamespace)
  113. } else if credentialsSecretName != "" {
  114. objectKey.Namespace = *sr.SecretAccessKey.Namespace
  115. }
  116. }
  117. err := kube.Get(ctx, objectKey, credentialsSecret)
  118. if err != nil {
  119. return nil, fmt.Errorf(errFetchSAKSecret, err)
  120. }
  121. credentials := credentialsSecret.Data[sr.SecretAccessKey.Key]
  122. if (credentials == nil) || (len(credentials) == 0) {
  123. return nil, fmt.Errorf(errMissingSAK)
  124. }
  125. config, err := google.JWTConfigFromJSON(credentials, CloudPlatformRole)
  126. if err != nil {
  127. return nil, fmt.Errorf(errUnableProcessJSONCredentials, err)
  128. }
  129. return config.TokenSource(ctx), nil
  130. }
  131. // NewClient constructs a GCP Provider.
  132. func (sm *ProviderGCP) NewClient(ctx context.Context, store esv1beta1.GenericStore, kube kclient.Client, namespace string) (esv1beta1.SecretsClient, error) {
  133. storeSpec := store.GetSpec()
  134. if storeSpec == nil || storeSpec.Provider == nil || storeSpec.Provider.GCPSM == nil {
  135. return nil, fmt.Errorf(errGCPSMStore)
  136. }
  137. storeSpecGCPSM := storeSpec.Provider.GCPSM
  138. useMu.Lock()
  139. wi, err := newWorkloadIdentity(ctx)
  140. if err != nil {
  141. useMu.Unlock()
  142. return nil, fmt.Errorf("unable to initialize workload identity")
  143. }
  144. cliStore := gClient{
  145. kube: kube,
  146. store: storeSpecGCPSM,
  147. namespace: namespace,
  148. storeKind: store.GetObjectKind().GroupVersionKind().Kind,
  149. workloadIdentity: wi,
  150. }
  151. sm.gClient = &cliStore
  152. defer func() {
  153. // closes IAMClient to prevent gRPC connection leak in case of an error.
  154. if sm.SecretManagerClient == nil {
  155. _ = sm.gClient.Close()
  156. }
  157. }()
  158. sm.projectID = cliStore.store.ProjectID
  159. ts, err := cliStore.getTokenSource(ctx, store, kube, namespace)
  160. if err != nil {
  161. useMu.Unlock()
  162. return nil, fmt.Errorf(errUnableCreateGCPSMClient, err)
  163. }
  164. // check if we can get credentials
  165. _, err = ts.Token()
  166. if err != nil {
  167. useMu.Unlock()
  168. return nil, fmt.Errorf(errUnableGetCredentials, err)
  169. }
  170. clientGCPSM, err := secretmanager.NewClient(ctx, option.WithTokenSource(ts))
  171. if err != nil {
  172. useMu.Unlock()
  173. return nil, fmt.Errorf(errUnableCreateGCPSMClient, err)
  174. }
  175. sm.SecretManagerClient = clientGCPSM
  176. return sm, nil
  177. }
  178. // Empty GetAllSecrets.
  179. func (sm *ProviderGCP) GetAllSecrets(ctx context.Context, ref esv1beta1.ExternalSecretFind) (map[string][]byte, error) {
  180. // TO be implemented
  181. return nil, fmt.Errorf("GetAllSecrets not implemented")
  182. }
  183. // GetSecret returns a single secret from the provider.
  184. func (sm *ProviderGCP) GetSecret(ctx context.Context, ref esv1beta1.ExternalSecretDataRemoteRef) ([]byte, error) {
  185. if utils.IsNil(sm.SecretManagerClient) || sm.projectID == "" {
  186. return nil, fmt.Errorf(errUninitalizedGCPProvider)
  187. }
  188. version := ref.Version
  189. if version == "" {
  190. version = defaultVersion
  191. }
  192. req := &secretmanagerpb.AccessSecretVersionRequest{
  193. Name: fmt.Sprintf("projects/%s/secrets/%s/versions/%s", sm.projectID, ref.Key, version),
  194. }
  195. result, err := sm.SecretManagerClient.AccessSecretVersion(ctx, req)
  196. if err != nil {
  197. return nil, fmt.Errorf(errClientGetSecretAccess, err)
  198. }
  199. if ref.Property == "" {
  200. if result.Payload.Data != nil {
  201. return result.Payload.Data, nil
  202. }
  203. return nil, fmt.Errorf("invalid secret received. no secret string for key: %s", ref.Key)
  204. }
  205. var payload string
  206. if result.Payload.Data != nil {
  207. payload = string(result.Payload.Data)
  208. }
  209. val := gjson.Get(payload, ref.Property)
  210. if !val.Exists() {
  211. return nil, fmt.Errorf("key %s does not exist in secret %s", ref.Property, ref.Key)
  212. }
  213. return []byte(val.String()), nil
  214. }
  215. // GetSecretMap returns multiple k/v pairs from the provider.
  216. func (sm *ProviderGCP) GetSecretMap(ctx context.Context, ref esv1beta1.ExternalSecretDataRemoteRef) (map[string][]byte, error) {
  217. if sm.SecretManagerClient == nil || sm.projectID == "" {
  218. return nil, fmt.Errorf(errUninitalizedGCPProvider)
  219. }
  220. data, err := sm.GetSecret(ctx, ref)
  221. if err != nil {
  222. return nil, err
  223. }
  224. kv := make(map[string]json.RawMessage)
  225. err = json.Unmarshal(data, &kv)
  226. if err != nil {
  227. return nil, fmt.Errorf(errJSONSecretUnmarshal, err)
  228. }
  229. secretData := make(map[string][]byte)
  230. for k, v := range kv {
  231. var strVal string
  232. err = json.Unmarshal(v, &strVal)
  233. if err == nil {
  234. secretData[k] = []byte(strVal)
  235. } else {
  236. secretData[k] = v
  237. }
  238. }
  239. return secretData, nil
  240. }
  241. func (sm *ProviderGCP) Close(ctx context.Context) error {
  242. err := sm.SecretManagerClient.Close()
  243. if sm.gClient != nil {
  244. err = sm.gClient.Close()
  245. }
  246. useMu.Unlock()
  247. if err != nil {
  248. return fmt.Errorf(errClientClose, err)
  249. }
  250. return nil
  251. }
  252. func (sm *ProviderGCP) Validate() error {
  253. return nil
  254. }
  255. func (sm *ProviderGCP) ValidateStore(store esv1beta1.GenericStore) error {
  256. if store == nil {
  257. return fmt.Errorf(errInvalidStore)
  258. }
  259. spc := store.GetSpec()
  260. if spc == nil {
  261. return fmt.Errorf(errInvalidStoreSpec)
  262. }
  263. if spc.Provider == nil {
  264. return fmt.Errorf(errInvalidStoreProv)
  265. }
  266. p := spc.Provider.GCPSM
  267. if p == nil {
  268. return fmt.Errorf(errInvalidGCPProv)
  269. }
  270. if p.Auth.SecretRef != nil {
  271. if err := utils.ValidateSecretSelector(store, p.Auth.SecretRef.SecretAccessKey); err != nil {
  272. return fmt.Errorf(errInvalidAuthSecretRef, err)
  273. }
  274. }
  275. if p.Auth.WorkloadIdentity != nil {
  276. if err := utils.ValidateServiceAccountSelector(store, p.Auth.WorkloadIdentity.ServiceAccountRef); err != nil {
  277. return fmt.Errorf(errInvalidWISARef, err)
  278. }
  279. }
  280. return nil
  281. }
  282. func init() {
  283. esv1beta1.Register(&ProviderGCP{}, &esv1beta1.SecretStoreProvider{
  284. GCPSM: &esv1beta1.GCPSMProvider{},
  285. })
  286. }