externalsecret_controller.go 23 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528529530531532533534535536537538539540541542543544545546547548549550551552553554555556557558559560561562563564565566567568569570571572573574575576577578579580581582583584585586587588589590591592593594595596597598599600601602603604605606607608609610611612613614615616617618619620621622623624625626627628629630631632633634635636637638639640641642643644645646647648649650651652653654655656657658659660661662663664665666667668669670671672673674675676677678679680681682683
  1. /*
  2. Licensed under the Apache License, Version 2.0 (the "License");
  3. you may not use this file except in compliance with the License.
  4. You may obtain a copy of the License at
  5. http://www.apache.org/licenses/LICENSE-2.0
  6. Unless required by applicable law or agreed to in writing, software
  7. distributed under the License is distributed on an "AS IS" BASIS,
  8. WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
  9. See the License for the specific language governing permissions and
  10. limitations under the License.
  11. */
  12. package externalsecret
  13. import (
  14. "context"
  15. "encoding/json"
  16. "fmt"
  17. "strings"
  18. "time"
  19. "github.com/go-logr/logr"
  20. "github.com/prometheus/client_golang/prometheus"
  21. v1 "k8s.io/api/core/v1"
  22. "k8s.io/apimachinery/pkg/api/equality"
  23. apierrors "k8s.io/apimachinery/pkg/api/errors"
  24. metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
  25. "k8s.io/apimachinery/pkg/runtime"
  26. "k8s.io/apimachinery/pkg/types"
  27. "k8s.io/client-go/rest"
  28. "k8s.io/client-go/tools/record"
  29. ctrl "sigs.k8s.io/controller-runtime"
  30. "sigs.k8s.io/controller-runtime/pkg/builder"
  31. "sigs.k8s.io/controller-runtime/pkg/client"
  32. "sigs.k8s.io/controller-runtime/pkg/controller"
  33. "sigs.k8s.io/controller-runtime/pkg/controller/controllerutil"
  34. "sigs.k8s.io/controller-runtime/pkg/handler"
  35. "sigs.k8s.io/controller-runtime/pkg/predicate"
  36. "sigs.k8s.io/controller-runtime/pkg/reconcile"
  37. esv1beta1 "github.com/external-secrets/external-secrets/apis/externalsecrets/v1beta1"
  38. // Metrics.
  39. "github.com/external-secrets/external-secrets/pkg/controllers/externalsecret/esmetrics"
  40. ctrlmetrics "github.com/external-secrets/external-secrets/pkg/controllers/metrics"
  41. "github.com/external-secrets/external-secrets/pkg/utils"
  42. // Loading registered generators.
  43. _ "github.com/external-secrets/external-secrets/pkg/generator/register"
  44. // Loading registered providers.
  45. _ "github.com/external-secrets/external-secrets/pkg/provider/register"
  46. )
  47. const (
  48. fieldOwnerTemplate = "externalsecrets.external-secrets.io/%v"
  49. errGetES = "could not get ExternalSecret"
  50. errConvert = "could not apply conversion strategy to keys: %v"
  51. errDecode = "could not apply decoding strategy to %v[%d]: %v"
  52. errGenerate = "could not generate [%d]: %w"
  53. errRewrite = "could not rewrite spec.dataFrom[%d]: %v"
  54. errInvalidKeys = "secret keys from spec.dataFrom.%v[%d] can only have alphanumeric,'-', '_' or '.' characters. Convert them using rewrite (https://external-secrets.io/latest/guides-datafrom-rewrite)"
  55. errUpdateSecret = "could not update Secret"
  56. errPatchStatus = "unable to patch status"
  57. errGetExistingSecret = "could not get existing secret: %w"
  58. errSetCtrlReference = "could not set ExternalSecret controller reference: %w"
  59. errFetchTplFrom = "error fetching templateFrom data: %w"
  60. errGetSecretData = "could not get secret data from provider"
  61. errDeleteSecret = "could not delete secret"
  62. errApplyTemplate = "could not apply template: %w"
  63. errExecTpl = "could not execute template: %w"
  64. errInvalidCreatePolicy = "invalid creationPolicy=%s. Can not delete secret i do not own"
  65. errPolicyMergeNotFound = "the desired secret %s was not found. With creationPolicy=Merge the secret won't be created"
  66. errPolicyMergeGetSecret = "unable to get secret %s: %w"
  67. errPolicyMergeMutate = "unable to mutate secret %s: %w"
  68. errPolicyMergePatch = "unable to patch secret %s: %w"
  69. )
  70. const externalSecretSecretNameKey = ".spec.target.name"
  71. // Reconciler reconciles a ExternalSecret object.
  72. type Reconciler struct {
  73. client.Client
  74. Log logr.Logger
  75. Scheme *runtime.Scheme
  76. RestConfig *rest.Config
  77. ControllerClass string
  78. RequeueInterval time.Duration
  79. ClusterSecretStoreEnabled bool
  80. EnableFloodGate bool
  81. recorder record.EventRecorder
  82. }
  83. // Reconcile implements the main reconciliation loop
  84. // for watched objects (ExternalSecret, ClusterSecretStore and SecretStore),
  85. // and updates/creates a Kubernetes secret based on them.
  86. func (r *Reconciler) Reconcile(ctx context.Context, req ctrl.Request) (ctrl.Result, error) {
  87. log := r.Log.WithValues("ExternalSecret", req.NamespacedName)
  88. resourceLabels := ctrlmetrics.RefineNonConditionMetricLabels(map[string]string{"name": req.Name, "namespace": req.Namespace})
  89. start := time.Now()
  90. syncCallsError := esmetrics.GetCounterVec(esmetrics.SyncCallsErrorKey)
  91. // use closures to dynamically update resourceLabels
  92. defer func() {
  93. esmetrics.GetGaugeVec(esmetrics.ExternalSecretReconcileDurationKey).With(resourceLabels).Set(float64(time.Since(start)))
  94. esmetrics.GetCounterVec(esmetrics.SyncCallsKey).With(resourceLabels).Inc()
  95. }()
  96. var externalSecret esv1beta1.ExternalSecret
  97. err := r.Get(ctx, req.NamespacedName, &externalSecret)
  98. if err != nil {
  99. if apierrors.IsNotFound(err) {
  100. conditionSynced := NewExternalSecretCondition(esv1beta1.ExternalSecretDeleted, v1.ConditionFalse, esv1beta1.ConditionReasonSecretDeleted, "Secret was deleted")
  101. SetExternalSecretCondition(&esv1beta1.ExternalSecret{
  102. ObjectMeta: metav1.ObjectMeta{
  103. Name: req.Name,
  104. Namespace: req.Namespace,
  105. },
  106. }, *conditionSynced)
  107. return ctrl.Result{}, nil
  108. }
  109. log.Error(err, errGetES)
  110. syncCallsError.With(resourceLabels).Inc()
  111. return ctrl.Result{}, err
  112. }
  113. timeSinceLastRefresh := 0 * time.Second
  114. if !externalSecret.Status.RefreshTime.IsZero() {
  115. timeSinceLastRefresh = time.Since(externalSecret.Status.RefreshTime.Time)
  116. }
  117. // skip reconciliation if deletion timestamp is set on external secret
  118. if externalSecret.DeletionTimestamp != nil {
  119. log.Info("skipping as it is in deletion")
  120. return ctrl.Result{}, nil
  121. }
  122. // if extended metrics is enabled, refine the time series vector
  123. resourceLabels = ctrlmetrics.RefineLabels(resourceLabels, externalSecret.Labels)
  124. if shouldSkipClusterSecretStore(r, externalSecret) {
  125. log.Info("skipping cluster secret store as it is disabled")
  126. return ctrl.Result{}, nil
  127. }
  128. // skip when pointing to an unmanaged store
  129. skip, err := shouldSkipUnmanagedStore(ctx, req.Namespace, r, externalSecret)
  130. if skip {
  131. log.Info("skipping unmanaged store as it points to a unmanaged controllerClass")
  132. return ctrl.Result{}, nil
  133. }
  134. refreshInt := r.RequeueInterval
  135. if externalSecret.Spec.RefreshInterval != nil {
  136. refreshInt = externalSecret.Spec.RefreshInterval.Duration
  137. }
  138. // Target Secret Name should default to the ExternalSecret name if not explicitly specified
  139. secretName := externalSecret.Spec.Target.Name
  140. if secretName == "" {
  141. secretName = externalSecret.ObjectMeta.Name
  142. }
  143. // fetch external secret, we need to ensure that it exists, and it's hashmap corresponds
  144. var existingSecret v1.Secret
  145. err = r.Get(ctx, types.NamespacedName{
  146. Name: secretName,
  147. Namespace: externalSecret.Namespace,
  148. }, &existingSecret)
  149. if err != nil && !apierrors.IsNotFound(err) {
  150. log.Error(err, errGetExistingSecret)
  151. return ctrl.Result{}, err
  152. }
  153. // refresh should be skipped if
  154. // 1. resource generation hasn't changed
  155. // 2. refresh interval is 0
  156. // 3. if we're still within refresh-interval
  157. if !shouldRefresh(externalSecret) && isSecretValid(existingSecret) {
  158. refreshInt = (externalSecret.Spec.RefreshInterval.Duration - timeSinceLastRefresh) + 5*time.Second
  159. log.V(1).Info("skipping refresh", "rv", getResourceVersion(externalSecret), "nr", refreshInt.Seconds())
  160. return ctrl.Result{RequeueAfter: refreshInt}, nil
  161. }
  162. if !shouldReconcile(externalSecret) {
  163. log.V(1).Info("stopping reconciling", "rv", getResourceVersion(externalSecret))
  164. return ctrl.Result{}, nil
  165. }
  166. // patch status when done processing
  167. p := client.MergeFrom(externalSecret.DeepCopy())
  168. defer func() {
  169. err = r.Status().Patch(ctx, &externalSecret, p)
  170. if err != nil {
  171. log.Error(err, errPatchStatus)
  172. }
  173. }()
  174. secret := &v1.Secret{
  175. ObjectMeta: metav1.ObjectMeta{
  176. Name: secretName,
  177. Namespace: externalSecret.Namespace,
  178. },
  179. Immutable: &externalSecret.Spec.Target.Immutable,
  180. Data: make(map[string][]byte),
  181. }
  182. dataMap, err := r.getProviderSecretData(ctx, &externalSecret)
  183. if err != nil {
  184. r.markAsFailed(log, errGetSecretData, err, &externalSecret, syncCallsError.With(resourceLabels))
  185. return ctrl.Result{}, err
  186. }
  187. // if no data was found we can delete the secret if needed.
  188. if len(dataMap) == 0 {
  189. switch externalSecret.Spec.Target.DeletionPolicy {
  190. // delete secret and return early.
  191. case esv1beta1.DeletionPolicyDelete:
  192. // safeguard that we only can delete secrets we own
  193. // this is also implemented in the es validation webhook
  194. if externalSecret.Spec.Target.CreationPolicy != esv1beta1.CreatePolicyOwner {
  195. err := fmt.Errorf(errInvalidCreatePolicy, externalSecret.Spec.Target.CreationPolicy)
  196. r.markAsFailed(log, errDeleteSecret, err, &externalSecret, syncCallsError.With(resourceLabels))
  197. return ctrl.Result{}, err
  198. }
  199. if err := r.Delete(ctx, secret); err != nil && !apierrors.IsNotFound(err) {
  200. r.markAsFailed(log, errDeleteSecret, err, &externalSecret, syncCallsError.With(resourceLabels))
  201. return ctrl.Result{}, err
  202. }
  203. conditionSynced := NewExternalSecretCondition(esv1beta1.ExternalSecretReady, v1.ConditionTrue, esv1beta1.ConditionReasonSecretDeleted, "secret deleted due to DeletionPolicy")
  204. SetExternalSecretCondition(&externalSecret, *conditionSynced)
  205. return ctrl.Result{RequeueAfter: refreshInt}, nil
  206. // In case provider secrets don't exist the kubernetes secret will be kept as-is.
  207. case esv1beta1.DeletionPolicyRetain:
  208. r.markAsDone(&externalSecret, start, log)
  209. return ctrl.Result{RequeueAfter: refreshInt}, nil
  210. // noop, handled below
  211. case esv1beta1.DeletionPolicyMerge:
  212. }
  213. }
  214. mutationFunc := func() error {
  215. if externalSecret.Spec.Target.CreationPolicy == esv1beta1.CreatePolicyOwner {
  216. err = controllerutil.SetControllerReference(&externalSecret, &secret.ObjectMeta, r.Scheme)
  217. if err != nil {
  218. return fmt.Errorf(errSetCtrlReference, err)
  219. }
  220. }
  221. if secret.Data == nil {
  222. secret.Data = make(map[string][]byte)
  223. }
  224. // diff existing keys
  225. keys, err := getManagedDataKeys(&existingSecret, externalSecret.Name)
  226. if err != nil {
  227. return err
  228. }
  229. // Sanitize data map for any updates on the ES
  230. for _, key := range keys {
  231. if dataMap[key] == nil {
  232. secret.Data[key] = nil
  233. // Sanitizing any templated / updated keys
  234. delete(secret.Data, key)
  235. }
  236. }
  237. err = r.applyTemplate(ctx, &externalSecret, secret, dataMap)
  238. if err != nil {
  239. return fmt.Errorf(errApplyTemplate, err)
  240. }
  241. if externalSecret.Spec.Target.CreationPolicy == esv1beta1.CreatePolicyOwner {
  242. lblValue := utils.ObjectHash(fmt.Sprintf("%v/%v", externalSecret.Namespace, externalSecret.Name))
  243. secret.Labels[esv1beta1.LabelOwner] = lblValue
  244. }
  245. secret.Annotations[esv1beta1.AnnotationDataHash] = r.computeDataHashAnnotation(&existingSecret, secret)
  246. return nil
  247. }
  248. switch externalSecret.Spec.Target.CreationPolicy { //nolint:exhaustive
  249. case esv1beta1.CreatePolicyMerge:
  250. err = r.patchSecret(ctx, secret, mutationFunc, &externalSecret)
  251. if err == nil {
  252. externalSecret.Status.Binding = v1.LocalObjectReference{Name: secret.Name}
  253. }
  254. case esv1beta1.CreatePolicyNone:
  255. log.V(1).Info("secret creation skipped due to creationPolicy=None")
  256. err = nil
  257. default:
  258. var created bool
  259. created, err = r.createOrUpdateSecret(ctx, secret, mutationFunc, &externalSecret)
  260. if err == nil {
  261. externalSecret.Status.Binding = v1.LocalObjectReference{Name: secret.Name}
  262. }
  263. // cleanup orphaned secrets
  264. if created {
  265. delErr := deleteOrphanedSecrets(ctx, r.Client, &externalSecret)
  266. if delErr != nil {
  267. msg := fmt.Sprintf("failed to clean up orphaned secrets: %v", delErr)
  268. r.markAsFailed(log, msg, delErr, &externalSecret, syncCallsError.With(resourceLabels))
  269. return ctrl.Result{}, delErr
  270. }
  271. }
  272. }
  273. if err != nil {
  274. r.markAsFailed(log, errUpdateSecret, err, &externalSecret, syncCallsError.With(resourceLabels))
  275. return ctrl.Result{}, err
  276. }
  277. r.markAsDone(&externalSecret, start, log)
  278. return ctrl.Result{
  279. RequeueAfter: refreshInt,
  280. }, nil
  281. }
  282. func (r *Reconciler) markAsDone(externalSecret *esv1beta1.ExternalSecret, start time.Time, log logr.Logger) {
  283. conditionSynced := NewExternalSecretCondition(esv1beta1.ExternalSecretReady, v1.ConditionTrue, esv1beta1.ConditionReasonSecretSynced, "Secret was synced")
  284. currCond := GetExternalSecretCondition(externalSecret.Status, esv1beta1.ExternalSecretReady)
  285. SetExternalSecretCondition(externalSecret, *conditionSynced)
  286. externalSecret.Status.RefreshTime = metav1.NewTime(start)
  287. externalSecret.Status.SyncedResourceVersion = getResourceVersion(*externalSecret)
  288. if currCond == nil || currCond.Status != conditionSynced.Status {
  289. log.Info("reconciled secret") // Log once if on success in any verbosity
  290. } else {
  291. log.V(1).Info("reconciled secret") // Log all reconciliation cycles if higher verbosity applied
  292. }
  293. }
  294. func (r *Reconciler) markAsFailed(log logr.Logger, msg string, err error, externalSecret *esv1beta1.ExternalSecret, counter prometheus.Counter) {
  295. log.Error(err, msg)
  296. r.recorder.Event(externalSecret, v1.EventTypeWarning, esv1beta1.ReasonUpdateFailed, err.Error())
  297. conditionSynced := NewExternalSecretCondition(esv1beta1.ExternalSecretReady, v1.ConditionFalse, esv1beta1.ConditionReasonSecretSyncedError, msg)
  298. SetExternalSecretCondition(externalSecret, *conditionSynced)
  299. counter.Inc()
  300. }
  301. func deleteOrphanedSecrets(ctx context.Context, cl client.Client, externalSecret *esv1beta1.ExternalSecret) error {
  302. secretList := v1.SecretList{}
  303. lblValue := utils.ObjectHash(fmt.Sprintf("%v/%v", externalSecret.Namespace, externalSecret.Name))
  304. ls := &metav1.LabelSelector{
  305. MatchLabels: map[string]string{
  306. esv1beta1.LabelOwner: lblValue,
  307. },
  308. }
  309. labelSelector, err := metav1.LabelSelectorAsSelector(ls)
  310. if err != nil {
  311. return err
  312. }
  313. err = cl.List(ctx, &secretList, &client.ListOptions{LabelSelector: labelSelector})
  314. if err != nil {
  315. return err
  316. }
  317. for key, secret := range secretList.Items {
  318. if externalSecret.Spec.Target.Name != "" && secret.Name != externalSecret.Spec.Target.Name {
  319. err = cl.Delete(ctx, &secretList.Items[key])
  320. if err != nil {
  321. return err
  322. }
  323. }
  324. }
  325. return nil
  326. }
  327. func (r *Reconciler) createOrUpdateSecret(ctx context.Context, secret *v1.Secret, mutationFunc func() error, es *esv1beta1.ExternalSecret) (bool, error) {
  328. fqdn := fmt.Sprintf(fieldOwnerTemplate, es.Name)
  329. key := client.ObjectKeyFromObject(secret)
  330. if err := r.Client.Get(ctx, key, secret); err != nil {
  331. if !apierrors.IsNotFound(err) {
  332. return false, err
  333. }
  334. if err := mutationFunc(); err != nil {
  335. return false, err
  336. }
  337. // Setting Field Owner even for CreationPolicy==Create
  338. if err := r.Client.Create(ctx, secret, client.FieldOwner(fqdn)); err != nil {
  339. return false, err
  340. }
  341. r.recorder.Event(es, v1.EventTypeNormal, esv1beta1.ReasonCreated, "Created Secret")
  342. return true, nil
  343. }
  344. existing := secret.DeepCopyObject()
  345. if err := mutationFunc(); err != nil {
  346. return false, err
  347. }
  348. if equality.Semantic.DeepEqual(existing, secret) {
  349. return false, nil
  350. }
  351. if err := r.Client.Update(ctx, secret, client.FieldOwner(fqdn)); err != nil {
  352. return false, err
  353. }
  354. r.recorder.Event(es, v1.EventTypeNormal, esv1beta1.ReasonUpdated, "Updated Secret")
  355. return false, nil
  356. }
  357. func (r *Reconciler) patchSecret(ctx context.Context, secret *v1.Secret, mutationFunc func() error, es *esv1beta1.ExternalSecret) error {
  358. fqdn := fmt.Sprintf(fieldOwnerTemplate, es.Name)
  359. err := r.Client.Get(ctx, client.ObjectKeyFromObject(secret), secret.DeepCopy())
  360. if apierrors.IsNotFound(err) {
  361. return fmt.Errorf(errPolicyMergeNotFound, secret.Name)
  362. }
  363. if err != nil {
  364. return fmt.Errorf(errPolicyMergeGetSecret, secret.Name, err)
  365. }
  366. existing := secret.DeepCopyObject()
  367. if err = mutationFunc(); err != nil {
  368. return fmt.Errorf(errPolicyMergeMutate, secret.Name, err)
  369. }
  370. // GVK is missing in the Secret, see:
  371. // https://github.com/kubernetes-sigs/controller-runtime/issues/526
  372. // https://github.com/kubernetes-sigs/controller-runtime/issues/1517
  373. // https://github.com/kubernetes/kubernetes/issues/80609
  374. // we need to manually set it before doing a Patch() as it depends on the GVK
  375. gvks, unversioned, err := r.Scheme.ObjectKinds(secret)
  376. if err != nil {
  377. return err
  378. }
  379. if !unversioned && len(gvks) == 1 {
  380. secret.SetGroupVersionKind(gvks[0])
  381. }
  382. if equality.Semantic.DeepEqual(existing, secret) {
  383. return nil
  384. }
  385. // Cleaning up Managed fields manually as to keep patch coherence
  386. secret.ObjectMeta.ManagedFields = nil
  387. // we're not able to resolve conflicts so we force ownership
  388. // see: https://kubernetes.io/docs/reference/using-api/server-side-apply/#using-server-side-apply-in-a-controller
  389. if err := r.Client.Patch(ctx, secret, client.Apply, client.FieldOwner(fqdn), client.ForceOwnership); err != nil {
  390. return fmt.Errorf(errPolicyMergePatch, secret.Name, err)
  391. }
  392. r.recorder.Event(es, v1.EventTypeNormal, esv1beta1.ReasonUpdated, "Updated Secret")
  393. return nil
  394. }
  395. func getManagedDataKeys(secret *v1.Secret, fieldOwner string) ([]string, error) {
  396. return getManagedFieldKeys(secret, fieldOwner, func(fields map[string]any) []string {
  397. dataFields := fields["f:data"]
  398. if dataFields == nil {
  399. return nil
  400. }
  401. df, ok := dataFields.(map[string]any)
  402. if !ok {
  403. return nil
  404. }
  405. var keys []string
  406. for k := range df {
  407. keys = append(keys, k)
  408. }
  409. return keys
  410. })
  411. }
  412. func getManagedFieldKeys(
  413. secret *v1.Secret,
  414. fieldOwner string,
  415. process func(fields map[string]any) []string,
  416. ) ([]string, error) {
  417. fqdn := fmt.Sprintf(fieldOwnerTemplate, fieldOwner)
  418. var keys []string
  419. for _, v := range secret.ObjectMeta.ManagedFields {
  420. if v.Manager != fqdn {
  421. continue
  422. }
  423. fields := make(map[string]any)
  424. err := json.Unmarshal(v.FieldsV1.Raw, &fields)
  425. if err != nil {
  426. return nil, fmt.Errorf("error unmarshaling managed fields: %w", err)
  427. }
  428. for _, key := range process(fields) {
  429. if key == "." {
  430. continue
  431. }
  432. keys = append(keys, strings.TrimPrefix(key, "f:"))
  433. }
  434. }
  435. return keys, nil
  436. }
  437. func getResourceVersion(es esv1beta1.ExternalSecret) string {
  438. return fmt.Sprintf("%d-%s", es.ObjectMeta.GetGeneration(), hashMeta(es.ObjectMeta))
  439. }
  440. func hashMeta(m metav1.ObjectMeta) string {
  441. type meta struct {
  442. annotations map[string]string
  443. labels map[string]string
  444. }
  445. return utils.ObjectHash(meta{
  446. annotations: m.Annotations,
  447. labels: m.Labels,
  448. })
  449. }
  450. func shouldSkipClusterSecretStore(r *Reconciler, es esv1beta1.ExternalSecret) bool {
  451. return !r.ClusterSecretStoreEnabled && es.Spec.SecretStoreRef.Kind == esv1beta1.ClusterSecretStoreKind
  452. }
  453. // shouldSkipUnmanagedStore iterates over all secretStore references in the externalSecret spec,
  454. // fetches the store and evaluates the controllerClass property.
  455. // Returns true if any storeRef points to store with a non-matching controllerClass.
  456. func shouldSkipUnmanagedStore(ctx context.Context, namespace string, r *Reconciler, es esv1beta1.ExternalSecret) (bool, error) {
  457. var storeList []esv1beta1.SecretStoreRef
  458. if es.Spec.SecretStoreRef.Name != "" {
  459. storeList = append(storeList, es.Spec.SecretStoreRef)
  460. }
  461. for _, ref := range es.Spec.Data {
  462. if ref.SourceRef != nil {
  463. storeList = append(storeList, ref.SourceRef.SecretStoreRef)
  464. }
  465. }
  466. for _, ref := range es.Spec.DataFrom {
  467. if ref.SourceRef != nil && ref.SourceRef.SecretStoreRef != nil {
  468. storeList = append(storeList, *ref.SourceRef.SecretStoreRef)
  469. }
  470. // verify that generator's controllerClass matches
  471. if ref.SourceRef != nil && ref.SourceRef.GeneratorRef != nil {
  472. genDef, err := r.getGeneratorDefinition(ctx, namespace, ref.SourceRef.GeneratorRef)
  473. if err != nil {
  474. return false, err
  475. }
  476. skipGenerator, err := shouldSkipGenerator(r, genDef)
  477. if err != nil {
  478. return false, err
  479. }
  480. if skipGenerator {
  481. return true, nil
  482. }
  483. }
  484. }
  485. for _, ref := range storeList {
  486. var store esv1beta1.GenericStore
  487. switch ref.Kind {
  488. case esv1beta1.SecretStoreKind, "":
  489. store = &esv1beta1.SecretStore{}
  490. case esv1beta1.ClusterSecretStoreKind:
  491. store = &esv1beta1.ClusterSecretStore{}
  492. namespace = ""
  493. }
  494. err := r.Client.Get(ctx, types.NamespacedName{
  495. Name: ref.Name,
  496. Namespace: namespace,
  497. }, store)
  498. if err != nil {
  499. return false, err
  500. }
  501. class := store.GetSpec().Controller
  502. if class != "" && class != r.ControllerClass {
  503. return true, nil
  504. }
  505. }
  506. return false, nil
  507. }
  508. func shouldRefresh(es esv1beta1.ExternalSecret) bool {
  509. // refresh if resource version changed
  510. if es.Status.SyncedResourceVersion != getResourceVersion(es) {
  511. return true
  512. }
  513. // skip refresh if refresh interval is 0
  514. if es.Spec.RefreshInterval.Duration == 0 && es.Status.SyncedResourceVersion != "" {
  515. return false
  516. }
  517. if es.Status.RefreshTime.IsZero() {
  518. return true
  519. }
  520. return es.Status.RefreshTime.Add(es.Spec.RefreshInterval.Duration).Before(time.Now())
  521. }
  522. func shouldReconcile(es esv1beta1.ExternalSecret) bool {
  523. if es.Spec.Target.Immutable && hasSyncedCondition(es) {
  524. return false
  525. }
  526. return true
  527. }
  528. func hasSyncedCondition(es esv1beta1.ExternalSecret) bool {
  529. for _, condition := range es.Status.Conditions {
  530. if condition.Reason == "SecretSynced" {
  531. return true
  532. }
  533. }
  534. return false
  535. }
  536. // isSecretValid checks if the secret exists, and it's data is consistent with the calculated hash.
  537. func isSecretValid(existingSecret v1.Secret) bool {
  538. // if target secret doesn't exist, or annotations as not set, we need to refresh
  539. if existingSecret.UID == "" || existingSecret.Annotations == nil {
  540. return false
  541. }
  542. // if the calculated hash is different from the calculation, then it's invalid
  543. if existingSecret.Annotations[esv1beta1.AnnotationDataHash] != utils.ObjectHash(existingSecret.Data) {
  544. return false
  545. }
  546. return true
  547. }
  548. // computeDataHashAnnotation generate a hash of the secret data combining the old key with the new keys to add or override.
  549. func (r *Reconciler) computeDataHashAnnotation(existing, secret *v1.Secret) string {
  550. data := make(map[string][]byte)
  551. for k, v := range existing.Data {
  552. data[k] = v
  553. }
  554. for k, v := range secret.Data {
  555. data[k] = v
  556. }
  557. return utils.ObjectHash(data)
  558. }
  559. // SetupWithManager returns a new controller builder that will be started by the provided Manager.
  560. func (r *Reconciler) SetupWithManager(mgr ctrl.Manager, opts controller.Options) error {
  561. r.recorder = mgr.GetEventRecorderFor("external-secrets")
  562. // Index .Spec.Target.Name to reconcile ExternalSecrets effectively when secrets have changed
  563. if err := mgr.GetFieldIndexer().IndexField(context.Background(), &esv1beta1.ExternalSecret{}, externalSecretSecretNameKey, func(obj client.Object) []string {
  564. es := obj.(*esv1beta1.ExternalSecret)
  565. if name := es.Spec.Target.Name; name != "" {
  566. return []string{name}
  567. }
  568. return []string{es.Name}
  569. }); err != nil {
  570. return err
  571. }
  572. return ctrl.NewControllerManagedBy(mgr).
  573. WithOptions(opts).
  574. For(&esv1beta1.ExternalSecret{}).
  575. // Cannot use Owns since the controller does not set owner reference when creation policy is not Owner
  576. Watches(
  577. &v1.Secret{},
  578. handler.EnqueueRequestsFromMapFunc(r.findObjectsForSecret),
  579. builder.WithPredicates(predicate.ResourceVersionChangedPredicate{}),
  580. builder.OnlyMetadata,
  581. ).
  582. Complete(r)
  583. }
  584. func (r *Reconciler) findObjectsForSecret(ctx context.Context, secret client.Object) []reconcile.Request {
  585. var externalSecrets esv1beta1.ExternalSecretList
  586. err := r.List(
  587. ctx,
  588. &externalSecrets,
  589. client.InNamespace(secret.GetNamespace()),
  590. client.MatchingFields{externalSecretSecretNameKey: secret.GetName()},
  591. )
  592. if err != nil {
  593. return []reconcile.Request{}
  594. }
  595. requests := make([]reconcile.Request, len(externalSecrets.Items))
  596. for i := range externalSecrets.Items {
  597. requests[i] = reconcile.Request{
  598. NamespacedName: types.NamespacedName{
  599. Name: externalSecrets.Items[i].GetName(),
  600. Namespace: externalSecrets.Items[i].GetNamespace(),
  601. },
  602. }
  603. }
  604. return requests
  605. }