keyvault.go 34 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528529530531532533534535536537538539540541542543544545546547548549550551552553554555556557558559560561562563564565566567568569570571572573574575576577578579580581582583584585586587588589590591592593594595596597598599600601602603604605606607608609610611612613614615616617618619620621622623624625626627628629630631632633634635636637638639640641642643644645646647648649650651652653654655656657658659660661662663664665666667668669670671672673674675676677678679680681682683684685686687688689690691692693694695696697698699700701702703704705706707708709710711712713714715716717718719720721722723724725726727728729730731732733734735736737738739740741742743744745746747748749750751752753754755756757758759760761762763764765766767768769770771772773774775776777778779780781782783784785786787788789790791792793794795796797798799800801802803804805806807808809810811812813814815816817818819820821822823824825826827828829830831832833834835836837838839840841842843844845846847848849850851852853854855856857858859860861862863864865866867868869870871872873874875876877878879880881882883884885886887888889890891892893894895896897898899900901902903904905906907908909910911912913914915916917918919920921922923924925926927928929930931932933934935936937938939940941942943944945946947948949950951952953954955956957958959960961962963964965966967968969970971972973974975976977978979980981982983984985986987988989990991992993994995996997998999100010011002100310041005100610071008100910101011101210131014101510161017101810191020102110221023
  1. /*
  2. Licensed under the Apache License, Version 2.0 (the "License");
  3. you may not use this file except in compliance with the License.
  4. You may obtain a copy of the License at
  5. http://www.apache.org/licenses/LICENSE-2.0
  6. Unless required by applicable law or agreed to in writing, software
  7. distributed under the License is distributed on an "AS IS" BASIS,
  8. WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
  9. See the License for the specific language governing permissions and
  10. limitations under the License.
  11. */
  12. package keyvault
  13. import (
  14. "context"
  15. "crypto/x509"
  16. b64 "encoding/base64"
  17. "encoding/json"
  18. "encoding/pem"
  19. "errors"
  20. "fmt"
  21. "os"
  22. "path"
  23. "regexp"
  24. "strings"
  25. "github.com/Azure/azure-sdk-for-go/profiles/latest/keyvault/keyvault"
  26. "github.com/Azure/go-autorest/autorest"
  27. "github.com/Azure/go-autorest/autorest/adal"
  28. "github.com/Azure/go-autorest/autorest/azure"
  29. kvauth "github.com/Azure/go-autorest/autorest/azure/auth"
  30. "github.com/AzureAD/microsoft-authentication-library-for-go/apps/confidential"
  31. "github.com/lestrrat-go/jwx/jwk"
  32. "github.com/tidwall/gjson"
  33. "golang.org/x/crypto/pkcs12"
  34. "golang.org/x/crypto/sha3"
  35. authv1 "k8s.io/api/authentication/v1"
  36. corev1 "k8s.io/api/core/v1"
  37. metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
  38. "k8s.io/apimachinery/pkg/types"
  39. "k8s.io/client-go/kubernetes"
  40. kcorev1 "k8s.io/client-go/kubernetes/typed/core/v1"
  41. "k8s.io/utils/pointer"
  42. "sigs.k8s.io/controller-runtime/pkg/client"
  43. ctrlcfg "sigs.k8s.io/controller-runtime/pkg/client/config"
  44. esv1beta1 "github.com/external-secrets/external-secrets/apis/externalsecrets/v1beta1"
  45. smmeta "github.com/external-secrets/external-secrets/apis/meta/v1"
  46. "github.com/external-secrets/external-secrets/pkg/provider/metrics"
  47. "github.com/external-secrets/external-secrets/pkg/utils"
  48. )
  49. const (
  50. defaultObjType = "secret"
  51. objectTypeCert = "cert"
  52. objectTypeKey = "key"
  53. AzureDefaultAudience = "api://AzureADTokenExchange"
  54. AnnotationClientID = "azure.workload.identity/client-id"
  55. AnnotationTenantID = "azure.workload.identity/tenant-id"
  56. managerLabel = "external-secrets"
  57. errUnexpectedStoreSpec = "unexpected store spec"
  58. errMissingAuthType = "cannot initialize Azure Client: no valid authType was specified"
  59. errPropNotExist = "property %s does not exist in key %s"
  60. errTagNotExist = "tag %s does not exist"
  61. errUnknownObjectType = "unknown Azure Keyvault object Type for %s"
  62. errUnmarshalJSONData = "error unmarshalling json data: %w"
  63. errDataFromCert = "cannot get use dataFrom to get certificate secret"
  64. errDataFromKey = "cannot get use dataFrom to get key secret"
  65. errMissingTenant = "missing tenantID in store config"
  66. errMissingSecretRef = "missing secretRef in provider config"
  67. errMissingClientIDSecret = "missing accessKeyID/secretAccessKey in store config"
  68. errFindSecret = "could not find secret %s/%s: %w"
  69. errFindDataKey = "no data for %q in secret '%s/%s'"
  70. errInvalidStore = "invalid store"
  71. errInvalidStoreSpec = "invalid store spec"
  72. errInvalidStoreProv = "invalid store provider"
  73. errInvalidAzureProv = "invalid azure keyvault provider"
  74. errInvalidSecRefClientID = "invalid AuthSecretRef.ClientID: %w"
  75. errInvalidSecRefClientSecret = "invalid AuthSecretRef.ClientSecret: %w"
  76. errInvalidSARef = "invalid ServiceAccountRef: %w"
  77. errMissingWorkloadEnvVars = "missing environment variables. AZURE_CLIENT_ID, AZURE_TENANT_ID and AZURE_FEDERATED_TOKEN_FILE must be set"
  78. errReadTokenFile = "unable to read token file %s: %w"
  79. errMissingSAAnnotation = "missing service account annotation: %s"
  80. )
  81. // https://github.com/external-secrets/external-secrets/issues/644
  82. var _ esv1beta1.SecretsClient = &Azure{}
  83. var _ esv1beta1.Provider = &Azure{}
  84. // interface to keyvault.BaseClient.
  85. type SecretClient interface {
  86. GetKey(ctx context.Context, vaultBaseURL string, keyName string, keyVersion string) (result keyvault.KeyBundle, err error)
  87. GetSecret(ctx context.Context, vaultBaseURL string, secretName string, secretVersion string) (result keyvault.SecretBundle, err error)
  88. GetSecretsComplete(ctx context.Context, vaultBaseURL string, maxresults *int32) (result keyvault.SecretListResultIterator, err error)
  89. GetCertificate(ctx context.Context, vaultBaseURL string, certificateName string, certificateVersion string) (result keyvault.CertificateBundle, err error)
  90. SetSecret(ctx context.Context, vaultBaseURL string, secretName string, parameters keyvault.SecretSetParameters) (result keyvault.SecretBundle, err error)
  91. ImportKey(ctx context.Context, vaultBaseURL string, keyName string, parameters keyvault.KeyImportParameters) (result keyvault.KeyBundle, err error)
  92. ImportCertificate(ctx context.Context, vaultBaseURL string, certificateName string, parameters keyvault.CertificateImportParameters) (result keyvault.CertificateBundle, err error)
  93. DeleteCertificate(ctx context.Context, vaultBaseURL string, certificateName string) (result keyvault.DeletedCertificateBundle, err error)
  94. DeleteKey(ctx context.Context, vaultBaseURL string, keyName string) (result keyvault.DeletedKeyBundle, err error)
  95. DeleteSecret(ctx context.Context, vaultBaseURL string, secretName string) (result keyvault.DeletedSecretBundle, err error)
  96. }
  97. type Azure struct {
  98. crClient client.Client
  99. kubeClient kcorev1.CoreV1Interface
  100. store esv1beta1.GenericStore
  101. provider *esv1beta1.AzureKVProvider
  102. baseClient SecretClient
  103. namespace string
  104. }
  105. func init() {
  106. esv1beta1.Register(&Azure{}, &esv1beta1.SecretStoreProvider{
  107. AzureKV: &esv1beta1.AzureKVProvider{},
  108. })
  109. }
  110. // Capabilities return the provider supported capabilities (ReadOnly, WriteOnly, ReadWrite).
  111. func (a *Azure) Capabilities() esv1beta1.SecretStoreCapabilities {
  112. return esv1beta1.SecretStoreReadWrite
  113. }
  114. // NewClient constructs a new secrets client based on the provided store.
  115. func (a *Azure) NewClient(ctx context.Context, store esv1beta1.GenericStore, kube client.Client, namespace string) (esv1beta1.SecretsClient, error) {
  116. return newClient(ctx, store, kube, namespace)
  117. }
  118. func newClient(ctx context.Context, store esv1beta1.GenericStore, kube client.Client, namespace string) (esv1beta1.SecretsClient, error) {
  119. provider, err := getProvider(store)
  120. if err != nil {
  121. return nil, err
  122. }
  123. cfg, err := ctrlcfg.GetConfig()
  124. if err != nil {
  125. return nil, err
  126. }
  127. kubeClient, err := kubernetes.NewForConfig(cfg)
  128. if err != nil {
  129. return nil, err
  130. }
  131. az := &Azure{
  132. crClient: kube,
  133. kubeClient: kubeClient.CoreV1(),
  134. store: store,
  135. namespace: namespace,
  136. provider: provider,
  137. }
  138. // allow SecretStore controller validation to pass
  139. // when using referent namespace.
  140. if store.GetKind() == esv1beta1.ClusterSecretStoreKind &&
  141. namespace == "" &&
  142. isReferentSpec(provider) {
  143. return az, nil
  144. }
  145. var authorizer autorest.Authorizer
  146. switch *provider.AuthType {
  147. case esv1beta1.AzureManagedIdentity:
  148. authorizer, err = az.authorizerForManagedIdentity()
  149. case esv1beta1.AzureServicePrincipal:
  150. authorizer, err = az.authorizerForServicePrincipal(ctx)
  151. case esv1beta1.AzureWorkloadIdentity:
  152. authorizer, err = az.authorizerForWorkloadIdentity(ctx, NewTokenProvider)
  153. default:
  154. err = fmt.Errorf(errMissingAuthType)
  155. }
  156. cl := keyvault.New()
  157. cl.Authorizer = authorizer
  158. az.baseClient = &cl
  159. return az, err
  160. }
  161. func getProvider(store esv1beta1.GenericStore) (*esv1beta1.AzureKVProvider, error) {
  162. spc := store.GetSpec()
  163. if spc == nil || spc.Provider.AzureKV == nil {
  164. return nil, errors.New(errUnexpectedStoreSpec)
  165. }
  166. return spc.Provider.AzureKV, nil
  167. }
  168. func (a *Azure) ValidateStore(store esv1beta1.GenericStore) error {
  169. if store == nil {
  170. return fmt.Errorf(errInvalidStore)
  171. }
  172. spc := store.GetSpec()
  173. if spc == nil {
  174. return fmt.Errorf(errInvalidStoreSpec)
  175. }
  176. if spc.Provider == nil {
  177. return fmt.Errorf(errInvalidStoreProv)
  178. }
  179. p := spc.Provider.AzureKV
  180. if p == nil {
  181. return fmt.Errorf(errInvalidAzureProv)
  182. }
  183. if p.AuthSecretRef != nil {
  184. if p.AuthSecretRef.ClientID != nil {
  185. if err := utils.ValidateReferentSecretSelector(store, *p.AuthSecretRef.ClientID); err != nil {
  186. return fmt.Errorf(errInvalidSecRefClientID, err)
  187. }
  188. }
  189. if p.AuthSecretRef.ClientSecret != nil {
  190. if err := utils.ValidateReferentSecretSelector(store, *p.AuthSecretRef.ClientSecret); err != nil {
  191. return fmt.Errorf(errInvalidSecRefClientSecret, err)
  192. }
  193. }
  194. }
  195. if p.ServiceAccountRef != nil {
  196. if err := utils.ValidateReferentServiceAccountSelector(store, *p.ServiceAccountRef); err != nil {
  197. return fmt.Errorf(errInvalidSARef, err)
  198. }
  199. }
  200. return nil
  201. }
  202. func canDelete(tags map[string]*string, err error) (bool, error) {
  203. aerr := &autorest.DetailedError{}
  204. conv := errors.As(err, aerr)
  205. if err != nil && !conv {
  206. return false, fmt.Errorf("could not parse error: %w", err)
  207. }
  208. if conv && aerr.StatusCode != 404 { // Secret is already deleted, nothing to do.
  209. return false, fmt.Errorf("unexpected api error: %w", err)
  210. }
  211. if aerr.StatusCode == 404 {
  212. return false, nil
  213. }
  214. manager, ok := tags["managed-by"]
  215. if !ok || manager == nil || *manager != managerLabel {
  216. return false, fmt.Errorf("not managed by external-secrets")
  217. }
  218. return true, nil
  219. }
  220. func (a *Azure) deleteKeyVaultKey(ctx context.Context, keyName string) error {
  221. value, err := a.baseClient.GetKey(ctx, *a.provider.VaultURL, keyName, "")
  222. metrics.ObserveAPICall(metrics.ProviderAzureKV, metrics.CallAzureKVGetKey, err)
  223. ok, err := canDelete(value.Tags, err)
  224. if err != nil {
  225. return fmt.Errorf("error getting key %v: %w", keyName, err)
  226. }
  227. if ok {
  228. _, err = a.baseClient.DeleteKey(ctx, *a.provider.VaultURL, keyName)
  229. metrics.ObserveAPICall(metrics.ProviderAzureKV, metrics.CallAzureKVDeleteKey, err)
  230. if err != nil {
  231. return fmt.Errorf("error deleting key %v: %w", keyName, err)
  232. }
  233. }
  234. return nil
  235. }
  236. func (a *Azure) deleteKeyVaultSecret(ctx context.Context, secretName string) error {
  237. value, err := a.baseClient.GetSecret(ctx, *a.provider.VaultURL, secretName, "")
  238. metrics.ObserveAPICall(metrics.ProviderAzureKV, metrics.CallAzureKVGetSecret, err)
  239. ok, err := canDelete(value.Tags, err)
  240. if err != nil {
  241. return fmt.Errorf("error getting secret %v: %w", secretName, err)
  242. }
  243. if ok {
  244. _, err = a.baseClient.DeleteSecret(ctx, *a.provider.VaultURL, secretName)
  245. metrics.ObserveAPICall(metrics.ProviderAzureKV, metrics.CallAzureKVDeleteSecret, err)
  246. if err != nil {
  247. return fmt.Errorf("error deleting secret %v: %w", secretName, err)
  248. }
  249. }
  250. return nil
  251. }
  252. func (a *Azure) deleteKeyVaultCertificate(ctx context.Context, certName string) error {
  253. value, err := a.baseClient.GetCertificate(ctx, *a.provider.VaultURL, certName, "")
  254. metrics.ObserveAPICall(metrics.ProviderAzureKV, metrics.CallAzureKVGetCertificate, err)
  255. ok, err := canDelete(value.Tags, err)
  256. if err != nil {
  257. return fmt.Errorf("error getting certificate %v: %w", certName, err)
  258. }
  259. if ok {
  260. _, err = a.baseClient.DeleteCertificate(ctx, *a.provider.VaultURL, certName)
  261. metrics.ObserveAPICall(metrics.ProviderAzureKV, metrics.CallAzureKVDeleteCertificate, err)
  262. if err != nil {
  263. return fmt.Errorf("error deleting certificate %v: %w", certName, err)
  264. }
  265. }
  266. return nil
  267. }
  268. func (a *Azure) DeleteSecret(ctx context.Context, remoteRef esv1beta1.PushRemoteRef) error {
  269. objectType, secretName := getObjType(esv1beta1.ExternalSecretDataRemoteRef{Key: remoteRef.GetRemoteKey()})
  270. switch objectType {
  271. case defaultObjType:
  272. return a.deleteKeyVaultSecret(ctx, secretName)
  273. case objectTypeCert:
  274. return a.deleteKeyVaultCertificate(ctx, secretName)
  275. case objectTypeKey:
  276. return a.deleteKeyVaultKey(ctx, secretName)
  277. default:
  278. return fmt.Errorf("secret type '%v' is not supported", objectType)
  279. }
  280. }
  281. func getCertificateFromValue(value []byte) (*x509.Certificate, error) {
  282. // 1st: try decode pkcs12
  283. _, localCert, err := pkcs12.Decode(value, "")
  284. if err == nil {
  285. return localCert, nil
  286. }
  287. // 2nd: try DER
  288. localCert, err = x509.ParseCertificate(value)
  289. if err == nil {
  290. return localCert, nil
  291. }
  292. // 3nd: parse PEM blocks
  293. for {
  294. block, rest := pem.Decode(value)
  295. value = rest
  296. if block == nil {
  297. break
  298. }
  299. cert, err := x509.ParseCertificate(block.Bytes)
  300. if err == nil {
  301. return cert, nil
  302. }
  303. }
  304. return nil, fmt.Errorf("could not parse certificate value as PKCS#12, DER or PEM")
  305. }
  306. func getKeyFromValue(value []byte) (interface{}, error) {
  307. val := value
  308. pemBlock, _ := pem.Decode(value)
  309. // if a private key regular expression doesn't match, we should consider this key to be symmetric
  310. if pemBlock == nil {
  311. return val, nil
  312. }
  313. val = pemBlock.Bytes
  314. switch pemBlock.Type {
  315. case "PRIVATE KEY":
  316. return x509.ParsePKCS8PrivateKey(val)
  317. case "RSA PRIVATE KEY":
  318. return x509.ParsePKCS1PrivateKey(val)
  319. case "EC PRIVATE KEY":
  320. return x509.ParseECPrivateKey(val)
  321. default:
  322. return nil, fmt.Errorf("key type %v is not supported", pemBlock.Type)
  323. }
  324. }
  325. func canCreate(tags map[string]*string, err error) (bool, error) {
  326. aerr := &autorest.DetailedError{}
  327. conv := errors.As(err, aerr)
  328. if err != nil && !conv {
  329. return false, fmt.Errorf("could not parse error: %w", err)
  330. }
  331. if conv && aerr.StatusCode != 404 {
  332. return false, fmt.Errorf("unexpected api error: %w", err)
  333. }
  334. if err == nil {
  335. manager, ok := tags["managed-by"]
  336. if !ok || manager == nil || *manager != managerLabel {
  337. return false, fmt.Errorf("not managed by external-secrets")
  338. }
  339. }
  340. return true, nil
  341. }
  342. func (a *Azure) setKeyVaultSecret(ctx context.Context, secretName string, value []byte) error {
  343. secret, err := a.baseClient.GetSecret(ctx, *a.provider.VaultURL, secretName, "")
  344. metrics.ObserveAPICall(metrics.ProviderAzureKV, metrics.CallAzureKVGetSecret, err)
  345. ok, err := canCreate(secret.Tags, err)
  346. if err != nil {
  347. return fmt.Errorf("cannot get secret %v: %w", secretName, err)
  348. }
  349. if !ok {
  350. return nil
  351. }
  352. val := string(value)
  353. if secret.Value != nil && val == *secret.Value {
  354. return nil
  355. }
  356. secretParams := keyvault.SecretSetParameters{
  357. Value: &val,
  358. Tags: map[string]*string{
  359. "managed-by": pointer.String(managerLabel),
  360. },
  361. SecretAttributes: &keyvault.SecretAttributes{
  362. Enabled: pointer.Bool(true),
  363. },
  364. }
  365. _, err = a.baseClient.SetSecret(ctx, *a.provider.VaultURL, secretName, secretParams)
  366. metrics.ObserveAPICall(metrics.ProviderAzureKV, metrics.CallAzureKVGetSecret, err)
  367. if err != nil {
  368. return fmt.Errorf("could not set secret %v: %w", secretName, err)
  369. }
  370. return nil
  371. }
  372. func (a *Azure) setKeyVaultCertificate(ctx context.Context, secretName string, value []byte) error {
  373. val := b64.StdEncoding.EncodeToString(value)
  374. localCert, err := getCertificateFromValue(value)
  375. if err != nil {
  376. return fmt.Errorf("value from secret is not a valid certificate: %w", err)
  377. }
  378. cert, err := a.baseClient.GetCertificate(ctx, *a.provider.VaultURL, secretName, "")
  379. metrics.ObserveAPICall(metrics.ProviderAzureKV, metrics.CallAzureKVGetCertificate, err)
  380. ok, err := canCreate(cert.Tags, err)
  381. if err != nil {
  382. return fmt.Errorf("cannot get certificate %v: %w", secretName, err)
  383. }
  384. if !ok {
  385. return nil
  386. }
  387. b512 := sha3.Sum512(localCert.Raw)
  388. if cert.Cer != nil && b512 == sha3.Sum512(*cert.Cer) {
  389. return nil
  390. }
  391. params := keyvault.CertificateImportParameters{
  392. Base64EncodedCertificate: &val,
  393. Tags: map[string]*string{
  394. "managed-by": pointer.String(managerLabel),
  395. },
  396. }
  397. _, err = a.baseClient.ImportCertificate(ctx, *a.provider.VaultURL, secretName, params)
  398. metrics.ObserveAPICall(metrics.ProviderAzureKV, metrics.CallAzureKVImportCertificate, err)
  399. if err != nil {
  400. return fmt.Errorf("could not import certificate %v: %w", secretName, err)
  401. }
  402. return nil
  403. }
  404. func equalKeys(newKey, oldKey keyvault.JSONWebKey) bool {
  405. // checks for everything except KeyID and KeyOps
  406. rsaCheck := newKey.E != nil && oldKey.E != nil && *newKey.E == *oldKey.E &&
  407. newKey.N != nil && oldKey.N != nil && *newKey.N == *oldKey.N
  408. symmetricCheck := newKey.Crv == oldKey.Crv &&
  409. newKey.T != nil && oldKey.T != nil && *newKey.T == *oldKey.T &&
  410. newKey.X != nil && oldKey.X != nil && *newKey.X == *oldKey.X &&
  411. newKey.Y != nil && oldKey.Y != nil && *newKey.Y == *oldKey.Y
  412. return newKey.Kty == oldKey.Kty && (rsaCheck || symmetricCheck)
  413. }
  414. func (a *Azure) setKeyVaultKey(ctx context.Context, secretName string, value []byte) error {
  415. key, err := getKeyFromValue(value)
  416. if err != nil {
  417. return fmt.Errorf("could not load private key %v: %w", secretName, err)
  418. }
  419. jwKey, err := jwk.New(key)
  420. if err != nil {
  421. return fmt.Errorf("failed to generate a JWK from secret %v content: %w", secretName, err)
  422. }
  423. buf, err := json.Marshal(jwKey)
  424. if err != nil {
  425. return fmt.Errorf("error parsing key: %w", err)
  426. }
  427. azkey := keyvault.JSONWebKey{}
  428. err = json.Unmarshal(buf, &azkey)
  429. if err != nil {
  430. return fmt.Errorf("error unmarshalling key: %w", err)
  431. }
  432. keyFromVault, err := a.baseClient.GetKey(ctx, *a.provider.VaultURL, secretName, "")
  433. metrics.ObserveAPICall(metrics.ProviderAzureKV, metrics.CallAzureKVGetKey, err)
  434. ok, err := canCreate(keyFromVault.Tags, err)
  435. if err != nil {
  436. return fmt.Errorf("cannot get key %v: %w", secretName, err)
  437. }
  438. if !ok {
  439. return nil
  440. }
  441. if keyFromVault.Key != nil && equalKeys(azkey, *keyFromVault.Key) {
  442. return nil
  443. }
  444. params := keyvault.KeyImportParameters{
  445. Key: &azkey,
  446. KeyAttributes: &keyvault.KeyAttributes{},
  447. Tags: map[string]*string{
  448. "managed-by": pointer.String(managerLabel),
  449. },
  450. }
  451. _, err = a.baseClient.ImportKey(ctx, *a.provider.VaultURL, secretName, params)
  452. metrics.ObserveAPICall(metrics.ProviderAzureKV, metrics.CallAzureKVImportKey, err)
  453. if err != nil {
  454. return fmt.Errorf("could not import key %v: %w", secretName, err)
  455. }
  456. return nil
  457. }
  458. // PushSecret stores secrets into a Key vault instance.
  459. func (a *Azure) PushSecret(ctx context.Context, value []byte, remoteRef esv1beta1.PushRemoteRef) error {
  460. objectType, secretName := getObjType(esv1beta1.ExternalSecretDataRemoteRef{Key: remoteRef.GetRemoteKey()})
  461. switch objectType {
  462. case defaultObjType:
  463. return a.setKeyVaultSecret(ctx, secretName, value)
  464. case objectTypeCert:
  465. return a.setKeyVaultCertificate(ctx, secretName, value)
  466. case objectTypeKey:
  467. return a.setKeyVaultKey(ctx, secretName, value)
  468. default:
  469. return fmt.Errorf("secret type %v not supported", objectType)
  470. }
  471. }
  472. // Implements store.Client.GetAllSecrets Interface.
  473. // Retrieves a map[string][]byte with the secret names as key and the secret itself as the calue.
  474. func (a *Azure) GetAllSecrets(ctx context.Context, ref esv1beta1.ExternalSecretFind) (map[string][]byte, error) {
  475. basicClient := a.baseClient
  476. secretsMap := make(map[string][]byte)
  477. checkTags := len(ref.Tags) > 0
  478. checkName := ref.Name != nil && len(ref.Name.RegExp) > 0
  479. secretListIter, err := basicClient.GetSecretsComplete(context.Background(), *a.provider.VaultURL, nil)
  480. err = parseError(err)
  481. if err != nil {
  482. return nil, err
  483. }
  484. for secretListIter.NotDone() {
  485. secretList := secretListIter.Response().Value
  486. for _, secret := range *secretList {
  487. ok, secretName := isValidSecret(checkTags, checkName, ref, secret)
  488. if !ok {
  489. continue
  490. }
  491. secretResp, err := basicClient.GetSecret(context.Background(), *a.provider.VaultURL, secretName, "")
  492. err = parseError(err)
  493. if err != nil {
  494. return nil, err
  495. }
  496. secretValue := *secretResp.Value
  497. secretsMap[secretName] = []byte(secretValue)
  498. }
  499. err = secretListIter.Next()
  500. if err != nil {
  501. return nil, err
  502. }
  503. }
  504. return secretsMap, nil
  505. }
  506. // Retrieves a tag value if specified and all tags in JSON format if not.
  507. func getSecretTag(tags map[string]*string, property string) ([]byte, error) {
  508. if property == "" {
  509. secretTagsData := make(map[string]string)
  510. for k, v := range tags {
  511. secretTagsData[k] = *v
  512. }
  513. return json.Marshal(secretTagsData)
  514. }
  515. if val, exist := tags[property]; exist {
  516. return []byte(*val), nil
  517. }
  518. idx := strings.Index(property, ".")
  519. if idx < 0 {
  520. return nil, fmt.Errorf(errTagNotExist, property)
  521. }
  522. if idx > 0 {
  523. tagName := property[0:idx]
  524. if val, exist := tags[tagName]; exist {
  525. key := strings.Replace(property, tagName+".", "", 1)
  526. return getProperty(*val, key, property)
  527. }
  528. }
  529. return nil, fmt.Errorf(errTagNotExist, property)
  530. }
  531. // Retrieves a property value if specified and the secret value if not.
  532. func getProperty(secret, property, key string) ([]byte, error) {
  533. if property == "" {
  534. return []byte(secret), nil
  535. }
  536. res := gjson.Get(secret, property)
  537. if !res.Exists() {
  538. idx := strings.Index(property, ".")
  539. if idx < 0 {
  540. return nil, fmt.Errorf(errPropNotExist, property, key)
  541. }
  542. escaped := strings.ReplaceAll(property, ".", "\\.")
  543. jValue := gjson.Get(secret, escaped)
  544. if jValue.Exists() {
  545. return []byte(jValue.String()), nil
  546. }
  547. return nil, fmt.Errorf(errPropNotExist, property, key)
  548. }
  549. return []byte(res.String()), nil
  550. }
  551. func parseError(err error) error {
  552. aerr := autorest.DetailedError{}
  553. if errors.As(err, &aerr) && aerr.StatusCode == 404 {
  554. return esv1beta1.NoSecretError{}
  555. }
  556. return err
  557. }
  558. // Implements store.Client.GetSecret Interface.
  559. // Retrieves a secret/Key/Certificate/Tag with the secret name defined in ref.Name
  560. // The Object Type is defined as a prefix in the ref.Name , if no prefix is defined , we assume a secret is required.
  561. func (a *Azure) GetSecret(ctx context.Context, ref esv1beta1.ExternalSecretDataRemoteRef) ([]byte, error) {
  562. objectType, secretName := getObjType(ref)
  563. switch objectType {
  564. case defaultObjType:
  565. // returns a SecretBundle with the secret value
  566. // https://pkg.go.dev/github.com/Azure/azure-sdk-for-go/services/keyvault/v7.0/keyvault#SecretBundle
  567. secretResp, err := a.baseClient.GetSecret(context.Background(), *a.provider.VaultURL, secretName, ref.Version)
  568. metrics.ObserveAPICall(metrics.ProviderAzureKV, metrics.CallAzureKVGetSecret, err)
  569. err = parseError(err)
  570. if err != nil {
  571. return nil, err
  572. }
  573. if ref.MetadataPolicy == esv1beta1.ExternalSecretMetadataPolicyFetch {
  574. return getSecretTag(secretResp.Tags, ref.Property)
  575. }
  576. return getProperty(*secretResp.Value, ref.Property, ref.Key)
  577. case objectTypeCert:
  578. // returns a CertBundle. We return CER contents of x509 certificate
  579. // see: https://pkg.go.dev/github.com/Azure/azure-sdk-for-go/services/keyvault/v7.0/keyvault#CertificateBundle
  580. certResp, err := a.baseClient.GetCertificate(context.Background(), *a.provider.VaultURL, secretName, ref.Version)
  581. metrics.ObserveAPICall(metrics.ProviderAzureKV, metrics.CallAzureKVGetCertificate, err)
  582. err = parseError(err)
  583. if err != nil {
  584. return nil, err
  585. }
  586. if ref.MetadataPolicy == esv1beta1.ExternalSecretMetadataPolicyFetch {
  587. return getSecretTag(certResp.Tags, ref.Property)
  588. }
  589. return *certResp.Cer, nil
  590. case objectTypeKey:
  591. // returns a KeyBundle that contains a jwk
  592. // azure kv returns only public keys
  593. // see: https://pkg.go.dev/github.com/Azure/azure-sdk-for-go/services/keyvault/v7.0/keyvault#KeyBundle
  594. keyResp, err := a.baseClient.GetKey(context.Background(), *a.provider.VaultURL, secretName, ref.Version)
  595. metrics.ObserveAPICall(metrics.ProviderAzureKV, metrics.CallAzureKVGetKey, err)
  596. err = parseError(err)
  597. if err != nil {
  598. return nil, err
  599. }
  600. if ref.MetadataPolicy == esv1beta1.ExternalSecretMetadataPolicyFetch {
  601. return getSecretTag(keyResp.Tags, ref.Property)
  602. }
  603. return json.Marshal(keyResp.Key)
  604. }
  605. return nil, fmt.Errorf(errUnknownObjectType, secretName)
  606. }
  607. // returns a SecretBundle with the tags values.
  608. func (a *Azure) getSecretTags(ref esv1beta1.ExternalSecretDataRemoteRef) (map[string]*string, error) {
  609. _, secretName := getObjType(ref)
  610. secretResp, err := a.baseClient.GetSecret(context.Background(), *a.provider.VaultURL, secretName, ref.Version)
  611. metrics.ObserveAPICall(metrics.ProviderAzureKV, metrics.CallAzureKVGetSecret, err)
  612. err = parseError(err)
  613. if err != nil {
  614. return nil, err
  615. }
  616. secretTagsData := make(map[string]*string)
  617. for tagname, tagval := range secretResp.Tags {
  618. name := secretName + "_" + tagname
  619. kv := make(map[string]string)
  620. err = json.Unmarshal([]byte(*tagval), &kv)
  621. // if the tagvalue is not in JSON format then we added to secretTagsData we added as it is
  622. if err != nil {
  623. secretTagsData[name] = tagval
  624. } else {
  625. for k, v := range kv {
  626. value := v
  627. secretTagsData[name+"_"+k] = &value
  628. }
  629. }
  630. }
  631. return secretTagsData, nil
  632. }
  633. // Implements store.Client.GetSecretMap Interface.
  634. // New version of GetSecretMap.
  635. func (a *Azure) GetSecretMap(ctx context.Context, ref esv1beta1.ExternalSecretDataRemoteRef) (map[string][]byte, error) {
  636. objectType, secretName := getObjType(ref)
  637. switch objectType {
  638. case defaultObjType:
  639. data, err := a.GetSecret(ctx, ref)
  640. if err != nil {
  641. return nil, err
  642. }
  643. if ref.MetadataPolicy == esv1beta1.ExternalSecretMetadataPolicyFetch {
  644. tags, _ := a.getSecretTags(ref)
  645. return getSecretMapProperties(tags, ref.Key, ref.Property), nil
  646. }
  647. return getSecretMapMap(data)
  648. case objectTypeCert:
  649. return nil, fmt.Errorf(errDataFromCert)
  650. case objectTypeKey:
  651. return nil, fmt.Errorf(errDataFromKey)
  652. }
  653. return nil, fmt.Errorf(errUnknownObjectType, secretName)
  654. }
  655. func getSecretMapMap(data []byte) (map[string][]byte, error) {
  656. kv := make(map[string]json.RawMessage)
  657. err := json.Unmarshal(data, &kv)
  658. if err != nil {
  659. return nil, fmt.Errorf(errUnmarshalJSONData, err)
  660. }
  661. secretData := make(map[string][]byte)
  662. for k, v := range kv {
  663. var strVal string
  664. err = json.Unmarshal(v, &strVal)
  665. if err == nil {
  666. secretData[k] = []byte(strVal)
  667. } else {
  668. secretData[k] = v
  669. }
  670. }
  671. return secretData, nil
  672. }
  673. func getSecretMapProperties(tags map[string]*string, key, property string) map[string][]byte {
  674. tagByteArray := make(map[string][]byte)
  675. if property != "" {
  676. keyPropertyName := key + "_" + property
  677. singleTag, _ := getSecretTag(tags, keyPropertyName)
  678. tagByteArray[keyPropertyName] = singleTag
  679. return tagByteArray
  680. }
  681. for k, v := range tags {
  682. tagByteArray[k] = []byte(*v)
  683. }
  684. return tagByteArray
  685. }
  686. func (a *Azure) authorizerForWorkloadIdentity(ctx context.Context, tokenProvider tokenProviderFunc) (autorest.Authorizer, error) {
  687. aadEndpoint := AadEndpointForType(a.provider.EnvironmentType)
  688. kvResource := kvResourceForProviderConfig(a.provider.EnvironmentType)
  689. // if no serviceAccountRef was provided
  690. // we expect certain env vars to be present.
  691. // They are set by the azure workload identity webhook.
  692. if a.provider.ServiceAccountRef == nil {
  693. clientID := os.Getenv("AZURE_CLIENT_ID")
  694. tenantID := os.Getenv("AZURE_TENANT_ID")
  695. tokenFilePath := os.Getenv("AZURE_FEDERATED_TOKEN_FILE")
  696. if clientID == "" || tenantID == "" || tokenFilePath == "" {
  697. return nil, errors.New(errMissingWorkloadEnvVars)
  698. }
  699. token, err := os.ReadFile(tokenFilePath)
  700. if err != nil {
  701. return nil, fmt.Errorf(errReadTokenFile, tokenFilePath, err)
  702. }
  703. tp, err := tokenProvider(ctx, string(token), clientID, tenantID, aadEndpoint, kvResource)
  704. if err != nil {
  705. return nil, err
  706. }
  707. return autorest.NewBearerAuthorizer(tp), nil
  708. }
  709. ns := a.namespace
  710. if a.store.GetKind() == esv1beta1.ClusterSecretStoreKind && a.provider.ServiceAccountRef.Namespace != nil {
  711. ns = *a.provider.ServiceAccountRef.Namespace
  712. }
  713. var sa corev1.ServiceAccount
  714. err := a.crClient.Get(ctx, types.NamespacedName{
  715. Name: a.provider.ServiceAccountRef.Name,
  716. Namespace: ns,
  717. }, &sa)
  718. if err != nil {
  719. return nil, err
  720. }
  721. clientID, ok := sa.ObjectMeta.Annotations[AnnotationClientID]
  722. if !ok {
  723. return nil, fmt.Errorf(errMissingSAAnnotation, AnnotationClientID)
  724. }
  725. tenantID, ok := sa.ObjectMeta.Annotations[AnnotationTenantID]
  726. if !ok {
  727. return nil, fmt.Errorf(errMissingSAAnnotation, AnnotationTenantID)
  728. }
  729. audiences := []string{AzureDefaultAudience}
  730. if len(a.provider.ServiceAccountRef.Audiences) > 0 {
  731. audiences = append(audiences, a.provider.ServiceAccountRef.Audiences...)
  732. }
  733. token, err := FetchSAToken(ctx, ns, a.provider.ServiceAccountRef.Name, audiences, a.kubeClient)
  734. if err != nil {
  735. return nil, err
  736. }
  737. tp, err := tokenProvider(ctx, token, clientID, tenantID, aadEndpoint, kvResource)
  738. if err != nil {
  739. return nil, err
  740. }
  741. return autorest.NewBearerAuthorizer(tp), nil
  742. }
  743. func FetchSAToken(ctx context.Context, ns, name string, audiences []string, kubeClient kcorev1.CoreV1Interface) (string, error) {
  744. token, err := kubeClient.ServiceAccounts(ns).CreateToken(ctx, name, &authv1.TokenRequest{
  745. Spec: authv1.TokenRequestSpec{
  746. Audiences: audiences,
  747. },
  748. }, metav1.CreateOptions{})
  749. if err != nil {
  750. return "", err
  751. }
  752. return token.Status.Token, nil
  753. }
  754. // tokenProvider satisfies the adal.OAuthTokenProvider interface.
  755. type tokenProvider struct {
  756. accessToken string
  757. }
  758. type tokenProviderFunc func(ctx context.Context, token, clientID, tenantID, aadEndpoint, kvResource string) (adal.OAuthTokenProvider, error)
  759. func NewTokenProvider(ctx context.Context, token, clientID, tenantID, aadEndpoint, kvResource string) (adal.OAuthTokenProvider, error) {
  760. // exchange token with Azure AccessToken
  761. cred := confidential.NewCredFromAssertionCallback(func(ctx context.Context, aro confidential.AssertionRequestOptions) (string, error) {
  762. return token, nil
  763. })
  764. cClient, err := confidential.New(fmt.Sprintf("%s%s/oauth2/token", aadEndpoint, tenantID), clientID, cred)
  765. if err != nil {
  766. return nil, err
  767. }
  768. scope := kvResource
  769. // .default needs to be added to the scope
  770. if !strings.Contains(kvResource, ".default") {
  771. scope = fmt.Sprintf("%s/.default", kvResource)
  772. }
  773. authRes, err := cClient.AcquireTokenByCredential(ctx, []string{
  774. scope,
  775. })
  776. if err != nil {
  777. return nil, err
  778. }
  779. return &tokenProvider{
  780. accessToken: authRes.AccessToken,
  781. }, nil
  782. }
  783. func (t *tokenProvider) OAuthToken() string {
  784. return t.accessToken
  785. }
  786. func (a *Azure) authorizerForManagedIdentity() (autorest.Authorizer, error) {
  787. msiConfig := kvauth.NewMSIConfig()
  788. msiConfig.Resource = kvResourceForProviderConfig(a.provider.EnvironmentType)
  789. if a.provider.IdentityID != nil {
  790. msiConfig.ClientID = *a.provider.IdentityID
  791. }
  792. return msiConfig.Authorizer()
  793. }
  794. func (a *Azure) authorizerForServicePrincipal(ctx context.Context) (autorest.Authorizer, error) {
  795. if a.provider.TenantID == nil {
  796. return nil, fmt.Errorf(errMissingTenant)
  797. }
  798. if a.provider.AuthSecretRef == nil {
  799. return nil, fmt.Errorf(errMissingSecretRef)
  800. }
  801. if a.provider.AuthSecretRef.ClientID == nil || a.provider.AuthSecretRef.ClientSecret == nil {
  802. return nil, fmt.Errorf(errMissingClientIDSecret)
  803. }
  804. clusterScoped := false
  805. if a.store.GetKind() == esv1beta1.ClusterSecretStoreKind {
  806. clusterScoped = true
  807. }
  808. cid, err := a.secretKeyRef(ctx, a.namespace, *a.provider.AuthSecretRef.ClientID, clusterScoped)
  809. if err != nil {
  810. return nil, err
  811. }
  812. csec, err := a.secretKeyRef(ctx, a.namespace, *a.provider.AuthSecretRef.ClientSecret, clusterScoped)
  813. if err != nil {
  814. return nil, err
  815. }
  816. clientCredentialsConfig := kvauth.NewClientCredentialsConfig(cid, csec, *a.provider.TenantID)
  817. clientCredentialsConfig.Resource = kvResourceForProviderConfig(a.provider.EnvironmentType)
  818. clientCredentialsConfig.AADEndpoint = AadEndpointForType(a.provider.EnvironmentType)
  819. return clientCredentialsConfig.Authorizer()
  820. }
  821. // secretKeyRef fetch a secret key.
  822. func (a *Azure) secretKeyRef(ctx context.Context, namespace string, secretRef smmeta.SecretKeySelector, clusterScoped bool) (string, error) {
  823. var secret corev1.Secret
  824. ref := types.NamespacedName{
  825. Name: secretRef.Name,
  826. Namespace: namespace,
  827. }
  828. if clusterScoped && secretRef.Namespace != nil {
  829. ref.Namespace = *secretRef.Namespace
  830. }
  831. err := a.crClient.Get(ctx, ref, &secret)
  832. if err != nil {
  833. return "", fmt.Errorf(errFindSecret, ref.Namespace, ref.Name, err)
  834. }
  835. keyBytes, ok := secret.Data[secretRef.Key]
  836. if !ok {
  837. return "", fmt.Errorf(errFindDataKey, secretRef.Key, secretRef.Name, namespace)
  838. }
  839. value := strings.TrimSpace(string(keyBytes))
  840. return value, nil
  841. }
  842. func (a *Azure) Close(ctx context.Context) error {
  843. return nil
  844. }
  845. func (a *Azure) Validate() (esv1beta1.ValidationResult, error) {
  846. if a.store.GetKind() == esv1beta1.ClusterSecretStoreKind && isReferentSpec(a.provider) {
  847. return esv1beta1.ValidationResultUnknown, nil
  848. }
  849. return esv1beta1.ValidationResultReady, nil
  850. }
  851. func isReferentSpec(prov *esv1beta1.AzureKVProvider) bool {
  852. if prov.AuthSecretRef != nil &&
  853. ((prov.AuthSecretRef.ClientID != nil &&
  854. prov.AuthSecretRef.ClientID.Namespace == nil) ||
  855. (prov.AuthSecretRef.ClientSecret != nil &&
  856. prov.AuthSecretRef.ClientSecret.Namespace == nil)) {
  857. return true
  858. }
  859. if prov.ServiceAccountRef != nil &&
  860. prov.ServiceAccountRef.Namespace == nil {
  861. return true
  862. }
  863. return false
  864. }
  865. func AadEndpointForType(t esv1beta1.AzureEnvironmentType) string {
  866. switch t {
  867. case esv1beta1.AzureEnvironmentPublicCloud:
  868. return azure.PublicCloud.ActiveDirectoryEndpoint
  869. case esv1beta1.AzureEnvironmentChinaCloud:
  870. return azure.ChinaCloud.ActiveDirectoryEndpoint
  871. case esv1beta1.AzureEnvironmentUSGovernmentCloud:
  872. return azure.USGovernmentCloud.ActiveDirectoryEndpoint
  873. case esv1beta1.AzureEnvironmentGermanCloud:
  874. return azure.GermanCloud.ActiveDirectoryEndpoint
  875. default:
  876. return azure.PublicCloud.ActiveDirectoryEndpoint
  877. }
  878. }
  879. func kvResourceForProviderConfig(t esv1beta1.AzureEnvironmentType) string {
  880. var res string
  881. switch t {
  882. case esv1beta1.AzureEnvironmentPublicCloud:
  883. res = azure.PublicCloud.KeyVaultEndpoint
  884. case esv1beta1.AzureEnvironmentChinaCloud:
  885. res = azure.ChinaCloud.KeyVaultEndpoint
  886. case esv1beta1.AzureEnvironmentUSGovernmentCloud:
  887. res = azure.USGovernmentCloud.KeyVaultEndpoint
  888. case esv1beta1.AzureEnvironmentGermanCloud:
  889. res = azure.GermanCloud.KeyVaultEndpoint
  890. default:
  891. res = azure.PublicCloud.KeyVaultEndpoint
  892. }
  893. return strings.TrimSuffix(res, "/")
  894. }
  895. func getObjType(ref esv1beta1.ExternalSecretDataRemoteRef) (string, string) {
  896. objectType := defaultObjType
  897. secretName := ref.Key
  898. nameSplitted := strings.Split(secretName, "/")
  899. if len(nameSplitted) > 1 {
  900. objectType = nameSplitted[0]
  901. secretName = nameSplitted[1]
  902. // TODO: later tokens can be used to read the secret tags
  903. }
  904. return objectType, secretName
  905. }
  906. func isValidSecret(checkTags, checkName bool, ref esv1beta1.ExternalSecretFind, secret keyvault.SecretItem) (bool, string) {
  907. if secret.ID == nil || !*secret.Attributes.Enabled {
  908. return false, ""
  909. }
  910. if checkTags && !okByTags(ref, secret) {
  911. return false, ""
  912. }
  913. secretName := path.Base(*secret.ID)
  914. if checkName && !okByName(ref, secretName) {
  915. return false, ""
  916. }
  917. return true, secretName
  918. }
  919. func okByName(ref esv1beta1.ExternalSecretFind, secretName string) bool {
  920. matches, _ := regexp.MatchString(ref.Name.RegExp, secretName)
  921. return matches
  922. }
  923. func okByTags(ref esv1beta1.ExternalSecretFind, secret keyvault.SecretItem) bool {
  924. tagsFound := true
  925. for k, v := range ref.Tags {
  926. if val, ok := secret.Tags[k]; !ok || *val != v {
  927. tagsFound = false
  928. break
  929. }
  930. }
  931. return tagsFound
  932. }