secretsmanager.go 23 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528529530531532533534535536537538539540541542543544545546547548549550551552553554555556557558559560561562563564565566567568569570571572573574575576577578579580581582583584585586587588589590591592593594595596597598599600601602603604605606607608609610611612613614615616617618619620621622623624625626627628629630631632633634635636637638639640641642643644645646647648649650651652653654655656657658659660661662663664665666667668669670671672673674675676677678679680681682683684685686687688689690691692693694695696697698699700701702703704705706707708709710711712713714715716717718719720721722723724725726727728729730731732733734735736737738739740741742743744745746747748749750751752753754755756757758759760761762763764765766767768769770771772773774775
  1. /*
  2. Licensed under the Apache License, Version 2.0 (the "License");
  3. you may not use this file except in compliance with the License.
  4. You may obtain a copy of the License at
  5. http://www.apache.org/licenses/LICENSE-2.0
  6. Unless required by applicable law or agreed to in writing, software
  7. distributed under the License is distributed on an "AS IS" BASIS,
  8. WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
  9. See the License for the specific language governing permissions and
  10. limitations under the License.
  11. */
  12. package secretsmanager
  13. import (
  14. "bytes"
  15. "context"
  16. "encoding/json"
  17. "errors"
  18. "fmt"
  19. "math/big"
  20. "slices"
  21. "strings"
  22. "github.com/aws/aws-sdk-go-v2/aws"
  23. awssm "github.com/aws/aws-sdk-go-v2/service/secretsmanager"
  24. "github.com/aws/aws-sdk-go-v2/service/secretsmanager/types"
  25. "github.com/aws/smithy-go"
  26. "github.com/google/uuid"
  27. "github.com/tidwall/gjson"
  28. "github.com/tidwall/sjson"
  29. corev1 "k8s.io/api/core/v1"
  30. apiextensionsv1 "k8s.io/apiextensions-apiserver/pkg/apis/apiextensions/v1"
  31. utilpointer "k8s.io/utils/ptr"
  32. ctrl "sigs.k8s.io/controller-runtime"
  33. esv1 "github.com/external-secrets/external-secrets/apis/externalsecrets/v1"
  34. "github.com/external-secrets/external-secrets/pkg/constants"
  35. "github.com/external-secrets/external-secrets/pkg/find"
  36. "github.com/external-secrets/external-secrets/pkg/metrics"
  37. "github.com/external-secrets/external-secrets/pkg/provider/aws/util"
  38. "github.com/external-secrets/external-secrets/pkg/utils"
  39. "github.com/external-secrets/external-secrets/pkg/utils/metadata"
  40. )
  41. type PushSecretMetadataSpec struct {
  42. Tags map[string]string `json:"tags,omitempty"`
  43. Description string `json:"description,omitempty"`
  44. SecretPushFormat string `json:"secretPushFormat,omitempty"`
  45. KMSKeyID string `json:"kmsKeyId,omitempty"`
  46. }
  47. // Declares metadata information for pushing secrets to AWS Secret Store.
  48. const (
  49. SecretPushFormatKey = "secretPushFormat"
  50. SecretPushFormatString = "string"
  51. SecretPushFormatBinary = "binary"
  52. ResourceNotFoundException = "ResourceNotFoundException"
  53. )
  54. // https://github.com/external-secrets/external-secrets/issues/644
  55. var _ esv1.SecretsClient = &SecretsManager{}
  56. // SecretsManager is a provider for AWS SecretsManager.
  57. type SecretsManager struct {
  58. cfg *aws.Config
  59. client SMInterface // Keep the interface
  60. referentAuth bool
  61. cache map[string]*awssm.GetSecretValueOutput
  62. config *esv1.SecretsManager
  63. prefix string
  64. }
  65. // SMInterface is a subset of the smiface api.
  66. // see: https://docs.aws.amazon.com/sdk-for-go/api/service/secretsmanager/secretsmanageriface/
  67. type SMInterface interface {
  68. BatchGetSecretValue(ctx context.Context, params *awssm.BatchGetSecretValueInput, optFuncs ...func(*awssm.Options)) (*awssm.BatchGetSecretValueOutput, error)
  69. ListSecrets(ctx context.Context, params *awssm.ListSecretsInput, optFuncs ...func(*awssm.Options)) (*awssm.ListSecretsOutput, error)
  70. GetSecretValue(ctx context.Context, params *awssm.GetSecretValueInput, optFuncs ...func(*awssm.Options)) (*awssm.GetSecretValueOutput, error)
  71. CreateSecret(ctx context.Context, params *awssm.CreateSecretInput, optFuncs ...func(*awssm.Options)) (*awssm.CreateSecretOutput, error)
  72. PutSecretValue(ctx context.Context, params *awssm.PutSecretValueInput, optFuncs ...func(*awssm.Options)) (*awssm.PutSecretValueOutput, error)
  73. DescribeSecret(ctx context.Context, params *awssm.DescribeSecretInput, optFuncs ...func(*awssm.Options)) (*awssm.DescribeSecretOutput, error)
  74. DeleteSecret(ctx context.Context, params *awssm.DeleteSecretInput, optFuncs ...func(*awssm.Options)) (*awssm.DeleteSecretOutput, error)
  75. TagResource(ctx context.Context, params *awssm.TagResourceInput, optFuncs ...func(*awssm.Options)) (*awssm.TagResourceOutput, error)
  76. UntagResource(ctx context.Context, params *awssm.UntagResourceInput, optFuncs ...func(*awssm.Options)) (*awssm.UntagResourceOutput, error)
  77. }
  78. const (
  79. errUnexpectedFindOperator = "unexpected find operator"
  80. managedBy = "managed-by"
  81. externalSecrets = "external-secrets"
  82. initialVersion = "00000000-0000-0000-0000-000000000001"
  83. )
  84. var log = ctrl.Log.WithName("provider").WithName("aws").WithName("secretsmanager")
  85. // New creates a new SecretsManager client.
  86. func New(_ context.Context, cfg *aws.Config, secretsManagerCfg *esv1.SecretsManager, prefix string, referentAuth bool) (*SecretsManager, error) {
  87. return &SecretsManager{
  88. cfg: cfg,
  89. client: awssm.NewFromConfig(*cfg, func(o *awssm.Options) {
  90. o.EndpointResolverV2 = customEndpointResolver{}
  91. }),
  92. referentAuth: referentAuth,
  93. cache: make(map[string]*awssm.GetSecretValueOutput),
  94. config: secretsManagerCfg,
  95. prefix: prefix,
  96. }, nil
  97. }
  98. func (sm *SecretsManager) fetch(ctx context.Context, ref esv1.ExternalSecretDataRemoteRef) (*awssm.GetSecretValueOutput, error) {
  99. ver := "AWSCURRENT"
  100. valueFrom := "SECRET"
  101. if ref.Version != "" {
  102. ver = ref.Version
  103. }
  104. if ref.MetadataPolicy == esv1.ExternalSecretMetadataPolicyFetch {
  105. valueFrom = "TAG"
  106. }
  107. key := sm.prefix + ref.Key
  108. log.Info("fetching secret value", "key", key, "version", ver, "value", valueFrom)
  109. cacheKey := fmt.Sprintf("%s#%s#%s", key, ver, valueFrom)
  110. if secretOut, found := sm.cache[cacheKey]; found {
  111. log.Info("found secret in cache", "key", key, "version", ver)
  112. return secretOut, nil
  113. }
  114. secretOut, err := sm.constructSecretValue(ctx, key, ver, ref.MetadataPolicy)
  115. if err != nil {
  116. return nil, err
  117. }
  118. sm.cache[cacheKey] = secretOut
  119. return secretOut, nil
  120. }
  121. func (sm *SecretsManager) DeleteSecret(ctx context.Context, remoteRef esv1.PushSecretRemoteRef) error {
  122. secretName := sm.prefix + remoteRef.GetRemoteKey()
  123. secretValue := awssm.GetSecretValueInput{
  124. SecretId: &secretName,
  125. }
  126. secretInput := awssm.DescribeSecretInput{
  127. SecretId: &secretName,
  128. }
  129. awsSecret, err := sm.client.GetSecretValue(ctx, &secretValue)
  130. metrics.ObserveAPICall(constants.ProviderAWSSM, constants.CallAWSSMGetSecretValue, err)
  131. var aerr smithy.APIError
  132. if err != nil {
  133. if ok := errors.As(err, &aerr); !ok {
  134. return err
  135. }
  136. if aerr.ErrorCode() == ResourceNotFoundException {
  137. return nil
  138. }
  139. return err
  140. }
  141. data, err := sm.client.DescribeSecret(ctx, &secretInput)
  142. metrics.ObserveAPICall(constants.ProviderAWSSM, constants.CallAWSSMDescribeSecret, err)
  143. if err != nil {
  144. return err
  145. }
  146. if !isManagedByESO(data) {
  147. return nil
  148. }
  149. deleteInput := &awssm.DeleteSecretInput{
  150. SecretId: awsSecret.ARN,
  151. }
  152. if sm.config != nil && sm.config.ForceDeleteWithoutRecovery {
  153. deleteInput.ForceDeleteWithoutRecovery = &sm.config.ForceDeleteWithoutRecovery
  154. }
  155. if sm.config != nil && sm.config.RecoveryWindowInDays > 0 {
  156. deleteInput.RecoveryWindowInDays = &sm.config.RecoveryWindowInDays
  157. }
  158. err = util.ValidateDeleteSecretInput(*deleteInput)
  159. if err != nil {
  160. return err
  161. }
  162. _, err = sm.client.DeleteSecret(ctx, deleteInput)
  163. metrics.ObserveAPICall(constants.ProviderAWSSM, constants.CallAWSSMDeleteSecret, err)
  164. return err
  165. }
  166. func (sm *SecretsManager) SecretExists(ctx context.Context, pushSecretRef esv1.PushSecretRemoteRef) (bool, error) {
  167. secretName := sm.prefix + pushSecretRef.GetRemoteKey()
  168. secretValue := awssm.GetSecretValueInput{
  169. SecretId: &secretName,
  170. }
  171. _, err := sm.client.GetSecretValue(ctx, &secretValue)
  172. if err != nil {
  173. return sm.handleSecretError(err)
  174. }
  175. return true, nil
  176. }
  177. func (sm *SecretsManager) handleSecretError(err error) (bool, error) {
  178. var aerr smithy.APIError
  179. if ok := errors.As(err, &aerr); !ok {
  180. return false, err
  181. }
  182. if aerr.ErrorCode() == ResourceNotFoundException {
  183. return false, nil
  184. }
  185. return false, err
  186. }
  187. func (sm *SecretsManager) PushSecret(ctx context.Context, secret *corev1.Secret, psd esv1.PushSecretData) error {
  188. value, err := utils.ExtractSecretData(psd, secret)
  189. if err != nil {
  190. return fmt.Errorf("failed to extract secret data: %w", err)
  191. }
  192. secretName := sm.prefix + psd.GetRemoteKey()
  193. secretValue := awssm.GetSecretValueInput{
  194. SecretId: &secretName,
  195. }
  196. secretInput := awssm.DescribeSecretInput{
  197. SecretId: &secretName,
  198. }
  199. awsSecret, err := sm.client.GetSecretValue(ctx, &secretValue)
  200. metrics.ObserveAPICall(constants.ProviderAWSSM, constants.CallAWSSMGetSecretValue, err)
  201. if psd.GetProperty() != "" {
  202. currentSecret := sm.retrievePayload(awsSecret)
  203. if currentSecret != "" && !gjson.Valid(currentSecret) {
  204. return errors.New("PushSecret for aws secrets manager with a pushSecretData property requires a json secret")
  205. }
  206. value, _ = sjson.SetBytes([]byte(currentSecret), psd.GetProperty(), value)
  207. }
  208. var aerr smithy.APIError
  209. if err != nil {
  210. if ok := errors.As(err, &aerr); !ok {
  211. return err
  212. }
  213. if aerr.ErrorCode() == ResourceNotFoundException {
  214. return sm.createSecretWithContext(ctx, secretName, psd, value)
  215. }
  216. return err
  217. }
  218. return sm.putSecretValueWithContext(ctx, secretInput, awsSecret, psd, value)
  219. }
  220. func padOrTrim(b []byte) []byte {
  221. l := len(b)
  222. size := 16
  223. if l == size {
  224. return b
  225. }
  226. if l > size {
  227. return b[l-size:]
  228. }
  229. tmp := make([]byte, size)
  230. copy(tmp[size-l:], b)
  231. return tmp
  232. }
  233. func bumpVersionNumber(id *string) (*string, error) {
  234. if id == nil {
  235. output := initialVersion
  236. return &output, nil
  237. }
  238. n := new(big.Int)
  239. oldVersion, ok := n.SetString(strings.ReplaceAll(*id, "-", ""), 16)
  240. if !ok {
  241. return nil, fmt.Errorf("expected secret version in AWS SSM to be a UUID but got '%s'", *id)
  242. }
  243. newVersionRaw := oldVersion.Add(oldVersion, big.NewInt(1)).Bytes()
  244. newVersion, err := uuid.FromBytes(padOrTrim(newVersionRaw))
  245. if err != nil {
  246. return nil, err
  247. }
  248. s := newVersion.String()
  249. return &s, nil
  250. }
  251. func isManagedByESO(data *awssm.DescribeSecretOutput) bool {
  252. managedBy := managedBy
  253. externalSecrets := externalSecrets
  254. for _, tag := range data.Tags {
  255. if *tag.Key == managedBy && *tag.Value == externalSecrets {
  256. return true
  257. }
  258. }
  259. return false
  260. }
  261. // GetAllSecrets syncs multiple secrets from aws provider into a single Kubernetes Secret.
  262. func (sm *SecretsManager) GetAllSecrets(ctx context.Context, ref esv1.ExternalSecretFind) (map[string][]byte, error) {
  263. if ref.Name != nil {
  264. return sm.findByName(ctx, ref)
  265. }
  266. if len(ref.Tags) > 0 {
  267. return sm.findByTags(ctx, ref)
  268. }
  269. return nil, errors.New(errUnexpectedFindOperator)
  270. }
  271. func (sm *SecretsManager) findByName(ctx context.Context, ref esv1.ExternalSecretFind) (map[string][]byte, error) {
  272. matcher, err := find.New(*ref.Name)
  273. if err != nil {
  274. return nil, err
  275. }
  276. filters := make([]types.Filter, 0)
  277. if ref.Path != nil {
  278. filters = append(filters, types.Filter{
  279. Key: types.FilterNameStringTypeName,
  280. Values: []string{
  281. *ref.Path,
  282. },
  283. })
  284. return sm.fetchWithBatch(ctx, filters, matcher)
  285. }
  286. data := make(map[string][]byte)
  287. var nextToken *string
  288. for {
  289. // I put this into the for loop on purpose.
  290. log.V(0).Info("using ListSecret to fetch all secrets; this is a costly operations, please use batching by defining a _path_")
  291. it, err := sm.client.ListSecrets(ctx, &awssm.ListSecretsInput{
  292. Filters: filters,
  293. NextToken: nextToken,
  294. })
  295. metrics.ObserveAPICall(constants.ProviderAWSSM, constants.CallAWSSMListSecrets, err)
  296. if err != nil {
  297. return nil, err
  298. }
  299. log.V(1).Info("aws sm findByName found", "secrets", len(it.SecretList))
  300. for _, secret := range it.SecretList {
  301. if !matcher.MatchName(*secret.Name) {
  302. continue
  303. }
  304. log.V(1).Info("aws sm findByName matches", "name", *secret.Name)
  305. if err := sm.fetchAndSet(ctx, data, *secret.Name); err != nil {
  306. return nil, err
  307. }
  308. }
  309. nextToken = it.NextToken
  310. if nextToken == nil {
  311. break
  312. }
  313. }
  314. return data, nil
  315. }
  316. func (sm *SecretsManager) findByTags(ctx context.Context, ref esv1.ExternalSecretFind) (map[string][]byte, error) {
  317. filters := make([]types.Filter, 0)
  318. for k, v := range ref.Tags {
  319. filters = append(filters, types.Filter{
  320. Key: types.FilterNameStringTypeTagKey,
  321. Values: []string{
  322. k,
  323. },
  324. }, types.Filter{
  325. Key: types.FilterNameStringTypeTagValue,
  326. Values: []string{
  327. v,
  328. },
  329. })
  330. }
  331. if ref.Path != nil {
  332. filters = append(filters, types.Filter{
  333. Key: types.FilterNameStringTypeName,
  334. Values: []string{
  335. *ref.Path,
  336. },
  337. })
  338. }
  339. return sm.fetchWithBatch(ctx, filters, nil)
  340. }
  341. func (sm *SecretsManager) fetchAndSet(ctx context.Context, data map[string][]byte, name string) error {
  342. sec, err := sm.fetch(ctx, esv1.ExternalSecretDataRemoteRef{
  343. Key: name,
  344. })
  345. if err != nil {
  346. return err
  347. }
  348. if sec.SecretString != nil {
  349. data[name] = []byte(*sec.SecretString)
  350. }
  351. if sec.SecretBinary != nil {
  352. data[name] = sec.SecretBinary
  353. }
  354. return nil
  355. }
  356. // GetSecret returns a single secret from the provider.
  357. func (sm *SecretsManager) GetSecret(ctx context.Context, ref esv1.ExternalSecretDataRemoteRef) ([]byte, error) {
  358. secretOut, err := sm.fetch(ctx, ref)
  359. if errors.Is(err, esv1.NoSecretErr) {
  360. return nil, err
  361. }
  362. if err != nil {
  363. return nil, util.SanitizeErr(err)
  364. }
  365. if ref.Property == "" {
  366. if secretOut.SecretString != nil {
  367. return []byte(*secretOut.SecretString), nil
  368. }
  369. if secretOut.SecretBinary != nil {
  370. return secretOut.SecretBinary, nil
  371. }
  372. return nil, fmt.Errorf("invalid secret received. no secret string nor binary for key: %s", ref.Key)
  373. }
  374. val := sm.mapSecretToGjson(secretOut, ref.Property)
  375. if !val.Exists() {
  376. return nil, fmt.Errorf("key %s does not exist in secret %s", ref.Property, ref.Key)
  377. }
  378. return []byte(val.String()), nil
  379. }
  380. func (sm *SecretsManager) mapSecretToGjson(secretOut *awssm.GetSecretValueOutput, property string) gjson.Result {
  381. payload := sm.retrievePayload(secretOut)
  382. refProperty := sm.escapeDotsIfRequired(property, payload)
  383. val := gjson.Get(payload, refProperty)
  384. return val
  385. }
  386. func (sm *SecretsManager) retrievePayload(secretOut *awssm.GetSecretValueOutput) string {
  387. if secretOut == nil {
  388. return ""
  389. }
  390. var payload string
  391. if secretOut.SecretString != nil {
  392. payload = *secretOut.SecretString
  393. }
  394. if secretOut.SecretBinary != nil {
  395. payload = string(secretOut.SecretBinary)
  396. }
  397. return payload
  398. }
  399. func (sm *SecretsManager) escapeDotsIfRequired(currentRefProperty, payload string) string {
  400. // We need to search if a given key with a . exists before using gjson operations.
  401. idx := strings.Index(currentRefProperty, ".")
  402. refProperty := currentRefProperty
  403. if idx > -1 {
  404. refProperty = strings.ReplaceAll(currentRefProperty, ".", "\\.")
  405. val := gjson.Get(payload, refProperty)
  406. if !val.Exists() {
  407. refProperty = currentRefProperty
  408. }
  409. }
  410. return refProperty
  411. }
  412. // GetSecretMap returns multiple k/v pairs from the provider.
  413. func (sm *SecretsManager) GetSecretMap(ctx context.Context, ref esv1.ExternalSecretDataRemoteRef) (map[string][]byte, error) {
  414. log.Info("fetching secret map", "key", ref.Key)
  415. data, err := sm.GetSecret(ctx, ref)
  416. if err != nil {
  417. return nil, err
  418. }
  419. kv := make(map[string]json.RawMessage)
  420. err = json.Unmarshal(data, &kv)
  421. if err != nil {
  422. return nil, fmt.Errorf("unable to unmarshal secret %s: %w", ref.Key, err)
  423. }
  424. secretData := make(map[string][]byte)
  425. for k, v := range kv {
  426. var strVal string
  427. err = json.Unmarshal(v, &strVal)
  428. if err == nil {
  429. secretData[k] = []byte(strVal)
  430. } else {
  431. secretData[k] = v
  432. }
  433. }
  434. return secretData, nil
  435. }
  436. func (sm *SecretsManager) Close(_ context.Context) error {
  437. return nil
  438. }
  439. func (sm *SecretsManager) Validate() (esv1.ValidationResult, error) {
  440. // skip validation stack because it depends on the namespace
  441. // of the ExternalSecret
  442. if sm.referentAuth {
  443. return esv1.ValidationResultUnknown, nil
  444. }
  445. _, err := sm.cfg.Credentials.Retrieve(context.Background())
  446. if err != nil {
  447. return esv1.ValidationResultError, util.SanitizeErr(err)
  448. }
  449. return esv1.ValidationResultReady, nil
  450. }
  451. func (sm *SecretsManager) Capabilities() esv1.SecretStoreCapabilities {
  452. return esv1.SecretStoreReadWrite
  453. }
  454. func (sm *SecretsManager) createSecretWithContext(ctx context.Context, secretName string, psd esv1.PushSecretData, value []byte) error {
  455. mdata, err := sm.constructMetadataWithDefaults(psd.GetMetadata())
  456. if err != nil {
  457. return fmt.Errorf("failed to parse push secret metadata: %w", err)
  458. }
  459. tags := make([]types.Tag, 0)
  460. for k, v := range mdata.Spec.Tags {
  461. tags = append(tags, types.Tag{
  462. Key: utilpointer.To(k),
  463. Value: utilpointer.To(v),
  464. })
  465. }
  466. input := &awssm.CreateSecretInput{
  467. Name: &secretName,
  468. SecretBinary: value,
  469. Tags: tags,
  470. Description: utilpointer.To(mdata.Spec.Description),
  471. ClientRequestToken: utilpointer.To(initialVersion),
  472. KmsKeyId: utilpointer.To(mdata.Spec.KMSKeyID),
  473. }
  474. if mdata.Spec.SecretPushFormat == SecretPushFormatString {
  475. input.SecretBinary = nil
  476. input.SecretString = aws.String(string(value))
  477. }
  478. _, err = sm.client.CreateSecret(ctx, input)
  479. metrics.ObserveAPICall(constants.ProviderAWSSM, constants.CallAWSSMCreateSecret, err)
  480. return err
  481. }
  482. func (sm *SecretsManager) putSecretValueWithContext(ctx context.Context, secretInput awssm.DescribeSecretInput, awsSecret *awssm.GetSecretValueOutput, psd esv1.PushSecretData, value []byte) error {
  483. data, err := sm.client.DescribeSecret(ctx, &secretInput)
  484. metrics.ObserveAPICall(constants.ProviderAWSSM, constants.CallAWSSMDescribeSecret, err)
  485. if err != nil {
  486. return err
  487. }
  488. if !isManagedByESO(data) {
  489. return errors.New("secret not managed by external-secrets")
  490. }
  491. if awsSecret != nil && bytes.Equal(awsSecret.SecretBinary, value) || utils.CompareStringAndByteSlices(awsSecret.SecretString, value) {
  492. return nil
  493. }
  494. newVersionNumber, err := bumpVersionNumber(awsSecret.VersionId)
  495. if err != nil {
  496. return err
  497. }
  498. input := &awssm.PutSecretValueInput{
  499. SecretId: awsSecret.ARN,
  500. SecretBinary: value,
  501. ClientRequestToken: newVersionNumber,
  502. }
  503. secretPushFormat, err := utils.FetchValueFromMetadata(SecretPushFormatKey, psd.GetMetadata(), SecretPushFormatBinary)
  504. if err != nil {
  505. return fmt.Errorf("failed to parse metadata: %w", err)
  506. }
  507. if secretPushFormat == SecretPushFormatString {
  508. input.SecretBinary = nil
  509. input.SecretString = aws.String(string(value))
  510. }
  511. _, err = sm.client.PutSecretValue(ctx, input)
  512. metrics.ObserveAPICall(constants.ProviderAWSSM, constants.CallAWSSMPutSecretValue, err)
  513. if err != nil {
  514. return err
  515. }
  516. currentTags := make(map[string]string, len(data.Tags))
  517. for _, tag := range data.Tags {
  518. currentTags[*tag.Key] = *tag.Value
  519. }
  520. return sm.patchTags(ctx, psd.GetMetadata(), awsSecret.ARN, currentTags)
  521. }
  522. func (sm *SecretsManager) patchTags(ctx context.Context, metadata *apiextensionsv1.JSON, secretId *string, tags map[string]string) error {
  523. meta, err := sm.constructMetadataWithDefaults(metadata)
  524. if err != nil {
  525. return err
  526. }
  527. tagKeysToRemove := util.FindTagKeysToRemove(tags, meta.Spec.Tags)
  528. if len(tagKeysToRemove) > 0 {
  529. _, err = sm.client.UntagResource(ctx, &awssm.UntagResourceInput{
  530. SecretId: secretId,
  531. TagKeys: tagKeysToRemove,
  532. })
  533. metrics.ObserveAPICall(constants.ProviderAWSSM, constants.CallAWSSMUntagResource, err)
  534. if err != nil {
  535. return err
  536. }
  537. }
  538. tagsToUpdate, isModified := computeTagsToUpdate(tags, meta.Spec.Tags)
  539. if isModified {
  540. _, err = sm.client.TagResource(ctx, &awssm.TagResourceInput{
  541. SecretId: secretId,
  542. Tags: tagsToUpdate,
  543. })
  544. metrics.ObserveAPICall(constants.ProviderAWSSM, constants.CallAWSSMTagResource, err)
  545. if err != nil {
  546. return err
  547. }
  548. }
  549. return nil
  550. }
  551. func (sm *SecretsManager) fetchWithBatch(ctx context.Context, filters []types.Filter, matcher *find.Matcher) (map[string][]byte, error) {
  552. data := make(map[string][]byte)
  553. var nextToken *string
  554. for {
  555. it, err := sm.client.BatchGetSecretValue(ctx, &awssm.BatchGetSecretValueInput{
  556. Filters: filters,
  557. NextToken: nextToken,
  558. })
  559. metrics.ObserveAPICall(constants.ProviderAWSSM, constants.CallAWSSMBatchGetSecretValue, err)
  560. if err != nil {
  561. return nil, err
  562. }
  563. log.V(1).Info("aws sm findByName found", "secrets", len(it.SecretValues))
  564. for _, secret := range it.SecretValues {
  565. if matcher != nil && !matcher.MatchName(*secret.Name) {
  566. continue
  567. }
  568. log.V(1).Info("aws sm findByName matches", "name", *secret.Name)
  569. sm.setSecretValues(&secret, data)
  570. }
  571. nextToken = it.NextToken
  572. if nextToken == nil {
  573. break
  574. }
  575. }
  576. return data, nil
  577. }
  578. func (sm *SecretsManager) setSecretValues(secret *types.SecretValueEntry, data map[string][]byte) {
  579. if secret.SecretString != nil {
  580. data[*secret.Name] = []byte(*secret.SecretString)
  581. }
  582. if secret.SecretBinary != nil {
  583. data[*secret.Name] = secret.SecretBinary
  584. }
  585. }
  586. func (sm *SecretsManager) constructSecretValue(ctx context.Context, key, ver string, metadataPolicy esv1.ExternalSecretMetadataPolicy) (*awssm.GetSecretValueOutput, error) {
  587. if metadataPolicy == esv1.ExternalSecretMetadataPolicyFetch {
  588. describeSecretInput := &awssm.DescribeSecretInput{
  589. SecretId: &key,
  590. }
  591. descOutput, err := sm.client.DescribeSecret(ctx, describeSecretInput)
  592. if err != nil {
  593. return nil, err
  594. }
  595. log.Info("found metadata secret", "key", key, "output", descOutput)
  596. jsonTags, err := util.SecretTagsToJSONString(descOutput.Tags)
  597. if err != nil {
  598. return nil, err
  599. }
  600. return &awssm.GetSecretValueOutput{
  601. ARN: descOutput.ARN,
  602. CreatedDate: descOutput.CreatedDate,
  603. Name: descOutput.Name,
  604. SecretString: &jsonTags,
  605. VersionId: &ver,
  606. }, nil
  607. }
  608. var getSecretValueInput *awssm.GetSecretValueInput
  609. if strings.HasPrefix(ver, "uuid/") {
  610. versionID := strings.TrimPrefix(ver, "uuid/")
  611. getSecretValueInput = &awssm.GetSecretValueInput{
  612. SecretId: &key,
  613. VersionId: &versionID,
  614. }
  615. } else {
  616. getSecretValueInput = &awssm.GetSecretValueInput{
  617. SecretId: &key,
  618. VersionStage: &ver,
  619. }
  620. }
  621. secretOut, err := sm.client.GetSecretValue(ctx, getSecretValueInput)
  622. metrics.ObserveAPICall(constants.ProviderAWSSM, constants.CallAWSSMGetSecretValue, err)
  623. var (
  624. nf *types.ResourceNotFoundException
  625. ie *types.InvalidParameterException
  626. )
  627. if errors.As(err, &nf) {
  628. return nil, esv1.NoSecretErr
  629. }
  630. if errors.As(err, &ie) && strings.Contains(ie.Error(), "was marked for deletion") {
  631. return nil, esv1.NoSecretErr
  632. }
  633. return secretOut, err
  634. }
  635. func (sm *SecretsManager) constructMetadataWithDefaults(data *apiextensionsv1.JSON) (*metadata.PushSecretMetadata[PushSecretMetadataSpec], error) {
  636. var (
  637. meta *metadata.PushSecretMetadata[PushSecretMetadataSpec]
  638. err error
  639. )
  640. meta, err = metadata.ParseMetadataParameters[PushSecretMetadataSpec](data)
  641. if err != nil {
  642. return nil, fmt.Errorf("failed to parse metadata: %w", err)
  643. }
  644. if meta == nil {
  645. meta = &metadata.PushSecretMetadata[PushSecretMetadataSpec]{}
  646. }
  647. if meta.Spec.SecretPushFormat == "" {
  648. meta.Spec.SecretPushFormat = SecretPushFormatBinary
  649. } else if !slices.Contains([]string{SecretPushFormatBinary, SecretPushFormatString}, meta.Spec.SecretPushFormat) {
  650. return nil, fmt.Errorf("invalid secret push format: %s", meta.Spec.SecretPushFormat)
  651. }
  652. if meta.Spec.Description == "" {
  653. meta.Spec.Description = fmt.Sprintf("secret '%s:%s'", managedBy, externalSecrets)
  654. }
  655. if meta.Spec.KMSKeyID == "" {
  656. meta.Spec.KMSKeyID = "alias/aws/secretsmanager"
  657. }
  658. if len(meta.Spec.Tags) > 0 {
  659. if _, exists := meta.Spec.Tags[managedBy]; exists {
  660. return nil, fmt.Errorf("error parsing tags in metadata: Cannot specify a '%s' tag", managedBy)
  661. }
  662. } else {
  663. meta.Spec.Tags = make(map[string]string)
  664. }
  665. meta.Spec.Tags[managedBy] = externalSecrets
  666. return meta, nil
  667. }
  668. // computeTagsToUpdate compares the current tags with the desired metaTags and returns a slice of ssmTypes.Tag
  669. // that should be set on the resource. It also returns a boolean indicating if any tag was added or modified.
  670. func computeTagsToUpdate(tags, metaTags map[string]string) ([]types.Tag, bool) {
  671. result := make([]types.Tag, 0, len(metaTags))
  672. modified := false
  673. for k, v := range metaTags {
  674. if _, exists := tags[k]; !exists || tags[k] != v {
  675. if k != managedBy {
  676. modified = true
  677. }
  678. }
  679. result = append(result, types.Tag{
  680. Key: utilpointer.To(k),
  681. Value: utilpointer.To(v),
  682. })
  683. }
  684. return result, modified
  685. }