| 1234567891011121314151617181920212223242526272829303132333435363738394041424344454647484950515253545556575859606162636465666768697071727374757677787980818283848586878889909192939495969798991001011021031041051061071081091101111121131141151161171181191201211221231241251261271281291301311321331341351361371381391401411421431441451461471481491501511521531541551561571581591601611621631641651661671681691701711721731741751761771781791801811821831841851861871881891901911921931941951961971981992002012022032042052062072082092102112122132142152162172182192202212222232242252262272282292302312322332342352362372382392402412422432442452462472482492502512522532542552562572582592602612622632642652662672682692702712722732742752762772782792802812822832842852862872882892902912922932942952962972982993003013023033043053063073083093103113123133143153163173183193203213223233243253263273283293303313323333343353363373383393403413423433443453463473483493503513523533543553563573583593603613623633643653663673683693703713723733743753763773783793803813823833843853863873883893903913923933943953963973983994004014024034044054064074084094104114124134144154164174184194204214224234244254264274284294304314324334344354364374384394404414424434444454464474484494504514524534544554564574584594604614624634644654664674684694704714724734744754764774784794804814824834844854864874884894904914924934944954964974984995005015025035045055065075085095105115125135145155165175185195205215225235245255265275285295305315325335345355365375385395405415425435445455465475485495505515525535545555565575585595605615625635645655665675685695705715725735745755765775785795805815825835845855865875885895905915925935945955965975985996006016026036046056066076086096106116126136146156166176186196206216226236246256266276286296306316326336346356366376386396406416426436446456466476486496506516526536546556566576586596606616626636646656666676686696706716726736746756766776786796806816826836846856866876886896906916926936946956966976986997007017027037047057067077087097107117127137147157167177187197207217227237247257267277287297307317327337347357367377387397407417427437447457467477487497507517527537547557567577587597607617627637647657667677687697707717727737747757767777787797807817827837847857867877887897907917927937947957967977987998008018028038048058068078088098108118128138148158168178188198208218228238248258268278288298308318328338348358368378388398408418428438448458468478488498508518528538548558568578588598608618628638648658668678688698708718728738748758768778788798808818828838848858868878888898908918928938948958968978988999009019029039049059069079089099109119129139149159169179189199209219229239249259269279289299309319329339349359369379389399409419429439449459469479489499509519529539549559569579589599609619629639649659669679689699709719729739749759769779789799809819829839849859869879889899909919929939949959969979989991000100110021003100410051006100710081009101010111012101310141015101610171018101910201021102210231024102510261027102810291030103110321033103410351036103710381039104010411042104310441045104610471048104910501051105210531054105510561057105810591060106110621063106410651066106710681069107010711072107310741075 |
- /*
- Licensed under the Apache License, Version 2.0 (the "License");
- you may not use this file except in compliance with the License.
- You may obtain a copy of the License at
- http://www.apache.org/licenses/LICENSE-2.0
- Unless required by applicable law or agreed to in writing, software
- distributed under the License is distributed on an "AS IS" BASIS,
- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- See the License for the specific language governing permissions and
- limitations under the License.
- */
- package bitwarden
- import (
- "context"
- "reflect"
- "testing"
- "github.com/stretchr/testify/assert"
- corev1 "k8s.io/api/core/v1"
- "sigs.k8s.io/controller-runtime/pkg/client"
- "sigs.k8s.io/controller-runtime/pkg/client/fake"
- esv1 "github.com/external-secrets/external-secrets/apis/externalsecrets/v1"
- "github.com/external-secrets/external-secrets/apis/externalsecrets/v1alpha1"
- )
- const (
- remoteID = "d8f29773-3019-4973-9bbc-66327d077fe2"
- testKey = "this-is-a-name"
- )
- var projectID = "e8fc8f9c-2208-446e-9e89-9bc358f39b47"
- func TestProviderDeleteSecret(t *testing.T) {
- type fields struct {
- kube client.Client
- namespace string
- store esv1.GenericStore
- mock func(c *FakeClient)
- assertMock func(t *testing.T, c *FakeClient)
- }
- type args struct {
- ctx context.Context
- ref esv1.PushSecretRemoteRef
- }
- tests := []struct {
- name string
- fields fields
- args args
- wantErr bool
- }{
- {
- name: "delete secret is successfully with UUID",
- fields: fields{
- namespace: "default",
- store: &esv1.SecretStore{
- Spec: esv1.SecretStoreSpec{
- Provider: &esv1.SecretStoreProvider{
- BitwardenSecretsManager: &esv1.BitwardenSecretsManagerProvider{
- OrganizationID: "orgid",
- ProjectID: projectID,
- },
- },
- },
- },
- mock: func(c *FakeClient) {
- c.DeleteSecretReturnsOnCallN(0, &SecretsDeleteResponse{})
- },
- assertMock: func(t *testing.T, c *FakeClient) {
- assert.Equal(t, 1, c.deleteSecretCalledN)
- },
- },
- args: args{
- ctx: context.TODO(),
- ref: v1alpha1.PushSecretRemoteRef{
- RemoteKey: remoteID,
- },
- },
- },
- {
- name: "delete secret by name",
- fields: fields{
- namespace: "default",
- store: &esv1.SecretStore{
- Spec: esv1.SecretStoreSpec{
- Provider: &esv1.SecretStoreProvider{
- BitwardenSecretsManager: &esv1.BitwardenSecretsManagerProvider{
- OrganizationID: "orgid",
- ProjectID: projectID,
- },
- },
- },
- },
- mock: func(c *FakeClient) {
- c.ListSecretReturnsOnCallN(0, &SecretIdentifiersResponse{
- Data: []SecretIdentifierResponse{
- {
- ID: remoteID,
- Key: testKey,
- OrganizationID: "orgid",
- },
- },
- })
- c.GetSecretReturnsOnCallN(0, &SecretResponse{
- ID: remoteID,
- Key: "key",
- Note: "note",
- OrganizationID: "org",
- Value: "value",
- ProjectID: &projectID,
- })
- c.DeleteSecretReturnsOnCallN(0, &SecretsDeleteResponse{})
- },
- assertMock: func(t *testing.T, c *FakeClient) {
- assert.Equal(t, 1, c.deleteSecretCalledN)
- },
- },
- args: args{
- ctx: context.TODO(),
- ref: v1alpha1.PushSecretRemoteRef{
- RemoteKey: remoteID,
- },
- },
- },
- {
- name: "delete secret by name will not delete if something doesn't match",
- fields: fields{
- namespace: "default",
- store: &esv1.SecretStore{
- Spec: esv1.SecretStoreSpec{
- Provider: &esv1.SecretStoreProvider{
- BitwardenSecretsManager: &esv1.BitwardenSecretsManagerProvider{
- OrganizationID: "orgid",
- ProjectID: projectID,
- },
- },
- },
- },
- mock: func(c *FakeClient) {
- c.ListSecretReturnsOnCallN(0, &SecretIdentifiersResponse{
- Data: []SecretIdentifierResponse{
- {
- ID: remoteID,
- Key: testKey,
- OrganizationID: "orgid",
- },
- },
- })
- projectID := "another-project"
- c.GetSecretReturnsOnCallN(0, &SecretResponse{
- ID: remoteID,
- Key: testKey,
- Note: "note",
- OrganizationID: "orgid",
- Value: "value",
- ProjectID: &projectID,
- })
- },
- assertMock: func(t *testing.T, c *FakeClient) {
- assert.Equal(t, 0, c.deleteSecretCalledN)
- },
- },
- wantErr: true, // no secret found
- args: args{
- ctx: context.TODO(),
- ref: v1alpha1.PushSecretRemoteRef{
- RemoteKey: testKey,
- },
- },
- },
- }
- for _, tt := range tests {
- t.Run(tt.name, func(t *testing.T) {
- fakeClient := &FakeClient{}
- tt.fields.mock(fakeClient)
- p := &Provider{
- kube: tt.fields.kube,
- namespace: tt.fields.namespace,
- store: tt.fields.store,
- bitwardenSdkClient: fakeClient,
- }
- if err := p.DeleteSecret(tt.args.ctx, tt.args.ref); (err != nil) != tt.wantErr {
- t.Errorf("DeleteSecret() error = %v, wantErr %v", err, tt.wantErr)
- }
- tt.fields.assertMock(t, fakeClient)
- })
- }
- }
- func TestProviderGetAllSecrets(t *testing.T) {
- type fields struct {
- kube client.Client
- namespace string
- store esv1.GenericStore
- mock func(c *FakeClient)
- }
- type args struct {
- ctx context.Context
- ref esv1.ExternalSecretFind
- }
- tests := []struct {
- name string
- fields fields
- args args
- want map[string][]byte
- wantErr bool
- }{
- {
- name: "get all secrets",
- fields: fields{
- namespace: "default",
- store: &esv1.SecretStore{
- Spec: esv1.SecretStoreSpec{
- Provider: &esv1.SecretStoreProvider{
- BitwardenSecretsManager: &esv1.BitwardenSecretsManagerProvider{
- OrganizationID: "orgid",
- ProjectID: projectID,
- },
- },
- },
- },
- mock: func(c *FakeClient) {
- c.ListSecretReturnsOnCallN(0, &SecretIdentifiersResponse{
- Data: []SecretIdentifierResponse{
- {
- ID: remoteID,
- Key: "key1",
- OrganizationID: "orgid",
- },
- {
- ID: "7c0d21ec-10d9-4972-bdf8-ec52df99cc86",
- Key: "key2",
- OrganizationID: "orgid",
- },
- },
- })
- c.GetSecretReturnsOnCallN(0, &SecretResponse{
- ID: remoteID,
- Key: "key1",
- Value: "value1",
- })
- c.GetSecretReturnsOnCallN(1, &SecretResponse{
- ID: "7c0d21ec-10d9-4972-bdf8-ec52df99cc86",
- Key: "key2",
- Value: "value2",
- })
- },
- },
- args: args{
- ctx: context.TODO(),
- ref: esv1.ExternalSecretFind{},
- },
- want: map[string][]byte{
- remoteID: []byte("value1"),
- "7c0d21ec-10d9-4972-bdf8-ec52df99cc86": []byte("value2"),
- },
- },
- }
- for _, tt := range tests {
- t.Run(tt.name, func(t *testing.T) {
- fakeClient := &FakeClient{}
- tt.fields.mock(fakeClient)
- p := &Provider{
- kube: tt.fields.kube,
- namespace: tt.fields.namespace,
- store: tt.fields.store,
- bitwardenSdkClient: fakeClient,
- }
- got, err := p.GetAllSecrets(tt.args.ctx, tt.args.ref)
- if (err != nil) != tt.wantErr {
- t.Errorf("GetAllSecrets() error = %v, wantErr %v", err, tt.wantErr)
- return
- }
- if !reflect.DeepEqual(got, tt.want) {
- t.Errorf("GetAllSecrets() got = %v, want %v", got, tt.want)
- }
- })
- }
- }
- func TestProviderGetSecret(t *testing.T) {
- type fields struct {
- kube func() client.Client
- namespace string
- store esv1.GenericStore
- mock func(c *FakeClient)
- }
- type args struct {
- ctx context.Context
- ref esv1.ExternalSecretDataRemoteRef
- }
- tests := []struct {
- name string
- fields fields
- args args
- want []byte
- wantErr bool
- }{
- {
- name: "get secret with UUID",
- fields: fields{
- kube: func() client.Client {
- return fake.NewFakeClient()
- },
- namespace: "default",
- store: &esv1.SecretStore{},
- mock: func(c *FakeClient) {
- c.GetSecretReturnsOnCallN(0, &SecretResponse{
- ID: "id",
- Key: "key",
- Note: "note",
- OrganizationID: "org",
- Value: "value",
- })
- },
- },
- args: args{
- ctx: context.Background(),
- ref: esv1.ExternalSecretDataRemoteRef{
- Key: remoteID,
- },
- },
- want: []byte("value"),
- },
- {
- name: "get secret by name",
- fields: fields{
- kube: func() client.Client {
- return fake.NewFakeClient()
- },
- namespace: "default",
- store: &esv1.SecretStore{
- Spec: esv1.SecretStoreSpec{
- Provider: &esv1.SecretStoreProvider{
- BitwardenSecretsManager: &esv1.BitwardenSecretsManagerProvider{
- OrganizationID: "orgid",
- ProjectID: projectID,
- },
- },
- },
- },
- mock: func(c *FakeClient) {
- c.ListSecretReturnsOnCallN(0, &SecretIdentifiersResponse{
- Data: []SecretIdentifierResponse{
- {
- ID: remoteID,
- Key: testKey,
- OrganizationID: "orgid",
- },
- },
- })
- c.GetSecretReturnsOnCallN(0, &SecretResponse{
- ID: remoteID,
- Key: "key",
- Note: "note",
- OrganizationID: "org",
- Value: "value",
- ProjectID: &projectID,
- })
- },
- },
- args: args{
- ctx: context.Background(),
- ref: esv1.ExternalSecretDataRemoteRef{
- Key: testKey,
- },
- },
- want: []byte("value"),
- },
- }
- for _, tt := range tests {
- t.Run(tt.name, func(t *testing.T) {
- fakeClient := &FakeClient{}
- tt.fields.mock(fakeClient)
- p := &Provider{
- kube: tt.fields.kube(),
- namespace: tt.fields.namespace,
- store: tt.fields.store,
- bitwardenSdkClient: fakeClient,
- }
- got, err := p.GetSecret(tt.args.ctx, tt.args.ref)
- if (err != nil) != tt.wantErr {
- t.Errorf("GetSecret() error = %v, wantErr %v", err, tt.wantErr)
- return
- }
- if !reflect.DeepEqual(got, tt.want) {
- t.Errorf("GetSecret() got = %v, want %v", got, tt.want)
- }
- })
- }
- }
- func TestProviderPushSecret(t *testing.T) {
- type fields struct {
- kube func() client.Client
- namespace string
- store esv1.GenericStore
- mock func(c *FakeClient)
- assertMock func(t *testing.T, c *FakeClient)
- }
- type args struct {
- ctx context.Context
- secret *corev1.Secret
- data esv1.PushSecretData
- }
- tests := []struct {
- name string
- fields fields
- args args
- wantErr bool
- }{
- {
- name: "push secret is successful for a none existent remote secret",
- args: args{
- ctx: context.Background(),
- secret: &corev1.Secret{
- Data: map[string][]byte{
- "key": []byte("value"),
- },
- },
- data: v1alpha1.PushSecretData{
- Match: v1alpha1.PushSecretMatch{
- SecretKey: "key",
- RemoteRef: v1alpha1.PushSecretRemoteRef{
- RemoteKey: testKey,
- },
- },
- },
- },
- fields: fields{
- kube: func() client.Client {
- return fake.NewFakeClient()
- },
- namespace: "default",
- store: &esv1.SecretStore{
- Spec: esv1.SecretStoreSpec{
- Provider: &esv1.SecretStoreProvider{
- BitwardenSecretsManager: &esv1.BitwardenSecretsManagerProvider{
- OrganizationID: "orgid",
- ProjectID: projectID,
- },
- },
- },
- },
- mock: func(c *FakeClient) {
- c.ListSecretReturnsOnCallN(0, &SecretIdentifiersResponse{
- Data: []SecretIdentifierResponse{
- {
- ID: remoteID,
- Key: testKey,
- OrganizationID: "orgid",
- },
- },
- })
- c.GetSecretReturnsOnCallN(0, &SecretResponse{
- ID: remoteID,
- Key: "no-match", // if this is this-is-a-name it would match
- Note: "",
- OrganizationID: "orgid",
- Value: "value",
- ProjectID: &projectID,
- })
- c.CreateSecretReturnsOnCallN(0, &SecretResponse{})
- },
- assertMock: func(t *testing.T, c *FakeClient) {
- cargs := c.createSecretCallArguments[0]
- assert.Equal(t, cargs, SecretCreateRequest{
- Key: testKey,
- Note: "",
- OrganizationID: "orgid",
- ProjectIDS: []string{projectID},
- Value: "value",
- })
- },
- },
- },
- {
- name: "push entire secret succeeds",
- args: args{
- ctx: context.Background(),
- secret: &corev1.Secret{
- Data: map[string][]byte{
- "key": []byte("value"),
- },
- },
- data: v1alpha1.PushSecretData{
- Match: v1alpha1.PushSecretMatch{
- RemoteRef: v1alpha1.PushSecretRemoteRef{
- RemoteKey: testKey,
- },
- },
- },
- },
- fields: fields{
- kube: func() client.Client {
- return fake.NewFakeClient()
- },
- namespace: "default",
- store: &esv1.SecretStore{
- Spec: esv1.SecretStoreSpec{
- Provider: &esv1.SecretStoreProvider{
- BitwardenSecretsManager: &esv1.BitwardenSecretsManagerProvider{
- OrganizationID: "orgid",
- ProjectID: projectID,
- },
- },
- },
- },
- mock: func(c *FakeClient) {
- c.ListSecretReturnsOnCallN(0, &SecretIdentifiersResponse{
- Data: []SecretIdentifierResponse{
- {
- ID: remoteID,
- Key: testKey,
- OrganizationID: "orgid",
- },
- },
- })
- c.GetSecretReturnsOnCallN(0, &SecretResponse{
- ID: remoteID,
- Key: "no-match", // if this is this-is-a-name it would match
- Note: "",
- OrganizationID: "orgid",
- Value: "value",
- ProjectID: &projectID,
- })
- c.CreateSecretReturnsOnCallN(0, &SecretResponse{})
- },
- assertMock: func(t *testing.T, c *FakeClient) {
- cargs := c.createSecretCallArguments[0]
- assert.Equal(t, SecretCreateRequest{
- Key: testKey,
- Note: "",
- OrganizationID: "orgid",
- ProjectIDS: []string{projectID},
- Value: `{"key":"value"}`,
- }, cargs)
- },
- },
- },
- {
- name: "push secret is successful for an existing remote secret but only the value differs will call update",
- args: args{
- ctx: context.Background(),
- secret: &corev1.Secret{
- Data: map[string][]byte{
- "key": []byte("new-value"),
- },
- },
- data: v1alpha1.PushSecretData{
- Match: v1alpha1.PushSecretMatch{
- SecretKey: "key",
- RemoteRef: v1alpha1.PushSecretRemoteRef{
- RemoteKey: testKey,
- },
- },
- },
- },
- fields: fields{
- kube: func() client.Client {
- return fake.NewFakeClient()
- },
- namespace: "default",
- store: &esv1.SecretStore{
- Spec: esv1.SecretStoreSpec{
- Provider: &esv1.SecretStoreProvider{
- BitwardenSecretsManager: &esv1.BitwardenSecretsManagerProvider{
- OrganizationID: "orgid",
- ProjectID: projectID,
- },
- },
- },
- },
- mock: func(c *FakeClient) {
- c.ListSecretReturnsOnCallN(0, &SecretIdentifiersResponse{
- Data: []SecretIdentifierResponse{
- {
- ID: remoteID,
- Key: testKey,
- OrganizationID: "orgid",
- },
- },
- })
- c.GetSecretReturnsOnCallN(0, &SecretResponse{
- ID: remoteID,
- Key: testKey,
- Note: "",
- OrganizationID: "orgid",
- Value: "value",
- ProjectID: &projectID,
- })
- c.UpdateSecretReturnsOnCallN(0, &SecretResponse{})
- },
- assertMock: func(t *testing.T, c *FakeClient) {
- pargs := c.updateSecretCallArguments[0]
- assert.Equal(t, pargs, SecretPutRequest{
- ID: remoteID,
- Key: testKey,
- Note: "",
- OrganizationID: "orgid",
- ProjectIDS: []string{projectID},
- Value: "new-value",
- })
- },
- },
- },
- {
- name: "push secret will not push if the same secret already exists",
- args: args{
- ctx: context.Background(),
- secret: &corev1.Secret{
- Data: map[string][]byte{
- "key": []byte("value"),
- },
- },
- data: v1alpha1.PushSecretData{
- Match: v1alpha1.PushSecretMatch{
- SecretKey: "key",
- RemoteRef: v1alpha1.PushSecretRemoteRef{
- RemoteKey: testKey,
- },
- },
- },
- },
- fields: fields{
- kube: func() client.Client {
- return fake.NewFakeClient()
- },
- namespace: "default",
- store: &esv1.SecretStore{
- Spec: esv1.SecretStoreSpec{
- Provider: &esv1.SecretStoreProvider{
- BitwardenSecretsManager: &esv1.BitwardenSecretsManagerProvider{
- OrganizationID: "orgid",
- ProjectID: projectID,
- },
- },
- },
- },
- mock: func(c *FakeClient) {
- c.ListSecretReturnsOnCallN(0, &SecretIdentifiersResponse{
- Data: []SecretIdentifierResponse{
- {
- ID: remoteID,
- Key: testKey,
- OrganizationID: "orgid",
- },
- },
- })
- c.GetSecretReturnsOnCallN(0, &SecretResponse{
- ID: remoteID,
- Key: testKey,
- OrganizationID: "orgid",
- Value: "value",
- ProjectID: &projectID,
- })
- c.UpdateSecretReturnsOnCallN(0, &SecretResponse{})
- },
- assertMock: func(t *testing.T, c *FakeClient) {
- assert.Equal(t, 0, c.createSecretCalledN)
- assert.Equal(t, 0, c.updateSecretCalledN)
- },
- },
- },
- }
- for _, tt := range tests {
- t.Run(tt.name, func(t *testing.T) {
- fakeClient := &FakeClient{}
- tt.fields.mock(fakeClient)
- p := &Provider{
- kube: tt.fields.kube(),
- namespace: tt.fields.namespace,
- store: tt.fields.store,
- bitwardenSdkClient: fakeClient,
- }
- if err := p.PushSecret(tt.args.ctx, tt.args.secret, tt.args.data); (err != nil) != tt.wantErr {
- t.Errorf("PushSecret() error = %v, wantErr %v", err, tt.wantErr)
- }
- tt.fields.assertMock(t, fakeClient)
- })
- }
- }
- func TestProviderSecretExists(t *testing.T) {
- type fields struct {
- kube client.Client
- namespace string
- store esv1.GenericStore
- mock func(c *FakeClient)
- assertMock func(t *testing.T, c *FakeClient)
- }
- type args struct {
- ctx context.Context
- ref v1alpha1.PushSecretData
- }
- tests := []struct {
- name string
- fields fields
- args args
- want bool
- wantErr bool
- }{
- {
- name: "secret exists",
- fields: fields{
- store: &esv1.SecretStore{
- Spec: esv1.SecretStoreSpec{
- Provider: &esv1.SecretStoreProvider{
- BitwardenSecretsManager: &esv1.BitwardenSecretsManagerProvider{
- OrganizationID: "orgid",
- ProjectID: projectID,
- },
- },
- },
- },
- mock: func(c *FakeClient) {
- c.GetSecretReturnsOnCallN(0, &SecretResponse{})
- },
- assertMock: func(t *testing.T, c *FakeClient) {
- assert.Equal(t, 0, c.listSecretsCalledN)
- },
- },
- args: args{
- ctx: nil,
- ref: v1alpha1.PushSecretData{
- Match: v1alpha1.PushSecretMatch{
- RemoteRef: v1alpha1.PushSecretRemoteRef{
- RemoteKey: remoteID,
- },
- },
- },
- },
- want: true,
- },
- {
- name: "secret exists by name",
- fields: fields{
- store: &esv1.SecretStore{
- Spec: esv1.SecretStoreSpec{
- Provider: &esv1.SecretStoreProvider{
- BitwardenSecretsManager: &esv1.BitwardenSecretsManagerProvider{
- OrganizationID: "orgid",
- ProjectID: projectID,
- },
- },
- },
- },
- mock: func(c *FakeClient) {
- c.ListSecretReturnsOnCallN(0, &SecretIdentifiersResponse{
- Data: []SecretIdentifierResponse{
- {
- ID: remoteID,
- Key: "name",
- OrganizationID: "orgid",
- },
- },
- })
- c.GetSecretReturnsOnCallN(0, &SecretResponse{
- ID: remoteID,
- Key: "name",
- OrganizationID: "orgid",
- Value: "value",
- ProjectID: &projectID,
- })
- },
- },
- args: args{
- ctx: nil,
- ref: v1alpha1.PushSecretData{
- Match: v1alpha1.PushSecretMatch{
- RemoteRef: v1alpha1.PushSecretRemoteRef{
- RemoteKey: "name",
- },
- },
- },
- },
- want: true,
- },
- {
- name: "secret not found by name",
- fields: fields{
- store: &esv1.SecretStore{
- Spec: esv1.SecretStoreSpec{
- Provider: &esv1.SecretStoreProvider{
- BitwardenSecretsManager: &esv1.BitwardenSecretsManagerProvider{
- OrganizationID: "orgid",
- ProjectID: projectID,
- },
- },
- },
- },
- mock: func(c *FakeClient) {
- c.ListSecretReturnsOnCallN(0, &SecretIdentifiersResponse{
- Data: []SecretIdentifierResponse{
- {
- ID: remoteID,
- Key: "name",
- OrganizationID: "orgid",
- },
- },
- })
- projectIDDifferent := "different-project"
- c.GetSecretReturnsOnCallN(0, &SecretResponse{
- ID: remoteID,
- Key: "name",
- OrganizationID: "orgid",
- Value: "value",
- ProjectID: &projectIDDifferent,
- })
- },
- },
- args: args{
- ctx: nil,
- ref: v1alpha1.PushSecretData{
- Match: v1alpha1.PushSecretMatch{
- RemoteRef: v1alpha1.PushSecretRemoteRef{
- RemoteKey: "name",
- },
- },
- },
- },
- want: false,
- },
- {
- name: "invalid name format should error",
- fields: fields{
- store: &esv1.SecretStore{
- Spec: esv1.SecretStoreSpec{
- Provider: &esv1.SecretStoreProvider{
- BitwardenSecretsManager: &esv1.BitwardenSecretsManagerProvider{
- OrganizationID: "orgid",
- ProjectID: projectID,
- },
- },
- },
- },
- mock: func(c *FakeClient) {
- // no mocking needed
- },
- assertMock: func(t *testing.T, c *FakeClient) {
- assert.Equal(t, 0, c.listSecretsCalledN)
- },
- },
- args: args{
- ctx: nil,
- ref: v1alpha1.PushSecretData{
- Match: v1alpha1.PushSecretMatch{
- RemoteRef: v1alpha1.PushSecretRemoteRef{
- RemoteKey: "name",
- },
- },
- },
- },
- want: false,
- wantErr: true, // invalid remote key format
- },
- }
- for _, tt := range tests {
- t.Run(tt.name, func(t *testing.T) {
- fakeClient := &FakeClient{}
- tt.fields.mock(fakeClient)
- p := &Provider{
- kube: tt.fields.kube,
- namespace: tt.fields.namespace,
- store: tt.fields.store,
- bitwardenSdkClient: fakeClient,
- }
- got, err := p.SecretExists(tt.args.ctx, tt.args.ref)
- if (err != nil) != tt.wantErr {
- t.Errorf("SecretExists() error = %v, wantErr %v", err, tt.wantErr)
- return
- }
- if got != tt.want {
- t.Errorf("SecretExists() got = %v, want %v", got, tt.want)
- }
- })
- }
- }
- func TestProviderGetSecretMap(t *testing.T) {
- type fields struct {
- kube func() client.Client
- namespace string
- store esv1.GenericStore
- mock func(c *FakeClient)
- }
- type args struct {
- ctx context.Context
- ref esv1.ExternalSecretDataRemoteRef
- key string
- }
- tests := []struct {
- name string
- fields fields
- args args
- want []byte
- wantErr bool
- }{
- {
- name: "get secret map",
- fields: fields{
- kube: func() client.Client {
- return fake.NewFakeClient()
- },
- namespace: "default",
- store: &esv1.SecretStore{},
- mock: func(c *FakeClient) {
- c.GetSecretReturnsOnCallN(0, &SecretResponse{
- ID: remoteID,
- Key: "key",
- Note: "note",
- OrganizationID: "org",
- Value: `{"key": "value"}`,
- })
- },
- },
- args: args{
- ctx: context.Background(),
- ref: esv1.ExternalSecretDataRemoteRef{
- Key: remoteID,
- Property: "key",
- },
- key: "key",
- },
- want: []byte("value"),
- },
- {
- name: "get secret map with yaml",
- fields: fields{
- kube: func() client.Client {
- return fake.NewFakeClient()
- },
- namespace: "default",
- store: &esv1.SecretStore{},
- mock: func(c *FakeClient) {
- c.GetSecretReturnsOnCallN(0, &SecretResponse{
- ID: remoteID,
- Key: "key",
- Note: "note",
- OrganizationID: "org",
- Value: `key: value`,
- })
- },
- },
- args: args{
- ctx: context.Background(),
- ref: esv1.ExternalSecretDataRemoteRef{
- Key: remoteID,
- Property: "key",
- },
- key: "key",
- },
- want: []byte("value"),
- },
- {
- name: "get secret map with nested yaml",
- fields: fields{
- kube: func() client.Client {
- return fake.NewFakeClient()
- },
- namespace: "default",
- store: &esv1.SecretStore{},
- mock: func(c *FakeClient) {
- c.GetSecretReturnsOnCallN(0, &SecretResponse{
- ID: remoteID,
- Key: "key",
- Note: "note",
- OrganizationID: "org",
- Value: `key:
- key2: value`,
- })
- },
- },
- args: args{
- ctx: context.Background(),
- ref: esv1.ExternalSecretDataRemoteRef{
- Key: remoteID,
- Property: "key",
- },
- key: "key",
- },
- want: []byte("key2: value"),
- },
- {
- name: "get secret map with binary yaml data",
- fields: fields{
- kube: func() client.Client {
- return fake.NewFakeClient()
- },
- namespace: "default",
- store: &esv1.SecretStore{},
- mock: func(c *FakeClient) {
- c.GetSecretReturnsOnCallN(0, &SecretResponse{
- ID: remoteID,
- Key: "key",
- Note: "note",
- OrganizationID: "org",
- Value: `key: value
- key2: !!binary VGhpcyBpcyBhIHRlc3Q=`,
- })
- },
- },
- args: args{
- ctx: context.Background(),
- ref: esv1.ExternalSecretDataRemoteRef{
- Key: remoteID,
- Property: "key2",
- },
- key: "key2",
- },
- want: []byte(`This is a test`),
- },
- {
- name: "get secret map - missing key",
- fields: fields{
- kube: func() client.Client {
- return fake.NewFakeClient()
- },
- namespace: "default",
- store: &esv1.SecretStore{},
- mock: func(c *FakeClient) {
- c.GetSecretReturnsOnCallN(0, &SecretResponse{
- ID: remoteID,
- Key: "key",
- Note: "note",
- OrganizationID: "org",
- Value: `{"key": "value"}`,
- })
- },
- },
- args: args{
- ctx: context.Background(),
- ref: esv1.ExternalSecretDataRemoteRef{
- Key: remoteID,
- Property: "nope",
- },
- },
- },
- }
- for _, tt := range tests {
- t.Run(tt.name, func(t *testing.T) {
- fakeClient := &FakeClient{}
- tt.fields.mock(fakeClient)
- p := &Provider{
- kube: tt.fields.kube(),
- namespace: tt.fields.namespace,
- store: tt.fields.store,
- bitwardenSdkClient: fakeClient,
- }
- got, err := p.GetSecretMap(tt.args.ctx, tt.args.ref)
- if (err != nil) != tt.wantErr {
- t.Errorf("GetSecret() error = %v, wantErr %v", err, tt.wantErr)
- return
- }
- assert.Equal(t, tt.want, got[tt.args.key])
- })
- }
- }
|