client.go 17 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528529530531532533534535536537538539540541542543544545546547548549550551
  1. /*
  2. Licensed under the Apache License, Version 2.0 (the "License");
  3. you may not use this file except in compliance with the License.
  4. You may obtain a copy of the License at
  5. http://www.apache.org/licenses/LICENSE-2.0
  6. Unless required by applicable law or agreed to in writing, software
  7. distributed under the License is distributed on an "AS IS" BASIS,
  8. WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
  9. See the License for the specific language governing permissions and
  10. limitations under the License.
  11. */
  12. package secretmanager
  13. import (
  14. "context"
  15. "encoding/json"
  16. "errors"
  17. "fmt"
  18. "maps"
  19. "strconv"
  20. "strings"
  21. secretmanager "cloud.google.com/go/secretmanager/apiv1"
  22. "cloud.google.com/go/secretmanager/apiv1/secretmanagerpb"
  23. "github.com/googleapis/gax-go/v2"
  24. "github.com/googleapis/gax-go/v2/apierror"
  25. "github.com/tidwall/gjson"
  26. "google.golang.org/api/iterator"
  27. "google.golang.org/genproto/protobuf/field_mask"
  28. "google.golang.org/grpc/codes"
  29. "google.golang.org/grpc/status"
  30. corev1 "k8s.io/api/core/v1"
  31. ctrl "sigs.k8s.io/controller-runtime"
  32. kclient "sigs.k8s.io/controller-runtime/pkg/client"
  33. esv1beta1 "github.com/external-secrets/external-secrets/apis/externalsecrets/v1beta1"
  34. "github.com/external-secrets/external-secrets/pkg/constants"
  35. "github.com/external-secrets/external-secrets/pkg/find"
  36. "github.com/external-secrets/external-secrets/pkg/metrics"
  37. "github.com/external-secrets/external-secrets/pkg/provider/util/locks"
  38. "github.com/external-secrets/external-secrets/pkg/utils"
  39. )
  40. const (
  41. CloudPlatformRole = "https://www.googleapis.com/auth/cloud-platform"
  42. defaultVersion = "latest"
  43. errGCPSMStore = "received invalid GCPSM SecretStore resource"
  44. errUnableGetCredentials = "unable to get credentials: %w"
  45. errClientClose = "unable to close SecretManager client: %w"
  46. errMissingStoreSpec = "invalid: missing store spec"
  47. errFetchSAKSecret = "could not fetch SecretAccessKey secret: %w"
  48. errUnableProcessJSONCredentials = "failed to process the provided JSON credentials: %w"
  49. errUnableCreateGCPSMClient = "failed to create GCP secretmanager client: %w"
  50. errUninitalizedGCPProvider = "provider GCP is not initialized"
  51. errClientGetSecretAccess = "unable to access Secret from SecretManager Client: %w"
  52. errJSONSecretUnmarshal = "unable to unmarshal secret: %w"
  53. errInvalidStore = "invalid store"
  54. errInvalidStoreSpec = "invalid store spec"
  55. errInvalidStoreProv = "invalid store provider"
  56. errInvalidGCPProv = "invalid gcp secrets manager provider"
  57. errInvalidAuthSecretRef = "invalid auth secret data: %w"
  58. errInvalidWISARef = "invalid workload identity service account reference: %w"
  59. errUnexpectedFindOperator = "unexpected find operator"
  60. managedByKey = "managed-by"
  61. managedByValue = "external-secrets"
  62. providerName = "GCPSecretManager"
  63. )
  64. type Client struct {
  65. smClient GoogleSecretManagerClient
  66. kube kclient.Client
  67. store *esv1beta1.GCPSMProvider
  68. storeKind string
  69. // namespace of the external secret
  70. namespace string
  71. workloadIdentity *workloadIdentity
  72. }
  73. type GoogleSecretManagerClient interface {
  74. DeleteSecret(ctx context.Context, req *secretmanagerpb.DeleteSecretRequest, opts ...gax.CallOption) error
  75. AccessSecretVersion(ctx context.Context, req *secretmanagerpb.AccessSecretVersionRequest, opts ...gax.CallOption) (*secretmanagerpb.AccessSecretVersionResponse, error)
  76. ListSecrets(ctx context.Context, req *secretmanagerpb.ListSecretsRequest, opts ...gax.CallOption) *secretmanager.SecretIterator
  77. AddSecretVersion(ctx context.Context, req *secretmanagerpb.AddSecretVersionRequest, opts ...gax.CallOption) (*secretmanagerpb.SecretVersion, error)
  78. CreateSecret(ctx context.Context, req *secretmanagerpb.CreateSecretRequest, opts ...gax.CallOption) (*secretmanagerpb.Secret, error)
  79. Close() error
  80. GetSecret(ctx context.Context, req *secretmanagerpb.GetSecretRequest, opts ...gax.CallOption) (*secretmanagerpb.Secret, error)
  81. UpdateSecret(context.Context, *secretmanagerpb.UpdateSecretRequest, ...gax.CallOption) (*secretmanagerpb.Secret, error)
  82. }
  83. var log = ctrl.Log.WithName("provider").WithName("gcp").WithName("secretsmanager")
  84. func (c *Client) DeleteSecret(ctx context.Context, remoteRef esv1beta1.PushSecretRemoteRef) error {
  85. gcpSecret, err := c.smClient.GetSecret(ctx, &secretmanagerpb.GetSecretRequest{
  86. Name: fmt.Sprintf("projects/%s/secrets/%s", c.store.ProjectID, remoteRef.GetRemoteKey()),
  87. })
  88. metrics.ObserveAPICall(constants.ProviderGCPSM, constants.CallGCPSMGetSecret, err)
  89. if err != nil {
  90. if status.Code(err) == codes.NotFound {
  91. return nil
  92. }
  93. return err
  94. }
  95. if manager, ok := gcpSecret.Labels[managedByKey]; !ok || manager != managedByValue {
  96. return nil
  97. }
  98. deleteSecretVersionReq := &secretmanagerpb.DeleteSecretRequest{
  99. Name: fmt.Sprintf("projects/%s/secrets/%s", c.store.ProjectID, remoteRef.GetRemoteKey()),
  100. Etag: gcpSecret.Etag,
  101. }
  102. err = c.smClient.DeleteSecret(ctx, deleteSecretVersionReq)
  103. metrics.ObserveAPICall(constants.ProviderGCPSM, constants.CallGCPSMDeleteSecret, err)
  104. return err
  105. }
  106. func parseError(err error) error {
  107. var gerr *apierror.APIError
  108. if errors.As(err, &gerr) && gerr.GRPCStatus().Code() == codes.NotFound {
  109. return esv1beta1.NoSecretError{}
  110. }
  111. return err
  112. }
  113. func (c *Client) SecretExists(_ context.Context, _ esv1beta1.PushSecretRemoteRef) (bool, error) {
  114. return false, fmt.Errorf("not implemented")
  115. }
  116. // PushSecret pushes a kubernetes secret key into gcp provider Secret.
  117. func (c *Client) PushSecret(ctx context.Context, secret *corev1.Secret, pushSecretData esv1beta1.PushSecretData) error {
  118. if pushSecretData.GetSecretKey() == "" {
  119. return fmt.Errorf("pushing the whole secret is not yet implemented")
  120. }
  121. payload := secret.Data[pushSecretData.GetSecretKey()]
  122. secretName := fmt.Sprintf("projects/%s/secrets/%s", c.store.ProjectID, pushSecretData.GetRemoteKey())
  123. gcpSecret, err := c.smClient.GetSecret(ctx, &secretmanagerpb.GetSecretRequest{
  124. Name: secretName,
  125. })
  126. metrics.ObserveAPICall(constants.ProviderGCPSM, constants.CallGCPSMGetSecret, err)
  127. if err != nil {
  128. if status.Code(err) != codes.NotFound {
  129. return err
  130. }
  131. gcpSecret, err = c.smClient.CreateSecret(ctx, &secretmanagerpb.CreateSecretRequest{
  132. Parent: fmt.Sprintf("projects/%s", c.store.ProjectID),
  133. SecretId: pushSecretData.GetRemoteKey(),
  134. Secret: &secretmanagerpb.Secret{
  135. Labels: map[string]string{
  136. managedByKey: managedByValue,
  137. },
  138. Replication: &secretmanagerpb.Replication{
  139. Replication: &secretmanagerpb.Replication_Automatic_{
  140. Automatic: &secretmanagerpb.Replication_Automatic{},
  141. },
  142. },
  143. },
  144. })
  145. metrics.ObserveAPICall(constants.ProviderGCPSM, constants.CallGCPSMCreateSecret, err)
  146. if err != nil {
  147. return err
  148. }
  149. }
  150. builder, err := newPushSecretBuilder(payload, pushSecretData)
  151. if err != nil {
  152. return err
  153. }
  154. annotations, labels, err := builder.buildMetadata(gcpSecret.Annotations, gcpSecret.Labels)
  155. if err != nil {
  156. return err
  157. }
  158. if !maps.Equal(gcpSecret.Annotations, annotations) || !maps.Equal(gcpSecret.Labels, labels) {
  159. _, err = c.smClient.UpdateSecret(ctx, &secretmanagerpb.UpdateSecretRequest{
  160. Secret: &secretmanagerpb.Secret{
  161. Name: gcpSecret.Name,
  162. Etag: gcpSecret.Etag,
  163. Labels: labels,
  164. Annotations: annotations,
  165. },
  166. UpdateMask: &field_mask.FieldMask{
  167. Paths: []string{"labels", "annotations"},
  168. },
  169. })
  170. metrics.ObserveAPICall(constants.ProviderGCPSM, constants.CallGCPSMUpdateSecret, err)
  171. if err != nil {
  172. return err
  173. }
  174. }
  175. unlock, err := locks.TryLock(providerName, secretName)
  176. if err != nil {
  177. return err
  178. }
  179. defer unlock()
  180. gcpVersion, err := c.smClient.AccessSecretVersion(ctx, &secretmanagerpb.AccessSecretVersionRequest{
  181. Name: fmt.Sprintf("%s/versions/latest", secretName),
  182. })
  183. metrics.ObserveAPICall(constants.ProviderGCPSM, constants.CallGCPSMAccessSecretVersion, err)
  184. if err != nil && status.Code(err) != codes.NotFound {
  185. return err
  186. }
  187. if gcpVersion != nil && gcpVersion.Payload != nil && !builder.needUpdate(gcpVersion.Payload.Data) {
  188. return nil
  189. }
  190. var original []byte
  191. if gcpVersion != nil && gcpVersion.Payload != nil {
  192. original = gcpVersion.Payload.Data
  193. }
  194. data, err := builder.buildData(original)
  195. if err != nil {
  196. return err
  197. }
  198. addSecretVersionReq := &secretmanagerpb.AddSecretVersionRequest{
  199. Parent: fmt.Sprintf("projects/%s/secrets/%s", c.store.ProjectID, pushSecretData.GetRemoteKey()),
  200. Payload: &secretmanagerpb.SecretPayload{
  201. Data: data,
  202. },
  203. }
  204. _, err = c.smClient.AddSecretVersion(ctx, addSecretVersionReq)
  205. metrics.ObserveAPICall(constants.ProviderGCPSM, constants.CallGCPSMAddSecretVersion, err)
  206. return err
  207. }
  208. // GetAllSecrets syncs multiple secrets from gcp provider into a single Kubernetes Secret.
  209. func (c *Client) GetAllSecrets(ctx context.Context, ref esv1beta1.ExternalSecretFind) (map[string][]byte, error) {
  210. if ref.Name != nil {
  211. return c.findByName(ctx, ref)
  212. }
  213. if len(ref.Tags) > 0 {
  214. return c.findByTags(ctx, ref)
  215. }
  216. return nil, errors.New(errUnexpectedFindOperator)
  217. }
  218. func (c *Client) findByName(ctx context.Context, ref esv1beta1.ExternalSecretFind) (map[string][]byte, error) {
  219. // regex matcher
  220. matcher, err := find.New(*ref.Name)
  221. if err != nil {
  222. return nil, err
  223. }
  224. req := &secretmanagerpb.ListSecretsRequest{
  225. Parent: fmt.Sprintf("projects/%s", c.store.ProjectID),
  226. }
  227. if ref.Path != nil {
  228. req.Filter = fmt.Sprintf("name:%s", *ref.Path)
  229. }
  230. // Call the API.
  231. it := c.smClient.ListSecrets(ctx, req)
  232. secretMap := make(map[string][]byte)
  233. var resp *secretmanagerpb.Secret
  234. defer metrics.ObserveAPICall(constants.ProviderGCPSM, constants.CallGCPSMListSecrets, err)
  235. for {
  236. resp, err = it.Next()
  237. if errors.Is(err, iterator.Done) {
  238. break
  239. }
  240. if err != nil {
  241. return nil, fmt.Errorf("failed to list secrets: %w", err)
  242. }
  243. log.V(1).Info("gcp sm findByName found", "secrets", strconv.Itoa(it.PageInfo().Remaining()))
  244. key := c.trimName(resp.Name)
  245. // If we don't match we skip.
  246. // Also, if we have path, and it is not at the beguining we skip.
  247. // We have to check if path is at the beguining of the key because
  248. // there is no way to create a `name:%s*` (starts with) filter
  249. // At https://cloud.google.com/secret-manager/docs/filtering you can use `*`
  250. // but not like that it seems.
  251. if !matcher.MatchName(key) || (ref.Path != nil && !strings.HasPrefix(key, *ref.Path)) {
  252. continue
  253. }
  254. log.V(1).Info("gcp sm findByName matches", "name", resp.Name)
  255. secretMap[key], err = c.getData(ctx, key)
  256. if err != nil {
  257. return nil, err
  258. }
  259. }
  260. return utils.ConvertKeys(ref.ConversionStrategy, secretMap)
  261. }
  262. func (c *Client) getData(ctx context.Context, key string) ([]byte, error) {
  263. dataRef := esv1beta1.ExternalSecretDataRemoteRef{
  264. Key: key,
  265. }
  266. data, err := c.GetSecret(ctx, dataRef)
  267. if err != nil {
  268. return []byte(""), err
  269. }
  270. return data, nil
  271. }
  272. func (c *Client) findByTags(ctx context.Context, ref esv1beta1.ExternalSecretFind) (map[string][]byte, error) {
  273. var tagFilter string
  274. for k, v := range ref.Tags {
  275. tagFilter = fmt.Sprintf("%slabels.%s=%s ", tagFilter, k, v)
  276. }
  277. tagFilter = strings.TrimSuffix(tagFilter, " ")
  278. if ref.Path != nil {
  279. tagFilter = fmt.Sprintf("%s name:%s", tagFilter, *ref.Path)
  280. }
  281. req := &secretmanagerpb.ListSecretsRequest{
  282. Parent: fmt.Sprintf("projects/%s", c.store.ProjectID),
  283. }
  284. log.V(1).Info("gcp sm findByTags", "tagFilter", tagFilter)
  285. req.Filter = tagFilter
  286. // Call the API.
  287. it := c.smClient.ListSecrets(ctx, req)
  288. var resp *secretmanagerpb.Secret
  289. var err error
  290. defer metrics.ObserveAPICall(constants.ProviderGCPSM, constants.CallGCPSMListSecrets, err)
  291. secretMap := make(map[string][]byte)
  292. for {
  293. resp, err = it.Next()
  294. if errors.Is(err, iterator.Done) {
  295. break
  296. }
  297. if err != nil {
  298. return nil, fmt.Errorf("failed to list secrets: %w", err)
  299. }
  300. key := c.trimName(resp.Name)
  301. if ref.Path != nil && !strings.HasPrefix(key, *ref.Path) {
  302. continue
  303. }
  304. log.V(1).Info("gcp sm findByTags matches tags", "name", resp.Name)
  305. secretMap[key], err = c.getData(ctx, key)
  306. if err != nil {
  307. return nil, err
  308. }
  309. }
  310. return utils.ConvertKeys(ref.ConversionStrategy, secretMap)
  311. }
  312. func (c *Client) trimName(name string) string {
  313. projectIDNumuber := c.extractProjectIDNumber(name)
  314. key := strings.TrimPrefix(name, fmt.Sprintf("projects/%s/secrets/", projectIDNumuber))
  315. return key
  316. }
  317. // extractProjectIDNumber grabs the project id from the full name returned by gcp api
  318. // gcp api seems to always return the number and not the project name
  319. // (and users would always use the name, while requests accept both).
  320. func (c *Client) extractProjectIDNumber(secretFullName string) string {
  321. s := strings.Split(secretFullName, "/")
  322. ProjectIDNumuber := s[1]
  323. return ProjectIDNumuber
  324. }
  325. // GetSecret returns a single secret from the provider.
  326. func (c *Client) GetSecret(ctx context.Context, ref esv1beta1.ExternalSecretDataRemoteRef) ([]byte, error) {
  327. if utils.IsNil(c.smClient) || c.store.ProjectID == "" {
  328. return nil, fmt.Errorf(errUninitalizedGCPProvider)
  329. }
  330. if ref.MetadataPolicy == esv1beta1.ExternalSecretMetadataPolicyFetch {
  331. return c.getSecretMetadata(ctx, ref)
  332. }
  333. version := ref.Version
  334. if version == "" {
  335. version = defaultVersion
  336. }
  337. req := &secretmanagerpb.AccessSecretVersionRequest{
  338. Name: fmt.Sprintf("projects/%s/secrets/%s/versions/%s", c.store.ProjectID, ref.Key, version),
  339. }
  340. result, err := c.smClient.AccessSecretVersion(ctx, req)
  341. metrics.ObserveAPICall(constants.ProviderGCPSM, constants.CallGCPSMAccessSecretVersion, err)
  342. err = parseError(err)
  343. if err != nil {
  344. return nil, fmt.Errorf(errClientGetSecretAccess, err)
  345. }
  346. if ref.Property == "" {
  347. if result.Payload.Data != nil {
  348. return result.Payload.Data, nil
  349. }
  350. return nil, fmt.Errorf("invalid secret received. no secret string for key: %s", ref.Key)
  351. }
  352. val := getDataByProperty(result.Payload.Data, ref.Property)
  353. if !val.Exists() {
  354. return nil, fmt.Errorf("key %s does not exist in secret %s", ref.Property, ref.Key)
  355. }
  356. return []byte(val.String()), nil
  357. }
  358. func (c *Client) getSecretMetadata(ctx context.Context, ref esv1beta1.ExternalSecretDataRemoteRef) ([]byte, error) {
  359. secret, err := c.smClient.GetSecret(ctx, &secretmanagerpb.GetSecretRequest{
  360. Name: fmt.Sprintf("projects/%s/secrets/%s", c.store.ProjectID, ref.Key),
  361. })
  362. err = parseError(err)
  363. if err != nil {
  364. return nil, fmt.Errorf(errClientGetSecretAccess, err)
  365. }
  366. const (
  367. annotations = "annotations"
  368. labels = "labels"
  369. )
  370. extractMetadataKey := func(s string, p string) string {
  371. prefix := p + "."
  372. if !strings.HasPrefix(s, prefix) {
  373. return ""
  374. }
  375. return strings.TrimPrefix(s, prefix)
  376. }
  377. if annotation := extractMetadataKey(ref.Property, annotations); annotation != "" {
  378. v, ok := secret.GetAnnotations()[annotation]
  379. if !ok {
  380. return nil, fmt.Errorf("annotation with key %s does not exist in secret %s", annotation, ref.Key)
  381. }
  382. return []byte(v), nil
  383. }
  384. if label := extractMetadataKey(ref.Property, labels); label != "" {
  385. v, ok := secret.GetLabels()[label]
  386. if !ok {
  387. return nil, fmt.Errorf("label with key %s does not exist in secret %s", label, ref.Key)
  388. }
  389. return []byte(v), nil
  390. }
  391. if ref.Property == annotations {
  392. j, err := json.Marshal(secret.GetAnnotations())
  393. if err != nil {
  394. return nil, fmt.Errorf("faild marshaling annotations into json: %w", err)
  395. }
  396. return j, nil
  397. }
  398. if ref.Property == labels {
  399. j, err := json.Marshal(secret.GetLabels())
  400. if err != nil {
  401. return nil, fmt.Errorf("faild marshaling labels into json: %w", err)
  402. }
  403. return j, nil
  404. }
  405. if ref.Property != "" {
  406. return nil, fmt.Errorf("invalid property %s: metadata property should start with either %s or %s", ref.Property, annotations, labels)
  407. }
  408. j, err := json.Marshal(map[string]map[string]string{
  409. "annotations": secret.GetAnnotations(),
  410. "labels": secret.GetLabels(),
  411. })
  412. if err != nil {
  413. return nil, fmt.Errorf("faild marshaling metadata map into json: %w", err)
  414. }
  415. return j, nil
  416. }
  417. // GetSecretMap returns multiple k/v pairs from the provider.
  418. func (c *Client) GetSecretMap(ctx context.Context, ref esv1beta1.ExternalSecretDataRemoteRef) (map[string][]byte, error) {
  419. if c.smClient == nil || c.store.ProjectID == "" {
  420. return nil, fmt.Errorf(errUninitalizedGCPProvider)
  421. }
  422. data, err := c.GetSecret(ctx, ref)
  423. if err != nil {
  424. return nil, err
  425. }
  426. kv := make(map[string]json.RawMessage)
  427. err = json.Unmarshal(data, &kv)
  428. if err != nil {
  429. return nil, fmt.Errorf(errJSONSecretUnmarshal, err)
  430. }
  431. secretData := make(map[string][]byte)
  432. for k, v := range kv {
  433. var strVal string
  434. err = json.Unmarshal(v, &strVal)
  435. if err == nil {
  436. secretData[k] = []byte(strVal)
  437. } else {
  438. secretData[k] = v
  439. }
  440. }
  441. return secretData, nil
  442. }
  443. func (c *Client) Close(_ context.Context) error {
  444. var err error
  445. if c.smClient != nil {
  446. err = c.smClient.Close()
  447. }
  448. if c.workloadIdentity != nil {
  449. err = c.workloadIdentity.Close()
  450. }
  451. useMu.Unlock()
  452. if err != nil {
  453. return fmt.Errorf(errClientClose, err)
  454. }
  455. return nil
  456. }
  457. func (c *Client) Validate() (esv1beta1.ValidationResult, error) {
  458. if c.storeKind == esv1beta1.ClusterSecretStoreKind && isReferentSpec(c.store) {
  459. return esv1beta1.ValidationResultUnknown, nil
  460. }
  461. return esv1beta1.ValidationResultReady, nil
  462. }
  463. func getDataByProperty(data []byte, property string) gjson.Result {
  464. var payload string
  465. if data != nil {
  466. payload = string(data)
  467. }
  468. idx := strings.Index(property, ".")
  469. refProperty := property
  470. if idx > 0 {
  471. refProperty = strings.ReplaceAll(refProperty, ".", "\\.")
  472. val := gjson.Get(payload, refProperty)
  473. if val.Exists() {
  474. return val
  475. }
  476. }
  477. return gjson.Get(payload, property)
  478. }