secretsmanager.go 14 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483
  1. /*
  2. Licensed under the Apache License, Version 2.0 (the "License");
  3. you may not use this file except in compliance with the License.
  4. You may obtain a copy of the License at
  5. http://www.apache.org/licenses/LICENSE-2.0
  6. Unless required by applicable law or agreed to in writing, software
  7. distributed under the License is distributed on an "AS IS" BASIS,
  8. WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
  9. See the License for the specific language governing permissions and
  10. limitations under the License.
  11. */
  12. package secretsmanager
  13. import (
  14. "bytes"
  15. "context"
  16. "encoding/json"
  17. "errors"
  18. "fmt"
  19. "strings"
  20. "github.com/aws/aws-sdk-go/aws"
  21. "github.com/aws/aws-sdk-go/aws/awserr"
  22. "github.com/aws/aws-sdk-go/aws/request"
  23. "github.com/aws/aws-sdk-go/aws/session"
  24. awssm "github.com/aws/aws-sdk-go/service/secretsmanager"
  25. "github.com/tidwall/gjson"
  26. utilpointer "k8s.io/utils/pointer"
  27. ctrl "sigs.k8s.io/controller-runtime"
  28. esv1beta1 "github.com/external-secrets/external-secrets/apis/externalsecrets/v1beta1"
  29. "github.com/external-secrets/external-secrets/pkg/find"
  30. "github.com/external-secrets/external-secrets/pkg/provider/aws/util"
  31. "github.com/external-secrets/external-secrets/pkg/provider/metrics"
  32. )
  33. // https://github.com/external-secrets/external-secrets/issues/644
  34. var _ esv1beta1.SecretsClient = &SecretsManager{}
  35. // SecretsManager is a provider for AWS SecretsManager.
  36. type SecretsManager struct {
  37. sess *session.Session
  38. client SMInterface
  39. referentAuth bool
  40. cache map[string]*awssm.GetSecretValueOutput
  41. }
  42. // SMInterface is a subset of the smiface api.
  43. // see: https://docs.aws.amazon.com/sdk-for-go/api/service/secretsmanager/secretsmanageriface/
  44. type SMInterface interface {
  45. ListSecrets(*awssm.ListSecretsInput) (*awssm.ListSecretsOutput, error)
  46. GetSecretValue(*awssm.GetSecretValueInput) (*awssm.GetSecretValueOutput, error)
  47. CreateSecretWithContext(aws.Context, *awssm.CreateSecretInput, ...request.Option) (*awssm.CreateSecretOutput, error)
  48. GetSecretValueWithContext(aws.Context, *awssm.GetSecretValueInput, ...request.Option) (*awssm.GetSecretValueOutput, error)
  49. PutSecretValueWithContext(aws.Context, *awssm.PutSecretValueInput, ...request.Option) (*awssm.PutSecretValueOutput, error)
  50. DescribeSecretWithContext(aws.Context, *awssm.DescribeSecretInput, ...request.Option) (*awssm.DescribeSecretOutput, error)
  51. DeleteSecretWithContext(ctx aws.Context, input *awssm.DeleteSecretInput, opts ...request.Option) (*awssm.DeleteSecretOutput, error)
  52. }
  53. const (
  54. errUnexpectedFindOperator = "unexpected find operator"
  55. managedBy = "managed-by"
  56. externalSecrets = "external-secrets"
  57. )
  58. var log = ctrl.Log.WithName("provider").WithName("aws").WithName("secretsmanager")
  59. // New creates a new SecretsManager client.
  60. func New(sess *session.Session, cfg *aws.Config, referentAuth bool) (*SecretsManager, error) {
  61. return &SecretsManager{
  62. sess: sess,
  63. client: awssm.New(sess, cfg),
  64. referentAuth: referentAuth,
  65. cache: make(map[string]*awssm.GetSecretValueOutput),
  66. }, nil
  67. }
  68. func (sm *SecretsManager) fetch(ctx context.Context, ref esv1beta1.ExternalSecretDataRemoteRef) (*awssm.GetSecretValueOutput, error) {
  69. ver := "AWSCURRENT"
  70. valueFrom := "SECRET"
  71. if ref.Version != "" {
  72. ver = ref.Version
  73. }
  74. if ref.MetadataPolicy == esv1beta1.ExternalSecretMetadataPolicyFetch {
  75. valueFrom = "TAG"
  76. }
  77. log.Info("fetching secret value", "key", ref.Key, "version", ver, "value", valueFrom)
  78. cacheKey := fmt.Sprintf("%s#%s#%s", ref.Key, ver, valueFrom)
  79. if secretOut, found := sm.cache[cacheKey]; found {
  80. log.Info("found secret in cache", "key", ref.Key, "version", ver)
  81. return secretOut, nil
  82. }
  83. var secretOut *awssm.GetSecretValueOutput
  84. var err error
  85. if ref.MetadataPolicy == esv1beta1.ExternalSecretMetadataPolicyFetch {
  86. describeSecretInput := &awssm.DescribeSecretInput{
  87. SecretId: &ref.Key,
  88. }
  89. descOutput, err := sm.client.DescribeSecretWithContext(ctx, describeSecretInput)
  90. if err != nil {
  91. return nil, err
  92. }
  93. log.Info("found metadata secret", "key", ref.Key, "output", descOutput)
  94. jsonTags, err := TagsToJSONString(descOutput.Tags)
  95. if err != nil {
  96. return nil, err
  97. }
  98. secretOut = &awssm.GetSecretValueOutput{
  99. ARN: descOutput.ARN,
  100. CreatedDate: descOutput.CreatedDate,
  101. Name: descOutput.Name,
  102. SecretString: &jsonTags,
  103. VersionId: &ver,
  104. }
  105. } else {
  106. var getSecretValueInput *awssm.GetSecretValueInput
  107. if strings.HasPrefix(ver, "uuid/") {
  108. versionID := strings.TrimPrefix(ver, "uuid/")
  109. getSecretValueInput = &awssm.GetSecretValueInput{
  110. SecretId: &ref.Key,
  111. VersionId: &versionID,
  112. }
  113. } else {
  114. getSecretValueInput = &awssm.GetSecretValueInput{
  115. SecretId: &ref.Key,
  116. VersionStage: &ver,
  117. }
  118. }
  119. secretOut, err = sm.client.GetSecretValue(getSecretValueInput)
  120. metrics.ObserveAPICall(metrics.ProviderAWSSM, metrics.CallAWSSMGetSecretValue, err)
  121. var nf *awssm.ResourceNotFoundException
  122. if errors.As(err, &nf) {
  123. return nil, esv1beta1.NoSecretErr
  124. }
  125. if err != nil {
  126. return nil, err
  127. }
  128. }
  129. sm.cache[cacheKey] = secretOut
  130. return secretOut, nil
  131. }
  132. func TagsToJSONString(tags []*awssm.Tag) (string, error) {
  133. tagMap := make(map[string]string, len(tags))
  134. for _, tag := range tags {
  135. tagMap[*tag.Key] = *tag.Value
  136. }
  137. byteArr, err := json.Marshal(tagMap)
  138. if err != nil {
  139. return "", err
  140. }
  141. return string(byteArr), nil
  142. }
  143. func (sm *SecretsManager) DeleteSecret(ctx context.Context, remoteRef esv1beta1.PushRemoteRef) error {
  144. secretName := remoteRef.GetRemoteKey()
  145. secretValue := awssm.GetSecretValueInput{
  146. SecretId: &secretName,
  147. }
  148. secretInput := awssm.DescribeSecretInput{
  149. SecretId: &secretName,
  150. }
  151. awsSecret, err := sm.client.GetSecretValueWithContext(ctx, &secretValue)
  152. metrics.ObserveAPICall(metrics.ProviderAWSSM, metrics.CallAWSSMGetSecretValue, err)
  153. var aerr awserr.Error
  154. if err != nil {
  155. if ok := errors.As(err, &aerr); !ok {
  156. return err
  157. }
  158. if aerr.Code() == awssm.ErrCodeResourceNotFoundException {
  159. return nil
  160. }
  161. return err
  162. }
  163. data, err := sm.client.DescribeSecretWithContext(ctx, &secretInput)
  164. metrics.ObserveAPICall(metrics.ProviderAWSSM, metrics.CallAWSSMDescribeSecret, err)
  165. if err != nil {
  166. return err
  167. }
  168. if !isManagedByESO(data) {
  169. return nil
  170. }
  171. deleteInput := &awssm.DeleteSecretInput{
  172. SecretId: awsSecret.ARN,
  173. }
  174. _, err = sm.client.DeleteSecretWithContext(ctx, deleteInput)
  175. metrics.ObserveAPICall(metrics.ProviderAWSSM, metrics.CallAWSSMDeleteSecret, err)
  176. return err
  177. }
  178. func (sm *SecretsManager) PushSecret(ctx context.Context, value []byte, remoteRef esv1beta1.PushRemoteRef) error {
  179. secretName := remoteRef.GetRemoteKey()
  180. managedBy := managedBy
  181. externalSecrets := externalSecrets
  182. externalSecretsTag := []*awssm.Tag{
  183. {
  184. Key: &managedBy,
  185. Value: &externalSecrets,
  186. },
  187. }
  188. secretRequest := awssm.CreateSecretInput{
  189. Name: &secretName,
  190. SecretBinary: value,
  191. Tags: externalSecretsTag,
  192. }
  193. secretValue := awssm.GetSecretValueInput{
  194. SecretId: &secretName,
  195. }
  196. secretInput := awssm.DescribeSecretInput{
  197. SecretId: &secretName,
  198. }
  199. awsSecret, err := sm.client.GetSecretValueWithContext(ctx, &secretValue)
  200. metrics.ObserveAPICall(metrics.ProviderAWSSM, metrics.CallAWSSMGetSecretValue, err)
  201. var aerr awserr.Error
  202. if err != nil {
  203. if ok := errors.As(err, &aerr); !ok {
  204. return err
  205. }
  206. if aerr.Code() == awssm.ErrCodeResourceNotFoundException {
  207. _, err = sm.client.CreateSecretWithContext(ctx, &secretRequest)
  208. metrics.ObserveAPICall(metrics.ProviderAWSSM, metrics.CallAWSSMCreateSecret, err)
  209. return err
  210. }
  211. return err
  212. }
  213. data, err := sm.client.DescribeSecretWithContext(ctx, &secretInput)
  214. metrics.ObserveAPICall(metrics.ProviderAWSSM, metrics.CallAWSSMDescribeSecret, err)
  215. if err != nil {
  216. return err
  217. }
  218. if !isManagedByESO(data) {
  219. return fmt.Errorf("secret not managed by external-secrets")
  220. }
  221. if awsSecret != nil && bytes.Equal(awsSecret.SecretBinary, value) {
  222. return nil
  223. }
  224. input := &awssm.PutSecretValueInput{
  225. SecretId: awsSecret.ARN,
  226. SecretBinary: value,
  227. }
  228. _, err = sm.client.PutSecretValueWithContext(ctx, input)
  229. metrics.ObserveAPICall(metrics.ProviderAWSSM, metrics.CallAWSSMPutSecretValue, err)
  230. return err
  231. }
  232. func isManagedByESO(data *awssm.DescribeSecretOutput) bool {
  233. managedBy := managedBy
  234. externalSecrets := externalSecrets
  235. for _, tag := range data.Tags {
  236. if *tag.Key == managedBy && *tag.Value == externalSecrets {
  237. return true
  238. }
  239. }
  240. return false
  241. }
  242. // GetAllSecrets syncs multiple secrets from aws provider into a single Kubernetes Secret.
  243. func (sm *SecretsManager) GetAllSecrets(ctx context.Context, ref esv1beta1.ExternalSecretFind) (map[string][]byte, error) {
  244. if ref.Name != nil {
  245. return sm.findByName(ctx, ref)
  246. }
  247. if len(ref.Tags) > 0 {
  248. return sm.findByTags(ctx, ref)
  249. }
  250. return nil, errors.New(errUnexpectedFindOperator)
  251. }
  252. func (sm *SecretsManager) findByName(ctx context.Context, ref esv1beta1.ExternalSecretFind) (map[string][]byte, error) {
  253. matcher, err := find.New(*ref.Name)
  254. if err != nil {
  255. return nil, err
  256. }
  257. filters := make([]*awssm.Filter, 0)
  258. if ref.Path != nil {
  259. filters = append(filters, &awssm.Filter{
  260. Key: utilpointer.String(awssm.FilterNameStringTypeName),
  261. Values: []*string{
  262. ref.Path,
  263. },
  264. })
  265. }
  266. data := make(map[string][]byte)
  267. var nextToken *string
  268. for {
  269. it, err := sm.client.ListSecrets(&awssm.ListSecretsInput{
  270. Filters: filters,
  271. NextToken: nextToken,
  272. })
  273. metrics.ObserveAPICall(metrics.ProviderAWSSM, metrics.CallAWSSMListSecrets, err)
  274. if err != nil {
  275. return nil, err
  276. }
  277. log.V(1).Info("aws sm findByName found", "secrets", len(it.SecretList))
  278. for _, secret := range it.SecretList {
  279. if !matcher.MatchName(*secret.Name) {
  280. continue
  281. }
  282. log.V(1).Info("aws sm findByName matches", "name", *secret.Name)
  283. err = sm.fetchAndSet(ctx, data, *secret.Name)
  284. if err != nil {
  285. return nil, err
  286. }
  287. }
  288. nextToken = it.NextToken
  289. if nextToken == nil {
  290. break
  291. }
  292. }
  293. return data, nil
  294. }
  295. func (sm *SecretsManager) findByTags(ctx context.Context, ref esv1beta1.ExternalSecretFind) (map[string][]byte, error) {
  296. filters := make([]*awssm.Filter, 0)
  297. for k, v := range ref.Tags {
  298. filters = append(filters, &awssm.Filter{
  299. Key: utilpointer.String(awssm.FilterNameStringTypeTagKey),
  300. Values: []*string{
  301. utilpointer.String(k),
  302. },
  303. }, &awssm.Filter{
  304. Key: utilpointer.String(awssm.FilterNameStringTypeTagValue),
  305. Values: []*string{
  306. utilpointer.String(v),
  307. },
  308. })
  309. }
  310. if ref.Path != nil {
  311. filters = append(filters, &awssm.Filter{
  312. Key: utilpointer.String(awssm.FilterNameStringTypeName),
  313. Values: []*string{
  314. ref.Path,
  315. },
  316. })
  317. }
  318. data := make(map[string][]byte)
  319. var nextToken *string
  320. for {
  321. log.V(1).Info("aws sm findByTag", "nextToken", nextToken)
  322. it, err := sm.client.ListSecrets(&awssm.ListSecretsInput{
  323. Filters: filters,
  324. NextToken: nextToken,
  325. })
  326. metrics.ObserveAPICall(metrics.ProviderAWSSM, metrics.CallAWSSMListSecrets, err)
  327. if err != nil {
  328. return nil, err
  329. }
  330. log.V(1).Info("aws sm findByTag found", "secrets", len(it.SecretList))
  331. for _, secret := range it.SecretList {
  332. err = sm.fetchAndSet(ctx, data, *secret.Name)
  333. if err != nil {
  334. return nil, err
  335. }
  336. }
  337. nextToken = it.NextToken
  338. if nextToken == nil {
  339. break
  340. }
  341. }
  342. return data, nil
  343. }
  344. func (sm *SecretsManager) fetchAndSet(ctx context.Context, data map[string][]byte, name string) error {
  345. sec, err := sm.fetch(ctx, esv1beta1.ExternalSecretDataRemoteRef{
  346. Key: name,
  347. })
  348. if err != nil {
  349. return err
  350. }
  351. if sec.SecretString != nil {
  352. data[name] = []byte(*sec.SecretString)
  353. }
  354. if sec.SecretBinary != nil {
  355. data[name] = sec.SecretBinary
  356. }
  357. return nil
  358. }
  359. // GetSecret returns a single secret from the provider.
  360. func (sm *SecretsManager) GetSecret(ctx context.Context, ref esv1beta1.ExternalSecretDataRemoteRef) ([]byte, error) {
  361. secretOut, err := sm.fetch(ctx, ref)
  362. if errors.Is(err, esv1beta1.NoSecretErr) {
  363. return nil, err
  364. }
  365. if err != nil {
  366. return nil, util.SanitizeErr(err)
  367. }
  368. if ref.Property == "" {
  369. if secretOut.SecretString != nil {
  370. return []byte(*secretOut.SecretString), nil
  371. }
  372. if secretOut.SecretBinary != nil {
  373. return secretOut.SecretBinary, nil
  374. }
  375. return nil, fmt.Errorf("invalid secret received. no secret string nor binary for key: %s", ref.Key)
  376. }
  377. var payload string
  378. if secretOut.SecretString != nil {
  379. payload = *secretOut.SecretString
  380. }
  381. if secretOut.SecretBinary != nil {
  382. payload = string(secretOut.SecretBinary)
  383. }
  384. // We need to search if a given key with a . exists before using gjson operations.
  385. idx := strings.Index(ref.Property, ".")
  386. if idx > -1 {
  387. refProperty := strings.ReplaceAll(ref.Property, ".", "\\.")
  388. val := gjson.Get(payload, refProperty)
  389. if val.Exists() {
  390. return []byte(val.String()), nil
  391. }
  392. }
  393. val := gjson.Get(payload, ref.Property)
  394. if !val.Exists() {
  395. return nil, fmt.Errorf("key %s does not exist in secret %s", ref.Property, ref.Key)
  396. }
  397. return []byte(val.String()), nil
  398. }
  399. // GetSecretMap returns multiple k/v pairs from the provider.
  400. func (sm *SecretsManager) GetSecretMap(ctx context.Context, ref esv1beta1.ExternalSecretDataRemoteRef) (map[string][]byte, error) {
  401. log.Info("fetching secret map", "key", ref.Key)
  402. data, err := sm.GetSecret(ctx, ref)
  403. if err != nil {
  404. return nil, err
  405. }
  406. kv := make(map[string]json.RawMessage)
  407. err = json.Unmarshal(data, &kv)
  408. if err != nil {
  409. return nil, fmt.Errorf("unable to unmarshal secret %s: %w", ref.Key, err)
  410. }
  411. secretData := make(map[string][]byte)
  412. for k, v := range kv {
  413. var strVal string
  414. err = json.Unmarshal(v, &strVal)
  415. if err == nil {
  416. secretData[k] = []byte(strVal)
  417. } else {
  418. secretData[k] = v
  419. }
  420. }
  421. return secretData, nil
  422. }
  423. func (sm *SecretsManager) Close(ctx context.Context) error {
  424. return nil
  425. }
  426. func (sm *SecretsManager) Validate() (esv1beta1.ValidationResult, error) {
  427. // skip validation stack because it depends on the namespace
  428. // of the ExternalSecret
  429. if sm.referentAuth {
  430. return esv1beta1.ValidationResultUnknown, nil
  431. }
  432. _, err := sm.sess.Config.Credentials.Get()
  433. if err != nil {
  434. return esv1beta1.ValidationResultError, err
  435. }
  436. return esv1beta1.ValidationResultReady, nil
  437. }
  438. func (sm *SecretsManager) Capabilities() esv1beta1.SecretStoreCapabilities {
  439. return esv1beta1.SecretStoreReadWrite
  440. }