validate.go 4.5 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123
  1. /*
  2. Licensed under the Apache License, Version 2.0 (the "License");
  3. you may not use this file except in compliance with the License.
  4. You may obtain a copy of the License at
  5. http://www.apache.org/licenses/LICENSE-2.0
  6. Unless required by applicable law or agreed to in writing, software
  7. distributed under the License is distributed on an "AS IS" BASIS,
  8. WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
  9. See the License for the specific language governing permissions and
  10. limitations under the License.
  11. */
  12. package kubernetes
  13. import (
  14. "context"
  15. "errors"
  16. "fmt"
  17. "slices"
  18. authv1 "k8s.io/api/authorization/v1"
  19. metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
  20. "sigs.k8s.io/controller-runtime/pkg/webhook/admission"
  21. esv1 "github.com/external-secrets/external-secrets/apis/externalsecrets/v1"
  22. "github.com/external-secrets/external-secrets/pkg/constants"
  23. "github.com/external-secrets/external-secrets/pkg/metrics"
  24. "github.com/external-secrets/external-secrets/pkg/utils"
  25. )
  26. func (p *Provider) ValidateStore(store esv1.GenericStore) (admission.Warnings, error) {
  27. storeSpec := store.GetSpec()
  28. k8sSpec := storeSpec.Provider.Kubernetes
  29. if k8sSpec.AuthRef == nil && k8sSpec.Server.CABundle == nil && k8sSpec.Server.CAProvider == nil {
  30. return nil, errors.New("a CABundle or CAProvider is required")
  31. }
  32. if store.GetObjectKind().GroupVersionKind().Kind == esv1.ClusterSecretStoreKind &&
  33. k8sSpec.Server.CAProvider != nil &&
  34. k8sSpec.Server.CAProvider.Namespace == nil {
  35. return nil, errors.New("CAProvider.namespace must not be empty with ClusterSecretStore")
  36. }
  37. if store.GetObjectKind().GroupVersionKind().Kind == esv1.SecretStoreKind &&
  38. k8sSpec.Server.CAProvider != nil &&
  39. k8sSpec.Server.CAProvider.Namespace != nil {
  40. return nil, errors.New("CAProvider.namespace must be empty with SecretStore")
  41. }
  42. if k8sSpec.Auth != nil && k8sSpec.Auth.Cert != nil {
  43. if k8sSpec.Auth.Cert.ClientCert.Name == "" {
  44. return nil, errors.New("ClientCert.Name cannot be empty")
  45. }
  46. if k8sSpec.Auth.Cert.ClientCert.Key == "" {
  47. return nil, errors.New("ClientCert.Key cannot be empty")
  48. }
  49. if err := utils.ValidateSecretSelector(store, k8sSpec.Auth.Cert.ClientCert); err != nil {
  50. return nil, err
  51. }
  52. }
  53. if k8sSpec.Auth != nil && k8sSpec.Auth.Token != nil {
  54. if k8sSpec.Auth.Token.BearerToken.Name == "" {
  55. return nil, errors.New("BearerToken.Name cannot be empty")
  56. }
  57. if k8sSpec.Auth.Token.BearerToken.Key == "" {
  58. return nil, errors.New("BearerToken.Key cannot be empty")
  59. }
  60. if err := utils.ValidateSecretSelector(store, k8sSpec.Auth.Token.BearerToken); err != nil {
  61. return nil, err
  62. }
  63. }
  64. if k8sSpec.Auth != nil && k8sSpec.Auth.ServiceAccount != nil {
  65. if err := utils.ValidateReferentServiceAccountSelector(store, *k8sSpec.Auth.ServiceAccount); err != nil {
  66. return nil, err
  67. }
  68. }
  69. return nil, nil
  70. }
  71. func (c *Client) Validate() (esv1.ValidationResult, error) {
  72. // when using referent namespace we can not validate the token
  73. // because the namespace is not known yet when Validate() is called
  74. // from the SecretStore controller.
  75. if c.storeKind == esv1.ClusterSecretStoreKind && isReferentSpec(c.store) {
  76. return esv1.ValidationResultUnknown, nil
  77. }
  78. ctx := context.Background()
  79. t := authv1.SelfSubjectRulesReview{
  80. Spec: authv1.SelfSubjectRulesReviewSpec{
  81. Namespace: c.store.RemoteNamespace,
  82. },
  83. }
  84. authReview, err := c.userReviewClient.Create(ctx, &t, metav1.CreateOptions{})
  85. metrics.ObserveAPICall(constants.ProviderKubernetes, constants.CallKubernetesCreateSelfSubjectRulesReview, err)
  86. if err != nil {
  87. return esv1.ValidationResultUnknown, fmt.Errorf("could not verify if client is valid: %w", err)
  88. }
  89. for _, rev := range authReview.Status.ResourceRules {
  90. if (slices.Contains(rev.Resources, "secrets") || slices.Contains(rev.Resources, "*")) &&
  91. (slices.Contains(rev.Verbs, "get") || slices.Contains(rev.Verbs, "*")) &&
  92. (len(rev.APIGroups) == 0 || (slices.Contains(rev.APIGroups, "") || slices.Contains(rev.APIGroups, "*"))) {
  93. return esv1.ValidationResultReady, nil
  94. }
  95. }
  96. a := authv1.SelfSubjectAccessReview{
  97. Spec: authv1.SelfSubjectAccessReviewSpec{
  98. ResourceAttributes: &authv1.ResourceAttributes{
  99. Resource: "secrets",
  100. Namespace: c.store.RemoteNamespace,
  101. Verb: "get",
  102. },
  103. },
  104. }
  105. accessReview, err := c.userAccessReviewClient.Create(ctx, &a, metav1.CreateOptions{})
  106. if err != nil {
  107. return esv1.ValidationResultUnknown, fmt.Errorf("could not verify if client is valid: %w", err)
  108. }
  109. if accessReview.Status.Allowed {
  110. return esv1.ValidationResultReady, nil
  111. }
  112. return esv1.ValidationResultError, errors.New("client is not allowed to get secrets")
  113. }