keyvault.go 32 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528529530531532533534535536537538539540541542543544545546547548549550551552553554555556557558559560561562563564565566567568569570571572573574575576577578579580581582583584585586587588589590591592593594595596597598599600601602603604605606607608609610611612613614615616617618619620621622623624625626627628629630631632633634635636637638639640641642643644645646647648649650651652653654655656657658659660661662663664665666667668669670671672673674675676677678679680681682683684685686687688689690691692693694695696697698699700701702703704705706707708709710711712713714715716717718719720721722723724725726727728729730731732733734735736737738739740741742743744745746747748749750751752753754755756757758759760761762763764765766767768769770771772773774775776777778779780781782783784785786787788789790791792793794795796797798799800801802803804805806807808809810811812813814815816817818819820821822823824825826827828829830831832833834835836837838839840841842843844845846847848849850851852853854855856857858859860861862863864865866867868869870871872873874875876877878879880881882883884885886887888889890891892893894895896897898899900901902903904905906907908909910911912913914915916917918919920921922923924925926927928929930931932933934935936937938939940941942943944945946947948949950951952953954955956957958959960961962963964965966967968969970971972973974975976977978979
  1. /*
  2. Licensed under the Apache License, Version 2.0 (the "License");
  3. you may not use this file except in compliance with the License.
  4. You may obtain a copy of the License at
  5. http://www.apache.org/licenses/LICENSE-2.0
  6. Unless required by applicable law or agreed to in writing, software
  7. distributed under the License is distributed on an "AS IS" BASIS,
  8. WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
  9. See the License for the specific language governing permissions and
  10. limitations under the License.
  11. */
  12. package keyvault
  13. import (
  14. "context"
  15. "crypto/x509"
  16. b64 "encoding/base64"
  17. "encoding/json"
  18. "encoding/pem"
  19. "errors"
  20. "fmt"
  21. "os"
  22. "path"
  23. "regexp"
  24. "strings"
  25. "github.com/Azure/azure-sdk-for-go/profiles/latest/keyvault/keyvault"
  26. "github.com/Azure/go-autorest/autorest"
  27. "github.com/Azure/go-autorest/autorest/adal"
  28. "github.com/Azure/go-autorest/autorest/azure"
  29. kvauth "github.com/Azure/go-autorest/autorest/azure/auth"
  30. "github.com/AzureAD/microsoft-authentication-library-for-go/apps/confidential"
  31. "github.com/lestrrat-go/jwx/jwk"
  32. "github.com/tidwall/gjson"
  33. "golang.org/x/crypto/pkcs12"
  34. "golang.org/x/crypto/sha3"
  35. authv1 "k8s.io/api/authentication/v1"
  36. corev1 "k8s.io/api/core/v1"
  37. metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
  38. "k8s.io/apimachinery/pkg/types"
  39. "k8s.io/client-go/kubernetes"
  40. kcorev1 "k8s.io/client-go/kubernetes/typed/core/v1"
  41. "k8s.io/utils/pointer"
  42. "sigs.k8s.io/controller-runtime/pkg/client"
  43. ctrlcfg "sigs.k8s.io/controller-runtime/pkg/client/config"
  44. esv1beta1 "github.com/external-secrets/external-secrets/apis/externalsecrets/v1beta1"
  45. smmeta "github.com/external-secrets/external-secrets/apis/meta/v1"
  46. "github.com/external-secrets/external-secrets/pkg/utils"
  47. )
  48. const (
  49. defaultObjType = "secret"
  50. objectTypeCert = "cert"
  51. objectTypeKey = "key"
  52. AzureDefaultAudience = "api://AzureADTokenExchange"
  53. AnnotationClientID = "azure.workload.identity/client-id"
  54. AnnotationTenantID = "azure.workload.identity/tenant-id"
  55. managerLabel = "external-secrets"
  56. errUnexpectedStoreSpec = "unexpected store spec"
  57. errMissingAuthType = "cannot initialize Azure Client: no valid authType was specified"
  58. errPropNotExist = "property %s does not exist in key %s"
  59. errTagNotExist = "tag %s does not exist"
  60. errUnknownObjectType = "unknown Azure Keyvault object Type for %s"
  61. errUnmarshalJSONData = "error unmarshalling json data: %w"
  62. errDataFromCert = "cannot get use dataFrom to get certificate secret"
  63. errDataFromKey = "cannot get use dataFrom to get key secret"
  64. errMissingTenant = "missing tenantID in store config"
  65. errMissingSecretRef = "missing secretRef in provider config"
  66. errMissingClientIDSecret = "missing accessKeyID/secretAccessKey in store config"
  67. errFindSecret = "could not find secret %s/%s: %w"
  68. errFindDataKey = "no data for %q in secret '%s/%s'"
  69. errInvalidStore = "invalid store"
  70. errInvalidStoreSpec = "invalid store spec"
  71. errInvalidStoreProv = "invalid store provider"
  72. errInvalidAzureProv = "invalid azure keyvault provider"
  73. errInvalidSecRefClientID = "invalid AuthSecretRef.ClientID: %w"
  74. errInvalidSecRefClientSecret = "invalid AuthSecretRef.ClientSecret: %w"
  75. errInvalidSARef = "invalid ServiceAccountRef: %w"
  76. errMissingWorkloadEnvVars = "missing environment variables. AZURE_CLIENT_ID, AZURE_TENANT_ID and AZURE_FEDERATED_TOKEN_FILE must be set"
  77. errReadTokenFile = "unable to read token file %s: %w"
  78. errMissingSAAnnotation = "missing service account annotation: %s"
  79. )
  80. // https://github.com/external-secrets/external-secrets/issues/644
  81. var _ esv1beta1.SecretsClient = &Azure{}
  82. var _ esv1beta1.Provider = &Azure{}
  83. // interface to keyvault.BaseClient.
  84. type SecretClient interface {
  85. GetKey(ctx context.Context, vaultBaseURL string, keyName string, keyVersion string) (result keyvault.KeyBundle, err error)
  86. GetSecret(ctx context.Context, vaultBaseURL string, secretName string, secretVersion string) (result keyvault.SecretBundle, err error)
  87. GetSecretsComplete(ctx context.Context, vaultBaseURL string, maxresults *int32) (result keyvault.SecretListResultIterator, err error)
  88. GetCertificate(ctx context.Context, vaultBaseURL string, certificateName string, certificateVersion string) (result keyvault.CertificateBundle, err error)
  89. SetSecret(ctx context.Context, vaultBaseURL string, secretName string, parameters keyvault.SecretSetParameters) (result keyvault.SecretBundle, err error)
  90. ImportKey(ctx context.Context, vaultBaseURL string, keyName string, parameters keyvault.KeyImportParameters) (result keyvault.KeyBundle, err error)
  91. ImportCertificate(ctx context.Context, vaultBaseURL string, certificateName string, parameters keyvault.CertificateImportParameters) (result keyvault.CertificateBundle, err error)
  92. DeleteCertificate(ctx context.Context, vaultBaseURL string, certificateName string) (result keyvault.DeletedCertificateBundle, err error)
  93. DeleteKey(ctx context.Context, vaultBaseURL string, keyName string) (result keyvault.DeletedKeyBundle, err error)
  94. DeleteSecret(ctx context.Context, vaultBaseURL string, secretName string) (result keyvault.DeletedSecretBundle, err error)
  95. }
  96. type Azure struct {
  97. crClient client.Client
  98. kubeClient kcorev1.CoreV1Interface
  99. store esv1beta1.GenericStore
  100. provider *esv1beta1.AzureKVProvider
  101. baseClient SecretClient
  102. namespace string
  103. }
  104. func init() {
  105. esv1beta1.Register(&Azure{}, &esv1beta1.SecretStoreProvider{
  106. AzureKV: &esv1beta1.AzureKVProvider{},
  107. })
  108. }
  109. // Capabilities return the provider supported capabilities (ReadOnly, WriteOnly, ReadWrite).
  110. func (a *Azure) Capabilities() esv1beta1.SecretStoreCapabilities {
  111. return esv1beta1.SecretStoreReadOnly
  112. }
  113. // NewClient constructs a new secrets client based on the provided store.
  114. func (a *Azure) NewClient(ctx context.Context, store esv1beta1.GenericStore, kube client.Client, namespace string) (esv1beta1.SecretsClient, error) {
  115. return newClient(ctx, store, kube, namespace)
  116. }
  117. func newClient(ctx context.Context, store esv1beta1.GenericStore, kube client.Client, namespace string) (esv1beta1.SecretsClient, error) {
  118. provider, err := getProvider(store)
  119. if err != nil {
  120. return nil, err
  121. }
  122. cfg, err := ctrlcfg.GetConfig()
  123. if err != nil {
  124. return nil, err
  125. }
  126. kubeClient, err := kubernetes.NewForConfig(cfg)
  127. if err != nil {
  128. return nil, err
  129. }
  130. az := &Azure{
  131. crClient: kube,
  132. kubeClient: kubeClient.CoreV1(),
  133. store: store,
  134. namespace: namespace,
  135. provider: provider,
  136. }
  137. // allow SecretStore controller validation to pass
  138. // when using referent namespace.
  139. if store.GetKind() == esv1beta1.ClusterSecretStoreKind &&
  140. namespace == "" &&
  141. isReferentSpec(provider) {
  142. return az, nil
  143. }
  144. var authorizer autorest.Authorizer
  145. switch *provider.AuthType {
  146. case esv1beta1.AzureManagedIdentity:
  147. authorizer, err = az.authorizerForManagedIdentity()
  148. case esv1beta1.AzureServicePrincipal:
  149. authorizer, err = az.authorizerForServicePrincipal(ctx)
  150. case esv1beta1.AzureWorkloadIdentity:
  151. authorizer, err = az.authorizerForWorkloadIdentity(ctx, NewTokenProvider)
  152. default:
  153. err = fmt.Errorf(errMissingAuthType)
  154. }
  155. cl := keyvault.New()
  156. cl.Authorizer = authorizer
  157. az.baseClient = &cl
  158. return az, err
  159. }
  160. func getProvider(store esv1beta1.GenericStore) (*esv1beta1.AzureKVProvider, error) {
  161. spc := store.GetSpec()
  162. if spc == nil || spc.Provider.AzureKV == nil {
  163. return nil, errors.New(errUnexpectedStoreSpec)
  164. }
  165. return spc.Provider.AzureKV, nil
  166. }
  167. func (a *Azure) ValidateStore(store esv1beta1.GenericStore) error {
  168. if store == nil {
  169. return fmt.Errorf(errInvalidStore)
  170. }
  171. spc := store.GetSpec()
  172. if spc == nil {
  173. return fmt.Errorf(errInvalidStoreSpec)
  174. }
  175. if spc.Provider == nil {
  176. return fmt.Errorf(errInvalidStoreProv)
  177. }
  178. p := spc.Provider.AzureKV
  179. if p == nil {
  180. return fmt.Errorf(errInvalidAzureProv)
  181. }
  182. if p.AuthSecretRef != nil {
  183. if p.AuthSecretRef.ClientID != nil {
  184. if err := utils.ValidateReferentSecretSelector(store, *p.AuthSecretRef.ClientID); err != nil {
  185. return fmt.Errorf(errInvalidSecRefClientID, err)
  186. }
  187. }
  188. if p.AuthSecretRef.ClientSecret != nil {
  189. if err := utils.ValidateReferentSecretSelector(store, *p.AuthSecretRef.ClientSecret); err != nil {
  190. return fmt.Errorf(errInvalidSecRefClientSecret, err)
  191. }
  192. }
  193. }
  194. if p.ServiceAccountRef != nil {
  195. if err := utils.ValidateReferentServiceAccountSelector(store, *p.ServiceAccountRef); err != nil {
  196. return fmt.Errorf(errInvalidSARef, err)
  197. }
  198. }
  199. return nil
  200. }
  201. func canDelete(tags map[string]*string, err error) (bool, error) {
  202. aerr := &autorest.DetailedError{}
  203. conv := errors.As(err, aerr)
  204. if err != nil && !conv {
  205. return false, fmt.Errorf("could not parse error: %w", err)
  206. }
  207. if conv && aerr.StatusCode != 404 { // Secret is already deleted, nothing to do.
  208. return false, fmt.Errorf("unexpected api error: %w", err)
  209. }
  210. if aerr.StatusCode == 404 {
  211. return false, nil
  212. }
  213. manager, ok := tags["managed-by"]
  214. if !ok || manager == nil || *manager != managerLabel {
  215. return false, fmt.Errorf("not managed by external-secrets")
  216. }
  217. return true, nil
  218. }
  219. func (a *Azure) deleteKeyVaultKey(ctx context.Context, keyName string) error {
  220. value, err := a.baseClient.GetKey(ctx, *a.provider.VaultURL, keyName, "")
  221. ok, err := canDelete(value.Tags, err)
  222. if err != nil {
  223. return fmt.Errorf("error getting key %v: %w", keyName, err)
  224. }
  225. if ok {
  226. _, err = a.baseClient.DeleteKey(ctx, *a.provider.VaultURL, keyName)
  227. if err != nil {
  228. return fmt.Errorf("error deleting key %v: %w", keyName, err)
  229. }
  230. }
  231. return nil
  232. }
  233. func (a *Azure) deleteKeyVaultSecret(ctx context.Context, secretName string) error {
  234. value, err := a.baseClient.GetSecret(ctx, *a.provider.VaultURL, secretName, "")
  235. ok, err := canDelete(value.Tags, err)
  236. if err != nil {
  237. return fmt.Errorf("error getting secret %v: %w", secretName, err)
  238. }
  239. if ok {
  240. _, err = a.baseClient.DeleteSecret(ctx, *a.provider.VaultURL, secretName)
  241. if err != nil {
  242. return fmt.Errorf("error deleting secret %v: %w", secretName, err)
  243. }
  244. }
  245. return nil
  246. }
  247. func (a *Azure) deleteKeyVaultCertificate(ctx context.Context, certName string) error {
  248. value, err := a.baseClient.GetCertificate(ctx, *a.provider.VaultURL, certName, "")
  249. ok, err := canDelete(value.Tags, err)
  250. if err != nil {
  251. return fmt.Errorf("error getting certificate %v: %w", certName, err)
  252. }
  253. if ok {
  254. _, err = a.baseClient.DeleteCertificate(ctx, *a.provider.VaultURL, certName)
  255. if err != nil {
  256. return fmt.Errorf("error deleting certificate %v: %w", certName, err)
  257. }
  258. }
  259. return nil
  260. }
  261. func (a *Azure) DeleteSecret(ctx context.Context, remoteRef esv1beta1.PushRemoteRef) error {
  262. objectType, secretName := getObjType(esv1beta1.ExternalSecretDataRemoteRef{Key: remoteRef.GetRemoteKey()})
  263. switch objectType {
  264. case defaultObjType:
  265. return a.deleteKeyVaultSecret(ctx, secretName)
  266. case objectTypeCert:
  267. return a.deleteKeyVaultCertificate(ctx, secretName)
  268. case objectTypeKey:
  269. return a.deleteKeyVaultKey(ctx, secretName)
  270. default:
  271. return fmt.Errorf("secret type '%v' is not supported", objectType)
  272. }
  273. }
  274. func getCertificateFromValue(value []byte) (*x509.Certificate, error) {
  275. _, localCert, err := pkcs12.Decode(value, "")
  276. if err != nil {
  277. pemBlock, _ := pem.Decode(value)
  278. if pemBlock == nil {
  279. return x509.ParseCertificate(value)
  280. }
  281. return x509.ParseCertificate(pemBlock.Bytes)
  282. }
  283. return localCert, err
  284. }
  285. func getKeyFromValue(value []byte) (interface{}, error) {
  286. val := value
  287. pemBlock, _ := pem.Decode(value)
  288. // if a private key regular expression doesn't match, we should consider this key to be symmetric
  289. if pemBlock == nil {
  290. return val, nil
  291. }
  292. val = pemBlock.Bytes
  293. switch pemBlock.Type {
  294. case "PRIVATE KEY":
  295. return x509.ParsePKCS8PrivateKey(val)
  296. case "RSA PRIVATE KEY":
  297. return x509.ParsePKCS1PrivateKey(val)
  298. case "EC PRIVATE KEY":
  299. return x509.ParseECPrivateKey(val)
  300. default:
  301. return nil, fmt.Errorf("key type %v is not supported", pemBlock.Type)
  302. }
  303. }
  304. func canCreate(tags map[string]*string, err error) (bool, error) {
  305. aerr := &autorest.DetailedError{}
  306. conv := errors.As(err, aerr)
  307. if err != nil && !conv {
  308. return false, fmt.Errorf("could not parse error: %w", err)
  309. }
  310. if conv && aerr.StatusCode != 404 {
  311. return false, fmt.Errorf("unexpected api error: %w", err)
  312. }
  313. if err == nil {
  314. manager, ok := tags["managed-by"]
  315. if !ok || manager == nil || *manager != managerLabel {
  316. return false, fmt.Errorf("not managed by external-secrets")
  317. }
  318. }
  319. return true, nil
  320. }
  321. func (a *Azure) setKeyVaultSecret(ctx context.Context, secretName string, value []byte) error {
  322. secret, err := a.baseClient.GetSecret(ctx, *a.provider.VaultURL, secretName, "")
  323. ok, err := canCreate(secret.Tags, err)
  324. if err != nil {
  325. return fmt.Errorf("cannot get secret %v: %w", secretName, err)
  326. }
  327. if !ok {
  328. return nil
  329. }
  330. val := string(value)
  331. if secret.Value != nil && val == *secret.Value {
  332. return nil
  333. }
  334. secretParams := keyvault.SecretSetParameters{
  335. Value: &val,
  336. Tags: map[string]*string{
  337. "managed-by": pointer.String(managerLabel),
  338. },
  339. SecretAttributes: &keyvault.SecretAttributes{
  340. Enabled: pointer.Bool(true),
  341. },
  342. }
  343. _, err = a.baseClient.SetSecret(ctx, *a.provider.VaultURL, secretName, secretParams)
  344. if err != nil {
  345. return fmt.Errorf("could not set secret %v: %w", secretName, err)
  346. }
  347. return nil
  348. }
  349. func (a *Azure) setKeyVaultCertificate(ctx context.Context, secretName string, value []byte) error {
  350. val := b64.StdEncoding.EncodeToString(value)
  351. localCert, err := getCertificateFromValue(value)
  352. if err != nil {
  353. return fmt.Errorf("value from secret is not a valid certificate: %w", err)
  354. }
  355. cert, err := a.baseClient.GetCertificate(ctx, *a.provider.VaultURL, secretName, "")
  356. ok, err := canCreate(cert.Tags, err)
  357. if err != nil {
  358. return fmt.Errorf("cannot get certificate %v: %w", secretName, err)
  359. }
  360. if !ok {
  361. return nil
  362. }
  363. b512 := sha3.Sum512(localCert.Raw)
  364. if cert.Cer != nil && b512 == sha3.Sum512(*cert.Cer) {
  365. return nil
  366. }
  367. params := keyvault.CertificateImportParameters{
  368. Base64EncodedCertificate: &val,
  369. Tags: map[string]*string{
  370. "managed-by": pointer.String(managerLabel),
  371. },
  372. }
  373. _, err = a.baseClient.ImportCertificate(ctx, *a.provider.VaultURL, secretName, params)
  374. if err != nil {
  375. return fmt.Errorf("could not import certificate %v: %w", secretName, err)
  376. }
  377. return nil
  378. }
  379. func equalKeys(newKey, oldKey keyvault.JSONWebKey) bool {
  380. // checks for everything except KeyID and KeyOps
  381. rsaCheck := newKey.E != nil && oldKey.E != nil && *newKey.E == *oldKey.E &&
  382. newKey.N != nil && oldKey.N != nil && *newKey.N == *oldKey.N
  383. symmetricCheck := newKey.Crv == oldKey.Crv &&
  384. newKey.T != nil && oldKey.T != nil && *newKey.T == *oldKey.T &&
  385. newKey.X != nil && oldKey.X != nil && *newKey.X == *oldKey.X &&
  386. newKey.Y != nil && oldKey.Y != nil && *newKey.Y == *oldKey.Y
  387. return newKey.Kty == oldKey.Kty && (rsaCheck || symmetricCheck)
  388. }
  389. func (a *Azure) setKeyVaultKey(ctx context.Context, secretName string, value []byte) error {
  390. key, err := getKeyFromValue(value)
  391. if err != nil {
  392. return fmt.Errorf("could not load private key %v: %w", secretName, err)
  393. }
  394. jwKey, err := jwk.New(key)
  395. if err != nil {
  396. return fmt.Errorf("failed to generate a JWK from secret %v content: %w", secretName, err)
  397. }
  398. buf, err := json.Marshal(jwKey)
  399. if err != nil {
  400. return fmt.Errorf("error parsing key: %w", err)
  401. }
  402. azkey := keyvault.JSONWebKey{}
  403. err = json.Unmarshal(buf, &azkey)
  404. if err != nil {
  405. return fmt.Errorf("error unmarshalling key: %w", err)
  406. }
  407. keyFromVault, err := a.baseClient.GetKey(ctx, *a.provider.VaultURL, secretName, "")
  408. ok, err := canCreate(keyFromVault.Tags, err)
  409. if err != nil {
  410. return fmt.Errorf("cannot get key %v: %w", secretName, err)
  411. }
  412. if !ok {
  413. return nil
  414. }
  415. if keyFromVault.Key != nil && equalKeys(azkey, *keyFromVault.Key) {
  416. return nil
  417. }
  418. params := keyvault.KeyImportParameters{
  419. Key: &azkey,
  420. KeyAttributes: &keyvault.KeyAttributes{},
  421. Tags: map[string]*string{
  422. "managed-by": pointer.String(managerLabel),
  423. },
  424. }
  425. _, err = a.baseClient.ImportKey(ctx, *a.provider.VaultURL, secretName, params)
  426. if err != nil {
  427. return fmt.Errorf("could not import key %v: %w", secretName, err)
  428. }
  429. return nil
  430. }
  431. // PushSecret stores secrets into a Key vault instance.
  432. func (a *Azure) PushSecret(ctx context.Context, value []byte, remoteRef esv1beta1.PushRemoteRef) error {
  433. objectType, secretName := getObjType(esv1beta1.ExternalSecretDataRemoteRef{Key: remoteRef.GetRemoteKey()})
  434. switch objectType {
  435. case defaultObjType:
  436. return a.setKeyVaultSecret(ctx, secretName, value)
  437. case objectTypeCert:
  438. return a.setKeyVaultCertificate(ctx, secretName, value)
  439. case objectTypeKey:
  440. return a.setKeyVaultKey(ctx, secretName, value)
  441. default:
  442. return fmt.Errorf("secret type %v not supported", objectType)
  443. }
  444. }
  445. // Implements store.Client.GetAllSecrets Interface.
  446. // Retrieves a map[string][]byte with the secret names as key and the secret itself as the calue.
  447. func (a *Azure) GetAllSecrets(ctx context.Context, ref esv1beta1.ExternalSecretFind) (map[string][]byte, error) {
  448. basicClient := a.baseClient
  449. secretsMap := make(map[string][]byte)
  450. checkTags := len(ref.Tags) > 0
  451. checkName := ref.Name != nil && len(ref.Name.RegExp) > 0
  452. secretListIter, err := basicClient.GetSecretsComplete(context.Background(), *a.provider.VaultURL, nil)
  453. if err != nil {
  454. return nil, err
  455. }
  456. for secretListIter.NotDone() {
  457. secretList := secretListIter.Response().Value
  458. for _, secret := range *secretList {
  459. ok, secretName := isValidSecret(checkTags, checkName, ref, secret)
  460. if !ok {
  461. continue
  462. }
  463. secretResp, err := basicClient.GetSecret(context.Background(), *a.provider.VaultURL, secretName, "")
  464. if err != nil {
  465. return nil, err
  466. }
  467. secretValue := *secretResp.Value
  468. secretsMap[secretName] = []byte(secretValue)
  469. }
  470. err = secretListIter.Next()
  471. if err != nil {
  472. return nil, err
  473. }
  474. }
  475. return secretsMap, nil
  476. }
  477. // Retrieves a tag value if specified and all tags in JSON format if not.
  478. func getSecretTag(tags map[string]*string, property string) ([]byte, error) {
  479. if property == "" {
  480. secretTagsData := make(map[string]string)
  481. for k, v := range tags {
  482. secretTagsData[k] = *v
  483. }
  484. return json.Marshal(secretTagsData)
  485. }
  486. if val, exist := tags[property]; exist {
  487. return []byte(*val), nil
  488. }
  489. idx := strings.Index(property, ".")
  490. if idx < 0 {
  491. return nil, fmt.Errorf(errTagNotExist, property)
  492. }
  493. if idx > 0 {
  494. tagName := property[0:idx]
  495. if val, exist := tags[tagName]; exist {
  496. key := strings.Replace(property, tagName+".", "", 1)
  497. return getProperty(*val, key, property)
  498. }
  499. }
  500. return nil, fmt.Errorf(errTagNotExist, property)
  501. }
  502. // Retrieves a property value if specified and the secret value if not.
  503. func getProperty(secret, property, key string) ([]byte, error) {
  504. if property == "" {
  505. return []byte(secret), nil
  506. }
  507. res := gjson.Get(secret, property)
  508. if !res.Exists() {
  509. idx := strings.Index(property, ".")
  510. if idx < 0 {
  511. return nil, fmt.Errorf(errPropNotExist, property, key)
  512. }
  513. escaped := strings.ReplaceAll(property, ".", "\\.")
  514. jValue := gjson.Get(secret, escaped)
  515. if jValue.Exists() {
  516. return []byte(jValue.String()), nil
  517. }
  518. return nil, fmt.Errorf(errPropNotExist, property, key)
  519. }
  520. return []byte(res.String()), nil
  521. }
  522. // Implements store.Client.GetSecret Interface.
  523. // Retrieves a secret/Key/Certificate/Tag with the secret name defined in ref.Name
  524. // The Object Type is defined as a prefix in the ref.Name , if no prefix is defined , we assume a secret is required.
  525. func (a *Azure) GetSecret(ctx context.Context, ref esv1beta1.ExternalSecretDataRemoteRef) ([]byte, error) {
  526. objectType, secretName := getObjType(ref)
  527. switch objectType {
  528. case defaultObjType:
  529. // returns a SecretBundle with the secret value
  530. // https://pkg.go.dev/github.com/Azure/azure-sdk-for-go/services/keyvault/v7.0/keyvault#SecretBundle
  531. secretResp, err := a.baseClient.GetSecret(context.Background(), *a.provider.VaultURL, secretName, ref.Version)
  532. if err != nil {
  533. return nil, err
  534. }
  535. if ref.MetadataPolicy == esv1beta1.ExternalSecretMetadataPolicyFetch {
  536. return getSecretTag(secretResp.Tags, ref.Property)
  537. }
  538. return getProperty(*secretResp.Value, ref.Property, ref.Key)
  539. case objectTypeCert:
  540. // returns a CertBundle. We return CER contents of x509 certificate
  541. // see: https://pkg.go.dev/github.com/Azure/azure-sdk-for-go/services/keyvault/v7.0/keyvault#CertificateBundle
  542. certResp, err := a.baseClient.GetCertificate(context.Background(), *a.provider.VaultURL, secretName, ref.Version)
  543. if err != nil {
  544. return nil, err
  545. }
  546. if ref.MetadataPolicy == esv1beta1.ExternalSecretMetadataPolicyFetch {
  547. return getSecretTag(certResp.Tags, ref.Property)
  548. }
  549. return *certResp.Cer, nil
  550. case objectTypeKey:
  551. // returns a KeyBundle that contains a jwk
  552. // azure kv returns only public keys
  553. // see: https://pkg.go.dev/github.com/Azure/azure-sdk-for-go/services/keyvault/v7.0/keyvault#KeyBundle
  554. keyResp, err := a.baseClient.GetKey(context.Background(), *a.provider.VaultURL, secretName, ref.Version)
  555. if err != nil {
  556. return nil, err
  557. }
  558. if ref.MetadataPolicy == esv1beta1.ExternalSecretMetadataPolicyFetch {
  559. return getSecretTag(keyResp.Tags, ref.Property)
  560. }
  561. return json.Marshal(keyResp.Key)
  562. }
  563. return nil, fmt.Errorf(errUnknownObjectType, secretName)
  564. }
  565. // returns a SecretBundle with the tags values.
  566. func (a *Azure) getSecretTags(ref esv1beta1.ExternalSecretDataRemoteRef) (map[string]*string, error) {
  567. _, secretName := getObjType(ref)
  568. secretResp, err := a.baseClient.GetSecret(context.Background(), *a.provider.VaultURL, secretName, ref.Version)
  569. if err != nil {
  570. return nil, err
  571. }
  572. secretTagsData := make(map[string]*string)
  573. for tagname, tagval := range secretResp.Tags {
  574. name := secretName + "_" + tagname
  575. kv := make(map[string]string)
  576. err = json.Unmarshal([]byte(*tagval), &kv)
  577. // if the tagvalue is not in JSON format then we added to secretTagsData we added as it is
  578. if err != nil {
  579. secretTagsData[name] = tagval
  580. } else {
  581. for k, v := range kv {
  582. value := v
  583. secretTagsData[name+"_"+k] = &value
  584. }
  585. }
  586. }
  587. return secretTagsData, nil
  588. }
  589. // Implements store.Client.GetSecretMap Interface.
  590. // New version of GetSecretMap.
  591. func (a *Azure) GetSecretMap(ctx context.Context, ref esv1beta1.ExternalSecretDataRemoteRef) (map[string][]byte, error) {
  592. objectType, secretName := getObjType(ref)
  593. switch objectType {
  594. case defaultObjType:
  595. data, err := a.GetSecret(ctx, ref)
  596. if err != nil {
  597. return nil, err
  598. }
  599. if ref.MetadataPolicy == esv1beta1.ExternalSecretMetadataPolicyFetch {
  600. tags, _ := a.getSecretTags(ref)
  601. return getSecretMapProperties(tags, ref.Key, ref.Property), nil
  602. }
  603. return getSecretMapMap(data)
  604. case objectTypeCert:
  605. return nil, fmt.Errorf(errDataFromCert)
  606. case objectTypeKey:
  607. return nil, fmt.Errorf(errDataFromKey)
  608. }
  609. return nil, fmt.Errorf(errUnknownObjectType, secretName)
  610. }
  611. func getSecretMapMap(data []byte) (map[string][]byte, error) {
  612. kv := make(map[string]json.RawMessage)
  613. err := json.Unmarshal(data, &kv)
  614. if err != nil {
  615. return nil, fmt.Errorf(errUnmarshalJSONData, err)
  616. }
  617. secretData := make(map[string][]byte)
  618. for k, v := range kv {
  619. var strVal string
  620. err = json.Unmarshal(v, &strVal)
  621. if err == nil {
  622. secretData[k] = []byte(strVal)
  623. } else {
  624. secretData[k] = v
  625. }
  626. }
  627. return secretData, nil
  628. }
  629. func getSecretMapProperties(tags map[string]*string, key, property string) map[string][]byte {
  630. tagByteArray := make(map[string][]byte)
  631. if property != "" {
  632. keyPropertyName := key + "_" + property
  633. singleTag, _ := getSecretTag(tags, keyPropertyName)
  634. tagByteArray[keyPropertyName] = singleTag
  635. return tagByteArray
  636. }
  637. for k, v := range tags {
  638. tagByteArray[k] = []byte(*v)
  639. }
  640. return tagByteArray
  641. }
  642. func (a *Azure) authorizerForWorkloadIdentity(ctx context.Context, tokenProvider tokenProviderFunc) (autorest.Authorizer, error) {
  643. aadEndpoint := AadEndpointForType(a.provider.EnvironmentType)
  644. kvResource := kvResourceForProviderConfig(a.provider.EnvironmentType)
  645. // if no serviceAccountRef was provided
  646. // we expect certain env vars to be present.
  647. // They are set by the azure workload identity webhook.
  648. if a.provider.ServiceAccountRef == nil {
  649. clientID := os.Getenv("AZURE_CLIENT_ID")
  650. tenantID := os.Getenv("AZURE_TENANT_ID")
  651. tokenFilePath := os.Getenv("AZURE_FEDERATED_TOKEN_FILE")
  652. if clientID == "" || tenantID == "" || tokenFilePath == "" {
  653. return nil, errors.New(errMissingWorkloadEnvVars)
  654. }
  655. token, err := os.ReadFile(tokenFilePath)
  656. if err != nil {
  657. return nil, fmt.Errorf(errReadTokenFile, tokenFilePath, err)
  658. }
  659. tp, err := tokenProvider(ctx, string(token), clientID, tenantID, aadEndpoint, kvResource)
  660. if err != nil {
  661. return nil, err
  662. }
  663. return autorest.NewBearerAuthorizer(tp), nil
  664. }
  665. ns := a.namespace
  666. if a.store.GetKind() == esv1beta1.ClusterSecretStoreKind && a.provider.ServiceAccountRef.Namespace != nil {
  667. ns = *a.provider.ServiceAccountRef.Namespace
  668. }
  669. var sa corev1.ServiceAccount
  670. err := a.crClient.Get(ctx, types.NamespacedName{
  671. Name: a.provider.ServiceAccountRef.Name,
  672. Namespace: ns,
  673. }, &sa)
  674. if err != nil {
  675. return nil, err
  676. }
  677. clientID, ok := sa.ObjectMeta.Annotations[AnnotationClientID]
  678. if !ok {
  679. return nil, fmt.Errorf(errMissingSAAnnotation, AnnotationClientID)
  680. }
  681. tenantID, ok := sa.ObjectMeta.Annotations[AnnotationTenantID]
  682. if !ok {
  683. return nil, fmt.Errorf(errMissingSAAnnotation, AnnotationTenantID)
  684. }
  685. audiences := []string{AzureDefaultAudience}
  686. if len(a.provider.ServiceAccountRef.Audiences) > 0 {
  687. audiences = append(audiences, a.provider.ServiceAccountRef.Audiences...)
  688. }
  689. token, err := FetchSAToken(ctx, ns, a.provider.ServiceAccountRef.Name, audiences, a.kubeClient)
  690. if err != nil {
  691. return nil, err
  692. }
  693. tp, err := tokenProvider(ctx, token, clientID, tenantID, aadEndpoint, kvResource)
  694. if err != nil {
  695. return nil, err
  696. }
  697. return autorest.NewBearerAuthorizer(tp), nil
  698. }
  699. func FetchSAToken(ctx context.Context, ns, name string, audiences []string, kubeClient kcorev1.CoreV1Interface) (string, error) {
  700. token, err := kubeClient.ServiceAccounts(ns).CreateToken(ctx, name, &authv1.TokenRequest{
  701. Spec: authv1.TokenRequestSpec{
  702. Audiences: audiences,
  703. },
  704. }, metav1.CreateOptions{})
  705. if err != nil {
  706. return "", err
  707. }
  708. return token.Status.Token, nil
  709. }
  710. // tokenProvider satisfies the adal.OAuthTokenProvider interface.
  711. type tokenProvider struct {
  712. accessToken string
  713. }
  714. type tokenProviderFunc func(ctx context.Context, token, clientID, tenantID, aadEndpoint, kvResource string) (adal.OAuthTokenProvider, error)
  715. func NewTokenProvider(ctx context.Context, token, clientID, tenantID, aadEndpoint, kvResource string) (adal.OAuthTokenProvider, error) {
  716. // exchange token with Azure AccessToken
  717. cred := confidential.NewCredFromAssertionCallback(func(ctx context.Context, aro confidential.AssertionRequestOptions) (string, error) {
  718. return token, nil
  719. })
  720. cClient, err := confidential.New(clientID, cred, confidential.WithAuthority(
  721. fmt.Sprintf("%s%s/oauth2/token", aadEndpoint, tenantID),
  722. ))
  723. if err != nil {
  724. return nil, err
  725. }
  726. scope := kvResource
  727. // .default needs to be added to the scope
  728. if !strings.Contains(kvResource, ".default") {
  729. scope = fmt.Sprintf("%s/.default", kvResource)
  730. }
  731. authRes, err := cClient.AcquireTokenByCredential(ctx, []string{
  732. scope,
  733. })
  734. if err != nil {
  735. return nil, err
  736. }
  737. return &tokenProvider{
  738. accessToken: authRes.AccessToken,
  739. }, nil
  740. }
  741. func (t *tokenProvider) OAuthToken() string {
  742. return t.accessToken
  743. }
  744. func (a *Azure) authorizerForManagedIdentity() (autorest.Authorizer, error) {
  745. msiConfig := kvauth.NewMSIConfig()
  746. msiConfig.Resource = kvResourceForProviderConfig(a.provider.EnvironmentType)
  747. if a.provider.IdentityID != nil {
  748. msiConfig.ClientID = *a.provider.IdentityID
  749. }
  750. return msiConfig.Authorizer()
  751. }
  752. func (a *Azure) authorizerForServicePrincipal(ctx context.Context) (autorest.Authorizer, error) {
  753. if a.provider.TenantID == nil {
  754. return nil, fmt.Errorf(errMissingTenant)
  755. }
  756. if a.provider.AuthSecretRef == nil {
  757. return nil, fmt.Errorf(errMissingSecretRef)
  758. }
  759. if a.provider.AuthSecretRef.ClientID == nil || a.provider.AuthSecretRef.ClientSecret == nil {
  760. return nil, fmt.Errorf(errMissingClientIDSecret)
  761. }
  762. clusterScoped := false
  763. if a.store.GetKind() == esv1beta1.ClusterSecretStoreKind {
  764. clusterScoped = true
  765. }
  766. cid, err := a.secretKeyRef(ctx, a.namespace, *a.provider.AuthSecretRef.ClientID, clusterScoped)
  767. if err != nil {
  768. return nil, err
  769. }
  770. csec, err := a.secretKeyRef(ctx, a.namespace, *a.provider.AuthSecretRef.ClientSecret, clusterScoped)
  771. if err != nil {
  772. return nil, err
  773. }
  774. clientCredentialsConfig := kvauth.NewClientCredentialsConfig(cid, csec, *a.provider.TenantID)
  775. clientCredentialsConfig.Resource = kvResourceForProviderConfig(a.provider.EnvironmentType)
  776. clientCredentialsConfig.AADEndpoint = AadEndpointForType(a.provider.EnvironmentType)
  777. return clientCredentialsConfig.Authorizer()
  778. }
  779. // secretKeyRef fetch a secret key.
  780. func (a *Azure) secretKeyRef(ctx context.Context, namespace string, secretRef smmeta.SecretKeySelector, clusterScoped bool) (string, error) {
  781. var secret corev1.Secret
  782. ref := types.NamespacedName{
  783. Name: secretRef.Name,
  784. Namespace: namespace,
  785. }
  786. if clusterScoped && secretRef.Namespace != nil {
  787. ref.Namespace = *secretRef.Namespace
  788. }
  789. err := a.crClient.Get(ctx, ref, &secret)
  790. if err != nil {
  791. return "", fmt.Errorf(errFindSecret, ref.Namespace, ref.Name, err)
  792. }
  793. keyBytes, ok := secret.Data[secretRef.Key]
  794. if !ok {
  795. return "", fmt.Errorf(errFindDataKey, secretRef.Key, secretRef.Name, namespace)
  796. }
  797. value := strings.TrimSpace(string(keyBytes))
  798. return value, nil
  799. }
  800. func (a *Azure) Close(ctx context.Context) error {
  801. return nil
  802. }
  803. func (a *Azure) Validate() (esv1beta1.ValidationResult, error) {
  804. if a.store.GetKind() == esv1beta1.ClusterSecretStoreKind && isReferentSpec(a.provider) {
  805. return esv1beta1.ValidationResultUnknown, nil
  806. }
  807. return esv1beta1.ValidationResultReady, nil
  808. }
  809. func isReferentSpec(prov *esv1beta1.AzureKVProvider) bool {
  810. if prov.AuthSecretRef != nil &&
  811. ((prov.AuthSecretRef.ClientID != nil &&
  812. prov.AuthSecretRef.ClientID.Namespace == nil) ||
  813. (prov.AuthSecretRef.ClientSecret != nil &&
  814. prov.AuthSecretRef.ClientSecret.Namespace == nil)) {
  815. return true
  816. }
  817. if prov.ServiceAccountRef != nil &&
  818. prov.ServiceAccountRef.Namespace == nil {
  819. return true
  820. }
  821. return false
  822. }
  823. func AadEndpointForType(t esv1beta1.AzureEnvironmentType) string {
  824. switch t {
  825. case esv1beta1.AzureEnvironmentPublicCloud:
  826. return azure.PublicCloud.ActiveDirectoryEndpoint
  827. case esv1beta1.AzureEnvironmentChinaCloud:
  828. return azure.ChinaCloud.ActiveDirectoryEndpoint
  829. case esv1beta1.AzureEnvironmentUSGovernmentCloud:
  830. return azure.USGovernmentCloud.ActiveDirectoryEndpoint
  831. case esv1beta1.AzureEnvironmentGermanCloud:
  832. return azure.GermanCloud.ActiveDirectoryEndpoint
  833. default:
  834. return azure.PublicCloud.ActiveDirectoryEndpoint
  835. }
  836. }
  837. func kvResourceForProviderConfig(t esv1beta1.AzureEnvironmentType) string {
  838. var res string
  839. switch t {
  840. case esv1beta1.AzureEnvironmentPublicCloud:
  841. res = azure.PublicCloud.KeyVaultEndpoint
  842. case esv1beta1.AzureEnvironmentChinaCloud:
  843. res = azure.ChinaCloud.KeyVaultEndpoint
  844. case esv1beta1.AzureEnvironmentUSGovernmentCloud:
  845. res = azure.USGovernmentCloud.KeyVaultEndpoint
  846. case esv1beta1.AzureEnvironmentGermanCloud:
  847. res = azure.GermanCloud.KeyVaultEndpoint
  848. default:
  849. res = azure.PublicCloud.KeyVaultEndpoint
  850. }
  851. return strings.TrimSuffix(res, "/")
  852. }
  853. func getObjType(ref esv1beta1.ExternalSecretDataRemoteRef) (string, string) {
  854. objectType := defaultObjType
  855. secretName := ref.Key
  856. nameSplitted := strings.Split(secretName, "/")
  857. if len(nameSplitted) > 1 {
  858. objectType = nameSplitted[0]
  859. secretName = nameSplitted[1]
  860. // TODO: later tokens can be used to read the secret tags
  861. }
  862. return objectType, secretName
  863. }
  864. func isValidSecret(checkTags, checkName bool, ref esv1beta1.ExternalSecretFind, secret keyvault.SecretItem) (bool, string) {
  865. if secret.ID == nil || !*secret.Attributes.Enabled {
  866. return false, ""
  867. }
  868. if checkTags && !okByTags(ref, secret) {
  869. return false, ""
  870. }
  871. secretName := path.Base(*secret.ID)
  872. if checkName && !okByName(ref, secretName) {
  873. return false, ""
  874. }
  875. return true, secretName
  876. }
  877. func okByName(ref esv1beta1.ExternalSecretFind, secretName string) bool {
  878. matches, _ := regexp.MatchString(ref.Name.RegExp, secretName)
  879. return matches
  880. }
  881. func okByTags(ref esv1beta1.ExternalSecretFind, secret keyvault.SecretItem) bool {
  882. tagsFound := true
  883. for k, v := range ref.Tags {
  884. if val, ok := secret.Tags[k]; !ok || *val != v {
  885. tagsFound = false
  886. break
  887. }
  888. }
  889. return tagsFound
  890. }