externalsecret_controller.go 24 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528529530531532533534535536537538539540541542543544545546547548549550551552553554555556557558559560561562563564565566567568569570571572573574575576577578579580581582583584585586587588589590591592593594595596597598599600601602603604605606607608609610611612613614615616617618619620621622623624625626627628629630631632633634635636637638639640641642643644645646647648649650651652653654655656657658659660661662663664665666667668669670671672673674675676677678679680681682683684685686687688689690691692693694695696697698699
  1. /*
  2. Licensed under the Apache License, Version 2.0 (the "License");
  3. you may not use this file except in compliance with the License.
  4. You may obtain a copy of the License at
  5. http://www.apache.org/licenses/LICENSE-2.0
  6. Unless required by applicable law or agreed to in writing, software
  7. distributed under the License is distributed on an "AS IS" BASIS,
  8. WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
  9. See the License for the specific language governing permissions and
  10. limitations under the License.
  11. */
  12. package externalsecret
  13. import (
  14. "context"
  15. "encoding/json"
  16. "errors"
  17. "fmt"
  18. "maps"
  19. "slices"
  20. "strings"
  21. "time"
  22. "github.com/go-logr/logr"
  23. "github.com/prometheus/client_golang/prometheus"
  24. v1 "k8s.io/api/core/v1"
  25. "k8s.io/apimachinery/pkg/api/equality"
  26. apierrors "k8s.io/apimachinery/pkg/api/errors"
  27. metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
  28. "k8s.io/apimachinery/pkg/runtime"
  29. "k8s.io/apimachinery/pkg/types"
  30. "k8s.io/client-go/rest"
  31. "k8s.io/client-go/tools/record"
  32. ctrl "sigs.k8s.io/controller-runtime"
  33. "sigs.k8s.io/controller-runtime/pkg/builder"
  34. "sigs.k8s.io/controller-runtime/pkg/client"
  35. "sigs.k8s.io/controller-runtime/pkg/controller"
  36. "sigs.k8s.io/controller-runtime/pkg/controller/controllerutil"
  37. "sigs.k8s.io/controller-runtime/pkg/handler"
  38. "sigs.k8s.io/controller-runtime/pkg/predicate"
  39. "sigs.k8s.io/controller-runtime/pkg/reconcile"
  40. esv1beta1 "github.com/external-secrets/external-secrets/apis/externalsecrets/v1beta1"
  41. // Metrics.
  42. "github.com/external-secrets/external-secrets/pkg/controllers/externalsecret/esmetrics"
  43. ctrlmetrics "github.com/external-secrets/external-secrets/pkg/controllers/metrics"
  44. "github.com/external-secrets/external-secrets/pkg/utils"
  45. "github.com/external-secrets/external-secrets/pkg/utils/resolvers"
  46. // Loading registered generators.
  47. _ "github.com/external-secrets/external-secrets/pkg/generator/register"
  48. // Loading registered providers.
  49. _ "github.com/external-secrets/external-secrets/pkg/provider/register"
  50. )
  51. const (
  52. fieldOwnerTemplate = "externalsecrets.external-secrets.io/%v"
  53. errGetES = "could not get ExternalSecret"
  54. errConvert = "could not apply conversion strategy to keys: %v"
  55. errDecode = "could not apply decoding strategy to %v[%d]: %v"
  56. errGenerate = "could not generate [%d]: %w"
  57. errRewrite = "could not rewrite spec.dataFrom[%d]: %v"
  58. errInvalidKeys = "secret keys from spec.dataFrom.%v[%d] can only have alphanumeric,'-', '_' or '.' characters. Convert them using rewrite (https://external-secrets.io/latest/guides-datafrom-rewrite)"
  59. errUpdateSecret = "could not update Secret"
  60. errPatchStatus = "unable to patch status"
  61. errGetExistingSecret = "could not get existing secret: %w"
  62. errSetCtrlReference = "could not set ExternalSecret controller reference: %w"
  63. errFetchTplFrom = "error fetching templateFrom data: %w"
  64. errGetSecretData = "could not get secret data from provider"
  65. errDeleteSecret = "could not delete secret"
  66. errApplyTemplate = "could not apply template: %w"
  67. errExecTpl = "could not execute template: %w"
  68. errInvalidCreatePolicy = "invalid creationPolicy=%s. Can not delete secret i do not own"
  69. errPolicyMergeNotFound = "the desired secret %s was not found. With creationPolicy=Merge the secret won't be created"
  70. errPolicyMergeGetSecret = "unable to get secret %s: %w"
  71. errPolicyMergeMutate = "unable to mutate secret %s: %w"
  72. errPolicyMergePatch = "unable to patch secret %s: %w"
  73. )
  74. const externalSecretSecretNameKey = ".spec.target.name"
  75. // Reconciler reconciles a ExternalSecret object.
  76. type Reconciler struct {
  77. client.Client
  78. Log logr.Logger
  79. Scheme *runtime.Scheme
  80. RestConfig *rest.Config
  81. ControllerClass string
  82. RequeueInterval time.Duration
  83. ClusterSecretStoreEnabled bool
  84. EnableFloodGate bool
  85. recorder record.EventRecorder
  86. }
  87. // Reconcile implements the main reconciliation loop
  88. // for watched objects (ExternalSecret, ClusterSecretStore and SecretStore),
  89. // and updates/creates a Kubernetes secret based on them.
  90. func (r *Reconciler) Reconcile(ctx context.Context, req ctrl.Request) (ctrl.Result, error) {
  91. log := r.Log.WithValues("ExternalSecret", req.NamespacedName)
  92. resourceLabels := ctrlmetrics.RefineNonConditionMetricLabels(map[string]string{"name": req.Name, "namespace": req.Namespace})
  93. start := time.Now()
  94. syncCallsError := esmetrics.GetCounterVec(esmetrics.SyncCallsErrorKey)
  95. // use closures to dynamically update resourceLabels
  96. defer func() {
  97. esmetrics.GetGaugeVec(esmetrics.ExternalSecretReconcileDurationKey).With(resourceLabels).Set(float64(time.Since(start)))
  98. esmetrics.GetCounterVec(esmetrics.SyncCallsKey).With(resourceLabels).Inc()
  99. }()
  100. var externalSecret esv1beta1.ExternalSecret
  101. err := r.Get(ctx, req.NamespacedName, &externalSecret)
  102. if err != nil {
  103. if apierrors.IsNotFound(err) {
  104. conditionSynced := NewExternalSecretCondition(esv1beta1.ExternalSecretDeleted, v1.ConditionFalse, esv1beta1.ConditionReasonSecretDeleted, "Secret was deleted")
  105. SetExternalSecretCondition(&esv1beta1.ExternalSecret{
  106. ObjectMeta: metav1.ObjectMeta{
  107. Name: req.Name,
  108. Namespace: req.Namespace,
  109. },
  110. }, *conditionSynced)
  111. return ctrl.Result{}, nil
  112. }
  113. log.Error(err, errGetES)
  114. syncCallsError.With(resourceLabels).Inc()
  115. return ctrl.Result{}, err
  116. }
  117. // See https://github.com/external-secrets/external-secrets/issues/3604
  118. // We fetch the ExternalSecret resource above, however the status subresource is inconsistent.
  119. // We have to explicitly fetch it, otherwise it may be missing and will cause
  120. // unexpected side effects.
  121. err = r.SubResource("status").Get(ctx, &externalSecret, &externalSecret)
  122. if err != nil {
  123. log.Error(err, "failed to get status subresource")
  124. return ctrl.Result{}, err
  125. }
  126. timeSinceLastRefresh := 0 * time.Second
  127. if !externalSecret.Status.RefreshTime.IsZero() {
  128. timeSinceLastRefresh = time.Since(externalSecret.Status.RefreshTime.Time)
  129. }
  130. // skip reconciliation if deletion timestamp is set on external secret
  131. if externalSecret.DeletionTimestamp != nil {
  132. log.Info("skipping as it is in deletion")
  133. return ctrl.Result{}, nil
  134. }
  135. // if extended metrics is enabled, refine the time series vector
  136. resourceLabels = ctrlmetrics.RefineLabels(resourceLabels, externalSecret.Labels)
  137. if shouldSkipClusterSecretStore(r, externalSecret) {
  138. log.Info("skipping cluster secret store as it is disabled")
  139. return ctrl.Result{}, nil
  140. }
  141. // skip when pointing to an unmanaged store
  142. skip, err := shouldSkipUnmanagedStore(ctx, req.Namespace, r, externalSecret)
  143. if skip {
  144. log.Info("skipping unmanaged store as it points to a unmanaged controllerClass")
  145. return ctrl.Result{}, nil
  146. }
  147. refreshInt := r.RequeueInterval
  148. if externalSecret.Spec.RefreshInterval != nil {
  149. refreshInt = externalSecret.Spec.RefreshInterval.Duration
  150. }
  151. // Target Secret Name should default to the ExternalSecret name if not explicitly specified
  152. secretName := externalSecret.Spec.Target.Name
  153. if secretName == "" {
  154. secretName = externalSecret.ObjectMeta.Name
  155. }
  156. // fetch external secret, we need to ensure that it exists, and it's hashmap corresponds
  157. var existingSecret v1.Secret
  158. err = r.Get(ctx, types.NamespacedName{
  159. Name: secretName,
  160. Namespace: externalSecret.Namespace,
  161. }, &existingSecret)
  162. if err != nil && !apierrors.IsNotFound(err) {
  163. log.Error(err, errGetExistingSecret)
  164. return ctrl.Result{}, err
  165. }
  166. // refresh should be skipped if
  167. // 1. resource generation hasn't changed
  168. // 2. refresh interval is 0
  169. // 3. if we're still within refresh-interval
  170. if !shouldRefresh(externalSecret) && isSecretValid(existingSecret) {
  171. refreshInt = (externalSecret.Spec.RefreshInterval.Duration - timeSinceLastRefresh) + 5*time.Second
  172. log.V(1).Info("skipping refresh", "rv", getResourceVersion(externalSecret), "nr", refreshInt.Seconds())
  173. return ctrl.Result{RequeueAfter: refreshInt}, nil
  174. }
  175. if !shouldReconcile(externalSecret) {
  176. log.V(1).Info("stopping reconciling", "rv", getResourceVersion(externalSecret))
  177. return ctrl.Result{}, nil
  178. }
  179. // patch status when done processing
  180. p := client.MergeFrom(externalSecret.DeepCopy())
  181. defer func() {
  182. err = r.Status().Patch(ctx, &externalSecret, p)
  183. if err != nil {
  184. log.Error(err, errPatchStatus)
  185. }
  186. }()
  187. secret := &v1.Secret{
  188. ObjectMeta: metav1.ObjectMeta{
  189. Name: secretName,
  190. Namespace: externalSecret.Namespace,
  191. },
  192. Immutable: &externalSecret.Spec.Target.Immutable,
  193. Data: make(map[string][]byte),
  194. }
  195. dataMap, err := r.getProviderSecretData(ctx, &externalSecret)
  196. if err != nil {
  197. r.markAsFailed(log, errGetSecretData, err, &externalSecret, syncCallsError.With(resourceLabels))
  198. return ctrl.Result{}, err
  199. }
  200. // secret data was not modified.
  201. if errors.Is(err, esv1beta1.NotModifiedErr) {
  202. log.Info("secret was not modified as a NotModified was returned by the provider")
  203. r.markAsDone(&externalSecret, start, log)
  204. return ctrl.Result{}, nil
  205. }
  206. // if no data was found we can delete the secret if needed.
  207. if len(dataMap) == 0 {
  208. switch externalSecret.Spec.Target.DeletionPolicy {
  209. // delete secret and return early.
  210. case esv1beta1.DeletionPolicyDelete:
  211. // safeguard that we only can delete secrets we own
  212. // this is also implemented in the es validation webhook
  213. if externalSecret.Spec.Target.CreationPolicy != esv1beta1.CreatePolicyOwner {
  214. err := fmt.Errorf(errInvalidCreatePolicy, externalSecret.Spec.Target.CreationPolicy)
  215. r.markAsFailed(log, errDeleteSecret, err, &externalSecret, syncCallsError.With(resourceLabels))
  216. return ctrl.Result{}, err
  217. }
  218. if err := r.Delete(ctx, secret); err != nil && !apierrors.IsNotFound(err) {
  219. r.markAsFailed(log, errDeleteSecret, err, &externalSecret, syncCallsError.With(resourceLabels))
  220. return ctrl.Result{}, err
  221. }
  222. conditionSynced := NewExternalSecretCondition(esv1beta1.ExternalSecretReady, v1.ConditionTrue, esv1beta1.ConditionReasonSecretDeleted, "secret deleted due to DeletionPolicy")
  223. SetExternalSecretCondition(&externalSecret, *conditionSynced)
  224. return ctrl.Result{RequeueAfter: refreshInt}, nil
  225. // In case provider secrets don't exist the kubernetes secret will be kept as-is.
  226. case esv1beta1.DeletionPolicyRetain:
  227. r.markAsDone(&externalSecret, start, log)
  228. return ctrl.Result{RequeueAfter: refreshInt}, nil
  229. // noop, handled below
  230. case esv1beta1.DeletionPolicyMerge:
  231. }
  232. }
  233. mutationFunc := func() error {
  234. if externalSecret.Spec.Target.CreationPolicy == esv1beta1.CreatePolicyOwner {
  235. err = controllerutil.SetControllerReference(&externalSecret, &secret.ObjectMeta, r.Scheme)
  236. if err != nil {
  237. return fmt.Errorf(errSetCtrlReference, err)
  238. }
  239. }
  240. if secret.Data == nil {
  241. secret.Data = make(map[string][]byte)
  242. }
  243. // diff existing keys
  244. keys, err := getManagedDataKeys(&existingSecret, externalSecret.Name)
  245. if err != nil {
  246. return err
  247. }
  248. // Sanitize data map for any updates on the ES
  249. for _, key := range keys {
  250. if dataMap[key] == nil {
  251. secret.Data[key] = nil
  252. // Sanitizing any templated / updated keys
  253. delete(secret.Data, key)
  254. }
  255. }
  256. err = r.applyTemplate(ctx, &externalSecret, secret, dataMap)
  257. if err != nil {
  258. return fmt.Errorf(errApplyTemplate, err)
  259. }
  260. if externalSecret.Spec.Target.CreationPolicy == esv1beta1.CreatePolicyOwner {
  261. lblValue := utils.ObjectHash(fmt.Sprintf("%v/%v", externalSecret.Namespace, externalSecret.Name))
  262. secret.Labels[esv1beta1.LabelOwner] = lblValue
  263. }
  264. secret.Annotations[esv1beta1.AnnotationDataHash] = r.computeDataHashAnnotation(&existingSecret, secret)
  265. return nil
  266. }
  267. switch externalSecret.Spec.Target.CreationPolicy { //nolint:exhaustive
  268. case esv1beta1.CreatePolicyMerge:
  269. err = r.patchSecret(ctx, secret, mutationFunc, &externalSecret)
  270. if err == nil {
  271. externalSecret.Status.Binding = v1.LocalObjectReference{Name: secret.Name}
  272. }
  273. case esv1beta1.CreatePolicyNone:
  274. log.V(1).Info("secret creation skipped due to creationPolicy=None")
  275. err = nil
  276. default:
  277. var created bool
  278. created, err = r.createOrUpdateSecret(ctx, secret, mutationFunc, &externalSecret)
  279. if err == nil {
  280. externalSecret.Status.Binding = v1.LocalObjectReference{Name: secret.Name}
  281. }
  282. // cleanup orphaned secrets
  283. if created {
  284. delErr := deleteOrphanedSecrets(ctx, r.Client, &externalSecret)
  285. if delErr != nil {
  286. msg := fmt.Sprintf("failed to clean up orphaned secrets: %v", delErr)
  287. r.markAsFailed(log, msg, delErr, &externalSecret, syncCallsError.With(resourceLabels))
  288. return ctrl.Result{}, delErr
  289. }
  290. }
  291. }
  292. if err != nil {
  293. r.markAsFailed(log, errUpdateSecret, err, &externalSecret, syncCallsError.With(resourceLabels))
  294. return ctrl.Result{}, err
  295. }
  296. r.markAsDone(&externalSecret, start, log)
  297. return ctrl.Result{
  298. RequeueAfter: refreshInt,
  299. }, nil
  300. }
  301. func (r *Reconciler) markAsDone(externalSecret *esv1beta1.ExternalSecret, start time.Time, log logr.Logger) {
  302. conditionSynced := NewExternalSecretCondition(esv1beta1.ExternalSecretReady, v1.ConditionTrue, esv1beta1.ConditionReasonSecretSynced, "Secret was synced")
  303. currCond := GetExternalSecretCondition(externalSecret.Status, esv1beta1.ExternalSecretReady)
  304. SetExternalSecretCondition(externalSecret, *conditionSynced)
  305. externalSecret.Status.RefreshTime = metav1.NewTime(start)
  306. externalSecret.Status.SyncedResourceVersion = getResourceVersion(*externalSecret)
  307. if currCond == nil || currCond.Status != conditionSynced.Status {
  308. log.Info("reconciled secret") // Log once if on success in any verbosity
  309. } else {
  310. log.V(1).Info("reconciled secret") // Log all reconciliation cycles if higher verbosity applied
  311. }
  312. }
  313. func (r *Reconciler) markAsFailed(log logr.Logger, msg string, err error, externalSecret *esv1beta1.ExternalSecret, counter prometheus.Counter) {
  314. log.Error(err, msg)
  315. r.recorder.Event(externalSecret, v1.EventTypeWarning, esv1beta1.ReasonUpdateFailed, err.Error())
  316. conditionSynced := NewExternalSecretCondition(esv1beta1.ExternalSecretReady, v1.ConditionFalse, esv1beta1.ConditionReasonSecretSyncedError, msg)
  317. SetExternalSecretCondition(externalSecret, *conditionSynced)
  318. counter.Inc()
  319. }
  320. func deleteOrphanedSecrets(ctx context.Context, cl client.Client, externalSecret *esv1beta1.ExternalSecret) error {
  321. secretList := v1.SecretList{}
  322. lblValue := utils.ObjectHash(fmt.Sprintf("%v/%v", externalSecret.Namespace, externalSecret.Name))
  323. ls := &metav1.LabelSelector{
  324. MatchLabels: map[string]string{
  325. esv1beta1.LabelOwner: lblValue,
  326. },
  327. }
  328. labelSelector, err := metav1.LabelSelectorAsSelector(ls)
  329. if err != nil {
  330. return err
  331. }
  332. err = cl.List(ctx, &secretList, &client.ListOptions{LabelSelector: labelSelector})
  333. if err != nil {
  334. return err
  335. }
  336. for key, secret := range secretList.Items {
  337. if externalSecret.Spec.Target.Name != "" && secret.Name != externalSecret.Spec.Target.Name {
  338. err = cl.Delete(ctx, &secretList.Items[key])
  339. if err != nil {
  340. return err
  341. }
  342. }
  343. }
  344. return nil
  345. }
  346. func (r *Reconciler) createOrUpdateSecret(ctx context.Context, secret *v1.Secret, mutationFunc func() error, es *esv1beta1.ExternalSecret) (bool, error) {
  347. fqdn := fmt.Sprintf(fieldOwnerTemplate, es.Name)
  348. key := client.ObjectKeyFromObject(secret)
  349. if err := r.Client.Get(ctx, key, secret); err != nil {
  350. if !apierrors.IsNotFound(err) {
  351. return false, err
  352. }
  353. if err := mutationFunc(); err != nil {
  354. return false, err
  355. }
  356. // Setting Field Owner even for CreationPolicy==Create
  357. if err := r.Client.Create(ctx, secret, client.FieldOwner(fqdn)); err != nil {
  358. return false, err
  359. }
  360. r.recorder.Event(es, v1.EventTypeNormal, esv1beta1.ReasonCreated, "Created Secret")
  361. return true, nil
  362. }
  363. existing := secret.DeepCopyObject()
  364. if err := mutationFunc(); err != nil {
  365. return false, err
  366. }
  367. if equality.Semantic.DeepEqual(existing, secret) {
  368. return false, nil
  369. }
  370. if err := r.Client.Update(ctx, secret, client.FieldOwner(fqdn)); err != nil {
  371. return false, err
  372. }
  373. r.recorder.Event(es, v1.EventTypeNormal, esv1beta1.ReasonUpdated, "Updated Secret")
  374. return false, nil
  375. }
  376. func (r *Reconciler) patchSecret(ctx context.Context, secret *v1.Secret, mutationFunc func() error, es *esv1beta1.ExternalSecret) error {
  377. fqdn := fmt.Sprintf(fieldOwnerTemplate, es.Name)
  378. err := r.Client.Get(ctx, client.ObjectKeyFromObject(secret), secret.DeepCopy())
  379. if apierrors.IsNotFound(err) {
  380. return fmt.Errorf(errPolicyMergeNotFound, secret.Name)
  381. }
  382. if err != nil {
  383. return fmt.Errorf(errPolicyMergeGetSecret, secret.Name, err)
  384. }
  385. existing := secret.DeepCopyObject()
  386. if err = mutationFunc(); err != nil {
  387. return fmt.Errorf(errPolicyMergeMutate, secret.Name, err)
  388. }
  389. // GVK is missing in the Secret, see:
  390. // https://github.com/kubernetes-sigs/controller-runtime/issues/526
  391. // https://github.com/kubernetes-sigs/controller-runtime/issues/1517
  392. // https://github.com/kubernetes/kubernetes/issues/80609
  393. // we need to manually set it before doing a Patch() as it depends on the GVK
  394. gvks, unversioned, err := r.Scheme.ObjectKinds(secret)
  395. if err != nil {
  396. return err
  397. }
  398. if !unversioned && len(gvks) == 1 {
  399. secret.SetGroupVersionKind(gvks[0])
  400. }
  401. if equality.Semantic.DeepEqual(existing, secret) {
  402. return nil
  403. }
  404. // Cleaning up Managed fields manually as to keep patch coherence
  405. secret.ObjectMeta.ManagedFields = nil
  406. // we're not able to resolve conflicts so we force ownership
  407. // see: https://kubernetes.io/docs/reference/using-api/server-side-apply/#using-server-side-apply-in-a-controller
  408. if err := r.Client.Patch(ctx, secret, client.Apply, client.FieldOwner(fqdn), client.ForceOwnership); err != nil {
  409. return fmt.Errorf(errPolicyMergePatch, secret.Name, err)
  410. }
  411. r.recorder.Event(es, v1.EventTypeNormal, esv1beta1.ReasonUpdated, "Updated Secret")
  412. return nil
  413. }
  414. func getManagedDataKeys(secret *v1.Secret, fieldOwner string) ([]string, error) {
  415. return getManagedFieldKeys(secret, fieldOwner, func(fields map[string]any) []string {
  416. dataFields := fields["f:data"]
  417. if dataFields == nil {
  418. return nil
  419. }
  420. df, ok := dataFields.(map[string]any)
  421. if !ok {
  422. return nil
  423. }
  424. return slices.Collect(maps.Keys(df))
  425. })
  426. }
  427. func getManagedFieldKeys(
  428. secret *v1.Secret,
  429. fieldOwner string,
  430. process func(fields map[string]any) []string,
  431. ) ([]string, error) {
  432. fqdn := fmt.Sprintf(fieldOwnerTemplate, fieldOwner)
  433. var keys []string
  434. for _, v := range secret.ObjectMeta.ManagedFields {
  435. if v.Manager != fqdn {
  436. continue
  437. }
  438. fields := make(map[string]any)
  439. err := json.Unmarshal(v.FieldsV1.Raw, &fields)
  440. if err != nil {
  441. return nil, fmt.Errorf("error unmarshaling managed fields: %w", err)
  442. }
  443. for _, key := range process(fields) {
  444. if key == "." {
  445. continue
  446. }
  447. keys = append(keys, strings.TrimPrefix(key, "f:"))
  448. }
  449. }
  450. return keys, nil
  451. }
  452. func getResourceVersion(es esv1beta1.ExternalSecret) string {
  453. return fmt.Sprintf("%d-%s", es.ObjectMeta.GetGeneration(), hashMeta(es.ObjectMeta))
  454. }
  455. func hashMeta(m metav1.ObjectMeta) string {
  456. type meta struct {
  457. annotations map[string]string
  458. labels map[string]string
  459. }
  460. return utils.ObjectHash(meta{
  461. annotations: m.Annotations,
  462. labels: m.Labels,
  463. })
  464. }
  465. func shouldSkipClusterSecretStore(r *Reconciler, es esv1beta1.ExternalSecret) bool {
  466. return !r.ClusterSecretStoreEnabled && es.Spec.SecretStoreRef.Kind == esv1beta1.ClusterSecretStoreKind
  467. }
  468. // shouldSkipUnmanagedStore iterates over all secretStore references in the externalSecret spec,
  469. // fetches the store and evaluates the controllerClass property.
  470. // Returns true if any storeRef points to store with a non-matching controllerClass.
  471. func shouldSkipUnmanagedStore(ctx context.Context, namespace string, r *Reconciler, es esv1beta1.ExternalSecret) (bool, error) {
  472. var storeList []esv1beta1.SecretStoreRef
  473. if es.Spec.SecretStoreRef.Name != "" {
  474. storeList = append(storeList, es.Spec.SecretStoreRef)
  475. }
  476. for _, ref := range es.Spec.Data {
  477. if ref.SourceRef != nil {
  478. storeList = append(storeList, ref.SourceRef.SecretStoreRef)
  479. }
  480. }
  481. for _, ref := range es.Spec.DataFrom {
  482. if ref.SourceRef != nil && ref.SourceRef.SecretStoreRef != nil {
  483. storeList = append(storeList, *ref.SourceRef.SecretStoreRef)
  484. }
  485. // verify that generator's controllerClass matches
  486. if ref.SourceRef != nil && ref.SourceRef.GeneratorRef != nil {
  487. _, obj, err := resolvers.GeneratorRef(ctx, r.RestConfig, namespace, ref.SourceRef.GeneratorRef)
  488. if err != nil {
  489. return false, err
  490. }
  491. skipGenerator, err := shouldSkipGenerator(r, obj)
  492. if err != nil {
  493. return false, err
  494. }
  495. if skipGenerator {
  496. return true, nil
  497. }
  498. }
  499. }
  500. for _, ref := range storeList {
  501. var store esv1beta1.GenericStore
  502. switch ref.Kind {
  503. case esv1beta1.SecretStoreKind, "":
  504. store = &esv1beta1.SecretStore{}
  505. case esv1beta1.ClusterSecretStoreKind:
  506. store = &esv1beta1.ClusterSecretStore{}
  507. namespace = ""
  508. }
  509. err := r.Client.Get(ctx, types.NamespacedName{
  510. Name: ref.Name,
  511. Namespace: namespace,
  512. }, store)
  513. if err != nil {
  514. return false, err
  515. }
  516. class := store.GetSpec().Controller
  517. if class != "" && class != r.ControllerClass {
  518. return true, nil
  519. }
  520. }
  521. return false, nil
  522. }
  523. func shouldRefresh(es esv1beta1.ExternalSecret) bool {
  524. // refresh if resource version changed
  525. if es.Status.SyncedResourceVersion != getResourceVersion(es) {
  526. return true
  527. }
  528. // skip refresh if refresh interval is 0
  529. if es.Spec.RefreshInterval.Duration == 0 && es.Status.SyncedResourceVersion != "" {
  530. return false
  531. }
  532. if es.Status.RefreshTime.IsZero() {
  533. return true
  534. }
  535. return es.Status.RefreshTime.Add(es.Spec.RefreshInterval.Duration).Before(time.Now())
  536. }
  537. func shouldReconcile(es esv1beta1.ExternalSecret) bool {
  538. if es.Spec.Target.Immutable && hasSyncedCondition(es) {
  539. return false
  540. }
  541. return true
  542. }
  543. func hasSyncedCondition(es esv1beta1.ExternalSecret) bool {
  544. for _, condition := range es.Status.Conditions {
  545. if condition.Reason == "SecretSynced" {
  546. return true
  547. }
  548. }
  549. return false
  550. }
  551. // isSecretValid checks if the secret exists, and it's data is consistent with the calculated hash.
  552. func isSecretValid(existingSecret v1.Secret) bool {
  553. // if target secret doesn't exist, or annotations as not set, we need to refresh
  554. if existingSecret.UID == "" || existingSecret.Annotations == nil {
  555. return false
  556. }
  557. // if the calculated hash is different from the calculation, then it's invalid
  558. if existingSecret.Annotations[esv1beta1.AnnotationDataHash] != utils.ObjectHash(existingSecret.Data) {
  559. return false
  560. }
  561. return true
  562. }
  563. // computeDataHashAnnotation generate a hash of the secret data combining the old key with the new keys to add or override.
  564. func (r *Reconciler) computeDataHashAnnotation(existing, secret *v1.Secret) string {
  565. data := make(map[string][]byte)
  566. maps.Insert(data, maps.All(existing.Data))
  567. maps.Insert(data, maps.All(secret.Data))
  568. return utils.ObjectHash(data)
  569. }
  570. // SetupWithManager returns a new controller builder that will be started by the provided Manager.
  571. func (r *Reconciler) SetupWithManager(mgr ctrl.Manager, opts controller.Options) error {
  572. r.recorder = mgr.GetEventRecorderFor("external-secrets")
  573. // Index .Spec.Target.Name to reconcile ExternalSecrets effectively when secrets have changed
  574. if err := mgr.GetFieldIndexer().IndexField(context.Background(), &esv1beta1.ExternalSecret{}, externalSecretSecretNameKey, func(obj client.Object) []string {
  575. es := obj.(*esv1beta1.ExternalSecret)
  576. if name := es.Spec.Target.Name; name != "" {
  577. return []string{name}
  578. }
  579. return []string{es.Name}
  580. }); err != nil {
  581. return err
  582. }
  583. return ctrl.NewControllerManagedBy(mgr).
  584. WithOptions(opts).
  585. For(&esv1beta1.ExternalSecret{}).
  586. // Cannot use Owns since the controller does not set owner reference when creation policy is not Owner
  587. Watches(
  588. &v1.Secret{},
  589. handler.EnqueueRequestsFromMapFunc(r.findObjectsForSecret),
  590. builder.WithPredicates(predicate.ResourceVersionChangedPredicate{}),
  591. builder.OnlyMetadata,
  592. ).
  593. Complete(r)
  594. }
  595. func (r *Reconciler) findObjectsForSecret(ctx context.Context, secret client.Object) []reconcile.Request {
  596. var externalSecrets esv1beta1.ExternalSecretList
  597. err := r.List(
  598. ctx,
  599. &externalSecrets,
  600. client.InNamespace(secret.GetNamespace()),
  601. client.MatchingFields{externalSecretSecretNameKey: secret.GetName()},
  602. )
  603. if err != nil {
  604. return []reconcile.Request{}
  605. }
  606. requests := make([]reconcile.Request, len(externalSecrets.Items))
  607. for i := range externalSecrets.Items {
  608. requests[i] = reconcile.Request{
  609. NamespacedName: types.NamespacedName{
  610. Name: externalSecrets.Items[i].GetName(),
  611. Namespace: externalSecrets.Items[i].GetNamespace(),
  612. },
  613. }
  614. }
  615. return requests
  616. }