keyvault.go 48 KB

12345678910111213141516171819202122232425262728293031323334353637383940414243444546474849505152535455565758596061626364656667686970717273747576777879808182838485868788899091929394959697989910010110210310410510610710810911011111211311411511611711811912012112212312412512612712812913013113213313413513613713813914014114214314414514614714814915015115215315415515615715815916016116216316416516616716816917017117217317417517617717817918018118218318418518618718818919019119219319419519619719819920020120220320420520620720820921021121221321421521621721821922022122222322422522622722822923023123223323423523623723823924024124224324424524624724824925025125225325425525625725825926026126226326426526626726826927027127227327427527627727827928028128228328428528628728828929029129229329429529629729829930030130230330430530630730830931031131231331431531631731831932032132232332432532632732832933033133233333433533633733833934034134234334434534634734834935035135235335435535635735835936036136236336436536636736836937037137237337437537637737837938038138238338438538638738838939039139239339439539639739839940040140240340440540640740840941041141241341441541641741841942042142242342442542642742842943043143243343443543643743843944044144244344444544644744844945045145245345445545645745845946046146246346446546646746846947047147247347447547647747847948048148248348448548648748848949049149249349449549649749849950050150250350450550650750850951051151251351451551651751851952052152252352452552652752852953053153253353453553653753853954054154254354454554654754854955055155255355455555655755855956056156256356456556656756856957057157257357457557657757857958058158258358458558658758858959059159259359459559659759859960060160260360460560660760860961061161261361461561661761861962062162262362462562662762862963063163263363463563663763863964064164264364464564664764864965065165265365465565665765865966066166266366466566666766866967067167267367467567667767867968068168268368468568668768868969069169269369469569669769869970070170270370470570670770870971071171271371471571671771871972072172272372472572672772872973073173273373473573673773873974074174274374474574674774874975075175275375475575675775875976076176276376476576676776876977077177277377477577677777877978078178278378478578678778878979079179279379479579679779879980080180280380480580680780880981081181281381481581681781881982082182282382482582682782882983083183283383483583683783883984084184284384484584684784884985085185285385485585685785885986086186286386486586686786886987087187287387487587687787887988088188288388488588688788888989089189289389489589689789889990090190290390490590690790890991091191291391491591691791891992092192292392492592692792892993093193293393493593693793893994094194294394494594694794894995095195295395495595695795895996096196296396496596696796896997097197297397497597697797897998098198298398498598698798898999099199299399499599699799899910001001100210031004100510061007100810091010101110121013101410151016101710181019102010211022102310241025102610271028102910301031103210331034103510361037103810391040104110421043104410451046104710481049105010511052105310541055105610571058105910601061106210631064106510661067106810691070107110721073107410751076107710781079108010811082108310841085108610871088108910901091109210931094109510961097109810991100110111021103110411051106110711081109111011111112111311141115111611171118111911201121112211231124112511261127112811291130113111321133113411351136113711381139114011411142114311441145114611471148114911501151115211531154115511561157115811591160116111621163116411651166116711681169117011711172117311741175117611771178117911801181118211831184118511861187118811891190119111921193119411951196119711981199120012011202120312041205120612071208120912101211121212131214121512161217121812191220122112221223122412251226122712281229123012311232123312341235123612371238123912401241124212431244124512461247124812491250125112521253125412551256125712581259126012611262126312641265126612671268126912701271127212731274127512761277127812791280128112821283128412851286128712881289129012911292129312941295129612971298129913001301130213031304130513061307130813091310131113121313131413151316131713181319132013211322132313241325132613271328132913301331133213331334133513361337133813391340134113421343134413451346134713481349135013511352135313541355135613571358135913601361136213631364136513661367136813691370137113721373137413751376137713781379138013811382138313841385138613871388138913901391139213931394139513961397139813991400140114021403140414051406140714081409141014111412141314141415141614171418141914201421142214231424142514261427142814291430143114321433143414351436143714381439144014411442144314441445144614471448144914501451145214531454145514561457
  1. /*
  2. Copyright © The ESO Authors
  3. Licensed under the Apache License, Version 2.0 (the "License");
  4. you may not use this file except in compliance with the License.
  5. You may obtain a copy of the License at
  6. https://www.apache.org/licenses/LICENSE-2.0
  7. Unless required by applicable law or agreed to in writing, software
  8. distributed under the License is distributed on an "AS IS" BASIS,
  9. WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
  10. See the License for the specific language governing permissions and
  11. limitations under the License.
  12. */
  13. // Package keyvault implements a provider for Azure Key Vault secrets, allowing
  14. // External Secrets to read from and write to Azure Key Vault.
  15. package keyvault
  16. import (
  17. "context"
  18. "crypto/x509"
  19. b64 "encoding/base64"
  20. "encoding/json"
  21. "encoding/pem"
  22. "errors"
  23. "fmt"
  24. "os"
  25. "path"
  26. "path/filepath"
  27. "regexp"
  28. "strings"
  29. "time"
  30. "github.com/Azure/azure-sdk-for-go/sdk/azcore"
  31. "github.com/Azure/azure-sdk-for-go/sdk/security/keyvault/azcertificates"
  32. "github.com/Azure/azure-sdk-for-go/sdk/security/keyvault/azkeys"
  33. "github.com/Azure/azure-sdk-for-go/sdk/security/keyvault/azsecrets"
  34. "github.com/Azure/azure-sdk-for-go/services/keyvault/v7.0/keyvault"
  35. "github.com/Azure/go-autorest/autorest"
  36. "github.com/Azure/go-autorest/autorest/adal"
  37. "github.com/Azure/go-autorest/autorest/azure"
  38. kvauth "github.com/Azure/go-autorest/autorest/azure/auth"
  39. "github.com/Azure/go-autorest/autorest/date"
  40. "github.com/AzureAD/microsoft-authentication-library-for-go/apps/confidential"
  41. "github.com/aws/smithy-go/ptr"
  42. "github.com/lestrrat-go/jwx/v2/jwk"
  43. "github.com/tidwall/gjson"
  44. "golang.org/x/crypto/sha3"
  45. authv1 "k8s.io/api/authentication/v1"
  46. corev1 "k8s.io/api/core/v1"
  47. metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
  48. "k8s.io/apimachinery/pkg/types"
  49. "k8s.io/client-go/kubernetes"
  50. kcorev1 "k8s.io/client-go/kubernetes/typed/core/v1"
  51. pointer "k8s.io/utils/ptr"
  52. "sigs.k8s.io/controller-runtime/pkg/client"
  53. ctrlcfg "sigs.k8s.io/controller-runtime/pkg/client/config"
  54. "sigs.k8s.io/controller-runtime/pkg/webhook/admission"
  55. gopkcs12 "software.sslmate.com/src/go-pkcs12"
  56. esv1 "github.com/external-secrets/external-secrets/apis/externalsecrets/v1"
  57. "github.com/external-secrets/external-secrets/runtime/constants"
  58. "github.com/external-secrets/external-secrets/runtime/esutils"
  59. "github.com/external-secrets/external-secrets/runtime/esutils/metadata"
  60. "github.com/external-secrets/external-secrets/runtime/esutils/resolvers"
  61. "github.com/external-secrets/external-secrets/runtime/metrics"
  62. )
  63. const (
  64. defaultObjType = "secret"
  65. objectTypeCert = "cert"
  66. objectTypeKey = "key"
  67. // AzureDefaultAudience is the default audience used for Azure AD token exchange.
  68. AzureDefaultAudience = "api://AzureADTokenExchange"
  69. // AnnotationClientID is the annotation key for Azure Workload Identity client ID.
  70. AnnotationClientID = "azure.workload.identity/client-id"
  71. // AnnotationTenantID is the annotation key for Azure Workload Identity tenant ID.
  72. AnnotationTenantID = "azure.workload.identity/tenant-id"
  73. managerLabel = "external-secrets"
  74. managedBy = "managed-by"
  75. errUnexpectedStoreSpec = "unexpected store spec"
  76. errMissingAuthType = "cannot initialize Azure Client: no valid authType was specified"
  77. errPropNotExist = "property %s does not exist in key %s"
  78. errTagNotExist = "tag %s does not exist"
  79. errUnknownObjectType = "unknown Azure Keyvault object Type for %s"
  80. errUnmarshalJSONData = "error unmarshalling json data: %w"
  81. errDataFromCert = "cannot get use dataFrom to get certificate secret"
  82. errDataFromKey = "cannot get use dataFrom to get key secret"
  83. errMissingTenant = "missing tenantID in store config"
  84. errMissingClient = "missing clientID: either serviceAccountRef or service account annotation '%s' is missing"
  85. errMissingSecretRef = "missing secretRef in provider config"
  86. errMissingClientIDSecret = "missing accessKeyID/secretAccessKey in store config"
  87. errInvalidClientCredentials = "both clientSecret and clientCredentials set"
  88. errMultipleClientID = "multiple clientID found. Check secretRef and serviceAccountRef"
  89. errMultipleTenantID = "multiple tenantID found. Check secretRef, 'spec.provider.azurekv.tenantId', and serviceAccountRef"
  90. errInvalidStore = "invalid store"
  91. errInvalidStoreSpec = "invalid store spec"
  92. errInvalidStoreProv = "invalid store provider"
  93. errInvalidAzureProv = "invalid azure keyvault provider"
  94. errInvalidSecRefClientID = "invalid AuthSecretRef.ClientID: %w"
  95. errInvalidSecRefClientSecret = "invalid AuthSecretRef.ClientSecret: %w"
  96. errInvalidSARef = "invalid ServiceAccountRef: %w"
  97. errMissingWorkloadEnvVars = "missing environment variables. AZURE_CLIENT_ID, AZURE_TENANT_ID and AZURE_FEDERATED_TOKEN_FILE must be set"
  98. errReadTokenFile = "unable to read token file %s: %w"
  99. )
  100. // https://github.com/external-secrets/external-secrets/issues/644
  101. var _ esv1.SecretsClient = &Azure{}
  102. var _ esv1.Provider = &Azure{}
  103. // SecretClient is an interface to keyvault.BaseClient.
  104. type SecretClient interface {
  105. GetKey(ctx context.Context, vaultBaseURL string, keyName string, keyVersion string) (result keyvault.KeyBundle, err error)
  106. GetSecret(ctx context.Context, vaultBaseURL string, secretName string, secretVersion string) (result keyvault.SecretBundle, err error)
  107. GetSecretsComplete(ctx context.Context, vaultBaseURL string, maxresults *int32) (result keyvault.SecretListResultIterator, err error)
  108. GetCertificate(ctx context.Context, vaultBaseURL string, certificateName string, certificateVersion string) (result keyvault.CertificateBundle, err error)
  109. SetSecret(ctx context.Context, vaultBaseURL string, secretName string, parameters keyvault.SecretSetParameters) (result keyvault.SecretBundle, err error)
  110. ImportKey(ctx context.Context, vaultBaseURL string, keyName string, parameters keyvault.KeyImportParameters) (result keyvault.KeyBundle, err error)
  111. ImportCertificate(ctx context.Context, vaultBaseURL string, certificateName string, parameters keyvault.CertificateImportParameters) (result keyvault.CertificateBundle, err error)
  112. DeleteCertificate(ctx context.Context, vaultBaseURL string, certificateName string) (result keyvault.DeletedCertificateBundle, err error)
  113. DeleteKey(ctx context.Context, vaultBaseURL string, keyName string) (result keyvault.DeletedKeyBundle, err error)
  114. DeleteSecret(ctx context.Context, vaultBaseURL string, secretName string) (result keyvault.DeletedSecretBundle, err error)
  115. }
  116. // Azure implements the External Secrets provider for Azure Key Vault.
  117. type Azure struct {
  118. crClient client.Client
  119. kubeClient kcorev1.CoreV1Interface
  120. store esv1.GenericStore
  121. provider *esv1.AzureKVProvider
  122. namespace string
  123. // Legacy go-autorest client
  124. baseClient SecretClient
  125. // New Azure SDK clients (used when UseAzureSDK is true)
  126. secretsClient *azsecrets.Client
  127. keysClient *azkeys.Client
  128. certsClient *azcertificates.Client
  129. }
  130. // PushSecretMetadataSpec defines metadata for pushing secrets to Azure Key Vault,
  131. // including expiration date and tags.
  132. type PushSecretMetadataSpec struct {
  133. ExpirationDate string `json:"expirationDate,omitempty"`
  134. Tags map[string]string `json:"tags,omitempty"`
  135. }
  136. // Capabilities return the provider supported capabilities (ReadOnly, WriteOnly, ReadWrite).
  137. func (a *Azure) Capabilities() esv1.SecretStoreCapabilities {
  138. return esv1.SecretStoreReadWrite
  139. }
  140. // NewClient constructs a new secrets client based on the provided store.
  141. func (a *Azure) NewClient(ctx context.Context, store esv1.GenericStore, kube client.Client, namespace string) (esv1.SecretsClient, error) {
  142. return newClient(ctx, store, kube, namespace)
  143. }
  144. func newClient(ctx context.Context, store esv1.GenericStore, kube client.Client, namespace string) (esv1.SecretsClient, error) {
  145. provider, err := getProvider(store)
  146. if err != nil {
  147. return nil, err
  148. }
  149. cfg, err := ctrlcfg.GetConfig()
  150. if err != nil {
  151. return nil, err
  152. }
  153. kubeClient, err := kubernetes.NewForConfig(cfg)
  154. if err != nil {
  155. return nil, err
  156. }
  157. az := &Azure{
  158. crClient: kube,
  159. kubeClient: kubeClient.CoreV1(),
  160. store: store,
  161. namespace: namespace,
  162. provider: provider,
  163. }
  164. // allow SecretStore controller validation to pass
  165. // when using referent namespace.
  166. if store.GetKind() == esv1.ClusterSecretStoreKind &&
  167. namespace == "" &&
  168. isReferentSpec(provider) {
  169. return az, nil
  170. }
  171. // Check if the new Azure SDK should be used
  172. if provider.UseAzureSDK != nil && *provider.UseAzureSDK {
  173. err = initializeNewAzureSDK(ctx, az)
  174. } else {
  175. err = initializeLegacyClient(ctx, az)
  176. }
  177. return az, err
  178. }
  179. // initializeLegacyClient sets up the Azure Key Vault client using the legacy go-autorest SDK.
  180. func initializeLegacyClient(ctx context.Context, az *Azure) error {
  181. var authorizer autorest.Authorizer
  182. var err error
  183. switch *az.provider.AuthType {
  184. case esv1.AzureManagedIdentity:
  185. authorizer, err = az.authorizerForManagedIdentity()
  186. case esv1.AzureServicePrincipal:
  187. authorizer, err = az.authorizerForServicePrincipal(ctx)
  188. case esv1.AzureWorkloadIdentity:
  189. authorizer, err = az.authorizerForWorkloadIdentity(ctx, NewTokenProvider)
  190. default:
  191. return errors.New(errMissingAuthType)
  192. }
  193. if err != nil {
  194. return err
  195. }
  196. cl := keyvault.New()
  197. cl.Authorizer = authorizer
  198. az.baseClient = &cl
  199. return nil
  200. }
  201. // initializeNewAzureSDK sets up the Azure Key Vault client using the new azcore-based SDK.
  202. func initializeNewAzureSDK(ctx context.Context, az *Azure) error {
  203. // Get cloud configuration
  204. cloudConfig, err := getCloudConfiguration(az.provider)
  205. if err != nil {
  206. return fmt.Errorf("failed to get cloud configuration: %w", err)
  207. }
  208. // Build credential based on auth type
  209. var credential azcore.TokenCredential
  210. switch *az.provider.AuthType {
  211. case esv1.AzureManagedIdentity:
  212. credential, err = buildManagedIdentityCredential(az, cloudConfig)
  213. case esv1.AzureServicePrincipal:
  214. credential, err = buildServicePrincipalCredential(ctx, az, cloudConfig)
  215. case esv1.AzureWorkloadIdentity:
  216. credential, err = buildWorkloadIdentityCredential(ctx, az, cloudConfig)
  217. default:
  218. return errors.New(errMissingAuthType)
  219. }
  220. if err != nil {
  221. return err
  222. }
  223. // Create Azure SDK clients and store them directly
  224. az.secretsClient, err = azsecrets.NewClient(*az.provider.VaultURL, credential, &azsecrets.ClientOptions{
  225. ClientOptions: azcore.ClientOptions{Cloud: cloudConfig},
  226. })
  227. if err != nil {
  228. return fmt.Errorf("failed to create secrets client: %w", err)
  229. }
  230. az.keysClient, err = azkeys.NewClient(*az.provider.VaultURL, credential, &azkeys.ClientOptions{
  231. ClientOptions: azcore.ClientOptions{Cloud: cloudConfig},
  232. })
  233. if err != nil {
  234. return fmt.Errorf("failed to create keys client: %w", err)
  235. }
  236. az.certsClient, err = azcertificates.NewClient(*az.provider.VaultURL, credential, &azcertificates.ClientOptions{
  237. ClientOptions: azcore.ClientOptions{Cloud: cloudConfig},
  238. })
  239. if err != nil {
  240. return fmt.Errorf("failed to create certificates client: %w", err)
  241. }
  242. return nil
  243. }
  244. // useNewSDK returns true if the new Azure SDK should be used.
  245. func (a *Azure) useNewSDK() bool {
  246. return a.provider.UseAzureSDK != nil && *a.provider.UseAzureSDK
  247. }
  248. func getProvider(store esv1.GenericStore) (*esv1.AzureKVProvider, error) {
  249. spc := store.GetSpec()
  250. if spc == nil || spc.Provider.AzureKV == nil {
  251. return nil, errors.New(errUnexpectedStoreSpec)
  252. }
  253. return spc.Provider.AzureKV, nil
  254. }
  255. // ValidateStore validates the Azure Key Vault provider configuration.
  256. func (a *Azure) ValidateStore(store esv1.GenericStore) (admission.Warnings, error) {
  257. if store == nil {
  258. return nil, errors.New(errInvalidStore)
  259. }
  260. spc := store.GetSpec()
  261. if spc == nil {
  262. return nil, errors.New(errInvalidStoreSpec)
  263. }
  264. if spc.Provider == nil {
  265. return nil, errors.New(errInvalidStoreProv)
  266. }
  267. p := spc.Provider.AzureKV
  268. if p == nil {
  269. return nil, errors.New(errInvalidAzureProv)
  270. }
  271. if p.AuthSecretRef != nil {
  272. if p.AuthSecretRef.ClientID != nil {
  273. if err := esutils.ValidateReferentSecretSelector(store, *p.AuthSecretRef.ClientID); err != nil {
  274. return nil, fmt.Errorf(errInvalidSecRefClientID, err)
  275. }
  276. }
  277. if p.AuthSecretRef.ClientSecret != nil {
  278. if err := esutils.ValidateReferentSecretSelector(store, *p.AuthSecretRef.ClientSecret); err != nil {
  279. return nil, fmt.Errorf(errInvalidSecRefClientSecret, err)
  280. }
  281. }
  282. }
  283. if p.ServiceAccountRef != nil {
  284. if err := esutils.ValidateReferentServiceAccountSelector(store, *p.ServiceAccountRef); err != nil {
  285. return nil, fmt.Errorf(errInvalidSARef, err)
  286. }
  287. }
  288. if p.CustomCloudConfig != nil {
  289. if !ptr.ToBool(p.UseAzureSDK) {
  290. return nil, errors.New("CustomCloudConfig requires UseAzureSDK to be set to true - the legacy SDK does not support custom clouds")
  291. }
  292. if p.CustomCloudConfig.ActiveDirectoryEndpoint == "" {
  293. return nil, errors.New("activeDirectoryEndpoint is required in CustomCloudConfig")
  294. }
  295. }
  296. if p.EnvironmentType == esv1.AzureEnvironmentAzureStackCloud && p.CustomCloudConfig == nil {
  297. return nil, errors.New("CustomCloudConfig is required when EnvironmentType is AzureStackCloud")
  298. }
  299. return nil, nil
  300. }
  301. func canDelete(tags map[string]*string, err error) (bool, error) {
  302. aerr := &autorest.DetailedError{}
  303. conv := errors.As(err, aerr)
  304. if err != nil && !conv {
  305. return false, fmt.Errorf("could not parse error: %w", err)
  306. }
  307. if conv && aerr.StatusCode != 404 { // Secret is already deleted, nothing to do.
  308. return false, fmt.Errorf("unexpected api error: %w", err)
  309. }
  310. if aerr.StatusCode == 404 {
  311. return false, nil
  312. }
  313. manager, ok := tags[managedBy]
  314. if !ok || manager == nil || *manager != managerLabel {
  315. return false, errors.New("not managed by external-secrets")
  316. }
  317. return true, nil
  318. }
  319. func (a *Azure) deleteKeyVaultKey(ctx context.Context, keyName string) error {
  320. value, err := a.baseClient.GetKey(ctx, *a.provider.VaultURL, keyName, "")
  321. metrics.ObserveAPICall(constants.ProviderAzureKV, constants.CallAzureKVGetKey, err)
  322. ok, err := canDelete(value.Tags, err)
  323. if err != nil {
  324. return fmt.Errorf("error getting key %v: %w", keyName, err)
  325. }
  326. if ok {
  327. _, err = a.baseClient.DeleteKey(ctx, *a.provider.VaultURL, keyName)
  328. metrics.ObserveAPICall(constants.ProviderAzureKV, constants.CallAzureKVDeleteKey, err)
  329. if err != nil {
  330. return fmt.Errorf("error deleting key %v: %w", keyName, err)
  331. }
  332. }
  333. return nil
  334. }
  335. func (a *Azure) deleteKeyVaultSecret(ctx context.Context, secretName string) error {
  336. value, err := a.baseClient.GetSecret(ctx, *a.provider.VaultURL, secretName, "")
  337. metrics.ObserveAPICall(constants.ProviderAzureKV, constants.CallAzureKVGetSecret, err)
  338. ok, err := canDelete(value.Tags, err)
  339. if err != nil {
  340. return fmt.Errorf("error getting secret %v: %w", secretName, err)
  341. }
  342. if ok {
  343. _, err = a.baseClient.DeleteSecret(ctx, *a.provider.VaultURL, secretName)
  344. metrics.ObserveAPICall(constants.ProviderAzureKV, constants.CallAzureKVDeleteSecret, err)
  345. if err != nil {
  346. return fmt.Errorf("error deleting secret %v: %w", secretName, err)
  347. }
  348. }
  349. return nil
  350. }
  351. func (a *Azure) deleteKeyVaultCertificate(ctx context.Context, certName string) error {
  352. value, err := a.baseClient.GetCertificate(ctx, *a.provider.VaultURL, certName, "")
  353. metrics.ObserveAPICall(constants.ProviderAzureKV, constants.CallAzureKVGetCertificate, err)
  354. ok, err := canDelete(value.Tags, err)
  355. if err != nil {
  356. return fmt.Errorf("error getting certificate %v: %w", certName, err)
  357. }
  358. if ok {
  359. _, err = a.baseClient.DeleteCertificate(ctx, *a.provider.VaultURL, certName)
  360. metrics.ObserveAPICall(constants.ProviderAzureKV, constants.CallAzureKVDeleteCertificate, err)
  361. if err != nil {
  362. return fmt.Errorf("error deleting certificate %v: %w", certName, err)
  363. }
  364. }
  365. return nil
  366. }
  367. // DeleteSecret deletes a secret from Azure Key Vault.
  368. func (a *Azure) DeleteSecret(ctx context.Context, remoteRef esv1.PushSecretRemoteRef) error {
  369. objectType, secretName := getObjType(esv1.ExternalSecretDataRemoteRef{Key: remoteRef.GetRemoteKey()})
  370. switch objectType {
  371. case defaultObjType:
  372. if a.useNewSDK() {
  373. return a.deleteKeyVaultSecretWithNewSDK(ctx, secretName)
  374. }
  375. return a.deleteKeyVaultSecret(ctx, secretName)
  376. case objectTypeCert:
  377. if a.useNewSDK() {
  378. return a.deleteKeyVaultCertificateWithNewSDK(ctx, secretName)
  379. }
  380. return a.deleteKeyVaultCertificate(ctx, secretName)
  381. case objectTypeKey:
  382. if a.useNewSDK() {
  383. return a.deleteKeyVaultKeyWithNewSDK(ctx, secretName)
  384. }
  385. return a.deleteKeyVaultKey(ctx, secretName)
  386. default:
  387. return fmt.Errorf("secret type '%v' is not supported", objectType)
  388. }
  389. }
  390. // SecretExists checks if a secret exists in Azure Key Vault.
  391. func (a *Azure) SecretExists(ctx context.Context, remoteRef esv1.PushSecretRemoteRef) (bool, error) {
  392. if a.useNewSDK() {
  393. return a.secretExistsWithNewSDK(ctx, remoteRef)
  394. }
  395. objectType, secretName := getObjType(esv1.ExternalSecretDataRemoteRef{Key: remoteRef.GetRemoteKey()})
  396. var err error
  397. switch objectType {
  398. case defaultObjType:
  399. _, err = a.baseClient.GetSecret(ctx, *a.provider.VaultURL, secretName, "")
  400. case objectTypeCert:
  401. _, err = a.baseClient.GetCertificate(ctx, *a.provider.VaultURL, secretName, "")
  402. case objectTypeKey:
  403. _, err = a.baseClient.GetKey(ctx, *a.provider.VaultURL, secretName, "")
  404. default:
  405. errMsg := fmt.Sprintf("secret type '%v' is not supported", objectType)
  406. return false, errors.New(errMsg)
  407. }
  408. err = parseError(err)
  409. if err != nil {
  410. var noSecretErr esv1.NoSecretError
  411. if errors.As(err, &noSecretErr) {
  412. return false, nil
  413. }
  414. return false, err
  415. }
  416. return true, nil
  417. }
  418. func getCertificateFromValue(value []byte) (*x509.Certificate, error) {
  419. // 1st: try decode pkcs12
  420. _, localCert, err := gopkcs12.Decode(value, "")
  421. if err == nil {
  422. return localCert, nil
  423. }
  424. // 2nd: try decode pkcs12 with chain
  425. _, localCert, _, err = gopkcs12.DecodeChain(value, "")
  426. if err == nil {
  427. return localCert, nil
  428. }
  429. // 3rd: try DER
  430. localCert, err = x509.ParseCertificate(value)
  431. if err == nil {
  432. return localCert, nil
  433. }
  434. // 4th: parse PEM blocks
  435. for {
  436. block, rest := pem.Decode(value)
  437. value = rest
  438. if block == nil {
  439. break
  440. }
  441. cert, err := x509.ParseCertificate(block.Bytes)
  442. if err == nil {
  443. return cert, nil
  444. }
  445. }
  446. return nil, errors.New("could not parse certificate value as PKCS#12, DER or PEM")
  447. }
  448. func getKeyFromValue(value []byte) (any, error) {
  449. val := value
  450. pemBlock, _ := pem.Decode(value)
  451. // if a private key regular expression doesn't match, we should consider this key to be symmetric
  452. if pemBlock == nil {
  453. return val, nil
  454. }
  455. val = pemBlock.Bytes
  456. switch pemBlock.Type {
  457. case "PRIVATE KEY":
  458. return x509.ParsePKCS8PrivateKey(val)
  459. case "RSA PRIVATE KEY":
  460. return x509.ParsePKCS1PrivateKey(val)
  461. case "EC PRIVATE KEY":
  462. return x509.ParseECPrivateKey(val)
  463. default:
  464. return nil, fmt.Errorf("key type %v is not supported", pemBlock.Type)
  465. }
  466. }
  467. func canCreate(tags map[string]*string, err error) (bool, error) {
  468. aerr := &autorest.DetailedError{}
  469. conv := errors.As(err, aerr)
  470. if err != nil && !conv {
  471. return false, fmt.Errorf("could not parse error: %w", err)
  472. }
  473. if conv && aerr.StatusCode != 404 {
  474. return false, fmt.Errorf("unexpected api error: %w", err)
  475. }
  476. if err == nil {
  477. manager, ok := tags[managedBy]
  478. if !ok || manager == nil || *manager != managerLabel {
  479. return false, errors.New("not managed by external-secrets")
  480. }
  481. }
  482. return true, nil
  483. }
  484. func (a *Azure) setKeyVaultSecret(ctx context.Context, secretName string, value []byte, expires *date.UnixTime, tags map[string]string) error {
  485. secret, err := a.baseClient.GetSecret(ctx, *a.provider.VaultURL, secretName, "")
  486. metrics.ObserveAPICall(constants.ProviderAzureKV, constants.CallAzureKVGetSecret, err)
  487. ok, err := canCreate(secret.Tags, err)
  488. if err != nil {
  489. return fmt.Errorf("cannot get secret %v: %w", secretName, err)
  490. }
  491. if !ok {
  492. return nil
  493. }
  494. val := string(value)
  495. if secret.Value != nil && val == *secret.Value {
  496. if secret.Attributes != nil {
  497. if (secret.Attributes.Expires == nil && expires == nil) ||
  498. (secret.Attributes.Expires != nil && expires != nil && *secret.Attributes.Expires == *expires) {
  499. return nil
  500. }
  501. }
  502. }
  503. secretParams := keyvault.SecretSetParameters{
  504. Value: &val,
  505. Tags: map[string]*string{
  506. managedBy: pointer.To(managerLabel),
  507. },
  508. SecretAttributes: &keyvault.SecretAttributes{
  509. Enabled: pointer.To(true),
  510. },
  511. }
  512. for k, v := range tags {
  513. secretParams.Tags[k] = &v
  514. }
  515. if expires != nil {
  516. secretParams.SecretAttributes.Expires = expires
  517. }
  518. _, err = a.baseClient.SetSecret(ctx, *a.provider.VaultURL, secretName, secretParams)
  519. metrics.ObserveAPICall(constants.ProviderAzureKV, constants.CallAzureKVGetSecret, err)
  520. if err != nil {
  521. return fmt.Errorf("could not set secret %v: %w", secretName, err)
  522. }
  523. return nil
  524. }
  525. func (a *Azure) setKeyVaultCertificate(ctx context.Context, secretName string, value []byte, tags map[string]string) error {
  526. val := b64.StdEncoding.EncodeToString(value)
  527. localCert, err := getCertificateFromValue(value)
  528. if err != nil {
  529. return fmt.Errorf("value from secret is not a valid certificate: %w", err)
  530. }
  531. cert, err := a.baseClient.GetCertificate(ctx, *a.provider.VaultURL, secretName, "")
  532. metrics.ObserveAPICall(constants.ProviderAzureKV, constants.CallAzureKVGetCertificate, err)
  533. ok, err := canCreate(cert.Tags, err)
  534. if err != nil {
  535. return fmt.Errorf("cannot get certificate %v: %w", secretName, err)
  536. }
  537. if !ok {
  538. return nil
  539. }
  540. b512 := sha3.Sum512(localCert.Raw)
  541. if cert.Cer != nil && b512 == sha3.Sum512(*cert.Cer) {
  542. return nil
  543. }
  544. params := keyvault.CertificateImportParameters{
  545. Base64EncodedCertificate: &val,
  546. Tags: map[string]*string{
  547. managedBy: pointer.To(managerLabel),
  548. },
  549. }
  550. for k, v := range tags {
  551. params.Tags[k] = &v
  552. }
  553. _, err = a.baseClient.ImportCertificate(ctx, *a.provider.VaultURL, secretName, params)
  554. metrics.ObserveAPICall(constants.ProviderAzureKV, constants.CallAzureKVImportCertificate, err)
  555. if err != nil {
  556. return fmt.Errorf("could not import certificate %v: %w", secretName, err)
  557. }
  558. return nil
  559. }
  560. func equalKeys(newKey, oldKey keyvault.JSONWebKey) bool {
  561. // checks for everything except KeyID and KeyOps
  562. rsaCheck := newKey.E != nil && oldKey.E != nil && *newKey.E == *oldKey.E &&
  563. newKey.N != nil && oldKey.N != nil && *newKey.N == *oldKey.N
  564. symmetricCheck := newKey.Crv == oldKey.Crv &&
  565. newKey.T != nil && oldKey.T != nil && *newKey.T == *oldKey.T &&
  566. newKey.X != nil && oldKey.X != nil && *newKey.X == *oldKey.X &&
  567. newKey.Y != nil && oldKey.Y != nil && *newKey.Y == *oldKey.Y
  568. return newKey.Kty == oldKey.Kty && (rsaCheck || symmetricCheck)
  569. }
  570. func (a *Azure) setKeyVaultKey(ctx context.Context, secretName string, value []byte, tags map[string]string) error {
  571. key, err := getKeyFromValue(value)
  572. if err != nil {
  573. return fmt.Errorf("could not load private key %v: %w", secretName, err)
  574. }
  575. jwKey, err := jwk.FromRaw(key)
  576. if err != nil {
  577. return fmt.Errorf("failed to generate a JWK from secret %v content: %w", secretName, err)
  578. }
  579. buf, err := json.Marshal(jwKey)
  580. if err != nil {
  581. return fmt.Errorf("error parsing key: %w", err)
  582. }
  583. azkey := keyvault.JSONWebKey{}
  584. err = json.Unmarshal(buf, &azkey)
  585. if err != nil {
  586. return fmt.Errorf("error unmarshalling key: %w", err)
  587. }
  588. keyFromVault, err := a.baseClient.GetKey(ctx, *a.provider.VaultURL, secretName, "")
  589. metrics.ObserveAPICall(constants.ProviderAzureKV, constants.CallAzureKVGetKey, err)
  590. ok, err := canCreate(keyFromVault.Tags, err)
  591. if err != nil {
  592. return fmt.Errorf("cannot get key %v: %w", secretName, err)
  593. }
  594. if !ok {
  595. return nil
  596. }
  597. if keyFromVault.Key != nil && equalKeys(azkey, *keyFromVault.Key) {
  598. return nil
  599. }
  600. params := keyvault.KeyImportParameters{
  601. Key: &azkey,
  602. KeyAttributes: &keyvault.KeyAttributes{},
  603. Tags: map[string]*string{
  604. managedBy: pointer.To(managerLabel),
  605. },
  606. }
  607. for k, v := range tags {
  608. params.Tags[k] = &v
  609. }
  610. _, err = a.baseClient.ImportKey(ctx, *a.provider.VaultURL, secretName, params)
  611. metrics.ObserveAPICall(constants.ProviderAzureKV, constants.CallAzureKVImportKey, err)
  612. if err != nil {
  613. return fmt.Errorf("could not import key %v: %w", secretName, err)
  614. }
  615. return nil
  616. }
  617. func getSecretKey(secret *corev1.Secret, data esv1.PushSecretData) ([]byte, error) {
  618. if data.GetSecretKey() != "" {
  619. return secret.Data[data.GetSecretKey()], nil
  620. }
  621. // Must convert secret values to string, otherwise data will be sent as base64 to Vault
  622. secretStringVal := make(map[string]string)
  623. for k, v := range secret.Data {
  624. secretStringVal[k] = string(v)
  625. }
  626. value, err := esutils.JSONMarshal(secretStringVal)
  627. if err != nil {
  628. return nil, fmt.Errorf("failed to serialize secret content as JSON: %w", err)
  629. }
  630. return value, nil
  631. }
  632. // PushSecret stores secrets into a Key vault instance.
  633. func (a *Azure) PushSecret(ctx context.Context, secret *corev1.Secret, data esv1.PushSecretData) error {
  634. var (
  635. value []byte
  636. err error
  637. expires *date.UnixTime
  638. tags map[string]string
  639. )
  640. if value, err = getSecretKey(secret, data); err != nil {
  641. return err
  642. }
  643. metadata, err := metadata.ParseMetadataParameters[PushSecretMetadataSpec](data.GetMetadata())
  644. if err != nil {
  645. return fmt.Errorf("failed to parse push secret metadata: %w", err)
  646. }
  647. if metadata != nil && metadata.Spec.ExpirationDate != "" {
  648. t, err := time.Parse(time.RFC3339, metadata.Spec.ExpirationDate)
  649. if err != nil {
  650. return fmt.Errorf("error parsing expiration date in metadata: %w. Expected format: YYYY-MM-DDTHH:MM:SSZ (RFC3339). Example: 2024-12-31T20:00:00Z", err)
  651. }
  652. unixTime := date.UnixTime(t)
  653. expires = &unixTime
  654. }
  655. if metadata != nil && metadata.Spec.Tags != nil {
  656. if _, exists := metadata.Spec.Tags[managedBy]; exists {
  657. return fmt.Errorf("error parsing tags in metadata: Cannot specify a '%s' tag", managedBy)
  658. }
  659. tags = metadata.Spec.Tags
  660. }
  661. objectType, secretName := getObjType(esv1.ExternalSecretDataRemoteRef{Key: data.GetRemoteKey()})
  662. switch objectType {
  663. case defaultObjType:
  664. if a.useNewSDK() {
  665. return a.setKeyVaultSecretWithNewSDK(ctx, secretName, value, nil, tags)
  666. }
  667. return a.setKeyVaultSecret(ctx, secretName, value, expires, tags)
  668. case objectTypeCert:
  669. if a.useNewSDK() {
  670. return a.setKeyVaultCertificateWithNewSDK(ctx, secretName, value, tags)
  671. }
  672. return a.setKeyVaultCertificate(ctx, secretName, value, tags)
  673. case objectTypeKey:
  674. if a.useNewSDK() {
  675. return a.setKeyVaultKeyWithNewSDK(ctx, secretName, value, tags)
  676. }
  677. return a.setKeyVaultKey(ctx, secretName, value, tags)
  678. default:
  679. return fmt.Errorf("secret type %v not supported", objectType)
  680. }
  681. }
  682. // GetAllSecrets implements store.Client.GetAllSecrets Interface.
  683. // Retrieves a map[string][]byte with the secret names as key and the secret itself as the calue.
  684. func (a *Azure) GetAllSecrets(ctx context.Context, ref esv1.ExternalSecretFind) (map[string][]byte, error) {
  685. if a.useNewSDK() {
  686. return a.getAllSecretsWithNewSDK(ctx, ref)
  687. }
  688. return a.getAllSecretsWithLegacySDK(ctx, ref)
  689. }
  690. func (a *Azure) getAllSecretsWithLegacySDK(ctx context.Context, ref esv1.ExternalSecretFind) (map[string][]byte, error) {
  691. basicClient := a.baseClient
  692. secretsMap := make(map[string][]byte)
  693. checkTags := len(ref.Tags) > 0
  694. checkName := ref.Name != nil && ref.Name.RegExp != ""
  695. secretListIter, err := basicClient.GetSecretsComplete(ctx, *a.provider.VaultURL, nil)
  696. metrics.ObserveAPICall(constants.ProviderAzureKV, constants.CallAzureKVGetSecrets, err)
  697. err = parseError(err)
  698. if err != nil {
  699. return nil, err
  700. }
  701. for secretListIter.NotDone() {
  702. secret := secretListIter.Value()
  703. ok, secretName := isValidSecret(checkTags, checkName, ref, secret)
  704. if !ok {
  705. err = secretListIter.Next()
  706. if err != nil {
  707. return nil, err
  708. }
  709. continue
  710. }
  711. secretResp, err := basicClient.GetSecret(ctx, *a.provider.VaultURL, secretName, "")
  712. metrics.ObserveAPICall(constants.ProviderAzureKV, constants.CallAzureKVGetSecret, err)
  713. err = parseError(err)
  714. if err != nil {
  715. return nil, err
  716. }
  717. secretValue := *secretResp.Value
  718. secretsMap[secretName] = []byte(secretValue)
  719. err = secretListIter.Next()
  720. if err != nil {
  721. return nil, err
  722. }
  723. }
  724. return secretsMap, nil
  725. }
  726. // Retrieves a tag value if specified and all tags in JSON format if not.
  727. func getSecretTag(tags map[string]*string, property string) ([]byte, error) {
  728. if property == "" {
  729. secretTagsData := make(map[string]string)
  730. for k, v := range tags {
  731. secretTagsData[k] = *v
  732. }
  733. return json.Marshal(secretTagsData)
  734. }
  735. if val, exist := tags[property]; exist {
  736. return []byte(*val), nil
  737. }
  738. idx := strings.Index(property, ".")
  739. if idx < 0 {
  740. return nil, fmt.Errorf(errTagNotExist, property)
  741. }
  742. if idx > 0 {
  743. tagName := property[0:idx]
  744. if val, exist := tags[tagName]; exist {
  745. key := strings.Replace(property, tagName+".", "", 1)
  746. return getProperty(*val, key, property)
  747. }
  748. }
  749. return nil, fmt.Errorf(errTagNotExist, property)
  750. }
  751. // Retrieves a property value if specified and the secret value if not.
  752. func getProperty(secret, property, key string) ([]byte, error) {
  753. if property == "" {
  754. return []byte(secret), nil
  755. }
  756. res := gjson.Get(secret, property)
  757. if !res.Exists() {
  758. idx := strings.Index(property, ".")
  759. if idx < 0 {
  760. return nil, fmt.Errorf(errPropNotExist, property, key)
  761. }
  762. escaped := strings.ReplaceAll(property, ".", "\\.")
  763. jValue := gjson.Get(secret, escaped)
  764. if jValue.Exists() {
  765. return []byte(jValue.String()), nil
  766. }
  767. return nil, fmt.Errorf(errPropNotExist, property, key)
  768. }
  769. return []byte(res.String()), nil
  770. }
  771. func parseError(err error) error {
  772. aerr := autorest.DetailedError{}
  773. if errors.As(err, &aerr) && aerr.StatusCode == 404 {
  774. return esv1.NoSecretError{}
  775. }
  776. return err
  777. }
  778. // GetSecret implements store.Client.GetSecret Interface.
  779. // Retrieves a secret/Key/Certificate/Tag with the secret name defined in ref.Name
  780. // The Object Type is defined as a prefix in the ref.Name , if no prefix is defined , we assume a secret is required.
  781. func (a *Azure) GetSecret(ctx context.Context, ref esv1.ExternalSecretDataRemoteRef) ([]byte, error) {
  782. if a.useNewSDK() {
  783. return a.getSecretWithNewSDK(ctx, ref)
  784. }
  785. return a.getSecretWithLegacySDK(ctx, ref)
  786. }
  787. // returns a SecretBundle with the tags values.
  788. func (a *Azure) getSecretTags(ctx context.Context, ref esv1.ExternalSecretDataRemoteRef) (map[string]*string, error) {
  789. if a.useNewSDK() {
  790. return a.getSecretTagsWithNewSDK(ctx, ref)
  791. }
  792. return a.getSecretTagsWithLegacySDK(ctx, ref)
  793. }
  794. func (a *Azure) getSecretTagsWithLegacySDK(ctx context.Context, ref esv1.ExternalSecretDataRemoteRef) (map[string]*string, error) {
  795. _, secretName := getObjType(ref)
  796. secretResp, err := a.baseClient.GetSecret(ctx, *a.provider.VaultURL, secretName, ref.Version)
  797. metrics.ObserveAPICall(constants.ProviderAzureKV, constants.CallAzureKVGetSecret, err)
  798. err = parseError(err)
  799. if err != nil {
  800. return nil, err
  801. }
  802. secretTagsData := make(map[string]*string)
  803. for tagname, tagval := range secretResp.Tags {
  804. name := secretName + "_" + tagname
  805. kv := make(map[string]string)
  806. err = json.Unmarshal([]byte(*tagval), &kv)
  807. // if the tagvalue is not in JSON format then we added to secretTagsData we added as it is
  808. if err != nil {
  809. secretTagsData[name] = tagval
  810. } else {
  811. for k, v := range kv {
  812. value := v
  813. secretTagsData[name+"_"+k] = &value
  814. }
  815. }
  816. }
  817. return secretTagsData, nil
  818. }
  819. // GetSecretMap returns a map of secret values from Azure KeyVault by fetching the secret with
  820. // the given name and parsing it as a JSON object. If MetadataPolicy is set to Fetch, it will
  821. // return the secret tags instead.
  822. func (a *Azure) GetSecretMap(ctx context.Context, ref esv1.ExternalSecretDataRemoteRef) (map[string][]byte, error) {
  823. objectType, secretName := getObjType(ref)
  824. switch objectType {
  825. case defaultObjType:
  826. data, err := a.GetSecret(ctx, ref)
  827. if err != nil {
  828. return nil, err
  829. }
  830. if ref.MetadataPolicy == esv1.ExternalSecretMetadataPolicyFetch {
  831. tags, _ := a.getSecretTags(ctx, ref)
  832. return getSecretMapProperties(tags, ref.Key, ref.Property), nil
  833. }
  834. return getSecretMapMap(data)
  835. case objectTypeCert:
  836. return nil, errors.New(errDataFromCert)
  837. case objectTypeKey:
  838. return nil, errors.New(errDataFromKey)
  839. }
  840. return nil, fmt.Errorf(errUnknownObjectType, secretName)
  841. }
  842. func getSecretMapMap(data []byte) (map[string][]byte, error) {
  843. kv := make(map[string]json.RawMessage)
  844. err := json.Unmarshal(data, &kv)
  845. if err != nil {
  846. return nil, fmt.Errorf(errUnmarshalJSONData, err)
  847. }
  848. secretData := make(map[string][]byte)
  849. for k, v := range kv {
  850. var strVal string
  851. err = json.Unmarshal(v, &strVal)
  852. if err == nil {
  853. secretData[k] = []byte(strVal)
  854. } else {
  855. secretData[k] = v
  856. }
  857. }
  858. return secretData, nil
  859. }
  860. func getSecretMapProperties(tags map[string]*string, key, property string) map[string][]byte {
  861. tagByteArray := make(map[string][]byte)
  862. if property != "" {
  863. keyPropertyName := key + "_" + property
  864. singleTag, _ := getSecretTag(tags, keyPropertyName)
  865. tagByteArray[keyPropertyName] = singleTag
  866. return tagByteArray
  867. }
  868. for k, v := range tags {
  869. tagByteArray[k] = []byte(*v)
  870. }
  871. return tagByteArray
  872. }
  873. func (a *Azure) authorizerForWorkloadIdentity(ctx context.Context, tokenProvider tokenProviderFunc) (autorest.Authorizer, error) {
  874. aadEndpoint := AadEndpointForType(a.provider.EnvironmentType)
  875. kvResource := kvResourceForProviderConfig(a.provider.EnvironmentType)
  876. // If no serviceAccountRef was provided
  877. // we expect certain env vars to be present.
  878. // They are set by the azure workload identity webhook
  879. // by adding the label `azure.workload.identity/use: "true"` to the external-secrets pod
  880. if a.provider.ServiceAccountRef == nil {
  881. clientID := os.Getenv("AZURE_CLIENT_ID")
  882. tenantID := os.Getenv("AZURE_TENANT_ID")
  883. tokenFilePath := os.Getenv("AZURE_FEDERATED_TOKEN_FILE")
  884. if clientID == "" || tenantID == "" || tokenFilePath == "" {
  885. return nil, errors.New(errMissingWorkloadEnvVars)
  886. }
  887. token, err := os.ReadFile(filepath.Clean(tokenFilePath))
  888. if err != nil {
  889. return nil, fmt.Errorf(errReadTokenFile, tokenFilePath, err)
  890. }
  891. tp, err := tokenProvider(ctx, string(token), clientID, tenantID, aadEndpoint, kvResource)
  892. if err != nil {
  893. return nil, err
  894. }
  895. return autorest.NewBearerAuthorizer(tp), nil
  896. }
  897. ns := a.namespace
  898. if a.store.GetKind() == esv1.ClusterSecretStoreKind && a.provider.ServiceAccountRef.Namespace != nil {
  899. ns = *a.provider.ServiceAccountRef.Namespace
  900. }
  901. var sa corev1.ServiceAccount
  902. err := a.crClient.Get(ctx, types.NamespacedName{
  903. Name: a.provider.ServiceAccountRef.Name,
  904. Namespace: ns,
  905. }, &sa)
  906. if err != nil {
  907. return nil, err
  908. }
  909. // Extract clientID
  910. var clientID string
  911. // First check if AuthSecretRef is set and clientID can be fetched from there
  912. if a.provider.AuthSecretRef != nil {
  913. if a.provider.AuthSecretRef.ClientID == nil {
  914. return nil, errors.New(errMissingClientIDSecret)
  915. }
  916. clientID, err = resolvers.SecretKeyRef(
  917. ctx,
  918. a.crClient,
  919. a.store.GetKind(),
  920. a.namespace, a.provider.AuthSecretRef.ClientID)
  921. if err != nil {
  922. return nil, err
  923. }
  924. }
  925. // If AuthSecretRef is not set, use default (Service Account) implementation
  926. // Try to get clientID from Annotations
  927. if len(sa.ObjectMeta.Annotations) > 0 {
  928. if val, found := sa.ObjectMeta.Annotations[AnnotationClientID]; found {
  929. // If clientID is defined in both Annotations and AuthSecretRef, return an error
  930. if clientID != "" {
  931. return nil, errors.New(errMultipleClientID)
  932. }
  933. clientID = val
  934. }
  935. }
  936. // Return an error if clientID is still empty
  937. if clientID == "" {
  938. return nil, fmt.Errorf(errMissingClient, AnnotationClientID)
  939. }
  940. // Extract tenantID
  941. var tenantID string
  942. // First check if AuthSecretRef is set and tenantID can be fetched from there
  943. if a.provider.AuthSecretRef != nil {
  944. // We may want to set tenantID explicitly in the `spec.provider.azurekv` section of the SecretStore object
  945. // So that is okay if it is not there
  946. if a.provider.AuthSecretRef.TenantID != nil {
  947. tenantID, err = resolvers.SecretKeyRef(
  948. ctx,
  949. a.crClient,
  950. a.store.GetKind(),
  951. a.namespace, a.provider.AuthSecretRef.TenantID)
  952. if err != nil {
  953. return nil, err
  954. }
  955. }
  956. }
  957. // Check if spec.provider.azurekv.tenantID is set
  958. if tenantID == "" && a.provider.TenantID != nil {
  959. tenantID = *a.provider.TenantID
  960. }
  961. // Try to get tenantID from Annotations first. Default implementation.
  962. if len(sa.ObjectMeta.Annotations) > 0 {
  963. if val, found := sa.ObjectMeta.Annotations[AnnotationTenantID]; found {
  964. // If tenantID is defined in both Annotations and AuthSecretRef, return an error
  965. if tenantID != "" {
  966. return nil, errors.New(errMultipleTenantID)
  967. }
  968. tenantID = val
  969. }
  970. }
  971. // Fallback: use the AZURE_TENANT_ID env var which is set by the azure workload identity webhook
  972. // https://azure.github.io/azure-workload-identity/docs/topics/service-account-labels-and-annotations.html#service-account
  973. if tenantID == "" {
  974. tenantID = os.Getenv("AZURE_TENANT_ID")
  975. }
  976. // Return an error if tenantID is still empty
  977. if tenantID == "" {
  978. return nil, errors.New(errMissingTenant)
  979. }
  980. audiences := []string{AzureDefaultAudience}
  981. if len(a.provider.ServiceAccountRef.Audiences) > 0 {
  982. audiences = append(audiences, a.provider.ServiceAccountRef.Audiences...)
  983. }
  984. token, err := FetchSAToken(ctx, ns, a.provider.ServiceAccountRef.Name, audiences, a.kubeClient)
  985. if err != nil {
  986. return nil, err
  987. }
  988. tp, err := tokenProvider(ctx, token, clientID, tenantID, aadEndpoint, kvResource)
  989. if err != nil {
  990. return nil, err
  991. }
  992. return autorest.NewBearerAuthorizer(tp), nil
  993. }
  994. // FetchSAToken retrieves a service account token from Kubernetes with the specified audiences.
  995. // It takes the service account namespace, name, audience list, and Kubernetes client interface.
  996. // Returns the token string or an error if the token creation fails.
  997. func FetchSAToken(ctx context.Context, ns, name string, audiences []string, kubeClient kcorev1.CoreV1Interface) (string, error) {
  998. token, err := kubeClient.ServiceAccounts(ns).CreateToken(ctx, name, &authv1.TokenRequest{
  999. Spec: authv1.TokenRequestSpec{
  1000. Audiences: audiences,
  1001. },
  1002. }, metav1.CreateOptions{})
  1003. if err != nil {
  1004. return "", err
  1005. }
  1006. return token.Status.Token, nil
  1007. }
  1008. // tokenProvider satisfies the adal.OAuthTokenProvider interface.
  1009. type tokenProvider struct {
  1010. accessToken string
  1011. }
  1012. type tokenProviderFunc func(ctx context.Context, token, clientID, tenantID, aadEndpoint, kvResource string) (adal.OAuthTokenProvider, error)
  1013. // NewTokenProvider creates a new Azure OAuth token provider for authentication.
  1014. func NewTokenProvider(ctx context.Context, token, clientID, tenantID, aadEndpoint, kvResource string) (adal.OAuthTokenProvider, error) {
  1015. cred := confidential.NewCredFromAssertionCallback(func(_ context.Context, _ confidential.AssertionRequestOptions) (string, error) {
  1016. return token, nil
  1017. })
  1018. cClient, err := confidential.New(fmt.Sprintf("%s%s", aadEndpoint, tenantID), clientID, cred)
  1019. if err != nil {
  1020. return nil, err
  1021. }
  1022. scope := kvResource
  1023. // .default needs to be added to the scope
  1024. if !strings.Contains(kvResource, ".default") {
  1025. scope = fmt.Sprintf("%s/.default", kvResource)
  1026. }
  1027. authRes, err := cClient.AcquireTokenByCredential(ctx, []string{
  1028. scope,
  1029. })
  1030. if err != nil {
  1031. return nil, err
  1032. }
  1033. return &tokenProvider{
  1034. accessToken: authRes.AccessToken,
  1035. }, nil
  1036. }
  1037. func (t *tokenProvider) OAuthToken() string {
  1038. return t.accessToken
  1039. }
  1040. func (a *Azure) authorizerForManagedIdentity() (autorest.Authorizer, error) {
  1041. msiConfig := kvauth.NewMSIConfig()
  1042. msiConfig.Resource = kvResourceForProviderConfig(a.provider.EnvironmentType)
  1043. if a.provider.IdentityID != nil {
  1044. msiConfig.ClientID = *a.provider.IdentityID
  1045. }
  1046. return msiConfig.Authorizer()
  1047. }
  1048. func (a *Azure) authorizerForServicePrincipal(ctx context.Context) (autorest.Authorizer, error) {
  1049. if a.provider.TenantID == nil {
  1050. return nil, errors.New(errMissingTenant)
  1051. }
  1052. if a.provider.AuthSecretRef == nil {
  1053. return nil, errors.New(errMissingSecretRef)
  1054. }
  1055. if a.provider.AuthSecretRef.ClientID == nil || (a.provider.AuthSecretRef.ClientSecret == nil && a.provider.AuthSecretRef.ClientCertificate == nil) {
  1056. return nil, errors.New(errMissingClientIDSecret)
  1057. }
  1058. if a.provider.AuthSecretRef.ClientSecret != nil && a.provider.AuthSecretRef.ClientCertificate != nil {
  1059. return nil, errors.New(errInvalidClientCredentials)
  1060. }
  1061. return a.getAuthorizerFromCredentials(ctx)
  1062. }
  1063. func (a *Azure) getAuthorizerFromCredentials(ctx context.Context) (autorest.Authorizer, error) {
  1064. clientID, err := resolvers.SecretKeyRef(
  1065. ctx,
  1066. a.crClient,
  1067. a.store.GetKind(),
  1068. a.namespace, a.provider.AuthSecretRef.ClientID,
  1069. )
  1070. if err != nil {
  1071. return nil, err
  1072. }
  1073. if a.provider.AuthSecretRef.ClientSecret != nil {
  1074. clientSecret, err := resolvers.SecretKeyRef(
  1075. ctx,
  1076. a.crClient,
  1077. a.store.GetKind(),
  1078. a.namespace, a.provider.AuthSecretRef.ClientSecret,
  1079. )
  1080. if err != nil {
  1081. return nil, err
  1082. }
  1083. return getAuthorizerForClientSecret(
  1084. clientID,
  1085. clientSecret,
  1086. *a.provider.TenantID,
  1087. a.provider.EnvironmentType,
  1088. )
  1089. }
  1090. clientCertificate, err := resolvers.SecretKeyRef(
  1091. ctx,
  1092. a.crClient,
  1093. a.store.GetKind(),
  1094. a.namespace, a.provider.AuthSecretRef.ClientCertificate,
  1095. )
  1096. if err != nil {
  1097. return nil, err
  1098. }
  1099. return getAuthorizerForClientCertificate(
  1100. clientID,
  1101. []byte(clientCertificate),
  1102. *a.provider.TenantID,
  1103. a.provider.EnvironmentType,
  1104. )
  1105. }
  1106. func getAuthorizerForClientSecret(clientID, clientSecret, tenantID string, environmentType esv1.AzureEnvironmentType) (autorest.Authorizer, error) {
  1107. clientCredentialsConfig := kvauth.NewClientCredentialsConfig(clientID, clientSecret, tenantID)
  1108. clientCredentialsConfig.Resource = kvResourceForProviderConfig(environmentType)
  1109. clientCredentialsConfig.AADEndpoint = AadEndpointForType(environmentType)
  1110. return clientCredentialsConfig.Authorizer()
  1111. }
  1112. func getAuthorizerForClientCertificate(clientID string, certificateBytes []byte, tenantID string, environmentType esv1.AzureEnvironmentType) (autorest.Authorizer, error) {
  1113. clientCertificateConfig := NewClientInMemoryCertificateConfig(clientID, certificateBytes, tenantID)
  1114. clientCertificateConfig.Resource = kvResourceForProviderConfig(environmentType)
  1115. clientCertificateConfig.AADEndpoint = AadEndpointForType(environmentType)
  1116. return clientCertificateConfig.Authorizer()
  1117. }
  1118. // Close closes the Azure Key Vault provider.
  1119. func (a *Azure) Close(_ context.Context) error {
  1120. return nil
  1121. }
  1122. // Validate validates the Azure Key Vault provider configuration.
  1123. func (a *Azure) Validate() (esv1.ValidationResult, error) {
  1124. if a.store.GetKind() == esv1.ClusterSecretStoreKind && isReferentSpec(a.provider) {
  1125. return esv1.ValidationResultUnknown, nil
  1126. }
  1127. return esv1.ValidationResultReady, nil
  1128. }
  1129. func isReferentSpec(prov *esv1.AzureKVProvider) bool {
  1130. if prov.AuthSecretRef != nil &&
  1131. ((prov.AuthSecretRef.ClientID != nil &&
  1132. prov.AuthSecretRef.ClientID.Namespace == nil) ||
  1133. (prov.AuthSecretRef.ClientSecret != nil &&
  1134. prov.AuthSecretRef.ClientSecret.Namespace == nil)) {
  1135. return true
  1136. }
  1137. if prov.ServiceAccountRef != nil &&
  1138. prov.ServiceAccountRef.Namespace == nil {
  1139. return true
  1140. }
  1141. return false
  1142. }
  1143. // AadEndpointForType returns the Azure Active Directory endpoint for the specified Azure environment type.
  1144. func AadEndpointForType(t esv1.AzureEnvironmentType) string {
  1145. switch t {
  1146. case esv1.AzureEnvironmentPublicCloud:
  1147. return azure.PublicCloud.ActiveDirectoryEndpoint
  1148. case esv1.AzureEnvironmentChinaCloud:
  1149. return azure.ChinaCloud.ActiveDirectoryEndpoint
  1150. case esv1.AzureEnvironmentUSGovernmentCloud:
  1151. return azure.USGovernmentCloud.ActiveDirectoryEndpoint
  1152. case esv1.AzureEnvironmentGermanCloud:
  1153. return azure.GermanCloud.ActiveDirectoryEndpoint
  1154. case esv1.AzureEnvironmentAzureStackCloud:
  1155. // Azure Stack Cloud requires custom configuration and new SDK
  1156. // Return empty string to indicate it's not supported in old SDK
  1157. return ""
  1158. default:
  1159. return azure.PublicCloud.ActiveDirectoryEndpoint
  1160. }
  1161. }
  1162. // ServiceManagementEndpointForType returns the service management endpoint for the specified Azure environment type.
  1163. func ServiceManagementEndpointForType(t esv1.AzureEnvironmentType) string {
  1164. switch t {
  1165. case esv1.AzureEnvironmentPublicCloud:
  1166. return azure.PublicCloud.ServiceManagementEndpoint
  1167. case esv1.AzureEnvironmentChinaCloud:
  1168. return azure.ChinaCloud.ServiceManagementEndpoint
  1169. case esv1.AzureEnvironmentUSGovernmentCloud:
  1170. return azure.USGovernmentCloud.ServiceManagementEndpoint
  1171. case esv1.AzureEnvironmentGermanCloud:
  1172. return azure.GermanCloud.ServiceManagementEndpoint
  1173. case esv1.AzureEnvironmentAzureStackCloud:
  1174. // Azure Stack Cloud requires custom configuration and new SDK
  1175. // Return empty string to indicate it's not supported in old SDK
  1176. return ""
  1177. default:
  1178. return azure.PublicCloud.ServiceManagementEndpoint
  1179. }
  1180. }
  1181. func kvResourceForProviderConfig(t esv1.AzureEnvironmentType) string {
  1182. var res string
  1183. switch t {
  1184. case esv1.AzureEnvironmentPublicCloud:
  1185. res = azure.PublicCloud.KeyVaultEndpoint
  1186. case esv1.AzureEnvironmentChinaCloud:
  1187. res = azure.ChinaCloud.KeyVaultEndpoint
  1188. case esv1.AzureEnvironmentUSGovernmentCloud:
  1189. res = azure.USGovernmentCloud.KeyVaultEndpoint
  1190. case esv1.AzureEnvironmentGermanCloud:
  1191. res = azure.GermanCloud.KeyVaultEndpoint
  1192. case esv1.AzureEnvironmentAzureStackCloud:
  1193. // Azure Stack Cloud requires custom configuration and new SDK
  1194. // Return empty string to indicate it's not supported in old SDK
  1195. res = ""
  1196. default:
  1197. res = azure.PublicCloud.KeyVaultEndpoint
  1198. }
  1199. return strings.TrimSuffix(res, "/")
  1200. }
  1201. func getObjType(ref esv1.ExternalSecretDataRemoteRef) (string, string) {
  1202. objectType := defaultObjType
  1203. secretName := ref.Key
  1204. nameSplitted := strings.Split(secretName, "/")
  1205. if len(nameSplitted) > 1 {
  1206. objectType = nameSplitted[0]
  1207. secretName = nameSplitted[1]
  1208. // TODO: later tokens can be used to read the secret tags
  1209. }
  1210. return objectType, secretName
  1211. }
  1212. func isValidSecret(checkTags, checkName bool, ref esv1.ExternalSecretFind, secret keyvault.SecretItem) (bool, string) {
  1213. if secret.ID == nil || !*secret.Attributes.Enabled {
  1214. return false, ""
  1215. }
  1216. if checkTags && !okByTags(ref, secret) {
  1217. return false, ""
  1218. }
  1219. secretName := path.Base(*secret.ID)
  1220. if checkName && !okByName(ref, secretName) {
  1221. return false, ""
  1222. }
  1223. return true, secretName
  1224. }
  1225. func okByName(ref esv1.ExternalSecretFind, secretName string) bool {
  1226. matches, _ := regexp.MatchString(ref.Name.RegExp, secretName)
  1227. return matches
  1228. }
  1229. func okByTags(ref esv1.ExternalSecretFind, secret keyvault.SecretItem) bool {
  1230. tagsFound := true
  1231. for k, v := range ref.Tags {
  1232. if val, ok := secret.Tags[k]; !ok || *val != v {
  1233. tagsFound = false
  1234. break
  1235. }
  1236. }
  1237. return tagsFound
  1238. }
  1239. // GetSecret implementation using legacy go-autorest SDK.
  1240. func (a *Azure) getSecretWithLegacySDK(ctx context.Context, ref esv1.ExternalSecretDataRemoteRef) ([]byte, error) {
  1241. objectType, secretName := getObjType(ref)
  1242. switch objectType {
  1243. case defaultObjType:
  1244. // returns a SecretBundle with the secret value
  1245. // https://pkg.go.dev/github.com/Azure/azure-sdk-for-go/services/keyvault/v7.0/keyvault#SecretBundle
  1246. secretResp, err := a.baseClient.GetSecret(ctx, *a.provider.VaultURL, secretName, ref.Version)
  1247. metrics.ObserveAPICall(constants.ProviderAzureKV, constants.CallAzureKVGetSecret, err)
  1248. err = parseError(err)
  1249. if err != nil {
  1250. return nil, err
  1251. }
  1252. if ref.MetadataPolicy == esv1.ExternalSecretMetadataPolicyFetch {
  1253. return getSecretTag(secretResp.Tags, ref.Property)
  1254. }
  1255. return getProperty(*secretResp.Value, ref.Property, ref.Key)
  1256. case objectTypeCert:
  1257. // returns a CertBundle. We return CER contents of x509 certificate
  1258. // see: https://pkg.go.dev/github.com/Azure/azure-sdk-for-go/services/keyvault/v7.0/keyvault#CertificateBundle
  1259. certResp, err := a.baseClient.GetCertificate(ctx, *a.provider.VaultURL, secretName, ref.Version)
  1260. metrics.ObserveAPICall(constants.ProviderAzureKV, constants.CallAzureKVGetCertificate, err)
  1261. err = parseError(err)
  1262. if err != nil {
  1263. return nil, err
  1264. }
  1265. if ref.MetadataPolicy == esv1.ExternalSecretMetadataPolicyFetch {
  1266. return getSecretTag(certResp.Tags, ref.Property)
  1267. }
  1268. return *certResp.Cer, nil
  1269. case objectTypeKey:
  1270. // returns a KeyBundle
  1271. // https://pkg.go.dev/github.com/Azure/azure-sdk-for-go/services/keyvault/v7.0/keyvault#KeyBundle
  1272. keyResp, err := a.baseClient.GetKey(ctx, *a.provider.VaultURL, secretName, ref.Version)
  1273. metrics.ObserveAPICall(constants.ProviderAzureKV, constants.CallAzureKVGetKey, err)
  1274. err = parseError(err)
  1275. if err != nil {
  1276. return nil, err
  1277. }
  1278. if ref.MetadataPolicy == esv1.ExternalSecretMetadataPolicyFetch {
  1279. return getSecretTag(keyResp.Tags, ref.Property)
  1280. }
  1281. keyBytes, err := json.Marshal(keyResp.Key)
  1282. if err != nil {
  1283. return nil, fmt.Errorf("failed to marshal key: %w", err)
  1284. }
  1285. return getProperty(string(keyBytes), ref.Property, ref.Key)
  1286. }
  1287. return nil, fmt.Errorf(errUnknownObjectType, secretName)
  1288. }
  1289. // NewProvider creates a new Provider instance.
  1290. func NewProvider() esv1.Provider {
  1291. return &Azure{}
  1292. }
  1293. // ProviderSpec returns the provider specification for registration.
  1294. func ProviderSpec() *esv1.SecretStoreProvider {
  1295. return &esv1.SecretStoreProvider{
  1296. AzureKV: &esv1.AzureKVProvider{},
  1297. }
  1298. }
  1299. // MaintenanceStatus returns the maintenance status of the provider.
  1300. func MaintenanceStatus() esv1.MaintenanceStatus {
  1301. return esv1.MaintenanceStatusMaintained
  1302. }