secretsmanager.go 16 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528529530531532533534535536537538539540541542543
  1. /*
  2. Licensed under the Apache License, Version 2.0 (the "License");
  3. you may not use this file except in compliance with the License.
  4. You may obtain a copy of the License at
  5. http://www.apache.org/licenses/LICENSE-2.0
  6. Unless required by applicable law or agreed to in writing, software
  7. distributed under the License is distributed on an "AS IS" BASIS,
  8. WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
  9. See the License for the specific language governing permissions and
  10. limitations under the License.
  11. */
  12. package secretsmanager
  13. import (
  14. "bytes"
  15. "context"
  16. "encoding/json"
  17. "errors"
  18. "fmt"
  19. "math/big"
  20. "strings"
  21. "github.com/aws/aws-sdk-go/aws"
  22. "github.com/aws/aws-sdk-go/aws/awserr"
  23. "github.com/aws/aws-sdk-go/aws/request"
  24. "github.com/aws/aws-sdk-go/aws/session"
  25. awssm "github.com/aws/aws-sdk-go/service/secretsmanager"
  26. "github.com/google/uuid"
  27. "github.com/tidwall/gjson"
  28. "github.com/tidwall/sjson"
  29. apiextensionsv1 "k8s.io/apiextensions-apiserver/pkg/apis/apiextensions/v1"
  30. utilpointer "k8s.io/utils/ptr"
  31. ctrl "sigs.k8s.io/controller-runtime"
  32. esv1beta1 "github.com/external-secrets/external-secrets/apis/externalsecrets/v1beta1"
  33. "github.com/external-secrets/external-secrets/pkg/constants"
  34. "github.com/external-secrets/external-secrets/pkg/find"
  35. "github.com/external-secrets/external-secrets/pkg/metrics"
  36. "github.com/external-secrets/external-secrets/pkg/provider/aws/util"
  37. )
  38. // https://github.com/external-secrets/external-secrets/issues/644
  39. var _ esv1beta1.SecretsClient = &SecretsManager{}
  40. // SecretsManager is a provider for AWS SecretsManager.
  41. type SecretsManager struct {
  42. sess *session.Session
  43. client SMInterface
  44. referentAuth bool
  45. cache map[string]*awssm.GetSecretValueOutput
  46. }
  47. // SMInterface is a subset of the smiface api.
  48. // see: https://docs.aws.amazon.com/sdk-for-go/api/service/secretsmanager/secretsmanageriface/
  49. type SMInterface interface {
  50. ListSecrets(*awssm.ListSecretsInput) (*awssm.ListSecretsOutput, error)
  51. GetSecretValue(*awssm.GetSecretValueInput) (*awssm.GetSecretValueOutput, error)
  52. CreateSecretWithContext(aws.Context, *awssm.CreateSecretInput, ...request.Option) (*awssm.CreateSecretOutput, error)
  53. GetSecretValueWithContext(aws.Context, *awssm.GetSecretValueInput, ...request.Option) (*awssm.GetSecretValueOutput, error)
  54. PutSecretValueWithContext(aws.Context, *awssm.PutSecretValueInput, ...request.Option) (*awssm.PutSecretValueOutput, error)
  55. DescribeSecretWithContext(aws.Context, *awssm.DescribeSecretInput, ...request.Option) (*awssm.DescribeSecretOutput, error)
  56. DeleteSecretWithContext(ctx aws.Context, input *awssm.DeleteSecretInput, opts ...request.Option) (*awssm.DeleteSecretOutput, error)
  57. }
  58. const (
  59. errUnexpectedFindOperator = "unexpected find operator"
  60. managedBy = "managed-by"
  61. externalSecrets = "external-secrets"
  62. initialVersion = "00000000-0000-0000-0000-000000000001"
  63. )
  64. var log = ctrl.Log.WithName("provider").WithName("aws").WithName("secretsmanager")
  65. // New creates a new SecretsManager client.
  66. func New(sess *session.Session, cfg *aws.Config, referentAuth bool) (*SecretsManager, error) {
  67. return &SecretsManager{
  68. sess: sess,
  69. client: awssm.New(sess, cfg),
  70. referentAuth: referentAuth,
  71. cache: make(map[string]*awssm.GetSecretValueOutput),
  72. }, nil
  73. }
  74. func (sm *SecretsManager) fetch(ctx context.Context, ref esv1beta1.ExternalSecretDataRemoteRef) (*awssm.GetSecretValueOutput, error) {
  75. ver := "AWSCURRENT"
  76. valueFrom := "SECRET"
  77. if ref.Version != "" {
  78. ver = ref.Version
  79. }
  80. if ref.MetadataPolicy == esv1beta1.ExternalSecretMetadataPolicyFetch {
  81. valueFrom = "TAG"
  82. }
  83. log.Info("fetching secret value", "key", ref.Key, "version", ver, "value", valueFrom)
  84. cacheKey := fmt.Sprintf("%s#%s#%s", ref.Key, ver, valueFrom)
  85. if secretOut, found := sm.cache[cacheKey]; found {
  86. log.Info("found secret in cache", "key", ref.Key, "version", ver)
  87. return secretOut, nil
  88. }
  89. var secretOut *awssm.GetSecretValueOutput
  90. var err error
  91. if ref.MetadataPolicy == esv1beta1.ExternalSecretMetadataPolicyFetch {
  92. describeSecretInput := &awssm.DescribeSecretInput{
  93. SecretId: &ref.Key,
  94. }
  95. descOutput, err := sm.client.DescribeSecretWithContext(ctx, describeSecretInput)
  96. if err != nil {
  97. return nil, err
  98. }
  99. log.Info("found metadata secret", "key", ref.Key, "output", descOutput)
  100. jsonTags, err := util.SecretTagsToJSONString(descOutput.Tags)
  101. if err != nil {
  102. return nil, err
  103. }
  104. secretOut = &awssm.GetSecretValueOutput{
  105. ARN: descOutput.ARN,
  106. CreatedDate: descOutput.CreatedDate,
  107. Name: descOutput.Name,
  108. SecretString: &jsonTags,
  109. VersionId: &ver,
  110. }
  111. } else {
  112. var getSecretValueInput *awssm.GetSecretValueInput
  113. if strings.HasPrefix(ver, "uuid/") {
  114. versionID := strings.TrimPrefix(ver, "uuid/")
  115. getSecretValueInput = &awssm.GetSecretValueInput{
  116. SecretId: &ref.Key,
  117. VersionId: &versionID,
  118. }
  119. } else {
  120. getSecretValueInput = &awssm.GetSecretValueInput{
  121. SecretId: &ref.Key,
  122. VersionStage: &ver,
  123. }
  124. }
  125. secretOut, err = sm.client.GetSecretValue(getSecretValueInput)
  126. metrics.ObserveAPICall(constants.ProviderAWSSM, constants.CallAWSSMGetSecretValue, err)
  127. var nf *awssm.ResourceNotFoundException
  128. if errors.As(err, &nf) {
  129. return nil, esv1beta1.NoSecretErr
  130. }
  131. if err != nil {
  132. return nil, err
  133. }
  134. }
  135. sm.cache[cacheKey] = secretOut
  136. return secretOut, nil
  137. }
  138. func (sm *SecretsManager) DeleteSecret(ctx context.Context, remoteRef esv1beta1.PushRemoteRef) error {
  139. secretName := remoteRef.GetRemoteKey()
  140. secretValue := awssm.GetSecretValueInput{
  141. SecretId: &secretName,
  142. }
  143. secretInput := awssm.DescribeSecretInput{
  144. SecretId: &secretName,
  145. }
  146. awsSecret, err := sm.client.GetSecretValueWithContext(ctx, &secretValue)
  147. metrics.ObserveAPICall(constants.ProviderAWSSM, constants.CallAWSSMGetSecretValue, err)
  148. var aerr awserr.Error
  149. if err != nil {
  150. if ok := errors.As(err, &aerr); !ok {
  151. return err
  152. }
  153. if aerr.Code() == awssm.ErrCodeResourceNotFoundException {
  154. return nil
  155. }
  156. return err
  157. }
  158. data, err := sm.client.DescribeSecretWithContext(ctx, &secretInput)
  159. metrics.ObserveAPICall(constants.ProviderAWSSM, constants.CallAWSSMDescribeSecret, err)
  160. if err != nil {
  161. return err
  162. }
  163. if !isManagedByESO(data) {
  164. return nil
  165. }
  166. deleteInput := &awssm.DeleteSecretInput{
  167. SecretId: awsSecret.ARN,
  168. }
  169. _, err = sm.client.DeleteSecretWithContext(ctx, deleteInput)
  170. metrics.ObserveAPICall(constants.ProviderAWSSM, constants.CallAWSSMDeleteSecret, err)
  171. return err
  172. }
  173. func (sm *SecretsManager) PushSecret(ctx context.Context, value []byte, _ *apiextensionsv1.JSON, remoteRef esv1beta1.PushRemoteRef) error {
  174. secretName := remoteRef.GetRemoteKey()
  175. managedBy := managedBy
  176. externalSecrets := externalSecrets
  177. externalSecretsTag := []*awssm.Tag{
  178. {
  179. Key: &managedBy,
  180. Value: &externalSecrets,
  181. },
  182. }
  183. secretValue := awssm.GetSecretValueInput{
  184. SecretId: &secretName,
  185. }
  186. secretInput := awssm.DescribeSecretInput{
  187. SecretId: &secretName,
  188. }
  189. awsSecret, err := sm.client.GetSecretValueWithContext(ctx, &secretValue)
  190. metrics.ObserveAPICall(constants.ProviderAWSSM, constants.CallAWSSMGetSecretValue, err)
  191. if remoteRef.GetProperty() != "" {
  192. currentSecret := sm.retrievePayload(awsSecret)
  193. if currentSecret != "" && !gjson.Valid(currentSecret) {
  194. return errors.New("PushSecret for aws secrets manager with a remoteRef property requires a json secret")
  195. }
  196. value, _ = sjson.SetBytes([]byte(currentSecret), remoteRef.GetProperty(), value)
  197. }
  198. var aerr awserr.Error
  199. if err != nil {
  200. if ok := errors.As(err, &aerr); !ok {
  201. return err
  202. }
  203. if aerr.Code() == awssm.ErrCodeResourceNotFoundException {
  204. secretVersion := initialVersion
  205. secretRequest := awssm.CreateSecretInput{
  206. Name: &secretName,
  207. SecretBinary: value,
  208. Tags: externalSecretsTag,
  209. ClientRequestToken: &secretVersion,
  210. }
  211. _, err = sm.client.CreateSecretWithContext(ctx, &secretRequest)
  212. metrics.ObserveAPICall(constants.ProviderAWSSM, constants.CallAWSSMCreateSecret, err)
  213. return err
  214. }
  215. return err
  216. }
  217. data, err := sm.client.DescribeSecretWithContext(ctx, &secretInput)
  218. metrics.ObserveAPICall(constants.ProviderAWSSM, constants.CallAWSSMDescribeSecret, err)
  219. if err != nil {
  220. return err
  221. }
  222. if !isManagedByESO(data) {
  223. return fmt.Errorf("secret not managed by external-secrets")
  224. }
  225. if awsSecret != nil && bytes.Equal(awsSecret.SecretBinary, value) {
  226. return nil
  227. }
  228. newVersionNumber, err := bumpVersionNumber(awsSecret.VersionId)
  229. if err != nil {
  230. return err
  231. }
  232. input := &awssm.PutSecretValueInput{
  233. SecretId: awsSecret.ARN,
  234. SecretBinary: value,
  235. ClientRequestToken: newVersionNumber,
  236. }
  237. _, err = sm.client.PutSecretValueWithContext(ctx, input)
  238. metrics.ObserveAPICall(constants.ProviderAWSSM, constants.CallAWSSMPutSecretValue, err)
  239. return err
  240. }
  241. func padOrTrim(b []byte) []byte {
  242. l := len(b)
  243. size := 16
  244. if l == size {
  245. return b
  246. }
  247. if l > size {
  248. return b[l-size:]
  249. }
  250. tmp := make([]byte, size)
  251. copy(tmp[size-l:], b)
  252. return tmp
  253. }
  254. func bumpVersionNumber(id *string) (*string, error) {
  255. if id == nil {
  256. output := initialVersion
  257. return &output, nil
  258. }
  259. n := new(big.Int)
  260. oldVersion, ok := n.SetString(strings.ReplaceAll(*id, "-", ""), 16)
  261. if !ok {
  262. return nil, fmt.Errorf("expected secret version in AWS SSM to be a UUID but got '%s'", *id)
  263. }
  264. newVersionRaw := oldVersion.Add(oldVersion, big.NewInt(1)).Bytes()
  265. newVersion, err := uuid.FromBytes(padOrTrim(newVersionRaw))
  266. if err != nil {
  267. return nil, err
  268. }
  269. s := newVersion.String()
  270. return &s, nil
  271. }
  272. func isManagedByESO(data *awssm.DescribeSecretOutput) bool {
  273. managedBy := managedBy
  274. externalSecrets := externalSecrets
  275. for _, tag := range data.Tags {
  276. if *tag.Key == managedBy && *tag.Value == externalSecrets {
  277. return true
  278. }
  279. }
  280. return false
  281. }
  282. // GetAllSecrets syncs multiple secrets from aws provider into a single Kubernetes Secret.
  283. func (sm *SecretsManager) GetAllSecrets(ctx context.Context, ref esv1beta1.ExternalSecretFind) (map[string][]byte, error) {
  284. if ref.Name != nil {
  285. return sm.findByName(ctx, ref)
  286. }
  287. if len(ref.Tags) > 0 {
  288. return sm.findByTags(ctx, ref)
  289. }
  290. return nil, errors.New(errUnexpectedFindOperator)
  291. }
  292. func (sm *SecretsManager) findByName(ctx context.Context, ref esv1beta1.ExternalSecretFind) (map[string][]byte, error) {
  293. matcher, err := find.New(*ref.Name)
  294. if err != nil {
  295. return nil, err
  296. }
  297. filters := make([]*awssm.Filter, 0)
  298. if ref.Path != nil {
  299. filters = append(filters, &awssm.Filter{
  300. Key: utilpointer.To(awssm.FilterNameStringTypeName),
  301. Values: []*string{
  302. ref.Path,
  303. },
  304. })
  305. }
  306. data := make(map[string][]byte)
  307. var nextToken *string
  308. for {
  309. it, err := sm.client.ListSecrets(&awssm.ListSecretsInput{
  310. Filters: filters,
  311. NextToken: nextToken,
  312. })
  313. metrics.ObserveAPICall(constants.ProviderAWSSM, constants.CallAWSSMListSecrets, err)
  314. if err != nil {
  315. return nil, err
  316. }
  317. log.V(1).Info("aws sm findByName found", "secrets", len(it.SecretList))
  318. for _, secret := range it.SecretList {
  319. if !matcher.MatchName(*secret.Name) {
  320. continue
  321. }
  322. log.V(1).Info("aws sm findByName matches", "name", *secret.Name)
  323. err = sm.fetchAndSet(ctx, data, *secret.Name)
  324. if err != nil {
  325. return nil, err
  326. }
  327. }
  328. nextToken = it.NextToken
  329. if nextToken == nil {
  330. break
  331. }
  332. }
  333. return data, nil
  334. }
  335. func (sm *SecretsManager) findByTags(ctx context.Context, ref esv1beta1.ExternalSecretFind) (map[string][]byte, error) {
  336. filters := make([]*awssm.Filter, 0)
  337. for k, v := range ref.Tags {
  338. filters = append(filters, &awssm.Filter{
  339. Key: utilpointer.To(awssm.FilterNameStringTypeTagKey),
  340. Values: []*string{
  341. utilpointer.To(k),
  342. },
  343. }, &awssm.Filter{
  344. Key: utilpointer.To(awssm.FilterNameStringTypeTagValue),
  345. Values: []*string{
  346. utilpointer.To(v),
  347. },
  348. })
  349. }
  350. if ref.Path != nil {
  351. filters = append(filters, &awssm.Filter{
  352. Key: utilpointer.To(awssm.FilterNameStringTypeName),
  353. Values: []*string{
  354. ref.Path,
  355. },
  356. })
  357. }
  358. data := make(map[string][]byte)
  359. var nextToken *string
  360. for {
  361. log.V(1).Info("aws sm findByTag", "nextToken", nextToken)
  362. it, err := sm.client.ListSecrets(&awssm.ListSecretsInput{
  363. Filters: filters,
  364. NextToken: nextToken,
  365. })
  366. metrics.ObserveAPICall(constants.ProviderAWSSM, constants.CallAWSSMListSecrets, err)
  367. if err != nil {
  368. return nil, err
  369. }
  370. log.V(1).Info("aws sm findByTag found", "secrets", len(it.SecretList))
  371. for _, secret := range it.SecretList {
  372. err = sm.fetchAndSet(ctx, data, *secret.Name)
  373. if err != nil {
  374. return nil, err
  375. }
  376. }
  377. nextToken = it.NextToken
  378. if nextToken == nil {
  379. break
  380. }
  381. }
  382. return data, nil
  383. }
  384. func (sm *SecretsManager) fetchAndSet(ctx context.Context, data map[string][]byte, name string) error {
  385. sec, err := sm.fetch(ctx, esv1beta1.ExternalSecretDataRemoteRef{
  386. Key: name,
  387. })
  388. if err != nil {
  389. return err
  390. }
  391. if sec.SecretString != nil {
  392. data[name] = []byte(*sec.SecretString)
  393. }
  394. if sec.SecretBinary != nil {
  395. data[name] = sec.SecretBinary
  396. }
  397. return nil
  398. }
  399. // GetSecret returns a single secret from the provider.
  400. func (sm *SecretsManager) GetSecret(ctx context.Context, ref esv1beta1.ExternalSecretDataRemoteRef) ([]byte, error) {
  401. secretOut, err := sm.fetch(ctx, ref)
  402. if errors.Is(err, esv1beta1.NoSecretErr) {
  403. return nil, err
  404. }
  405. if err != nil {
  406. return nil, util.SanitizeErr(err)
  407. }
  408. if ref.Property == "" {
  409. if secretOut.SecretString != nil {
  410. return []byte(*secretOut.SecretString), nil
  411. }
  412. if secretOut.SecretBinary != nil {
  413. return secretOut.SecretBinary, nil
  414. }
  415. return nil, fmt.Errorf("invalid secret received. no secret string nor binary for key: %s", ref.Key)
  416. }
  417. val := sm.mapSecretToGjson(secretOut, ref.Property)
  418. if !val.Exists() {
  419. return nil, fmt.Errorf("key %s does not exist in secret %s", ref.Property, ref.Key)
  420. }
  421. return []byte(val.String()), nil
  422. }
  423. func (sm *SecretsManager) mapSecretToGjson(secretOut *awssm.GetSecretValueOutput, property string) gjson.Result {
  424. payload := sm.retrievePayload(secretOut)
  425. refProperty := sm.escapeDotsIfRequired(property, payload)
  426. val := gjson.Get(payload, refProperty)
  427. return val
  428. }
  429. func (sm *SecretsManager) retrievePayload(secretOut *awssm.GetSecretValueOutput) string {
  430. var payload string
  431. if secretOut.SecretString != nil {
  432. payload = *secretOut.SecretString
  433. }
  434. if secretOut.SecretBinary != nil {
  435. payload = string(secretOut.SecretBinary)
  436. }
  437. return payload
  438. }
  439. func (sm *SecretsManager) escapeDotsIfRequired(currentRefProperty, payload string) string {
  440. // We need to search if a given key with a . exists before using gjson operations.
  441. idx := strings.Index(currentRefProperty, ".")
  442. refProperty := currentRefProperty
  443. if idx > -1 {
  444. refProperty = strings.ReplaceAll(currentRefProperty, ".", "\\.")
  445. val := gjson.Get(payload, refProperty)
  446. if !val.Exists() {
  447. refProperty = currentRefProperty
  448. }
  449. }
  450. return refProperty
  451. }
  452. // GetSecretMap returns multiple k/v pairs from the provider.
  453. func (sm *SecretsManager) GetSecretMap(ctx context.Context, ref esv1beta1.ExternalSecretDataRemoteRef) (map[string][]byte, error) {
  454. log.Info("fetching secret map", "key", ref.Key)
  455. data, err := sm.GetSecret(ctx, ref)
  456. if err != nil {
  457. return nil, err
  458. }
  459. kv := make(map[string]json.RawMessage)
  460. err = json.Unmarshal(data, &kv)
  461. if err != nil {
  462. return nil, fmt.Errorf("unable to unmarshal secret %s: %w", ref.Key, err)
  463. }
  464. secretData := make(map[string][]byte)
  465. for k, v := range kv {
  466. var strVal string
  467. err = json.Unmarshal(v, &strVal)
  468. if err == nil {
  469. secretData[k] = []byte(strVal)
  470. } else {
  471. secretData[k] = v
  472. }
  473. }
  474. return secretData, nil
  475. }
  476. func (sm *SecretsManager) Close(_ context.Context) error {
  477. return nil
  478. }
  479. func (sm *SecretsManager) Validate() (esv1beta1.ValidationResult, error) {
  480. // skip validation stack because it depends on the namespace
  481. // of the ExternalSecret
  482. if sm.referentAuth {
  483. return esv1beta1.ValidationResultUnknown, nil
  484. }
  485. _, err := sm.sess.Config.Credentials.Get()
  486. if err != nil {
  487. return esv1beta1.ValidationResultError, util.SanitizeErr(err)
  488. }
  489. return esv1beta1.ValidationResultReady, nil
  490. }
  491. func (sm *SecretsManager) Capabilities() esv1beta1.SecretStoreCapabilities {
  492. return esv1beta1.SecretStoreReadWrite
  493. }