keyvault.go 34 KB

12345678910111213141516171819202122232425262728293031323334353637383940414243444546474849505152535455565758596061626364656667686970717273747576777879808182838485868788899091929394959697989910010110210310410510610710810911011111211311411511611711811912012112212312412512612712812913013113213313413513613713813914014114214314414514614714814915015115215315415515615715815916016116216316416516616716816917017117217317417517617717817918018118218318418518618718818919019119219319419519619719819920020120220320420520620720820921021121221321421521621721821922022122222322422522622722822923023123223323423523623723823924024124224324424524624724824925025125225325425525625725825926026126226326426526626726826927027127227327427527627727827928028128228328428528628728828929029129229329429529629729829930030130230330430530630730830931031131231331431531631731831932032132232332432532632732832933033133233333433533633733833934034134234334434534634734834935035135235335435535635735835936036136236336436536636736836937037137237337437537637737837938038138238338438538638738838939039139239339439539639739839940040140240340440540640740840941041141241341441541641741841942042142242342442542642742842943043143243343443543643743843944044144244344444544644744844945045145245345445545645745845946046146246346446546646746846947047147247347447547647747847948048148248348448548648748848949049149249349449549649749849950050150250350450550650750850951051151251351451551651751851952052152252352452552652752852953053153253353453553653753853954054154254354454554654754854955055155255355455555655755855956056156256356456556656756856957057157257357457557657757857958058158258358458558658758858959059159259359459559659759859960060160260360460560660760860961061161261361461561661761861962062162262362462562662762862963063163263363463563663763863964064164264364464564664764864965065165265365465565665765865966066166266366466566666766866967067167267367467567667767867968068168268368468568668768868969069169269369469569669769869970070170270370470570670770870971071171271371471571671771871972072172272372472572672772872973073173273373473573673773873974074174274374474574674774874975075175275375475575675775875976076176276376476576676776876977077177277377477577677777877978078178278378478578678778878979079179279379479579679779879980080180280380480580680780880981081181281381481581681781881982082182282382482582682782882983083183283383483583683783883984084184284384484584684784884985085185285385485585685785885986086186286386486586686786886987087187287387487587687787887988088188288388488588688788888989089189289389489589689789889990090190290390490590690790890991091191291391491591691791891992092192292392492592692792892993093193293393493593693793893994094194294394494594694794894995095195295395495595695795895996096196296396496596696796896997097197297397497597697797897998098198298398498598698798898999099199299399499599699799899910001001100210031004100510061007100810091010101110121013101410151016101710181019102010211022102310241025102610271028
  1. /*
  2. Licensed under the Apache License, Version 2.0 (the "License");
  3. you may not use this file except in compliance with the License.
  4. You may obtain a copy of the License at
  5. http://www.apache.org/licenses/LICENSE-2.0
  6. Unless required by applicable law or agreed to in writing, software
  7. distributed under the License is distributed on an "AS IS" BASIS,
  8. WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
  9. See the License for the specific language governing permissions and
  10. limitations under the License.
  11. */
  12. package keyvault
  13. import (
  14. "context"
  15. "crypto/x509"
  16. b64 "encoding/base64"
  17. "encoding/json"
  18. "encoding/pem"
  19. "errors"
  20. "fmt"
  21. "os"
  22. "path"
  23. "regexp"
  24. "strings"
  25. "github.com/Azure/azure-sdk-for-go/profiles/latest/keyvault/keyvault"
  26. "github.com/Azure/go-autorest/autorest"
  27. "github.com/Azure/go-autorest/autorest/adal"
  28. "github.com/Azure/go-autorest/autorest/azure"
  29. kvauth "github.com/Azure/go-autorest/autorest/azure/auth"
  30. "github.com/AzureAD/microsoft-authentication-library-for-go/apps/confidential"
  31. "github.com/lestrrat-go/jwx/jwk"
  32. "github.com/tidwall/gjson"
  33. "golang.org/x/crypto/pkcs12"
  34. "golang.org/x/crypto/sha3"
  35. authv1 "k8s.io/api/authentication/v1"
  36. corev1 "k8s.io/api/core/v1"
  37. apiextensionsv1 "k8s.io/apiextensions-apiserver/pkg/apis/apiextensions/v1"
  38. metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
  39. "k8s.io/apimachinery/pkg/types"
  40. "k8s.io/client-go/kubernetes"
  41. kcorev1 "k8s.io/client-go/kubernetes/typed/core/v1"
  42. pointer "k8s.io/utils/ptr"
  43. "sigs.k8s.io/controller-runtime/pkg/client"
  44. ctrlcfg "sigs.k8s.io/controller-runtime/pkg/client/config"
  45. esv1beta1 "github.com/external-secrets/external-secrets/apis/externalsecrets/v1beta1"
  46. smmeta "github.com/external-secrets/external-secrets/apis/meta/v1"
  47. "github.com/external-secrets/external-secrets/pkg/constants"
  48. "github.com/external-secrets/external-secrets/pkg/metrics"
  49. "github.com/external-secrets/external-secrets/pkg/utils"
  50. )
  51. const (
  52. defaultObjType = "secret"
  53. objectTypeCert = "cert"
  54. objectTypeKey = "key"
  55. AzureDefaultAudience = "api://AzureADTokenExchange"
  56. AnnotationClientID = "azure.workload.identity/client-id"
  57. AnnotationTenantID = "azure.workload.identity/tenant-id"
  58. managerLabel = "external-secrets"
  59. errUnexpectedStoreSpec = "unexpected store spec"
  60. errMissingAuthType = "cannot initialize Azure Client: no valid authType was specified"
  61. errPropNotExist = "property %s does not exist in key %s"
  62. errTagNotExist = "tag %s does not exist"
  63. errUnknownObjectType = "unknown Azure Keyvault object Type for %s"
  64. errUnmarshalJSONData = "error unmarshalling json data: %w"
  65. errDataFromCert = "cannot get use dataFrom to get certificate secret"
  66. errDataFromKey = "cannot get use dataFrom to get key secret"
  67. errMissingTenant = "missing tenantID in store config"
  68. errMissingSecretRef = "missing secretRef in provider config"
  69. errMissingClientIDSecret = "missing accessKeyID/secretAccessKey in store config"
  70. errFindSecret = "could not find secret %s/%s: %w"
  71. errFindDataKey = "no data for %q in secret '%s/%s'"
  72. errInvalidStore = "invalid store"
  73. errInvalidStoreSpec = "invalid store spec"
  74. errInvalidStoreProv = "invalid store provider"
  75. errInvalidAzureProv = "invalid azure keyvault provider"
  76. errInvalidSecRefClientID = "invalid AuthSecretRef.ClientID: %w"
  77. errInvalidSecRefClientSecret = "invalid AuthSecretRef.ClientSecret: %w"
  78. errInvalidSARef = "invalid ServiceAccountRef: %w"
  79. errMissingWorkloadEnvVars = "missing environment variables. AZURE_CLIENT_ID, AZURE_TENANT_ID and AZURE_FEDERATED_TOKEN_FILE must be set"
  80. errReadTokenFile = "unable to read token file %s: %w"
  81. errMissingSAAnnotation = "missing service account annotation: %s"
  82. )
  83. // https://github.com/external-secrets/external-secrets/issues/644
  84. var _ esv1beta1.SecretsClient = &Azure{}
  85. var _ esv1beta1.Provider = &Azure{}
  86. // interface to keyvault.BaseClient.
  87. type SecretClient interface {
  88. GetKey(ctx context.Context, vaultBaseURL string, keyName string, keyVersion string) (result keyvault.KeyBundle, err error)
  89. GetSecret(ctx context.Context, vaultBaseURL string, secretName string, secretVersion string) (result keyvault.SecretBundle, err error)
  90. GetSecretsComplete(ctx context.Context, vaultBaseURL string, maxresults *int32) (result keyvault.SecretListResultIterator, err error)
  91. GetCertificate(ctx context.Context, vaultBaseURL string, certificateName string, certificateVersion string) (result keyvault.CertificateBundle, err error)
  92. SetSecret(ctx context.Context, vaultBaseURL string, secretName string, parameters keyvault.SecretSetParameters) (result keyvault.SecretBundle, err error)
  93. ImportKey(ctx context.Context, vaultBaseURL string, keyName string, parameters keyvault.KeyImportParameters) (result keyvault.KeyBundle, err error)
  94. ImportCertificate(ctx context.Context, vaultBaseURL string, certificateName string, parameters keyvault.CertificateImportParameters) (result keyvault.CertificateBundle, err error)
  95. DeleteCertificate(ctx context.Context, vaultBaseURL string, certificateName string) (result keyvault.DeletedCertificateBundle, err error)
  96. DeleteKey(ctx context.Context, vaultBaseURL string, keyName string) (result keyvault.DeletedKeyBundle, err error)
  97. DeleteSecret(ctx context.Context, vaultBaseURL string, secretName string) (result keyvault.DeletedSecretBundle, err error)
  98. }
  99. type Azure struct {
  100. crClient client.Client
  101. kubeClient kcorev1.CoreV1Interface
  102. store esv1beta1.GenericStore
  103. provider *esv1beta1.AzureKVProvider
  104. baseClient SecretClient
  105. namespace string
  106. }
  107. func init() {
  108. esv1beta1.Register(&Azure{}, &esv1beta1.SecretStoreProvider{
  109. AzureKV: &esv1beta1.AzureKVProvider{},
  110. })
  111. }
  112. // Capabilities return the provider supported capabilities (ReadOnly, WriteOnly, ReadWrite).
  113. func (a *Azure) Capabilities() esv1beta1.SecretStoreCapabilities {
  114. return esv1beta1.SecretStoreReadWrite
  115. }
  116. // NewClient constructs a new secrets client based on the provided store.
  117. func (a *Azure) NewClient(ctx context.Context, store esv1beta1.GenericStore, kube client.Client, namespace string) (esv1beta1.SecretsClient, error) {
  118. return newClient(ctx, store, kube, namespace)
  119. }
  120. func newClient(ctx context.Context, store esv1beta1.GenericStore, kube client.Client, namespace string) (esv1beta1.SecretsClient, error) {
  121. provider, err := getProvider(store)
  122. if err != nil {
  123. return nil, err
  124. }
  125. cfg, err := ctrlcfg.GetConfig()
  126. if err != nil {
  127. return nil, err
  128. }
  129. kubeClient, err := kubernetes.NewForConfig(cfg)
  130. if err != nil {
  131. return nil, err
  132. }
  133. az := &Azure{
  134. crClient: kube,
  135. kubeClient: kubeClient.CoreV1(),
  136. store: store,
  137. namespace: namespace,
  138. provider: provider,
  139. }
  140. // allow SecretStore controller validation to pass
  141. // when using referent namespace.
  142. if store.GetKind() == esv1beta1.ClusterSecretStoreKind &&
  143. namespace == "" &&
  144. isReferentSpec(provider) {
  145. return az, nil
  146. }
  147. var authorizer autorest.Authorizer
  148. switch *provider.AuthType {
  149. case esv1beta1.AzureManagedIdentity:
  150. authorizer, err = az.authorizerForManagedIdentity()
  151. case esv1beta1.AzureServicePrincipal:
  152. authorizer, err = az.authorizerForServicePrincipal(ctx)
  153. case esv1beta1.AzureWorkloadIdentity:
  154. authorizer, err = az.authorizerForWorkloadIdentity(ctx, NewTokenProvider)
  155. default:
  156. err = fmt.Errorf(errMissingAuthType)
  157. }
  158. cl := keyvault.New()
  159. cl.Authorizer = authorizer
  160. az.baseClient = &cl
  161. return az, err
  162. }
  163. func getProvider(store esv1beta1.GenericStore) (*esv1beta1.AzureKVProvider, error) {
  164. spc := store.GetSpec()
  165. if spc == nil || spc.Provider.AzureKV == nil {
  166. return nil, errors.New(errUnexpectedStoreSpec)
  167. }
  168. return spc.Provider.AzureKV, nil
  169. }
  170. func (a *Azure) ValidateStore(store esv1beta1.GenericStore) error {
  171. if store == nil {
  172. return fmt.Errorf(errInvalidStore)
  173. }
  174. spc := store.GetSpec()
  175. if spc == nil {
  176. return fmt.Errorf(errInvalidStoreSpec)
  177. }
  178. if spc.Provider == nil {
  179. return fmt.Errorf(errInvalidStoreProv)
  180. }
  181. p := spc.Provider.AzureKV
  182. if p == nil {
  183. return fmt.Errorf(errInvalidAzureProv)
  184. }
  185. if p.AuthSecretRef != nil {
  186. if p.AuthSecretRef.ClientID != nil {
  187. if err := utils.ValidateReferentSecretSelector(store, *p.AuthSecretRef.ClientID); err != nil {
  188. return fmt.Errorf(errInvalidSecRefClientID, err)
  189. }
  190. }
  191. if p.AuthSecretRef.ClientSecret != nil {
  192. if err := utils.ValidateReferentSecretSelector(store, *p.AuthSecretRef.ClientSecret); err != nil {
  193. return fmt.Errorf(errInvalidSecRefClientSecret, err)
  194. }
  195. }
  196. }
  197. if p.ServiceAccountRef != nil {
  198. if err := utils.ValidateReferentServiceAccountSelector(store, *p.ServiceAccountRef); err != nil {
  199. return fmt.Errorf(errInvalidSARef, err)
  200. }
  201. }
  202. return nil
  203. }
  204. func canDelete(tags map[string]*string, err error) (bool, error) {
  205. aerr := &autorest.DetailedError{}
  206. conv := errors.As(err, aerr)
  207. if err != nil && !conv {
  208. return false, fmt.Errorf("could not parse error: %w", err)
  209. }
  210. if conv && aerr.StatusCode != 404 { // Secret is already deleted, nothing to do.
  211. return false, fmt.Errorf("unexpected api error: %w", err)
  212. }
  213. if aerr.StatusCode == 404 {
  214. return false, nil
  215. }
  216. manager, ok := tags["managed-by"]
  217. if !ok || manager == nil || *manager != managerLabel {
  218. return false, fmt.Errorf("not managed by external-secrets")
  219. }
  220. return true, nil
  221. }
  222. func (a *Azure) deleteKeyVaultKey(ctx context.Context, keyName string) error {
  223. value, err := a.baseClient.GetKey(ctx, *a.provider.VaultURL, keyName, "")
  224. metrics.ObserveAPICall(constants.ProviderAzureKV, constants.CallAzureKVGetKey, err)
  225. ok, err := canDelete(value.Tags, err)
  226. if err != nil {
  227. return fmt.Errorf("error getting key %v: %w", keyName, err)
  228. }
  229. if ok {
  230. _, err = a.baseClient.DeleteKey(ctx, *a.provider.VaultURL, keyName)
  231. metrics.ObserveAPICall(constants.ProviderAzureKV, constants.CallAzureKVDeleteKey, err)
  232. if err != nil {
  233. return fmt.Errorf("error deleting key %v: %w", keyName, err)
  234. }
  235. }
  236. return nil
  237. }
  238. func (a *Azure) deleteKeyVaultSecret(ctx context.Context, secretName string) error {
  239. value, err := a.baseClient.GetSecret(ctx, *a.provider.VaultURL, secretName, "")
  240. metrics.ObserveAPICall(constants.ProviderAzureKV, constants.CallAzureKVGetSecret, err)
  241. ok, err := canDelete(value.Tags, err)
  242. if err != nil {
  243. return fmt.Errorf("error getting secret %v: %w", secretName, err)
  244. }
  245. if ok {
  246. _, err = a.baseClient.DeleteSecret(ctx, *a.provider.VaultURL, secretName)
  247. metrics.ObserveAPICall(constants.ProviderAzureKV, constants.CallAzureKVDeleteSecret, err)
  248. if err != nil {
  249. return fmt.Errorf("error deleting secret %v: %w", secretName, err)
  250. }
  251. }
  252. return nil
  253. }
  254. func (a *Azure) deleteKeyVaultCertificate(ctx context.Context, certName string) error {
  255. value, err := a.baseClient.GetCertificate(ctx, *a.provider.VaultURL, certName, "")
  256. metrics.ObserveAPICall(constants.ProviderAzureKV, constants.CallAzureKVGetCertificate, err)
  257. ok, err := canDelete(value.Tags, err)
  258. if err != nil {
  259. return fmt.Errorf("error getting certificate %v: %w", certName, err)
  260. }
  261. if ok {
  262. _, err = a.baseClient.DeleteCertificate(ctx, *a.provider.VaultURL, certName)
  263. metrics.ObserveAPICall(constants.ProviderAzureKV, constants.CallAzureKVDeleteCertificate, err)
  264. if err != nil {
  265. return fmt.Errorf("error deleting certificate %v: %w", certName, err)
  266. }
  267. }
  268. return nil
  269. }
  270. func (a *Azure) DeleteSecret(ctx context.Context, remoteRef esv1beta1.PushRemoteRef) error {
  271. objectType, secretName := getObjType(esv1beta1.ExternalSecretDataRemoteRef{Key: remoteRef.GetRemoteKey()})
  272. switch objectType {
  273. case defaultObjType:
  274. return a.deleteKeyVaultSecret(ctx, secretName)
  275. case objectTypeCert:
  276. return a.deleteKeyVaultCertificate(ctx, secretName)
  277. case objectTypeKey:
  278. return a.deleteKeyVaultKey(ctx, secretName)
  279. default:
  280. return fmt.Errorf("secret type '%v' is not supported", objectType)
  281. }
  282. }
  283. func getCertificateFromValue(value []byte) (*x509.Certificate, error) {
  284. // 1st: try decode pkcs12
  285. _, localCert, err := pkcs12.Decode(value, "")
  286. if err == nil {
  287. return localCert, nil
  288. }
  289. // 2nd: try DER
  290. localCert, err = x509.ParseCertificate(value)
  291. if err == nil {
  292. return localCert, nil
  293. }
  294. // 3nd: parse PEM blocks
  295. for {
  296. block, rest := pem.Decode(value)
  297. value = rest
  298. if block == nil {
  299. break
  300. }
  301. cert, err := x509.ParseCertificate(block.Bytes)
  302. if err == nil {
  303. return cert, nil
  304. }
  305. }
  306. return nil, fmt.Errorf("could not parse certificate value as PKCS#12, DER or PEM")
  307. }
  308. func getKeyFromValue(value []byte) (interface{}, error) {
  309. val := value
  310. pemBlock, _ := pem.Decode(value)
  311. // if a private key regular expression doesn't match, we should consider this key to be symmetric
  312. if pemBlock == nil {
  313. return val, nil
  314. }
  315. val = pemBlock.Bytes
  316. switch pemBlock.Type {
  317. case "PRIVATE KEY":
  318. return x509.ParsePKCS8PrivateKey(val)
  319. case "RSA PRIVATE KEY":
  320. return x509.ParsePKCS1PrivateKey(val)
  321. case "EC PRIVATE KEY":
  322. return x509.ParseECPrivateKey(val)
  323. default:
  324. return nil, fmt.Errorf("key type %v is not supported", pemBlock.Type)
  325. }
  326. }
  327. func canCreate(tags map[string]*string, err error) (bool, error) {
  328. aerr := &autorest.DetailedError{}
  329. conv := errors.As(err, aerr)
  330. if err != nil && !conv {
  331. return false, fmt.Errorf("could not parse error: %w", err)
  332. }
  333. if conv && aerr.StatusCode != 404 {
  334. return false, fmt.Errorf("unexpected api error: %w", err)
  335. }
  336. if err == nil {
  337. manager, ok := tags["managed-by"]
  338. if !ok || manager == nil || *manager != managerLabel {
  339. return false, fmt.Errorf("not managed by external-secrets")
  340. }
  341. }
  342. return true, nil
  343. }
  344. func (a *Azure) setKeyVaultSecret(ctx context.Context, secretName string, value []byte) error {
  345. secret, err := a.baseClient.GetSecret(ctx, *a.provider.VaultURL, secretName, "")
  346. metrics.ObserveAPICall(constants.ProviderAzureKV, constants.CallAzureKVGetSecret, err)
  347. ok, err := canCreate(secret.Tags, err)
  348. if err != nil {
  349. return fmt.Errorf("cannot get secret %v: %w", secretName, err)
  350. }
  351. if !ok {
  352. return nil
  353. }
  354. val := string(value)
  355. if secret.Value != nil && val == *secret.Value {
  356. return nil
  357. }
  358. secretParams := keyvault.SecretSetParameters{
  359. Value: &val,
  360. Tags: map[string]*string{
  361. "managed-by": pointer.To(managerLabel),
  362. },
  363. SecretAttributes: &keyvault.SecretAttributes{
  364. Enabled: pointer.To(true),
  365. },
  366. }
  367. _, err = a.baseClient.SetSecret(ctx, *a.provider.VaultURL, secretName, secretParams)
  368. metrics.ObserveAPICall(constants.ProviderAzureKV, constants.CallAzureKVGetSecret, err)
  369. if err != nil {
  370. return fmt.Errorf("could not set secret %v: %w", secretName, err)
  371. }
  372. return nil
  373. }
  374. func (a *Azure) setKeyVaultCertificate(ctx context.Context, secretName string, value []byte) error {
  375. val := b64.StdEncoding.EncodeToString(value)
  376. localCert, err := getCertificateFromValue(value)
  377. if err != nil {
  378. return fmt.Errorf("value from secret is not a valid certificate: %w", err)
  379. }
  380. cert, err := a.baseClient.GetCertificate(ctx, *a.provider.VaultURL, secretName, "")
  381. metrics.ObserveAPICall(constants.ProviderAzureKV, constants.CallAzureKVGetCertificate, err)
  382. ok, err := canCreate(cert.Tags, err)
  383. if err != nil {
  384. return fmt.Errorf("cannot get certificate %v: %w", secretName, err)
  385. }
  386. if !ok {
  387. return nil
  388. }
  389. b512 := sha3.Sum512(localCert.Raw)
  390. if cert.Cer != nil && b512 == sha3.Sum512(*cert.Cer) {
  391. return nil
  392. }
  393. params := keyvault.CertificateImportParameters{
  394. Base64EncodedCertificate: &val,
  395. Tags: map[string]*string{
  396. "managed-by": pointer.To(managerLabel),
  397. },
  398. }
  399. _, err = a.baseClient.ImportCertificate(ctx, *a.provider.VaultURL, secretName, params)
  400. metrics.ObserveAPICall(constants.ProviderAzureKV, constants.CallAzureKVImportCertificate, err)
  401. if err != nil {
  402. return fmt.Errorf("could not import certificate %v: %w", secretName, err)
  403. }
  404. return nil
  405. }
  406. func equalKeys(newKey, oldKey keyvault.JSONWebKey) bool {
  407. // checks for everything except KeyID and KeyOps
  408. rsaCheck := newKey.E != nil && oldKey.E != nil && *newKey.E == *oldKey.E &&
  409. newKey.N != nil && oldKey.N != nil && *newKey.N == *oldKey.N
  410. symmetricCheck := newKey.Crv == oldKey.Crv &&
  411. newKey.T != nil && oldKey.T != nil && *newKey.T == *oldKey.T &&
  412. newKey.X != nil && oldKey.X != nil && *newKey.X == *oldKey.X &&
  413. newKey.Y != nil && oldKey.Y != nil && *newKey.Y == *oldKey.Y
  414. return newKey.Kty == oldKey.Kty && (rsaCheck || symmetricCheck)
  415. }
  416. func (a *Azure) setKeyVaultKey(ctx context.Context, secretName string, value []byte) error {
  417. key, err := getKeyFromValue(value)
  418. if err != nil {
  419. return fmt.Errorf("could not load private key %v: %w", secretName, err)
  420. }
  421. jwKey, err := jwk.New(key)
  422. if err != nil {
  423. return fmt.Errorf("failed to generate a JWK from secret %v content: %w", secretName, err)
  424. }
  425. buf, err := json.Marshal(jwKey)
  426. if err != nil {
  427. return fmt.Errorf("error parsing key: %w", err)
  428. }
  429. azkey := keyvault.JSONWebKey{}
  430. err = json.Unmarshal(buf, &azkey)
  431. if err != nil {
  432. return fmt.Errorf("error unmarshalling key: %w", err)
  433. }
  434. keyFromVault, err := a.baseClient.GetKey(ctx, *a.provider.VaultURL, secretName, "")
  435. metrics.ObserveAPICall(constants.ProviderAzureKV, constants.CallAzureKVGetKey, err)
  436. ok, err := canCreate(keyFromVault.Tags, err)
  437. if err != nil {
  438. return fmt.Errorf("cannot get key %v: %w", secretName, err)
  439. }
  440. if !ok {
  441. return nil
  442. }
  443. if keyFromVault.Key != nil && equalKeys(azkey, *keyFromVault.Key) {
  444. return nil
  445. }
  446. params := keyvault.KeyImportParameters{
  447. Key: &azkey,
  448. KeyAttributes: &keyvault.KeyAttributes{},
  449. Tags: map[string]*string{
  450. "managed-by": pointer.To(managerLabel),
  451. },
  452. }
  453. _, err = a.baseClient.ImportKey(ctx, *a.provider.VaultURL, secretName, params)
  454. metrics.ObserveAPICall(constants.ProviderAzureKV, constants.CallAzureKVImportKey, err)
  455. if err != nil {
  456. return fmt.Errorf("could not import key %v: %w", secretName, err)
  457. }
  458. return nil
  459. }
  460. // PushSecret stores secrets into a Key vault instance.
  461. func (a *Azure) PushSecret(ctx context.Context, value []byte, _ *apiextensionsv1.JSON, remoteRef esv1beta1.PushRemoteRef) error {
  462. objectType, secretName := getObjType(esv1beta1.ExternalSecretDataRemoteRef{Key: remoteRef.GetRemoteKey()})
  463. switch objectType {
  464. case defaultObjType:
  465. return a.setKeyVaultSecret(ctx, secretName, value)
  466. case objectTypeCert:
  467. return a.setKeyVaultCertificate(ctx, secretName, value)
  468. case objectTypeKey:
  469. return a.setKeyVaultKey(ctx, secretName, value)
  470. default:
  471. return fmt.Errorf("secret type %v not supported", objectType)
  472. }
  473. }
  474. // Implements store.Client.GetAllSecrets Interface.
  475. // Retrieves a map[string][]byte with the secret names as key and the secret itself as the calue.
  476. func (a *Azure) GetAllSecrets(ctx context.Context, ref esv1beta1.ExternalSecretFind) (map[string][]byte, error) {
  477. basicClient := a.baseClient
  478. secretsMap := make(map[string][]byte)
  479. checkTags := len(ref.Tags) > 0
  480. checkName := ref.Name != nil && len(ref.Name.RegExp) > 0
  481. secretListIter, err := basicClient.GetSecretsComplete(ctx, *a.provider.VaultURL, nil)
  482. metrics.ObserveAPICall(constants.ProviderAzureKV, constants.CallAzureKVGetSecrets, err)
  483. err = parseError(err)
  484. if err != nil {
  485. return nil, err
  486. }
  487. for secretListIter.NotDone() {
  488. secret := secretListIter.Value()
  489. ok, secretName := isValidSecret(checkTags, checkName, ref, secret)
  490. if !ok {
  491. err = secretListIter.Next()
  492. if err != nil {
  493. return nil, err
  494. }
  495. continue
  496. }
  497. secretResp, err := basicClient.GetSecret(ctx, *a.provider.VaultURL, secretName, "")
  498. metrics.ObserveAPICall(constants.ProviderAzureKV, constants.CallAzureKVGetSecret, err)
  499. err = parseError(err)
  500. if err != nil {
  501. return nil, err
  502. }
  503. secretValue := *secretResp.Value
  504. secretsMap[secretName] = []byte(secretValue)
  505. err = secretListIter.Next()
  506. if err != nil {
  507. return nil, err
  508. }
  509. }
  510. return secretsMap, nil
  511. }
  512. // Retrieves a tag value if specified and all tags in JSON format if not.
  513. func getSecretTag(tags map[string]*string, property string) ([]byte, error) {
  514. if property == "" {
  515. secretTagsData := make(map[string]string)
  516. for k, v := range tags {
  517. secretTagsData[k] = *v
  518. }
  519. return json.Marshal(secretTagsData)
  520. }
  521. if val, exist := tags[property]; exist {
  522. return []byte(*val), nil
  523. }
  524. idx := strings.Index(property, ".")
  525. if idx < 0 {
  526. return nil, fmt.Errorf(errTagNotExist, property)
  527. }
  528. if idx > 0 {
  529. tagName := property[0:idx]
  530. if val, exist := tags[tagName]; exist {
  531. key := strings.Replace(property, tagName+".", "", 1)
  532. return getProperty(*val, key, property)
  533. }
  534. }
  535. return nil, fmt.Errorf(errTagNotExist, property)
  536. }
  537. // Retrieves a property value if specified and the secret value if not.
  538. func getProperty(secret, property, key string) ([]byte, error) {
  539. if property == "" {
  540. return []byte(secret), nil
  541. }
  542. res := gjson.Get(secret, property)
  543. if !res.Exists() {
  544. idx := strings.Index(property, ".")
  545. if idx < 0 {
  546. return nil, fmt.Errorf(errPropNotExist, property, key)
  547. }
  548. escaped := strings.ReplaceAll(property, ".", "\\.")
  549. jValue := gjson.Get(secret, escaped)
  550. if jValue.Exists() {
  551. return []byte(jValue.String()), nil
  552. }
  553. return nil, fmt.Errorf(errPropNotExist, property, key)
  554. }
  555. return []byte(res.String()), nil
  556. }
  557. func parseError(err error) error {
  558. aerr := autorest.DetailedError{}
  559. if errors.As(err, &aerr) && aerr.StatusCode == 404 {
  560. return esv1beta1.NoSecretError{}
  561. }
  562. return err
  563. }
  564. // Implements store.Client.GetSecret Interface.
  565. // Retrieves a secret/Key/Certificate/Tag with the secret name defined in ref.Name
  566. // The Object Type is defined as a prefix in the ref.Name , if no prefix is defined , we assume a secret is required.
  567. func (a *Azure) GetSecret(ctx context.Context, ref esv1beta1.ExternalSecretDataRemoteRef) ([]byte, error) {
  568. objectType, secretName := getObjType(ref)
  569. switch objectType {
  570. case defaultObjType:
  571. // returns a SecretBundle with the secret value
  572. // https://pkg.go.dev/github.com/Azure/azure-sdk-for-go/services/keyvault/v7.0/keyvault#SecretBundle
  573. secretResp, err := a.baseClient.GetSecret(ctx, *a.provider.VaultURL, secretName, ref.Version)
  574. metrics.ObserveAPICall(constants.ProviderAzureKV, constants.CallAzureKVGetSecret, err)
  575. err = parseError(err)
  576. if err != nil {
  577. return nil, err
  578. }
  579. if ref.MetadataPolicy == esv1beta1.ExternalSecretMetadataPolicyFetch {
  580. return getSecretTag(secretResp.Tags, ref.Property)
  581. }
  582. return getProperty(*secretResp.Value, ref.Property, ref.Key)
  583. case objectTypeCert:
  584. // returns a CertBundle. We return CER contents of x509 certificate
  585. // see: https://pkg.go.dev/github.com/Azure/azure-sdk-for-go/services/keyvault/v7.0/keyvault#CertificateBundle
  586. certResp, err := a.baseClient.GetCertificate(ctx, *a.provider.VaultURL, secretName, ref.Version)
  587. metrics.ObserveAPICall(constants.ProviderAzureKV, constants.CallAzureKVGetCertificate, err)
  588. err = parseError(err)
  589. if err != nil {
  590. return nil, err
  591. }
  592. if ref.MetadataPolicy == esv1beta1.ExternalSecretMetadataPolicyFetch {
  593. return getSecretTag(certResp.Tags, ref.Property)
  594. }
  595. return *certResp.Cer, nil
  596. case objectTypeKey:
  597. // returns a KeyBundle that contains a jwk
  598. // azure kv returns only public keys
  599. // see: https://pkg.go.dev/github.com/Azure/azure-sdk-for-go/services/keyvault/v7.0/keyvault#KeyBundle
  600. keyResp, err := a.baseClient.GetKey(ctx, *a.provider.VaultURL, secretName, ref.Version)
  601. metrics.ObserveAPICall(constants.ProviderAzureKV, constants.CallAzureKVGetKey, err)
  602. err = parseError(err)
  603. if err != nil {
  604. return nil, err
  605. }
  606. if ref.MetadataPolicy == esv1beta1.ExternalSecretMetadataPolicyFetch {
  607. return getSecretTag(keyResp.Tags, ref.Property)
  608. }
  609. return json.Marshal(keyResp.Key)
  610. }
  611. return nil, fmt.Errorf(errUnknownObjectType, secretName)
  612. }
  613. // returns a SecretBundle with the tags values.
  614. func (a *Azure) getSecretTags(ctx context.Context, ref esv1beta1.ExternalSecretDataRemoteRef) (map[string]*string, error) {
  615. _, secretName := getObjType(ref)
  616. secretResp, err := a.baseClient.GetSecret(ctx, *a.provider.VaultURL, secretName, ref.Version)
  617. metrics.ObserveAPICall(constants.ProviderAzureKV, constants.CallAzureKVGetSecret, err)
  618. err = parseError(err)
  619. if err != nil {
  620. return nil, err
  621. }
  622. secretTagsData := make(map[string]*string)
  623. for tagname, tagval := range secretResp.Tags {
  624. name := secretName + "_" + tagname
  625. kv := make(map[string]string)
  626. err = json.Unmarshal([]byte(*tagval), &kv)
  627. // if the tagvalue is not in JSON format then we added to secretTagsData we added as it is
  628. if err != nil {
  629. secretTagsData[name] = tagval
  630. } else {
  631. for k, v := range kv {
  632. value := v
  633. secretTagsData[name+"_"+k] = &value
  634. }
  635. }
  636. }
  637. return secretTagsData, nil
  638. }
  639. // Implements store.Client.GetSecretMap Interface.
  640. // New version of GetSecretMap.
  641. func (a *Azure) GetSecretMap(ctx context.Context, ref esv1beta1.ExternalSecretDataRemoteRef) (map[string][]byte, error) {
  642. objectType, secretName := getObjType(ref)
  643. switch objectType {
  644. case defaultObjType:
  645. data, err := a.GetSecret(ctx, ref)
  646. if err != nil {
  647. return nil, err
  648. }
  649. if ref.MetadataPolicy == esv1beta1.ExternalSecretMetadataPolicyFetch {
  650. tags, _ := a.getSecretTags(ctx, ref)
  651. return getSecretMapProperties(tags, ref.Key, ref.Property), nil
  652. }
  653. return getSecretMapMap(data)
  654. case objectTypeCert:
  655. return nil, fmt.Errorf(errDataFromCert)
  656. case objectTypeKey:
  657. return nil, fmt.Errorf(errDataFromKey)
  658. }
  659. return nil, fmt.Errorf(errUnknownObjectType, secretName)
  660. }
  661. func getSecretMapMap(data []byte) (map[string][]byte, error) {
  662. kv := make(map[string]json.RawMessage)
  663. err := json.Unmarshal(data, &kv)
  664. if err != nil {
  665. return nil, fmt.Errorf(errUnmarshalJSONData, err)
  666. }
  667. secretData := make(map[string][]byte)
  668. for k, v := range kv {
  669. var strVal string
  670. err = json.Unmarshal(v, &strVal)
  671. if err == nil {
  672. secretData[k] = []byte(strVal)
  673. } else {
  674. secretData[k] = v
  675. }
  676. }
  677. return secretData, nil
  678. }
  679. func getSecretMapProperties(tags map[string]*string, key, property string) map[string][]byte {
  680. tagByteArray := make(map[string][]byte)
  681. if property != "" {
  682. keyPropertyName := key + "_" + property
  683. singleTag, _ := getSecretTag(tags, keyPropertyName)
  684. tagByteArray[keyPropertyName] = singleTag
  685. return tagByteArray
  686. }
  687. for k, v := range tags {
  688. tagByteArray[k] = []byte(*v)
  689. }
  690. return tagByteArray
  691. }
  692. func (a *Azure) authorizerForWorkloadIdentity(ctx context.Context, tokenProvider tokenProviderFunc) (autorest.Authorizer, error) {
  693. aadEndpoint := AadEndpointForType(a.provider.EnvironmentType)
  694. kvResource := kvResourceForProviderConfig(a.provider.EnvironmentType)
  695. // if no serviceAccountRef was provided
  696. // we expect certain env vars to be present.
  697. // They are set by the azure workload identity webhook.
  698. if a.provider.ServiceAccountRef == nil {
  699. clientID := os.Getenv("AZURE_CLIENT_ID")
  700. tenantID := os.Getenv("AZURE_TENANT_ID")
  701. tokenFilePath := os.Getenv("AZURE_FEDERATED_TOKEN_FILE")
  702. if clientID == "" || tenantID == "" || tokenFilePath == "" {
  703. return nil, errors.New(errMissingWorkloadEnvVars)
  704. }
  705. token, err := os.ReadFile(tokenFilePath)
  706. if err != nil {
  707. return nil, fmt.Errorf(errReadTokenFile, tokenFilePath, err)
  708. }
  709. tp, err := tokenProvider(ctx, string(token), clientID, tenantID, aadEndpoint, kvResource)
  710. if err != nil {
  711. return nil, err
  712. }
  713. return autorest.NewBearerAuthorizer(tp), nil
  714. }
  715. ns := a.namespace
  716. if a.store.GetKind() == esv1beta1.ClusterSecretStoreKind && a.provider.ServiceAccountRef.Namespace != nil {
  717. ns = *a.provider.ServiceAccountRef.Namespace
  718. }
  719. var sa corev1.ServiceAccount
  720. err := a.crClient.Get(ctx, types.NamespacedName{
  721. Name: a.provider.ServiceAccountRef.Name,
  722. Namespace: ns,
  723. }, &sa)
  724. if err != nil {
  725. return nil, err
  726. }
  727. clientID, ok := sa.ObjectMeta.Annotations[AnnotationClientID]
  728. if !ok {
  729. return nil, fmt.Errorf(errMissingSAAnnotation, AnnotationClientID)
  730. }
  731. tenantID, ok := sa.ObjectMeta.Annotations[AnnotationTenantID]
  732. if !ok {
  733. return nil, fmt.Errorf(errMissingSAAnnotation, AnnotationTenantID)
  734. }
  735. audiences := []string{AzureDefaultAudience}
  736. if len(a.provider.ServiceAccountRef.Audiences) > 0 {
  737. audiences = append(audiences, a.provider.ServiceAccountRef.Audiences...)
  738. }
  739. token, err := FetchSAToken(ctx, ns, a.provider.ServiceAccountRef.Name, audiences, a.kubeClient)
  740. if err != nil {
  741. return nil, err
  742. }
  743. tp, err := tokenProvider(ctx, token, clientID, tenantID, aadEndpoint, kvResource)
  744. if err != nil {
  745. return nil, err
  746. }
  747. return autorest.NewBearerAuthorizer(tp), nil
  748. }
  749. func FetchSAToken(ctx context.Context, ns, name string, audiences []string, kubeClient kcorev1.CoreV1Interface) (string, error) {
  750. token, err := kubeClient.ServiceAccounts(ns).CreateToken(ctx, name, &authv1.TokenRequest{
  751. Spec: authv1.TokenRequestSpec{
  752. Audiences: audiences,
  753. },
  754. }, metav1.CreateOptions{})
  755. if err != nil {
  756. return "", err
  757. }
  758. return token.Status.Token, nil
  759. }
  760. // tokenProvider satisfies the adal.OAuthTokenProvider interface.
  761. type tokenProvider struct {
  762. accessToken string
  763. }
  764. type tokenProviderFunc func(ctx context.Context, token, clientID, tenantID, aadEndpoint, kvResource string) (adal.OAuthTokenProvider, error)
  765. func NewTokenProvider(ctx context.Context, token, clientID, tenantID, aadEndpoint, kvResource string) (adal.OAuthTokenProvider, error) {
  766. // exchange token with Azure AccessToken
  767. cred := confidential.NewCredFromAssertionCallback(func(ctx context.Context, aro confidential.AssertionRequestOptions) (string, error) {
  768. return token, nil
  769. })
  770. cClient, err := confidential.New(fmt.Sprintf("%s%s/oauth2/token", aadEndpoint, tenantID), clientID, cred)
  771. if err != nil {
  772. return nil, err
  773. }
  774. scope := kvResource
  775. // .default needs to be added to the scope
  776. if !strings.Contains(kvResource, ".default") {
  777. scope = fmt.Sprintf("%s/.default", kvResource)
  778. }
  779. authRes, err := cClient.AcquireTokenByCredential(ctx, []string{
  780. scope,
  781. })
  782. if err != nil {
  783. return nil, err
  784. }
  785. return &tokenProvider{
  786. accessToken: authRes.AccessToken,
  787. }, nil
  788. }
  789. func (t *tokenProvider) OAuthToken() string {
  790. return t.accessToken
  791. }
  792. func (a *Azure) authorizerForManagedIdentity() (autorest.Authorizer, error) {
  793. msiConfig := kvauth.NewMSIConfig()
  794. msiConfig.Resource = kvResourceForProviderConfig(a.provider.EnvironmentType)
  795. if a.provider.IdentityID != nil {
  796. msiConfig.ClientID = *a.provider.IdentityID
  797. }
  798. return msiConfig.Authorizer()
  799. }
  800. func (a *Azure) authorizerForServicePrincipal(ctx context.Context) (autorest.Authorizer, error) {
  801. if a.provider.TenantID == nil {
  802. return nil, fmt.Errorf(errMissingTenant)
  803. }
  804. if a.provider.AuthSecretRef == nil {
  805. return nil, fmt.Errorf(errMissingSecretRef)
  806. }
  807. if a.provider.AuthSecretRef.ClientID == nil || a.provider.AuthSecretRef.ClientSecret == nil {
  808. return nil, fmt.Errorf(errMissingClientIDSecret)
  809. }
  810. clusterScoped := false
  811. if a.store.GetKind() == esv1beta1.ClusterSecretStoreKind {
  812. clusterScoped = true
  813. }
  814. cid, err := a.secretKeyRef(ctx, a.namespace, *a.provider.AuthSecretRef.ClientID, clusterScoped)
  815. if err != nil {
  816. return nil, err
  817. }
  818. csec, err := a.secretKeyRef(ctx, a.namespace, *a.provider.AuthSecretRef.ClientSecret, clusterScoped)
  819. if err != nil {
  820. return nil, err
  821. }
  822. clientCredentialsConfig := kvauth.NewClientCredentialsConfig(cid, csec, *a.provider.TenantID)
  823. clientCredentialsConfig.Resource = kvResourceForProviderConfig(a.provider.EnvironmentType)
  824. clientCredentialsConfig.AADEndpoint = AadEndpointForType(a.provider.EnvironmentType)
  825. return clientCredentialsConfig.Authorizer()
  826. }
  827. // secretKeyRef fetch a secret key.
  828. func (a *Azure) secretKeyRef(ctx context.Context, namespace string, secretRef smmeta.SecretKeySelector, clusterScoped bool) (string, error) {
  829. var secret corev1.Secret
  830. ref := types.NamespacedName{
  831. Name: secretRef.Name,
  832. Namespace: namespace,
  833. }
  834. if clusterScoped && secretRef.Namespace != nil {
  835. ref.Namespace = *secretRef.Namespace
  836. }
  837. err := a.crClient.Get(ctx, ref, &secret)
  838. if err != nil {
  839. return "", fmt.Errorf(errFindSecret, ref.Namespace, ref.Name, err)
  840. }
  841. keyBytes, ok := secret.Data[secretRef.Key]
  842. if !ok {
  843. return "", fmt.Errorf(errFindDataKey, secretRef.Key, secretRef.Name, namespace)
  844. }
  845. value := strings.TrimSpace(string(keyBytes))
  846. return value, nil
  847. }
  848. func (a *Azure) Close(_ context.Context) error {
  849. return nil
  850. }
  851. func (a *Azure) Validate() (esv1beta1.ValidationResult, error) {
  852. if a.store.GetKind() == esv1beta1.ClusterSecretStoreKind && isReferentSpec(a.provider) {
  853. return esv1beta1.ValidationResultUnknown, nil
  854. }
  855. return esv1beta1.ValidationResultReady, nil
  856. }
  857. func isReferentSpec(prov *esv1beta1.AzureKVProvider) bool {
  858. if prov.AuthSecretRef != nil &&
  859. ((prov.AuthSecretRef.ClientID != nil &&
  860. prov.AuthSecretRef.ClientID.Namespace == nil) ||
  861. (prov.AuthSecretRef.ClientSecret != nil &&
  862. prov.AuthSecretRef.ClientSecret.Namespace == nil)) {
  863. return true
  864. }
  865. if prov.ServiceAccountRef != nil &&
  866. prov.ServiceAccountRef.Namespace == nil {
  867. return true
  868. }
  869. return false
  870. }
  871. func AadEndpointForType(t esv1beta1.AzureEnvironmentType) string {
  872. switch t {
  873. case esv1beta1.AzureEnvironmentPublicCloud:
  874. return azure.PublicCloud.ActiveDirectoryEndpoint
  875. case esv1beta1.AzureEnvironmentChinaCloud:
  876. return azure.ChinaCloud.ActiveDirectoryEndpoint
  877. case esv1beta1.AzureEnvironmentUSGovernmentCloud:
  878. return azure.USGovernmentCloud.ActiveDirectoryEndpoint
  879. case esv1beta1.AzureEnvironmentGermanCloud:
  880. return azure.GermanCloud.ActiveDirectoryEndpoint
  881. default:
  882. return azure.PublicCloud.ActiveDirectoryEndpoint
  883. }
  884. }
  885. func kvResourceForProviderConfig(t esv1beta1.AzureEnvironmentType) string {
  886. var res string
  887. switch t {
  888. case esv1beta1.AzureEnvironmentPublicCloud:
  889. res = azure.PublicCloud.KeyVaultEndpoint
  890. case esv1beta1.AzureEnvironmentChinaCloud:
  891. res = azure.ChinaCloud.KeyVaultEndpoint
  892. case esv1beta1.AzureEnvironmentUSGovernmentCloud:
  893. res = azure.USGovernmentCloud.KeyVaultEndpoint
  894. case esv1beta1.AzureEnvironmentGermanCloud:
  895. res = azure.GermanCloud.KeyVaultEndpoint
  896. default:
  897. res = azure.PublicCloud.KeyVaultEndpoint
  898. }
  899. return strings.TrimSuffix(res, "/")
  900. }
  901. func getObjType(ref esv1beta1.ExternalSecretDataRemoteRef) (string, string) {
  902. objectType := defaultObjType
  903. secretName := ref.Key
  904. nameSplitted := strings.Split(secretName, "/")
  905. if len(nameSplitted) > 1 {
  906. objectType = nameSplitted[0]
  907. secretName = nameSplitted[1]
  908. // TODO: later tokens can be used to read the secret tags
  909. }
  910. return objectType, secretName
  911. }
  912. func isValidSecret(checkTags, checkName bool, ref esv1beta1.ExternalSecretFind, secret keyvault.SecretItem) (bool, string) {
  913. if secret.ID == nil || !*secret.Attributes.Enabled {
  914. return false, ""
  915. }
  916. if checkTags && !okByTags(ref, secret) {
  917. return false, ""
  918. }
  919. secretName := path.Base(*secret.ID)
  920. if checkName && !okByName(ref, secretName) {
  921. return false, ""
  922. }
  923. return true, secretName
  924. }
  925. func okByName(ref esv1beta1.ExternalSecretFind, secretName string) bool {
  926. matches, _ := regexp.MatchString(ref.Name.RegExp, secretName)
  927. return matches
  928. }
  929. func okByTags(ref esv1beta1.ExternalSecretFind, secret keyvault.SecretItem) bool {
  930. tagsFound := true
  931. for k, v := range ref.Tags {
  932. if val, ok := secret.Tags[k]; !ok || *val != v {
  933. tagsFound = false
  934. break
  935. }
  936. }
  937. return tagsFound
  938. }