| 12345678910111213141516171819202122232425262728293031323334353637383940414243444546474849505152535455565758596061626364656667686970717273747576777879808182838485868788899091929394959697989910010110210310410510610710810911011111211311411511611711811912012112212312412512612712812913013113213313413513613713813914014114214314414514614714814915015115215315415515615715815916016116216316416516616716816917017117217317417517617717817918018118218318418518618718818919019119219319419519619719819920020120220320420520620720820921021121221321421521621721821922022122222322422522622722822923023123223323423523623723823924024124224324424524624724824925025125225325425525625725825926026126226326426526626726826927027127227327427527627727827928028128228328428528628728828929029129229329429529629729829930030130230330430530630730830931031131231331431531631731831932032132232332432532632732832933033133233333433533633733833934034134234334434534634734834935035135235335435535635735835936036136236336436536636736836937037137237337437537637737837938038138238338438538638738838939039139239339439539639739839940040140240340440540640740840941041141241341441541641741841942042142242342442542642742842943043143243343443543643743843944044144244344444544644744844945045145245345445545645745845946046146246346446546646746846947047147247347447547647747847948048148248348448548648748848949049149249349449549649749849950050150250350450550650750850951051151251351451551651751851952052152252352452552652752852953053153253353453553653753853954054154254354454554654754854955055155255355455555655755855956056156256356456556656756856957057157257357457557657757857958058158258358458558658758858959059159259359459559659759859960060160260360460560660760860961061161261361461561661761861962062162262362462562662762862963063163263363463563663763863964064164264364464564664764864965065165265365465565665765865966066166266366466566666766866967067167267367467567667767867968068168268368468568668768868969069169269369469569669769869970070170270370470570670770870971071171271371471571671771871972072172272372472572672772872973073173273373473573673773873974074174274374474574674774874975075175275375475575675775875976076176276376476576676776876977077177277377477577677777877978078178278378478578678778878979079179279379479579679779879980080180280380480580680780880981081181281381481581681781881982082182282382482582682782882983083183283383483583683783883984084184284384484584684784884985085185285385485585685785885986086186286386486586686786886987087187287387487587687787887988088188288388488588688788888989089189289389489589689789889990090190290390490590690790890991091191291391491591691791891992092192292392492592692792892993093193293393493593693793893994094194294394494594694794894995095195295395495595695795895996096196296396496596696796896997097197297397497597697797897998098198298398498598698798898999099199299399499599699799899910001001100210031004100510061007100810091010101110121013101410151016101710181019102010211022102310241025102610271028 |
- /*
- Licensed under the Apache License, Version 2.0 (the "License");
- you may not use this file except in compliance with the License.
- You may obtain a copy of the License at
- http://www.apache.org/licenses/LICENSE-2.0
- Unless required by applicable law or agreed to in writing, software
- distributed under the License is distributed on an "AS IS" BASIS,
- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- See the License for the specific language governing permissions and
- limitations under the License.
- */
- package keyvault
- import (
- "context"
- "crypto/x509"
- b64 "encoding/base64"
- "encoding/json"
- "encoding/pem"
- "errors"
- "fmt"
- "os"
- "path"
- "regexp"
- "strings"
- "github.com/Azure/azure-sdk-for-go/profiles/latest/keyvault/keyvault"
- "github.com/Azure/go-autorest/autorest"
- "github.com/Azure/go-autorest/autorest/adal"
- "github.com/Azure/go-autorest/autorest/azure"
- kvauth "github.com/Azure/go-autorest/autorest/azure/auth"
- "github.com/AzureAD/microsoft-authentication-library-for-go/apps/confidential"
- "github.com/lestrrat-go/jwx/jwk"
- "github.com/tidwall/gjson"
- "golang.org/x/crypto/pkcs12"
- "golang.org/x/crypto/sha3"
- authv1 "k8s.io/api/authentication/v1"
- corev1 "k8s.io/api/core/v1"
- apiextensionsv1 "k8s.io/apiextensions-apiserver/pkg/apis/apiextensions/v1"
- metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
- "k8s.io/apimachinery/pkg/types"
- "k8s.io/client-go/kubernetes"
- kcorev1 "k8s.io/client-go/kubernetes/typed/core/v1"
- pointer "k8s.io/utils/ptr"
- "sigs.k8s.io/controller-runtime/pkg/client"
- ctrlcfg "sigs.k8s.io/controller-runtime/pkg/client/config"
- esv1beta1 "github.com/external-secrets/external-secrets/apis/externalsecrets/v1beta1"
- smmeta "github.com/external-secrets/external-secrets/apis/meta/v1"
- "github.com/external-secrets/external-secrets/pkg/constants"
- "github.com/external-secrets/external-secrets/pkg/metrics"
- "github.com/external-secrets/external-secrets/pkg/utils"
- )
- const (
- defaultObjType = "secret"
- objectTypeCert = "cert"
- objectTypeKey = "key"
- AzureDefaultAudience = "api://AzureADTokenExchange"
- AnnotationClientID = "azure.workload.identity/client-id"
- AnnotationTenantID = "azure.workload.identity/tenant-id"
- managerLabel = "external-secrets"
- errUnexpectedStoreSpec = "unexpected store spec"
- errMissingAuthType = "cannot initialize Azure Client: no valid authType was specified"
- errPropNotExist = "property %s does not exist in key %s"
- errTagNotExist = "tag %s does not exist"
- errUnknownObjectType = "unknown Azure Keyvault object Type for %s"
- errUnmarshalJSONData = "error unmarshalling json data: %w"
- errDataFromCert = "cannot get use dataFrom to get certificate secret"
- errDataFromKey = "cannot get use dataFrom to get key secret"
- errMissingTenant = "missing tenantID in store config"
- errMissingSecretRef = "missing secretRef in provider config"
- errMissingClientIDSecret = "missing accessKeyID/secretAccessKey in store config"
- errFindSecret = "could not find secret %s/%s: %w"
- errFindDataKey = "no data for %q in secret '%s/%s'"
- errInvalidStore = "invalid store"
- errInvalidStoreSpec = "invalid store spec"
- errInvalidStoreProv = "invalid store provider"
- errInvalidAzureProv = "invalid azure keyvault provider"
- errInvalidSecRefClientID = "invalid AuthSecretRef.ClientID: %w"
- errInvalidSecRefClientSecret = "invalid AuthSecretRef.ClientSecret: %w"
- errInvalidSARef = "invalid ServiceAccountRef: %w"
- errMissingWorkloadEnvVars = "missing environment variables. AZURE_CLIENT_ID, AZURE_TENANT_ID and AZURE_FEDERATED_TOKEN_FILE must be set"
- errReadTokenFile = "unable to read token file %s: %w"
- errMissingSAAnnotation = "missing service account annotation: %s"
- )
- // https://github.com/external-secrets/external-secrets/issues/644
- var _ esv1beta1.SecretsClient = &Azure{}
- var _ esv1beta1.Provider = &Azure{}
- // interface to keyvault.BaseClient.
- type SecretClient interface {
- GetKey(ctx context.Context, vaultBaseURL string, keyName string, keyVersion string) (result keyvault.KeyBundle, err error)
- GetSecret(ctx context.Context, vaultBaseURL string, secretName string, secretVersion string) (result keyvault.SecretBundle, err error)
- GetSecretsComplete(ctx context.Context, vaultBaseURL string, maxresults *int32) (result keyvault.SecretListResultIterator, err error)
- GetCertificate(ctx context.Context, vaultBaseURL string, certificateName string, certificateVersion string) (result keyvault.CertificateBundle, err error)
- SetSecret(ctx context.Context, vaultBaseURL string, secretName string, parameters keyvault.SecretSetParameters) (result keyvault.SecretBundle, err error)
- ImportKey(ctx context.Context, vaultBaseURL string, keyName string, parameters keyvault.KeyImportParameters) (result keyvault.KeyBundle, err error)
- ImportCertificate(ctx context.Context, vaultBaseURL string, certificateName string, parameters keyvault.CertificateImportParameters) (result keyvault.CertificateBundle, err error)
- DeleteCertificate(ctx context.Context, vaultBaseURL string, certificateName string) (result keyvault.DeletedCertificateBundle, err error)
- DeleteKey(ctx context.Context, vaultBaseURL string, keyName string) (result keyvault.DeletedKeyBundle, err error)
- DeleteSecret(ctx context.Context, vaultBaseURL string, secretName string) (result keyvault.DeletedSecretBundle, err error)
- }
- type Azure struct {
- crClient client.Client
- kubeClient kcorev1.CoreV1Interface
- store esv1beta1.GenericStore
- provider *esv1beta1.AzureKVProvider
- baseClient SecretClient
- namespace string
- }
- func init() {
- esv1beta1.Register(&Azure{}, &esv1beta1.SecretStoreProvider{
- AzureKV: &esv1beta1.AzureKVProvider{},
- })
- }
- // Capabilities return the provider supported capabilities (ReadOnly, WriteOnly, ReadWrite).
- func (a *Azure) Capabilities() esv1beta1.SecretStoreCapabilities {
- return esv1beta1.SecretStoreReadWrite
- }
- // NewClient constructs a new secrets client based on the provided store.
- func (a *Azure) NewClient(ctx context.Context, store esv1beta1.GenericStore, kube client.Client, namespace string) (esv1beta1.SecretsClient, error) {
- return newClient(ctx, store, kube, namespace)
- }
- func newClient(ctx context.Context, store esv1beta1.GenericStore, kube client.Client, namespace string) (esv1beta1.SecretsClient, error) {
- provider, err := getProvider(store)
- if err != nil {
- return nil, err
- }
- cfg, err := ctrlcfg.GetConfig()
- if err != nil {
- return nil, err
- }
- kubeClient, err := kubernetes.NewForConfig(cfg)
- if err != nil {
- return nil, err
- }
- az := &Azure{
- crClient: kube,
- kubeClient: kubeClient.CoreV1(),
- store: store,
- namespace: namespace,
- provider: provider,
- }
- // allow SecretStore controller validation to pass
- // when using referent namespace.
- if store.GetKind() == esv1beta1.ClusterSecretStoreKind &&
- namespace == "" &&
- isReferentSpec(provider) {
- return az, nil
- }
- var authorizer autorest.Authorizer
- switch *provider.AuthType {
- case esv1beta1.AzureManagedIdentity:
- authorizer, err = az.authorizerForManagedIdentity()
- case esv1beta1.AzureServicePrincipal:
- authorizer, err = az.authorizerForServicePrincipal(ctx)
- case esv1beta1.AzureWorkloadIdentity:
- authorizer, err = az.authorizerForWorkloadIdentity(ctx, NewTokenProvider)
- default:
- err = fmt.Errorf(errMissingAuthType)
- }
- cl := keyvault.New()
- cl.Authorizer = authorizer
- az.baseClient = &cl
- return az, err
- }
- func getProvider(store esv1beta1.GenericStore) (*esv1beta1.AzureKVProvider, error) {
- spc := store.GetSpec()
- if spc == nil || spc.Provider.AzureKV == nil {
- return nil, errors.New(errUnexpectedStoreSpec)
- }
- return spc.Provider.AzureKV, nil
- }
- func (a *Azure) ValidateStore(store esv1beta1.GenericStore) error {
- if store == nil {
- return fmt.Errorf(errInvalidStore)
- }
- spc := store.GetSpec()
- if spc == nil {
- return fmt.Errorf(errInvalidStoreSpec)
- }
- if spc.Provider == nil {
- return fmt.Errorf(errInvalidStoreProv)
- }
- p := spc.Provider.AzureKV
- if p == nil {
- return fmt.Errorf(errInvalidAzureProv)
- }
- if p.AuthSecretRef != nil {
- if p.AuthSecretRef.ClientID != nil {
- if err := utils.ValidateReferentSecretSelector(store, *p.AuthSecretRef.ClientID); err != nil {
- return fmt.Errorf(errInvalidSecRefClientID, err)
- }
- }
- if p.AuthSecretRef.ClientSecret != nil {
- if err := utils.ValidateReferentSecretSelector(store, *p.AuthSecretRef.ClientSecret); err != nil {
- return fmt.Errorf(errInvalidSecRefClientSecret, err)
- }
- }
- }
- if p.ServiceAccountRef != nil {
- if err := utils.ValidateReferentServiceAccountSelector(store, *p.ServiceAccountRef); err != nil {
- return fmt.Errorf(errInvalidSARef, err)
- }
- }
- return nil
- }
- func canDelete(tags map[string]*string, err error) (bool, error) {
- aerr := &autorest.DetailedError{}
- conv := errors.As(err, aerr)
- if err != nil && !conv {
- return false, fmt.Errorf("could not parse error: %w", err)
- }
- if conv && aerr.StatusCode != 404 { // Secret is already deleted, nothing to do.
- return false, fmt.Errorf("unexpected api error: %w", err)
- }
- if aerr.StatusCode == 404 {
- return false, nil
- }
- manager, ok := tags["managed-by"]
- if !ok || manager == nil || *manager != managerLabel {
- return false, fmt.Errorf("not managed by external-secrets")
- }
- return true, nil
- }
- func (a *Azure) deleteKeyVaultKey(ctx context.Context, keyName string) error {
- value, err := a.baseClient.GetKey(ctx, *a.provider.VaultURL, keyName, "")
- metrics.ObserveAPICall(constants.ProviderAzureKV, constants.CallAzureKVGetKey, err)
- ok, err := canDelete(value.Tags, err)
- if err != nil {
- return fmt.Errorf("error getting key %v: %w", keyName, err)
- }
- if ok {
- _, err = a.baseClient.DeleteKey(ctx, *a.provider.VaultURL, keyName)
- metrics.ObserveAPICall(constants.ProviderAzureKV, constants.CallAzureKVDeleteKey, err)
- if err != nil {
- return fmt.Errorf("error deleting key %v: %w", keyName, err)
- }
- }
- return nil
- }
- func (a *Azure) deleteKeyVaultSecret(ctx context.Context, secretName string) error {
- value, err := a.baseClient.GetSecret(ctx, *a.provider.VaultURL, secretName, "")
- metrics.ObserveAPICall(constants.ProviderAzureKV, constants.CallAzureKVGetSecret, err)
- ok, err := canDelete(value.Tags, err)
- if err != nil {
- return fmt.Errorf("error getting secret %v: %w", secretName, err)
- }
- if ok {
- _, err = a.baseClient.DeleteSecret(ctx, *a.provider.VaultURL, secretName)
- metrics.ObserveAPICall(constants.ProviderAzureKV, constants.CallAzureKVDeleteSecret, err)
- if err != nil {
- return fmt.Errorf("error deleting secret %v: %w", secretName, err)
- }
- }
- return nil
- }
- func (a *Azure) deleteKeyVaultCertificate(ctx context.Context, certName string) error {
- value, err := a.baseClient.GetCertificate(ctx, *a.provider.VaultURL, certName, "")
- metrics.ObserveAPICall(constants.ProviderAzureKV, constants.CallAzureKVGetCertificate, err)
- ok, err := canDelete(value.Tags, err)
- if err != nil {
- return fmt.Errorf("error getting certificate %v: %w", certName, err)
- }
- if ok {
- _, err = a.baseClient.DeleteCertificate(ctx, *a.provider.VaultURL, certName)
- metrics.ObserveAPICall(constants.ProviderAzureKV, constants.CallAzureKVDeleteCertificate, err)
- if err != nil {
- return fmt.Errorf("error deleting certificate %v: %w", certName, err)
- }
- }
- return nil
- }
- func (a *Azure) DeleteSecret(ctx context.Context, remoteRef esv1beta1.PushRemoteRef) error {
- objectType, secretName := getObjType(esv1beta1.ExternalSecretDataRemoteRef{Key: remoteRef.GetRemoteKey()})
- switch objectType {
- case defaultObjType:
- return a.deleteKeyVaultSecret(ctx, secretName)
- case objectTypeCert:
- return a.deleteKeyVaultCertificate(ctx, secretName)
- case objectTypeKey:
- return a.deleteKeyVaultKey(ctx, secretName)
- default:
- return fmt.Errorf("secret type '%v' is not supported", objectType)
- }
- }
- func getCertificateFromValue(value []byte) (*x509.Certificate, error) {
- // 1st: try decode pkcs12
- _, localCert, err := pkcs12.Decode(value, "")
- if err == nil {
- return localCert, nil
- }
- // 2nd: try DER
- localCert, err = x509.ParseCertificate(value)
- if err == nil {
- return localCert, nil
- }
- // 3nd: parse PEM blocks
- for {
- block, rest := pem.Decode(value)
- value = rest
- if block == nil {
- break
- }
- cert, err := x509.ParseCertificate(block.Bytes)
- if err == nil {
- return cert, nil
- }
- }
- return nil, fmt.Errorf("could not parse certificate value as PKCS#12, DER or PEM")
- }
- func getKeyFromValue(value []byte) (interface{}, error) {
- val := value
- pemBlock, _ := pem.Decode(value)
- // if a private key regular expression doesn't match, we should consider this key to be symmetric
- if pemBlock == nil {
- return val, nil
- }
- val = pemBlock.Bytes
- switch pemBlock.Type {
- case "PRIVATE KEY":
- return x509.ParsePKCS8PrivateKey(val)
- case "RSA PRIVATE KEY":
- return x509.ParsePKCS1PrivateKey(val)
- case "EC PRIVATE KEY":
- return x509.ParseECPrivateKey(val)
- default:
- return nil, fmt.Errorf("key type %v is not supported", pemBlock.Type)
- }
- }
- func canCreate(tags map[string]*string, err error) (bool, error) {
- aerr := &autorest.DetailedError{}
- conv := errors.As(err, aerr)
- if err != nil && !conv {
- return false, fmt.Errorf("could not parse error: %w", err)
- }
- if conv && aerr.StatusCode != 404 {
- return false, fmt.Errorf("unexpected api error: %w", err)
- }
- if err == nil {
- manager, ok := tags["managed-by"]
- if !ok || manager == nil || *manager != managerLabel {
- return false, fmt.Errorf("not managed by external-secrets")
- }
- }
- return true, nil
- }
- func (a *Azure) setKeyVaultSecret(ctx context.Context, secretName string, value []byte) error {
- secret, err := a.baseClient.GetSecret(ctx, *a.provider.VaultURL, secretName, "")
- metrics.ObserveAPICall(constants.ProviderAzureKV, constants.CallAzureKVGetSecret, err)
- ok, err := canCreate(secret.Tags, err)
- if err != nil {
- return fmt.Errorf("cannot get secret %v: %w", secretName, err)
- }
- if !ok {
- return nil
- }
- val := string(value)
- if secret.Value != nil && val == *secret.Value {
- return nil
- }
- secretParams := keyvault.SecretSetParameters{
- Value: &val,
- Tags: map[string]*string{
- "managed-by": pointer.To(managerLabel),
- },
- SecretAttributes: &keyvault.SecretAttributes{
- Enabled: pointer.To(true),
- },
- }
- _, err = a.baseClient.SetSecret(ctx, *a.provider.VaultURL, secretName, secretParams)
- metrics.ObserveAPICall(constants.ProviderAzureKV, constants.CallAzureKVGetSecret, err)
- if err != nil {
- return fmt.Errorf("could not set secret %v: %w", secretName, err)
- }
- return nil
- }
- func (a *Azure) setKeyVaultCertificate(ctx context.Context, secretName string, value []byte) error {
- val := b64.StdEncoding.EncodeToString(value)
- localCert, err := getCertificateFromValue(value)
- if err != nil {
- return fmt.Errorf("value from secret is not a valid certificate: %w", err)
- }
- cert, err := a.baseClient.GetCertificate(ctx, *a.provider.VaultURL, secretName, "")
- metrics.ObserveAPICall(constants.ProviderAzureKV, constants.CallAzureKVGetCertificate, err)
- ok, err := canCreate(cert.Tags, err)
- if err != nil {
- return fmt.Errorf("cannot get certificate %v: %w", secretName, err)
- }
- if !ok {
- return nil
- }
- b512 := sha3.Sum512(localCert.Raw)
- if cert.Cer != nil && b512 == sha3.Sum512(*cert.Cer) {
- return nil
- }
- params := keyvault.CertificateImportParameters{
- Base64EncodedCertificate: &val,
- Tags: map[string]*string{
- "managed-by": pointer.To(managerLabel),
- },
- }
- _, err = a.baseClient.ImportCertificate(ctx, *a.provider.VaultURL, secretName, params)
- metrics.ObserveAPICall(constants.ProviderAzureKV, constants.CallAzureKVImportCertificate, err)
- if err != nil {
- return fmt.Errorf("could not import certificate %v: %w", secretName, err)
- }
- return nil
- }
- func equalKeys(newKey, oldKey keyvault.JSONWebKey) bool {
- // checks for everything except KeyID and KeyOps
- rsaCheck := newKey.E != nil && oldKey.E != nil && *newKey.E == *oldKey.E &&
- newKey.N != nil && oldKey.N != nil && *newKey.N == *oldKey.N
- symmetricCheck := newKey.Crv == oldKey.Crv &&
- newKey.T != nil && oldKey.T != nil && *newKey.T == *oldKey.T &&
- newKey.X != nil && oldKey.X != nil && *newKey.X == *oldKey.X &&
- newKey.Y != nil && oldKey.Y != nil && *newKey.Y == *oldKey.Y
- return newKey.Kty == oldKey.Kty && (rsaCheck || symmetricCheck)
- }
- func (a *Azure) setKeyVaultKey(ctx context.Context, secretName string, value []byte) error {
- key, err := getKeyFromValue(value)
- if err != nil {
- return fmt.Errorf("could not load private key %v: %w", secretName, err)
- }
- jwKey, err := jwk.New(key)
- if err != nil {
- return fmt.Errorf("failed to generate a JWK from secret %v content: %w", secretName, err)
- }
- buf, err := json.Marshal(jwKey)
- if err != nil {
- return fmt.Errorf("error parsing key: %w", err)
- }
- azkey := keyvault.JSONWebKey{}
- err = json.Unmarshal(buf, &azkey)
- if err != nil {
- return fmt.Errorf("error unmarshalling key: %w", err)
- }
- keyFromVault, err := a.baseClient.GetKey(ctx, *a.provider.VaultURL, secretName, "")
- metrics.ObserveAPICall(constants.ProviderAzureKV, constants.CallAzureKVGetKey, err)
- ok, err := canCreate(keyFromVault.Tags, err)
- if err != nil {
- return fmt.Errorf("cannot get key %v: %w", secretName, err)
- }
- if !ok {
- return nil
- }
- if keyFromVault.Key != nil && equalKeys(azkey, *keyFromVault.Key) {
- return nil
- }
- params := keyvault.KeyImportParameters{
- Key: &azkey,
- KeyAttributes: &keyvault.KeyAttributes{},
- Tags: map[string]*string{
- "managed-by": pointer.To(managerLabel),
- },
- }
- _, err = a.baseClient.ImportKey(ctx, *a.provider.VaultURL, secretName, params)
- metrics.ObserveAPICall(constants.ProviderAzureKV, constants.CallAzureKVImportKey, err)
- if err != nil {
- return fmt.Errorf("could not import key %v: %w", secretName, err)
- }
- return nil
- }
- // PushSecret stores secrets into a Key vault instance.
- func (a *Azure) PushSecret(ctx context.Context, value []byte, _ *apiextensionsv1.JSON, remoteRef esv1beta1.PushRemoteRef) error {
- objectType, secretName := getObjType(esv1beta1.ExternalSecretDataRemoteRef{Key: remoteRef.GetRemoteKey()})
- switch objectType {
- case defaultObjType:
- return a.setKeyVaultSecret(ctx, secretName, value)
- case objectTypeCert:
- return a.setKeyVaultCertificate(ctx, secretName, value)
- case objectTypeKey:
- return a.setKeyVaultKey(ctx, secretName, value)
- default:
- return fmt.Errorf("secret type %v not supported", objectType)
- }
- }
- // Implements store.Client.GetAllSecrets Interface.
- // Retrieves a map[string][]byte with the secret names as key and the secret itself as the calue.
- func (a *Azure) GetAllSecrets(ctx context.Context, ref esv1beta1.ExternalSecretFind) (map[string][]byte, error) {
- basicClient := a.baseClient
- secretsMap := make(map[string][]byte)
- checkTags := len(ref.Tags) > 0
- checkName := ref.Name != nil && len(ref.Name.RegExp) > 0
- secretListIter, err := basicClient.GetSecretsComplete(ctx, *a.provider.VaultURL, nil)
- metrics.ObserveAPICall(constants.ProviderAzureKV, constants.CallAzureKVGetSecrets, err)
- err = parseError(err)
- if err != nil {
- return nil, err
- }
- for secretListIter.NotDone() {
- secret := secretListIter.Value()
- ok, secretName := isValidSecret(checkTags, checkName, ref, secret)
- if !ok {
- err = secretListIter.Next()
- if err != nil {
- return nil, err
- }
- continue
- }
- secretResp, err := basicClient.GetSecret(ctx, *a.provider.VaultURL, secretName, "")
- metrics.ObserveAPICall(constants.ProviderAzureKV, constants.CallAzureKVGetSecret, err)
- err = parseError(err)
- if err != nil {
- return nil, err
- }
- secretValue := *secretResp.Value
- secretsMap[secretName] = []byte(secretValue)
- err = secretListIter.Next()
- if err != nil {
- return nil, err
- }
- }
- return secretsMap, nil
- }
- // Retrieves a tag value if specified and all tags in JSON format if not.
- func getSecretTag(tags map[string]*string, property string) ([]byte, error) {
- if property == "" {
- secretTagsData := make(map[string]string)
- for k, v := range tags {
- secretTagsData[k] = *v
- }
- return json.Marshal(secretTagsData)
- }
- if val, exist := tags[property]; exist {
- return []byte(*val), nil
- }
- idx := strings.Index(property, ".")
- if idx < 0 {
- return nil, fmt.Errorf(errTagNotExist, property)
- }
- if idx > 0 {
- tagName := property[0:idx]
- if val, exist := tags[tagName]; exist {
- key := strings.Replace(property, tagName+".", "", 1)
- return getProperty(*val, key, property)
- }
- }
- return nil, fmt.Errorf(errTagNotExist, property)
- }
- // Retrieves a property value if specified and the secret value if not.
- func getProperty(secret, property, key string) ([]byte, error) {
- if property == "" {
- return []byte(secret), nil
- }
- res := gjson.Get(secret, property)
- if !res.Exists() {
- idx := strings.Index(property, ".")
- if idx < 0 {
- return nil, fmt.Errorf(errPropNotExist, property, key)
- }
- escaped := strings.ReplaceAll(property, ".", "\\.")
- jValue := gjson.Get(secret, escaped)
- if jValue.Exists() {
- return []byte(jValue.String()), nil
- }
- return nil, fmt.Errorf(errPropNotExist, property, key)
- }
- return []byte(res.String()), nil
- }
- func parseError(err error) error {
- aerr := autorest.DetailedError{}
- if errors.As(err, &aerr) && aerr.StatusCode == 404 {
- return esv1beta1.NoSecretError{}
- }
- return err
- }
- // Implements store.Client.GetSecret Interface.
- // Retrieves a secret/Key/Certificate/Tag with the secret name defined in ref.Name
- // The Object Type is defined as a prefix in the ref.Name , if no prefix is defined , we assume a secret is required.
- func (a *Azure) GetSecret(ctx context.Context, ref esv1beta1.ExternalSecretDataRemoteRef) ([]byte, error) {
- objectType, secretName := getObjType(ref)
- switch objectType {
- case defaultObjType:
- // returns a SecretBundle with the secret value
- // https://pkg.go.dev/github.com/Azure/azure-sdk-for-go/services/keyvault/v7.0/keyvault#SecretBundle
- secretResp, err := a.baseClient.GetSecret(ctx, *a.provider.VaultURL, secretName, ref.Version)
- metrics.ObserveAPICall(constants.ProviderAzureKV, constants.CallAzureKVGetSecret, err)
- err = parseError(err)
- if err != nil {
- return nil, err
- }
- if ref.MetadataPolicy == esv1beta1.ExternalSecretMetadataPolicyFetch {
- return getSecretTag(secretResp.Tags, ref.Property)
- }
- return getProperty(*secretResp.Value, ref.Property, ref.Key)
- case objectTypeCert:
- // returns a CertBundle. We return CER contents of x509 certificate
- // see: https://pkg.go.dev/github.com/Azure/azure-sdk-for-go/services/keyvault/v7.0/keyvault#CertificateBundle
- certResp, err := a.baseClient.GetCertificate(ctx, *a.provider.VaultURL, secretName, ref.Version)
- metrics.ObserveAPICall(constants.ProviderAzureKV, constants.CallAzureKVGetCertificate, err)
- err = parseError(err)
- if err != nil {
- return nil, err
- }
- if ref.MetadataPolicy == esv1beta1.ExternalSecretMetadataPolicyFetch {
- return getSecretTag(certResp.Tags, ref.Property)
- }
- return *certResp.Cer, nil
- case objectTypeKey:
- // returns a KeyBundle that contains a jwk
- // azure kv returns only public keys
- // see: https://pkg.go.dev/github.com/Azure/azure-sdk-for-go/services/keyvault/v7.0/keyvault#KeyBundle
- keyResp, err := a.baseClient.GetKey(ctx, *a.provider.VaultURL, secretName, ref.Version)
- metrics.ObserveAPICall(constants.ProviderAzureKV, constants.CallAzureKVGetKey, err)
- err = parseError(err)
- if err != nil {
- return nil, err
- }
- if ref.MetadataPolicy == esv1beta1.ExternalSecretMetadataPolicyFetch {
- return getSecretTag(keyResp.Tags, ref.Property)
- }
- return json.Marshal(keyResp.Key)
- }
- return nil, fmt.Errorf(errUnknownObjectType, secretName)
- }
- // returns a SecretBundle with the tags values.
- func (a *Azure) getSecretTags(ctx context.Context, ref esv1beta1.ExternalSecretDataRemoteRef) (map[string]*string, error) {
- _, secretName := getObjType(ref)
- secretResp, err := a.baseClient.GetSecret(ctx, *a.provider.VaultURL, secretName, ref.Version)
- metrics.ObserveAPICall(constants.ProviderAzureKV, constants.CallAzureKVGetSecret, err)
- err = parseError(err)
- if err != nil {
- return nil, err
- }
- secretTagsData := make(map[string]*string)
- for tagname, tagval := range secretResp.Tags {
- name := secretName + "_" + tagname
- kv := make(map[string]string)
- err = json.Unmarshal([]byte(*tagval), &kv)
- // if the tagvalue is not in JSON format then we added to secretTagsData we added as it is
- if err != nil {
- secretTagsData[name] = tagval
- } else {
- for k, v := range kv {
- value := v
- secretTagsData[name+"_"+k] = &value
- }
- }
- }
- return secretTagsData, nil
- }
- // Implements store.Client.GetSecretMap Interface.
- // New version of GetSecretMap.
- func (a *Azure) GetSecretMap(ctx context.Context, ref esv1beta1.ExternalSecretDataRemoteRef) (map[string][]byte, error) {
- objectType, secretName := getObjType(ref)
- switch objectType {
- case defaultObjType:
- data, err := a.GetSecret(ctx, ref)
- if err != nil {
- return nil, err
- }
- if ref.MetadataPolicy == esv1beta1.ExternalSecretMetadataPolicyFetch {
- tags, _ := a.getSecretTags(ctx, ref)
- return getSecretMapProperties(tags, ref.Key, ref.Property), nil
- }
- return getSecretMapMap(data)
- case objectTypeCert:
- return nil, fmt.Errorf(errDataFromCert)
- case objectTypeKey:
- return nil, fmt.Errorf(errDataFromKey)
- }
- return nil, fmt.Errorf(errUnknownObjectType, secretName)
- }
- func getSecretMapMap(data []byte) (map[string][]byte, error) {
- kv := make(map[string]json.RawMessage)
- err := json.Unmarshal(data, &kv)
- if err != nil {
- return nil, fmt.Errorf(errUnmarshalJSONData, err)
- }
- secretData := make(map[string][]byte)
- for k, v := range kv {
- var strVal string
- err = json.Unmarshal(v, &strVal)
- if err == nil {
- secretData[k] = []byte(strVal)
- } else {
- secretData[k] = v
- }
- }
- return secretData, nil
- }
- func getSecretMapProperties(tags map[string]*string, key, property string) map[string][]byte {
- tagByteArray := make(map[string][]byte)
- if property != "" {
- keyPropertyName := key + "_" + property
- singleTag, _ := getSecretTag(tags, keyPropertyName)
- tagByteArray[keyPropertyName] = singleTag
- return tagByteArray
- }
- for k, v := range tags {
- tagByteArray[k] = []byte(*v)
- }
- return tagByteArray
- }
- func (a *Azure) authorizerForWorkloadIdentity(ctx context.Context, tokenProvider tokenProviderFunc) (autorest.Authorizer, error) {
- aadEndpoint := AadEndpointForType(a.provider.EnvironmentType)
- kvResource := kvResourceForProviderConfig(a.provider.EnvironmentType)
- // if no serviceAccountRef was provided
- // we expect certain env vars to be present.
- // They are set by the azure workload identity webhook.
- if a.provider.ServiceAccountRef == nil {
- clientID := os.Getenv("AZURE_CLIENT_ID")
- tenantID := os.Getenv("AZURE_TENANT_ID")
- tokenFilePath := os.Getenv("AZURE_FEDERATED_TOKEN_FILE")
- if clientID == "" || tenantID == "" || tokenFilePath == "" {
- return nil, errors.New(errMissingWorkloadEnvVars)
- }
- token, err := os.ReadFile(tokenFilePath)
- if err != nil {
- return nil, fmt.Errorf(errReadTokenFile, tokenFilePath, err)
- }
- tp, err := tokenProvider(ctx, string(token), clientID, tenantID, aadEndpoint, kvResource)
- if err != nil {
- return nil, err
- }
- return autorest.NewBearerAuthorizer(tp), nil
- }
- ns := a.namespace
- if a.store.GetKind() == esv1beta1.ClusterSecretStoreKind && a.provider.ServiceAccountRef.Namespace != nil {
- ns = *a.provider.ServiceAccountRef.Namespace
- }
- var sa corev1.ServiceAccount
- err := a.crClient.Get(ctx, types.NamespacedName{
- Name: a.provider.ServiceAccountRef.Name,
- Namespace: ns,
- }, &sa)
- if err != nil {
- return nil, err
- }
- clientID, ok := sa.ObjectMeta.Annotations[AnnotationClientID]
- if !ok {
- return nil, fmt.Errorf(errMissingSAAnnotation, AnnotationClientID)
- }
- tenantID, ok := sa.ObjectMeta.Annotations[AnnotationTenantID]
- if !ok {
- return nil, fmt.Errorf(errMissingSAAnnotation, AnnotationTenantID)
- }
- audiences := []string{AzureDefaultAudience}
- if len(a.provider.ServiceAccountRef.Audiences) > 0 {
- audiences = append(audiences, a.provider.ServiceAccountRef.Audiences...)
- }
- token, err := FetchSAToken(ctx, ns, a.provider.ServiceAccountRef.Name, audiences, a.kubeClient)
- if err != nil {
- return nil, err
- }
- tp, err := tokenProvider(ctx, token, clientID, tenantID, aadEndpoint, kvResource)
- if err != nil {
- return nil, err
- }
- return autorest.NewBearerAuthorizer(tp), nil
- }
- func FetchSAToken(ctx context.Context, ns, name string, audiences []string, kubeClient kcorev1.CoreV1Interface) (string, error) {
- token, err := kubeClient.ServiceAccounts(ns).CreateToken(ctx, name, &authv1.TokenRequest{
- Spec: authv1.TokenRequestSpec{
- Audiences: audiences,
- },
- }, metav1.CreateOptions{})
- if err != nil {
- return "", err
- }
- return token.Status.Token, nil
- }
- // tokenProvider satisfies the adal.OAuthTokenProvider interface.
- type tokenProvider struct {
- accessToken string
- }
- type tokenProviderFunc func(ctx context.Context, token, clientID, tenantID, aadEndpoint, kvResource string) (adal.OAuthTokenProvider, error)
- func NewTokenProvider(ctx context.Context, token, clientID, tenantID, aadEndpoint, kvResource string) (adal.OAuthTokenProvider, error) {
- // exchange token with Azure AccessToken
- cred := confidential.NewCredFromAssertionCallback(func(ctx context.Context, aro confidential.AssertionRequestOptions) (string, error) {
- return token, nil
- })
- cClient, err := confidential.New(fmt.Sprintf("%s%s/oauth2/token", aadEndpoint, tenantID), clientID, cred)
- if err != nil {
- return nil, err
- }
- scope := kvResource
- // .default needs to be added to the scope
- if !strings.Contains(kvResource, ".default") {
- scope = fmt.Sprintf("%s/.default", kvResource)
- }
- authRes, err := cClient.AcquireTokenByCredential(ctx, []string{
- scope,
- })
- if err != nil {
- return nil, err
- }
- return &tokenProvider{
- accessToken: authRes.AccessToken,
- }, nil
- }
- func (t *tokenProvider) OAuthToken() string {
- return t.accessToken
- }
- func (a *Azure) authorizerForManagedIdentity() (autorest.Authorizer, error) {
- msiConfig := kvauth.NewMSIConfig()
- msiConfig.Resource = kvResourceForProviderConfig(a.provider.EnvironmentType)
- if a.provider.IdentityID != nil {
- msiConfig.ClientID = *a.provider.IdentityID
- }
- return msiConfig.Authorizer()
- }
- func (a *Azure) authorizerForServicePrincipal(ctx context.Context) (autorest.Authorizer, error) {
- if a.provider.TenantID == nil {
- return nil, fmt.Errorf(errMissingTenant)
- }
- if a.provider.AuthSecretRef == nil {
- return nil, fmt.Errorf(errMissingSecretRef)
- }
- if a.provider.AuthSecretRef.ClientID == nil || a.provider.AuthSecretRef.ClientSecret == nil {
- return nil, fmt.Errorf(errMissingClientIDSecret)
- }
- clusterScoped := false
- if a.store.GetKind() == esv1beta1.ClusterSecretStoreKind {
- clusterScoped = true
- }
- cid, err := a.secretKeyRef(ctx, a.namespace, *a.provider.AuthSecretRef.ClientID, clusterScoped)
- if err != nil {
- return nil, err
- }
- csec, err := a.secretKeyRef(ctx, a.namespace, *a.provider.AuthSecretRef.ClientSecret, clusterScoped)
- if err != nil {
- return nil, err
- }
- clientCredentialsConfig := kvauth.NewClientCredentialsConfig(cid, csec, *a.provider.TenantID)
- clientCredentialsConfig.Resource = kvResourceForProviderConfig(a.provider.EnvironmentType)
- clientCredentialsConfig.AADEndpoint = AadEndpointForType(a.provider.EnvironmentType)
- return clientCredentialsConfig.Authorizer()
- }
- // secretKeyRef fetch a secret key.
- func (a *Azure) secretKeyRef(ctx context.Context, namespace string, secretRef smmeta.SecretKeySelector, clusterScoped bool) (string, error) {
- var secret corev1.Secret
- ref := types.NamespacedName{
- Name: secretRef.Name,
- Namespace: namespace,
- }
- if clusterScoped && secretRef.Namespace != nil {
- ref.Namespace = *secretRef.Namespace
- }
- err := a.crClient.Get(ctx, ref, &secret)
- if err != nil {
- return "", fmt.Errorf(errFindSecret, ref.Namespace, ref.Name, err)
- }
- keyBytes, ok := secret.Data[secretRef.Key]
- if !ok {
- return "", fmt.Errorf(errFindDataKey, secretRef.Key, secretRef.Name, namespace)
- }
- value := strings.TrimSpace(string(keyBytes))
- return value, nil
- }
- func (a *Azure) Close(_ context.Context) error {
- return nil
- }
- func (a *Azure) Validate() (esv1beta1.ValidationResult, error) {
- if a.store.GetKind() == esv1beta1.ClusterSecretStoreKind && isReferentSpec(a.provider) {
- return esv1beta1.ValidationResultUnknown, nil
- }
- return esv1beta1.ValidationResultReady, nil
- }
- func isReferentSpec(prov *esv1beta1.AzureKVProvider) bool {
- if prov.AuthSecretRef != nil &&
- ((prov.AuthSecretRef.ClientID != nil &&
- prov.AuthSecretRef.ClientID.Namespace == nil) ||
- (prov.AuthSecretRef.ClientSecret != nil &&
- prov.AuthSecretRef.ClientSecret.Namespace == nil)) {
- return true
- }
- if prov.ServiceAccountRef != nil &&
- prov.ServiceAccountRef.Namespace == nil {
- return true
- }
- return false
- }
- func AadEndpointForType(t esv1beta1.AzureEnvironmentType) string {
- switch t {
- case esv1beta1.AzureEnvironmentPublicCloud:
- return azure.PublicCloud.ActiveDirectoryEndpoint
- case esv1beta1.AzureEnvironmentChinaCloud:
- return azure.ChinaCloud.ActiveDirectoryEndpoint
- case esv1beta1.AzureEnvironmentUSGovernmentCloud:
- return azure.USGovernmentCloud.ActiveDirectoryEndpoint
- case esv1beta1.AzureEnvironmentGermanCloud:
- return azure.GermanCloud.ActiveDirectoryEndpoint
- default:
- return azure.PublicCloud.ActiveDirectoryEndpoint
- }
- }
- func kvResourceForProviderConfig(t esv1beta1.AzureEnvironmentType) string {
- var res string
- switch t {
- case esv1beta1.AzureEnvironmentPublicCloud:
- res = azure.PublicCloud.KeyVaultEndpoint
- case esv1beta1.AzureEnvironmentChinaCloud:
- res = azure.ChinaCloud.KeyVaultEndpoint
- case esv1beta1.AzureEnvironmentUSGovernmentCloud:
- res = azure.USGovernmentCloud.KeyVaultEndpoint
- case esv1beta1.AzureEnvironmentGermanCloud:
- res = azure.GermanCloud.KeyVaultEndpoint
- default:
- res = azure.PublicCloud.KeyVaultEndpoint
- }
- return strings.TrimSuffix(res, "/")
- }
- func getObjType(ref esv1beta1.ExternalSecretDataRemoteRef) (string, string) {
- objectType := defaultObjType
- secretName := ref.Key
- nameSplitted := strings.Split(secretName, "/")
- if len(nameSplitted) > 1 {
- objectType = nameSplitted[0]
- secretName = nameSplitted[1]
- // TODO: later tokens can be used to read the secret tags
- }
- return objectType, secretName
- }
- func isValidSecret(checkTags, checkName bool, ref esv1beta1.ExternalSecretFind, secret keyvault.SecretItem) (bool, string) {
- if secret.ID == nil || !*secret.Attributes.Enabled {
- return false, ""
- }
- if checkTags && !okByTags(ref, secret) {
- return false, ""
- }
- secretName := path.Base(*secret.ID)
- if checkName && !okByName(ref, secretName) {
- return false, ""
- }
- return true, secretName
- }
- func okByName(ref esv1beta1.ExternalSecretFind, secretName string) bool {
- matches, _ := regexp.MatchString(ref.Name.RegExp, secretName)
- return matches
- }
- func okByTags(ref esv1beta1.ExternalSecretFind, secret keyvault.SecretItem) bool {
- tagsFound := true
- for k, v := range ref.Tags {
- if val, ok := secret.Tags[k]; !ok || *val != v {
- tagsFound = false
- break
- }
- }
- return tagsFound
- }
|