onepassword.go 15 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479
  1. /*
  2. Licensed under the Apache License, Version 2.0 (the "License");
  3. you may not use this file except in compliance with the License.
  4. You may obtain a copy of the License at
  5. http://www.apache.org/licenses/LICENSE-2.0
  6. Unless required by applicable law or agreed to in writing, software
  7. distributed under the License is distributed on an "AS IS" BASIS,
  8. WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
  9. See the License for the specific language governing permissions and
  10. limitations under the License.
  11. */
  12. package onepassword
  13. import (
  14. "context"
  15. "fmt"
  16. "net/url"
  17. "sort"
  18. "github.com/1Password/connect-sdk-go/connect"
  19. "github.com/1Password/connect-sdk-go/onepassword"
  20. corev1 "k8s.io/api/core/v1"
  21. apiextensionsv1 "k8s.io/apiextensions-apiserver/pkg/apis/apiextensions/v1"
  22. "k8s.io/apimachinery/pkg/types"
  23. kclient "sigs.k8s.io/controller-runtime/pkg/client"
  24. esv1beta1 "github.com/external-secrets/external-secrets/apis/externalsecrets/v1beta1"
  25. "github.com/external-secrets/external-secrets/pkg/find"
  26. "github.com/external-secrets/external-secrets/pkg/utils"
  27. )
  28. const (
  29. userAgent = "external-secrets"
  30. errOnePasswordStore = "received invalid 1Password SecretStore resource: %w"
  31. errOnePasswordStoreNilSpec = "nil spec"
  32. errOnePasswordStoreNilSpecProvider = "nil spec.provider"
  33. errOnePasswordStoreNilSpecProviderOnePassword = "nil spec.provider.onepassword"
  34. errOnePasswordStoreMissingRefName = "missing: spec.provider.onepassword.auth.secretRef.connectTokenSecretRef.name"
  35. errOnePasswordStoreMissingRefKey = "missing: spec.provider.onepassword.auth.secretRef.connectTokenSecretRef.key"
  36. errOnePasswordStoreAtLeastOneVault = "must be at least one vault: spec.provider.onepassword.vaults"
  37. errOnePasswordStoreInvalidConnectHost = "unable to parse URL: spec.provider.onepassword.connectHost: %w"
  38. errOnePasswordStoreNonUniqueVaultNumbers = "vault order numbers must be unique"
  39. errFetchK8sSecret = "could not fetch ConnectToken Secret: %w"
  40. errMissingToken = "missing Secret Token"
  41. errGetVault = "error finding 1Password Vault: %w"
  42. errExpectedOneItem = "expected one 1Password Item matching %w"
  43. errGetItem = "error finding 1Password Item: %w"
  44. errKeyNotFound = "key not found in 1Password Vaults: %w"
  45. errDocumentNotFound = "error finding 1Password Document: %w"
  46. errExpectedOneField = "expected one 1Password ItemField matching %w"
  47. errTagsNotImplemented = "'find.tags' is not implemented in the 1Password provider"
  48. errVersionNotImplemented = "'remoteRef.version' is not implemented in the 1Password provider"
  49. documentCategory = "DOCUMENT"
  50. fieldsWithLabelFormat = "'%s' in '%s', got %d"
  51. incorrectCountFormat = "'%s', got %d"
  52. )
  53. // ProviderOnePassword is a provider for 1Password.
  54. type ProviderOnePassword struct {
  55. vaults map[string]int
  56. client connect.Client
  57. }
  58. // https://github.com/external-secrets/external-secrets/issues/644
  59. var _ esv1beta1.SecretsClient = &ProviderOnePassword{}
  60. var _ esv1beta1.Provider = &ProviderOnePassword{}
  61. // Capabilities return the provider supported capabilities (ReadOnly, WriteOnly, ReadWrite).
  62. func (provider *ProviderOnePassword) Capabilities() esv1beta1.SecretStoreCapabilities {
  63. return esv1beta1.SecretStoreReadOnly
  64. }
  65. // NewClient constructs a 1Password Provider.
  66. func (provider *ProviderOnePassword) NewClient(ctx context.Context, store esv1beta1.GenericStore, kube kclient.Client, namespace string) (esv1beta1.SecretsClient, error) {
  67. config := store.GetSpec().Provider.OnePassword
  68. credentialsSecret := &corev1.Secret{}
  69. objectKey := types.NamespacedName{
  70. Name: config.Auth.SecretRef.ConnectToken.Name,
  71. Namespace: namespace,
  72. }
  73. // only ClusterSecretStore is allowed to set namespace (and then it's required)
  74. if store.GetObjectKind().GroupVersionKind().Kind == esv1beta1.ClusterSecretStoreKind {
  75. objectKey.Namespace = *config.Auth.SecretRef.ConnectToken.Namespace
  76. }
  77. err := kube.Get(ctx, objectKey, credentialsSecret)
  78. if err != nil {
  79. return nil, fmt.Errorf(errFetchK8sSecret, err)
  80. }
  81. token := credentialsSecret.Data[config.Auth.SecretRef.ConnectToken.Key]
  82. if (token == nil) || (len(token) == 0) {
  83. return nil, fmt.Errorf(errMissingToken)
  84. }
  85. provider.client = connect.NewClientWithUserAgent(config.ConnectHost, string(token), userAgent)
  86. provider.vaults = config.Vaults
  87. return provider, nil
  88. }
  89. // ValidateStore checks if the provided store is valid.
  90. func (provider *ProviderOnePassword) ValidateStore(store esv1beta1.GenericStore) error {
  91. return validateStore(store)
  92. }
  93. func validateStore(store esv1beta1.GenericStore) error {
  94. // check nils
  95. storeSpec := store.GetSpec()
  96. if storeSpec == nil {
  97. return fmt.Errorf(errOnePasswordStore, fmt.Errorf(errOnePasswordStoreNilSpec))
  98. }
  99. if storeSpec.Provider == nil {
  100. return fmt.Errorf(errOnePasswordStore, fmt.Errorf(errOnePasswordStoreNilSpecProvider))
  101. }
  102. if storeSpec.Provider.OnePassword == nil {
  103. return fmt.Errorf(errOnePasswordStore, fmt.Errorf(errOnePasswordStoreNilSpecProviderOnePassword))
  104. }
  105. // check mandatory fields
  106. config := storeSpec.Provider.OnePassword
  107. if config.Auth.SecretRef.ConnectToken.Name == "" {
  108. return fmt.Errorf(errOnePasswordStore, fmt.Errorf(errOnePasswordStoreMissingRefName))
  109. }
  110. if config.Auth.SecretRef.ConnectToken.Key == "" {
  111. return fmt.Errorf(errOnePasswordStore, fmt.Errorf(errOnePasswordStoreMissingRefKey))
  112. }
  113. // check namespace compared to kind
  114. if err := utils.ValidateSecretSelector(store, config.Auth.SecretRef.ConnectToken); err != nil {
  115. return fmt.Errorf(errOnePasswordStore, err)
  116. }
  117. // check at least one vault
  118. if len(config.Vaults) == 0 {
  119. return fmt.Errorf(errOnePasswordStore, fmt.Errorf(errOnePasswordStoreAtLeastOneVault))
  120. }
  121. // ensure vault numbers are unique
  122. if !hasUniqueVaultNumbers(config.Vaults) {
  123. return fmt.Errorf(errOnePasswordStore, fmt.Errorf(errOnePasswordStoreNonUniqueVaultNumbers))
  124. }
  125. // check valid URL
  126. if _, err := url.Parse(config.ConnectHost); err != nil {
  127. return fmt.Errorf(errOnePasswordStore, fmt.Errorf(errOnePasswordStoreInvalidConnectHost, err))
  128. }
  129. return nil
  130. }
  131. func (provider *ProviderOnePassword) DeleteSecret(_ context.Context, _ esv1beta1.PushRemoteRef) error {
  132. return fmt.Errorf("not implemented")
  133. }
  134. // Not Implemented PushSecret.
  135. func (provider *ProviderOnePassword) PushSecret(_ context.Context, _ []byte, _ *apiextensionsv1.JSON, _ esv1beta1.PushRemoteRef) error {
  136. return fmt.Errorf("not implemented")
  137. }
  138. // GetSecret returns a single secret from the provider.
  139. func (provider *ProviderOnePassword) GetSecret(_ context.Context, ref esv1beta1.ExternalSecretDataRemoteRef) ([]byte, error) {
  140. if ref.Version != "" {
  141. return nil, fmt.Errorf(errVersionNotImplemented)
  142. }
  143. item, err := provider.findItem(ref.Key)
  144. if err != nil {
  145. return nil, err
  146. }
  147. // handle files
  148. if item.Category == documentCategory {
  149. // default to the first file when ref.Property is empty
  150. return provider.getFile(item, ref.Property)
  151. }
  152. // handle fields
  153. return provider.getField(item, ref.Property)
  154. }
  155. // Validate checks if the client is configured correctly
  156. // to be able to retrieve secrets from the provider.
  157. func (provider *ProviderOnePassword) Validate() (esv1beta1.ValidationResult, error) {
  158. for vaultName := range provider.vaults {
  159. _, err := provider.client.GetVaultByTitle(vaultName)
  160. if err != nil {
  161. return esv1beta1.ValidationResultError, err
  162. }
  163. }
  164. return esv1beta1.ValidationResultReady, nil
  165. }
  166. // GetSecretMap returns multiple k/v pairs from the provider, for dataFrom.extract.
  167. func (provider *ProviderOnePassword) GetSecretMap(_ context.Context, ref esv1beta1.ExternalSecretDataRemoteRef) (map[string][]byte, error) {
  168. if ref.Version != "" {
  169. return nil, fmt.Errorf(errVersionNotImplemented)
  170. }
  171. item, err := provider.findItem(ref.Key)
  172. if err != nil {
  173. return nil, err
  174. }
  175. // handle files
  176. if item.Category == documentCategory {
  177. return provider.getFiles(item, ref.Property)
  178. }
  179. // handle fields
  180. return provider.getFields(item, ref.Property)
  181. }
  182. // GetAllSecrets syncs multiple 1Password Items into a single Kubernetes Secret, for dataFrom.find.
  183. func (provider *ProviderOnePassword) GetAllSecrets(_ context.Context, ref esv1beta1.ExternalSecretFind) (map[string][]byte, error) {
  184. if ref.Tags != nil {
  185. return nil, fmt.Errorf(errTagsNotImplemented)
  186. }
  187. secretData := make(map[string][]byte)
  188. sortedVaults := sortVaults(provider.vaults)
  189. for _, vaultName := range sortedVaults {
  190. vault, err := provider.client.GetVaultByTitle(vaultName)
  191. if err != nil {
  192. return nil, fmt.Errorf(errGetVault, err)
  193. }
  194. err = provider.getAllForVault(vault.ID, ref, secretData)
  195. if err != nil {
  196. return nil, err
  197. }
  198. }
  199. return secretData, nil
  200. }
  201. // Close closes the client connection.
  202. func (provider *ProviderOnePassword) Close(_ context.Context) error {
  203. return nil
  204. }
  205. func (provider *ProviderOnePassword) findItem(name string) (*onepassword.Item, error) {
  206. sortedVaults := sortVaults(provider.vaults)
  207. for _, vaultName := range sortedVaults {
  208. vault, err := provider.client.GetVaultByTitle(vaultName)
  209. if err != nil {
  210. return nil, fmt.Errorf(errGetVault, err)
  211. }
  212. // use GetItemsByTitle instead of GetItemByTitle in order to handle length cases
  213. items, err := provider.client.GetItemsByTitle(name, vault.ID)
  214. if err != nil {
  215. return nil, fmt.Errorf(errGetItem, err)
  216. }
  217. switch {
  218. case len(items) == 1:
  219. return provider.client.GetItemByUUID(items[0].ID, items[0].Vault.ID)
  220. case len(items) > 1:
  221. return nil, fmt.Errorf(errExpectedOneItem, fmt.Errorf(incorrectCountFormat, name, len(items)))
  222. }
  223. }
  224. return nil, fmt.Errorf(errKeyNotFound, fmt.Errorf("%s in: %v", name, provider.vaults))
  225. }
  226. func (provider *ProviderOnePassword) getField(item *onepassword.Item, property string) ([]byte, error) {
  227. // default to a field labeled "password"
  228. fieldLabel := "password"
  229. if property != "" {
  230. fieldLabel = property
  231. }
  232. if length := countFieldsWithLabel(fieldLabel, item.Fields); length != 1 {
  233. return nil, fmt.Errorf(errExpectedOneField, fmt.Errorf(fieldsWithLabelFormat, fieldLabel, item.Title, length))
  234. }
  235. // caution: do not use client.GetValue here because it has undesirable behavior on keys with a dot in them
  236. value := ""
  237. for _, field := range item.Fields {
  238. if field.Label == fieldLabel {
  239. value = field.Value
  240. break
  241. }
  242. }
  243. return []byte(value), nil
  244. }
  245. func (provider *ProviderOnePassword) getFields(item *onepassword.Item, property string) (map[string][]byte, error) {
  246. secretData := make(map[string][]byte)
  247. for _, field := range item.Fields {
  248. if property != "" && field.Label != property {
  249. continue
  250. }
  251. if length := countFieldsWithLabel(field.Label, item.Fields); length != 1 {
  252. return nil, fmt.Errorf(errExpectedOneField, fmt.Errorf(fieldsWithLabelFormat, field.Label, item.Title, length))
  253. }
  254. // caution: do not use client.GetValue here because it has undesirable behavior on keys with a dot in them
  255. secretData[field.Label] = []byte(field.Value)
  256. }
  257. return secretData, nil
  258. }
  259. func (provider *ProviderOnePassword) getAllFields(item onepassword.Item, ref esv1beta1.ExternalSecretFind, secretData map[string][]byte) error {
  260. i, err := provider.client.GetItemByUUID(item.ID, item.Vault.ID)
  261. if err != nil {
  262. return fmt.Errorf(errGetItem, err)
  263. }
  264. item = *i
  265. for _, field := range item.Fields {
  266. if length := countFieldsWithLabel(field.Label, item.Fields); length != 1 {
  267. return fmt.Errorf(errExpectedOneField, fmt.Errorf(fieldsWithLabelFormat, field.Label, item.Title, length))
  268. }
  269. if ref.Name != nil {
  270. matcher, err := find.New(*ref.Name)
  271. if err != nil {
  272. return err
  273. }
  274. if !matcher.MatchName(field.Label) {
  275. continue
  276. }
  277. }
  278. if _, ok := secretData[field.Label]; !ok {
  279. secretData[field.Label] = []byte(field.Value)
  280. }
  281. }
  282. return nil
  283. }
  284. func (provider *ProviderOnePassword) getFile(item *onepassword.Item, property string) ([]byte, error) {
  285. for _, file := range item.Files {
  286. // default to the first file when ref.Property is empty
  287. if file.Name == property || property == "" {
  288. contents, err := provider.client.GetFileContent(file)
  289. if err != nil {
  290. return nil, err
  291. }
  292. return contents, nil
  293. }
  294. }
  295. return nil, fmt.Errorf(errDocumentNotFound, fmt.Errorf("'%s', '%s'", item.Title, property))
  296. }
  297. func (provider *ProviderOnePassword) getFiles(item *onepassword.Item, property string) (map[string][]byte, error) {
  298. secretData := make(map[string][]byte)
  299. for _, file := range item.Files {
  300. if property != "" && file.Name != property {
  301. continue
  302. }
  303. contents, err := provider.client.GetFileContent(file)
  304. if err != nil {
  305. return nil, err
  306. }
  307. secretData[file.Name] = contents
  308. }
  309. return secretData, nil
  310. }
  311. func (provider *ProviderOnePassword) getAllFiles(item onepassword.Item, ref esv1beta1.ExternalSecretFind, secretData map[string][]byte) error {
  312. for _, file := range item.Files {
  313. if ref.Name != nil {
  314. matcher, err := find.New(*ref.Name)
  315. if err != nil {
  316. return err
  317. }
  318. if !matcher.MatchName(file.Name) {
  319. continue
  320. }
  321. }
  322. if _, ok := secretData[file.Name]; !ok {
  323. contents, err := provider.client.GetFileContent(file)
  324. if err != nil {
  325. return err
  326. }
  327. secretData[file.Name] = contents
  328. }
  329. }
  330. return nil
  331. }
  332. func (provider *ProviderOnePassword) getAllForVault(vaultID string, ref esv1beta1.ExternalSecretFind, secretData map[string][]byte) error {
  333. items, err := provider.client.GetItems(vaultID)
  334. if err != nil {
  335. return fmt.Errorf(errGetItem, err)
  336. }
  337. for _, item := range items {
  338. if ref.Path != nil && *ref.Path != item.Title {
  339. continue
  340. }
  341. // handle files
  342. if item.Category == documentCategory {
  343. err = provider.getAllFiles(item, ref, secretData)
  344. if err != nil {
  345. return err
  346. }
  347. continue
  348. }
  349. // handle fields
  350. err = provider.getAllFields(item, ref, secretData)
  351. if err != nil {
  352. return err
  353. }
  354. }
  355. return nil
  356. }
  357. func countFieldsWithLabel(fieldLabel string, fields []*onepassword.ItemField) int {
  358. count := 0
  359. for _, field := range fields {
  360. if field.Label == fieldLabel {
  361. count++
  362. }
  363. }
  364. return count
  365. }
  366. type orderedVault struct {
  367. Name string
  368. Order int
  369. }
  370. type orderedVaultList []orderedVault
  371. func (list orderedVaultList) Len() int { return len(list) }
  372. func (list orderedVaultList) Swap(i, j int) { list[i], list[j] = list[j], list[i] }
  373. func (list orderedVaultList) Less(i, j int) bool { return list[i].Order < list[j].Order }
  374. func sortVaults(vaults map[string]int) []string {
  375. list := make(orderedVaultList, len(vaults))
  376. index := 0
  377. for key, value := range vaults {
  378. list[index] = orderedVault{key, value}
  379. index++
  380. }
  381. sort.Sort(list)
  382. sortedVaults := []string{}
  383. for _, item := range list {
  384. sortedVaults = append(sortedVaults, item.Name)
  385. }
  386. return sortedVaults
  387. }
  388. func hasUniqueVaultNumbers(vaults map[string]int) bool {
  389. unique := make([]int, 0, len(vaults))
  390. tracker := make(map[int]bool)
  391. for _, number := range vaults {
  392. if _, ok := tracker[number]; !ok {
  393. tracker[number] = true
  394. unique = append(unique, number)
  395. }
  396. }
  397. return len(vaults) == len(unique)
  398. }
  399. func init() {
  400. esv1beta1.Register(&ProviderOnePassword{}, &esv1beta1.SecretStoreProvider{
  401. OnePassword: &esv1beta1.OnePasswordProvider{},
  402. })
  403. }