pushsecret_controller.go 15 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414
  1. /*
  2. Licensed under the Apache License, Version 2.0 (the "License");
  3. you may not use this file except in compliance with the License.
  4. You may obtain a copy of the License at
  5. http://www.apache.org/licenses/LICENSE-2.0
  6. Unless required by applicable law or agreed to in writing, software
  7. distributed under the License is distributed on an "AS IS" BASIS,
  8. WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
  9. See the License for the specific language governing permissions and
  10. limitations under the License.
  11. */
  12. package pushsecret
  13. import (
  14. "context"
  15. "fmt"
  16. "strings"
  17. "time"
  18. "github.com/go-logr/logr"
  19. v1 "k8s.io/api/core/v1"
  20. apierrors "k8s.io/apimachinery/pkg/api/errors"
  21. metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
  22. "k8s.io/apimachinery/pkg/runtime"
  23. "k8s.io/apimachinery/pkg/types"
  24. "k8s.io/client-go/tools/record"
  25. ctrl "sigs.k8s.io/controller-runtime"
  26. "sigs.k8s.io/controller-runtime/pkg/client"
  27. "sigs.k8s.io/controller-runtime/pkg/controller/controllerutil"
  28. esapi "github.com/external-secrets/external-secrets/apis/externalsecrets/v1alpha1"
  29. "github.com/external-secrets/external-secrets/apis/externalsecrets/v1beta1"
  30. ctrlmetrics "github.com/external-secrets/external-secrets/pkg/controllers/metrics"
  31. "github.com/external-secrets/external-secrets/pkg/controllers/pushsecret/psmetrics"
  32. "github.com/external-secrets/external-secrets/pkg/controllers/secretstore"
  33. )
  34. const (
  35. errFailedGetSecret = "could not get source secret"
  36. errPatchStatus = "error merging"
  37. errGetSecretStore = "could not get SecretStore %q, %w"
  38. errGetClusterSecretStore = "could not get ClusterSecretStore %q, %w"
  39. errGetProviderFailed = "could not start provider"
  40. errGetSecretsClientFailed = "could not start secrets client"
  41. errCloseStoreClient = "error when calling provider close method"
  42. errSetSecretFailed = "could not write remote ref %v to target secretstore %v: %v"
  43. errFailedSetSecret = "set secret failed: %v"
  44. pushSecretFinalizer = "pushsecret.externalsecrets.io/finalizer"
  45. )
  46. type Reconciler struct {
  47. client.Client
  48. Log logr.Logger
  49. Scheme *runtime.Scheme
  50. recorder record.EventRecorder
  51. RequeueInterval time.Duration
  52. ControllerClass string
  53. }
  54. func (r *Reconciler) Reconcile(ctx context.Context, req ctrl.Request) (ctrl.Result, error) {
  55. log := r.Log.WithValues("pushsecret", req.NamespacedName)
  56. resourceLabels := ctrlmetrics.RefineNonConditionMetricLabels(map[string]string{"name": req.Name, "namespace": req.Namespace})
  57. start := time.Now()
  58. pushSecretReconcileDuration := psmetrics.GetGaugeVec(psmetrics.PushSecretReconcileDurationKey)
  59. defer func() { pushSecretReconcileDuration.With(resourceLabels).Set(float64(time.Since(start))) }()
  60. var ps esapi.PushSecret
  61. err := r.Get(ctx, req.NamespacedName, &ps)
  62. mgr := secretstore.NewManager(r.Client, r.ControllerClass, false)
  63. defer mgr.Close(ctx)
  64. if apierrors.IsNotFound(err) {
  65. return ctrl.Result{}, nil
  66. } else if err != nil {
  67. msg := "unable to get PushSecret"
  68. r.recorder.Event(&ps, v1.EventTypeWarning, esapi.ReasonErrored, msg)
  69. log.Error(err, msg)
  70. return ctrl.Result{}, fmt.Errorf("get resource: %w", err)
  71. }
  72. refreshInt := r.RequeueInterval
  73. if ps.Spec.RefreshInterval != nil {
  74. refreshInt = ps.Spec.RefreshInterval.Duration
  75. }
  76. p := client.MergeFrom(ps.DeepCopy())
  77. defer func() {
  78. err := r.Client.Status().Patch(ctx, &ps, p)
  79. if err != nil {
  80. log.Error(err, errPatchStatus)
  81. }
  82. }()
  83. switch ps.Spec.DeletionPolicy {
  84. case esapi.PushSecretDeletionPolicyDelete:
  85. // finalizer logic. Only added if we should delete the secrets
  86. if ps.ObjectMeta.DeletionTimestamp.IsZero() {
  87. if !controllerutil.ContainsFinalizer(&ps, pushSecretFinalizer) {
  88. controllerutil.AddFinalizer(&ps, pushSecretFinalizer)
  89. err := r.Client.Update(ctx, &ps, &client.UpdateOptions{})
  90. if err != nil {
  91. return ctrl.Result{}, fmt.Errorf("could not update finalizers: %w", err)
  92. }
  93. return ctrl.Result{}, nil
  94. }
  95. } else {
  96. if controllerutil.ContainsFinalizer(&ps, pushSecretFinalizer) {
  97. // trigger a cleanup with no Synced Map
  98. badState, err := r.DeleteSecretFromProviders(ctx, &ps, esapi.SyncedPushSecretsMap{}, mgr)
  99. if err != nil {
  100. msg := fmt.Sprintf("Failed to Delete Secrets from Provider: %v", err)
  101. cond := NewPushSecretCondition(esapi.PushSecretReady, v1.ConditionFalse, esapi.ReasonErrored, msg)
  102. ps = SetPushSecretCondition(ps, *cond)
  103. r.SetSyncedSecrets(&ps, badState)
  104. r.recorder.Event(&ps, v1.EventTypeWarning, esapi.ReasonErrored, msg)
  105. return ctrl.Result{}, err
  106. }
  107. controllerutil.RemoveFinalizer(&ps, pushSecretFinalizer)
  108. err = r.Client.Update(ctx, &ps, &client.UpdateOptions{})
  109. if err != nil {
  110. return ctrl.Result{}, fmt.Errorf("could not update finalizers: %w", err)
  111. }
  112. return ctrl.Result{}, nil
  113. }
  114. }
  115. case esapi.PushSecretDeletionPolicyNone:
  116. default:
  117. }
  118. secret, err := r.GetSecret(ctx, ps)
  119. if err != nil {
  120. cond := NewPushSecretCondition(esapi.PushSecretReady, v1.ConditionFalse, esapi.ReasonErrored, errFailedGetSecret)
  121. ps = SetPushSecretCondition(ps, *cond)
  122. r.recorder.Event(&ps, v1.EventTypeWarning, esapi.ReasonErrored, errFailedGetSecret)
  123. return ctrl.Result{}, err
  124. }
  125. secretStores, err := r.GetSecretStores(ctx, ps)
  126. if err != nil {
  127. cond := NewPushSecretCondition(esapi.PushSecretReady, v1.ConditionFalse, esapi.ReasonErrored, err.Error())
  128. ps = SetPushSecretCondition(ps, *cond)
  129. r.recorder.Event(&ps, v1.EventTypeWarning, esapi.ReasonErrored, err.Error())
  130. return ctrl.Result{}, err
  131. }
  132. syncedSecrets, err := r.PushSecretToProviders(ctx, secretStores, ps, secret, mgr)
  133. if err != nil {
  134. msg := fmt.Sprintf(errFailedSetSecret, err)
  135. cond := NewPushSecretCondition(esapi.PushSecretReady, v1.ConditionFalse, esapi.ReasonErrored, msg)
  136. ps = SetPushSecretCondition(ps, *cond)
  137. totalSecrets := mergeSecretState(syncedSecrets, ps.Status.SyncedPushSecrets)
  138. r.SetSyncedSecrets(&ps, totalSecrets)
  139. r.recorder.Event(&ps, v1.EventTypeWarning, esapi.ReasonErrored, msg)
  140. return ctrl.Result{}, err
  141. }
  142. switch ps.Spec.DeletionPolicy {
  143. case esapi.PushSecretDeletionPolicyDelete:
  144. badSyncState, err := r.DeleteSecretFromProviders(ctx, &ps, syncedSecrets, mgr)
  145. if err != nil {
  146. msg := fmt.Sprintf("Failed to Delete Secrets from Provider: %v", err)
  147. cond := NewPushSecretCondition(esapi.PushSecretReady, v1.ConditionFalse, esapi.ReasonErrored, msg)
  148. ps = SetPushSecretCondition(ps, *cond)
  149. r.SetSyncedSecrets(&ps, badSyncState)
  150. r.recorder.Event(&ps, v1.EventTypeWarning, esapi.ReasonErrored, msg)
  151. return ctrl.Result{}, err
  152. }
  153. case esapi.PushSecretDeletionPolicyNone:
  154. default:
  155. }
  156. msg := "PushSecret synced successfully"
  157. cond := NewPushSecretCondition(esapi.PushSecretReady, v1.ConditionTrue, esapi.ReasonSynced, msg)
  158. ps = SetPushSecretCondition(ps, *cond)
  159. r.SetSyncedSecrets(&ps, syncedSecrets)
  160. r.recorder.Event(&ps, v1.EventTypeNormal, esapi.ReasonSynced, msg)
  161. return ctrl.Result{RequeueAfter: refreshInt}, nil
  162. }
  163. func (r *Reconciler) SetSyncedSecrets(ps *esapi.PushSecret, status esapi.SyncedPushSecretsMap) {
  164. ps.Status.SyncedPushSecrets = status
  165. }
  166. func mergeSecretState(newMap, old esapi.SyncedPushSecretsMap) esapi.SyncedPushSecretsMap {
  167. out := newMap.DeepCopy()
  168. for k, v := range old {
  169. _, ok := out[k]
  170. if !ok {
  171. out[k] = make(map[string]esapi.PushSecretData)
  172. }
  173. for kk, vv := range v {
  174. out[k][kk] = vv
  175. }
  176. }
  177. return out
  178. }
  179. func (r *Reconciler) DeleteSecretFromProviders(ctx context.Context, ps *esapi.PushSecret, newMap esapi.SyncedPushSecretsMap, mgr *secretstore.Manager) (esapi.SyncedPushSecretsMap, error) {
  180. out := mergeSecretState(newMap, ps.Status.SyncedPushSecrets)
  181. for storeName, oldData := range ps.Status.SyncedPushSecrets {
  182. storeRef := v1beta1.SecretStoreRef{
  183. Name: strings.Split(storeName, "/")[1],
  184. Kind: strings.Split(storeName, "/")[0],
  185. }
  186. client, err := mgr.Get(ctx, storeRef, ps.Namespace, nil)
  187. if err != nil {
  188. return out, fmt.Errorf("could not get secrets client for store %v: %w", storeName, err)
  189. }
  190. newData, ok := newMap[storeName]
  191. if !ok {
  192. err = r.DeleteAllSecretsFromStore(ctx, client, oldData)
  193. if err != nil {
  194. return out, err
  195. }
  196. delete(out, storeName)
  197. continue
  198. }
  199. for oldEntry, oldRef := range oldData {
  200. _, ok := newData[oldEntry]
  201. if !ok {
  202. err = r.DeleteSecretFromStore(ctx, client, oldRef)
  203. if err != nil {
  204. return out, err
  205. }
  206. delete(out[storeName], oldRef.Match.RemoteRef.RemoteKey)
  207. }
  208. }
  209. }
  210. return out, nil
  211. }
  212. func (r *Reconciler) DeleteAllSecretsFromStore(ctx context.Context, client v1beta1.SecretsClient, data map[string]esapi.PushSecretData) error {
  213. for _, v := range data {
  214. err := r.DeleteSecretFromStore(ctx, client, v)
  215. if err != nil {
  216. return err
  217. }
  218. }
  219. return nil
  220. }
  221. func (r *Reconciler) DeleteSecretFromStore(ctx context.Context, client v1beta1.SecretsClient, data esapi.PushSecretData) error {
  222. return client.DeleteSecret(ctx, data.Match.RemoteRef)
  223. }
  224. func (r *Reconciler) PushSecretToProviders(ctx context.Context, stores map[esapi.PushSecretStoreRef]v1beta1.GenericStore, ps esapi.PushSecret, secret *v1.Secret, mgr *secretstore.Manager) (esapi.SyncedPushSecretsMap, error) {
  225. out := esapi.SyncedPushSecretsMap{}
  226. for ref, store := range stores {
  227. storeKey := fmt.Sprintf("%v/%v", ref.Kind, store.GetName())
  228. out[storeKey] = make(map[string]esapi.PushSecretData)
  229. storeRef := v1beta1.SecretStoreRef{
  230. Name: store.GetName(),
  231. Kind: ref.Kind,
  232. }
  233. client, err := mgr.Get(ctx, storeRef, ps.GetNamespace(), nil)
  234. if err != nil {
  235. return out, fmt.Errorf("could not get secrets client for store %v: %w", store.GetName(), err)
  236. }
  237. for _, ref := range ps.Spec.Data {
  238. secretValue, ok := secret.Data[ref.Match.SecretKey]
  239. if !ok {
  240. return out, fmt.Errorf("secret key %v does not exist", ref.Match.SecretKey)
  241. }
  242. err := client.PushSecret(ctx, secretValue, ref.Match.RemoteRef)
  243. if err != nil {
  244. return out, fmt.Errorf(errSetSecretFailed, ref.Match.SecretKey, store.GetName(), err)
  245. }
  246. out[storeKey][statusRef(ref.Match.RemoteRef)] = ref
  247. }
  248. }
  249. return out, nil
  250. }
  251. func (r *Reconciler) GetSecret(ctx context.Context, ps esapi.PushSecret) (*v1.Secret, error) {
  252. secretName := types.NamespacedName{Name: ps.Spec.Selector.Secret.Name, Namespace: ps.Namespace}
  253. secret := &v1.Secret{}
  254. err := r.Client.Get(ctx, secretName, secret)
  255. if err != nil {
  256. return nil, err
  257. }
  258. return secret, nil
  259. }
  260. func (r *Reconciler) GetSecretStores(ctx context.Context, ps esapi.PushSecret) (map[esapi.PushSecretStoreRef]v1beta1.GenericStore, error) {
  261. stores := make(map[esapi.PushSecretStoreRef]v1beta1.GenericStore)
  262. for _, refStore := range ps.Spec.SecretStoreRefs {
  263. if refStore.LabelSelector != nil {
  264. labelSelector, err := metav1.LabelSelectorAsSelector(refStore.LabelSelector)
  265. if err != nil {
  266. return nil, fmt.Errorf("could not convert labels: %w", err)
  267. }
  268. if refStore.Kind == v1beta1.ClusterSecretStoreKind {
  269. clusterSecretStoreList := v1beta1.ClusterSecretStoreList{}
  270. err = r.List(ctx, &clusterSecretStoreList, &client.ListOptions{LabelSelector: labelSelector})
  271. if err != nil {
  272. return nil, fmt.Errorf("could not list cluster Secret Stores: %w", err)
  273. }
  274. for k, v := range clusterSecretStoreList.Items {
  275. key := esapi.PushSecretStoreRef{
  276. Name: v.Name,
  277. Kind: v1beta1.ClusterSecretStoreKind,
  278. }
  279. stores[key] = &clusterSecretStoreList.Items[k]
  280. }
  281. } else {
  282. secretStoreList := v1beta1.SecretStoreList{}
  283. err = r.List(ctx, &secretStoreList, &client.ListOptions{LabelSelector: labelSelector})
  284. if err != nil {
  285. return nil, fmt.Errorf("could not list Secret Stores: %w", err)
  286. }
  287. for k, v := range secretStoreList.Items {
  288. key := esapi.PushSecretStoreRef{
  289. Name: v.Name,
  290. Kind: v1beta1.SecretStoreKind,
  291. }
  292. stores[key] = &secretStoreList.Items[k]
  293. }
  294. }
  295. } else {
  296. store, err := r.getSecretStoreFromName(ctx, refStore, ps.Namespace)
  297. if err != nil {
  298. return nil, err
  299. }
  300. stores[refStore] = store
  301. }
  302. }
  303. return stores, nil
  304. }
  305. func (r *Reconciler) getSecretStoreFromName(ctx context.Context, refStore esapi.PushSecretStoreRef, ns string) (v1beta1.GenericStore, error) {
  306. if refStore.Name == "" {
  307. return nil, fmt.Errorf("refStore Name must be provided")
  308. }
  309. ref := types.NamespacedName{
  310. Name: refStore.Name,
  311. }
  312. if refStore.Kind == v1beta1.ClusterSecretStoreKind {
  313. var store v1beta1.ClusterSecretStore
  314. err := r.Get(ctx, ref, &store)
  315. if err != nil {
  316. return nil, fmt.Errorf(errGetClusterSecretStore, ref.Name, err)
  317. }
  318. return &store, nil
  319. }
  320. ref.Namespace = ns
  321. var store v1beta1.SecretStore
  322. err := r.Get(ctx, ref, &store)
  323. if err != nil {
  324. return nil, fmt.Errorf(errGetSecretStore, ref.Name, err)
  325. }
  326. return &store, nil
  327. }
  328. func (r *Reconciler) SetupWithManager(mgr ctrl.Manager) error {
  329. r.recorder = mgr.GetEventRecorderFor("pushsecret")
  330. return ctrl.NewControllerManagedBy(mgr).
  331. For(&esapi.PushSecret{}).
  332. Complete(r)
  333. }
  334. func NewPushSecretCondition(condType esapi.PushSecretConditionType, status v1.ConditionStatus, reason, message string) *esapi.PushSecretStatusCondition {
  335. return &esapi.PushSecretStatusCondition{
  336. Type: condType,
  337. Status: status,
  338. LastTransitionTime: metav1.Now(),
  339. Reason: reason,
  340. Message: message,
  341. }
  342. }
  343. func SetPushSecretCondition(gs esapi.PushSecret, condition esapi.PushSecretStatusCondition) esapi.PushSecret {
  344. status := gs.Status
  345. currentCond := GetPushSecretCondition(status, condition.Type)
  346. if currentCond != nil && currentCond.Status == condition.Status &&
  347. currentCond.Reason == condition.Reason && currentCond.Message == condition.Message {
  348. return gs
  349. }
  350. // Do not update lastTransitionTime if the status of the condition doesn't change.
  351. if currentCond != nil && currentCond.Status == condition.Status {
  352. condition.LastTransitionTime = currentCond.LastTransitionTime
  353. }
  354. status.Conditions = append(filterOutCondition(status.Conditions, condition.Type), condition)
  355. gs.Status = status
  356. return gs
  357. }
  358. // filterOutCondition returns an empty set of conditions with the provided type.
  359. func filterOutCondition(conditions []esapi.PushSecretStatusCondition, condType esapi.PushSecretConditionType) []esapi.PushSecretStatusCondition {
  360. newConditions := make([]esapi.PushSecretStatusCondition, 0, len(conditions))
  361. for _, c := range conditions {
  362. if c.Type == condType {
  363. continue
  364. }
  365. newConditions = append(newConditions, c)
  366. }
  367. return newConditions
  368. }
  369. // GetSecretStoreCondition returns the condition with the provided type.
  370. func GetPushSecretCondition(status esapi.PushSecretStatus, condType esapi.PushSecretConditionType) *esapi.PushSecretStatusCondition {
  371. for i := range status.Conditions {
  372. c := status.Conditions[i]
  373. if c.Type == condType {
  374. return &c
  375. }
  376. }
  377. return nil
  378. }
  379. func statusRef(ref v1beta1.PushRemoteRef) string {
  380. if ref.GetProperty() != "" {
  381. return ref.GetRemoteKey() + "/" + ref.GetProperty()
  382. }
  383. return ref.GetRemoteKey()
  384. }