secretsmanager.go 24 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528529530531532533534535536537538539540541542543544545546547548549550551552553554555556557558559560561562563564565566567568569570571572573574575576577578579580581582583584585586587588589590591592593594595596597598599600601602603604605606607608609610611612613614615616617618619620621622623624625626627628629630631632633634635636637638639640641642643644645646647648649650651652653654655656657658659660661662663664665666667668669670671672673674675676677678679680681682683684685686687688689690691692693694695696697698699700701702703704705706707708709710711712713714715716717718719720721722723724725726727728729730731732733734735736737738739740741742743744745746747748749750751752753754755756757758759760761762763764765766767768769770771772773774775776777778779780781782783784785786787788789790791792793794795796
  1. /*
  2. Licensed under the Apache License, Version 2.0 (the "License");
  3. you may not use this file except in compliance with the License.
  4. You may obtain a copy of the License at
  5. http://www.apache.org/licenses/LICENSE-2.0
  6. Unless required by applicable law or agreed to in writing, software
  7. distributed under the License is distributed on an "AS IS" BASIS,
  8. WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
  9. See the License for the specific language governing permissions and
  10. limitations under the License.
  11. */
  12. package secretsmanager
  13. import (
  14. "bytes"
  15. "context"
  16. "encoding/json"
  17. "errors"
  18. "fmt"
  19. "math/big"
  20. "slices"
  21. "strings"
  22. "github.com/aws/aws-sdk-go-v2/aws"
  23. awssm "github.com/aws/aws-sdk-go-v2/service/secretsmanager"
  24. "github.com/aws/aws-sdk-go-v2/service/secretsmanager/types"
  25. "github.com/aws/smithy-go"
  26. "github.com/google/uuid"
  27. "github.com/tidwall/gjson"
  28. "github.com/tidwall/sjson"
  29. corev1 "k8s.io/api/core/v1"
  30. apiextensionsv1 "k8s.io/apiextensions-apiserver/pkg/apis/apiextensions/v1"
  31. utilpointer "k8s.io/utils/ptr"
  32. ctrl "sigs.k8s.io/controller-runtime"
  33. esv1 "github.com/external-secrets/external-secrets/apis/externalsecrets/v1"
  34. "github.com/external-secrets/external-secrets/pkg/constants"
  35. "github.com/external-secrets/external-secrets/pkg/find"
  36. "github.com/external-secrets/external-secrets/pkg/metrics"
  37. "github.com/external-secrets/external-secrets/pkg/provider/aws/util"
  38. "github.com/external-secrets/external-secrets/pkg/utils"
  39. "github.com/external-secrets/external-secrets/pkg/utils/metadata"
  40. )
  41. type PushSecretMetadataSpec struct {
  42. Tags map[string]string `json:"tags,omitempty"`
  43. Description string `json:"description,omitempty"`
  44. SecretPushFormat string `json:"secretPushFormat,omitempty"`
  45. KMSKeyID string `json:"kmsKeyId,omitempty"`
  46. }
  47. // Declares metadata information for pushing secrets to AWS Secret Store.
  48. const (
  49. SecretPushFormatKey = "secretPushFormat"
  50. SecretPushFormatString = "string"
  51. SecretPushFormatBinary = "binary"
  52. ResourceNotFoundException = "ResourceNotFoundException"
  53. )
  54. // https://github.com/external-secrets/external-secrets/issues/644
  55. var _ esv1.SecretsClient = &SecretsManager{}
  56. // SecretsManager is a provider for AWS SecretsManager.
  57. type SecretsManager struct {
  58. cfg *aws.Config
  59. client SMInterface // Keep the interface
  60. referentAuth bool
  61. cache map[string]*awssm.GetSecretValueOutput
  62. config *esv1.SecretsManager
  63. prefix string
  64. }
  65. // SMInterface is a subset of the smiface api.
  66. // see: https://docs.aws.amazon.com/sdk-for-go/api/service/secretsmanager/secretsmanageriface/
  67. type SMInterface interface {
  68. BatchGetSecretValue(ctx context.Context, params *awssm.BatchGetSecretValueInput, optFuncs ...func(*awssm.Options)) (*awssm.BatchGetSecretValueOutput, error)
  69. ListSecrets(ctx context.Context, params *awssm.ListSecretsInput, optFuncs ...func(*awssm.Options)) (*awssm.ListSecretsOutput, error)
  70. GetSecretValue(ctx context.Context, params *awssm.GetSecretValueInput, optFuncs ...func(*awssm.Options)) (*awssm.GetSecretValueOutput, error)
  71. CreateSecret(ctx context.Context, params *awssm.CreateSecretInput, optFuncs ...func(*awssm.Options)) (*awssm.CreateSecretOutput, error)
  72. PutSecretValue(ctx context.Context, params *awssm.PutSecretValueInput, optFuncs ...func(*awssm.Options)) (*awssm.PutSecretValueOutput, error)
  73. DescribeSecret(ctx context.Context, params *awssm.DescribeSecretInput, optFuncs ...func(*awssm.Options)) (*awssm.DescribeSecretOutput, error)
  74. DeleteSecret(ctx context.Context, params *awssm.DeleteSecretInput, optFuncs ...func(*awssm.Options)) (*awssm.DeleteSecretOutput, error)
  75. TagResource(ctx context.Context, params *awssm.TagResourceInput, optFuncs ...func(*awssm.Options)) (*awssm.TagResourceOutput, error)
  76. UntagResource(ctx context.Context, params *awssm.UntagResourceInput, optFuncs ...func(*awssm.Options)) (*awssm.UntagResourceOutput, error)
  77. }
  78. const (
  79. errUnexpectedFindOperator = "unexpected find operator"
  80. managedBy = "managed-by"
  81. externalSecrets = "external-secrets"
  82. initialVersion = "00000000-0000-0000-0000-000000000001"
  83. )
  84. var log = ctrl.Log.WithName("provider").WithName("aws").WithName("secretsmanager")
  85. // New creates a new SecretsManager client.
  86. func New(_ context.Context, cfg *aws.Config, secretsManagerCfg *esv1.SecretsManager, prefix string, referentAuth bool) (*SecretsManager, error) {
  87. return &SecretsManager{
  88. cfg: cfg,
  89. client: awssm.NewFromConfig(*cfg, func(o *awssm.Options) {
  90. o.EndpointResolverV2 = customEndpointResolver{}
  91. }),
  92. referentAuth: referentAuth,
  93. cache: make(map[string]*awssm.GetSecretValueOutput),
  94. config: secretsManagerCfg,
  95. prefix: prefix,
  96. }, nil
  97. }
  98. func (sm *SecretsManager) fetch(ctx context.Context, ref esv1.ExternalSecretDataRemoteRef) (*awssm.GetSecretValueOutput, error) {
  99. ver := "AWSCURRENT"
  100. valueFrom := "SECRET"
  101. if ref.Version != "" {
  102. ver = ref.Version
  103. }
  104. if ref.MetadataPolicy == esv1.ExternalSecretMetadataPolicyFetch {
  105. valueFrom = "TAG"
  106. }
  107. key := sm.prefix + ref.Key
  108. log.Info("fetching secret value", "key", key, "version", ver, "value", valueFrom)
  109. cacheKey := fmt.Sprintf("%s#%s#%s", key, ver, valueFrom)
  110. if secretOut, found := sm.cache[cacheKey]; found {
  111. log.Info("found secret in cache", "key", key, "version", ver)
  112. return secretOut, nil
  113. }
  114. secretOut, err := sm.constructSecretValue(ctx, key, ver, ref.MetadataPolicy)
  115. if err != nil {
  116. return nil, err
  117. }
  118. sm.cache[cacheKey] = secretOut
  119. return secretOut, nil
  120. }
  121. func (sm *SecretsManager) DeleteSecret(ctx context.Context, remoteRef esv1.PushSecretRemoteRef) error {
  122. secretName := sm.prefix + remoteRef.GetRemoteKey()
  123. secretValue := awssm.GetSecretValueInput{
  124. SecretId: &secretName,
  125. }
  126. secretInput := awssm.DescribeSecretInput{
  127. SecretId: &secretName,
  128. }
  129. awsSecret, err := sm.client.GetSecretValue(ctx, &secretValue)
  130. metrics.ObserveAPICall(constants.ProviderAWSSM, constants.CallAWSSMGetSecretValue, err)
  131. var aerr smithy.APIError
  132. if err != nil {
  133. if ok := errors.As(err, &aerr); !ok {
  134. return err
  135. }
  136. if aerr.ErrorCode() == ResourceNotFoundException {
  137. return nil
  138. }
  139. return err
  140. }
  141. data, err := sm.client.DescribeSecret(ctx, &secretInput)
  142. metrics.ObserveAPICall(constants.ProviderAWSSM, constants.CallAWSSMDescribeSecret, err)
  143. if err != nil {
  144. return err
  145. }
  146. if !isManagedByESO(data) {
  147. return nil
  148. }
  149. deleteInput := &awssm.DeleteSecretInput{
  150. SecretId: awsSecret.ARN,
  151. }
  152. if sm.config != nil && sm.config.ForceDeleteWithoutRecovery {
  153. deleteInput.ForceDeleteWithoutRecovery = &sm.config.ForceDeleteWithoutRecovery
  154. }
  155. if sm.config != nil && sm.config.RecoveryWindowInDays > 0 {
  156. deleteInput.RecoveryWindowInDays = &sm.config.RecoveryWindowInDays
  157. }
  158. err = util.ValidateDeleteSecretInput(*deleteInput)
  159. if err != nil {
  160. return err
  161. }
  162. _, err = sm.client.DeleteSecret(ctx, deleteInput)
  163. metrics.ObserveAPICall(constants.ProviderAWSSM, constants.CallAWSSMDeleteSecret, err)
  164. return err
  165. }
  166. func (sm *SecretsManager) SecretExists(ctx context.Context, pushSecretRef esv1.PushSecretRemoteRef) (bool, error) {
  167. secretName := sm.prefix + pushSecretRef.GetRemoteKey()
  168. secretValue := awssm.GetSecretValueInput{
  169. SecretId: &secretName,
  170. }
  171. _, err := sm.client.GetSecretValue(ctx, &secretValue)
  172. if err != nil {
  173. return sm.handleSecretError(err)
  174. }
  175. return true, nil
  176. }
  177. func (sm *SecretsManager) handleSecretError(err error) (bool, error) {
  178. var aerr smithy.APIError
  179. if ok := errors.As(err, &aerr); !ok {
  180. return false, err
  181. }
  182. if aerr.ErrorCode() == ResourceNotFoundException {
  183. return false, nil
  184. }
  185. return false, err
  186. }
  187. func (sm *SecretsManager) PushSecret(ctx context.Context, secret *corev1.Secret, psd esv1.PushSecretData) error {
  188. value, err := utils.ExtractSecretData(psd, secret)
  189. if err != nil {
  190. return fmt.Errorf("failed to extract secret data: %w", err)
  191. }
  192. secretName := sm.prefix + psd.GetRemoteKey()
  193. describeSecretInput := awssm.DescribeSecretInput{SecretId: &secretName}
  194. describeSecretOutput, err := sm.client.DescribeSecret(ctx, &describeSecretInput)
  195. metrics.ObserveAPICall(constants.ProviderAWSSM, constants.CallAWSSMDescribeSecret, err)
  196. var aerr smithy.APIError
  197. if err != nil {
  198. if ok := errors.As(err, &aerr); !ok {
  199. return err
  200. }
  201. if aerr.ErrorCode() == ResourceNotFoundException {
  202. finalValue, err := sm.getNewSecretValue(value, psd.GetProperty(), nil)
  203. if err != nil {
  204. return err
  205. }
  206. return sm.createSecretWithContext(ctx, secretName, psd, finalValue)
  207. }
  208. return err
  209. } else if !isManagedByESO(describeSecretOutput) {
  210. return errors.New("secret not managed by external-secrets")
  211. }
  212. if len(describeSecretOutput.VersionIdsToStages) == 0 {
  213. finalValue, err := sm.getNewSecretValue(value, psd.GetProperty(), nil)
  214. if err != nil {
  215. return err
  216. }
  217. return sm.putSecretValueWithContext(ctx, secretName, nil, psd, finalValue, describeSecretOutput.Tags)
  218. }
  219. getSecretValueInput := awssm.GetSecretValueInput{SecretId: &secretName}
  220. getSecretValueOutput, err := sm.client.GetSecretValue(ctx, &getSecretValueInput)
  221. metrics.ObserveAPICall(constants.ProviderAWSSM, constants.CallAWSSMGetSecretValue, err)
  222. if err != nil {
  223. return err
  224. }
  225. finalValue, err := sm.getNewSecretValue(value, psd.GetProperty(), getSecretValueOutput)
  226. if err != nil {
  227. return err
  228. }
  229. return sm.putSecretValueWithContext(ctx, secretName, getSecretValueOutput, psd, finalValue, describeSecretOutput.Tags)
  230. }
  231. func (sm *SecretsManager) getNewSecretValue(value []byte, property string, existingSecret *awssm.GetSecretValueOutput) ([]byte, error) {
  232. if property == "" {
  233. return value, nil
  234. }
  235. if existingSecret == nil {
  236. value, _ = sjson.SetBytes([]byte{}, property, value)
  237. return value, nil
  238. }
  239. currentSecret := sm.retrievePayload(existingSecret)
  240. if currentSecret != "" && !gjson.Valid(currentSecret) {
  241. return nil, errors.New("PushSecret for aws secrets manager with a pushSecretData property requires a json secret")
  242. }
  243. value, _ = sjson.SetBytes([]byte(currentSecret), property, value)
  244. return value, nil
  245. }
  246. func padOrTrim(b []byte) []byte {
  247. l := len(b)
  248. size := 16
  249. if l == size {
  250. return b
  251. }
  252. if l > size {
  253. return b[l-size:]
  254. }
  255. tmp := make([]byte, size)
  256. copy(tmp[size-l:], b)
  257. return tmp
  258. }
  259. func bumpVersionNumber(id *string) (*string, error) {
  260. if id == nil {
  261. output := initialVersion
  262. return &output, nil
  263. }
  264. n := new(big.Int)
  265. oldVersion, ok := n.SetString(strings.ReplaceAll(*id, "-", ""), 16)
  266. if !ok {
  267. return nil, fmt.Errorf("expected secret version in AWS SSM to be a UUID but got '%s'", *id)
  268. }
  269. newVersionRaw := oldVersion.Add(oldVersion, big.NewInt(1)).Bytes()
  270. newVersion, err := uuid.FromBytes(padOrTrim(newVersionRaw))
  271. if err != nil {
  272. return nil, err
  273. }
  274. s := newVersion.String()
  275. return &s, nil
  276. }
  277. func isManagedByESO(data *awssm.DescribeSecretOutput) bool {
  278. managedBy := managedBy
  279. externalSecrets := externalSecrets
  280. for _, tag := range data.Tags {
  281. if *tag.Key == managedBy && *tag.Value == externalSecrets {
  282. return true
  283. }
  284. }
  285. return false
  286. }
  287. // GetAllSecrets syncs multiple secrets from aws provider into a single Kubernetes Secret.
  288. func (sm *SecretsManager) GetAllSecrets(ctx context.Context, ref esv1.ExternalSecretFind) (map[string][]byte, error) {
  289. if ref.Name != nil {
  290. return sm.findByName(ctx, ref)
  291. }
  292. if len(ref.Tags) > 0 {
  293. return sm.findByTags(ctx, ref)
  294. }
  295. return nil, errors.New(errUnexpectedFindOperator)
  296. }
  297. func (sm *SecretsManager) findByName(ctx context.Context, ref esv1.ExternalSecretFind) (map[string][]byte, error) {
  298. matcher, err := find.New(*ref.Name)
  299. if err != nil {
  300. return nil, err
  301. }
  302. filters := make([]types.Filter, 0)
  303. if ref.Path != nil {
  304. filters = append(filters, types.Filter{
  305. Key: types.FilterNameStringTypeName,
  306. Values: []string{
  307. *ref.Path,
  308. },
  309. })
  310. return sm.fetchWithBatch(ctx, filters, matcher)
  311. }
  312. data := make(map[string][]byte)
  313. var nextToken *string
  314. for {
  315. // I put this into the for loop on purpose.
  316. log.V(0).Info("using ListSecret to fetch all secrets; this is a costly operations, please use batching by defining a _path_")
  317. it, err := sm.client.ListSecrets(ctx, &awssm.ListSecretsInput{
  318. Filters: filters,
  319. NextToken: nextToken,
  320. })
  321. metrics.ObserveAPICall(constants.ProviderAWSSM, constants.CallAWSSMListSecrets, err)
  322. if err != nil {
  323. return nil, err
  324. }
  325. log.V(1).Info("aws sm findByName found", "secrets", len(it.SecretList))
  326. for _, secret := range it.SecretList {
  327. if !matcher.MatchName(*secret.Name) {
  328. continue
  329. }
  330. log.V(1).Info("aws sm findByName matches", "name", *secret.Name)
  331. if err := sm.fetchAndSet(ctx, data, *secret.Name); err != nil {
  332. return nil, err
  333. }
  334. }
  335. nextToken = it.NextToken
  336. if nextToken == nil {
  337. break
  338. }
  339. }
  340. return data, nil
  341. }
  342. func (sm *SecretsManager) findByTags(ctx context.Context, ref esv1.ExternalSecretFind) (map[string][]byte, error) {
  343. filters := make([]types.Filter, 0)
  344. for k, v := range ref.Tags {
  345. filters = append(filters, types.Filter{
  346. Key: types.FilterNameStringTypeTagKey,
  347. Values: []string{
  348. k,
  349. },
  350. }, types.Filter{
  351. Key: types.FilterNameStringTypeTagValue,
  352. Values: []string{
  353. v,
  354. },
  355. })
  356. }
  357. if ref.Path != nil {
  358. filters = append(filters, types.Filter{
  359. Key: types.FilterNameStringTypeName,
  360. Values: []string{
  361. *ref.Path,
  362. },
  363. })
  364. }
  365. return sm.fetchWithBatch(ctx, filters, nil)
  366. }
  367. func (sm *SecretsManager) fetchAndSet(ctx context.Context, data map[string][]byte, name string) error {
  368. sec, err := sm.fetch(ctx, esv1.ExternalSecretDataRemoteRef{
  369. Key: name,
  370. })
  371. if err != nil {
  372. return err
  373. }
  374. if sec.SecretString != nil {
  375. data[name] = []byte(*sec.SecretString)
  376. }
  377. if sec.SecretBinary != nil {
  378. data[name] = sec.SecretBinary
  379. }
  380. return nil
  381. }
  382. // GetSecret returns a single secret from the provider.
  383. func (sm *SecretsManager) GetSecret(ctx context.Context, ref esv1.ExternalSecretDataRemoteRef) ([]byte, error) {
  384. secretOut, err := sm.fetch(ctx, ref)
  385. if errors.Is(err, esv1.NoSecretErr) {
  386. return nil, err
  387. }
  388. if err != nil {
  389. return nil, util.SanitizeErr(err)
  390. }
  391. if ref.Property == "" {
  392. if secretOut.SecretString != nil {
  393. return []byte(*secretOut.SecretString), nil
  394. }
  395. if secretOut.SecretBinary != nil {
  396. return secretOut.SecretBinary, nil
  397. }
  398. return nil, fmt.Errorf("invalid secret received. no secret string nor binary for key: %s", ref.Key)
  399. }
  400. val := sm.mapSecretToGjson(secretOut, ref.Property)
  401. if !val.Exists() {
  402. return nil, fmt.Errorf("key %s does not exist in secret %s", ref.Property, ref.Key)
  403. }
  404. return []byte(val.String()), nil
  405. }
  406. func (sm *SecretsManager) mapSecretToGjson(secretOut *awssm.GetSecretValueOutput, property string) gjson.Result {
  407. payload := sm.retrievePayload(secretOut)
  408. refProperty := sm.escapeDotsIfRequired(property, payload)
  409. val := gjson.Get(payload, refProperty)
  410. return val
  411. }
  412. func (sm *SecretsManager) retrievePayload(secretOut *awssm.GetSecretValueOutput) string {
  413. if secretOut == nil {
  414. return ""
  415. }
  416. var payload string
  417. if secretOut.SecretString != nil {
  418. payload = *secretOut.SecretString
  419. }
  420. if secretOut.SecretBinary != nil {
  421. payload = string(secretOut.SecretBinary)
  422. }
  423. return payload
  424. }
  425. func (sm *SecretsManager) escapeDotsIfRequired(currentRefProperty, payload string) string {
  426. // We need to search if a given key with a . exists before using gjson operations.
  427. idx := strings.Index(currentRefProperty, ".")
  428. refProperty := currentRefProperty
  429. if idx > -1 {
  430. refProperty = strings.ReplaceAll(currentRefProperty, ".", "\\.")
  431. val := gjson.Get(payload, refProperty)
  432. if !val.Exists() {
  433. refProperty = currentRefProperty
  434. }
  435. }
  436. return refProperty
  437. }
  438. // GetSecretMap returns multiple k/v pairs from the provider.
  439. func (sm *SecretsManager) GetSecretMap(ctx context.Context, ref esv1.ExternalSecretDataRemoteRef) (map[string][]byte, error) {
  440. log.Info("fetching secret map", "key", ref.Key)
  441. data, err := sm.GetSecret(ctx, ref)
  442. if err != nil {
  443. return nil, err
  444. }
  445. kv := make(map[string]json.RawMessage)
  446. err = json.Unmarshal(data, &kv)
  447. if err != nil {
  448. return nil, fmt.Errorf("unable to unmarshal secret %s: %w", ref.Key, err)
  449. }
  450. secretData := make(map[string][]byte)
  451. for k, v := range kv {
  452. var strVal string
  453. err = json.Unmarshal(v, &strVal)
  454. if err == nil {
  455. secretData[k] = []byte(strVal)
  456. } else {
  457. secretData[k] = v
  458. }
  459. }
  460. return secretData, nil
  461. }
  462. func (sm *SecretsManager) Close(_ context.Context) error {
  463. return nil
  464. }
  465. func (sm *SecretsManager) Validate() (esv1.ValidationResult, error) {
  466. // skip validation stack because it depends on the namespace
  467. // of the ExternalSecret
  468. if sm.referentAuth {
  469. return esv1.ValidationResultUnknown, nil
  470. }
  471. _, err := sm.cfg.Credentials.Retrieve(context.Background())
  472. if err != nil {
  473. return esv1.ValidationResultError, util.SanitizeErr(err)
  474. }
  475. return esv1.ValidationResultReady, nil
  476. }
  477. func (sm *SecretsManager) Capabilities() esv1.SecretStoreCapabilities {
  478. return esv1.SecretStoreReadWrite
  479. }
  480. func (sm *SecretsManager) createSecretWithContext(ctx context.Context, secretName string, psd esv1.PushSecretData, value []byte) error {
  481. mdata, err := sm.constructMetadataWithDefaults(psd.GetMetadata())
  482. if err != nil {
  483. return fmt.Errorf("failed to parse push secret metadata: %w", err)
  484. }
  485. tags := make([]types.Tag, 0)
  486. for k, v := range mdata.Spec.Tags {
  487. tags = append(tags, types.Tag{
  488. Key: utilpointer.To(k),
  489. Value: utilpointer.To(v),
  490. })
  491. }
  492. input := &awssm.CreateSecretInput{
  493. Name: &secretName,
  494. SecretBinary: value,
  495. Tags: tags,
  496. Description: utilpointer.To(mdata.Spec.Description),
  497. ClientRequestToken: utilpointer.To(initialVersion),
  498. KmsKeyId: utilpointer.To(mdata.Spec.KMSKeyID),
  499. }
  500. if mdata.Spec.SecretPushFormat == SecretPushFormatString {
  501. input.SecretBinary = nil
  502. input.SecretString = aws.String(string(value))
  503. }
  504. _, err = sm.client.CreateSecret(ctx, input)
  505. metrics.ObserveAPICall(constants.ProviderAWSSM, constants.CallAWSSMCreateSecret, err)
  506. return err
  507. }
  508. func (sm *SecretsManager) putSecretValueWithContext(ctx context.Context, secretArn string, awsSecret *awssm.GetSecretValueOutput, psd esv1.PushSecretData, value []byte, tags []types.Tag) error {
  509. if awsSecret != nil && (bytes.Equal(awsSecret.SecretBinary, value) || utils.CompareStringAndByteSlices(awsSecret.SecretString, value)) {
  510. return nil
  511. }
  512. newVersionNumber := initialVersion
  513. if awsSecret != nil {
  514. bumpedVersionNumber, err := bumpVersionNumber(awsSecret.VersionId)
  515. if err != nil {
  516. return err
  517. }
  518. newVersionNumber = *bumpedVersionNumber
  519. }
  520. input := &awssm.PutSecretValueInput{
  521. SecretId: &secretArn,
  522. SecretBinary: value,
  523. ClientRequestToken: aws.String(newVersionNumber),
  524. }
  525. secretPushFormat, err := utils.FetchValueFromMetadata(SecretPushFormatKey, psd.GetMetadata(), SecretPushFormatBinary)
  526. if err != nil {
  527. return fmt.Errorf("failed to parse metadata: %w", err)
  528. }
  529. if secretPushFormat == SecretPushFormatString {
  530. input.SecretBinary = nil
  531. input.SecretString = aws.String(string(value))
  532. }
  533. _, err = sm.client.PutSecretValue(ctx, input)
  534. metrics.ObserveAPICall(constants.ProviderAWSSM, constants.CallAWSSMPutSecretValue, err)
  535. if err != nil {
  536. return err
  537. }
  538. currentTags := make(map[string]string, len(tags))
  539. for _, tag := range tags {
  540. currentTags[*tag.Key] = *tag.Value
  541. }
  542. return sm.patchTags(ctx, psd.GetMetadata(), &secretArn, currentTags)
  543. }
  544. func (sm *SecretsManager) patchTags(ctx context.Context, metadata *apiextensionsv1.JSON, secretId *string, tags map[string]string) error {
  545. meta, err := sm.constructMetadataWithDefaults(metadata)
  546. if err != nil {
  547. return err
  548. }
  549. tagKeysToRemove := util.FindTagKeysToRemove(tags, meta.Spec.Tags)
  550. if len(tagKeysToRemove) > 0 {
  551. _, err = sm.client.UntagResource(ctx, &awssm.UntagResourceInput{
  552. SecretId: secretId,
  553. TagKeys: tagKeysToRemove,
  554. })
  555. metrics.ObserveAPICall(constants.ProviderAWSSM, constants.CallAWSSMUntagResource, err)
  556. if err != nil {
  557. return err
  558. }
  559. }
  560. tagsToUpdate, isModified := computeTagsToUpdate(tags, meta.Spec.Tags)
  561. if isModified {
  562. _, err = sm.client.TagResource(ctx, &awssm.TagResourceInput{
  563. SecretId: secretId,
  564. Tags: tagsToUpdate,
  565. })
  566. metrics.ObserveAPICall(constants.ProviderAWSSM, constants.CallAWSSMTagResource, err)
  567. if err != nil {
  568. return err
  569. }
  570. }
  571. return nil
  572. }
  573. func (sm *SecretsManager) fetchWithBatch(ctx context.Context, filters []types.Filter, matcher *find.Matcher) (map[string][]byte, error) {
  574. data := make(map[string][]byte)
  575. var nextToken *string
  576. for {
  577. it, err := sm.client.BatchGetSecretValue(ctx, &awssm.BatchGetSecretValueInput{
  578. Filters: filters,
  579. NextToken: nextToken,
  580. })
  581. metrics.ObserveAPICall(constants.ProviderAWSSM, constants.CallAWSSMBatchGetSecretValue, err)
  582. if err != nil {
  583. return nil, err
  584. }
  585. log.V(1).Info("aws sm findByName found", "secrets", len(it.SecretValues))
  586. for _, secret := range it.SecretValues {
  587. if matcher != nil && !matcher.MatchName(*secret.Name) {
  588. continue
  589. }
  590. log.V(1).Info("aws sm findByName matches", "name", *secret.Name)
  591. sm.setSecretValues(&secret, data)
  592. }
  593. nextToken = it.NextToken
  594. if nextToken == nil {
  595. break
  596. }
  597. }
  598. return data, nil
  599. }
  600. func (sm *SecretsManager) setSecretValues(secret *types.SecretValueEntry, data map[string][]byte) {
  601. if secret.SecretString != nil {
  602. data[*secret.Name] = []byte(*secret.SecretString)
  603. }
  604. if secret.SecretBinary != nil {
  605. data[*secret.Name] = secret.SecretBinary
  606. }
  607. }
  608. func (sm *SecretsManager) constructSecretValue(ctx context.Context, key, ver string, metadataPolicy esv1.ExternalSecretMetadataPolicy) (*awssm.GetSecretValueOutput, error) {
  609. if metadataPolicy == esv1.ExternalSecretMetadataPolicyFetch {
  610. describeSecretInput := &awssm.DescribeSecretInput{
  611. SecretId: &key,
  612. }
  613. descOutput, err := sm.client.DescribeSecret(ctx, describeSecretInput)
  614. if err != nil {
  615. return nil, err
  616. }
  617. log.Info("found metadata secret", "key", key, "output", descOutput)
  618. jsonTags, err := util.SecretTagsToJSONString(descOutput.Tags)
  619. if err != nil {
  620. return nil, err
  621. }
  622. return &awssm.GetSecretValueOutput{
  623. ARN: descOutput.ARN,
  624. CreatedDate: descOutput.CreatedDate,
  625. Name: descOutput.Name,
  626. SecretString: &jsonTags,
  627. VersionId: &ver,
  628. }, nil
  629. }
  630. var getSecretValueInput *awssm.GetSecretValueInput
  631. if strings.HasPrefix(ver, "uuid/") {
  632. versionID := strings.TrimPrefix(ver, "uuid/")
  633. getSecretValueInput = &awssm.GetSecretValueInput{
  634. SecretId: &key,
  635. VersionId: &versionID,
  636. }
  637. } else {
  638. getSecretValueInput = &awssm.GetSecretValueInput{
  639. SecretId: &key,
  640. VersionStage: &ver,
  641. }
  642. }
  643. secretOut, err := sm.client.GetSecretValue(ctx, getSecretValueInput)
  644. metrics.ObserveAPICall(constants.ProviderAWSSM, constants.CallAWSSMGetSecretValue, err)
  645. var (
  646. nf *types.ResourceNotFoundException
  647. ie *types.InvalidParameterException
  648. )
  649. if errors.As(err, &nf) {
  650. return nil, esv1.NoSecretErr
  651. }
  652. if errors.As(err, &ie) && strings.Contains(ie.Error(), "was marked for deletion") {
  653. return nil, esv1.NoSecretErr
  654. }
  655. return secretOut, err
  656. }
  657. func (sm *SecretsManager) constructMetadataWithDefaults(data *apiextensionsv1.JSON) (*metadata.PushSecretMetadata[PushSecretMetadataSpec], error) {
  658. var (
  659. meta *metadata.PushSecretMetadata[PushSecretMetadataSpec]
  660. err error
  661. )
  662. meta, err = metadata.ParseMetadataParameters[PushSecretMetadataSpec](data)
  663. if err != nil {
  664. return nil, fmt.Errorf("failed to parse metadata: %w", err)
  665. }
  666. if meta == nil {
  667. meta = &metadata.PushSecretMetadata[PushSecretMetadataSpec]{}
  668. }
  669. if meta.Spec.SecretPushFormat == "" {
  670. meta.Spec.SecretPushFormat = SecretPushFormatBinary
  671. } else if !slices.Contains([]string{SecretPushFormatBinary, SecretPushFormatString}, meta.Spec.SecretPushFormat) {
  672. return nil, fmt.Errorf("invalid secret push format: %s", meta.Spec.SecretPushFormat)
  673. }
  674. if meta.Spec.Description == "" {
  675. meta.Spec.Description = fmt.Sprintf("secret '%s:%s'", managedBy, externalSecrets)
  676. }
  677. if meta.Spec.KMSKeyID == "" {
  678. meta.Spec.KMSKeyID = "alias/aws/secretsmanager"
  679. }
  680. if len(meta.Spec.Tags) > 0 {
  681. if _, exists := meta.Spec.Tags[managedBy]; exists {
  682. return nil, fmt.Errorf("error parsing tags in metadata: Cannot specify a '%s' tag", managedBy)
  683. }
  684. } else {
  685. meta.Spec.Tags = make(map[string]string)
  686. }
  687. meta.Spec.Tags[managedBy] = externalSecrets
  688. return meta, nil
  689. }
  690. // computeTagsToUpdate compares the current tags with the desired metaTags and returns a slice of ssmTypes.Tag
  691. // that should be set on the resource. It also returns a boolean indicating if any tag was added or modified.
  692. func computeTagsToUpdate(tags, metaTags map[string]string) ([]types.Tag, bool) {
  693. result := make([]types.Tag, 0, len(metaTags))
  694. modified := false
  695. for k, v := range metaTags {
  696. if _, exists := tags[k]; !exists || tags[k] != v {
  697. if k != managedBy {
  698. modified = true
  699. }
  700. }
  701. result = append(result, types.Tag{
  702. Key: utilpointer.To(k),
  703. Value: utilpointer.To(v),
  704. })
  705. }
  706. return result, modified
  707. }