client.go 11 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361
  1. /*
  2. Licensed under the Apache License, Version 2.0 (the "License");
  3. you may not use this file except in compliance with the License.
  4. You may obtain a copy of the License at
  5. http://www.apache.org/licenses/LICENSE-2.0
  6. Unless required by applicable law or agreed to in writing, software
  7. distributed under the License is distributed on an "AS IS" BASIS,
  8. WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
  9. See the License for the specific language governing permissions and
  10. limitations under the License.
  11. */
  12. package bitwarden
  13. import (
  14. "bytes"
  15. "context"
  16. "encoding/json"
  17. "errors"
  18. "fmt"
  19. "gopkg.in/yaml.v3"
  20. corev1 "k8s.io/api/core/v1"
  21. "k8s.io/kube-openapi/pkg/validation/strfmt"
  22. "k8s.io/utils/ptr"
  23. esv1 "github.com/external-secrets/external-secrets/apis/externalsecrets/v1"
  24. "github.com/external-secrets/external-secrets/pkg/utils"
  25. )
  26. const (
  27. // NoteMetadataKey defines the note for the pushed secret.
  28. NoteMetadataKey = "note"
  29. errNoProvider = "store does not have a provider"
  30. )
  31. var (
  32. errFailedToGetAllSecrets = "failed to get all secrets: %w"
  33. errFailedToGetSecret = "failed to get secret: %w"
  34. )
  35. // PushSecret will write a single secret into the provider.
  36. // Note: We will refuse to overwrite ANY secrets, because we can never be completely
  37. // sure if it's the same secret we are trying to push. We only have the Name and the value
  38. // could be different. Therefore, we will always create a new secret. Except if, the value
  39. // the key, the note, and organization ID all match.
  40. // We only allow to push to a single project, because GET returns a single project ID
  41. // the secret belongs to even though technically Create allows multiple projects. This is
  42. // to ensure that we push to the same project always, and so we can determine reliably that
  43. // we don't need to push again.
  44. func (p *Provider) PushSecret(ctx context.Context, secret *corev1.Secret, data esv1.PushSecretData) error {
  45. spec := p.store.GetSpec()
  46. if spec == nil || spec.Provider == nil {
  47. return errors.New(errNoProvider)
  48. }
  49. if data.GetRemoteKey() == "" {
  50. return errors.New("remote key must be defined")
  51. }
  52. value, err := utils.ExtractSecretData(data, secret)
  53. if err != nil {
  54. return fmt.Errorf("failed to extract secret data: %w", err)
  55. }
  56. note, err := utils.FetchValueFromMetadata(NoteMetadataKey, data.GetMetadata(), "")
  57. if err != nil {
  58. return fmt.Errorf("failed to fetch note from metadata: %w", err)
  59. }
  60. // ListAll Secrets for an organization. If the key matches our key, we GetSecret that and do a compare.
  61. remoteSecrets, err := p.bitwardenSdkClient.ListSecrets(ctx, spec.Provider.BitwardenSecretsManager.OrganizationID)
  62. if err != nil {
  63. return fmt.Errorf(errFailedToGetAllSecrets, err)
  64. }
  65. for _, d := range remoteSecrets.Data {
  66. if d.Key != data.GetRemoteKey() {
  67. continue
  68. }
  69. sec, err := p.bitwardenSdkClient.GetSecret(ctx, d.ID)
  70. if err != nil {
  71. return fmt.Errorf("failed to get secret: %w", err)
  72. }
  73. // If all pushed data matches, we won't push this secret.
  74. if p.isExactlySameSecret(sec, data.GetRemoteKey(), note, spec.Provider.BitwardenSecretsManager.ProjectID, value) {
  75. // we have a complete match, skip pushing.
  76. return nil
  77. } else if p.isOnlyValueDifferent(sec, data.GetRemoteKey(), note, spec.Provider.BitwardenSecretsManager.ProjectID, value) {
  78. // only the value is different, update the existing secret.
  79. _, err = p.bitwardenSdkClient.UpdateSecret(ctx, SecretPutRequest{
  80. ID: sec.ID,
  81. Key: data.GetRemoteKey(),
  82. Note: note,
  83. OrganizationID: spec.Provider.BitwardenSecretsManager.OrganizationID,
  84. ProjectIDS: []string{spec.Provider.BitwardenSecretsManager.ProjectID},
  85. Value: string(value),
  86. })
  87. return err
  88. }
  89. }
  90. // no matching secret found, let's create it
  91. _, err = p.bitwardenSdkClient.CreateSecret(ctx, SecretCreateRequest{
  92. Key: data.GetRemoteKey(),
  93. Note: note,
  94. OrganizationID: spec.Provider.BitwardenSecretsManager.OrganizationID,
  95. ProjectIDS: []string{spec.Provider.BitwardenSecretsManager.ProjectID},
  96. Value: string(value),
  97. })
  98. return err
  99. }
  100. func (p *Provider) isExactlySameSecret(sec *SecretResponse, remoteKey, note, projectID string, value []byte) bool {
  101. return sec.Key == remoteKey &&
  102. sec.Value == string(value) &&
  103. sec.Note == note &&
  104. ptr.Deref(sec.ProjectID, "") == projectID
  105. }
  106. func (p *Provider) isOnlyValueDifferent(sec *SecretResponse, remoteKey, note, projectID string, value []byte) bool {
  107. return sec.Key == remoteKey &&
  108. sec.Value != string(value) &&
  109. sec.Note == note &&
  110. ptr.Deref(sec.ProjectID, "") == projectID
  111. }
  112. // GetSecret returns a single secret from the provider.
  113. func (p *Provider) GetSecret(ctx context.Context, ref esv1.ExternalSecretDataRemoteRef) ([]byte, error) {
  114. if strfmt.IsUUID(ref.Key) {
  115. resp, err := p.bitwardenSdkClient.GetSecret(ctx, ref.Key)
  116. if err != nil {
  117. return nil, fmt.Errorf(errFailedToGetSecret, err)
  118. }
  119. return []byte(resp.Value), nil
  120. }
  121. spec := p.store.GetSpec()
  122. if spec == nil || spec.Provider == nil {
  123. return nil, errors.New(errNoProvider)
  124. }
  125. secret, err := p.findSecretByRef(ctx, ref.Key, spec.Provider.BitwardenSecretsManager.ProjectID)
  126. if err != nil {
  127. return nil, fmt.Errorf(errFailedToGetSecret, err)
  128. }
  129. if secret == nil {
  130. return nil, fmt.Errorf("no secret found for project id %s and name %s", spec.Provider.BitwardenSecretsManager.ProjectID, ref.Key)
  131. }
  132. // we found our secret, return the value for it
  133. return []byte(secret.Value), nil
  134. }
  135. func (p *Provider) DeleteSecret(ctx context.Context, ref esv1.PushSecretRemoteRef) error {
  136. if strfmt.IsUUID(ref.GetRemoteKey()) {
  137. return p.deleteSecret(ctx, ref.GetRemoteKey())
  138. }
  139. spec := p.store.GetSpec()
  140. if spec == nil || spec.Provider == nil {
  141. return errors.New(errNoProvider)
  142. }
  143. secret, err := p.findSecretByRef(ctx, ref.GetRemoteKey(), spec.Provider.BitwardenSecretsManager.ProjectID)
  144. if err != nil {
  145. return fmt.Errorf(errFailedToGetSecret, err)
  146. }
  147. if secret == nil {
  148. return fmt.Errorf("no secret found for project id %s and name %s", spec.Provider.BitwardenSecretsManager.ProjectID, ref.GetRemoteKey())
  149. }
  150. return p.deleteSecret(ctx, secret.ID)
  151. }
  152. func (p *Provider) deleteSecret(ctx context.Context, id string) error {
  153. resp, err := p.bitwardenSdkClient.DeleteSecret(ctx, []string{id})
  154. if err != nil {
  155. return fmt.Errorf("error deleting secret: %w", err)
  156. }
  157. var errs error
  158. for _, data := range resp.Data {
  159. if data.Error != nil {
  160. errs = errors.Join(errs, fmt.Errorf("error deleting secret with id %s: %s", data.ID, *data.Error))
  161. }
  162. }
  163. if errs != nil {
  164. return fmt.Errorf("there were one or more errors deleting secrets: %w", errs)
  165. }
  166. return nil
  167. }
  168. func (p *Provider) SecretExists(ctx context.Context, ref esv1.PushSecretRemoteRef) (bool, error) {
  169. if strfmt.IsUUID(ref.GetRemoteKey()) {
  170. _, err := p.bitwardenSdkClient.GetSecret(ctx, ref.GetRemoteKey())
  171. if err != nil {
  172. return false, fmt.Errorf(errFailedToGetSecret, err)
  173. }
  174. return true, nil
  175. }
  176. spec := p.store.GetSpec()
  177. if spec == nil || spec.Provider == nil {
  178. return false, errors.New(errNoProvider)
  179. }
  180. secret, err := p.findSecretByRef(ctx, ref.GetRemoteKey(), spec.Provider.BitwardenSecretsManager.ProjectID)
  181. if err != nil {
  182. return false, fmt.Errorf(errFailedToGetSecret, err)
  183. }
  184. if secret == nil {
  185. return false, nil
  186. }
  187. return true, nil
  188. }
  189. // GetSecretMap returns multiple k/v pairs from the provider.
  190. func (p *Provider) GetSecretMap(ctx context.Context, ref esv1.ExternalSecretDataRemoteRef) (map[string][]byte, error) {
  191. data, err := p.GetSecret(ctx, ref)
  192. if err != nil {
  193. return nil, err
  194. }
  195. if err := yaml.Unmarshal(data, map[string]any{}); err == nil {
  196. return p.parseYamlSecretData(data)
  197. }
  198. kv := make(map[string]json.RawMessage)
  199. if err := json.Unmarshal(data, &kv); err != nil {
  200. return nil, fmt.Errorf("error unmarshalling secret: %w", err)
  201. }
  202. secretData := make(map[string][]byte)
  203. for k, v := range kv {
  204. var strVal string
  205. err = json.Unmarshal(v, &strVal)
  206. if err == nil {
  207. secretData[k] = []byte(strVal)
  208. } else {
  209. secretData[k] = v
  210. }
  211. }
  212. return secretData, nil
  213. }
  214. func (p *Provider) parseYamlSecretData(data []byte) (map[string][]byte, error) {
  215. kv := make(map[string]any)
  216. if err := yaml.Unmarshal(data, &kv); err != nil {
  217. return nil, fmt.Errorf("error unmarshalling secret: %w", err)
  218. }
  219. secretData := make(map[string][]byte)
  220. for k, v := range kv {
  221. switch t := v.(type) {
  222. case string:
  223. secretData[k] = []byte(t)
  224. case []byte:
  225. secretData[k] = t
  226. case map[string]any:
  227. d, err := yaml.Marshal(t)
  228. if err != nil {
  229. return nil, fmt.Errorf("error marshaling secret: %w", err)
  230. }
  231. secretData[k] = bytes.TrimSpace(d)
  232. default:
  233. secretData[k] = []byte(fmt.Sprintf("%v", t)) // Convert to string and then []byte
  234. }
  235. }
  236. return secretData, nil
  237. }
  238. // GetAllSecrets gets multiple secrets from the provider and loads into a kubernetes secret.
  239. // First load all secrets from secretStore path configuration
  240. // Then, gets secrets from a matching name or matching custom_metadata.
  241. func (p *Provider) GetAllSecrets(ctx context.Context, _ esv1.ExternalSecretFind) (map[string][]byte, error) {
  242. spec := p.store.GetSpec()
  243. if spec == nil {
  244. return nil, errors.New(errNoProvider)
  245. }
  246. secrets, err := p.bitwardenSdkClient.ListSecrets(ctx, spec.Provider.BitwardenSecretsManager.OrganizationID)
  247. if err != nil {
  248. return nil, fmt.Errorf(errFailedToGetAllSecrets, err)
  249. }
  250. result := map[string][]byte{}
  251. for _, d := range secrets.Data {
  252. sec, err := p.bitwardenSdkClient.GetSecret(ctx, d.ID)
  253. if err != nil {
  254. return nil, fmt.Errorf(errFailedToGetSecret, err)
  255. }
  256. result[d.ID] = []byte(sec.Value)
  257. }
  258. return result, nil
  259. }
  260. // Validate validates the provider.
  261. func (p *Provider) Validate() (esv1.ValidationResult, error) {
  262. return esv1.ValidationResultReady, nil
  263. }
  264. // Close closes the provider.
  265. func (p *Provider) Close(_ context.Context) error {
  266. return nil
  267. }
  268. func (p *Provider) findSecretByRef(ctx context.Context, key, projectID string) (*SecretResponse, error) {
  269. spec := p.store.GetSpec()
  270. if spec == nil || spec.Provider == nil {
  271. return nil, errors.New(errNoProvider)
  272. }
  273. // ListAll Secrets for an organization. If the key matches our key, we GetSecret that and do a compare.
  274. secrets, err := p.bitwardenSdkClient.ListSecrets(ctx, spec.Provider.BitwardenSecretsManager.OrganizationID)
  275. if err != nil {
  276. return nil, fmt.Errorf(errFailedToGetAllSecrets, err)
  277. }
  278. var remoteSecret *SecretResponse
  279. for _, d := range secrets.Data {
  280. if d.Key != key {
  281. continue
  282. }
  283. sec, err := p.bitwardenSdkClient.GetSecret(ctx, d.ID)
  284. if err != nil {
  285. return nil, fmt.Errorf(errFailedToGetSecret, err)
  286. }
  287. if sec.ProjectID != nil && *sec.ProjectID == projectID {
  288. if remoteSecret != nil {
  289. return nil, fmt.Errorf("more than one secret found for project %s with key %s", projectID, key)
  290. }
  291. // We don't break here because we WANT TO MAKE SURE that there is ONLY ONE
  292. // such secret.
  293. remoteSecret = sec
  294. }
  295. }
  296. return remoteSecret, nil
  297. }