client.go 11 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379
  1. /*
  2. Licensed under the Apache License, Version 2.0 (the "License");
  3. you may not use this file except in compliance with the License.
  4. You may obtain a copy of the License at
  5. http://www.apache.org/licenses/LICENSE-2.0
  6. Unless required by applicable law or agreed to in writing, software
  7. distributed under the License is distributed on an "AS IS" BASIS,
  8. WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
  9. See the License for the specific language governing permissions and
  10. limitations under the License.
  11. */
  12. package bitwarden
  13. import (
  14. "bytes"
  15. "context"
  16. "encoding/json"
  17. "errors"
  18. "fmt"
  19. "gopkg.in/yaml.v3"
  20. corev1 "k8s.io/api/core/v1"
  21. "k8s.io/kube-openapi/pkg/validation/strfmt"
  22. "k8s.io/utils/ptr"
  23. esv1beta1 "github.com/external-secrets/external-secrets/apis/externalsecrets/v1beta1"
  24. "github.com/external-secrets/external-secrets/pkg/utils"
  25. )
  26. const (
  27. // NoteMetadataKey defines the note for the pushed secret.
  28. NoteMetadataKey = "note"
  29. errNoProvider = "store does not have a provider"
  30. )
  31. var (
  32. errFailedToGetAllSecrets = "failed to get all secrets: %w"
  33. errFailedToGetSecret = "failed to get secret: %w"
  34. )
  35. // PushSecret will write a single secret into the provider.
  36. // Note: We will refuse to overwrite ANY secrets, because we can never be completely
  37. // sure if it's the same secret we are trying to push. We only have the Name and the value
  38. // could be different. Therefore, we will always create a new secret. Except if, the value
  39. // the key, the note, and organization ID all match.
  40. // We only allow to push to a single project, because GET returns a single project ID
  41. // the secret belongs to even though technically Create allows multiple projects. This is
  42. // to ensure that we push to the same project always, and so we can determine reliably that
  43. // we don't need to push again.
  44. func (p *Provider) PushSecret(ctx context.Context, secret *corev1.Secret, data esv1beta1.PushSecretData) error {
  45. spec := p.store.GetSpec()
  46. if spec == nil || spec.Provider == nil {
  47. return errors.New(errNoProvider)
  48. }
  49. if data.GetRemoteKey() == "" {
  50. return errors.New("remote key must be defined")
  51. }
  52. var (
  53. value []byte
  54. err error
  55. ok bool
  56. )
  57. if data.GetSecretKey() == "" {
  58. decodedMap := make(map[string]string)
  59. for k, v := range secret.Data {
  60. decodedMap[k] = string(v)
  61. }
  62. value, err = utils.JSONMarshal(decodedMap)
  63. if err != nil {
  64. return fmt.Errorf("failed to marshal secret data: %w", err)
  65. }
  66. } else {
  67. value, ok = secret.Data[data.GetSecretKey()]
  68. if !ok {
  69. return fmt.Errorf("failed to find secret key in secret with key: %s", data.GetSecretKey())
  70. }
  71. }
  72. note, err := utils.FetchValueFromMetadata(NoteMetadataKey, data.GetMetadata(), "")
  73. if err != nil {
  74. return fmt.Errorf("failed to fetch note from metadata: %w", err)
  75. }
  76. // ListAll Secrets for an organization. If the key matches our key, we GetSecret that and do a compare.
  77. remoteSecrets, err := p.bitwardenSdkClient.ListSecrets(ctx, spec.Provider.BitwardenSecretsManager.OrganizationID)
  78. if err != nil {
  79. return fmt.Errorf(errFailedToGetAllSecrets, err)
  80. }
  81. for _, d := range remoteSecrets.Data {
  82. if d.Key != data.GetRemoteKey() {
  83. continue
  84. }
  85. sec, err := p.bitwardenSdkClient.GetSecret(ctx, d.ID)
  86. if err != nil {
  87. return fmt.Errorf("failed to get secret: %w", err)
  88. }
  89. // If all pushed data matches, we won't push this secret.
  90. if p.isExactlySameSecret(sec, data.GetRemoteKey(), note, spec.Provider.BitwardenSecretsManager.ProjectID, value) {
  91. // we have a complete match, skip pushing.
  92. return nil
  93. } else if p.isOnlyValueDifferent(sec, data.GetRemoteKey(), note, spec.Provider.BitwardenSecretsManager.ProjectID, value) {
  94. // only the value is different, update the existing secret.
  95. _, err = p.bitwardenSdkClient.UpdateSecret(ctx, SecretPutRequest{
  96. ID: sec.ID,
  97. Key: data.GetRemoteKey(),
  98. Note: note,
  99. OrganizationID: spec.Provider.BitwardenSecretsManager.OrganizationID,
  100. ProjectIDS: []string{spec.Provider.BitwardenSecretsManager.ProjectID},
  101. Value: string(value),
  102. })
  103. return err
  104. }
  105. }
  106. // no matching secret found, let's create it
  107. _, err = p.bitwardenSdkClient.CreateSecret(ctx, SecretCreateRequest{
  108. Key: data.GetRemoteKey(),
  109. Note: note,
  110. OrganizationID: spec.Provider.BitwardenSecretsManager.OrganizationID,
  111. ProjectIDS: []string{spec.Provider.BitwardenSecretsManager.ProjectID},
  112. Value: string(value),
  113. })
  114. return err
  115. }
  116. func (p *Provider) isExactlySameSecret(sec *SecretResponse, remoteKey, note, projectID string, value []byte) bool {
  117. return sec.Key == remoteKey &&
  118. sec.Value == string(value) &&
  119. sec.Note == note &&
  120. ptr.Deref(sec.ProjectID, "") == projectID
  121. }
  122. func (p *Provider) isOnlyValueDifferent(sec *SecretResponse, remoteKey, note, projectID string, value []byte) bool {
  123. return sec.Key == remoteKey &&
  124. sec.Value != string(value) &&
  125. sec.Note == note &&
  126. ptr.Deref(sec.ProjectID, "") == projectID
  127. }
  128. // GetSecret returns a single secret from the provider.
  129. func (p *Provider) GetSecret(ctx context.Context, ref esv1beta1.ExternalSecretDataRemoteRef) ([]byte, error) {
  130. if strfmt.IsUUID(ref.Key) {
  131. resp, err := p.bitwardenSdkClient.GetSecret(ctx, ref.Key)
  132. if err != nil {
  133. return nil, fmt.Errorf(errFailedToGetSecret, err)
  134. }
  135. return []byte(resp.Value), nil
  136. }
  137. spec := p.store.GetSpec()
  138. if spec == nil || spec.Provider == nil {
  139. return nil, errors.New(errNoProvider)
  140. }
  141. secret, err := p.findSecretByRef(ctx, ref.Key, spec.Provider.BitwardenSecretsManager.ProjectID)
  142. if err != nil {
  143. return nil, fmt.Errorf(errFailedToGetSecret, err)
  144. }
  145. if secret == nil {
  146. return nil, fmt.Errorf("no secret found for project id %s and name %s", spec.Provider.BitwardenSecretsManager.ProjectID, ref.Key)
  147. }
  148. // we found our secret, return the value for it
  149. return []byte(secret.Value), nil
  150. }
  151. func (p *Provider) DeleteSecret(ctx context.Context, ref esv1beta1.PushSecretRemoteRef) error {
  152. if strfmt.IsUUID(ref.GetRemoteKey()) {
  153. return p.deleteSecret(ctx, ref.GetRemoteKey())
  154. }
  155. spec := p.store.GetSpec()
  156. if spec == nil || spec.Provider == nil {
  157. return errors.New(errNoProvider)
  158. }
  159. secret, err := p.findSecretByRef(ctx, ref.GetRemoteKey(), spec.Provider.BitwardenSecretsManager.ProjectID)
  160. if err != nil {
  161. return fmt.Errorf(errFailedToGetSecret, err)
  162. }
  163. if secret == nil {
  164. return fmt.Errorf("no secret found for project id %s and name %s", spec.Provider.BitwardenSecretsManager.ProjectID, ref.GetRemoteKey())
  165. }
  166. return p.deleteSecret(ctx, secret.ID)
  167. }
  168. func (p *Provider) deleteSecret(ctx context.Context, id string) error {
  169. resp, err := p.bitwardenSdkClient.DeleteSecret(ctx, []string{id})
  170. if err != nil {
  171. return fmt.Errorf("error deleting secret: %w", err)
  172. }
  173. var errs error
  174. for _, data := range resp.Data {
  175. if data.Error != nil {
  176. errs = errors.Join(errs, fmt.Errorf("error deleting secret with id %s: %s", data.ID, *data.Error))
  177. }
  178. }
  179. if errs != nil {
  180. return fmt.Errorf("there were one or more errors deleting secrets: %w", errs)
  181. }
  182. return nil
  183. }
  184. func (p *Provider) SecretExists(ctx context.Context, ref esv1beta1.PushSecretRemoteRef) (bool, error) {
  185. if strfmt.IsUUID(ref.GetRemoteKey()) {
  186. _, err := p.bitwardenSdkClient.GetSecret(ctx, ref.GetRemoteKey())
  187. if err != nil {
  188. return false, fmt.Errorf(errFailedToGetSecret, err)
  189. }
  190. return true, nil
  191. }
  192. spec := p.store.GetSpec()
  193. if spec == nil || spec.Provider == nil {
  194. return false, errors.New(errNoProvider)
  195. }
  196. secret, err := p.findSecretByRef(ctx, ref.GetRemoteKey(), spec.Provider.BitwardenSecretsManager.ProjectID)
  197. if err != nil {
  198. return false, fmt.Errorf(errFailedToGetSecret, err)
  199. }
  200. if secret == nil {
  201. return false, nil
  202. }
  203. return true, nil
  204. }
  205. // GetSecretMap returns multiple k/v pairs from the provider.
  206. func (p *Provider) GetSecretMap(ctx context.Context, ref esv1beta1.ExternalSecretDataRemoteRef) (map[string][]byte, error) {
  207. data, err := p.GetSecret(ctx, ref)
  208. if err != nil {
  209. return nil, err
  210. }
  211. if err := yaml.Unmarshal(data, map[string]any{}); err == nil {
  212. return p.parseYamlSecretData(data)
  213. }
  214. kv := make(map[string]json.RawMessage)
  215. if err := json.Unmarshal(data, &kv); err != nil {
  216. return nil, fmt.Errorf("error unmarshalling secret: %w", err)
  217. }
  218. secretData := make(map[string][]byte)
  219. for k, v := range kv {
  220. var strVal string
  221. err = json.Unmarshal(v, &strVal)
  222. if err == nil {
  223. secretData[k] = []byte(strVal)
  224. } else {
  225. secretData[k] = v
  226. }
  227. }
  228. return secretData, nil
  229. }
  230. func (p *Provider) parseYamlSecretData(data []byte) (map[string][]byte, error) {
  231. kv := make(map[string]any)
  232. if err := yaml.Unmarshal(data, &kv); err != nil {
  233. return nil, fmt.Errorf("error unmarshalling secret: %w", err)
  234. }
  235. secretData := make(map[string][]byte)
  236. for k, v := range kv {
  237. switch t := v.(type) {
  238. case string:
  239. secretData[k] = []byte(t)
  240. case []byte:
  241. secretData[k] = t
  242. case map[string]any:
  243. d, err := yaml.Marshal(t)
  244. if err != nil {
  245. return nil, fmt.Errorf("error marshaling secret: %w", err)
  246. }
  247. secretData[k] = bytes.TrimSpace(d)
  248. default:
  249. secretData[k] = []byte(fmt.Sprintf("%v", t)) // Convert to string and then []byte
  250. }
  251. }
  252. return secretData, nil
  253. }
  254. // GetAllSecrets gets multiple secrets from the provider and loads into a kubernetes secret.
  255. // First load all secrets from secretStore path configuration
  256. // Then, gets secrets from a matching name or matching custom_metadata.
  257. func (p *Provider) GetAllSecrets(ctx context.Context, _ esv1beta1.ExternalSecretFind) (map[string][]byte, error) {
  258. spec := p.store.GetSpec()
  259. if spec == nil {
  260. return nil, errors.New(errNoProvider)
  261. }
  262. secrets, err := p.bitwardenSdkClient.ListSecrets(ctx, spec.Provider.BitwardenSecretsManager.OrganizationID)
  263. if err != nil {
  264. return nil, fmt.Errorf(errFailedToGetAllSecrets, err)
  265. }
  266. result := map[string][]byte{}
  267. for _, d := range secrets.Data {
  268. sec, err := p.bitwardenSdkClient.GetSecret(ctx, d.ID)
  269. if err != nil {
  270. return nil, fmt.Errorf(errFailedToGetSecret, err)
  271. }
  272. result[d.ID] = []byte(sec.Value)
  273. }
  274. return result, nil
  275. }
  276. // Validate validates the provider.
  277. func (p *Provider) Validate() (esv1beta1.ValidationResult, error) {
  278. return esv1beta1.ValidationResultReady, nil
  279. }
  280. // Close closes the provider.
  281. func (p *Provider) Close(_ context.Context) error {
  282. return nil
  283. }
  284. func (p *Provider) findSecretByRef(ctx context.Context, key, projectID string) (*SecretResponse, error) {
  285. spec := p.store.GetSpec()
  286. if spec == nil || spec.Provider == nil {
  287. return nil, errors.New(errNoProvider)
  288. }
  289. // ListAll Secrets for an organization. If the key matches our key, we GetSecret that and do a compare.
  290. secrets, err := p.bitwardenSdkClient.ListSecrets(ctx, spec.Provider.BitwardenSecretsManager.OrganizationID)
  291. if err != nil {
  292. return nil, fmt.Errorf(errFailedToGetAllSecrets, err)
  293. }
  294. var remoteSecret *SecretResponse
  295. for _, d := range secrets.Data {
  296. if d.Key != key {
  297. continue
  298. }
  299. sec, err := p.bitwardenSdkClient.GetSecret(ctx, d.ID)
  300. if err != nil {
  301. return nil, fmt.Errorf(errFailedToGetSecret, err)
  302. }
  303. if sec.ProjectID != nil && *sec.ProjectID == projectID {
  304. if remoteSecret != nil {
  305. return nil, fmt.Errorf("more than one secret found for project %s with key %s", projectID, key)
  306. }
  307. // We don't break here because we WANT TO MAKE SURE that there is ONLY ONE
  308. // such secret.
  309. remoteSecret = sec
  310. }
  311. }
  312. return remoteSecret, nil
  313. }