provider.go 18 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528529530531532533534535536537538539540541542543544545546547548549550551552553554555556557558559560561562563564565566567568569570571572573574575576577578579580581582583584585586587588589590591592593594595596597598599600601602603604605606607608609610611612613614615616617618619620621622623
  1. /*
  2. Licensed under the Apache License, Version 2.0 (the "License");
  3. you may not use this file except in compliance with the License.
  4. You may obtain a copy of the License at
  5. http://www.apache.org/licenses/LICENSE-2.0
  6. Unless required by applicable law or agreed to in writing, software
  7. distributed under the License is distributed on an "AS IS" BASIS,
  8. WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
  9. See the License for the specific language governing permissions and
  10. limitations under the License.
  11. */
  12. package ibm
  13. import (
  14. "context"
  15. "encoding/json"
  16. "fmt"
  17. "strconv"
  18. "strings"
  19. "time"
  20. core "github.com/IBM/go-sdk-core/v5/core"
  21. sm "github.com/IBM/secrets-manager-go-sdk/secretsmanagerv1"
  22. gjson "github.com/tidwall/gjson"
  23. corev1 "k8s.io/api/core/v1"
  24. types "k8s.io/apimachinery/pkg/types"
  25. ctrl "sigs.k8s.io/controller-runtime"
  26. kclient "sigs.k8s.io/controller-runtime/pkg/client"
  27. esv1beta1 "github.com/external-secrets/external-secrets/apis/externalsecrets/v1beta1"
  28. utils "github.com/external-secrets/external-secrets/pkg/utils"
  29. )
  30. const (
  31. SecretsManagerEndpointEnv = "IBM_SECRETSMANAGER_ENDPOINT"
  32. STSEndpointEnv = "IBM_STS_ENDPOINT"
  33. SSMEndpointEnv = "IBM_SSM_ENDPOINT"
  34. errIBMClient = "cannot setup new ibm client: %w"
  35. errIBMCredSecretName = "invalid IBM SecretStore resource: missing IBM APIKey"
  36. errUninitalizedIBMProvider = "provider IBM is not initialized"
  37. errInvalidClusterStoreMissingSKNamespace = "invalid ClusterStore, missing namespace"
  38. errFetchSAKSecret = "could not fetch SecretAccessKey secret: %w"
  39. errMissingSAK = "missing SecretAccessKey"
  40. errJSONSecretUnmarshal = "unable to unmarshal secret: %w"
  41. )
  42. // https://github.com/external-secrets/external-secrets/issues/644
  43. var _ esv1beta1.SecretsClient = &providerIBM{}
  44. var _ esv1beta1.Provider = &providerIBM{}
  45. type SecretManagerClient interface {
  46. GetSecret(getSecretOptions *sm.GetSecretOptions) (result *sm.GetSecret, response *core.DetailedResponse, err error)
  47. }
  48. type providerIBM struct {
  49. IBMClient SecretManagerClient
  50. }
  51. type client struct {
  52. kube kclient.Client
  53. store *esv1beta1.IBMProvider
  54. namespace string
  55. storeKind string
  56. credentials []byte
  57. }
  58. var log = ctrl.Log.WithName("provider").WithName("ibm").WithName("secretsmanager")
  59. func (c *client) setAuth(ctx context.Context) error {
  60. credentialsSecret := &corev1.Secret{}
  61. credentialsSecretName := c.store.Auth.SecretRef.SecretAPIKey.Name
  62. if credentialsSecretName == "" {
  63. return fmt.Errorf(errIBMCredSecretName)
  64. }
  65. objectKey := types.NamespacedName{
  66. Name: credentialsSecretName,
  67. Namespace: c.namespace,
  68. }
  69. // only ClusterStore is allowed to set namespace (and then it's required)
  70. if c.storeKind == esv1beta1.ClusterSecretStoreKind {
  71. if c.store.Auth.SecretRef.SecretAPIKey.Namespace == nil {
  72. return fmt.Errorf(errInvalidClusterStoreMissingSKNamespace)
  73. }
  74. objectKey.Namespace = *c.store.Auth.SecretRef.SecretAPIKey.Namespace
  75. }
  76. err := c.kube.Get(ctx, objectKey, credentialsSecret)
  77. if err != nil {
  78. return fmt.Errorf(errFetchSAKSecret, err)
  79. }
  80. c.credentials = credentialsSecret.Data[c.store.Auth.SecretRef.SecretAPIKey.Key]
  81. if (c.credentials == nil) || (len(c.credentials) == 0) {
  82. return fmt.Errorf(errMissingSAK)
  83. }
  84. return nil
  85. }
  86. // Empty GetAllSecrets.
  87. func (ibm *providerIBM) GetAllSecrets(ctx context.Context, ref esv1beta1.ExternalSecretFind) (map[string][]byte, error) {
  88. // TO be implemented
  89. return nil, fmt.Errorf("GetAllSecrets not implemented")
  90. }
  91. func (ibm *providerIBM) GetSecret(ctx context.Context, ref esv1beta1.ExternalSecretDataRemoteRef) ([]byte, error) {
  92. if utils.IsNil(ibm.IBMClient) {
  93. return nil, fmt.Errorf(errUninitalizedIBMProvider)
  94. }
  95. secretType := sm.GetSecretOptionsSecretTypeArbitraryConst
  96. secretName := ref.Key
  97. nameSplitted := strings.Split(secretName, "/")
  98. if len(nameSplitted) > 1 {
  99. secretType = nameSplitted[0]
  100. secretName = nameSplitted[1]
  101. }
  102. switch secretType {
  103. case sm.GetSecretOptionsSecretTypeArbitraryConst:
  104. return getArbitrarySecret(ibm, &secretName)
  105. case sm.CreateSecretOptionsSecretTypeUsernamePasswordConst:
  106. if ref.Property == "" {
  107. return nil, fmt.Errorf("remoteRef.property required for secret type username_password")
  108. }
  109. return getUsernamePasswordSecret(ibm, &secretName, ref)
  110. case sm.CreateSecretOptionsSecretTypeIamCredentialsConst:
  111. return getIamCredentialsSecret(ibm, &secretName)
  112. case sm.CreateSecretOptionsSecretTypeImportedCertConst:
  113. if ref.Property == "" {
  114. return nil, fmt.Errorf("remoteRef.property required for secret type imported_cert")
  115. }
  116. return getImportCertSecret(ibm, &secretName, ref)
  117. case sm.CreateSecretOptionsSecretTypePublicCertConst:
  118. if ref.Property == "" {
  119. return nil, fmt.Errorf("remoteRef.property required for secret type public_cert")
  120. }
  121. return getPublicCertSecret(ibm, &secretName, ref)
  122. case sm.CreateSecretOptionsSecretTypePrivateCertConst:
  123. if ref.Property == "" {
  124. return nil, fmt.Errorf("remoteRef.property required for secret type private_cert")
  125. }
  126. return getPrivateCertSecret(ibm, &secretName, ref)
  127. case sm.CreateSecretOptionsSecretTypeKvConst:
  128. return getKVSecret(ibm, &secretName, ref)
  129. default:
  130. return nil, fmt.Errorf("unknown secret type %s", secretType)
  131. }
  132. }
  133. func getArbitrarySecret(ibm *providerIBM, secretName *string) ([]byte, error) {
  134. response, _, err := ibm.IBMClient.GetSecret(
  135. &sm.GetSecretOptions{
  136. SecretType: core.StringPtr(sm.GetSecretOptionsSecretTypeArbitraryConst),
  137. ID: secretName,
  138. })
  139. if err != nil {
  140. return nil, err
  141. }
  142. secret := response.Resources[0].(*sm.SecretResource)
  143. secretData := secret.SecretData.(map[string]interface{})
  144. arbitrarySecretPayload := secretData["payload"].(string)
  145. return []byte(arbitrarySecretPayload), nil
  146. }
  147. func getImportCertSecret(ibm *providerIBM, secretName *string, ref esv1beta1.ExternalSecretDataRemoteRef) ([]byte, error) {
  148. response, _, err := ibm.IBMClient.GetSecret(
  149. &sm.GetSecretOptions{
  150. SecretType: core.StringPtr(sm.CreateSecretOptionsSecretTypeImportedCertConst),
  151. ID: secretName,
  152. })
  153. if err != nil {
  154. return nil, err
  155. }
  156. secret := response.Resources[0].(*sm.SecretResource)
  157. secretData := secret.SecretData.(map[string]interface{})
  158. if val, ok := secretData[ref.Property]; ok {
  159. return []byte(val.(string)), nil
  160. }
  161. return nil, fmt.Errorf("key %s does not exist in secret %s", ref.Property, ref.Key)
  162. }
  163. func getPublicCertSecret(ibm *providerIBM, secretName *string, ref esv1beta1.ExternalSecretDataRemoteRef) ([]byte, error) {
  164. response, _, err := ibm.IBMClient.GetSecret(
  165. &sm.GetSecretOptions{
  166. SecretType: core.StringPtr(sm.CreateSecretOptionsSecretTypePublicCertConst),
  167. ID: secretName,
  168. })
  169. if err != nil {
  170. return nil, err
  171. }
  172. secret := response.Resources[0].(*sm.SecretResource)
  173. secretData := secret.SecretData.(map[string]interface{})
  174. if val, ok := secretData[ref.Property]; ok {
  175. return []byte(val.(string)), nil
  176. }
  177. return nil, fmt.Errorf("key %s does not exist in secret %s", ref.Property, ref.Key)
  178. }
  179. func getPrivateCertSecret(ibm *providerIBM, secretName *string, ref esv1beta1.ExternalSecretDataRemoteRef) ([]byte, error) {
  180. response, _, err := ibm.IBMClient.GetSecret(
  181. &sm.GetSecretOptions{
  182. SecretType: core.StringPtr(sm.CreateSecretOptionsSecretTypePrivateCertConst),
  183. ID: secretName,
  184. })
  185. if err != nil {
  186. return nil, err
  187. }
  188. secret := response.Resources[0].(*sm.SecretResource)
  189. secretData := secret.SecretData.(map[string]interface{})
  190. if val, ok := secretData[ref.Property]; ok {
  191. return []byte(val.(string)), nil
  192. }
  193. return nil, fmt.Errorf("key %s does not exist in secret %s", ref.Property, ref.Key)
  194. }
  195. func getIamCredentialsSecret(ibm *providerIBM, secretName *string) ([]byte, error) {
  196. response, _, err := ibm.IBMClient.GetSecret(
  197. &sm.GetSecretOptions{
  198. SecretType: core.StringPtr(sm.CreateSecretOptionsSecretTypeIamCredentialsConst),
  199. ID: secretName,
  200. })
  201. if err != nil {
  202. return nil, err
  203. }
  204. secret := response.Resources[0].(*sm.SecretResource)
  205. secretData := *secret.APIKey
  206. return []byte(secretData), nil
  207. }
  208. func getUsernamePasswordSecret(ibm *providerIBM, secretName *string, ref esv1beta1.ExternalSecretDataRemoteRef) ([]byte, error) {
  209. response, _, err := ibm.IBMClient.GetSecret(
  210. &sm.GetSecretOptions{
  211. SecretType: core.StringPtr(sm.CreateSecretOptionsSecretTypeUsernamePasswordConst),
  212. ID: secretName,
  213. })
  214. if err != nil {
  215. return nil, err
  216. }
  217. secret := response.Resources[0].(*sm.SecretResource)
  218. secretData := secret.SecretData.(map[string]interface{})
  219. if val, ok := secretData[ref.Property]; ok {
  220. return []byte(val.(string)), nil
  221. }
  222. return nil, fmt.Errorf("key %s does not exist in secret %s", ref.Property, ref.Key)
  223. }
  224. // Returns a secret of type kv and supports json path.
  225. func getKVSecret(ibm *providerIBM, secretName *string, ref esv1beta1.ExternalSecretDataRemoteRef) ([]byte, error) {
  226. secret, err := getSecretByType(ibm, secretName, sm.CreateSecretOptionsSecretTypeKvConst)
  227. if err != nil {
  228. return nil, err
  229. }
  230. log.Info("fetching secret", "secretName", secretName, "key", ref.Key)
  231. secretData := secret.SecretData.(map[string]interface{})
  232. payload, ok := secretData["payload"]
  233. if !ok {
  234. return nil, fmt.Errorf("no payload returned for secret %s", ref.Key)
  235. }
  236. payloadJSON := payload
  237. payloadJSONMap, ok := payloadJSON.(map[string]interface{})
  238. if ok {
  239. var payloadJSONByte []byte
  240. payloadJSONByte, err = json.Marshal(payloadJSONMap)
  241. if err != nil {
  242. return nil, fmt.Errorf("marshaling payload from secret failed. %w", err)
  243. }
  244. payloadJSON = string(payloadJSONByte)
  245. }
  246. // no property requested, return the entire payload
  247. if ref.Property == "" {
  248. return []byte(payloadJSON.(string)), nil
  249. }
  250. // returns the requested key
  251. // consider that the key contains a ".". this could be one of 2 options
  252. // a) "." is part of the key name
  253. // b) "." is symbole for JSON path
  254. if ref.Property != "" {
  255. refProperty := ref.Property
  256. // a) "." is part the key name
  257. // escape "."
  258. idx := strings.Index(refProperty, ".")
  259. if idx > 0 {
  260. refProperty = strings.ReplaceAll(refProperty, ".", "\\.")
  261. val := gjson.Get(payloadJSON.(string), refProperty)
  262. if val.Exists() {
  263. return []byte(val.String()), nil
  264. }
  265. }
  266. // b) "." is symbole for JSON path
  267. // try to get value for this path
  268. val := gjson.Get(payloadJSON.(string), ref.Property)
  269. if !val.Exists() {
  270. return nil, fmt.Errorf("key %s does not exist in secret %s", ref.Property, ref.Key)
  271. }
  272. return []byte(val.String()), nil
  273. }
  274. return nil, fmt.Errorf("no property provided for secret %s", ref.Key)
  275. }
  276. func getSecretByType(ibm *providerIBM, secretName *string, secretType string) (*sm.SecretResource, error) {
  277. response, _, err := ibm.IBMClient.GetSecret(
  278. &sm.GetSecretOptions{
  279. SecretType: core.StringPtr(secretType),
  280. ID: secretName,
  281. })
  282. if err != nil {
  283. return nil, err
  284. }
  285. secret := response.Resources[0].(*sm.SecretResource)
  286. return secret, nil
  287. }
  288. func (ibm *providerIBM) GetSecretMap(ctx context.Context, ref esv1beta1.ExternalSecretDataRemoteRef) (map[string][]byte, error) {
  289. if utils.IsNil(ibm.IBMClient) {
  290. return nil, fmt.Errorf(errUninitalizedIBMProvider)
  291. }
  292. secretType := sm.GetSecretOptionsSecretTypeArbitraryConst
  293. secretName := ref.Key
  294. nameSplitted := strings.Split(secretName, "/")
  295. if len(nameSplitted) > 1 {
  296. secretType = nameSplitted[0]
  297. secretName = nameSplitted[1]
  298. }
  299. switch secretType {
  300. case sm.GetSecretOptionsSecretTypeArbitraryConst:
  301. response, _, err := ibm.IBMClient.GetSecret(
  302. &sm.GetSecretOptions{
  303. SecretType: core.StringPtr(sm.GetSecretOptionsSecretTypeArbitraryConst),
  304. ID: &ref.Key,
  305. })
  306. if err != nil {
  307. return nil, err
  308. }
  309. secret := response.Resources[0].(*sm.SecretResource)
  310. secretData := secret.SecretData.(map[string]interface{})
  311. arbitrarySecretPayload := secretData["payload"].(string)
  312. kv := make(map[string]interface{})
  313. err = json.Unmarshal([]byte(arbitrarySecretPayload), &kv)
  314. if err != nil {
  315. return nil, fmt.Errorf(errJSONSecretUnmarshal, err)
  316. }
  317. secretMap := byteArrayMap(kv)
  318. return secretMap, nil
  319. case sm.CreateSecretOptionsSecretTypeUsernamePasswordConst:
  320. response, _, err := ibm.IBMClient.GetSecret(
  321. &sm.GetSecretOptions{
  322. SecretType: core.StringPtr(sm.CreateSecretOptionsSecretTypeUsernamePasswordConst),
  323. ID: &secretName,
  324. })
  325. if err != nil {
  326. return nil, err
  327. }
  328. secret := response.Resources[0].(*sm.SecretResource)
  329. secretData := secret.SecretData.(map[string]interface{})
  330. secretMap := byteArrayMap(secretData)
  331. return secretMap, nil
  332. case sm.CreateSecretOptionsSecretTypeIamCredentialsConst:
  333. response, _, err := ibm.IBMClient.GetSecret(
  334. &sm.GetSecretOptions{
  335. SecretType: core.StringPtr(sm.CreateSecretOptionsSecretTypeIamCredentialsConst),
  336. ID: &secretName,
  337. })
  338. if err != nil {
  339. return nil, err
  340. }
  341. secret := response.Resources[0].(*sm.SecretResource)
  342. secretData := *secret.APIKey
  343. secretMap := make(map[string][]byte)
  344. secretMap["apikey"] = []byte(secretData)
  345. return secretMap, nil
  346. case sm.CreateSecretOptionsSecretTypeImportedCertConst:
  347. response, _, err := ibm.IBMClient.GetSecret(
  348. &sm.GetSecretOptions{
  349. SecretType: core.StringPtr(sm.CreateSecretOptionsSecretTypeImportedCertConst),
  350. ID: &secretName,
  351. })
  352. if err != nil {
  353. return nil, err
  354. }
  355. secret := response.Resources[0].(*sm.SecretResource)
  356. secretData := secret.SecretData.(map[string]interface{})
  357. secretMap := byteArrayMap(secretData)
  358. return secretMap, nil
  359. case sm.CreateSecretOptionsSecretTypePublicCertConst:
  360. response, _, err := ibm.IBMClient.GetSecret(
  361. &sm.GetSecretOptions{
  362. SecretType: core.StringPtr(sm.CreateSecretOptionsSecretTypePublicCertConst),
  363. ID: &secretName,
  364. })
  365. if err != nil {
  366. return nil, err
  367. }
  368. secret := response.Resources[0].(*sm.SecretResource)
  369. secretData := secret.SecretData.(map[string]interface{})
  370. secretMap := byteArrayMap(secretData)
  371. return secretMap, nil
  372. case sm.CreateSecretOptionsSecretTypePrivateCertConst:
  373. response, _, err := ibm.IBMClient.GetSecret(
  374. &sm.GetSecretOptions{
  375. SecretType: core.StringPtr(sm.CreateSecretOptionsSecretTypePrivateCertConst),
  376. ID: &secretName,
  377. })
  378. if err != nil {
  379. return nil, err
  380. }
  381. secret := response.Resources[0].(*sm.SecretResource)
  382. secretData := secret.SecretData.(map[string]interface{})
  383. secretMap := byteArrayMap(secretData)
  384. return secretMap, nil
  385. case sm.CreateSecretOptionsSecretTypeKvConst:
  386. secret, err := getKVSecret(ibm, &secretName, ref)
  387. if err != nil {
  388. return nil, err
  389. }
  390. m := make(map[string]interface{})
  391. err = json.Unmarshal(secret, &m)
  392. if err != nil {
  393. return nil, err
  394. }
  395. secretMap := byteArrayMap(m)
  396. return secretMap, nil
  397. default:
  398. return nil, fmt.Errorf("unknown secret type %s", secretType)
  399. }
  400. }
  401. func byteArrayMap(secretData map[string]interface{}) map[string][]byte {
  402. var err error
  403. secretMap := make(map[string][]byte)
  404. for k, v := range secretData {
  405. secretMap[k], err = getTypedKey(v)
  406. if err != nil {
  407. return nil
  408. }
  409. }
  410. return secretMap
  411. }
  412. // kudos Vault Provider - convert from various types.
  413. func getTypedKey(v interface{}) ([]byte, error) {
  414. switch t := v.(type) {
  415. case string:
  416. return []byte(t), nil
  417. case map[string]interface{}:
  418. return json.Marshal(t)
  419. case map[string]string:
  420. return json.Marshal(t)
  421. case []byte:
  422. return t, nil
  423. // also covers int and float32 due to json.Marshal
  424. case float64:
  425. return []byte(strconv.FormatFloat(t, 'f', -1, 64)), nil
  426. case bool:
  427. return []byte(strconv.FormatBool(t)), nil
  428. case nil:
  429. return []byte(nil), nil
  430. default:
  431. return nil, fmt.Errorf("secret not in expected format")
  432. }
  433. }
  434. func (ibm *providerIBM) Close(ctx context.Context) error {
  435. return nil
  436. }
  437. func (ibm *providerIBM) Validate() (esv1beta1.ValidationResult, error) {
  438. return esv1beta1.ValidationResultReady, nil
  439. }
  440. func (ibm *providerIBM) ValidateStore(store esv1beta1.GenericStore) error {
  441. storeSpec := store.GetSpec()
  442. ibmSpec := storeSpec.Provider.IBM
  443. if ibmSpec.ServiceURL == nil {
  444. return fmt.Errorf("serviceURL is required")
  445. }
  446. secretRef := ibmSpec.Auth.SecretRef.SecretAPIKey
  447. err := utils.ValidateSecretSelector(store, secretRef)
  448. if err != nil {
  449. return err
  450. }
  451. if secretRef.Name == "" {
  452. return fmt.Errorf("secretAPIKey.name cannot be empty")
  453. }
  454. if secretRef.Key == "" {
  455. return fmt.Errorf("secretAPIKey.key cannot be empty")
  456. }
  457. return nil
  458. }
  459. func (ibm *providerIBM) NewClient(ctx context.Context, store esv1beta1.GenericStore, kube kclient.Client, namespace string) (esv1beta1.SecretsClient, error) {
  460. storeSpec := store.GetSpec()
  461. ibmSpec := storeSpec.Provider.IBM
  462. iStore := &client{
  463. kube: kube,
  464. store: ibmSpec,
  465. namespace: namespace,
  466. storeKind: store.GetObjectKind().GroupVersionKind().Kind,
  467. }
  468. if err := iStore.setAuth(ctx); err != nil {
  469. return nil, err
  470. }
  471. secretsManager, err := sm.NewSecretsManagerV1(&sm.SecretsManagerV1Options{
  472. URL: *storeSpec.Provider.IBM.ServiceURL,
  473. Authenticator: &core.IamAuthenticator{
  474. ApiKey: string(iStore.credentials),
  475. },
  476. })
  477. // Setup retry options, but only if present
  478. if storeSpec.RetrySettings != nil {
  479. var retryAmount int
  480. var retryDuration time.Duration
  481. if storeSpec.RetrySettings.MaxRetries != nil {
  482. retryAmount = int(*storeSpec.RetrySettings.MaxRetries)
  483. } else {
  484. retryAmount = 3
  485. }
  486. if storeSpec.RetrySettings.RetryInterval != nil {
  487. retryDuration, err = time.ParseDuration(*storeSpec.RetrySettings.RetryInterval)
  488. } else {
  489. retryDuration = 5 * time.Second
  490. }
  491. if err == nil {
  492. secretsManager.Service.EnableRetries(retryAmount, retryDuration)
  493. }
  494. }
  495. if err != nil {
  496. return nil, fmt.Errorf(errIBMClient, err)
  497. }
  498. ibm.IBMClient = secretsManager
  499. return ibm, nil
  500. }
  501. func init() {
  502. esv1beta1.Register(&providerIBM{}, &esv1beta1.SecretStoreProvider{
  503. IBM: &esv1beta1.IBMProvider{},
  504. })
  505. }