secretsmanager.go 24 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528529530531532533534535536537538539540541542543544545546547548549550551552553554555556557558559560561562563564565566567568569570571572573574575576577578579580581582583584585586587588589590591592593594595596597598599600601602603604605606607608609610611612613614615616617618619620621622623624625626627628629630631632633634635636637638639640641642643644645646647648649650651652653654655656657658659660661662663664665666667668669670671672673674675676677678679680681682683684685686687688689690691692693694695696697698699700701702703704705706707708709710711712713714715716717718719720721722723724725726727728729730731732733734735736737738739740741742743744745746747748749750751752753754755756757758759760761762763
  1. /*
  2. Copyright © 2025 ESO Maintainer Team
  3. Licensed under the Apache License, Version 2.0 (the "License");
  4. you may not use this file except in compliance with the License.
  5. You may obtain a copy of the License at
  6. https://www.apache.org/licenses/LICENSE-2.0
  7. Unless required by applicable law or agreed to in writing, software
  8. distributed under the License is distributed on an "AS IS" BASIS,
  9. WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
  10. See the License for the specific language governing permissions and
  11. limitations under the License.
  12. */
  13. package secretsmanager
  14. import (
  15. "bytes"
  16. "context"
  17. "encoding/json"
  18. "errors"
  19. "fmt"
  20. "slices"
  21. "strings"
  22. "github.com/aws/aws-sdk-go-v2/aws"
  23. awssm "github.com/aws/aws-sdk-go-v2/service/secretsmanager"
  24. "github.com/aws/aws-sdk-go-v2/service/secretsmanager/types"
  25. "github.com/aws/smithy-go"
  26. "github.com/google/uuid"
  27. "github.com/tidwall/gjson"
  28. "github.com/tidwall/sjson"
  29. corev1 "k8s.io/api/core/v1"
  30. apiextensionsv1 "k8s.io/apiextensions-apiserver/pkg/apis/apiextensions/v1"
  31. utilpointer "k8s.io/utils/ptr"
  32. ctrl "sigs.k8s.io/controller-runtime"
  33. esv1 "github.com/external-secrets/external-secrets/apis/externalsecrets/v1"
  34. "github.com/external-secrets/external-secrets/pkg/constants"
  35. "github.com/external-secrets/external-secrets/pkg/find"
  36. "github.com/external-secrets/external-secrets/pkg/metrics"
  37. "github.com/external-secrets/external-secrets/pkg/provider/aws/util"
  38. "github.com/external-secrets/external-secrets/pkg/utils"
  39. "github.com/external-secrets/external-secrets/pkg/utils/metadata"
  40. )
  41. type PushSecretMetadataSpec struct {
  42. Tags map[string]string `json:"tags,omitempty"`
  43. Description string `json:"description,omitempty"`
  44. SecretPushFormat string `json:"secretPushFormat,omitempty"`
  45. KMSKeyID string `json:"kmsKeyId,omitempty"`
  46. }
  47. // Declares metadata information for pushing secrets to AWS Secret Store.
  48. const (
  49. SecretPushFormatKey = "secretPushFormat"
  50. SecretPushFormatString = "string"
  51. SecretPushFormatBinary = "binary"
  52. ResourceNotFoundException = "ResourceNotFoundException"
  53. )
  54. // https://github.com/external-secrets/external-secrets/issues/644
  55. var _ esv1.SecretsClient = &SecretsManager{}
  56. // SecretsManager is a provider for AWS SecretsManager.
  57. type SecretsManager struct {
  58. cfg *aws.Config
  59. client SMInterface // Keep the interface
  60. referentAuth bool
  61. cache map[string]*awssm.GetSecretValueOutput
  62. config *esv1.SecretsManager
  63. prefix string
  64. newUUID func() string
  65. }
  66. // SMInterface is a subset of the smiface api.
  67. // see: https://docs.aws.amazon.com/sdk-for-go/api/service/secretsmanager/secretsmanageriface/
  68. type SMInterface interface {
  69. BatchGetSecretValue(ctx context.Context, params *awssm.BatchGetSecretValueInput, optFuncs ...func(*awssm.Options)) (*awssm.BatchGetSecretValueOutput, error)
  70. ListSecrets(ctx context.Context, params *awssm.ListSecretsInput, optFuncs ...func(*awssm.Options)) (*awssm.ListSecretsOutput, error)
  71. GetSecretValue(ctx context.Context, params *awssm.GetSecretValueInput, optFuncs ...func(*awssm.Options)) (*awssm.GetSecretValueOutput, error)
  72. CreateSecret(ctx context.Context, params *awssm.CreateSecretInput, optFuncs ...func(*awssm.Options)) (*awssm.CreateSecretOutput, error)
  73. PutSecretValue(ctx context.Context, params *awssm.PutSecretValueInput, optFuncs ...func(*awssm.Options)) (*awssm.PutSecretValueOutput, error)
  74. DescribeSecret(ctx context.Context, params *awssm.DescribeSecretInput, optFuncs ...func(*awssm.Options)) (*awssm.DescribeSecretOutput, error)
  75. DeleteSecret(ctx context.Context, params *awssm.DeleteSecretInput, optFuncs ...func(*awssm.Options)) (*awssm.DeleteSecretOutput, error)
  76. TagResource(ctx context.Context, params *awssm.TagResourceInput, optFuncs ...func(*awssm.Options)) (*awssm.TagResourceOutput, error)
  77. UntagResource(ctx context.Context, params *awssm.UntagResourceInput, optFuncs ...func(*awssm.Options)) (*awssm.UntagResourceOutput, error)
  78. }
  79. const (
  80. errUnexpectedFindOperator = "unexpected find operator"
  81. managedBy = "managed-by"
  82. externalSecrets = "external-secrets"
  83. initialVersion = "00000000-0000-0000-0000-000000000001"
  84. )
  85. var log = ctrl.Log.WithName("provider").WithName("aws").WithName("secretsmanager")
  86. // New creates a new SecretsManager client.
  87. func New(_ context.Context, cfg *aws.Config, secretsManagerCfg *esv1.SecretsManager, prefix string, referentAuth bool) (*SecretsManager, error) {
  88. return &SecretsManager{
  89. cfg: cfg,
  90. client: awssm.NewFromConfig(*cfg, func(o *awssm.Options) {
  91. o.EndpointResolverV2 = customEndpointResolver{}
  92. }),
  93. referentAuth: referentAuth,
  94. cache: make(map[string]*awssm.GetSecretValueOutput),
  95. config: secretsManagerCfg,
  96. prefix: prefix,
  97. }, nil
  98. }
  99. func (sm *SecretsManager) fetch(ctx context.Context, ref esv1.ExternalSecretDataRemoteRef) (*awssm.GetSecretValueOutput, error) {
  100. ver := "AWSCURRENT"
  101. valueFrom := "SECRET"
  102. if ref.Version != "" {
  103. ver = ref.Version
  104. }
  105. if ref.MetadataPolicy == esv1.ExternalSecretMetadataPolicyFetch {
  106. valueFrom = "TAG"
  107. }
  108. key := sm.prefix + ref.Key
  109. log.Info("fetching secret value", "key", key, "version", ver, "value", valueFrom)
  110. cacheKey := fmt.Sprintf("%s#%s#%s", key, ver, valueFrom)
  111. if secretOut, found := sm.cache[cacheKey]; found {
  112. log.Info("found secret in cache", "key", key, "version", ver)
  113. return secretOut, nil
  114. }
  115. secretOut, err := sm.constructSecretValue(ctx, key, ver, ref.MetadataPolicy)
  116. if err != nil {
  117. return nil, err
  118. }
  119. sm.cache[cacheKey] = secretOut
  120. return secretOut, nil
  121. }
  122. func (sm *SecretsManager) DeleteSecret(ctx context.Context, remoteRef esv1.PushSecretRemoteRef) error {
  123. secretName := sm.prefix + remoteRef.GetRemoteKey()
  124. secretValue := awssm.GetSecretValueInput{
  125. SecretId: &secretName,
  126. }
  127. secretInput := awssm.DescribeSecretInput{
  128. SecretId: &secretName,
  129. }
  130. awsSecret, err := sm.client.GetSecretValue(ctx, &secretValue)
  131. metrics.ObserveAPICall(constants.ProviderAWSSM, constants.CallAWSSMGetSecretValue, err)
  132. var aerr smithy.APIError
  133. if err != nil {
  134. if ok := errors.As(err, &aerr); !ok {
  135. return err
  136. }
  137. if aerr.ErrorCode() == ResourceNotFoundException {
  138. return nil
  139. }
  140. return err
  141. }
  142. data, err := sm.client.DescribeSecret(ctx, &secretInput)
  143. metrics.ObserveAPICall(constants.ProviderAWSSM, constants.CallAWSSMDescribeSecret, err)
  144. if err != nil {
  145. return err
  146. }
  147. if !isManagedByESO(data) {
  148. return nil
  149. }
  150. deleteInput := &awssm.DeleteSecretInput{
  151. SecretId: awsSecret.ARN,
  152. }
  153. if sm.config != nil && sm.config.ForceDeleteWithoutRecovery {
  154. deleteInput.ForceDeleteWithoutRecovery = &sm.config.ForceDeleteWithoutRecovery
  155. }
  156. if sm.config != nil && sm.config.RecoveryWindowInDays > 0 {
  157. deleteInput.RecoveryWindowInDays = &sm.config.RecoveryWindowInDays
  158. }
  159. err = util.ValidateDeleteSecretInput(*deleteInput)
  160. if err != nil {
  161. return err
  162. }
  163. _, err = sm.client.DeleteSecret(ctx, deleteInput)
  164. metrics.ObserveAPICall(constants.ProviderAWSSM, constants.CallAWSSMDeleteSecret, err)
  165. return err
  166. }
  167. func (sm *SecretsManager) SecretExists(ctx context.Context, pushSecretRef esv1.PushSecretRemoteRef) (bool, error) {
  168. secretName := sm.prefix + pushSecretRef.GetRemoteKey()
  169. secretValue := awssm.GetSecretValueInput{
  170. SecretId: &secretName,
  171. }
  172. _, err := sm.client.GetSecretValue(ctx, &secretValue)
  173. if err != nil {
  174. return sm.handleSecretError(err)
  175. }
  176. return true, nil
  177. }
  178. func (sm *SecretsManager) handleSecretError(err error) (bool, error) {
  179. var aerr smithy.APIError
  180. if ok := errors.As(err, &aerr); !ok {
  181. return false, err
  182. }
  183. if aerr.ErrorCode() == ResourceNotFoundException {
  184. return false, nil
  185. }
  186. return false, err
  187. }
  188. func (sm *SecretsManager) PushSecret(ctx context.Context, secret *corev1.Secret, psd esv1.PushSecretData) error {
  189. value, err := utils.ExtractSecretData(psd, secret)
  190. if err != nil {
  191. return fmt.Errorf("failed to extract secret data: %w", err)
  192. }
  193. secretName := sm.prefix + psd.GetRemoteKey()
  194. describeSecretInput := awssm.DescribeSecretInput{SecretId: &secretName}
  195. describeSecretOutput, err := sm.client.DescribeSecret(ctx, &describeSecretInput)
  196. metrics.ObserveAPICall(constants.ProviderAWSSM, constants.CallAWSSMDescribeSecret, err)
  197. var aerr smithy.APIError
  198. if err != nil {
  199. if ok := errors.As(err, &aerr); !ok {
  200. return err
  201. }
  202. if aerr.ErrorCode() == ResourceNotFoundException {
  203. finalValue, err := sm.getNewSecretValue(value, psd.GetProperty(), nil)
  204. if err != nil {
  205. return err
  206. }
  207. return sm.createSecretWithContext(ctx, secretName, psd, finalValue)
  208. }
  209. return err
  210. } else if !isManagedByESO(describeSecretOutput) {
  211. return errors.New("secret not managed by external-secrets")
  212. }
  213. if len(describeSecretOutput.VersionIdsToStages) == 0 {
  214. finalValue, err := sm.getNewSecretValue(value, psd.GetProperty(), nil)
  215. if err != nil {
  216. return err
  217. }
  218. return sm.putSecretValueWithContext(ctx, secretName, nil, psd, finalValue, describeSecretOutput.Tags)
  219. }
  220. getSecretValueInput := awssm.GetSecretValueInput{SecretId: &secretName}
  221. getSecretValueOutput, err := sm.client.GetSecretValue(ctx, &getSecretValueInput)
  222. metrics.ObserveAPICall(constants.ProviderAWSSM, constants.CallAWSSMGetSecretValue, err)
  223. if err != nil {
  224. return err
  225. }
  226. finalValue, err := sm.getNewSecretValue(value, psd.GetProperty(), getSecretValueOutput)
  227. if err != nil {
  228. return err
  229. }
  230. return sm.putSecretValueWithContext(ctx, secretName, getSecretValueOutput, psd, finalValue, describeSecretOutput.Tags)
  231. }
  232. func (sm *SecretsManager) getNewSecretValue(value []byte, property string, existingSecret *awssm.GetSecretValueOutput) ([]byte, error) {
  233. if property == "" {
  234. return value, nil
  235. }
  236. if existingSecret == nil {
  237. value, _ = sjson.SetBytes([]byte{}, property, value)
  238. return value, nil
  239. }
  240. currentSecret := sm.retrievePayload(existingSecret)
  241. if currentSecret != "" && !gjson.Valid(currentSecret) {
  242. return nil, errors.New("PushSecret for aws secrets manager with a pushSecretData property requires a json secret")
  243. }
  244. value, _ = sjson.SetBytes([]byte(currentSecret), property, value)
  245. return value, nil
  246. }
  247. func isManagedByESO(data *awssm.DescribeSecretOutput) bool {
  248. managedBy := managedBy
  249. externalSecrets := externalSecrets
  250. for _, tag := range data.Tags {
  251. if *tag.Key == managedBy && *tag.Value == externalSecrets {
  252. return true
  253. }
  254. }
  255. return false
  256. }
  257. // GetAllSecrets syncs multiple secrets from aws provider into a single Kubernetes Secret.
  258. func (sm *SecretsManager) GetAllSecrets(ctx context.Context, ref esv1.ExternalSecretFind) (map[string][]byte, error) {
  259. if ref.Name != nil {
  260. return sm.findByName(ctx, ref)
  261. }
  262. if len(ref.Tags) > 0 {
  263. return sm.findByTags(ctx, ref)
  264. }
  265. return nil, errors.New(errUnexpectedFindOperator)
  266. }
  267. func (sm *SecretsManager) findByName(ctx context.Context, ref esv1.ExternalSecretFind) (map[string][]byte, error) {
  268. matcher, err := find.New(*ref.Name)
  269. if err != nil {
  270. return nil, err
  271. }
  272. filters := make([]types.Filter, 0)
  273. if ref.Path != nil {
  274. filters = append(filters, types.Filter{
  275. Key: types.FilterNameStringTypeName,
  276. Values: []string{
  277. *ref.Path,
  278. },
  279. })
  280. return sm.fetchWithBatch(ctx, filters, matcher)
  281. }
  282. data := make(map[string][]byte)
  283. var nextToken *string
  284. for {
  285. // I put this into the for loop on purpose.
  286. log.V(0).Info("using ListSecret to fetch all secrets; this is a costly operations, please use batching by defining a _path_")
  287. it, err := sm.client.ListSecrets(ctx, &awssm.ListSecretsInput{
  288. Filters: filters,
  289. NextToken: nextToken,
  290. })
  291. metrics.ObserveAPICall(constants.ProviderAWSSM, constants.CallAWSSMListSecrets, err)
  292. if err != nil {
  293. return nil, err
  294. }
  295. log.V(1).Info("aws sm findByName found", "secrets", len(it.SecretList))
  296. for _, secret := range it.SecretList {
  297. if !matcher.MatchName(*secret.Name) {
  298. continue
  299. }
  300. log.V(1).Info("aws sm findByName matches", "name", *secret.Name)
  301. if err := sm.fetchAndSet(ctx, data, *secret.Name); err != nil {
  302. return nil, err
  303. }
  304. }
  305. nextToken = it.NextToken
  306. if nextToken == nil {
  307. break
  308. }
  309. }
  310. return data, nil
  311. }
  312. func (sm *SecretsManager) findByTags(ctx context.Context, ref esv1.ExternalSecretFind) (map[string][]byte, error) {
  313. filters := make([]types.Filter, 0)
  314. for k, v := range ref.Tags {
  315. filters = append(filters, types.Filter{
  316. Key: types.FilterNameStringTypeTagKey,
  317. Values: []string{
  318. k,
  319. },
  320. }, types.Filter{
  321. Key: types.FilterNameStringTypeTagValue,
  322. Values: []string{
  323. v,
  324. },
  325. })
  326. }
  327. if ref.Path != nil {
  328. filters = append(filters, types.Filter{
  329. Key: types.FilterNameStringTypeName,
  330. Values: []string{
  331. *ref.Path,
  332. },
  333. })
  334. }
  335. return sm.fetchWithBatch(ctx, filters, nil)
  336. }
  337. func (sm *SecretsManager) fetchAndSet(ctx context.Context, data map[string][]byte, name string) error {
  338. sec, err := sm.fetch(ctx, esv1.ExternalSecretDataRemoteRef{
  339. Key: name,
  340. })
  341. if err != nil {
  342. return err
  343. }
  344. if sec.SecretString != nil {
  345. data[name] = []byte(*sec.SecretString)
  346. }
  347. if sec.SecretBinary != nil {
  348. data[name] = sec.SecretBinary
  349. }
  350. return nil
  351. }
  352. // GetSecret returns a single secret from the provider.
  353. func (sm *SecretsManager) GetSecret(ctx context.Context, ref esv1.ExternalSecretDataRemoteRef) ([]byte, error) {
  354. secretOut, err := sm.fetch(ctx, ref)
  355. if errors.Is(err, esv1.NoSecretErr) {
  356. return nil, err
  357. }
  358. if err != nil {
  359. return nil, util.SanitizeErr(err)
  360. }
  361. if ref.Property == "" {
  362. if secretOut.SecretString != nil {
  363. return []byte(*secretOut.SecretString), nil
  364. }
  365. if secretOut.SecretBinary != nil {
  366. return secretOut.SecretBinary, nil
  367. }
  368. return nil, fmt.Errorf("invalid secret received. no secret string nor binary for key: %s", ref.Key)
  369. }
  370. val := sm.mapSecretToGjson(secretOut, ref.Property)
  371. if !val.Exists() {
  372. return nil, fmt.Errorf("key %s does not exist in secret %s", ref.Property, ref.Key)
  373. }
  374. return []byte(val.String()), nil
  375. }
  376. func (sm *SecretsManager) mapSecretToGjson(secretOut *awssm.GetSecretValueOutput, property string) gjson.Result {
  377. payload := sm.retrievePayload(secretOut)
  378. refProperty := sm.escapeDotsIfRequired(property, payload)
  379. val := gjson.Get(payload, refProperty)
  380. return val
  381. }
  382. func (sm *SecretsManager) retrievePayload(secretOut *awssm.GetSecretValueOutput) string {
  383. if secretOut == nil {
  384. return ""
  385. }
  386. var payload string
  387. if secretOut.SecretString != nil {
  388. payload = *secretOut.SecretString
  389. }
  390. if secretOut.SecretBinary != nil {
  391. payload = string(secretOut.SecretBinary)
  392. }
  393. return payload
  394. }
  395. func (sm *SecretsManager) escapeDotsIfRequired(currentRefProperty, payload string) string {
  396. // We need to search if a given key with a . exists before using gjson operations.
  397. idx := strings.Index(currentRefProperty, ".")
  398. refProperty := currentRefProperty
  399. if idx > -1 {
  400. refProperty = strings.ReplaceAll(currentRefProperty, ".", "\\.")
  401. val := gjson.Get(payload, refProperty)
  402. if !val.Exists() {
  403. refProperty = currentRefProperty
  404. }
  405. }
  406. return refProperty
  407. }
  408. // GetSecretMap returns multiple k/v pairs from the provider.
  409. func (sm *SecretsManager) GetSecretMap(ctx context.Context, ref esv1.ExternalSecretDataRemoteRef) (map[string][]byte, error) {
  410. log.Info("fetching secret map", "key", ref.Key)
  411. data, err := sm.GetSecret(ctx, ref)
  412. if err != nil {
  413. return nil, err
  414. }
  415. kv := make(map[string]json.RawMessage)
  416. err = json.Unmarshal(data, &kv)
  417. if err != nil {
  418. return nil, fmt.Errorf("unable to unmarshal secret %s: %w", ref.Key, err)
  419. }
  420. secretData := make(map[string][]byte)
  421. for k, v := range kv {
  422. var strVal string
  423. err = json.Unmarshal(v, &strVal)
  424. if err == nil {
  425. secretData[k] = []byte(strVal)
  426. } else {
  427. secretData[k] = v
  428. }
  429. }
  430. return secretData, nil
  431. }
  432. func (sm *SecretsManager) Close(_ context.Context) error {
  433. return nil
  434. }
  435. func (sm *SecretsManager) Validate() (esv1.ValidationResult, error) {
  436. // skip validation stack because it depends on the namespace
  437. // of the ExternalSecret
  438. if sm.referentAuth {
  439. return esv1.ValidationResultUnknown, nil
  440. }
  441. _, err := sm.cfg.Credentials.Retrieve(context.Background())
  442. if err != nil {
  443. return esv1.ValidationResultError, util.SanitizeErr(err)
  444. }
  445. return esv1.ValidationResultReady, nil
  446. }
  447. func (sm *SecretsManager) Capabilities() esv1.SecretStoreCapabilities {
  448. return esv1.SecretStoreReadWrite
  449. }
  450. func (sm *SecretsManager) createSecretWithContext(ctx context.Context, secretName string, psd esv1.PushSecretData, value []byte) error {
  451. mdata, err := sm.constructMetadataWithDefaults(psd.GetMetadata())
  452. if err != nil {
  453. return fmt.Errorf("failed to parse push secret metadata: %w", err)
  454. }
  455. tags := make([]types.Tag, 0)
  456. for k, v := range mdata.Spec.Tags {
  457. tags = append(tags, types.Tag{
  458. Key: utilpointer.To(k),
  459. Value: utilpointer.To(v),
  460. })
  461. }
  462. input := &awssm.CreateSecretInput{
  463. Name: &secretName,
  464. SecretBinary: value,
  465. Tags: tags,
  466. Description: utilpointer.To(mdata.Spec.Description),
  467. ClientRequestToken: utilpointer.To(initialVersion),
  468. KmsKeyId: utilpointer.To(mdata.Spec.KMSKeyID),
  469. }
  470. if mdata.Spec.SecretPushFormat == SecretPushFormatString {
  471. input.SecretBinary = nil
  472. input.SecretString = aws.String(string(value))
  473. }
  474. _, err = sm.client.CreateSecret(ctx, input)
  475. metrics.ObserveAPICall(constants.ProviderAWSSM, constants.CallAWSSMCreateSecret, err)
  476. return err
  477. }
  478. func (sm *SecretsManager) putSecretValueWithContext(ctx context.Context, secretArn string, awsSecret *awssm.GetSecretValueOutput, psd esv1.PushSecretData, value []byte, tags []types.Tag) error {
  479. if awsSecret != nil && (bytes.Equal(awsSecret.SecretBinary, value) || utils.CompareStringAndByteSlices(awsSecret.SecretString, value)) {
  480. return nil
  481. }
  482. newVersionNumber := initialVersion
  483. if awsSecret != nil {
  484. if sm.newUUID == nil {
  485. newVersionNumber = uuid.NewString()
  486. } else {
  487. newVersionNumber = sm.newUUID()
  488. }
  489. }
  490. input := &awssm.PutSecretValueInput{
  491. SecretId: &secretArn,
  492. SecretBinary: value,
  493. ClientRequestToken: aws.String(newVersionNumber),
  494. }
  495. secretPushFormat, err := utils.FetchValueFromMetadata(SecretPushFormatKey, psd.GetMetadata(), SecretPushFormatBinary)
  496. if err != nil {
  497. return fmt.Errorf("failed to parse metadata: %w", err)
  498. }
  499. if secretPushFormat == SecretPushFormatString {
  500. input.SecretBinary = nil
  501. input.SecretString = aws.String(string(value))
  502. }
  503. _, err = sm.client.PutSecretValue(ctx, input)
  504. metrics.ObserveAPICall(constants.ProviderAWSSM, constants.CallAWSSMPutSecretValue, err)
  505. if err != nil {
  506. return err
  507. }
  508. currentTags := make(map[string]string, len(tags))
  509. for _, tag := range tags {
  510. currentTags[*tag.Key] = *tag.Value
  511. }
  512. return sm.patchTags(ctx, psd.GetMetadata(), &secretArn, currentTags)
  513. }
  514. func (sm *SecretsManager) patchTags(ctx context.Context, metadata *apiextensionsv1.JSON, secretId *string, tags map[string]string) error {
  515. meta, err := sm.constructMetadataWithDefaults(metadata)
  516. if err != nil {
  517. return err
  518. }
  519. tagKeysToRemove := util.FindTagKeysToRemove(tags, meta.Spec.Tags)
  520. if len(tagKeysToRemove) > 0 {
  521. _, err = sm.client.UntagResource(ctx, &awssm.UntagResourceInput{
  522. SecretId: secretId,
  523. TagKeys: tagKeysToRemove,
  524. })
  525. metrics.ObserveAPICall(constants.ProviderAWSSM, constants.CallAWSSMUntagResource, err)
  526. if err != nil {
  527. return err
  528. }
  529. }
  530. tagsToUpdate, isModified := computeTagsToUpdate(tags, meta.Spec.Tags)
  531. if isModified {
  532. _, err = sm.client.TagResource(ctx, &awssm.TagResourceInput{
  533. SecretId: secretId,
  534. Tags: tagsToUpdate,
  535. })
  536. metrics.ObserveAPICall(constants.ProviderAWSSM, constants.CallAWSSMTagResource, err)
  537. if err != nil {
  538. return err
  539. }
  540. }
  541. return nil
  542. }
  543. func (sm *SecretsManager) fetchWithBatch(ctx context.Context, filters []types.Filter, matcher *find.Matcher) (map[string][]byte, error) {
  544. data := make(map[string][]byte)
  545. var nextToken *string
  546. for {
  547. it, err := sm.client.BatchGetSecretValue(ctx, &awssm.BatchGetSecretValueInput{
  548. Filters: filters,
  549. NextToken: nextToken,
  550. })
  551. metrics.ObserveAPICall(constants.ProviderAWSSM, constants.CallAWSSMBatchGetSecretValue, err)
  552. if err != nil {
  553. return nil, err
  554. }
  555. log.V(1).Info("aws sm findByName found", "secrets", len(it.SecretValues))
  556. for _, secret := range it.SecretValues {
  557. if matcher != nil && !matcher.MatchName(*secret.Name) {
  558. continue
  559. }
  560. log.V(1).Info("aws sm findByName matches", "name", *secret.Name)
  561. sm.setSecretValues(&secret, data)
  562. }
  563. nextToken = it.NextToken
  564. if nextToken == nil {
  565. break
  566. }
  567. }
  568. return data, nil
  569. }
  570. func (sm *SecretsManager) setSecretValues(secret *types.SecretValueEntry, data map[string][]byte) {
  571. if secret.SecretString != nil {
  572. data[*secret.Name] = []byte(*secret.SecretString)
  573. }
  574. if secret.SecretBinary != nil {
  575. data[*secret.Name] = secret.SecretBinary
  576. }
  577. }
  578. func (sm *SecretsManager) constructSecretValue(ctx context.Context, key, ver string, metadataPolicy esv1.ExternalSecretMetadataPolicy) (*awssm.GetSecretValueOutput, error) {
  579. if metadataPolicy == esv1.ExternalSecretMetadataPolicyFetch {
  580. describeSecretInput := &awssm.DescribeSecretInput{
  581. SecretId: &key,
  582. }
  583. descOutput, err := sm.client.DescribeSecret(ctx, describeSecretInput)
  584. if err != nil {
  585. return nil, err
  586. }
  587. log.Info("found metadata secret", "key", key, "output", descOutput)
  588. jsonTags, err := util.SecretTagsToJSONString(descOutput.Tags)
  589. if err != nil {
  590. return nil, err
  591. }
  592. return &awssm.GetSecretValueOutput{
  593. ARN: descOutput.ARN,
  594. CreatedDate: descOutput.CreatedDate,
  595. Name: descOutput.Name,
  596. SecretString: &jsonTags,
  597. VersionId: &ver,
  598. }, nil
  599. }
  600. var getSecretValueInput *awssm.GetSecretValueInput
  601. if strings.HasPrefix(ver, "uuid/") {
  602. versionID := strings.TrimPrefix(ver, "uuid/")
  603. getSecretValueInput = &awssm.GetSecretValueInput{
  604. SecretId: &key,
  605. VersionId: &versionID,
  606. }
  607. } else {
  608. getSecretValueInput = &awssm.GetSecretValueInput{
  609. SecretId: &key,
  610. VersionStage: &ver,
  611. }
  612. }
  613. secretOut, err := sm.client.GetSecretValue(ctx, getSecretValueInput)
  614. metrics.ObserveAPICall(constants.ProviderAWSSM, constants.CallAWSSMGetSecretValue, err)
  615. var (
  616. nf *types.ResourceNotFoundException
  617. ie *types.InvalidParameterException
  618. )
  619. if errors.As(err, &nf) {
  620. return nil, esv1.NoSecretErr
  621. }
  622. if errors.As(err, &ie) && strings.Contains(ie.Error(), "was marked for deletion") {
  623. return nil, esv1.NoSecretErr
  624. }
  625. return secretOut, err
  626. }
  627. func (sm *SecretsManager) constructMetadataWithDefaults(data *apiextensionsv1.JSON) (*metadata.PushSecretMetadata[PushSecretMetadataSpec], error) {
  628. var (
  629. meta *metadata.PushSecretMetadata[PushSecretMetadataSpec]
  630. err error
  631. )
  632. meta, err = metadata.ParseMetadataParameters[PushSecretMetadataSpec](data)
  633. if err != nil {
  634. return nil, fmt.Errorf("failed to parse metadata: %w", err)
  635. }
  636. if meta == nil {
  637. meta = &metadata.PushSecretMetadata[PushSecretMetadataSpec]{}
  638. }
  639. if meta.Spec.SecretPushFormat == "" {
  640. meta.Spec.SecretPushFormat = SecretPushFormatBinary
  641. } else if !slices.Contains([]string{SecretPushFormatBinary, SecretPushFormatString}, meta.Spec.SecretPushFormat) {
  642. return nil, fmt.Errorf("invalid secret push format: %s", meta.Spec.SecretPushFormat)
  643. }
  644. if meta.Spec.Description == "" {
  645. meta.Spec.Description = fmt.Sprintf("secret '%s:%s'", managedBy, externalSecrets)
  646. }
  647. if meta.Spec.KMSKeyID == "" {
  648. meta.Spec.KMSKeyID = "alias/aws/secretsmanager"
  649. }
  650. if len(meta.Spec.Tags) > 0 {
  651. if _, exists := meta.Spec.Tags[managedBy]; exists {
  652. return nil, fmt.Errorf("error parsing tags in metadata: Cannot specify a '%s' tag", managedBy)
  653. }
  654. } else {
  655. meta.Spec.Tags = make(map[string]string)
  656. }
  657. meta.Spec.Tags[managedBy] = externalSecrets
  658. return meta, nil
  659. }
  660. // computeTagsToUpdate compares the current tags with the desired metaTags and returns a slice of ssmTypes.Tag
  661. // that should be set on the resource. It also returns a boolean indicating if any tag was added or modified.
  662. func computeTagsToUpdate(tags, metaTags map[string]string) ([]types.Tag, bool) {
  663. result := make([]types.Tag, 0, len(metaTags))
  664. modified := false
  665. for k, v := range metaTags {
  666. if _, exists := tags[k]; !exists || tags[k] != v {
  667. if k != managedBy {
  668. modified = true
  669. }
  670. }
  671. result = append(result, types.Tag{
  672. Key: utilpointer.To(k),
  673. Value: utilpointer.To(v),
  674. })
  675. }
  676. return result, modified
  677. }