keyvault.go 32 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528529530531532533534535536537538539540541542543544545546547548549550551552553554555556557558559560561562563564565566567568569570571572573574575576577578579580581582583584585586587588589590591592593594595596597598599600601602603604605606607608609610611612613614615616617618619620621622623624625626627628629630631632633634635636637638639640641642643644645646647648649650651652653654655656657658659660661662663664665666667668669670671672673674675676677678679680681682683684685686687688689690691692693694695696697698699700701702703704705706707708709710711712713714715716717718719720721722723724725726727728729730731732733734735736737738739740741742743744745746747748749750751752753754755756757758759760761762763764765766767768769770771772773774775776777778779780781782783784785786787788789790791792793794795796797798799800801802803804805806807808809810811812813814815816817818819820821822823824825826827828829830831832833834835836837838839840841842843844845846847848849850851852853854855856857858859860861862863864865866867868869870871872873874875876877878879880881882883884885886887888889890891892893894895896897898899900901902903904905906907908909910911912913914915916917918919920921922923924925926927928929930931932933934935936937938939940941942943944945946947948949950951952953954955956957958959960961962963964965966967968969970971972973974975976977978979980981982983984985986987988989990991992
  1. /*
  2. Licensed under the Apache License, Version 2.0 (the "License");
  3. you may not use this file except in compliance with the License.
  4. You may obtain a copy of the License at
  5. http://www.apache.org/licenses/LICENSE-2.0
  6. Unless required by applicable law or agreed to in writing, software
  7. distributed under the License is distributed on an "AS IS" BASIS,
  8. WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
  9. See the License for the specific language governing permissions and
  10. limitations under the License.
  11. */
  12. package keyvault
  13. import (
  14. "context"
  15. "crypto/x509"
  16. b64 "encoding/base64"
  17. "encoding/json"
  18. "encoding/pem"
  19. "errors"
  20. "fmt"
  21. "os"
  22. "path"
  23. "regexp"
  24. "strings"
  25. "github.com/Azure/azure-sdk-for-go/profiles/latest/keyvault/keyvault"
  26. "github.com/Azure/go-autorest/autorest"
  27. "github.com/Azure/go-autorest/autorest/adal"
  28. "github.com/Azure/go-autorest/autorest/azure"
  29. kvauth "github.com/Azure/go-autorest/autorest/azure/auth"
  30. "github.com/AzureAD/microsoft-authentication-library-for-go/apps/confidential"
  31. "github.com/lestrrat-go/jwx/jwk"
  32. "github.com/tidwall/gjson"
  33. "golang.org/x/crypto/pkcs12"
  34. "golang.org/x/crypto/sha3"
  35. authv1 "k8s.io/api/authentication/v1"
  36. corev1 "k8s.io/api/core/v1"
  37. metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
  38. "k8s.io/apimachinery/pkg/types"
  39. "k8s.io/client-go/kubernetes"
  40. kcorev1 "k8s.io/client-go/kubernetes/typed/core/v1"
  41. "k8s.io/utils/pointer"
  42. "sigs.k8s.io/controller-runtime/pkg/client"
  43. ctrlcfg "sigs.k8s.io/controller-runtime/pkg/client/config"
  44. esv1beta1 "github.com/external-secrets/external-secrets/apis/externalsecrets/v1beta1"
  45. smmeta "github.com/external-secrets/external-secrets/apis/meta/v1"
  46. "github.com/external-secrets/external-secrets/pkg/utils"
  47. )
  48. const (
  49. defaultObjType = "secret"
  50. objectTypeCert = "cert"
  51. objectTypeKey = "key"
  52. AzureDefaultAudience = "api://AzureADTokenExchange"
  53. AnnotationClientID = "azure.workload.identity/client-id"
  54. AnnotationTenantID = "azure.workload.identity/tenant-id"
  55. managerLabel = "external-secrets"
  56. errUnexpectedStoreSpec = "unexpected store spec"
  57. errMissingAuthType = "cannot initialize Azure Client: no valid authType was specified"
  58. errPropNotExist = "property %s does not exist in key %s"
  59. errTagNotExist = "tag %s does not exist"
  60. errUnknownObjectType = "unknown Azure Keyvault object Type for %s"
  61. errUnmarshalJSONData = "error unmarshalling json data: %w"
  62. errDataFromCert = "cannot get use dataFrom to get certificate secret"
  63. errDataFromKey = "cannot get use dataFrom to get key secret"
  64. errMissingTenant = "missing tenantID in store config"
  65. errMissingSecretRef = "missing secretRef in provider config"
  66. errMissingClientIDSecret = "missing accessKeyID/secretAccessKey in store config"
  67. errFindSecret = "could not find secret %s/%s: %w"
  68. errFindDataKey = "no data for %q in secret '%s/%s'"
  69. errInvalidStore = "invalid store"
  70. errInvalidStoreSpec = "invalid store spec"
  71. errInvalidStoreProv = "invalid store provider"
  72. errInvalidAzureProv = "invalid azure keyvault provider"
  73. errInvalidSecRefClientID = "invalid AuthSecretRef.ClientID: %w"
  74. errInvalidSecRefClientSecret = "invalid AuthSecretRef.ClientSecret: %w"
  75. errInvalidSARef = "invalid ServiceAccountRef: %w"
  76. errMissingWorkloadEnvVars = "missing environment variables. AZURE_CLIENT_ID, AZURE_TENANT_ID and AZURE_FEDERATED_TOKEN_FILE must be set"
  77. errReadTokenFile = "unable to read token file %s: %w"
  78. errMissingSAAnnotation = "missing service account annotation: %s"
  79. )
  80. // https://github.com/external-secrets/external-secrets/issues/644
  81. var _ esv1beta1.SecretsClient = &Azure{}
  82. var _ esv1beta1.Provider = &Azure{}
  83. // interface to keyvault.BaseClient.
  84. type SecretClient interface {
  85. GetKey(ctx context.Context, vaultBaseURL string, keyName string, keyVersion string) (result keyvault.KeyBundle, err error)
  86. GetSecret(ctx context.Context, vaultBaseURL string, secretName string, secretVersion string) (result keyvault.SecretBundle, err error)
  87. GetSecretsComplete(ctx context.Context, vaultBaseURL string, maxresults *int32) (result keyvault.SecretListResultIterator, err error)
  88. GetCertificate(ctx context.Context, vaultBaseURL string, certificateName string, certificateVersion string) (result keyvault.CertificateBundle, err error)
  89. SetSecret(ctx context.Context, vaultBaseURL string, secretName string, parameters keyvault.SecretSetParameters) (result keyvault.SecretBundle, err error)
  90. ImportKey(ctx context.Context, vaultBaseURL string, keyName string, parameters keyvault.KeyImportParameters) (result keyvault.KeyBundle, err error)
  91. ImportCertificate(ctx context.Context, vaultBaseURL string, certificateName string, parameters keyvault.CertificateImportParameters) (result keyvault.CertificateBundle, err error)
  92. DeleteCertificate(ctx context.Context, vaultBaseURL string, certificateName string) (result keyvault.DeletedCertificateBundle, err error)
  93. DeleteKey(ctx context.Context, vaultBaseURL string, keyName string) (result keyvault.DeletedKeyBundle, err error)
  94. DeleteSecret(ctx context.Context, vaultBaseURL string, secretName string) (result keyvault.DeletedSecretBundle, err error)
  95. }
  96. type Azure struct {
  97. crClient client.Client
  98. kubeClient kcorev1.CoreV1Interface
  99. store esv1beta1.GenericStore
  100. provider *esv1beta1.AzureKVProvider
  101. baseClient SecretClient
  102. namespace string
  103. }
  104. func init() {
  105. esv1beta1.Register(&Azure{}, &esv1beta1.SecretStoreProvider{
  106. AzureKV: &esv1beta1.AzureKVProvider{},
  107. })
  108. }
  109. // Capabilities return the provider supported capabilities (ReadOnly, WriteOnly, ReadWrite).
  110. func (a *Azure) Capabilities() esv1beta1.SecretStoreCapabilities {
  111. return esv1beta1.SecretStoreReadOnly
  112. }
  113. // NewClient constructs a new secrets client based on the provided store.
  114. func (a *Azure) NewClient(ctx context.Context, store esv1beta1.GenericStore, kube client.Client, namespace string) (esv1beta1.SecretsClient, error) {
  115. return newClient(ctx, store, kube, namespace)
  116. }
  117. func newClient(ctx context.Context, store esv1beta1.GenericStore, kube client.Client, namespace string) (esv1beta1.SecretsClient, error) {
  118. provider, err := getProvider(store)
  119. if err != nil {
  120. return nil, err
  121. }
  122. cfg, err := ctrlcfg.GetConfig()
  123. if err != nil {
  124. return nil, err
  125. }
  126. kubeClient, err := kubernetes.NewForConfig(cfg)
  127. if err != nil {
  128. return nil, err
  129. }
  130. az := &Azure{
  131. crClient: kube,
  132. kubeClient: kubeClient.CoreV1(),
  133. store: store,
  134. namespace: namespace,
  135. provider: provider,
  136. }
  137. // allow SecretStore controller validation to pass
  138. // when using referent namespace.
  139. if store.GetKind() == esv1beta1.ClusterSecretStoreKind &&
  140. namespace == "" &&
  141. isReferentSpec(provider) {
  142. return az, nil
  143. }
  144. var authorizer autorest.Authorizer
  145. switch *provider.AuthType {
  146. case esv1beta1.AzureManagedIdentity:
  147. authorizer, err = az.authorizerForManagedIdentity()
  148. case esv1beta1.AzureServicePrincipal:
  149. authorizer, err = az.authorizerForServicePrincipal(ctx)
  150. case esv1beta1.AzureWorkloadIdentity:
  151. authorizer, err = az.authorizerForWorkloadIdentity(ctx, NewTokenProvider)
  152. default:
  153. err = fmt.Errorf(errMissingAuthType)
  154. }
  155. cl := keyvault.New()
  156. cl.Authorizer = authorizer
  157. az.baseClient = &cl
  158. return az, err
  159. }
  160. func getProvider(store esv1beta1.GenericStore) (*esv1beta1.AzureKVProvider, error) {
  161. spc := store.GetSpec()
  162. if spc == nil || spc.Provider.AzureKV == nil {
  163. return nil, errors.New(errUnexpectedStoreSpec)
  164. }
  165. return spc.Provider.AzureKV, nil
  166. }
  167. func (a *Azure) ValidateStore(store esv1beta1.GenericStore) error {
  168. if store == nil {
  169. return fmt.Errorf(errInvalidStore)
  170. }
  171. spc := store.GetSpec()
  172. if spc == nil {
  173. return fmt.Errorf(errInvalidStoreSpec)
  174. }
  175. if spc.Provider == nil {
  176. return fmt.Errorf(errInvalidStoreProv)
  177. }
  178. p := spc.Provider.AzureKV
  179. if p == nil {
  180. return fmt.Errorf(errInvalidAzureProv)
  181. }
  182. if p.AuthSecretRef != nil {
  183. if p.AuthSecretRef.ClientID != nil {
  184. if err := utils.ValidateReferentSecretSelector(store, *p.AuthSecretRef.ClientID); err != nil {
  185. return fmt.Errorf(errInvalidSecRefClientID, err)
  186. }
  187. }
  188. if p.AuthSecretRef.ClientSecret != nil {
  189. if err := utils.ValidateReferentSecretSelector(store, *p.AuthSecretRef.ClientSecret); err != nil {
  190. return fmt.Errorf(errInvalidSecRefClientSecret, err)
  191. }
  192. }
  193. }
  194. if p.ServiceAccountRef != nil {
  195. if err := utils.ValidateReferentServiceAccountSelector(store, *p.ServiceAccountRef); err != nil {
  196. return fmt.Errorf(errInvalidSARef, err)
  197. }
  198. }
  199. return nil
  200. }
  201. func canDelete(tags map[string]*string, err error) (bool, error) {
  202. aerr := &autorest.DetailedError{}
  203. conv := errors.As(err, aerr)
  204. if err != nil && !conv {
  205. return false, fmt.Errorf("could not parse error: %w", err)
  206. }
  207. if conv && aerr.StatusCode != 404 { // Secret is already deleted, nothing to do.
  208. return false, fmt.Errorf("unexpected api error: %w", err)
  209. }
  210. if aerr.StatusCode == 404 {
  211. return false, nil
  212. }
  213. manager, ok := tags["managed-by"]
  214. if !ok || manager == nil || *manager != managerLabel {
  215. return false, fmt.Errorf("not managed by external-secrets")
  216. }
  217. return true, nil
  218. }
  219. func (a *Azure) deleteKeyVaultKey(ctx context.Context, keyName string) error {
  220. value, err := a.baseClient.GetKey(ctx, *a.provider.VaultURL, keyName, "")
  221. ok, err := canDelete(value.Tags, err)
  222. if err != nil {
  223. return fmt.Errorf("error getting key %v: %w", keyName, err)
  224. }
  225. if ok {
  226. _, err = a.baseClient.DeleteKey(ctx, *a.provider.VaultURL, keyName)
  227. if err != nil {
  228. return fmt.Errorf("error deleting key %v: %w", keyName, err)
  229. }
  230. }
  231. return nil
  232. }
  233. func (a *Azure) deleteKeyVaultSecret(ctx context.Context, secretName string) error {
  234. value, err := a.baseClient.GetSecret(ctx, *a.provider.VaultURL, secretName, "")
  235. ok, err := canDelete(value.Tags, err)
  236. if err != nil {
  237. return fmt.Errorf("error getting secret %v: %w", secretName, err)
  238. }
  239. if ok {
  240. _, err = a.baseClient.DeleteSecret(ctx, *a.provider.VaultURL, secretName)
  241. if err != nil {
  242. return fmt.Errorf("error deleting secret %v: %w", secretName, err)
  243. }
  244. }
  245. return nil
  246. }
  247. func (a *Azure) deleteKeyVaultCertificate(ctx context.Context, certName string) error {
  248. value, err := a.baseClient.GetCertificate(ctx, *a.provider.VaultURL, certName, "")
  249. ok, err := canDelete(value.Tags, err)
  250. if err != nil {
  251. return fmt.Errorf("error getting certificate %v: %w", certName, err)
  252. }
  253. if ok {
  254. _, err = a.baseClient.DeleteCertificate(ctx, *a.provider.VaultURL, certName)
  255. if err != nil {
  256. return fmt.Errorf("error deleting certificate %v: %w", certName, err)
  257. }
  258. }
  259. return nil
  260. }
  261. func (a *Azure) DeleteSecret(ctx context.Context, remoteRef esv1beta1.PushRemoteRef) error {
  262. objectType, secretName := getObjType(esv1beta1.ExternalSecretDataRemoteRef{Key: remoteRef.GetRemoteKey()})
  263. switch objectType {
  264. case defaultObjType:
  265. return a.deleteKeyVaultSecret(ctx, secretName)
  266. case objectTypeCert:
  267. return a.deleteKeyVaultCertificate(ctx, secretName)
  268. case objectTypeKey:
  269. return a.deleteKeyVaultKey(ctx, secretName)
  270. default:
  271. return fmt.Errorf("secret type '%v' is not supported", objectType)
  272. }
  273. }
  274. func getCertificateFromValue(value []byte) (*x509.Certificate, error) {
  275. _, localCert, err := pkcs12.Decode(value, "")
  276. if err != nil {
  277. pemBlock, _ := pem.Decode(value)
  278. if pemBlock == nil {
  279. return x509.ParseCertificate(value)
  280. }
  281. return x509.ParseCertificate(pemBlock.Bytes)
  282. }
  283. return localCert, err
  284. }
  285. func getKeyFromValue(value []byte) (interface{}, error) {
  286. val := value
  287. pemBlock, _ := pem.Decode(value)
  288. // if a private key regular expression doesn't match, we should consider this key to be symmetric
  289. if pemBlock == nil {
  290. return val, nil
  291. }
  292. val = pemBlock.Bytes
  293. switch pemBlock.Type {
  294. case "PRIVATE KEY":
  295. return x509.ParsePKCS8PrivateKey(val)
  296. case "RSA PRIVATE KEY":
  297. return x509.ParsePKCS1PrivateKey(val)
  298. case "EC PRIVATE KEY":
  299. return x509.ParseECPrivateKey(val)
  300. default:
  301. return nil, fmt.Errorf("key type %v is not supported", pemBlock.Type)
  302. }
  303. }
  304. func canCreate(tags map[string]*string, err error) (bool, error) {
  305. aerr := &autorest.DetailedError{}
  306. conv := errors.As(err, aerr)
  307. if err != nil && !conv {
  308. return false, fmt.Errorf("could not parse error: %w", err)
  309. }
  310. if conv && aerr.StatusCode != 404 {
  311. return false, fmt.Errorf("unexpected api error: %w", err)
  312. }
  313. if err == nil {
  314. manager, ok := tags["managed-by"]
  315. if !ok || manager == nil || *manager != managerLabel {
  316. return false, fmt.Errorf("not managed by external-secrets")
  317. }
  318. }
  319. return true, nil
  320. }
  321. func (a *Azure) setKeyVaultSecret(ctx context.Context, secretName string, value []byte) error {
  322. secret, err := a.baseClient.GetSecret(ctx, *a.provider.VaultURL, secretName, "")
  323. ok, err := canCreate(secret.Tags, err)
  324. if err != nil {
  325. return fmt.Errorf("cannot get secret %v: %w", secretName, err)
  326. }
  327. if !ok {
  328. return nil
  329. }
  330. val := string(value)
  331. if secret.Value != nil && val == *secret.Value {
  332. return nil
  333. }
  334. secretParams := keyvault.SecretSetParameters{
  335. Value: &val,
  336. Tags: map[string]*string{
  337. "managed-by": pointer.String(managerLabel),
  338. },
  339. SecretAttributes: &keyvault.SecretAttributes{
  340. Enabled: pointer.Bool(true),
  341. },
  342. }
  343. _, err = a.baseClient.SetSecret(ctx, *a.provider.VaultURL, secretName, secretParams)
  344. if err != nil {
  345. return fmt.Errorf("could not set secret %v: %w", secretName, err)
  346. }
  347. return nil
  348. }
  349. func (a *Azure) setKeyVaultCertificate(ctx context.Context, secretName string, value []byte) error {
  350. val := b64.StdEncoding.EncodeToString(value)
  351. localCert, err := getCertificateFromValue(value)
  352. if err != nil {
  353. return fmt.Errorf("value from secret is not a valid certificate: %w", err)
  354. }
  355. cert, err := a.baseClient.GetCertificate(ctx, *a.provider.VaultURL, secretName, "")
  356. ok, err := canCreate(cert.Tags, err)
  357. if err != nil {
  358. return fmt.Errorf("cannot get certificate %v: %w", secretName, err)
  359. }
  360. if !ok {
  361. return nil
  362. }
  363. b512 := sha3.Sum512(localCert.Raw)
  364. if cert.Cer != nil && b512 == sha3.Sum512(*cert.Cer) {
  365. return nil
  366. }
  367. params := keyvault.CertificateImportParameters{
  368. Base64EncodedCertificate: &val,
  369. Tags: map[string]*string{
  370. "managed-by": pointer.String(managerLabel),
  371. },
  372. }
  373. _, err = a.baseClient.ImportCertificate(ctx, *a.provider.VaultURL, secretName, params)
  374. if err != nil {
  375. return fmt.Errorf("could not import certificate %v: %w", secretName, err)
  376. }
  377. return nil
  378. }
  379. func equalKeys(newKey, oldKey keyvault.JSONWebKey) bool {
  380. // checks for everything except KeyID and KeyOps
  381. rsaCheck := newKey.E != nil && oldKey.E != nil && *newKey.E == *oldKey.E &&
  382. newKey.N != nil && oldKey.N != nil && *newKey.N == *oldKey.N
  383. symmetricCheck := newKey.Crv == oldKey.Crv &&
  384. newKey.T != nil && oldKey.T != nil && *newKey.T == *oldKey.T &&
  385. newKey.X != nil && oldKey.X != nil && *newKey.X == *oldKey.X &&
  386. newKey.Y != nil && oldKey.Y != nil && *newKey.Y == *oldKey.Y
  387. return newKey.Kty == oldKey.Kty && (rsaCheck || symmetricCheck)
  388. }
  389. func (a *Azure) setKeyVaultKey(ctx context.Context, secretName string, value []byte) error {
  390. key, err := getKeyFromValue(value)
  391. if err != nil {
  392. return fmt.Errorf("could not load private key %v: %w", secretName, err)
  393. }
  394. jwKey, err := jwk.New(key)
  395. if err != nil {
  396. return fmt.Errorf("failed to generate a JWK from secret %v content: %w", secretName, err)
  397. }
  398. buf, err := json.Marshal(jwKey)
  399. if err != nil {
  400. return fmt.Errorf("error parsing key: %w", err)
  401. }
  402. azkey := keyvault.JSONWebKey{}
  403. err = json.Unmarshal(buf, &azkey)
  404. if err != nil {
  405. return fmt.Errorf("error unmarshalling key: %w", err)
  406. }
  407. keyFromVault, err := a.baseClient.GetKey(ctx, *a.provider.VaultURL, secretName, "")
  408. ok, err := canCreate(keyFromVault.Tags, err)
  409. if err != nil {
  410. return fmt.Errorf("cannot get key %v: %w", secretName, err)
  411. }
  412. if !ok {
  413. return nil
  414. }
  415. if keyFromVault.Key != nil && equalKeys(azkey, *keyFromVault.Key) {
  416. return nil
  417. }
  418. params := keyvault.KeyImportParameters{
  419. Key: &azkey,
  420. KeyAttributes: &keyvault.KeyAttributes{},
  421. Tags: map[string]*string{
  422. "managed-by": pointer.String(managerLabel),
  423. },
  424. }
  425. _, err = a.baseClient.ImportKey(ctx, *a.provider.VaultURL, secretName, params)
  426. if err != nil {
  427. return fmt.Errorf("could not import key %v: %w", secretName, err)
  428. }
  429. return nil
  430. }
  431. // PushSecret stores secrets into a Key vault instance.
  432. func (a *Azure) PushSecret(ctx context.Context, value []byte, remoteRef esv1beta1.PushRemoteRef) error {
  433. objectType, secretName := getObjType(esv1beta1.ExternalSecretDataRemoteRef{Key: remoteRef.GetRemoteKey()})
  434. switch objectType {
  435. case defaultObjType:
  436. return a.setKeyVaultSecret(ctx, secretName, value)
  437. case objectTypeCert:
  438. return a.setKeyVaultCertificate(ctx, secretName, value)
  439. case objectTypeKey:
  440. return a.setKeyVaultKey(ctx, secretName, value)
  441. default:
  442. return fmt.Errorf("secret type %v not supported", objectType)
  443. }
  444. }
  445. // Implements store.Client.GetAllSecrets Interface.
  446. // Retrieves a map[string][]byte with the secret names as key and the secret itself as the calue.
  447. func (a *Azure) GetAllSecrets(ctx context.Context, ref esv1beta1.ExternalSecretFind) (map[string][]byte, error) {
  448. basicClient := a.baseClient
  449. secretsMap := make(map[string][]byte)
  450. checkTags := len(ref.Tags) > 0
  451. checkName := ref.Name != nil && len(ref.Name.RegExp) > 0
  452. secretListIter, err := basicClient.GetSecretsComplete(context.Background(), *a.provider.VaultURL, nil)
  453. err = parseError(err)
  454. if err != nil {
  455. return nil, err
  456. }
  457. for secretListIter.NotDone() {
  458. secretList := secretListIter.Response().Value
  459. for _, secret := range *secretList {
  460. ok, secretName := isValidSecret(checkTags, checkName, ref, secret)
  461. if !ok {
  462. continue
  463. }
  464. secretResp, err := basicClient.GetSecret(context.Background(), *a.provider.VaultURL, secretName, "")
  465. err = parseError(err)
  466. if err != nil {
  467. return nil, err
  468. }
  469. secretValue := *secretResp.Value
  470. secretsMap[secretName] = []byte(secretValue)
  471. }
  472. err = secretListIter.Next()
  473. if err != nil {
  474. return nil, err
  475. }
  476. }
  477. return secretsMap, nil
  478. }
  479. // Retrieves a tag value if specified and all tags in JSON format if not.
  480. func getSecretTag(tags map[string]*string, property string) ([]byte, error) {
  481. if property == "" {
  482. secretTagsData := make(map[string]string)
  483. for k, v := range tags {
  484. secretTagsData[k] = *v
  485. }
  486. return json.Marshal(secretTagsData)
  487. }
  488. if val, exist := tags[property]; exist {
  489. return []byte(*val), nil
  490. }
  491. idx := strings.Index(property, ".")
  492. if idx < 0 {
  493. return nil, fmt.Errorf(errTagNotExist, property)
  494. }
  495. if idx > 0 {
  496. tagName := property[0:idx]
  497. if val, exist := tags[tagName]; exist {
  498. key := strings.Replace(property, tagName+".", "", 1)
  499. return getProperty(*val, key, property)
  500. }
  501. }
  502. return nil, fmt.Errorf(errTagNotExist, property)
  503. }
  504. // Retrieves a property value if specified and the secret value if not.
  505. func getProperty(secret, property, key string) ([]byte, error) {
  506. if property == "" {
  507. return []byte(secret), nil
  508. }
  509. res := gjson.Get(secret, property)
  510. if !res.Exists() {
  511. idx := strings.Index(property, ".")
  512. if idx < 0 {
  513. return nil, fmt.Errorf(errPropNotExist, property, key)
  514. }
  515. escaped := strings.ReplaceAll(property, ".", "\\.")
  516. jValue := gjson.Get(secret, escaped)
  517. if jValue.Exists() {
  518. return []byte(jValue.String()), nil
  519. }
  520. return nil, fmt.Errorf(errPropNotExist, property, key)
  521. }
  522. return []byte(res.String()), nil
  523. }
  524. func parseError(err error) error {
  525. aerr := autorest.DetailedError{}
  526. if errors.As(err, &aerr) && aerr.StatusCode == 404 {
  527. return esv1beta1.NoSecretError{}
  528. }
  529. return err
  530. }
  531. // Implements store.Client.GetSecret Interface.
  532. // Retrieves a secret/Key/Certificate/Tag with the secret name defined in ref.Name
  533. // The Object Type is defined as a prefix in the ref.Name , if no prefix is defined , we assume a secret is required.
  534. func (a *Azure) GetSecret(ctx context.Context, ref esv1beta1.ExternalSecretDataRemoteRef) ([]byte, error) {
  535. objectType, secretName := getObjType(ref)
  536. switch objectType {
  537. case defaultObjType:
  538. // returns a SecretBundle with the secret value
  539. // https://pkg.go.dev/github.com/Azure/azure-sdk-for-go/services/keyvault/v7.0/keyvault#SecretBundle
  540. secretResp, err := a.baseClient.GetSecret(context.Background(), *a.provider.VaultURL, secretName, ref.Version)
  541. err = parseError(err)
  542. if err != nil {
  543. return nil, err
  544. }
  545. if ref.MetadataPolicy == esv1beta1.ExternalSecretMetadataPolicyFetch {
  546. return getSecretTag(secretResp.Tags, ref.Property)
  547. }
  548. return getProperty(*secretResp.Value, ref.Property, ref.Key)
  549. case objectTypeCert:
  550. // returns a CertBundle. We return CER contents of x509 certificate
  551. // see: https://pkg.go.dev/github.com/Azure/azure-sdk-for-go/services/keyvault/v7.0/keyvault#CertificateBundle
  552. certResp, err := a.baseClient.GetCertificate(context.Background(), *a.provider.VaultURL, secretName, ref.Version)
  553. err = parseError(err)
  554. if err != nil {
  555. return nil, err
  556. }
  557. if ref.MetadataPolicy == esv1beta1.ExternalSecretMetadataPolicyFetch {
  558. return getSecretTag(certResp.Tags, ref.Property)
  559. }
  560. return *certResp.Cer, nil
  561. case objectTypeKey:
  562. // returns a KeyBundle that contains a jwk
  563. // azure kv returns only public keys
  564. // see: https://pkg.go.dev/github.com/Azure/azure-sdk-for-go/services/keyvault/v7.0/keyvault#KeyBundle
  565. keyResp, err := a.baseClient.GetKey(context.Background(), *a.provider.VaultURL, secretName, ref.Version)
  566. err = parseError(err)
  567. if err != nil {
  568. return nil, err
  569. }
  570. if ref.MetadataPolicy == esv1beta1.ExternalSecretMetadataPolicyFetch {
  571. return getSecretTag(keyResp.Tags, ref.Property)
  572. }
  573. return json.Marshal(keyResp.Key)
  574. }
  575. return nil, fmt.Errorf(errUnknownObjectType, secretName)
  576. }
  577. // returns a SecretBundle with the tags values.
  578. func (a *Azure) getSecretTags(ref esv1beta1.ExternalSecretDataRemoteRef) (map[string]*string, error) {
  579. _, secretName := getObjType(ref)
  580. secretResp, err := a.baseClient.GetSecret(context.Background(), *a.provider.VaultURL, secretName, ref.Version)
  581. err = parseError(err)
  582. if err != nil {
  583. return nil, err
  584. }
  585. secretTagsData := make(map[string]*string)
  586. for tagname, tagval := range secretResp.Tags {
  587. name := secretName + "_" + tagname
  588. kv := make(map[string]string)
  589. err = json.Unmarshal([]byte(*tagval), &kv)
  590. // if the tagvalue is not in JSON format then we added to secretTagsData we added as it is
  591. if err != nil {
  592. secretTagsData[name] = tagval
  593. } else {
  594. for k, v := range kv {
  595. value := v
  596. secretTagsData[name+"_"+k] = &value
  597. }
  598. }
  599. }
  600. return secretTagsData, nil
  601. }
  602. // Implements store.Client.GetSecretMap Interface.
  603. // New version of GetSecretMap.
  604. func (a *Azure) GetSecretMap(ctx context.Context, ref esv1beta1.ExternalSecretDataRemoteRef) (map[string][]byte, error) {
  605. objectType, secretName := getObjType(ref)
  606. switch objectType {
  607. case defaultObjType:
  608. data, err := a.GetSecret(ctx, ref)
  609. if err != nil {
  610. return nil, err
  611. }
  612. if ref.MetadataPolicy == esv1beta1.ExternalSecretMetadataPolicyFetch {
  613. tags, _ := a.getSecretTags(ref)
  614. return getSecretMapProperties(tags, ref.Key, ref.Property), nil
  615. }
  616. return getSecretMapMap(data)
  617. case objectTypeCert:
  618. return nil, fmt.Errorf(errDataFromCert)
  619. case objectTypeKey:
  620. return nil, fmt.Errorf(errDataFromKey)
  621. }
  622. return nil, fmt.Errorf(errUnknownObjectType, secretName)
  623. }
  624. func getSecretMapMap(data []byte) (map[string][]byte, error) {
  625. kv := make(map[string]json.RawMessage)
  626. err := json.Unmarshal(data, &kv)
  627. if err != nil {
  628. return nil, fmt.Errorf(errUnmarshalJSONData, err)
  629. }
  630. secretData := make(map[string][]byte)
  631. for k, v := range kv {
  632. var strVal string
  633. err = json.Unmarshal(v, &strVal)
  634. if err == nil {
  635. secretData[k] = []byte(strVal)
  636. } else {
  637. secretData[k] = v
  638. }
  639. }
  640. return secretData, nil
  641. }
  642. func getSecretMapProperties(tags map[string]*string, key, property string) map[string][]byte {
  643. tagByteArray := make(map[string][]byte)
  644. if property != "" {
  645. keyPropertyName := key + "_" + property
  646. singleTag, _ := getSecretTag(tags, keyPropertyName)
  647. tagByteArray[keyPropertyName] = singleTag
  648. return tagByteArray
  649. }
  650. for k, v := range tags {
  651. tagByteArray[k] = []byte(*v)
  652. }
  653. return tagByteArray
  654. }
  655. func (a *Azure) authorizerForWorkloadIdentity(ctx context.Context, tokenProvider tokenProviderFunc) (autorest.Authorizer, error) {
  656. aadEndpoint := AadEndpointForType(a.provider.EnvironmentType)
  657. kvResource := kvResourceForProviderConfig(a.provider.EnvironmentType)
  658. // if no serviceAccountRef was provided
  659. // we expect certain env vars to be present.
  660. // They are set by the azure workload identity webhook.
  661. if a.provider.ServiceAccountRef == nil {
  662. clientID := os.Getenv("AZURE_CLIENT_ID")
  663. tenantID := os.Getenv("AZURE_TENANT_ID")
  664. tokenFilePath := os.Getenv("AZURE_FEDERATED_TOKEN_FILE")
  665. if clientID == "" || tenantID == "" || tokenFilePath == "" {
  666. return nil, errors.New(errMissingWorkloadEnvVars)
  667. }
  668. token, err := os.ReadFile(tokenFilePath)
  669. if err != nil {
  670. return nil, fmt.Errorf(errReadTokenFile, tokenFilePath, err)
  671. }
  672. tp, err := tokenProvider(ctx, string(token), clientID, tenantID, aadEndpoint, kvResource)
  673. if err != nil {
  674. return nil, err
  675. }
  676. return autorest.NewBearerAuthorizer(tp), nil
  677. }
  678. ns := a.namespace
  679. if a.store.GetKind() == esv1beta1.ClusterSecretStoreKind && a.provider.ServiceAccountRef.Namespace != nil {
  680. ns = *a.provider.ServiceAccountRef.Namespace
  681. }
  682. var sa corev1.ServiceAccount
  683. err := a.crClient.Get(ctx, types.NamespacedName{
  684. Name: a.provider.ServiceAccountRef.Name,
  685. Namespace: ns,
  686. }, &sa)
  687. if err != nil {
  688. return nil, err
  689. }
  690. clientID, ok := sa.ObjectMeta.Annotations[AnnotationClientID]
  691. if !ok {
  692. return nil, fmt.Errorf(errMissingSAAnnotation, AnnotationClientID)
  693. }
  694. tenantID, ok := sa.ObjectMeta.Annotations[AnnotationTenantID]
  695. if !ok {
  696. return nil, fmt.Errorf(errMissingSAAnnotation, AnnotationTenantID)
  697. }
  698. audiences := []string{AzureDefaultAudience}
  699. if len(a.provider.ServiceAccountRef.Audiences) > 0 {
  700. audiences = append(audiences, a.provider.ServiceAccountRef.Audiences...)
  701. }
  702. token, err := FetchSAToken(ctx, ns, a.provider.ServiceAccountRef.Name, audiences, a.kubeClient)
  703. if err != nil {
  704. return nil, err
  705. }
  706. tp, err := tokenProvider(ctx, token, clientID, tenantID, aadEndpoint, kvResource)
  707. if err != nil {
  708. return nil, err
  709. }
  710. return autorest.NewBearerAuthorizer(tp), nil
  711. }
  712. func FetchSAToken(ctx context.Context, ns, name string, audiences []string, kubeClient kcorev1.CoreV1Interface) (string, error) {
  713. token, err := kubeClient.ServiceAccounts(ns).CreateToken(ctx, name, &authv1.TokenRequest{
  714. Spec: authv1.TokenRequestSpec{
  715. Audiences: audiences,
  716. },
  717. }, metav1.CreateOptions{})
  718. if err != nil {
  719. return "", err
  720. }
  721. return token.Status.Token, nil
  722. }
  723. // tokenProvider satisfies the adal.OAuthTokenProvider interface.
  724. type tokenProvider struct {
  725. accessToken string
  726. }
  727. type tokenProviderFunc func(ctx context.Context, token, clientID, tenantID, aadEndpoint, kvResource string) (adal.OAuthTokenProvider, error)
  728. func NewTokenProvider(ctx context.Context, token, clientID, tenantID, aadEndpoint, kvResource string) (adal.OAuthTokenProvider, error) {
  729. // exchange token with Azure AccessToken
  730. cred := confidential.NewCredFromAssertionCallback(func(ctx context.Context, aro confidential.AssertionRequestOptions) (string, error) {
  731. return token, nil
  732. })
  733. cClient, err := confidential.New(clientID, cred, confidential.WithAuthority(
  734. fmt.Sprintf("%s%s/oauth2/token", aadEndpoint, tenantID),
  735. ))
  736. if err != nil {
  737. return nil, err
  738. }
  739. scope := kvResource
  740. // .default needs to be added to the scope
  741. if !strings.Contains(kvResource, ".default") {
  742. scope = fmt.Sprintf("%s/.default", kvResource)
  743. }
  744. authRes, err := cClient.AcquireTokenByCredential(ctx, []string{
  745. scope,
  746. })
  747. if err != nil {
  748. return nil, err
  749. }
  750. return &tokenProvider{
  751. accessToken: authRes.AccessToken,
  752. }, nil
  753. }
  754. func (t *tokenProvider) OAuthToken() string {
  755. return t.accessToken
  756. }
  757. func (a *Azure) authorizerForManagedIdentity() (autorest.Authorizer, error) {
  758. msiConfig := kvauth.NewMSIConfig()
  759. msiConfig.Resource = kvResourceForProviderConfig(a.provider.EnvironmentType)
  760. if a.provider.IdentityID != nil {
  761. msiConfig.ClientID = *a.provider.IdentityID
  762. }
  763. return msiConfig.Authorizer()
  764. }
  765. func (a *Azure) authorizerForServicePrincipal(ctx context.Context) (autorest.Authorizer, error) {
  766. if a.provider.TenantID == nil {
  767. return nil, fmt.Errorf(errMissingTenant)
  768. }
  769. if a.provider.AuthSecretRef == nil {
  770. return nil, fmt.Errorf(errMissingSecretRef)
  771. }
  772. if a.provider.AuthSecretRef.ClientID == nil || a.provider.AuthSecretRef.ClientSecret == nil {
  773. return nil, fmt.Errorf(errMissingClientIDSecret)
  774. }
  775. clusterScoped := false
  776. if a.store.GetKind() == esv1beta1.ClusterSecretStoreKind {
  777. clusterScoped = true
  778. }
  779. cid, err := a.secretKeyRef(ctx, a.namespace, *a.provider.AuthSecretRef.ClientID, clusterScoped)
  780. if err != nil {
  781. return nil, err
  782. }
  783. csec, err := a.secretKeyRef(ctx, a.namespace, *a.provider.AuthSecretRef.ClientSecret, clusterScoped)
  784. if err != nil {
  785. return nil, err
  786. }
  787. clientCredentialsConfig := kvauth.NewClientCredentialsConfig(cid, csec, *a.provider.TenantID)
  788. clientCredentialsConfig.Resource = kvResourceForProviderConfig(a.provider.EnvironmentType)
  789. clientCredentialsConfig.AADEndpoint = AadEndpointForType(a.provider.EnvironmentType)
  790. return clientCredentialsConfig.Authorizer()
  791. }
  792. // secretKeyRef fetch a secret key.
  793. func (a *Azure) secretKeyRef(ctx context.Context, namespace string, secretRef smmeta.SecretKeySelector, clusterScoped bool) (string, error) {
  794. var secret corev1.Secret
  795. ref := types.NamespacedName{
  796. Name: secretRef.Name,
  797. Namespace: namespace,
  798. }
  799. if clusterScoped && secretRef.Namespace != nil {
  800. ref.Namespace = *secretRef.Namespace
  801. }
  802. err := a.crClient.Get(ctx, ref, &secret)
  803. if err != nil {
  804. return "", fmt.Errorf(errFindSecret, ref.Namespace, ref.Name, err)
  805. }
  806. keyBytes, ok := secret.Data[secretRef.Key]
  807. if !ok {
  808. return "", fmt.Errorf(errFindDataKey, secretRef.Key, secretRef.Name, namespace)
  809. }
  810. value := strings.TrimSpace(string(keyBytes))
  811. return value, nil
  812. }
  813. func (a *Azure) Close(ctx context.Context) error {
  814. return nil
  815. }
  816. func (a *Azure) Validate() (esv1beta1.ValidationResult, error) {
  817. if a.store.GetKind() == esv1beta1.ClusterSecretStoreKind && isReferentSpec(a.provider) {
  818. return esv1beta1.ValidationResultUnknown, nil
  819. }
  820. return esv1beta1.ValidationResultReady, nil
  821. }
  822. func isReferentSpec(prov *esv1beta1.AzureKVProvider) bool {
  823. if prov.AuthSecretRef != nil &&
  824. ((prov.AuthSecretRef.ClientID != nil &&
  825. prov.AuthSecretRef.ClientID.Namespace == nil) ||
  826. (prov.AuthSecretRef.ClientSecret != nil &&
  827. prov.AuthSecretRef.ClientSecret.Namespace == nil)) {
  828. return true
  829. }
  830. if prov.ServiceAccountRef != nil &&
  831. prov.ServiceAccountRef.Namespace == nil {
  832. return true
  833. }
  834. return false
  835. }
  836. func AadEndpointForType(t esv1beta1.AzureEnvironmentType) string {
  837. switch t {
  838. case esv1beta1.AzureEnvironmentPublicCloud:
  839. return azure.PublicCloud.ActiveDirectoryEndpoint
  840. case esv1beta1.AzureEnvironmentChinaCloud:
  841. return azure.ChinaCloud.ActiveDirectoryEndpoint
  842. case esv1beta1.AzureEnvironmentUSGovernmentCloud:
  843. return azure.USGovernmentCloud.ActiveDirectoryEndpoint
  844. case esv1beta1.AzureEnvironmentGermanCloud:
  845. return azure.GermanCloud.ActiveDirectoryEndpoint
  846. default:
  847. return azure.PublicCloud.ActiveDirectoryEndpoint
  848. }
  849. }
  850. func kvResourceForProviderConfig(t esv1beta1.AzureEnvironmentType) string {
  851. var res string
  852. switch t {
  853. case esv1beta1.AzureEnvironmentPublicCloud:
  854. res = azure.PublicCloud.KeyVaultEndpoint
  855. case esv1beta1.AzureEnvironmentChinaCloud:
  856. res = azure.ChinaCloud.KeyVaultEndpoint
  857. case esv1beta1.AzureEnvironmentUSGovernmentCloud:
  858. res = azure.USGovernmentCloud.KeyVaultEndpoint
  859. case esv1beta1.AzureEnvironmentGermanCloud:
  860. res = azure.GermanCloud.KeyVaultEndpoint
  861. default:
  862. res = azure.PublicCloud.KeyVaultEndpoint
  863. }
  864. return strings.TrimSuffix(res, "/")
  865. }
  866. func getObjType(ref esv1beta1.ExternalSecretDataRemoteRef) (string, string) {
  867. objectType := defaultObjType
  868. secretName := ref.Key
  869. nameSplitted := strings.Split(secretName, "/")
  870. if len(nameSplitted) > 1 {
  871. objectType = nameSplitted[0]
  872. secretName = nameSplitted[1]
  873. // TODO: later tokens can be used to read the secret tags
  874. }
  875. return objectType, secretName
  876. }
  877. func isValidSecret(checkTags, checkName bool, ref esv1beta1.ExternalSecretFind, secret keyvault.SecretItem) (bool, string) {
  878. if secret.ID == nil || !*secret.Attributes.Enabled {
  879. return false, ""
  880. }
  881. if checkTags && !okByTags(ref, secret) {
  882. return false, ""
  883. }
  884. secretName := path.Base(*secret.ID)
  885. if checkName && !okByName(ref, secretName) {
  886. return false, ""
  887. }
  888. return true, secretName
  889. }
  890. func okByName(ref esv1beta1.ExternalSecretFind, secretName string) bool {
  891. matches, _ := regexp.MatchString(ref.Name.RegExp, secretName)
  892. return matches
  893. }
  894. func okByTags(ref esv1beta1.ExternalSecretFind, secret keyvault.SecretItem) bool {
  895. tagsFound := true
  896. for k, v := range ref.Tags {
  897. if val, ok := secret.Tags[k]; !ok || *val != v {
  898. tagsFound = false
  899. break
  900. }
  901. }
  902. return tagsFound
  903. }